void QGetEnv::VisitStmt()

in src/checks/level0/qgetenv.cpp [34:109]
66 lines of code
22 McCabe index (conditional complexity)

void QGetEnv::VisitStmt(clang::Stmt *stmt)
{
    // Lets check only in function calls. Otherwise there are too many false positives, it's common
    // to implicit cast to bool when checking pointers for validity, like if (ptr)

    auto *memberCall = dyn_cast<CXXMemberCallExpr>(stmt);
    if (!memberCall) {
        return;
    }

    CXXMethodDecl *method = memberCall->getMethodDecl();
    if (!method) {
        return;
    }

    if (const CXXRecordDecl *record = method->getParent(); !record || clazy::name(record) != "QByteArray") {
        return;
    }

    std::vector<CallExpr *> calls = Utils::callListForChain(memberCall);
    if (calls.size() != 2) {
        return;
    }

    CallExpr *qgetEnvCall = calls.back();
    if (const FunctionDecl *func = qgetEnvCall->getDirectCallee(); !func || clazy::name(func) != "qgetenv") {
        return;
    }

    StringRef methodname = clazy::name(method);
    std::string errorMsg;
    std::string replacement;
    bool shouldIncludeOkParameter = false;
    bool changesToBaseAutodetection = false;
    if (methodname == "isEmpty") {
        errorMsg = "qgetenv().isEmpty() allocates.";
        replacement = "qEnvironmentVariableIsEmpty";
    } else if (methodname == "isNull") {
        errorMsg = "qgetenv().isNull() allocates.";
        replacement = "qEnvironmentVariableIsSet";
    } else if (methodname == "toInt") {
        errorMsg = "qgetenv().toInt() is slow.";
        replacement = "qEnvironmentVariableIntValue";
        for (unsigned int i = 0; i < memberCall->getNumArgs(); ++i) {
            auto *arg = memberCall->getArg(i);
            if (i == 0 && !isa<CXXDefaultArgExpr>(arg)) {
                if (!isa<CastExpr>(arg) || !isa<CXXNullPtrLiteralExpr>(dyn_cast<CastExpr>(arg)->getSubExpr())) {
                    shouldIncludeOkParameter = true;
                }
            } else if (i == 1) {
                if (auto *intLiteral = dyn_cast<IntegerLiteral>(arg)) {
                    if (intLiteral->getValue() != 0) {
                        return; // Custom base is specified - ignore this case
                    }
                } else if (isa<CXXDefaultArgExpr>(arg)) {
                    changesToBaseAutodetection = true;
                } else {
                    return; // If the base is neither the 0 literal or the default, skip checking it
                }
            }
        }
    } else {
        return; // Some different method on QByteArray, nothing to warn about
    }

    std::string getEnvArgStr = Lexer::getSourceText(CharSourceRange::getTokenRange(qgetEnvCall->getArg(0)->getSourceRange()), sm(), lo()).str();
    if (shouldIncludeOkParameter) {
        getEnvArgStr += ", " + Lexer::getSourceText(CharSourceRange::getTokenRange(memberCall->getArg(0)->getSourceRange()), sm(), lo()).str();
    }

    errorMsg += " Use " + replacement + "() instead";
    if (changesToBaseAutodetection) {
        errorMsg += ". This uses internally a base of 0, supporting decimal, hex and octal values";
    }
    emitWarning(memberCall->getBeginLoc(), errorMsg, {FixItHint::CreateReplacement(stmt->getSourceRange(), replacement + "(" + getEnvArgStr + ")")});
}