void QVariantTemplateInstantiation::VisitStmt()

in src/checks/manuallevel/qvariant-template-instantiation.cpp [43:108]


void QVariantTemplateInstantiation::VisitStmt(clang::Stmt *stm)
{
    auto *callExpr = dyn_cast<CXXMemberCallExpr>(stm);
    if (!callExpr) {
        return;
    }

    CXXMethodDecl *methodDecl = callExpr->getMethodDecl();
    if (!methodDecl || clazy::name(methodDecl) != "value") {
        return;
    }

    const auto *memberExpr = dyn_cast<MemberExpr>(callExpr->getCallee());
    if (!memberExpr) {
        return;
    }

    const auto *decl = dyn_cast<CXXRecordDecl>(memberExpr->getBase()->getType()->getAsCXXRecordDecl());
    if (!decl || !decl->getDefinition()
        || !(decl->getNameAsString() == "QVariant" || decl->getNameAsString() == "QHash" || decl->getNameAsString() == "QMap")) {
        return;
    }

    if (const auto *specDecl = dyn_cast<ClassTemplateSpecializationDecl>(decl)) {
        if (const auto *templateDecl = specDecl->getSpecializedTemplate()) {
            if (templateDecl->getNameAsString() == "QHash" || templateDecl->getNameAsString() == "QMap") {
                const TemplateArgumentList &templateArgs = specDecl->getTemplateArgs();
                if (!(templateArgs.size() == 2) || !(templateArgs.get(1).getAsType().getAsString() == "QVariant")) {
                    return;
                }
            } else if (templateDecl->getNameAsString() == "QList") {
                const TemplateArgumentList &templateArgs = specDecl->getTemplateArgs();
                if (!(templateArgs.size() == 1) || !(templateArgs.get(0).getAsType().getAsString() == "QVariant")) {
                    return;
                }
            }
        }
    }

    std::vector<QualType> typeList = clazy::getTemplateArgumentsTypes(methodDecl);
    const Type *t = typeList.empty() ? nullptr : typeList[0].getTypePtrOrNull();
    if (!t) {
        return;
    }

    bool matches = false;
    if (t->isBooleanType() || t->isFloatingType() || (t->isIntegerType() && !t->isEnumeralType())) {
        matches = true;
    } else {
        const CXXRecordDecl *recordDecl = t->getAsCXXRecordDecl();
        matches = recordDecl && t->isClassType() && isMatchingClass(clazy::name(recordDecl));
    }

    if (matches) {
        std::string typeName = clazy::simpleTypeName(typeList[0], lo());

        std::string typeName2 = typeName;
        typeName2[0] = toupper(typeName2[0]);

        if (typeName[0] == 'Q') {
            typeName2.erase(0, 1); // Remove first letter
        }
        std::string error = std::string("Use QVariant::to" + typeName2 + "() instead of QVariant::value<" + typeName + ">()");
        emitWarning(stm->getBeginLoc(), error);
    }
}