application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/DataPageToolkit.java (23 lines): - line 172: // FIXME: Should we include the type or not? - line 186: // FIXME: Create FieldAppearance class, similar to TypeAppearence? - line 192: // FIXME: Handle ColorProvider and combined events - line 296: * FIXME: JMC-5125 - This cast chain is scary and should be reworked. - line 407: // FIXME: If we have very short events (nanosecond scale) we can sometimes get a negative range. - line 422: // FIXME: Should make it possible to use the RangePayload[] directly instead - line 568: // FIXME: Make something that can use something other than time as x-axis? - line 576: // FIXME: JMC-4520 - Handle multiple item iterables - line 581: // FIXME: A better way to ensure sorting by endTime - line 664: // FIXME: Refactor to avoid this cast - line 816: // FIXME: This could potentially move into the FilterEditor class - line 851: // FIXME: Move to some AttributeToolkit? - line 858: // FIXME: Would like to always be able to persist a string representation of the attribute, because this is usable by filters. - line 860: // FIXME: Should we always include event type? Does it make any sense, except on the custom pages? - line 862: // FIXME: Transform both START_TIME and END_TIME to LIFETIME? - line 863: // FIXME: Add derived attributes, like a conversion of any THREAD or CLASS attribute? Thread group? - line 874: // FIXME: String or id? - line 925: // FIXME: Should move to FilterEditor, or some subclass/specialization? - line 1038: // FIXME: Add proper logging - line 1107: // TODO: Make more accessible. - line 1108: // TODO: Add support for storing the expansion state in a memento. - line 1109: // TODO: Add input from selection store, output to selection store - line 1110: // TODO: Add toolbar for choosing tree or checkbox tree. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/JfrPropertySheet.java (20 lines): - line 115: // FIXME: fields - units - filters - icons etc. should be handled more properly - line 135: * FIXME: Is this the desired behavior? Discuss and change if necessary. - line 201: // FIXME: Collect type or quantity values? - line 232: // FIXME: Combinations with for example two properties if there are three properties in total shared? - line 274: // FIXME: This is duplicated in EventBrowserPage, where we also create a tooltip for an attribute. - line 304: // FIXME: Merge with TypeHandling.getValueString - line 395: // FIXME: Merge with TypeHandling.getVerboseString - line 428: // FIXME: Should we keep a state for the properties view? - line 445: // FIXME: Break out to other place where these actions are added to menus - line 518: // FIXME: Would it be interesting to add derived attributes here as well? - line 526: // FIXME: List of attributes for the item collection should be provided from elsewhere - line 536: // FIXME: Use a Set> to avoid going through any type more than once. - line 545: // FIXME: Possible remove this filter if we convert this to persistable attributes. - line 559: // FIXME: Calculate common content types from the dstItems, and see if any of the srcItems can deliver them? - line 570: // FIXME: Add combinations here as well, similar to PropertySheetRowSelection.buildFlavors - line 571: // FIXME: Can we get construct a life time filter from start and end times? - line 579: // FIXME: How to order? (currently quantity attributes last). Should we involve relational key attributes? - line 619: // FIXME: Should null values be expected/accepted? - line 650: // FIXME: Should null values be expected/accepted? - line 681: // FIXME: Add more limitations if there are a lot of items? core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/StringDeduplicationRule.java (13 lines): - line 84: // FIXME: These are not all possibilities where the final string internal array is created, so can only use this as a heuristic - line 105: // FIXME: Does it make more sense to have individual liveset/allocation ratio limit and heap usage limits? - line 106: // FIXME: Add a physical memory limit - line 157: // FIXME: Add info about rule preferring object count event, and wanting heap conf or flags... - line 204: // TODO: Check free physical memory? - line 225: // FIXME: Compare to total liveset, committed heap or max heap? - line 241: // FIXME: Which average size estimation method to use? - line 275: // TODO: Calculate in time windows? - line 282: // FIXME: Check if there were any allocations - line 285: // TODO: Improve rule performance by using StacktraceModel instead of filtering each individual item? - line 287: // FIXME: This is a min value, can we calculate a higher value, which is not all the char/byte arrays? - line 291: // FIXME: Check if the stacktrace attribute is enabled - line 327: // FIXME: Return something else if there are no frames application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/ItemChart.java (11 lines): - line 272: // TODO: Allow the user to select type/attribute/aggregator combinations? - line 304: // FIXME: Decide if we want a separate Clear Chart option or not. - line 333: // FIXME: Can we remove histogramSelection and grouped, and instead check if chartItems is actually a histogramSelection? - line 443: // FIXME: Decide if we want a separate Clear Chart option or not. - line 526: // TODO: Can we get for example "Heap Used" as two different line charts, for "Before GC" and "After GC"? - line 543: // TODO: something other than time on x-axis? - line 550: // FIXME: JMC-4520 - Add support for multiple item iterables - line 570: // TODO: allow something other than time on x-axis? - line 578: // FIXME: Different rows, or transparent color? Otherwise total always wins - line 630: // FIXME: What should we have as the default for the items that don't have the attribute? Type? Grey? - line 631: // FIXME: Probably want more colors to choose from here, it's ok if they are not as distinguishable. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/LaneEditor.java (10 lines): - line 124: // FIXME: Do we want to group under categories somehow, or just hide the filters that don't have any existing event types. - line 132: // FIXME: Add a duplicate action? - line 157: // FIXME: Would like to enable editing by some other means than single-clicking, but seems a bit tricky. - line 209: // FIXME: Do we want to use italics for empty lanes? - line 229: // FIXME: Can we potentially reuse this tooltip in the legend as well? - line 269: // FIXME: Add icon - line 303: // FIXME: Can we refresh the filter editor to show that nothing has changed? - line 310: // FIXME: It's currently not possible to delete the last lane - line 460: // FIXME: Should probably warn if filter is not an instance of Types, and possibly handle other type filter variants as well, like TypeMatches. - line 493: // FIXME: Should we react if there are several rest lanes specified, or just ignore the other ones? core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/cpu/HighJvmCpuRule.java (9 lines): - line 67: // FIXME: This rule seems to be a precondition for other rules (Method profiling rules). Remove? - line 98: // FIXME: The implementation seems to assume that all quantities have the same unit - line 108: // FIXME: Should the score be hard-coded to 50 here? - line 120: // FIXME: Just looking at the overall average is not enough (it is recording length dependent) - line 126: // FIXME: Should check how many threads were actually sampled. - line 129: // FIXME: Will checking the cpuItems be correct enough to represent recording length? - line 130: // FIXME: Dependence on recording length is bad - line 139: // FIXME: Should we check the entire recording, or time windows? - line 151: // FIXME: This case (or similar) should be replaced with evaluating the method profiling rule application/org.openjdk.jmc.ide.launch/src/main/java/org/openjdk/jmc/ide/launch/JfrLaunchConfigurationTab.java (9 lines): - line 57: // TODO: Now that we target Eclipse 4, we could also use ILaunchConfigurationTab2, which might have some useful features. - line 70: // FIXME: Make sure to disable this for JDK 6 - line 71: // FIXME: Add timestamp to file? - line 72: // TODO: Show the full commandline (at least in debug mode) - line 73: // TODO: Change the help - line 74: // TODO: Better tooltips? - line 75: // TODO: Status bar plug-in that shows the last 2-3 recordings - line 124: // TODO: Improve this, would be nice to: 1. Not have to set in both gui and model. 2. Not have to deal with all settings separately. - line 194: // FIXME: Fake extra template to suppress message about using Template Manager? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JavaApplicationPage.java (8 lines): - line 126: // FIXME: Does this really have to be so green? - line 167: // FIXME: Decide which columns we should actually have - line 169: // FIXME: Do we want combined samples/balance column here? - line 226: // FIXME: The lanes field is initialized by initializeChartConfiguration which is called by the super constructor. This is too indirect for SpotBugs to resolve and should be simplified. - line 282: // FIXME: Add color based on top frame balance here as well? - line 326: // FIXME: Consider using a custom tooltip instead where the color could be shown graphically. - line 351: // FIXME: JMC-5192 - Should we use the selection even though it might be unchecked? - line 365: // FIXME: Could we return the other type chart items that do not depend on the thread selection, like cpu, heap etc? core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/UnitLookup.java (8 lines): - line 196: // FIXME: Should we add the OLD_OBJECT_* subtypes? - line 263: // FIXME: Doesn't really belong here. For now, make sure to not expose more. - line 302: // FIXME: Define better localized strings - line 309: // FIXME: Define better localized strings - line 399: // FIXME: Verify that scientific and engineering notation formatting works properly. - line 428: // FIXME: Rename to createPrimitiveNumber? Remove? - line 507: // FIXME: LKOQ.AutoFormatter uses IDisplayable.AUTO id which collides with the DualUnitFormatter above. Sync with FLR behavior? - line 611: // FIXME: Parse using UCUM (Unified Code for Units of Measure) syntax instead? Or by only allowing integers? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/HistogramSequence.java (8 lines): - line 94: // FIXME: Should we handle the case of the grouped attribute not being a common one, if someone has manually edited the page config? - line 102: // FIXME: Did not find the attributes, is that bad? Should we log? - line 114: // FIXME: Should we handle the case of the grouped attribute not being a common one, if someone has manually edited the page config? - line 117: // FIXME: if we allow grouping by uncommon, should we be able to combine as well? - line 133: // FIXME: Maybe remove combine grouping, and use checkboxes instead? - line 278: // FIXME: Would like to merge the menu managers and the menu consumers. - line 280: // FIXME: We can't know from here that this is the id, since it's set elsewhere. - line 355: // FIXME: Make this into a set. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/LinearKindOfQuantity.java (7 lines): - line 91: // FIXME: Should not use a SortedSet like TreeSet. It will prevent alias units. - line 101: * FIXME: Find out what this really should be. Might unfortunately be best to do manual - line 134: * FIXME: Specify "best", so that for example a lower value is preferred, and whether the - line 500: // FIXME: Throw QuantityConversionException if quantity is 0? - line 578: * FIXME: Specify "best", so that for example a lower value is preferred, and whether the upper - line 587: // FIXME: Implement properly! - line 591: // FIXME: Reimplement parsing application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/model/EventConfigurationModel.java (7 lines): - line 65: // FIXME: Rename to something more informative, along the lines of the class javadoc description. - line 111: // FIXME: Throw if this is not an EventConfiguration? - line 147: // FIXME: When we do override, should we clear the categories that only exist in the JFC? - line 148: // FIXME: Can we make sure we put the control part last, even though we recreate all the rest? - line 184: // FIXME: Get options from config and from server for this event type, and do the addOptions call once for each event type. - line 186: // FIXME: Would like to avoid doing two calls to addOptions, so send in both serverDefaults and configuration.getEventOptions(ConfigurationToolkit.getEventOptions(version)) - line 279: // FIXME: Potentially translate the four known option labels (Enabled, Period, Threshold, Stack Trace) here application/org.openjdk.jmc.ide.launch/src/main/java/org/openjdk/jmc/ide/launch/model/JfrLaunchModel.java (7 lines): - line 91: // TODO: Should this be changed to "profile"? - line 133: // FIXME: Anything extra needed here? - line 158: // FIXME: Is this really a good check? - line 207: // FIXME: Should we display the error in the GUI? - line 250: // FIXME: Can we make this check nicer? - line 251: // FIXME: Should this really be translated? - line 319: // FIXME: Might need a new way to parse the update version for JDK 9 and forward, will deal with that when needed. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/FlavorSelector.java (7 lines): - line 114: // FIXME: We can remove all references to useSelectionButton if we decide that we are not going to use it - line 285: // FIXME: Instead use radio buttons with images? - line 294: // FIXME: Instead use radio buttons with images? - line 303: // FIXME: Persist state for above checkboxes? - line 374: // FIXME: Make sure not to call useFlavor twice during initialization. - line 414: // FIXME: This is for if we enable/disable selection usage outside of the combo - line 533: // FIXME: Always use concurrent if (all?) items can't be displayed on page? application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/recordingconfiguration/EventConfigurationPart.java (7 lines): - line 107: // FIXME: Extract the default values we have in common with KnownEventOptions? - line 296: // FIXME: Make this expansion logic behave better, compare with TypeFilterBuilder used in the EventBrowserPage - line 345: // FIXME: Won't get any error messages if the options are incorrect in the input - line 384: // FIXME: Static to be usable by test, should probably break out the logic instead. - line 589: // TODO: Add a tooltip - line 610: // FIXME: JMC-5274 - Mark in some other way that there are multiple values. - line 669: // FIXME: Would it make sense to add all valid values to the periodOptions list, and make the list longer? core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/CustomUnitSelector.java (7 lines): - line 118: // FIXME: Else add one? So that exactly equal can be returned. - line 125: // FIXME: Decide on return value for zero quantity. - line 133: * FIXME: Use a slightly different multiplier array derived from tickList. - line 150: // FIXME: Arrays.binarySearch is overkill with the expected 5 values. - line 153: // FIXME: Need to check accuracy due to limited double precision? - line 156: // FIXME: Subtract one? Can this pos ever match? - line 162: // FIXME: Need to check accuracy due to limited double precision? core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/Aggregators.java (6 lines): - line 87: // FIXME: consumers can have different types, they should maybe not be merged? - line 88: // FIXME: Who should be responsible for this merge? - line 158: // FIXME: Should we create a new instance, or is it OK to modify consumers like this? - line 306: // FIXME: Would like to extend SumConsumer, but this currently causes generics problems - line 382: // FIXME: "add" is not an ideal name for this method, rename to something better - line 1157: // FIXME: Translated strings are not good for persistence purposes. Maybe do something else. application/org.openjdk.jmc.rjmx.services.jfr/src/main/java/org/openjdk/jmc/rjmx/services/jfr/internal/FlightRecorderServiceV2.java (6 lines): - line 215: // FIXME: Use generic string constraint if nothing better was found. - line 241: // FIXME: Deal with numerically specified event type (instance). - line 244: // FIXME: Try/catch and ignore? - line 257: // FIXME: This should _really_ be retrieved from the server, but the server API does not allow that at the moment. - line 401: // FIXME: Use JMX notifications instead? - line 462: * FIXME: JMC-4270 - Server time approximation is not reliable. Can perhaps get a better application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/remoteagent/RemoteJMXAgentWizardPage.java (6 lines): - line 147: // FIXME: Should we set these even if the agent has started, but these properties were not shown in the output? - line 353: // FIXME: Maybe only show the settings that were output from the status command? - line 355: // FIXME: Make these fields editable if we can get the plug-in dependencies to be nice so that preferences can be updated from here - line 374: // FIXME: Show more info about SSL/authentication setup being needed when these are enabled? - line 478: // FIXME: Should we make it possible to hide/show this? - line 502: // FIXME: Should we allow not setting TTL and pause at all? application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/descriptors/CollectionDescriptors.java (6 lines): - line 252: // TODO: TreeSet - line 253: // TODO: LinkedBlockingQueue, LinkedBlockingDequeue - line 254: // TODO: PriorityBlockingQueue, DelayQueue, SynchronousQueue - line 255: // TODO: BeanContextServicesSupport, BeanContextSupport? - line 256: // TODO: ConcurrentSkipListMap, ConcurrentSkipListSet - line 402: * TODO: this works at the moment, but doesn't look like the most elegant way to core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/util/RulesToolkit.java (6 lines): - line 105: // FIXME: Should probably be broken apart into methods related to rules (kept here) and methods related to JDK events (which should be moved to wherever JfrAttributes etc. are) - line 108: // FIXME: Quick and dirty inlining of constants constants defined in SettingsTransformer. These should be handled in some other way. - line 345: // FIXME: Copied from CommonConstraints.TimePersisterBrokenSI. Use that when it is exposed. - line 755: // FIXME: We might want to have a wider input range that produces discernible output values. - line 1259: // FIXME: Generalize this a bit, get the top N frames - line 1273: * FIXME: Consider defining the method formatting based on preferences. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/QuantityConversionException.java (6 lines): - line 47: // FIXME: Can we subclass IllegalArgumentException, like NumberFormatException? - line 61: // FIXME: Move this to another Exception class that is a sibling to this class. - line 247: * FIXME: This currently reports that the value is "below precision". Replace precisionLimit - line 276: * FIXME: This currently reports that the value is "below precision". Replace precisionLimit - line 283: // FIXME: Move this to another Exception class that is a sibling to this class. - line 343: // FIXME: toString() is used for logging and debugging. Get a non-localized string for this. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/ItemFilters.java (6 lines): - line 73: // FIXME: Else warn? - line 101: // FIXME: Else warn? - line 190: // FIXME: Should we require type matches to be a complete regexp, or should we look for any internal matches, using find? - line 256: // FIXME: We need to decide if we should allow content types that are not persistable - line 471: // FIXME: Perhaps make persistable (implement PersistableItemFilter) - line 793: // FIXME: We would like to merge this with PersistableItemFilter.readFrom(), but it is not a trivial task application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/TemplateManagerWizardPage.java (6 lines): - line 133: // FIXME: Change to "Close"-button for dialog. - line 152: // FIXME: Include version in the title - line 167: // FIXME: Include version in the description - line 332: // FIXME: Can't consider it online in the JFR IDE launch case. - line 381: // FIXME: Transform to valid filename? Remember directory? - line 506: // FIXME: Verify that this is actually called, or we might leak. application/org.openjdk.jmc.greychart/src/main/java/org/openjdk/jmc/greychart/impl/DefaultXYGreyChart.java (6 lines): - line 144: // FIXME: generalize - line 172: // FIXME: we shouldn't have to check the optimizing provider, it should go away if data provider is null - line 173: // FIXME: Resolution should account for y axis width - line 177: // FIXME: Update required. Schedule new redraw - line 206: // FIXME: we shouldn't have to check the optimizing provider, it should go away if data provider is null - line 255: // FIXME: Could improve rendering times further by caching the result of the Y axis rendering. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/EventBrowserPage.java (5 lines): - line 293: // FIXME: Possibly move to attribute toolkit/handler? - line 294: // FIXME: Make sure to get Event Type as the first column - line 295: // FIXME: Stream -> Stream should be delegated to some context (e.g. the editor) - line 319: // FIXME: This is duplicated in JfrPropertySheet, where we also create a tooltip for an attribute. - line 375: // FIXME: indexOf doesn't seem to work for some reason, probably an SWT bug core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/LongPostOffsetTransform.java (5 lines): - line 95: // FIXME: Avoid calculation overflow. Clamp result to possible range! - line 101: // FIXME: Avoid calculation overflow. Clamp result to possible range! - line 112: // FIXME: Avoid calculation overflow. Clamp result to possible range! - line 118: // FIXME: Avoid calculation overflow. Clamp result to possible range! - line 124: // FIXME: Avoid calculation overflow. Clamp result to possible range! core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/StructTypes.java (5 lines): - line 137: // FIXME: Change the reflective setting of fields on this class to avoid the conversion workarounds. See JMC-5966 - line 173: // FIXME: Is this the same package regardless of module? - line 243: * FIXME: Might want to include the constant pool index to be able to exactly identify the - line 282: // FIXME: Change the reflective setting of fields on this class to avoid the conversion workarounds. See JMC-5966 - line 345: * FIXME: We should include the classLoader value in determining whether or not two java application/org.openjdk.jmc.rjmx.services.jfr/src/main/java/org/openjdk/jmc/rjmx/services/jfr/internal/FlightRecorderServiceV1.java (5 lines): - line 99: // FIXME: This is a very long time span used to find the longest recording. We could remove the need for this constant by changing the code that uses it. - line 224: // FIXME: This should _really_ be retrieved from the server, but the server API does not allow that at the moment. - line 293: // FIXME: Calculate this in the updateEventTypeMetadataMaps() method as for V2? - line 381: // FIXME: Use JMX notifications instead? - line 429: * FIXME: JMC-4270 - Server time approximation is not reliable. Can perhaps get a better application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ThreadGraphLanes.java (5 lines): - line 105: // FIXME: Might there be other interesting events that don't really have duration? - line 145: // FIXME: Workaround since this method can be called from super class constructor. Refactor to avoid this. - line 218: // FIXME: This will change the order from the original lane order, putting all the non applicable lanes last, can we live with that? - line 229: // FIXME: Might be nice to make some sort of model for the whole lane set - line 285: // FIXME: Add a tooltip here application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/TypeFilterBuilder.java (5 lines): - line 102: // FIXME: Italics if count is 0? - line 108: // FIXME: Italics if count is 0? - line 133: // FIXME: Keep track of expansion state and do fancy stuff? - line 306: // FIXME: Could consider making this show/hide from the tree context menu, similar to FilterComponent - line 321: // FIXME: Expand depending on input? core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/combine/SpanToolkit.java (5 lines): - line 61: // FIXME: Consider letting the spans handle quantities, but will increase allocation? - line 79: // FIXME: Handle multiple IItemIterable - line 115: // FIXME: Handle multiple IItemIterable - line 157: // FIXME: Handle multiple IItemIterable - line 180: // FIXME: Should we use max span or max value, or get all the spans over the limit? application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/XYChart.java (5 lines): - line 65: // FIXME: Use bucketWidth * ticksPerBucket instead of hardcoded value? - line 139: // FIXME: xBucketRange and xTickRange should be more related, so that each tick is typically an integer number of buckets (or possibly 2.5 buckets). - line 141: // FIXME: Use bucketWidth * ticksPerBucket instead of hardcoded value? - line 151: // FIXME: Extract the needed functionality from SubdividedQuantityRange - line 405: // FIXME: Would like to show selection by graying out the other parts, can we do that? application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardModel.java (5 lines): - line 80: * FIXME: Would probably be best to remove model and keep everything in the RecordingWizardPage - line 91: // FIXME: Check min values - line 163: // FIXME: Base name on template? "My Default Recording"...? - line 185: // FIXME: Ugly dependency on localized string, but we do not want to expose the storage delegate either. - line 608: // FIXME: Just add an empty template instead application/org.openjdk.jmc.flightrecorder.configuration/src/main/java/org/openjdk/jmc/flightrecorder/configuration/internal/CommonConstraints.java (4 lines): - line 135: // FIXME: Log or warn that non-SI-conforming input was received. - line 178: // FIXME: Migrate localized value from configuration GUI. - line 237: // FIXME: Migrate localized value from configuration GUI. - line 350: // FIXME: Only log newly encountered (determined by inserting into other set, preferably). application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingWizardPage.java (4 lines): - line 130: // FIXME: This should be handled by using an IDescribedMap with the options. - line 502: // FIXME: Fix the tooltip for delay. - line 653: // FIXME: Does not work for the JFR IDE launch (offline) use case. - line 668: // FIXME: Should we observe the repository instead? Maybe through the m_model? core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/AutoBoxingRule.java (4 lines): - line 62: // FIXME: Rename class (and message constants) from autoboxing to something more generic? - line 112: // FIXME: Should add a check for allocation pressure later, but keeping the rule very simplistic as a first step. - line 115: // FIXME: Consider using StacktraceModel, since this only looks at top frame it might be cheaper? - line 133: // FIXME: Would like an aggregator that calculates all this at once, should be possible to use the GroupingAggregator with the ALLOCATION_TOTAL aggregator application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/SocketIOPage.java (4 lines): - line 173: // FIXME: Would we like to include # of hosts, # of ports and host name in the new histograms? - line 247: // FIXME: X-auto-range should be done properly - line 249: // FIXME: Workaround to make max value included - line 310: // FIXME: Break out this to a "ConfigurableHistogramUi or something? This is copy-pasted from ExceptionsPage core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/LinearUnit.java (4 lines): - line 86: // FIXME: Replace allowCustomUnit boolean above with three valued enum? To include "=" (if Long) or "~=" (otherwise)? - line 162: // FIXME: Throw exception if different kindOfQuantity. - line 234: * FIXME: Simplify by concatenating the ScaleFactor with an exact inverse of - line 250: * FIXME: Attempt to handle 2.5 ns quanta by quantizing to 2 * quanta? Might require another application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ProcessesPage.java (4 lines): - line 137: // FIXME: Want to display a string with the rule results, and also a link of some sort to more explanations - line 144: // FIXME: Configure y-axis to always show 100%? - line 208: // FIXME: Would like to show tooltip if the event is not enabled, but is probably a general thing to fix on the pages. - line 229: // FIXME: Do we want to use the timerange from the chart, or the actually selected items? core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/TimestampUnit.java (4 lines): - line 71: // FIXME: Obtain unit from kind of quantity? - line 82: // FIXME: Allow DoubleStored? - line 93: // FIXME: Allow DoubleStored? - line 253: * FIXME: Currently reusing useBreakingSpace flag to determine if the result has to be application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ItemList.java (4 lines): - line 79: // FIXME: Calculate column id, e.g. using getColumnId. - line 104: // FIXME: JMC-5127 - Don't initialize to 1000 elements - line 185: // FIXME: Remove and make table handle model updates with preserved selection. - line 192: // FIXME: Would like for this item to be displayed with a different font... application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/selection/FlavorToolkit.java (4 lines): - line 57: // FIXME: Move to flightrecorder bundle, and move back to Java 7 - line 80: // FIXME: Should this really be here, and not in the flavor calculation? - line 81: // TODO: Would be nice to get the "time X in thread A, time Y in thread B" but probably expensive? - line 184: // FIXME: Do we care about showConcurrent and sameThreads here? probably not core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/DecimalUnitSelector.java (4 lines): - line 78: * FIXME: Use a custom unit here, instead of just a null id, to avoid persisting and - line 134: * FIXME: Replace factor 2.5 with 4 below? (The test above should always use 4.) - line 151: // FIXME: Decide on return value for zero quantity. - line 159: // FIXME: Iterate over a collection of specified units/prefixes instead (capped by absVal). application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/SubdividedQuantityRange.java (4 lines): - line 162: // FIXME: Use another implementation? - line 234: // FIXME: Add the inverted transform to the cache instead. - line 246: // FIXME: Add the inverted transform to the cache instead. - line 247: // FIXME: Will not clamp correctly during the long to int conversion. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ChartToolTipProvider.java (4 lines): - line 61: // FIXME: Rework to use StyledText instead, since FormText has overflow problems on HiDPI screens - line 114: // FIXME: Add formatter that does AUTO (EXACT) or so. - line 178: // FIXME: One idea was to let the user see the details in Properties/StackTrace views by click-selecting an event. - line 211: // FIXME: Format timestamp with higher precision application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/model/ConfigurationRepositoryFactory.java (4 lines): - line 99: // FIXME: Leftover from earlier storage delegates. Log and delete? - line 112: // FIXME: Better exception handling - line 115: // FIXME: Better exception handling - line 138: // FIXME: Can there be some exception cases where we actually want the stack trace? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/Navigator.java (4 lines): - line 82: // FIXME: Used in code that should be re-implemented (see commented out code in 'create' methods below) - line 88: // FIXME: more explicit threading support - line 393: // FIXME: Use with pixel subdivisions instead. - line 398: // FIXME: Extract the needed functionality from SubdividedQuantityRange application/org.openjdk.jmc.rjmx.services.jfr/src/main/java/org/openjdk/jmc/rjmx/services/jfr/internal/RecordingOptionsToolkitV1.java (4 lines): - line 79: // FIXME: Add test to verify that keys are the same? - line 148: // FIXME: Add proper logging here - line 187: // FIXME: May need to rethink how to handle null values. Store constraint but not value? - line 193: // FIXME: Add proper logging here core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/ContentType.java (4 lines): - line 73: // FIXME: Disallow formatters with the same identifier. - line 91: * FIXME: This is a clash between IType and the legacy ContentType identifier (used in the - line 103: // FIXME: Replace formatterIdentifier with some specifier. - line 115: // TODO: Add description? application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/FilterEditor.java (4 lines): - line 372: // FIXME: This action does not update its enablement until it has been unselected and reselected (list selection has changed) - line 825: // FIXME: Should we rely on formatter or TypeHandling.getValueString here? - line 1101: // FIXME: Remove the node? - line 1153: // FIXME: Ignoring negate here, hopefully there are no negated leaf filters, but might cause bugs. application/org.openjdk.jmc.ide.launch/src/main/java/org/openjdk/jmc/ide/launch/JfrLaunchDelegateHelper.java (4 lines): - line 93: // FIXME: Check if the user wants a unique filename, and in that case create one. - line 95: // FIXME: The default project Mission Control only appears if autoOpen is enabled, need to find out why. - line 215: // FIXME: Verify that we get rid of all these threads - line 231: // FIXME: Check that this only gets event for a specific launch core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/TypeManager.java (4 lines): - line 284: // FIXME: During resolve, some constants may become equal. Should we ensure canonical constants? - line 290: // FIXME: Constant lookup can perhaps be optimized (across chunks) - line 364: // FIXME: Consider making the category array into something else, like an event type metadata array? - line 456: * FIXME: Currently we convert all numbers to quantities. This might not be ideal, core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/ScaleFactor.java (4 lines): - line 44: // FIXME: Find better method names. - line 45: // FIXME: Is it possible (or desirable) to extend Number? - line 49: // FIXME: Let subclasses do this, not very common case. - line 121: // FIXME: Override in subclasses to optimize? This would be a main point of these classes. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadDumpsPage.java (4 lines): - line 341: // FIXME: Would be nice if we could accept the combined properties thread/time, but maybe that needs fixing in the selection classes? - line 352: // FIXME: Items will not be usable with a property flavor that has an attribute that doesn't exist for the thread dump events - line 364: // FIXME: Keep expansion state? - line 378: // FIXME: indexOf doesn't seem to work for some reason, probably an SWT bug application/org.openjdk.jmc.console.ui.notification/src/main/java/org/openjdk/jmc/console/ui/notification/widget/ActionChooser.java (4 lines): - line 237: // FIXME: Refactor to avoid casting. Most current ITriggerAction implementations are TriggerComponent subclasses, but this relationship could be made more explicit. - line 262: // FIXME: This is a workaround to enable custom action UI. Should be moved to an extension point, but not worth the effort until the Trigger framework is rewritten. - line 328: // FIXME: Figure out why m_stackContainer sometimes is disposed - line 334: // FIXME: Consider doing refresh more often, for instance when switching between subtabs application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/selection/SelectionStore.java (3 lines): - line 79: // FIXME: Currently only one listener at a time to avoid bothering with unregistering. Consider allowing multiple listeners. - line 118: // FIXME: If we decide to use a separate enable button in the flavor selector, then it is not necessary to use the special NO_SELECTION entry - line 190: // FIXME: Should we listen for changes to this preference, and shrink the store if the size has decreased? application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/actions/PrintRecordingDescriptorAction.java (3 lines): - line 101: // FIXME: Restore after fixing printEventSettings - line 145: * FIXME: printEventSettings causes a ClassCastException because EventOptionID is no longer - line 173: // FIXME: Change to default event options, as "current" isn't actually available in JDK9 core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingMetaspaceLiveSetRule.java (3 lines): - line 78: // FIXME: Handle multiple IItemIterable - line 83: // FIXME: Configuration attribute - line 85: // FIXME: Should construct a message using leastSquare, not use a hard limit core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/FewSampledThreadsRule.java (3 lines): - line 80: // FIXME: Could possible be merged into the HighJvmCpuRule - line 185: // TODO: Could make this more advanced (calculated expected samples etc), and merge with MethodProfilingRule - line 204: // FIXME: Alter calculation to able to name/describe pref value better... application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/XYDataRenderer.java (3 lines): - line 66: // FIXME: Improve to simply adjust the XYQuantities.xRange if xRange is compatible. - line 249: // FIXME: Must NOT be dependent on mutable state from XYDataRenderer - line 264: // FIXME: Factor out to support axis on right application/org.openjdk.jmc.rjmx.services.jfr/src/main/java/org/openjdk/jmc/rjmx/services/jfr/internal/OpenTypeConverter.java (3 lines): - line 137: // FIXME: Really special treat null here? Should ideally not reach this point. - line 148: // FIXME: Really special treat -1 here? Should ideally not reach this point. - line 160: // FIXME: Move to a better place. application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/descriptors/ConcurrentHashMapDescriptorForJdk8.java (3 lines): - line 262: // TODO: shall we also look at views here, like keySet etc.? - line 290: // FIXME: the way of seeing whether it is sparseness might not be accurate because there are two tables. - line 363: // FIXME: this is a problem in new version of ConcurrentHashMap because it doesn't have modCount field any more core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/ColorToolkit.java (3 lines): - line 89: // FIXME: Need more variety in the generated colors - line 115: // FIXME: The gradient might not be optimal, maybe use the brightness balance stuff currently in DataPageToolkit? - line 116: // FIXME: Is it OK to create a new color or do we risk a memory leak? application/org.openjdk.jmc.console.ui/src/main/java/org/openjdk/jmc/console/ui/tabs/threads/ThreadsModel.java (3 lines): - line 155: // TODO: This is expected on JVMs other than Hotspot. Add user feedback. - line 270: // TODO: This is expected on JVMs other than Hotspot. Add user feedback. - line 327: // FIXME: We could use ThreadMXBean.getThreadInfo(long[]) instead core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/BinaryUnitSelector.java (3 lines): - line 82: * FIXME: Use a custom unit here, instead of just a null id, to avoid persisting and - line 108: // FIXME: Decide on return value for zero quantity. - line 128: * FIXME: Normalize to powers of 1024 _after_ factor concatenation. core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/report/JfrRulesReport.java (3 lines): - line 148: // TODO: Add some way to include all results - line 257: // TODO: Provide configuration - line 341: // FIXME: Exact will not work in the general case, usually limiting time stamps to seconds (intervals will be ok). application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ClassLoadingPage.java (3 lines): - line 182: // FIXME: Need to make a label provider for this - line 183: // FIXME: Want to have this in the same order - line 510: // FIXME: Make this depend on the legend as well? And maybe on which chart row has been selected? application/org.openjdk.jmc.greychart/src/main/java/org/openjdk/jmc/greychart/impl/DefaultVerticalIndexRenderer.java (3 lines): - line 116: // FIXME: Get series names - line 128: // FIXME: re-implement - line 185: // FIXME: Get series names application/org.openjdk.jmc.greychart/src/main/java/org/openjdk/jmc/greychart/impl/DefaultYAxis.java (3 lines): - line 340: // FIXME: Add customizable dash line color - line 594: // FIXME: Can the provider return NaN? The check above is to be safe. If we can be sure that NaN is never returned, then we can remove it. - line 643: // FIXME: Can the provider return NaN? The check above is to be safe. If we can be sure that NaN is never returned, then we can remove it. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/TimestampKind.java (3 lines): - line 204: // FIXME: Consider minNumericalValue and maxNumericalValue - line 303: * FIXME: Since MILLIS_UNIT is default in Java, maybe return that? - line 351: // FIXME: This is not a recommended usage of QuantityConversionException. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/overview/ResultReportUi.java (3 lines): - line 315: // FIXME: Avoid implicit dependency on HTML/javascript template. Generate script in RulesHtmlToolkit instead - line 338: // FIXME: Possible race condition where elements may be added to the queue without being consumed - line 345: // FIXME: Avoid implicit dependency on HTML/javascript template. Generate script in RulesHtmlToolkit instead application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/recordingconfiguration/PropertyContainer.java (3 lines): - line 50: * FIXME: Loosen coupling to event type, so that different instances can co-exist as children, as - line 137: // FIXME: Do something with the value here? Or rely on configuration added before server? - line 175: // FIXME: This doesn't seem right. Verify and add comment if correct. core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/SettingsTransformer.java (3 lines): - line 86: // TODO: Break out constants? - line 268: * FIXME: Weird to explicitly wrap when the parser does exactly that. - line 291: // FIXME: Avoid System.err.println application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/jobs/StartRecordingJob.java (3 lines): - line 113: // FIXME: Can sometime get CONNECTED state since the connection might not have had time to close yet - line 198: // FIXME: Make sure we never make negative progress even if server time is skewed due to hibernation. - line 204: // FIXME: Setting negative values violates the contract of IProgressMonitor.worked() application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/RecordingPage.java (3 lines): - line 129: // TODO: JMC-5409 - We don't know the start and end of this recording. Improve how the user is informed about this. - line 224: // FIXME: Would like to have a span chart for the recording event, but the metadata for that is not suitable. - line 232: // FIXME: Do we want to use the timerange from the chart, or the actually selected items? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/JComponentNavigator.java (3 lines): - line 66: // FIXME: rename class - line 106: // FIXME: Extract the needed functionality from SubdividedQuantityRange - line 325: // FIXME: need to clean up this mess core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/compilation/CodeCacheRule.java (3 lines): - line 218: * FIXME: JMC-5606 - If we end up in this block, then descriptions will not be set. - line 250: // FIXME: Include configured value of code cache size in long description - line 253: // FIXME: Show calculated free value also in ok text core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/ScalarQuantity.java (3 lines): - line 69: * FIXME: Quantity values of the same kind are probably compared a lot more often - line 204: // FIXME: Check precision! - line 386: // FIXME: Check precision! application/org.openjdk.jmc.rjmx.ui/src/main/java/org/openjdk/jmc/rjmx/ui/attributes/MRIAttributeInspector.java (3 lines): - line 355: // FIXME: Building tool tips and descriptors should be unified into a toolkit - line 532: // FIXME: This may cause problems by e.g. aborting cell editors. - line 705: // TODO: Investigate if this method might be called with other types of arguments. For safety return null. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/BinaryPrefix.java (3 lines): - line 195: // FIXME: Replace with Math.floorDiv() when JDK 8 is allowed for this code. - line 224: // FIXME: Handle double corner cases like NaN, infinity and denormalized numbers. - line 253: * FIXME: When quantities are used consistently all over JMC, change this to null? application/org.openjdk.jmc.greychart/src/main/java/org/openjdk/jmc/greychart/impl/AbstractAliasingLongAxis.java (3 lines): - line 125: // FIXME: Add customizable dash line color - line 170: // FIXME: Notify chart of change! - line 180: // FIXME: Consider throwing a checked exception instead. application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/configuration/model/gui/GUIModel.java (3 lines): - line 206: // FIXME: How do we know it is a ConditionNode? What if it isn't? - line 253: // FIXME: Must simplify to not fall back on V1 once the JDK is properly updated. We cannot release with the fallback. - line 265: // FIXME: Report in GUI? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/ItemListAndChart.java (3 lines): - line 155: // FIXME: Should we use the state here, if the columns have been updated? - line 156: // FIXME: Should we change the column state if the user explicitly has configured the columns? - line 234: // FIXME: Would like to merge the menu managers and the menu consumers. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/views/stacktrace/StacktraceView.java (3 lines): - line 178: // FIXME: Define dynamic color (editable in preferences, to handle dark themes etc.) - line 289: // FIXME: Would like to move the table cursor after changing sibling state, not just the selection. - line 824: * FIXME: 'backwards' argument was used for displaying trace groups built from thread roots with core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/ItemToolkit.java (3 lines): - line 49: // FIXME: JMC-3869 - This method should be moved to avoid it being used more than necessary. - line 55: // FIXME: JMC-3869 - Related to the removal of ItemToolkit.accessor. - line 67: // FIXME: Can we avoid using self inferring cast like this? application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/TemplateToolkit.java (3 lines): - line 78: // FIXME: Create IStatus:es instead, and show them in a generic IStatus dialog with expandable details. - line 82: // FIXME: Create IStatus:es instead, and show them in a generic IStatus dialog with expandable details. - line 86: // FIXME: Create IStatus:es instead, and show them in a generic IStatus dialog with expandable details. application/org.openjdk.jmc.rjmx.services.jfr/src/main/java/org/openjdk/jmc/rjmx/services/jfr/internal/JfrRecordingInputStreamV2.java (3 lines): - line 50: // FIXME: If the invoke operations are folded into the IFlightRecorderService implementations then we can avoid having two versions of this stream class - line 55: // FIXME: This seems to have no advantage over using null. Remove! - line 171: // FIXME: Replace with suitable IConstrainedMap. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/VerifyNoneRule.java (3 lines): - line 55: // FIXME: JMC-4617 - Merge with OptionsCheckRule? - line 65: // FIXME: Possibly not needed, seems to be translated to -Xverify:none. - line 69: // FIXME: Improve check, possibly make it configurable for the user? application/org.openjdk.jmc.rjmx.ui/src/main/java/org/openjdk/jmc/rjmx/ui/operations/OperationsLabelProvider.java (2 lines): - line 96: // FIXME: Building tool tips and descriptors should be unified into a toolkit - line 102: // FIXME: Type is in "compressed" form, [J instead of long[] application/org.openjdk.jmc.javafx.osgi/src/main/java/org/openjdk/jmc/javafx/osgi/FXToolkit.java (2 lines): - line 78: // FIXME: Create error scene, with the appropriate bells and whistles. - line 79: // FIXME: Plug-in is currently in IGNORE_NLS_PROBLEM mode - fix? application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/subscription/internal/AttributeValueToolkit.java (2 lines): - line 154: // FIXME: Do a proper look up - line 180: // FIXME: Should do a proper match against existing attributes core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCPackage.java (2 lines): - line 38: // FIXME: Move IMC* classes to a subpackage - line 60: // FIXME: Should null denote unknown export status? core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/HeapContentRule.java (2 lines): - line 93: // FIXME: Configuration attribute instead of hard coded 0.75 warning limit - line 95: // FIXME: Construct a more informative message, not use a hard limit. Include a description of the aggregate. application/org.openjdk.jmc.flightrecorder.metadata/src/main/java/org/openjdk/jmc/flightrecorder/metadata/MetadataPage.java (2 lines): - line 191: // FIXME: Would like the event types tree here, but still in one table - line 218: // FIXME: Do we want to add some synthetic attributes, like duration, or (thread).groupName, even though they don't exist in the type? application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/model/EventConfiguration.java (2 lines): - line 102: // FIXME: Make two different subclasses of this, V1 and V2? - line 536: // FIXME: Check for null? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/MethodProfilingPage.java (2 lines): - line 111: // FIXME: Add some top frame balance aggregate, but which? Tried similar to top frame balance but without dividing with total. - line 168: // FIXME: Create a bar chart or something of the samples, similar to the one on Java application? core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/EventAppearance.java (2 lines): - line 54: * FIXME: This class provides knowledge about JDK events. It would make sense to make this - line 57: * FIXME: This class (or to be precise, the flightrecorder.internal package) is exposed using a application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/heap/model/Snapshot.java (2 lines): - line 712: // TODO: we don't specify the correct instance size for this class. But does it matter? - line 907: * TODO: Should we recalculate instance size for all classes here? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/PairBucketBuilder.java (2 lines): - line 57: // FIXME: Move this class - line 59: // FIXME: Do we need a special class for this, or could we move the functionality into the ordinary BucketBuilder? application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/AbstractWarningAction.java (2 lines): - line 48: // FIXME: What if actions declared in plugin.xml also wants warnings? - line 75: // FIXME: Add IPrintable? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/ItemHandlerPage.java (2 lines): - line 129: * FIXME: JMC-4326 - Should build the page using the IType instances instead. All - line 254: // FIXME: Check state to decide if this should be shown application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/AWTChartToolkit.java (2 lines): - line 284: // FIXME: Draw with gradient fill? - line 359: // FIXME: Decide if truncated labels should be shown application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/recordingconfiguration/PropertyLabelProvider.java (2 lines): - line 80: // FIXME: Should be handled in RJMX layer, all times as nanos - line 83: // FIXME: Check or ideally delegate to "content type". application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/CompilationsPage.java (2 lines): - line 163: // FIXME: Might like to have Method Formatting Options here - line 200: // FIXME: Workaround to make max value included core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jfrnext/impl/JFRNextEventClassGenerator.java (2 lines): - line 54: // FIXME: Perhaps switch to Opcodes V9 when there is one. - line 114: // FIXME: RelKey core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/report/html/JfrHtmlRulesReport.java (2 lines): - line 144: // TODO: Provide configuration - line 213: // TODO: Add possibility to specify custom group configuration file application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/subscription/internal/AbstractAttributeSubscription.java (2 lines): - line 211: // FIXME: Calculation speed could be improved. - line 239: // FIXME: We hard code the filters for now, but this should be handled along with content types core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/GcFreedRatioRule.java (2 lines): - line 133: // FIXME: Check if range is null - line 174: // FIXME: Check which of heapSummarySlide and normal sliding window that seems to give the best result application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/stats/LongLivedStringClustersCalculator.java (2 lines): - line 98: // TODO: the fact that there is just a single check below implies that there are just 3 dumps in total - line 99: // FIXME: The code below is most likely wrong; it has been changed just to compile after we changed many things in ReferenceChain etc. application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/AdvancedWizardPage.java (2 lines): - line 114: // FIXME: This Observer is not deleted unless it is notified. Maybe it should be. - line 118: // FIXME: Unexpected and quite ugly to update the title in here. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/LowOnPhysicalMemoryRule.java (2 lines): - line 70: // FIXME: Configuration attribute for warning limit and maybe safe usage - line 74: // FIXME: Check that calculation gives a reasonable value application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/views/JVMBrowserView.java (2 lines): - line 220: // FIXME: Should we hold this state? This is a temporary 'memory leak' since removed objects are held until view type is switched. - line 402: // FIXME: Reenable tree layout in pulldown menu? application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/configuration/model/xml/XMLModel.java (2 lines): - line 296: * FIXME: Mixing up "dirty" as in not-saved-to-file, with notification of - line 324: // FIXME: Get a logger when this is in a better bundle. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/exceptions/ExceptionRule.java (2 lines): - line 93: // FIXME: Check EXCEPTIONS_THROWN event as well, and if so, consider adding an exclude list like for the error rule. - line 110: // FIXME: List most common exception if events are available application/org.openjdk.jmc.rjmx.ui/src/main/java/org/openjdk/jmc/rjmx/ui/attributes/AttributeTreeBuilder.java (2 lines): - line 74: // FIXME: Building tool tips and descriptors should be unified into a toolkit - line 75: // FIXME: Tool tips for parameters should include type application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/celleditors/CommonCellEditors.java (2 lines): - line 49: // FIXME: JMC-5904 - Should be merged with cell editors in org.openjdk.jmc.rjmx.ui.celleditors - line 167: // FIXME: Is this possible to implement as a single CellEditor, or do we need to use two cells, horizontally or vertically? application/org.openjdk.jmc.rjmx.ui/src/main/java/org/openjdk/jmc/rjmx/ui/internal/CombinedChartSectionPart.java (2 lines): - line 230: // FIXME: Long method, try to break out at least some anonymous classes - line 283: // FIXME: Determine outUnit through autorange, or pick one? application/org.openjdk.jmc.greychart/src/main/java/org/openjdk/jmc/greychart/impl/DefaultHorizontalIndexRenderer.java (2 lines): - line 90: // FIXME: Need to add change listener for when series names or number of series have changed. - line 100: // FIXME: Get series names application/org.openjdk.jmc.greychart/src/main/java/org/openjdk/jmc/greychart/GreyChartPanel.java (2 lines): - line 153: * FIXME: This assumes that every component beyond this point restores the altered - line 238: // FIXME: Maybe add a custom repaint manager, and ignore the Swing one? application/org.openjdk.jmc.greychart/src/main/java/org/openjdk/jmc/greychart/providers/IntermediateStackingProvider.java (2 lines): - line 136: // FIXME: Currently not checking if we need to re-calculate the sample stack - line 161: // FIXME: We should formalize this so that this can be set optionally. application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/descriptors/ConcurrentHashMapDescriptor.java (2 lines): - line 94: // TODO: shall we also look at views here, like keySet etc.? - line 376: * TODO: this all gets problematic when fields are added/changed in CHM and CHM$Segment... core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/version/JavaVersionSupport.java (2 lines): - line 59: // FIXME: Update this if JDK-8036749 is ever backported to 8uX. - line 61: // FIXME: Update this if JDK-8054307 is ever backported to 8uX. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCClassLoader.java (2 lines): - line 43: // FIXME: Find some way to add identity information - line 44: // FIXME: Move IMC* classes to a subpackage core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/IType.java (2 lines): - line 52: // FIXME: Lists of attributes should not be fetched directly from the type - line 67: // FIXME: Can we find a more appropriate return type? core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/IncreasingLiveSetRule.java (2 lines): - line 111: // FIXME: Handle multiple IItemIterable - line 135: // FIXME: Should construct an message using memoryIncrease, not use a hard limit core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v0/ChunkMetadata.java (2 lines): - line 70: // FIXME: Make unpersistable, possibly "Custom". Avoid plural unit name. - line 73: // FIXME: Make "ticks" based timestamp unit with recording provided origo to avoid nanosecond long/double precision issues? core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/HighGcRule.java (2 lines): - line 78: // FIXME: Configuration attribute instead of hard coded 1 second => score 90 - line 79: // FIXME: Also consider duration length when calculating score? core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/RangeContentType.java (2 lines): - line 44: // FIXME: Make package private if possible to restructure packages. - line 59: // FIXME: Drop DisplayFormatter, empower hints with IDescribable. Or something. application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/subscription/internal/DefaultNotificationSubscriptionManager.java (2 lines): - line 65: // FIXME: The Notification manager will currently not send out any null events on creation/destruction. - line 119: // FIXME: JMC-4270 - Server time approximation is not reliable application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/RecordingProvider.java (2 lines): - line 81: // FIXME: If the cutoff formatter makes sense elsewhere, consider adding it to TIMESPAN. - line 127: // FIXME: JMC-4270 - Server time approximation is not reliable application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/dial/DialViewer.java (2 lines): - line 68: // FIXME: This class definitely needs to be cleaned up. - line 434: // FIXME: Quick fix to avoid translating panel all over the place. Draw the panel Image first core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/StacktraceFrame.java (2 lines): - line 48: // FIXME: Replace use of SimpleArray with a standard collection or array - line 55: // TODO: Consider adding a frameSeparator field so that it becomes possible to tell how specific the frame is application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/VMOperationPage.java (2 lines): - line 132: // FIXME: Change to another icon - line 229: // FIXME: Same workaround as in SocketIOPage to include max value application/org.openjdk.jmc.greychart/src/main/java/org/openjdk/jmc/greychart/impl/DefaultPieRenderer.java (2 lines): - line 145: // FIXME: Paint it in the right section, fix truncation some day. - line 146: // FIXME: Re-implement application/org.openjdk.jmc.jdp/src/main/java/org/openjdk/jmc/jdp/common/JRockitJDPPacketDecoder.java (2 lines): - line 51: // FIXME: These keys need to be shared/standardized - line 110: // FIXME: auto-resolve hostname? core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/PersistableItemFilter.java (2 lines): - line 117: // FIXME: Rename "field" identifier which is now an attribute id - line 119: // FIXME: Differentiate between "value type", that needs to be looked up, and others. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/MCPackage.java (2 lines): - line 44: // FIXME: Move MC* classes and related toolkits to a separate package? - line 62: // FIXME: Should null be recommended for unknown export status? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/itemhandler/AttributeMenuFactory.java (2 lines): - line 58: // FIXME: Only create the menu and actions once, and just update the checkedState when the menu is displayed? - line 105: // FIXME: Send in a real id, and make sure other parts of the code, like HistogramSequence doesn't have to know about it. application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/triggers/extension/internal/TriggerFactory.java (2 lines): - line 52: // FIXME: Important, we need to add better error handling. - line 107: // FIXME: We must have error handling here application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/FlightRecorderUI.java (2 lines): - line 195: // TODO: Make folder configurable in preferences - line 216: // FIXME: Do this lazily for non active editors. Make sure that also editors that could not be fetched from the editor reference are refreshed. application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/RecordingEventOptionsWizardPage.java (2 lines): - line 112: // FIXME: This Observer is not deleted unless it is notified. Maybe it should be. - line 117: // FIXME: This should not modify the XML model, but currently it might (due to qualifying controls to URIs). application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/SWTColorToolkit.java (2 lines): - line 64: // FIXME: Take the actual background color into account? - line 115: // FIXME: Could potentially do the same as for ColoredSquare and save this in the ImageRegistry application/org.openjdk.jmc.rjmx.ui/src/main/java/org/openjdk/jmc/rjmx/ui/internal/SectionPartManager.java (2 lines): - line 85: // FIXME: force refresh of parts if some tab is reverted - line 143: // FIXME: Refactor to make this type safe application/org.openjdk.jmc.console.ui/src/main/java/org/openjdk/jmc/console/ui/editor/internal/ConsoleEditor.java (2 lines): - line 122: // FIXME: Show stacktrace? (Need to show our own ExceptionDialog in that case, or maybe create our own DetailsAreaProvider, see WorkbenchStatusDialogManager.setDetailsAreaProvider) - line 304: // TODO: Consider carefully which services we want to support. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ItemHistogram.java (2 lines): - line 142: // FIXME: Refactor/remove this method to avoid it being used instead of passing an IAggregator. - line 260: * FIXME: Consider some sharing with ColumnBuilder.DEFAULT_LP. application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/XYQuantities.java (2 lines): - line 76: // FIXME: Find samples also 'during' the pixel. Somewhat deviating from the method definition. - line 441: // FIXME: Alternatively to this method, return an AWT 2D Affine Transform here. core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/jdk/JdkAttributes.java (2 lines): - line 164: // FIXME: Fix train wreck to avoid NPEs and IndexOutOfBoundsException - line 312: // FIXME: Fix train wreck to avoid NPEs and IndexOutOfBoundsException core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/StacktraceModel.java (2 lines): - line 195: // FIXME: Clean up code so that it becomes more readable - line 505: // FIXME: Check input value range? application/org.openjdk.jmc.flightrecorder.configuration/src/main/java/org/openjdk/jmc/flightrecorder/configuration/internal/EventTypeIDV1.java (2 lines): - line 44: // FIXME: When usage has settled, revise stored state and convenience methods. - line 98: // FIXME: Use slash instead? core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/DumpReasonRule.java (2 lines): - line 91: // FIXME: Will hopefully include "exceptional" boolean in the future - line 108: // FIXME: When all recordings have DumpReasons, we will be more sure of if an unknown reason is good or bad. application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/triggers/internal/NotificationTrigger.java (2 lines): - line 60: // FIXME: This class would definitely benefit from a cleanup/refactoring - line 327: // FIXME: The invocation of the actions should be added to a queue and dispatched in a separate thread core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IWritableState.java (2 lines): - line 43: // FIXME: Rename to IStateCollector or similar - line 64: // FIXME: Rename to putAttribute to match IState.getAttribute application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/subscription/internal/DefaultAttributeSubscriptionThread.java (2 lines): - line 190: // FIXME: JMC-4270 - Server time approximation is not reliable - line 292: // FIXME: JMC-4270 - Server time approximation is not reliable application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/internal/MBeanOperationWrapper.java (2 lines): - line 175: // FIXME: Building tool tips and descriptors should be unified into a toolkit - line 180: // TODO: This is a workaround to get the descriptors to UI-layer. Should be handled using some adaptive mechanism. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/FileIOPage.java (2 lines): - line 349: // FIXME: X-auto-range should be done properly - line 351: // FIXME: Workaround to make max value included application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/configuration/model/xml/PrettyPrinter.java (2 lines): - line 70: // FIXME: Don't hardcode to UTF8. - line 82: // TODO: clean up logic application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/subscription/internal/MBeanMRIMetadataDB.java (2 lines): - line 69: // FIXME: extend possibility to record MBean metadata about notifications - line 232: // FIXME: We ought to retrieve all composites at once but we will not need this for well behaved MBeans application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ChartCanvas.java (2 lines): - line 181: // FIXME: Remove flicker by drawing in a buffered stage (AWT or SWT). - line 421: // FIXME: Do we want this highlighted? core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v1/ValueReaders.java (2 lines): - line 294: // FIXME: Rearrange to remove string switching on every method. (Java 8 could simplify this.) - line 492: // FIXME: Change the reflective setting of fields to avoid the conversion workarounds that some classes have to make. See JMC-5966 application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/RulesUiToolkit.java (2 lines): - line 48: // FIXME: Rules by topic can be cached statically. Wait until we finalize discussion on name and data type for "topic" until we do that. - line 49: // FIXME: Would like to avoid the empty string as catch all topic application/org.openjdk.jmc.console.ui.notification/src/main/java/org/openjdk/jmc/console/ui/notification/tab/ActionComponentFactory.java (2 lines): - line 56: // FIXME: This is a workaround to enable custom action UI. Should be moved to an extension point, but not worth the effort until the Trigger framework is rewritten. - line 75: // FIXME: State should be stored with the tab application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/RendererToolkit.java (2 lines): - line 149: // FIXME: Draw something nice. - line 169: // FIXME: Use stored state for fullyShown? application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/wizards/ConnectionWizardPage.java (2 lines): - line 85: // FIXME: This class needs to be refactored, needs to handle {create, edit, view(discovered or connected)} x {custom, local, jdp} - line 409: // FIXME: Make sure to fix the layout to align for all components, for example commandline, pid and service url (for JDP) core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/XmlToolkit.java (2 lines): - line 502: // FIXME: Replace usage with OWASP encoder - line 512: // FIXME: Replace usage with OWASP encoder core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/StructContentType.java (1 line): - line 91: // FIXME: Attribute should not be created here core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/MCOldObject.java (1 line): - line 52: // FIXME: Move MC* classes and related toolkits to a separate package? core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/MethodToolkit.java (1 line): - line 47: // FIXME: Move MC* classes and related toolkits to a separate package? application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/triggers/extension/internal/TriggerComponent.java (1 line): - line 189: * FIXME: JMC-5329 - Clean up quantity field initialization. core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/ValueField.java (1 line): - line 43: // FIXME: Investigate if this should be replaced by IAttribute application/org.openjdk.jmc.console.jconsole/src/main/java/org/openjdk/jmc/console/jconsole/tabs/JConsolePluginTabbedPane.java (1 line): - line 76: // FIXME: Make placement configurable in settings application/org.openjdk.jmc.greychart/src/main/java/org/openjdk/jmc/greychart/impl/DefaultXAxis.java (1 line): - line 156: // FIXME: Notify chart of change! application/org.openjdk.jmc.greychart/src/main/java/org/openjdk/jmc/greychart/AbstractAxis.java (1 line): - line 96: // FIXME: Add fix range axis and auto range axis. core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/TransformRegistry.java (1 line): - line 62: // FIXME: We should only update the transformation registry! The actual retransforms should happen elsewhere! core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/cpu/CompareCpuRule.java (1 line): - line 92: // FIXME: Could consider using the infoLimit for the span instead? application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/stats/OverallStatsCalculator.java (1 line): - line 245: // TODO: need a better way to calculate overhead for short primitive arrays, at least of size 0 and 1 application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/internal/SyntheticAttributeMBeanEntry.java (1 line): - line 148: // FIXME: Perform proper lookup core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/tree/Range.java (1 line): - line 41: // FIXME: Not really related to item trees. Should be moved somewhere else. application/org.openjdk.jmc.console.ui.notification/src/main/java/org/openjdk/jmc/console/ui/notification/wizard/RuleWizardDialog.java (1 line): - line 47: // FIXME: This dialog must be fixed before it can be used for editing purposes as it writes directly to the model. Until then, only call this method with rule==null. application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/util/AdapterUtil.java (1 line): - line 77: // FIXME: This falls back on returning adaptable if it is an instance of adapterClass, and that may not always be desired. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/IOptionDescriptor.java (1 line): - line 37: // FIXME: Move to flightrecorder.configuration unless used in relation to IDescribedMap. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/ExtraRowTableViewer.java (1 line): - line 49: // FIXME: Would like to decorate the extra row with a font, but the table we use this for uses ViewerColumns with their own labelproviders core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/IScalarAffineTransform.java (1 line): - line 60: // FIXME: Return QuantityConversionException.Problem instead? Handle underflow too? core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IPredicate.java (1 line): - line 42: // FIXME: Move to a subpackage (common.util?) application/org.openjdk.jmc.console.ui/src/main/java/org/openjdk/jmc/console/ui/preferences/MBeanBrowserPage.java (1 line): - line 45: // FIXME: This preference page would make more sense in the console.ui.mbeanbrowser plug-in? core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/ICanonicalAccessorFactory.java (1 line): - line 37: // FIXME: If we implement IDescribable here, then we can remove the current IAttribute subinterface and rename this one to IAttribute application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/views/NoLocalJVMsWarner.java (1 line): - line 73: // FIXME: Show a link to the FAQ section of the online help. Need to create special dialog with FormText. application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/FlightRecorderProvider.java (1 line): - line 124: * FIXME: ConnectionHandle state is not always up to date. core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/JdkTypeIDsPreJdk11.java (1 line): - line 67: * FIXME: VMError is commented out since the build cannot handle warnings on lines containing application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/actions/DumpWholeRecordingAction.java (1 line): - line 54: // FIXME: Only dump a part of the recording if it's too large application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/subscription/internal/HotSpotLiveSetAttribute.java (1 line): - line 123: // TODO: Is there a better way of finding the GC used for major collections? application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/configuration/model/xml/JFCGrammar.java (1 line): - line 109: * FIXME: These should probably not be defined in multiple places. application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/recordingconfiguration/PropertyContentBuilder.java (1 line): - line 81: // FIXME: If we expect any events that we have not encountered before, we need to create nodes. application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/tree/ITreeNode.java (1 line): - line 40: // FIXME: It would make sense to extend IChild and IParent here application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/RecordingLoader.java (1 line): - line 164: // FIXME: Can we calculate available memory without resorting to System.gc? application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/util/StatusFactory.java (1 line): - line 66: // FIXME: If subMsg == null, return plain status instead. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/selection/IPropertyFlavor.java (1 line): - line 74: * FIXME: We should really handle describing multiple values (to some max limit). application/org.openjdk.jmc.rjmx.ext/src/main/java/org/openjdk/jmc/rjmx/ext/OsgiServicesJmxProviderProxy.java (1 line): - line 102: // FIXME: Add WeakRef/ReferenceQueue or listener to "unget" service? core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCOldObjectArray.java (1 line): - line 39: // FIXME: Move IMC* classes to a subpackage application/org.openjdk.jmc.browser.attach/src/main/java/org/openjdk/jmc/browser/attach/internal/ExecuteTunnler.java (1 line): - line 83: // FIXME: Check if it is OK to wrap this unknown exception, usually a java.lang.reflect.InvocationTargetException with a com.sun.tools.attach.AttachOperationFailedException inside it. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/selection/FlavoredSelectionBase.java (1 line): - line 50: // FIXME: Unknown... remove super interface? application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/batch/ReportFormatter.java (1 line): - line 150: // FIXME: We probably can't get anything useful out of these collections. Remove calculation of this? application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/idesupport/IDESupportFactory.java (1 line): - line 84: // FIXME: Support may be null. Do we need a default IIDESupport? application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/configuration/model/gui/TestNode.java (1 line): - line 38: // TODO: Implement other operators than equals if needed. application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/column/ColumnManager.java (1 line): - line 235: // FIXME: Workaround to avoid drawing dug on windows when having hooked EraseItem listener and the first tree column draws a custom background or is right aligned application/org.openjdk.jmc.console.jconsole/src/main/java/org/openjdk/jmc/console/jconsole/MissionControlContext.java (1 line): - line 79: // FIXME: Check what the users of this interface expect? Is null OK? application/org.openjdk.jmc.rjmx.services.jfr/src/main/java/org/openjdk/jmc/rjmx/services/jfr/internal/RecordingDescriptorToolkitV1.java (1 line): - line 110: // FIXME: Why not reuse the code in RecordingOptionsToolkit? The options are the same. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/FormatToolkit.java (1 line): - line 46: // FIXME: Avoid exposing if possible. Could be moved to another package together with IMCMethod etc. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCType.java (1 line): - line 39: // FIXME: Move IMC* classes to a subpackage application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/ActionUiToolkit.java (1 line): - line 134: // FIXME: Add a context menu for enablement, should that be done here or in the caller? application/org.openjdk.jmc.ide.jdt/src/main/java/org/openjdk/jmc/ide/jdt/JumpToJavaMethod.java (1 line): - line 46: // FIXME: We don't support anonymous classes and static initializers core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/ClassLoadingRule.java (1 line): - line 96: // FIXME: Consider using a score function instead of set value. application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/OverheadTypeViewer.java (1 line): - line 71: // FIXME: Should be removed core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCMethod.java (1 line): - line 47: // FIXME: Move IMC* classes to a subpackage application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/triggers/fields/internal/PasswordField.java (1 line): - line 158: * FIXME: Currently it is only invoked when the field's value changes. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/IItem.java (1 line): - line 46: // FIXME: Can we force IType? Doing that causes a cascade of things that need to be fixed. application/org.openjdk.jmc.flightrecorder.configuration/src/main/java/org/openjdk/jmc/flightrecorder/configuration/internal/FixedDescriptorMap.java (1 line): - line 51: // FIXME: Rename to something more accurate. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/MCStackTrace.java (1 line): - line 43: // FIXME: Move MC* classes and related toolkits to a separate package? application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/stats/DetailedStatsCalculator.java (1 line): - line 300: * TODO: Our calculations for boxed arrays are much more precise, since they take into application/org.openjdk.jmc.rjmx.services.jfr/src/main/java/org/openjdk/jmc/rjmx/services/jfr/internal/FlightRecorderCommunicationHelperV2.java (1 line): - line 52: // FIXME: If the invoke operation and the MBean name is folded into the IFlightRecorderService implementations then we can avoid having two versions of this class core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/package-info.java (1 line): - line 36: // FIXME: There is a lot of undocumented code in this package. Document! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/dial/DialDevice.java (1 line): - line 116: * FIXME: Could not find a suitable unit, this shouldn't happen. application/org.openjdk.jmc.alert/src/main/java/org/openjdk/jmc/alert/AlertPlugin.java (1 line): - line 244: // FIXME: JMC-4270 - Server time approximation is not reliable core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCThreadGroup.java (1 line): - line 38: // FIXME: Move IMC* classes to a subpackage application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/idesupport/IDESupportUIToolkit.java (1 line): - line 46: // FIXME: This class hasn't got anything to do with IDESupport. Should be renamed to FileBrowserToolkit or something core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/TypeHandling.java (1 line): - line 185: // FIXME: Get the formatting options from MethodFormatter? Or from Preferences? application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/configuration/model/xml/JFCXMLValidator.java (1 line): - line 213: // FIXME: Generalize so that an overriding base URI can be applied at any element level? application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/labelingrules/Variables.java (1 line): - line 56: // FIXME: Could possibly be a good idea to combine JVMType and JVMArch into one enum, at least to avoid "[Unknown][Unknown]" application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/configuration/model/xml/XMLAttributeInstance.java (1 line): - line 96: // FIXME: Validate against allowed values core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/IEventSinkFactory.java (1 line): - line 87: // FIXME: The subfactory flushing should perhaps be handled outside of this interface application/org.openjdk.jmc.ide.launch/src/main/java/org/openjdk/jmc/ide/launch/model/JreFileStorageDelegate.java (1 line): - line 62: // FIXME: What should we do in this case, should we throw or return something? application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/actions/DumpAnyRecordingAction.java (1 line): - line 73: // FIXME: Can we make different error message depending on version? core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/LabeledIdentifier.java (1 line): - line 42: // FIXME: This is almost only used while reading flight recordings. Can we move it there? application/org.openjdk.jmc.console.ui.notification/src/main/java/org/openjdk/jmc/console/ui/notification/widget/ConditionChooser.java (1 line): - line 287: // FIXME: Refactor to avoid casting. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/DMSIncidentRule.java (1 line): - line 124: // FIXME: Create constant for path application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/subscription/internal/DefaultAttributeSubscriptionService.java (1 line): - line 391: // FIXME: Can be optimized if necessary. application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/scripting/ControlContentAdapter.java (1 line): - line 43: // FIXME: clean up, we need to investigate further how this is supposed to work. application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/subscription/internal/UnavailableChildSubscriptions.java (1 line): - line 112: // FIXME: change to a better test of containment? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/PagesExportWizard.java (1 line): - line 61: // FIXME: Choose an appropriate icon for this wizard core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/util/IItemResultSet.java (1 line): - line 42: // FIXME: We may want to clean all of this up and move it to common, so that it can be used more generally. application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/util/internal/SimpleAttributeInfo.java (1 line): - line 68: // FIXME: add description to equals and hashcode? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/CodeCachePage.java (1 line): - line 357: // FIXME: All these descriptions are null, add strings describing each code cache row application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/support/Constants.java (1 line): - line 171: // FIXME: Unused arrays that in either case should not be exposed. Consider if they are useful in any way or if they can be removed. application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/subscription/internal/FileMRIMetadataDB.java (1 line): - line 114: // FIXME: JMC-4672 - We cache the value to avoid multiple queries to the server. This may or may not be desirable. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/TlabAllocationRatioRule.java (1 line): - line 86: // FIXME: Configuration attribute instead of hard coded 0.2 for info limit application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/preferences/PreferenceKeys.java (1 line): - line 69: // FIXME: Used for testing. Perhaps remove in final version. application/org.openjdk.jmc.console.ui.notification/src/main/java/org/openjdk/jmc/console/ui/notification/action/TriggerActionRecordingToolkit.java (1 line): - line 82: // FIXME: Consider reporting the exception to the user application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/TemplateImportWizard.java (1 line): - line 62: // FIXME: Need large icon here, same as for the export wizard core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/dataproviders/HaltsProvider.java (1 line): - line 113: // FIXME: Use the item range instead of the time range, in case the sliding window logic slides outside the item range. Or fix the sliding window logic. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/package-info.java (1 line): - line 36: // FIXME: There is a lot of undocumented code in this package. Document! application/org.openjdk.jmc.flightrecorder.ext.jfx/src/main/java/org/openjdk/jmc/flightrecorder/ext/jfx/JfxPulseDurationRule.java (1 line): - line 64: * TODO: Add detection for if the recording was from an embedded JVM for 33.34ms (30 Hz) target. application/org.openjdk.jmc.console.ui/src/main/java/org/openjdk/jmc/console/ui/tabs/threads/ThreadTableSectionPart.java (1 line): - line 246: // TODO: JMC-5902 - Improve error handling. Separate expected (connection lost) from unexpected errors application/org.openjdk.jmc.flightrecorder.configuration/src/main/java/org/openjdk/jmc/flightrecorder/configuration/internal/DefaultValueMap.java (1 line): - line 97: // FIXME: fallbacks may be null here, but it is unlikely in practice. Should be handled. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/MetaspaceOomRule.java (1 line): - line 69: // FIXME: Configuration attribute instead of hard coded 1 as warning limit application/org.openjdk.jmc.rjmx.services.jfr/src/main/java/org/openjdk/jmc/rjmx/services/jfr/internal/EventOptionsToolkitV1.java (1 line): - line 155: // FIXME: Check exact semantics of JFR 1.0 here, when to override (0 vs. -1). core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/RuleRegistry.java (1 line): - line 103: // FIXME: can we make it impossible to get rule id conflicts? core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCStackTrace.java (1 line): - line 40: // FIXME: Move IMC* classes to a subpackage application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/UIPlugin.java (1 line): - line 207: // FIXME: Move to extension point core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/util/SlidingWindowToolkit.java (1 line): - line 114: // FIXME: What should we do about empty time intervals? application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/handlers/TemplateImportOnOpenHandler.java (1 line): - line 52: * FIXME: Extend the OpenHandler mechanism to either accept multiple files here, or have core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/IAttribute.java (1 line): - line 47: // FIXME: ICanonicalAccessorFactory should perhaps replace this interface core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/report/html/internal/RulesHtmlToolkit.java (1 line): - line 208: // FIXME: Make private and instead add a method for creating javascript updates application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/model/EventConfigurationRepository.java (1 line): - line 120: // FIXME: Go even further and ignore case and all whitespace differences? core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/combine/SpanSquare.java (1 line): - line 35: // FIXME: This could use some comments application/org.openjdk.jmc.ide.jdt/src/main/java/org/openjdk/jmc/ide/jdt/JumpToSourceToolkit.java (1 line): - line 53: // FIXME: Can't handle anonymous classes and static initializers. application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/configuration/model/gui/FlagNode.java (1 line): - line 55: // FIXME: Create standard swt toolkit to have just 1 method? application/org.openjdk.jmc.rcp.intro/src/main/java/org/openjdk/jmc/rcp/intro/FlightRecordingExampleAction.java (1 line): - line 53: // FIXME: This action is currently not used, but if we want to use it, we need to update this to use something other than sample recording. application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/preferences/LongQuantityFieldEditor.java (1 line): - line 67: * FIXME: Should we report the closest valid value rather than the supported precision? application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/triggers/internal/NotificationRuleBag.java (1 line): - line 135: // FIXME: This needs to go away... application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/SpanRenderer.java (1 line): - line 106: // FIXME: Are x1 and x2 guaranteed to be ordered? application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/remoteagent/RemoteJMXAgentWizard.java (1 line): - line 79: // FIXME: Would like to show the causing exception for the problem, which is actually printed on the console. application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/configuration/model/gui/AndNode.java (1 line): - line 35: // FIXME: add unit tests to logic nodes application/org.openjdk.jmc.ide.jdt/src/main/java/org/openjdk/jmc/ide/jdt/JumpToJavaType.java (1 line): - line 45: // FIXME: We don't support anonymous classes and static initializers application/org.openjdk.jmc.rjmx.services.jfr/src/main/java/org/openjdk/jmc/rjmx/services/jfr/internal/RecordingDescriptorV2.java (1 line): - line 101: // FIXME: CLOSED would fit better but there is no such enum value at the moment core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/OptionsCheckRule.java (1 line): - line 464: // TODO: Some checking could perhaps be done by using a csv file with match patterns and associated recommendation texts core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/tree/TimeRangeThreadFilter.java (1 line): - line 52: // FIXME: Not really related to item trees. Should be moved somewhere else. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/SimpleConstrainedMap.java (1 line): - line 64: // FIXME: We should validate values, but validation is currently only accessible to subclasses. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ThreadsPage.java (1 line): - line 164: // FIXME: The lanes field is initialized by initializeChartConfiguration which is called by the super constructor. This is too indirect for SpotBugs to resolve and should be simplified. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/HeapPage.java (1 line): - line 219: // FIXME: Add a better description. application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/MemoryStatisticsTable.java (1 line): - line 70: // FIXME: Change this when javafx RT-32518 is implemented application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/DistinctItemsPage.java (1 line): - line 81: // FIXME: Either provide a selection name that is not the same as the page name or do not support selections here core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/MCType.java (1 line): - line 41: // FIXME: Move MC* classes and related toolkits to a separate package? application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/QuantitySpanRenderer.java (1 line): - line 121: // FIXME: Only output this if near the boundaries? At least handle infinite lengths. core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/Transformer.java (1 line): - line 73: // FIXME: Optimization, should do all transforms to one class in one go, instead of creating one class writer per transform. core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v0/factories/ThreadGroupFactory.java (1 line): - line 46: * FIXME: Should resolve the parent at some point. Note that this cannot be done with this application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/TlabPage.java (1 line): - line 137: // FIXME: This page could probably use a horizontal legend instead. application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/TemplateEditSimplePage.java (1 line): - line 52: // FIXME: Should perhaps not reuse this code, but instead repeat the iteration here. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/PredicateToolkit.java (1 line): - line 656: // TODO: Possibly allow matching all (instead of none) if the regexp is invalid, by adding a boolean parameter to control the behavior core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/IAggregator.java (1 line): - line 53: // FIXME: We should consider accessor methods instead of extending all interfaces core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCOldObjectGcRoot.java (1 line): - line 39: // FIXME: Move IMC* classes to a subpackage application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/ExceptionsPage.java (1 line): - line 400: // FIXME: What should we do with the selection input here? application/org.openjdk.jmc.ide.launch/src/main/java/org/openjdk/jmc/ide/launch/model/JfrArgsBuilder.java (1 line): - line 193: // FIXME: Add timestamp here? core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/stacktrace/StacktraceFormatToolkit.java (1 line): - line 60: // TODO: Better presentation of UNKNOWN_FRAME application/org.openjdk.jmc.rjmx.ui/src/main/java/org/openjdk/jmc/rjmx/ui/attributes/SetUnitMenuManager.java (1 line): - line 182: // FIXME: This should preferably be abstracted away to e.g. MRIMetadataToolkit application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/charts/QuantitySeries.java (1 line): - line 51: // FIXME: Move and rename application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/wizards/ConnectionWizard.java (1 line): - line 121: // FIXME: Rewrite this. Create different wizards, perhaps reusing the same wizard pages. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/IValueBuilder.java (1 line): - line 43: // FIXME: Maybe getValueType could be removed and this interface could be replaced by a general function core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/MCClassLoader.java (1 line): - line 43: // FIXME: Move MC* classes and related toolkits to a separate package? application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/actions/OpenFileAction.java (1 line): - line 144: // FIXME: Workaround for Eclipse bug 540164. See JMC-6171. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/IItemConsumer.java (1 line): - line 50: // FIXME: Would like to avoid having a self referring generics parameter application/org.openjdk.jmc.greychart/src/main/java/org/openjdk/jmc/greychart/providers/IntegratingSampleCountingBuffer.java (1 line): - line 59: // FIXME: not safe, end might end up outside buffer application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/subscription/internal/SingleMRITransformationFactory.java (1 line): - line 93: // FIXME: Would be nice to not have to specify an ObjectName but until then let us use something meaningful. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/IConstraint.java (1 line): - line 43: * FIXME: Separate persistence to a has-a, rather than a is-a? Or maybe only in subclasses (and core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCFrame.java (1 line): - line 46: // FIXME: Move IMC* classes to a subpackage application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/internal/RJMXConnection.java (1 line): - line 497: * FIXME: JMC-4270 - Server time approximation is not reliable. Since JDK-6523160, application/org.openjdk.jmc.rjmx.services.jfr/src/main/java/org/openjdk/jmc/rjmx/services/jfr/FlightRecorderToolkit.java (1 line): - line 138: // FIXME: Also take max size into account? core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCThread.java (1 line): - line 38: // FIXME: Move IMC* classes to a subpackage application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/services/internal/ServiceFactoryManager.java (1 line): - line 167: // FIXME: Suggested improvement to service factories. Might not give enough benefits to be worth the effort. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/ManagementAgentRule.java (1 line): - line 68: // FIXME: Move the filter inside the aggregate. application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/handlers/MethodFormatter.java (1 line): - line 50: // FIXME: Move the option part to a non-UI bundle? core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/DisplayFormatter.java (1 line): - line 52: * FIXME: Rewrite! This class is responsible for holding configuration details about which kind of application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/AncestorViewer.java (1 line): - line 138: // FIXME: Should be removed core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/latency/ContextSwitchRule.java (1 line): - line 104: // FIXME: Configuration attribute for the warning and info limits core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/MCFrame.java (1 line): - line 41: // FIXME: Move MC* classes and related toolkits to a separate package? application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/wizards/ActionWizardPage.java (1 line): - line 66: // FIXME: Write a better description application/org.openjdk.jmc.browser/src/main/java/org/openjdk/jmc/browser/remoteagent/RemoteJMXAgentSettings.java (1 line): - line 90: // FIXME: Handle possible case where there is more than one remote agent, maybe with different protocols application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/util/internal/AbstractReadOnlyAttribute.java (1 line): - line 117: // FIXME: A more general handling of editing Object values would solve the problem of using the type of the array element. application/org.openjdk.jmc.rjmx.services.jfr/src/main/java/org/openjdk/jmc/rjmx/services/jfr/internal/JfrRecordingInputStreamV1.java (1 line): - line 50: // FIXME: This seems to have no advantage over using null. Remove! application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/services/IAttributeInfo.java (1 line): - line 35: // FIXME: Use generics in this interface (and dependent IAttribute and IOperation interfaces) when needed. getType should return Class etc. application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/pages/JVMInformationPage.java (1 line): - line 140: // FIXME: Return fallback function instead? application/org.openjdk.jmc.greychart/src/main/java/org/openjdk/jmc/greychart/impl/DefaultPieGreyChart.java (1 line): - line 151: // TODO Auto-generated method stub core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v0/ArrayReader.java (1 line): - line 78: // FIXME: JMC-5907, array of primitives are currently parsed to array of IQuantity. Should we produce primitive arrays instead? application/org.openjdk.jmc.console.ui.notification/src/main/java/org/openjdk/jmc/console/ui/notification/uicomponents/PasswordInputItem.java (1 line): - line 86: // FIXME: Memory leak. Color instances need to be disposed but we must be sure that they are not used anywhere else first. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/DebugNonSafepointsRule.java (1 line): - line 56: // FIXME: JMC-4617 - Merge with OptionsCheckRule? core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/jfr/impl/JFREventClassGenerator.java (1 line): - line 64: // TODO: Add support for different locations application/org.openjdk.jmc.ide.launch/src/main/java/org/openjdk/jmc/ide/launch/JfrLaunchPage.java (1 line): - line 73: // TODO: Add info text and help text application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/DataPageDescriptor.java (1 line): - line 80: // FIXME: Somehow determine that page id should not be used as help context id (e.g. for generated pages) application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/preferences/QuantityFieldEditor.java (1 line): - line 145: // FIXME: The conversion to a long in storageUnit shouldn't be clamped and could overflow, if it was performed in checkState() core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/ClassLeakingRule.java (1 line): - line 84: // FIXME: This rule could perhaps be improved by doing a linear regression of the metaspace usage the higher k, the higher score. application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/PersistableSashForm.java (1 line): - line 71: // FIXME: Clean up and move to a suitable toolkit class application/org.openjdk.jmc.ui.common/src/main/java/org/openjdk/jmc/ui/common/labelingrules/NameConverter.java (1 line): - line 127: // FIXME: Somehow rewrite this to avoid things like [Unknown][Unknown] and empty () when the pid is unknown. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/cpu/ManyRunningProcessesRule.java (1 line): - line 78: // FIXME: Can we really be sure that 'concurrent' events have the exact same timestamp? core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/PasswordsInEnvironmentRule.java (1 line): - line 65: // FIXME: Should extract set of variable names instead of joined string core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/AllocationByClassRule.java (1 line): - line 93: // FIXME: Configuration attribute instead of hard coded 1000 tlabs => relevance 50 application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/persistence/internal/PersistenceFile.java (1 line): - line 105: // TODO: For now read all data application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/triggers/extension/internal/ExtensionLoader.java (1 line): - line 88: // FIXME: Better error handling core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/item/IItemConsumerFactory.java (1 line): - line 42: * FIXME: Maybe acceptType could be removed (e.g. instead represented by the factory method core/org.openjdk.jmc.agent/src/main/java/org/openjdk/jmc/agent/impl/DefaultTransformRegistry.java (1 line): - line 292: // FIXME: Implement! application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/CopySettings.java (1 line): - line 41: // FIXME: Options should be separated and not presented everywhere core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/tree/ItemTreeBuilder.java (1 line): - line 74: // FIXME: Consider introducing a maxdepth at which to stop adding nodes application/org.openjdk.jmc.console.ui/src/main/java/org/openjdk/jmc/console/ui/tabs/memory/HeapHistogram.java (1 line): - line 206: // FIXME: Create a new icon. We should not use the same icon as 'reset to defaults' and 'undo'. application/org.openjdk.jmc.console.ui.notification/src/main/java/org/openjdk/jmc/console/ui/notification/wizard/TriggerConditionWizardPage.java (1 line): - line 105: // TODO: Allow choosing of min field application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/selection/SelectionStoreActionToolkit.java (1 line): - line 91: // FIXME: Could consider a new group instead of edit. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/exceptions/ErrorRule.java (1 line): - line 165: // FIXME: List some frames of the most common stack trace application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/JOverflowFxUi.java (1 line): - line 126: // TODO: Don't do the update on the UI tread. Fixing this requires that classes are made thread safe. application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/OptimisticComparator.java (1 line): - line 96: // FIXME: identityHashCode gives no guarantee, but can we really end up here in practice? Handle differently? application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/handlers/InFocusHandlerActivator.java (1 line): - line 96: // FIXME: We should pass the appropriate IServiceLocator around instead core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/memory/AllocationByThreadRule.java (1 line): - line 91: // FIXME: Configuration attribute instead of hard coded 1000 tlabs => relevance 50 core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCOldObject.java (1 line): - line 40: // FIXME: Move IMC* classes to a subpackage core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCOldObjectField.java (1 line): - line 40: // FIXME: Move IMC* classes to a subpackage application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/common/AbstractDataPage.java (1 line): - line 62: // FIXME: Dispose these image descriptors? core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/DuplicateFlagsRule.java (1 line): - line 74: // FIXME: Should we check if there are different jvm args in different chunks? application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/selection/StacktraceFrameSelection.java (1 line): - line 70: // FIXME: What more useful flavors can we create, can we use the frame, and how to we get the distinguish by option? core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IMCModule.java (1 line): - line 38: // FIXME: Move IMC* classes to a subpackage application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/column/ColumnBuilder.java (1 line): - line 55: * FIXME: Could consider displaying null, in italics, instead of an empty string. application/org.openjdk.jmc.console.ui.mbeanbrowser/src/main/java/org/openjdk/jmc/console/ui/mbeanbrowser/notifications/NotificationInfoSectionPart.java (1 line): - line 93: // FIXME: Improve formatting of info application/org.openjdk.jmc.console.ui.notification/src/main/java/org/openjdk/jmc/console/ui/notification/widget/ConstraintChooser.java (1 line): - line 200: // FIXME: Refactor to avoid casting. All current ITriggerConstraint implementations are TriggerComponent subclasses, but this relationship could be made more explicit. application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/subscription/internal/HotSpotGcNotification.java (1 line): - line 82: // TODO: Save metadata application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ClusterGroupViewer.java (1 line): - line 195: // FIXME: Should be removed configuration/spotbugs/spotbugs-exclude.xml (1 line): - line 608: methods. One could even argue that the class should be final. TODO: check this. --> application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/triggers/IActivatableTriggerAction.java (1 line): - line 41: // FIXME: Might want to move this into ITriggerAction later? core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/general/PasswordsInSystemPropertiesRule.java (1 line): - line 66: // FIXME: Should extract set of property names instead of joined string application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/heap/model/JavaObject.java (1 line): - line 183: // TODO: eventually may want to e.g. list field values here application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/misc/QuantityKindProposal.java (1 line): - line 153: // FIXME: Really customize proposal providers to take constraint into account. application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/configuration/model/xml/XMLTagInstance.java (1 line): - line 89: // FIXME: We might need to allow elements (processContents="skip" or "lax", see XMLSchema). application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/CoreImages.java (1 line): - line 182: // FIXME: Throwing an exception has the development time advantage of being very intrusive. For release time, logging might be better. application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/formpage/commands/internal/Traverser.java (1 line): - line 122: // TODO: optimize, it is not necessary to lookup the same class again and again. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/unit/KindOfQuantity.java (1 line): - line 106: // FIXME: Currently using "~=" sign. Figure out if it would be better to use "=". application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/TemplateExportWizard.java (1 line): - line 107: // FIXME: Need large icon here, same as for the import wizard application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ReferrerTable.java (1 line): - line 79: // FIXME: Change this when javafx RT-32518 is implemented application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/TemplateEditPage.java (1 line): - line 81: // FIXME: Fix layout to left align this button. core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/ParserExtensionRegistry.java (1 line): - line 51: // FIXME: Load the synthetic attribute extension using Java Service Loader instead application/org.openjdk.jmc.flightrecorder.ui/src/main/java/org/openjdk/jmc/flightrecorder/ui/PagesImportWizard.java (1 line): - line 50: // FIXME: Choose an appropriate icon for this wizard application/org.openjdk.jmc.rjmx.services.jfr/src/main/java/org/openjdk/jmc/rjmx/services/jfr/internal/EventTypeMetadataV2.java (1 line): - line 87: // FIXME: Remove this, as something similar already is in CommonConstraints. application/org.openjdk.jmc.console.ui/src/main/java/org/openjdk/jmc/console/ui/editor/internal/ConsolePageContributionFactory.java (1 line): - line 133: // FIXME: Replace with these lines? See the comment above for discussion. core/org.openjdk.jmc.flightrecorder.rules/src/main/java/org/openjdk/jmc/flightrecorder/rules/tree/TimeRangeFilter.java (1 line): - line 45: // FIXME: Not really related to item trees. Should be moved somewhere else. application/org.openjdk.jmc.rcp.application/src/main/java/org/openjdk/jmc/rcp/application/MissionControlEditorDropAdapter.java (1 line): - line 52: // FIXME: This is an ugly hack that adds unneeded dependencies to org.openjdk.jmc.console.ui, Use extensions instead. application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/services/internal/HotSpot24DiagnosticCommandService.java (1 line): - line 132: // FIXME: Argument descriptions for JFR operations contains \" that should be ". Workaround for now. core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/IDisplayable.java (1 line): - line 40: // FIXME: Replace String format hint constants with semi-enum. application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/TypeAppearance.java (1 line): - line 58: // FIXME: If this should be visible, make sure all time related icons are unique. application/org.openjdk.jmc.ui/src/main/java/org/openjdk/jmc/ui/layout/SimpleLayout.java (1 line): - line 296: // FIXME: Implement a more efficient way to distribute pixels according to a weight factor. core/org.openjdk.jmc.flightrecorder.rules.jdk/src/main/java/org/openjdk/jmc/flightrecorder/rules/jdk/io/SocketReadRule.java (1 line): - line 154: // FIXME: This should be moved to some data provider/toolkit/whatever core/org.openjdk.jmc.common/src/main/java/org/openjdk/jmc/common/util/MCMethod.java (1 line): - line 47: // FIXME: Move MC* classes and related toolkits to a separate package? application/org.openjdk.jmc.joverflow/src/main/java/org/openjdk/jmc/joverflow/descriptors/ArrayBasedCollectionDescriptor.java (1 line): - line 211: // TODO: if (bin.getClazz().getName().equals("java.lang.Object")) { core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/parser/synthetic/SyntheticAttributeExtension.java (1 line): - line 71: // FIXME: Break out constant application/org.openjdk.jmc.joverflow.ui/src/main/java/org/openjdk/jmc/joverflow/ui/viewers/ItemPieChart.java (1 line): - line 171: // FIXME: Should be removed application/org.openjdk.jmc.flightrecorder.controlpanel.ui/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/wizards/TemplateLabelProvider.java (1 line): - line 69: // FIXME: Use in combobox in RecordingWizardPage core/org.openjdk.jmc.flightrecorder/src/main/java/org/openjdk/jmc/flightrecorder/internal/parser/v0/factories/ThreadGroup.java (1 line): - line 78: * FIXME: This probably only works within a chunk, and equals on the name is very wrong. application/org.openjdk.jmc.console.ui.notification/src/main/java/org/openjdk/jmc/console/ui/notification/uicomponents/TextInputItem.java (1 line): - line 83: // FIXME: Memory leak. Color instances need to be disposed but we must be sure that they are not used anywhere else first. application/org.openjdk.jmc.flightrecorder.controlpanel.ui.configuration/src/main/java/org/openjdk/jmc/flightrecorder/controlpanel/ui/configuration/model/gui/SelectionNode.java (1 line): - line 149: // FIXME: Why not use m_optionElements? Otherwise, why keep it? application/org.openjdk.jmc.rjmx/src/main/java/org/openjdk/jmc/rjmx/triggers/internal/NotificationRegistry.java (1 line): - line 57: // FIXME: Must be made thread safe!