src/dumbo/src/tcp/connection.rs (11 lines): - line 232: // TODO: If we ever implement window scaling, change the part that computes - line 408: // TODO: The description of this method is also a TODO in disguise. - line 437: // TODO: return the actual advance value here - line 523: // TODO: The following logic fully makes sense only for a passive open (which is what we - line 531: // TODO: If/when we support active opens, we'll also have to accept RST/SYN segments, - line 570: // TODO: Is it an overreaction to reset here? - line 651: // TODO: This is a strange situation, because the other endpoint is sending data - line 659: // TODO: This is another strange (and potentially dangerous) situation, because - line 671: // TODO: Maybe we should enqueue multiple ACKs here (after making such a thing - line 826: // TODO: like receive_segment(), this function is specific in some ways to Connections - line 1011: // TODO: I'll be honest: the tests here cover the situations most likely to be encountered, but are src/dumbo/src/tcp/endpoint.rs (5 lines): - line 25: // TODO: These are currently expressed in cycles. Normally, they would be the equivalent of a - line 36: // TODO: Maybe at some point include this in the checks we do when populating the MMDS via the API, - line 87: // TODO: mention this in doc comment for function - line 102: // TODO: Using first_not_sent() makes sense here because a connection is currently - line 217: // TODO: Maximum efficiency. src/net_gen/src/iff.rs (4 lines): - line 2626: // TODO: rename this field to adopt inclusive language once Linux updates it, too. - line 2721: // TODO: rename this constant to adopt inclusive language once Linux updates it, too. - line 2723: // TODO: rename this constant to adopt inclusive language once Linux updates it, too. - line 3076: // TODO: rename this field to adopt inclusive language once Linux updates it, too. src/dumbo/src/tcp/handler.rs (4 lines): - line 19: // TODO: This is currently IPv4 specific. Maybe change it to a more generic implementation. - line 212: // TODO: We skip verifying the checksum, just in case the device model relies on offloading - line 353: // TODO: I guess this should be refactored at some point to also remove the endpoint if found. - line 395: // TODO: Maybe get this nicely from packet at some point. src/dumbo/src/pdu/tcp.rs (3 lines): - line 90: // TODO: The implementation of TcpSegment is IPv4 specific in regard to checksum computation. Maybe - line 244: // TODO: To be super strict, we should make sure there aren't additional MSS - line 340: // TODO: Check that header_len | 0b11 == 0 and the resulting data_offset is valid? src/vmm/src/vstate/vm.rs (2 lines): - line 332: // TODO: rename this field to adopt inclusive language once Linux updates it, too. - line 334: // TODO: rename this field to adopt inclusive language once Linux updates it, too. src/vmm/src/vstate/vcpu/mod.rs (2 lines): - line 315: // TODO: we should call `KVM_KVMCLOCK_CTRL` here to make sure - line 316: // TODO continued: the guest soft lockup watchdog does not panic on Resume. src/mmds/src/ns.rs (2 lines): - line 4: // TODO: get rid of this when splitting dumbo into public and internal parts. - line 153: // TODO: We skip verifying the checksum, just in case the device model relies on offloading src/jailer/src/env.rs (2 lines): - line 368: // TODO: just now wondering ... is doing a push()/pop() thing better than just creating - line 372: // TODO: hard link instead of copy? This would save up disk space, but hard linking is src/devices/src/virtio/mmio.rs (2 lines): - line 19: //TODO crosvm uses 0 here, but IIRC virtio specified some other vendor id that should be used - line 188: // TODO: notify backend driver to stop the device src/logger/src/metrics.rs (2 lines): - line 96: // TODO: We need a better name than app_metrics (something that says that these are the actual - line 248: // TODO: would a stronger ordering make a difference here? src/vmm/src/vstate/vcpu/x86_64.rs (2 lines): - line 291: // TODO: Add negative test for this warning failure. - line 415: // TODO: Are we sure we want to finish running a vcpu upon src/dumbo/src/pdu/ethernet.rs (1 line): - line 18: // TODO: support 802.1Q tags?! If so, don't forget to change the speculative_test_* functions src/devices/src/virtio/vsock/unix/muxer.rs (1 line): - line 570: // TODO: this doesn't seem very space-efficient. src/firecracker/src/metrics.rs (1 line): - line 69: // TODO: also check for errors. Pending high level discussions on how we want src/firecracker/src/main.rs (1 line): - line 40: // TODO: generate bindings for these from the kernel sources. src/devices/src/virtio/vsock/device.rs (1 line): - line 71: // TODO: Detect / handle queue deadlock: src/devices/src/virtio/queue.rs (1 line): - line 107: // TODO log address src/snapshot/benches/version_map.rs (1 line): - line 142: // TODO: Fix the duration below to match the required time to collect enough samples. src/vmm/src/vmm_config/net.rs (1 line): - line 339: // FIXME: use macro src/arch/src/x86_64/regs.rs (1 line): - line 263: // TODO: auto-generate kvm related structures with PartialEq on. src/dumbo/src/pdu/mod.rs (1 line): - line 80: // TODO: Is u32 enough to prevent overflow for the code in this function? I think so, but it src/devices/src/virtio/block/event_handler.rs (1 line): - line 52: // TODO: also check for errors. Pending high level discussions on how we want src/devices/src/virtio/vsock/packet.rs (1 line): - line 256: /// TODO: use `GuestMemory::write_to()` and `GuestMemory::read_from()` when they are stable src/dumbo/src/pdu/arp.rs (1 line): - line 409: // TODO: The following test code is way more verbose than it should've been. Make it src/utils/src/net/mac.rs (1 line): - line 87: // TODO: using something like std::mem::uninitialized could avoid the extra initialization, src/vmm/src/vmm_config/mod.rs (1 line): - line 38: // TODO: Migrate the VMM public-facing code (i.e. interface) to use stateless structures, src/vmm/src/rpc_interface.rs (1 line): - line 596: // FIXME: we're losing the bool saying whether metrics were actually written. src/dumbo/src/pdu/udp.rs (1 line): - line 137: // TODO working with IPv4 only for now src/vmm/src/vstate/vcpu/aarch64.rs (1 line): - line 165: // TODO: Are we sure we want to finish running a vcpu upon src/rate_limiter/src/lib.rs (1 line): - line 468: // TODO: Please note that, right now, the buckets become full after being updated. src/cpuid/src/common.rs (1 line): - line 30: // TODO: replace with validation based on `has_cpuid()` when it becomes stable: src/devices/src/virtio/net/device.rs (1 line): - line 73: // TODO: any better way to set all these bytes to 0? Or is this optimized by the compiler? src/devices/src/virtio/net/event_handler.rs (1 line): - line 58: // TODO: also check for errors. Pending high level discussions on how we want