alerting/src/main/kotlin/org/opensearch/alerting/MonitorRunner.kt (7 lines): - line 313: // TODO: This method has grown very large with all the business logic that has been added. - line 362: // TODO: Since a composite aggregation is being used for the input query, the total bucket count cannot be determined. - line 398: // TODO: Should triggerResult's aggregationResultBucket be a list? If not, getCategorizedAlertsForBucketLevelMonitor can - line 540: // TODO: Update BucketLevelTriggerRunResult.alertError() to retrieve error based on the first failed Action - line 600: // TODO: Remove "AmazonES_all_access" role? - line 607: // TODO: Can this be updated to just use 'Instant.now()'? - line 673: // TODO: This is largely a duplicate of runAction above for BucketLevelTriggerExecutionContext for now. alerting/src/main/kotlin/org/opensearch/alerting/AlertService.kt (5 lines): - line 84: // TODO: This should be limited based on a circuit breaker that limits Alerts - line 212: // TODO: Can change the parameters to use ctx: BucketLevelTriggerExecutionContext instead of monitor/trigger and - line 214: // TODO: Can refactor this method to use Sets instead which can cleanup some of the categorization logic (like getting completed alerts) - line 358: // TODO: This is only used to retrieve the retryCause, could instead fetch it from the bulkResponse iteration below - line 365: // TODO: What if the failure cause was not TOO_MANY_REQUESTS, should these be saved and logged? alerting/src/main/kotlin/org/opensearch/alerting/InputService.kt (2 lines): - line 53: // TODO: If/when multiple input queries are supported for Bucket-Level Monitor execution, aggTriggerAfterKeys will - line 58: // TODO: Figure out a way to use SearchTemplateRequest without bringing in the entire TransportClient alerting/src/main/kotlin/org/opensearch/alerting/model/Monitor.kt (2 lines): - line 49: // TODO: Check how this behaves during rolling upgrade/multi-version cluster - line 84: // TODO: Keeping query validation simple for now, only term aggregations have full support for the "group by" on the alerting/src/main/kotlin/org/opensearch/alerting/resthandler/RestSearchMonitorAction.kt (1 line): - line 48: * TODO: Deprecate API for a set of new APIs that will support this APIs use cases alerting/src/main/kotlin/org/opensearch/alerting/model/AggregationResultBucket.kt (1 line): - line 24: val bucket: Map? // TODO: Should reduce contents to only top-level to not include sub-aggs here alerting/src/main/kotlin/org/opensearch/alerting/TriggerService.kt (1 line): - line 70: // TODO test this part by passing sub-aggregation path alerting/src/main/kotlin/org/opensearch/alerting/aggregation/bucketselectorext/BucketSelectorExtAggregator.kt (1 line): - line 132: // TODO: can we use one instance of the script for all buckets? it should be stateless?