Places in code with 6 or more lines that are exactly the same.
Intro
- For duplication, we look at places in code where there are 6 or more lines of code that are exactly the same.
- Before duplication is calculated, the code is cleaned to remove empty lines, comments, and frequently duplicated constructs such as imports.
- You should aim at having as little as possible (<5%) of duplicated code as high-level of duplication can lead to maintenance difficulties, poor factoring, and logical contradictions.
- To learn more about duplications and techniques for eliminating duplication, Sokrates recommends the following resources:
- Avoid Repetition, MartinFlower.com (IEEE Software article)
- Refactoring duplicated code, sourcemaking.com
- Beck Design Rules, MartinFowler.com
- DRY (Don't Repeat Yourself) Principle, Wikipedia
- The Cut-and-Paste Programming Software Development Anti-Pattern, sourcemaking.com
- Code Smells / Duplicated Code, Jeff Atwood, codinghorror.com:
- "Duplicated code is the bane of software development. Stamp out duplication whenever possible. You should always be on the lookout for more subtle cases of near-duplication, too. Don't Repeat Yourself!"
- Reducing Coupling, MartinFlower.com (IEEE Software article):
- "There are several ways to describe coupling, but it boils down to this: If changing one module in a program requires changing another module, then coupling exists. ... Duplication always implies coupling, because changing one piece of duplicate code implies changing the other."
Duplication Overall
- 15% duplication:
- 24,640 cleaned lines of cleaned code (without empty lines, comments, and frequently duplicated constructs such as imports)
- 3,709 duplicated lines
- 328 duplicates
Duplication per Extension
Duplication per Component (primary)
Duplication Between Components (50+ lines)
Open 3D force graph...
Show more details on duplication between components...
From Component
--> To Component
Duplicated
Lines
File Pairs
Details
legacy/securityconfig_v6 (27%)
--> securityconfig (26%)
222
1 file pair
details...
src/main/java/org/opensearch/security/configuration (2%)
--> src/main/java/org/opensearch/security/securityconf (1%)
117
2 file pairs
details...
src/main/java/org/opensearch/security/rest (22%)
--> src/main/java/org/opensearch/security/ssl (2%)
116
12 file pairs
details...
src/main/java/org/opensearch/security/auditlog (2%)
--> src/main/java/org/opensearch/security/securityconf (1%)
104
2 file pairs
details...
src/main/java/org/opensearch/security/resolver (11%)
--> src/main/java/org/opensearch/security/securityconf (1%)
90
2 file pairs
details...
src/main/java/org/opensearch/security/securityconf (1%)
--> src/main/java/org/opensearch/security/user (23%)
90
2 file pairs
details...
src/main/java/org/opensearch/security/dlic (1%)
--> src/main/java/org/opensearch/security/rest (12%)
64
3 file pairs
details...
| From Component --> To Component |
Duplicated Lines |
File Pairs | Details |
|---|---|---|---|
| legacy/securityconfig_v6 (27%) --> securityconfig (26%) |
222 | 1 file pair | details... |
| src/main/java/org/opensearch/security/configuration (2%) --> src/main/java/org/opensearch/security/securityconf (1%) |
117 | 2 file pairs | details... |
| src/main/java/org/opensearch/security/rest (22%) --> src/main/java/org/opensearch/security/ssl (2%) |
116 | 12 file pairs | details... |
| src/main/java/org/opensearch/security/auditlog (2%) --> src/main/java/org/opensearch/security/securityconf (1%) |
104 | 2 file pairs | details... |
| src/main/java/org/opensearch/security/resolver (11%) --> src/main/java/org/opensearch/security/securityconf (1%) |
90 | 2 file pairs | details... |
| src/main/java/org/opensearch/security/securityconf (1%) --> src/main/java/org/opensearch/security/user (23%) |
90 | 2 file pairs | details... |
| src/main/java/org/opensearch/security/dlic (1%) --> src/main/java/org/opensearch/security/rest (12%) |
64 | 3 file pairs | details... |
Longest Duplicates
The list of 20 longest duplicates.
| Size | # | Folders | Files | Lines | Code |
|---|---|---|---|---|---|
| 138 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf |  ConfigModelV6.javaConfigModelV7.java |
266:483 (19%)252:470 (21%) | view |
| 67 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | DynamicConfigModelV6.javaDynamicConfigModelV7.java |
267:377 (28%)266:376 (28%) | view |
| 61 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | ConfigModelV6.javaConfigModelV7.java |
848:936 (8%)783:936 (9%) | view |
| 56 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | DynamicConfigModelV6.javaDynamicConfigModelV7.java |
86:160 (23%)86:160 (23%) | view |
| 34 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | ConfigModelV6.javaConfigModelV7.java |
1050:1103 (4%)1014:1067 (5%) | view |
| 30 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | ConfigModelV6.javaConfigModelV7.java |
696:727 (4%)692:723 (4%) | view |
| 29 | x 2 | src/main/java/com/amazon/dlic/auth/ldap/backendsrc/main/java/com/amazon/dlic/auth/ldap2 | LDAPAuthorizationBackend.javaLDAPAuthorizationBackend2.java |
891:945 (4%)351:405 (9%) | view |
| 29 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | DynamicConfigModelV6.javaDynamicConfigModelV7.java |
381:425 (12%)380:424 (12%) | view |
| 29 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | ConfigModelV6.javaConfigModelV7.java |
742:784 (4%)738:780 (4%) | view |
| 28 | x 2 | src/main/java/com/amazon/dlic/auth/ldap/backendsrc/main/java/com/amazon/dlic/auth/ldap2 | LDAPAuthorizationBackend.javaLDAPAuthorizationBackend2.java |
1059:1110 (4%)506:557 (9%) | view |
| 26 | x 2 | src/main/java/org/opense...ty/securityconf/impl/v6src/main/java/org/opense...ty/securityconf/impl/v7 | ConfigV6.javaConfigV7.java |
267:310 (15%)394:439 (10%) | view |
| 26 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | DynamicConfigModelV6.javaDynamicConfigModelV7.java |
222:262 (10%)222:262 (11%) | view |
| 25 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | ConfigModelV6.javaConfigModelV7.java |
586:612 (3%)586:612 (3%) | view |
| 25 | x 2 | src/main/java/org/opense...ty/securityconf/impl/v6src/main/java/org/opense...ty/securityconf/impl/v7 | ConfigV6.javaConfigV7.java |
103:141 (14%)154:194 (10%) | view |
| 25 | x 2 | src/main/java/com/amazon/dlic/auth/ldap/backendsrc/main/java/com/amazon/dlic/auth/ldap2 | LDAPAuthorizationBackend.javaLDAPAuthorizationBackend2.java |
847:888 (3%)307:348 (8%) | view |
| 24 | x 2 | src/main/java/com/amazon/dlic/auth/ldap/backendsrc/main/java/com/amazon/dlic/auth/ldap2 | LDAPAuthorizationBackend.javaLDAPAuthorizationBackend2.java |
787:835 (3%)251:299 (7%) | view |
| 24 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | DynamicConfigModelV6.javaDynamicConfigModelV7.java |
182:216 (10%)182:217 (10%) | view |
| 22 | x 2 | legacy/securityconfig_v6securityconfig |  config.ymlconfig.yml |
142:171 (18%)152:181 (17%) | view |
| 22 | x 2 | legacy/securityconfig_v6securityconfig | config.ymlconfig.yml |
172:214 (18%)183:225 (17%) | view |
| 20 | x 2 | src/main/java/com/amazon/dlic/auth/ldap/backendsrc/main/java/com/amazon/dlic/auth/ldap2 | LDAPAuthenticationBackend.javaLDAPAuthenticationBackend2.java |
117:153 (13%)151:187 (14%) | view |
Duplicated Units
The list of top 20 duplicated units.
| Size | # | Folders | Files | Lines | Code |
|---|---|---|---|---|---|
| 40 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | DynamicConfigModelV7.javaDynamicConfigModelV6.java |
374:428 375:429 | view |
| 25 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | ConfigModelV6.javaConfigModelV7.java |
746:773 742:769 | view |
| 16 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | ConfigModelV6.javaConfigModelV7.java |
882:898 882:898 | view |
| 14 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | ConfigModelV6.javaConfigModelV7.java |
326:340 312:326 | view |
| 14 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | ConfigModelV6.javaConfigModelV7.java |
906:922 906:922 | view |
| 12 | x 2 | src/main/java/com/amazon/dlic/auth/http/kerberossrc/main/java/com/amazon/dlic/auth/http/jwt | HTTPSpnegoAuthenticator.javaHTTPJwtAuthenticator.java |
169:184 118:133 | view |
| 10 | x 2 | src/main/java/com/amazon/dlic/auth/ldap/backendsrc/main/java/com/amazon/dlic/auth/ldap2 | LDAPAuthorizationBackend.javaLDAPAuthorizationBackend2.java |
1076:1089 523:536 | view |
| 9 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | ConfigModelV6.javaConfigModelV7.java |
470:479 457:466 | view |
| 8 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | ConfigModelV6.javaConfigModelV7.java |
354:362 341:349 | view |
| 8 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | DynamicConfigModelV7.javaDynamicConfigModelV6.java |
344:352 345:353 | view |
| 7 | x 2 | src/main/java/org/opense.../security/ssl/transportsrc/main/java/org/opense.../security/ssl/transport | SecuritySSLNettyTransport.javaSecuritySSLNettyTransport.java |
137:146 167:176 | view |
| 7 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | ConfigModelV6.javaConfigModelV7.java |
460:467 447:454 | view |
| 7 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | ConfigModelV6.javaConfigModelV7.java |
924:931 924:931 | view |
| 7 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | DynamicConfigModelV7.javaDynamicConfigModelV6.java |
85:92 85:92 | view |
| 6 | x 2 | src/main/java/org/opense.../security/dlic/rest/apisrc/main/java/org/opense.../security/dlic/rest/api | NodesDnApiAction.javaWhitelistApiAction.java |
93:99 107:113 | view |
| 6 | x 2 | src/main/java/org/opense.../security/dlic/rest/apisrc/main/java/org/opense.../security/dlic/rest/api | AuthTokenProcessorAction.javaInternalUsersApiAction.java |
52:58 71:77 | view |
| 6 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | ConfigModelV6.javaConfigModelV7.java |
873:879 873:879 | view |
| 6 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | DynamicConfigModelV7.javaDynamicConfigModelV6.java |
354:363 355:364 | view |
| 6 | x 2 | src/main/java/org/opensearch/security/securityconfsrc/main/java/org/opensearch/security/securityconf | DynamicConfigModelV7.javaDynamicConfigModelV6.java |
365:372 366:373 | view |
| 6 | x 2 | src/main/java/org/opense...ty/securityconf/impl/v6src/main/java/org/opense...ty/securityconf/impl/v7 | ConfigV6.javaConfigV7.java |
145:151 209:215 | view |