core/src/main/java/org/apache/brooklyn/core/entity/AbstractEntity.java (29 lines): - line 249: // FIXME we do not currently support changing parents, but to implement a cluster that can shrink we need to support at least - line 313: // FIXME don't leak this reference in constructor - even to utils - line 321: // TODO Don't let `this` reference escape during construction - line 369: // TODO use a config bag instead - line 372: // FIXME Need to set parent with proxy, rather than `this` - line 408: // TODO the default values on flags are not used? (we should remove that support, since ConfigKeys gives a better way) - line 415: // TODO use a config bag and remove the ones set above in the code below - line 698: // TODO revert to EnricherSupportInternal when groovy subclasses work without this (eg new groovy version) - line 709: // TODO revert to private when groups() is reverted to return GroupSupport - line 779: // TODO Can this really be deleted? Overridden by AbstractApplication; needs careful review - line 880: // TODO will not be required in future releases when creating locations always goes through LocationManager.createLocation(LocationSpec). - line 901: // TODO Not calling `Entities.unmanage(removedLocation)` because this location might be shared with other entities. - line 944: // TODO revert to ConfigurationSupportInternal when groovy subclasses work without this (eg new groovy version) - line 953: // TODO revert to SensorsSupportInternal when groovy subclasses work without this (eg new groovy version) - line 964: // TODO revert to private when config() is reverted to return SensorSupportInternal - line 1057: // TODO Conditionally set onAttributeChanged, only if was modified - line 1138: // TODO revert to private when config() is reverted to return ConfigurationSupportInternal - line 1205: // TODO can this be replaced with config().set ? - line 1224: // TODO revert to SubscriptionSupportInternal when groovy subclasses work without this (eg new groovy version) - line 1235: // TODO revert to private when config() is reverted to return SensorSupportInternal - line 1307: // TODO Would be nice to simplify concurrent model, and not synchronize on - line 1394: // TODO revert to PolicySupportInternal when groovy subclasses work without this (eg new groovy version) - line 1403: // TODO revert to EnricherSupportInternal when groovy subclasses work without this (eg new groovy version) - line 1527: // TODO Could add equivalent of AbstractEntity.POLICY_ADDED for enrichers; no use-case for that yet - line 1585: // TODO workaround for issue where enrichers/feeds/policies can get added multiple times on rebind, - line 1681: // TODO Could add equivalent of AbstractEntity.POLICY_ADDED for feeds; no use-case for that yet - line 1723: // TODO add these back when we implement AdjunctSupport (after 1.0.0) - line 1850: // TODO Just rely on GC of this entity instance, to get rid of the children map etc. - line 1852: // TODO move this to EntityMangementSupport, locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocation.java (28 lines): - line 186: // TODO After converting from Groovy to Java, this is now very bad code! It relies entirely on putting - line 190: // TODO test (and fix) ability to set config keys from flags - line 192: // TODO we say config is inherited, but it isn't the case for many "deep" / jclouds properties - line 297: // TODO should be able to use ConfigBag.newInstanceExtending; would require moving stuff around to api etc - line 300: .configure(config().getLocalBag().getAllConfig()) // FIXME Should this just be inherited? - line 463: // TODO remove tagMapping, or promote it - line 471: // TODO Decide on semantics. If I give "TomcatServer" and "Ubuntu", then must I get back an image that matches both? - line 581: // FIXME revert to computeService.destroyNode(cloudServiceId); once JCLOUDS-1332 gets fixed - line 692: // FIXME How do we influence the node.getLoginPort, so it is set correctly for Windows? - line 741: // TODO Was this too early to look at template.getImage? e.g. customizeTemplate could subsequently modify it. - line 753: // TODO it would be nice if this salt comes from the location's ID (but we don't know that yet as the ssh machine location isn't created yet) - line 754: // TODO in softlayer we want to control the suffix of the hostname which is 3 random hex digits - line 952: // TODO: Generate Windows Hostname - line 957: // also see TODO in SetHostnameCustomizer - ideally we share code between here and there - line 1176: // TODO Should we add an `orExecuteInSameThread()` in `TaskQueueingResult`? - line 1556: // TODO this injection is hacky and (currently) cloud specific. - line 1689: // TODO use key - line 1812: // TODO Retrying lots of times as workaround for vcloud-director. There the guest customizations - line 2264: // FIXME: Needs to release port forwarding for WinRmMachineLocations - line 2360: // FIXME revert to computeService.destroyNode(instanceId); once JCLOUDS-1332 gets fixed - line 2380: // TODO Implementation needs revisisted. It relies on deprecated PortForwardManager methods. - line 2584: // TODO will this just be a NumberFormatException? If so, catch that specificially - line 2950: // TODO Discouraged to do cloud-specific things; think of this code for aws as an - line 2979: // TODO If POLL_FOR_FIRST_REACHABLE_ADDRESS=false, then won't have checked if any node is reachable. - line 2980: // TODO Some of the private addresses might not be reachable, should check connectivity before - line 2982: // TODO Choose an IP once and stick to it - multiple places call JcloudsUtil.getFirstReachableAddress(), - line 3064: // TODO messy way to get an SSH session - line 3179: // TODO Very similar to EntityConfigMap.deepMerge core/src/main/java/org/apache/brooklyn/location/ssh/SshMachineLocation.java (15 lines): - line 204: // TODO remove - line 234: // TODO: Fully specify. - line 332: // TODO: Does it matter that this is synchronous? - Can closing pools cause long delays? - line 419: // TODO Note that check for addresss!=null is done automatically in super-constructor, in FlagUtils.checkRequiredFields - line 480: // TODO close has been used for a long time to perform clean-up wanted on unmanagement, but that's not clear; - line 620: // TODO make this config-setting mechanism more universal - line 688: // TODO submitCommands and submitScript which submit objects we can subsequently poll (cf JcloudsSshMachineLocation.submitRunScript) - line 815: // FIXME the return code is not a reliable indicator of success or failure - line 827: // FIXME the return code is not a reliable indicator of success or failure - line 837: // FIXME the return code is not a reliable indicator of success or failure - line 869: * TODO allow s3://bucket/file URIs for AWS S3 resources - line 870: * TODO use PAX-URL style URIs for maven artifacts - line 871: * TODO use subtasks here for greater visibility?; deprecate in favour of SshTasks.installFromUrl? - line 892: bash.INSTALL_CURL, // TODO should hold the 'installing' mutex - line 941: // TODO Does not yet check if the port really is free on this machine core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindIteration.java (15 lines): - line 331: // TODO building the manifests should be part of this class (or parent) - line 728: // TODO these call to the entity which in turn sets the entity on the underlying feeds and enrichers; - line 765: // TODO these call to the entity which in turn sets the entity on the underlying feeds and enrichers; - line 801: // TODO could also see about purging unreferenced locations - line 954: //TODO under what circumstances is this permitted? - line 992: // TODO get to the point when we can deprecate this behaviour!: - line 1054: // TODO Feels very hacky! - line 1060: // TODO document the multiple sources of flags, and the reason for setting the mgmt context *and* - line 1069: // TODO On serializing the memento, we should capture which interfaces so can recreate - line 1096: // TODO should prefer a registered type as the type to load (in lieu of jType), - line 1206: // TODO fail, rather than fallback to java? - line 1305: // TODO Need to rationalise this to move code into methods of InternalLocationFactory. - line 1321: // TODO Feels very hacky! - line 1351: // TODO Feels very hacky! - line 1386: // TODO Feels very hacky! core/src/main/java/org/apache/brooklyn/core/catalog/CatalogPredicates.java (12 lines): - line 58: // TODO PERSISTENCE WORKAROUND kept anonymous function in case referenced in persisted state - line 88: // TODO PERSISTENCE WORKAROUND kept anonymous function in case referenced in persisted state - line 158: // TODO PERSISTENCE WORKAROUND kept anonymous function in case referenced in persisted state - line 168: // TODO PERSISTENCE WORKAROUND kept anonymous function in case referenced in persisted state - line 186: // TODO PERSISTENCE WORKAROUND kept anonymous function in case referenced in persisted state - line 216: // TODO PERSISTENCE WORKAROUND kept anonymous function in case referenced in persisted state - line 246: // TODO PERSISTENCE WORKAROUND kept anonymous function in case referenced in persisted state - line 276: // TODO Previously the impl relied on catalogItem.toXmlString() to get a string - line 312: // TODO PERSISTENCE WORKAROUND kept anonymous function in case referenced in persisted state - line 326: * TODO Kept for backwards compatibility, in case it is reference in customer persisted state. - line 346: // TODO PERSISTENCE WORKAROUND kept anonymous function in case referenced in persisted state - line 378: // TODO PERSISTENCE WORKAROUND kept anonymous function in case referenced in persisted state utils/common/src/main/java/org/apache/brooklyn/util/text/StringFunctions.java (12 lines): - line 36: // TODO PERSISTENCE WORKAROUND - line 50: // TODO PERSISTENCE WORKAROUND - line 64: // TODO PERSISTENCE WORKAROUND - line 76: // TODO PERSISTENCE WORKAROUND - line 88: // TODO PERSISTENCE WORKAROUND - line 100: // TODO PERSISTENCE WORKAROUND - line 113: // TODO PERSISTENCE WORKAROUND - line 126: // TODO PERSISTENCE WORKAROUND - line 139: // TODO PERSISTENCE WORKAROUND - line 153: // TODO PERSISTENCE WORKAROUND - line 165: // TODO PERSISTENCE WORKAROUND - line 177: // TODO PERSISTENCE WORKAROUND software/winrm/src/main/java/org/apache/brooklyn/location/winrm/WinRmMachineLocation.java (11 lines): - line 102: * TODO Winrm supports several authentication mechanisms so it would be better to replace it with a prioritised list of authentication mechanisms to try. - line 107: // TODO merge with {link SshTool#PROP_USER} and {@link SshMachineLocation#user}? - line 110: // TODO merge with {link SshTool#PROP_PASSWORD}? - line 113: // TODO Delete once winrm4j supports this better? - line 151: // TODO See SshTool#PROP_SSH_TRIES, where it was called "sshTries"; remove duplication? Merge into one well-named thing? - line 203: // TODO: detect actual machine details via winRM - line 398: // TODO See comments/TODOs in SshMachineLocation.connectSsh() - line 419: // TODO make this config-setting mechanism more universal - line 519: // FIXME USE_HTTPS_WINRM - line 551: /* TODO: Find out why scripts with new line characters aren't working on AWS. The following appears as if it *should* - line 577: // TODO this is simplistic, writes at c:\ for HOME utils/common/src/main/java/org/apache/brooklyn/util/math/MathFunctions.java (10 lines): - line 33: // TODO PERSISTENCE WORKAROUND - line 46: // TODO PERSISTENCE WORKAROUND - line 59: // TODO PERSISTENCE WORKAROUND - line 72: // TODO PERSISTENCE WORKAROUND - line 85: // TODO PERSISTENCE WORKAROUND - line 98: // TODO PERSISTENCE WORKAROUND - line 111: // TODO PERSISTENCE WORKAROUND - line 124: // TODO PERSISTENCE WORKAROUND - line 140: // TODO PERSISTENCE WORKAROUND - line 154: // TODO PERSISTENCE WORKAROUND core/src/main/java/org/apache/brooklyn/util/core/internal/ssh/sshj/SshjTool.java (10 lines): - line 79: * TODO synchronization of connect/disconnect needs revisited! - line 88: * TODO need to upgrade sshj version from 0.8.1 to 0.9, but jclouds 1.7.2 still - line 261: return 0; // TODO Can we assume put will have thrown exception if failed? Rather than exit code != 0? - line 338: * TODO There are (probably) issues with this method when using {@link ShellTool#PROP_RUN_AS_ROOT}. - line 424: // TODO also execute this if the `buildRunScriptCommand` fails, as that might have left files behind? - line 442: // TODO Additional stdout/stderr written by buildLongPollCommand() could interfere, - line 506: // TODO How to ensure no additional output in stdout/stderr when parsing below? - line 623: * TODO In net.schmizz.sshj.SSHClient.auth(SSHClient.java:204) throws AssertionError - line 729: // TODO support backup as a property? - line 802: // TODO simpler not to use predicates (this seems not to be used) utils/common/src/main/java/org/apache/brooklyn/util/ssh/BashCommandsConfigurable.java (9 lines): - line 118: // TODO would like to move away from sudoOld -- but needs extensive testing! - line 150: // TODO would like to move away from sudoOld -- but needs extensive testing! - line 154: // // FIXME still doesn't always work e.g. doesn't have path of user - line 207: // TODO a builder would be better than these ifBlahExistsElseBlah methods! - line 532: // TODO How platform-dependent are the args + output format of netstat? - line 533: // TODO Not using sudo as wrapping either netstat call or sudo(alternativesGroup(...)) fails; parentheses too confusing! - line 802: // TODO Should we run `sudo service hostname restart` or `sudo /etc/init.d/hostname restart`? - line 805: // TODO What if /etc/sysconfig/network doesn't have a line for HOSTNAME=...? - line 807: // TODO What about hostPart ending in "." - see http://www.dns-sd.org/trailingdotsindomainnames.html core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalEntityManager.java (9 lines): - line 335: // TODO synchronization issues here. We guard with isManaged(), but if another thread executing - line 340: // TODO We need to do some check about isPreManaged - i.e. is there another thread (or is this a - line 344: // TODO Also see LocalLocationManager.manage(Entity), if fixing things here - line 369: /* TODO we sloppily use "recursive" to ensure ordering of parent-first in many places - line 447: // the TODO above removing manageRebindRoot in favour of explicit mgmt list would clean this up a lot! - line 475: // TODO don't want to guess; should we inspect state of e ? or maybe it doesn't matter ? - line 570: /* TODO tidy up when it is recursive and when it isn't; if something is being unloaded or destroyed, - line 762: return; // TODO Still a race for terminate being called, and then isManaged below returning false - line 926: * TODO Does getting then removing from groups risk this entity being added to other groups while policy/src/main/java/org/apache/brooklyn/policy/autoscaling/AutoScalerPolicy.java (9 lines): - line 235: // TODO Is there a nicer pattern for registering such type-coercions? - line 543: // TODO Should re-use the execution manager's thread pool, somehow - line 684: // TODO If recorded what last metric value was then we could recalculate immediately - line 709: // TODO see above about changing metricLowerBound; not triggering resize now - line 719: // TODO unsubscribe from everything? And resubscribe on resume? - line 1018: // TODO Make scale-out calls concurrent, rather than waiting for first resize to entirely - line 1074: // TODO Could have max period for notifications, or a step increment to warn when exceeded by ever bigger amounts - line 1093: // TODO Could check if there has been anything bigger than "min" since min happened (would be more efficient) - line 1140: // TODO Should we use int throughout, rather than casting here? software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcessImpl.java (8 lines): - line 278: * TODO improve the framework's feed system to detect duplicate additions - line 319: // TODO race because the is-running check may be mid-task - line 337: // TODO feels like that confusion could be eliminated with a single place for pre/post logic!) - line 345: // TODO Is there a race where disconnectSensors could leave a task of the feeds still running - line 496: // FIXME What if location not set? - line 605: // TODO Find a better way to detect early death of process. - line 638: // TODO use Repeater - line 675: // TODO There is a race where we set SERVICE_UP=false while sensor-adapter threads may still be polling. policy/src/main/java/org/apache/brooklyn/policy/loadbalancing/BalancingStrategy.java (8 lines): - line 37: * TODO: extract interface, provide default implementation - line 38: * TODO: remove legacy code comments - line 42: // FIXME Bad idea to use MessageFormat.format in this way; if toString of entity contains - line 180: // node presumably has been removed; TODO log - line 415: // hotNode presumably has been removed; TODO log - line 582: if (cost < 0) { // FIXME: already tested above - line 586: if (cost <= 0) { // FIXME: overlaps previous condition - line 593: if (!model.isItemMoveable(item)) { // FIXME: already tested above core/src/main/java/org/apache/brooklyn/entity/group/DynamicClusterImpl.java (8 lines): - line 136: // TODO better mechanism for arbitrary class name to instance type coercion - line 556: // TODO check that these are valid region / availabilityZones? - line 865: // FIXME symmetry in order of added as child, managed, started, and added to group - line 970: // TODO Could also call stop on them? - line 977: // TODO Could have CompoundException, rather than propagating first - line 1024: // TODO should refactor to have a createNodeSpec; and spec should support initial sensor values - line 1060: // TODO inefficient impl - line 1090: // TODO inefficient impl core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/dto/MementosGenerators.java (8 lines): - line 125: // TODO the dynamic attributeKeys and configKeys are computed in the BasicEntityMemento - line 149: // TODO Not transforming; that code is deleted in another pending PR anyway! - line 199: * TODO When we have a cleaner separation of constructor/config for entities and locations, then - line 267: // TODO persist config keys as well? Or only support those defined on policy class; - line 293: // TODO persist config keys as well? Or only support those defined on policy class; - line 317: // TODO persist config keys as well? Or only support those defined on policy class; - line 409: // TODO Swapping an attributeWhenReady task for the actual value, if completed. - line 428: // TODO how to record a completed but errored task? camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynComponentTemplateResolver.java (8 lines): - line 189: // TODO propagate exception so we can provide better error messages - line 451: // TODO We should remove duplicates, rather than just doing the `put` multiple times, - line 472: // TODO merge *bagFlags* with existing spec params, merge yaml w yaml parent params elsewhere - line 496: // TODO use in BasicSpecParameter to resolve ancestor config keys ? - line 507: // TODO currently at this point parameters have been merged with ancestor spec parameters, - line 521: /* TODO find a way to make do without loader here? - line 561: // TODO currently loader will non-null unless someone has messed with the rebind files, - line 576: // TODO: This should called from BrooklynAssemblyTemplateInstantiator.configureEntityConfig core/src/main/java/org/apache/brooklyn/feed/http/JsonFunctions.java (8 lines): - line 63: // TODO PERSISTENCE WORKAROUND - line 74: // TODO PERSISTENCE WORKAROUND - line 90: // TODO PERSISTENCE WORKAROUND - line 109: // TODO PERSISTENCE WORKAROUND - line 126: // TODO PERSISTENCE WORKAROUND - line 145: // TODO PERSISTENCE WORKAROUND - line 159: // TODO PERSISTENCE WORKAROUND - line 170: // TODO PERSISTENCE WORKAROUND core/src/main/java/org/apache/brooklyn/core/location/LocationPredicates.java (7 lines): - line 38: // TODO PERSISTENCE WORKAROUND - line 50: // TODO PERSISTENCE WORKAROUND - line 62: // TODO PERSISTENCE WORKAROUND - line 74: // TODO PERSISTENCE WORKAROUND - line 89: // TODO PERSISTENCE WORKAROUND - line 101: // TODO PERSISTENCE WORKAROUND - line 121: // TODO PERSISTENCE WORKAROUND software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/MachineLifecycleEffectorTasks.java (7 lines): - line 205: // TODO included anonymous inner class for backwards compatibility with persisted state. - line 251: // TODO included anonymous inner class for backwards compatibility with persisted state. - line 276: // TODO included anonymous inner class for backwards compatibility with persisted state. - line 517: // FIXME: Who or what is SSH_ADDRESS intended for? It's not necessarily the address that - line 737: // TODO should we consult ChildStartableMode? - line 878: // TODO we should test for destruction above, not merely successful "stop", as things like localhost and ssh won't be destroyed - line 1097: // TODO On exception, should we add the machine back to the entity (because it might not really be terminated)? core/src/main/java/org/apache/brooklyn/core/entity/EntityFunctions.java (7 lines): - line 53: // TODO PERSISTENCE WORKAROUND - line 65: // TODO PERSISTENCE WORKAROUND - line 77: // TODO PERSISTENCE WORKAROUND - line 89: // TODO PERSISTENCE WORKAROUND - line 101: // TODO PERSISTENCE WORKAROUND - line 126: // TODO PERSISTENCE WORKAROUND - line 139: // TODO PERSISTENCE WORKAROUND core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/RebindManagerImpl.java (7 lines): - line 95: // TODO Use ImmediateDeltaChangeListener if the period is set to 0? - line 125: // TODO separate times for persist and read-only rebind, allow configurable, default at least for RO rebind larger - line 162: * TODO What is a better way to do this?! - line 259: // TODO should probably throw here, but previously we have not -- so let's log for now to be sure it's not happening - line 416: // TODO inputs should be configurable - line 504: // TODO we might want different exception handling for partials; - line 682: * TODO Inefficient implementation! software/base/src/main/java/org/apache/brooklyn/entity/brooklynnode/effector/BrooklynNodeUpgradeEffectorBody.java (6 lines): - line 165: // TODO require entity() node state master or hot standby AND require persistence enabled, or a new 'force_attempt_upgrade' parameter to be applied - line 166: // TODO could have a 'skip_dry_run_upgrade' parameter - line 167: // TODO could support 'dry_run_only' parameter, with optional resumption tasks (eg new dynamic effector) - line 176: // TODO alternatively could use REST API as in BrooklynClusterUpgradeEffectorBody - line 177: // TODO Want better way to append to the config (so can do it all in the spec) - line 216: // TODO when there are PERSIST* options in BrooklynNode, look at them here! core/src/main/java/org/apache/brooklyn/core/typereg/BasicBrooklynTypeRegistry.java (6 lines): - line 98: // TODO optimisation? make indexes and look up? - line 146: // TODO ideally never come here, however - line 290: // TODO type is only used to call to "transform"; we should perhaps change transform so it doesn't need the type? - line 297: // TODO implement using java if permitted - line 306: // TODO remove once all transformers are available in the new style - line 388: // TODO create type using java if permitted? locations/container/src/main/java/org/apache/brooklyn/container/location/kubernetes/KubernetesLocation.java (6 lines): - line 353: // TODO only returns info on the first item :| - line 503: ImmutableMap.of( // TODO investigate why SSH connection does not time out with this config - line 842: .withLabels(ImmutableMap.of("type", "local")) // TODO make it configurable - line 845: .addToCapacity("storage", new QuantityBuilder().withAmount("20").build()) // TODO make it configurable - line 846: .addToAccessModes("ReadWriteOnce") // TODO make it configurable - line 847: .withNewHostPath().withPath("/tmp/pv-1").endHostPath() // TODO make it configurable software/base/src/main/java/org/apache/brooklyn/entity/brooklynnode/BrooklynNodeImpl.java (6 lines): - line 271: // TODO support YAML parsing - line 272: // TODO define a new type YamlMap for the config key which supports coercing from string and from map - line 282: // TODO ideally, parse YAML - line 454: // TODO what sensors should we poll? - line 488: // TODO sensors for load, size, etc - line 492: // TODO when updating the map, if it would change from empty to empty on a successful run (see in nginx) core/src/main/java/org/apache/brooklyn/core/mgmt/persist/BrooklynMementoPersisterToObjectStore.java (6 lines): - line 99: // TODO Crazy amount of duplication between handling entity, location, policy, enricher + feed; - line 102: // TODO Should stop() take a timeout, and shutdown the executor gracefully? - line 167: // FIXME does it belong here or to ManagementPlaneSyncRecordPersisterToObjectStore ? - line 205: // TODO enrichers etc aren't yet known -- would need to backtrack to the entity to get them from bundles - line 556: // TODO not convinced this is single threaded on reads; maybe should get a new one each time? - line 747: * TODO Longer term, if we care more about concurrent calls we could merge the queued deltas so that we camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/BrooklynDslCommon.java (6 lines): - line 127: // TODO there is a JavaEntitySpecResolver but no analogue for adjuncts - line 358: // TODO Should use catalog's classloader, rather than ClassLoaderUtils; how to get that? Should we return a future?! - line 373: // TODO could extend API to return a sensor of the given type; useful but makes API ambiguous in theory (unlikely in practise, but still...) - line 394: // TODO allow entitySpec to take string, parsed as YAML, and if just a string that's taken as the type - line 793: // TODO reconcile with "bean-with-type" usage and constructors; - line 849: // TODO de-dupe with getImmediately policy/src/main/java/org/apache/brooklyn/policy/loadbalancing/LoadBalancingPolicy.java (6 lines): - line 68: // TODO make metric and model things which can be initialized from config then reinstate in catalog - line 140: this.strategy = new BalancingStrategy(getDisplayName(), model); // TODO: extract interface, inject impl - line 142: // TODO Should re-use the execution manager's thread pool, somehow - line 173: // TODO unsubscribe from everything? And resubscribe on resume? - line 272: // TODO Can get duplicate onContainerAdded events. - line 302: // TODO Receiving duplicates of onContainerRemoved (e.g. when running LoadBalancingInmemorySoakTest) rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/AdjunctResource.java (6 lines): - line 118: // TODO would like to make 'config' arg optional but jersey complains if we do - line 140: // TODO add FeedSpec ? would be needed even if using the type registry - line 168: // TODO add FeedSpec - line 259: // TODO support parameters ?show=value,summary&name=xxx &format={string,json,xml} - line 270: // TODO try deprecated names? - line 287: // TODO try deprecated names? core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalLocationManager.java (6 lines): - line 176: // TODO synchronization issues here: see comment in LocalEntityManager.manage(Entity) - line 181: // TODO put log.warn back in if/when manage(Location) becomes private; or could even have assert. - line 210: // TODO see comments in LocalEntityManager about recursive management / manageRebindRoot v manageAll - line 253: // TODO The location-event history should be persisted; currently it is lost on - line 297: // TODO shouldn't this fall into "hasBeenReplaced" above? - line 309: // As above, see TODO in LocalEntityManager about recursive management / unmanagement v manageAll/unmanageAll core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalUsageManager.java (5 lines): - line 71: // TODO Threading model needs revisited. - line 280: // TODO This approach (i.e. recording events on manage/unmanage would not work for - line 287: // TODO Should perhaps extract the location storage methods into their own class, - line 391: // TODO could do more efficient indexing, to more easily find locations in use during a given period. - line 422: // TODO could do more efficient indexing, to more easily find locations in use during a given period. policy/src/main/java/org/apache/brooklyn/policy/followthesun/FollowTheSunPolicy.java (5 lines): - line 56: // TODO make model and parameters things which can be initialized from config then reinstate in catalog - line 123: // FIXME parameters: use a more groovy way of doing it, that's consistent with other policies/entities? - line 135: this.strategy = new FollowTheSunStrategy(model, parameters); // TODO: extract interface, inject impl - line 138: // TODO Should re-use the execution manager's thread pool, somehow - line 168: // TODO unsubscribe from everything? And resubscribe on resume? core/src/main/java/org/apache/brooklyn/feed/ssh/SshValueFunctions.java (5 lines): - line 34: // TODO PERSISTENCE WORKAROUND - line 45: // TODO PERSISTENCE WORKAROUND - line 56: // TODO PERSISTENCE WORKAROUND - line 67: // TODO PERSISTENCE WORKAROUND - line 78: // TODO PERSISTENCE WORKAROUND locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SecurityGroupTool.java (5 lines): - line 71: // TODO initialize the location - line 74: // TODO record that we created it - line 77: // FIXME this will always fail for providers which need a location, until we set it above - line 128: // TODO remove this method once we've confirmed the above works nicely (this is an early attempt) - line 132: // TODO where does the default come from? software/base/src/main/java/org/apache/brooklyn/entity/brooklynnode/effector/BrooklynClusterUpgradeEffectorBody.java (5 lines): - line 121: //TODO currently this will fight with auto-scaler policies; they must be turned off for upgrade to work - line 135: //TODO we'd like to disable these nodes as standby targets, ie in some 'hot standby but not available for failover' mode - line 186: // TODO support via EntitySpec - line 192: // TODO fail quicker if state changes to FAILED - line 196: // TODO also check that the nodes created all report the original master, in case persistence changes it core/src/main/java/org/apache/brooklyn/core/location/access/PortForwardManagerImpl.java (5 lines): - line 52: * TODO This implementation is not efficient, and currently has a cap of about 50000 rules. - line 57: * TODO Callers need to be more careful in acquirePublicPort for which ports are actually in use. - line 68: * TODO The publicIpId means different things to different callers: - line 112: // TODO Need to use attributes for these so they are persisted (once a location is an entity), - line 146: // TODO When delete deprecated code, stop registering PortMapping until associate() is called software/base/src/main/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessSshDriver.java (5 lines): - line 109: // FIXME this assumes we own the location, and causes warnings about configuring location after deployment; - line 159: // TODO replace with SshEffectorTasks.ssh ?; remove the use of flags - line 160: // TODO log the stdin/stdout/stderr upon error - line 303: // TODO use SshTasks.put instead, better logging - line 358: // TODO SshMachineLocation.copyTo currently doesn't log warn on non-zero or set blocking details core/src/main/java/org/apache/brooklyn/core/catalog/internal/BasicBrooklynCatalog.java (5 lines): - line 120: /* TODO the complex tree-structured catalogs are only useful when we are relying on those separate catalog classloaders - line 714: // TODO this may take a while if downloading; ideally the REST call would be async - line 851: // TODO we should let the plan transformer give us this - line 1427: // TODO this legacy path is still needed where an entity is declared with nice abbreviated 'type: ...' syntax, not the full-camp 'services: [ { type: ... } ]' syntax. - line 2199: // TODO collect registered type name supertypes, as strings core/src/main/java/org/apache/brooklyn/core/mgmt/ha/HighAvailabilityManagerImpl.java (5 lines): - line 305: // TODO Small race in that we first check, and then we'll do checkMaster() on first poll, - line 486: // TODO i think we might have previously started _in_ this method, if so we should set a flag and suppress the stop-then-restart - line 569: // TODO ideally there'd be an incremental rebind as well as an incremental persist - line 637: // TODO would be nice if scheduled task had a "no initial submission" flag ) - line 947: // TODO target may be RO ? core/src/main/java/org/apache/brooklyn/core/location/Machines.java (5 lines): - line 48: // TODO Should we look at HasNetworkAddresses? But that's not a hostname. - line 63: // TODO if Maybe.absent(message) appears, could/should use that - line 64: // TODO If no machine available, should we throw new IllegalStateException("Cannot find hostname for "+where); - line 69: // TODO Too much duplication between the ip and hostname methods - line 178: // TODO Or if can't find MachineLocation, should we throw new IllegalStateException("Cannot find hostname for among "+ll); core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogUtils.java (5 lines): - line 77: // TODO getLibraries() should never be null but sometimes it is still - line 122: // TODO determine whether to support stacking - line 127: // TODO and determine if this is needed/wanted - line 245: // TODO should be addToCatalogSearchPathOnAddition - line 325: // TODO null checks core/src/main/java/org/apache/brooklyn/core/objs/proxy/InternalPolicyFactory.java (4 lines): - line 79: policy.configure(MutableMap.copyOf(config)); // TODO AbstractPolicy.configure modifies the map - line 82: // TODO Can we avoid this for "new-style policies"? Should we just trust the configure() method, - line 123: theEnricher.configure(MutableMap.copyOf(config)); // TODO AbstractEnricher.configure modifies the map - line 126: // TODO Can we avoid this for "new-style policies"? Should we just trust the configure() method, locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsSshMachineLocation.java (4 lines): - line 120: * TODO We will rename these to get rid of the ugly underscore when the old node/template - line 122: * TODO Should we change callers to pass all the bits of node & template we are interested - line 150: // TODO Need to fix the rebind-detection, and not call init() on rebind. - line 437: // TODO Hacky; don't want aws specific stuff here but what to do?! core/src/main/java/org/apache/brooklyn/core/BrooklynVersion.java (4 lines): - line 102: // TODO there is also build-metadata.properties used in ServerResource /v1/server/version endpoint - line 116: // TODO does the OSGi version include other slightly differ gubbins/style ? - line 299: // TODO remove when everything uses osgi bundles tracked by brooklyn above - line 330: // TODO remove when everything uses osgi bundles tracked by brooklyn above camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/CampResolver.java (4 lines): - line 74: // TODO we have a few different modes, detailed below; this logic should be moved to the new transformer - line 98: // TODO new-style approach: - line 225: // TODO instead of BasicBrooklynCatalog.attemptLegacySpecTransformers where candidate yaml has 'services:' prepended, try that in this method - line 266: // TODO better approach to replacing scopeRoot core/src/main/java/org/apache/brooklyn/core/config/ConfigPredicates.java (4 lines): - line 39: // TODO PERSISTENCE WORKAROUND - line 51: // TODO PERSISTENCE WORKAROUND - line 63: // TODO PERSISTENCE WORKAROUND - line 76: // TODO PERSISTENCE WORKAROUND utils/common/src/main/java/org/apache/brooklyn/util/JavaGroovyEquivalents.java (4 lines): - line 41: // FIXME move to brooklyn.util.groovy - line 60: // TODO Would be nice to not cast, but this is groovy equivalent! Let's fix generics in stage 2 - line 106: // TODO Doesn't handle matchers (see http://docs.codehaus.org/display/GROOVY/Groovy+Truth) - line 155: // TODO Lazy coding here for large number values; but refactoring away from groovy anyway... rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/EntityConfigResource.java (4 lines): - line 71: // TODO merge with keys which have values: - line 88: // TODO support parameters ?show=value,summary&name=xxx &format={string,json,xml} - line 94: // TODO: add test - line 127: // TODO on API for this, and other config (location, policy, etc), support requesting local v inherited and resolved v raw core/src/main/java/org/apache/brooklyn/core/location/AbstractLocation.java (4 lines): - line 240: // TODO Explicitly dealing with iso3166 here because want custom splitter rule comma-separated string. - line 256: // TODO ensure no callers rely on 'remove' semantics, and don't remove; - line 328: // TODO Should we support a location changing parent? The resulting unmanage/manage might cause problems. - line 347: // TODO revert to SubscriptionSupportInternal when groovy subclasses work without this (eg new groovy version) locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/CreateUserStatements.java (4 lines): - line 165: // TODO Generate statements to create the user. - line 170: // TODO extractVmCredentials() will use user:publicKeyData defaults, if we don't override this. - line 217: * TODO have an explicit `create_new_key_per_machine` config key. - line 224: // TODO JcloudsLocation used to log this once only: loggedSshKeysHint.compareAndSet(false, true). core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/transformer/CompoundTransformer.java (4 lines): - line 57: // TODO Does not yet handle BrooklynMementoTransformer, for changing an entire BrooklynMemento. - line 227: //TODO update reference attributes - line 270: // TODO @neykov asks whether transformers should be run in registration order, - line 381: // TODO we should support a better way of adding/removing bundles, core/src/main/java/org/apache/brooklyn/core/effector/MethodEffector.java (4 lines): - line 92: // TODO if blank, could do "param"+(i+1); would that be better? - line 93: // TODO this will now give "" if name is blank, rather than previously null. Is that ok?! - line 163: // TODO Should really find method with right signature, rather than just the right args. - line 164: // TODO prepareArgs can miss things out that have "default values"! Code below will probably fail if that happens. utils/common/src/main/java/org/apache/brooklyn/util/math/MathPredicates.java (4 lines): - line 31: // TODO PERSISTENCE WORKAROUND - line 43: // TODO PERSISTENCE WORKAROUND - line 55: // TODO PERSISTENCE WORKAROUND - line 67: // TODO PERSISTENCE WORKAROUND core/src/main/java/org/apache/brooklyn/util/core/config/ConfigBag.java (4 lines): - line 196: // TODO sealed no longer works as before, because `config` is the backing storage map. - line 546: // TODO for now, no evaluation -- maps / closure content / other smart (self-extracting) keys are NOT supported - line 744: // TODO How to ensure sealed?! - line 760: // TODO why have both this and mutable software/base/src/main/java/org/apache/brooklyn/entity/java/JmxmpSslSupport.java (4 lines): - line 73: // TODO use brooklyn root CA keys etc - line 87: // TODO jmx.ssl.agent.keyPassword - line 92: // TODO jmx.ssl.agent.keyStorePassword - line 117: // TODO load from keyStoreUrl rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AdjunctApi.java (4 lines): - line 72: // TODO support YAML ? - line 73: // TODO support timeout - line 93: // TODO would like to make this optional but jersey complains if we do - line 216: // TODO support parameters ?show=value,summary&name=xxx &format={string,json,xml} rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/PolicyApi.java (4 lines): - line 56: // TODO support parameters ?show=value,summary&name=xxx - line 61: // FIXME method name -- this is nothing to do with config! - line 85: // TODO would like to make this optional but jersey complains if we do - line 137: // TODO: Should be DELETE /policy, not POST /policy/destroy core/src/main/java/org/apache/brooklyn/util/core/internal/ssh/SshTool.java (4 lines): - line 83: // TODO would be nice to track which arguments are used, so we can indicate whether extras are supplied - line 94: // TODO remove unnecessary "public static final" modifiers - line 96: // TODO Could define the following in SshMachineLocation, or some such? - line 175: // TODO might be more efficicent than copyFrom by way of temp file core/src/main/java/org/apache/brooklyn/core/config/MapConfigKey.java (4 lines): - line 57: //TODO Create interface - line 58: //TODO The BasicConfigKey.builder(Class,name) methods mean we can't define them on this sub-type, - line 129: // TODO it isn't clear whether defaultValue is an initialValue, or a value to use when map is empty - line 246: // TODO above is not thread-safe, and below is assuming synching on map core/src/main/java/org/apache/brooklyn/core/mgmt/BrooklynTaskTags.java (4 lines): - line 323: // TODO would be nice to just get the first 80 chars but that's a refactoring - line 361: // TODO only make it soft if/when stream exceeds a given size eg 1kb ? - line 386: // TODO also make soft - this is often larger than the streams themselves - line 485: // TODO handle these in the UI: core/src/main/java/org/apache/brooklyn/util/core/ResourceUtils.java (4 lines): - line 189: // TODO rework this class so it accepts but does not require a BCLC ? - line 242: * TODO may want OSGi, or typed object; should consider pax url - line 407: // TODO would be nice to support ZIP-wrapping from classpath, either as a protocol or DSL or both - line 454: // TODO messy way to get an SCP session policy/src/main/java/org/apache/brooklyn/policy/ha/ServiceFailureDetector.java (4 lines): - line 62: // TODO Remove duplication between this and MemberFailureDetectionPolicy. - line 141: * TODO Really don't want this mutex! - line 319: // TODO Execute in same thread as other onEvent calls are done in (i.e. same conceptually - line 322: // TODO Disabling the use of executorQueued check - it was causing assertions to fail that locations/jclouds/src/main/java/org/apache/brooklyn/policy/jclouds/os/CreateUserPolicy.java (3 lines): - line 67: // TODO Should add support for authorizing ssh keys as well - line 69: // TODO Should review duplication with: - line 74: // TODO Could make the password explicitly configurable, or auto-generate if not set? core/src/main/java/org/apache/brooklyn/location/multi/MultiLocationResolver.java (3 lines): - line 68: // FIXME pass all flags into the location - line 80: // TODO we are ignoring locationFlags after this (apart from named), looking only at these args - line 97: // TODO do we need to pass location flags etc into the children to ensure they are inherited? core/src/main/java/org/apache/brooklyn/core/entity/Entities.java (3 lines): - line 763: // TODO unmanage the location, if possible? - line 1173: // TODO it is messy to have to do this, but not sure there is a cleaner way :( - line 1178: // TODO could give this task a name, like "create task from factory" core/src/main/java/org/apache/brooklyn/core/mgmt/internal/BrooklynShutdownHooks.java (3 lines): - line 89: // TODO should be a weak reference in case it is destroyed before shutdown - line 128: // TODO weak reference, as per above - line 152: // TODO weak reference, as per above rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/TypeResource.java (3 lines): - line 94: // TODO application probably isn't at all interesting; keep it for backward compatibility, - line 102: // TODO inefficient - does n^2 comparisons where n is sufficient - line 147: // TODO best to default to "not found" - unless maybe they have permission to "see null" core/src/main/java/org/apache/brooklyn/entity/group/AbstractGroupImpl.java (3 lines): - line 110: // FIXME do not set sensors on members; possibly we don't need FIRST at all, just look at the first in MEMBERS, and take care to guarantee order there - line 164: // TODO ideally the following are all synched - line 246: // TODO use this instead; see issue and email thread where this comment was introduced software/base/src/main/java/org/apache/brooklyn/feed/jmx/JmxHelper.java (3 lines): - line 176: // TODO split this in to two classes, one for entities, and one entity-neutral - line 351: // TODO use root cert for trusting server - line 374: * TODO: What happens if already connected? core/src/main/java/org/apache/brooklyn/util/core/text/TemplateProcessor.java (3 lines): - line 630: // TODO could support null here, like we do for sensors and workflow - line 866: // TODO deprecated in 0.7.0, remove after next version - line 988: // TODO could expose CAMP '$brooklyn:' style dsl, based on template.createProcessingEnvironment core/src/main/java/org/apache/brooklyn/entity/group/DynamicCluster.java (3 lines): - line 81: // TODO document use of advanced availability zone configuration and features - line 94: // TODO Would like to add entity-down reporting - line 95: // TODO Should we push any of this into the AvailabilityZoneExtension, rather than on the dynamic cluster? core/src/main/java/org/apache/brooklyn/core/location/cloud/AbstractCloudMachineProvisioningLocation.java (3 lines): - line 61: // TODO should be able to use ConfigBag.newInstanceExtending; would require moving stuff around to api etc - line 62: // TODO was previously `return LocationCreationUtils.newSubLocation(newFlags, this)`; need to retest on CloudStack etc - line 65: .configure(config().getLocalBag().getAllConfig()) // FIXME Should this just be inherited? core/src/main/java/org/apache/brooklyn/entity/stock/AsyncApplicationImpl.java (3 lines): - line 176: // TODO How does this relate to quorum?! - line 308: // TODO could check no-one else has changed expectedState (e.g. by calling "stop") - line 309: // TODO do we need to subscribe to our own serviceStateExpected, in case someone calls stop? software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaSoftwareProcessSshDriver.java (3 lines): - line 154: // TODO see note in VanillaSoftwareProcess about PID_FILE as a config key - line 178: // TODO: template substitutions? - line 191: // TODO: template substitutions? server-cli/src/main/java/org/apache/brooklyn/cli/ItemLister.java (3 lines): - line 135: mkdir(parentDir, "locationResolvers"); //TODO nothing written here yet... - line 216: // TODO Remove duplication from separate ListPolicyCommand etc - line 337: // TODO this only really works if you give it lots of URLs - see comment on "--jar" argument utils/common/src/main/java/org/apache/brooklyn/util/guava/MaybeFunctions.java (3 lines): - line 28: // TODO PERSISTENCE WORKAROUND - line 40: // TODO PERSISTENCE WORKAROUND - line 52: // TODO PERSISTENCE WORKAROUND core/src/main/java/org/apache/brooklyn/core/mgmt/ha/ManagementPlaneSyncRecordPersisterToObjectStore.java (3 lines): - line 83: // TODO Multiple node appending to change.log could cause strange interleaving, or perhaps even data loss? - line 86: // TODO Should ManagementPlaneSyncRecordPersister.Delta be different so can tell what is a significant event, - line 95: // TODO Leak if we go through lots of managers; but tiny! server-cli/src/main/java/org/apache/brooklyn/cli/Main.java (3 lines): - line 307: // TODO currently defaults to disabled; want it to default to on, when we're ready - line 308: // TODO how to force a line-split per option?! - line 698: // TODO Should we really accept any entity type, and just wrap it in an app? That's not documented! rest/rest-resources/src/main/java/org/apache/brooklyn/rest/filter/HaHotCheckResourceFilter.java (3 lines): - line 132: // TODO use an annotation HaAnyStateAllowed or HaHotCheckRequired(false) instead of these ad hoc checks - line 148: // TODO support super annotations - line 163: // TODO could look in super classes but not needed now, we are in control of where to put the annotation core/src/main/java/org/apache/brooklyn/core/internal/storage/impl/ConcurrentMapAcceptingNullVals.java (3 lines): - line 191: // TODO Auto-generated method stub - line 229: // TODO Auto-generated method stub - line 235: // TODO Auto-generated method stub policy/src/main/java/org/apache/brooklyn/policy/ha/ServiceRestarter.java (3 lines): - line 108: // TODO Could use BasicExecutionManager.setTaskSchedulerForTag to prevent race of two - line 123: // TODO semaphores would be better to allow at-most-one-blocking behaviour - line 124: // FIXME as this is called in message-dispatch (single threaded) we should do most of this in a new submitted task core/src/main/java/org/apache/brooklyn/location/localhost/LocalhostMachineProvisioningLocation.java (3 lines): - line 140: // TODO should try to confirm this machine is accessible on the given address ... but there's no - line 188: // TODO should take the plunge and try removing this altogether! - line 198: addChild(new LocalhostMachine(flags2)); // TODO legacy way core/src/main/java/org/apache/brooklyn/core/entity/EntityRelations.java (3 lines): - line 39: /** TODO these relations are not used yet; see issue where this is introduced and email thread */ - line 106: // TODO replace by relations stored in catalog when catalog supports arbitrary types - line 131: /* TODO ultimately we'd like to support arbitrary relationships via persistence and lookup against the catalog; camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/pdp/DeploymentPlan.java (3 lines): - line 52: // TODO version - line 65: // TODO "map" short form - line 80: // TODO "map" short form software/base/src/main/java/org/apache/brooklyn/feed/jmx/JmxValueFunctions.java (3 lines): - line 40: // TODO PERSISTENCE WORKAROUND - line 50: // TODO PERSISTENCE WORKAROUND - line 60: // TODO PERSISTENCE WORKAROUND core/src/main/java/org/apache/brooklyn/core/entity/drivers/downloads/DownloadProducerFromProperties.java (3 lines): - line 52: * // FIXME Check format for including addonname- only if addonname is non-null? - line 53: * // FIXME Use this in a testng test case - line 110: /* FIXME: expose config for canContinueResolving. core/src/main/java/org/apache/brooklyn/feed/http/HttpValueFunctions.java (3 lines): - line 43: // TODO PERSISTENCE WORKAROUND kept anonymous function in case referenced in persisted state - line 76: // TODO PERSISTENCE WORKAROUND kept anonymous function in case referenced in persisted state - line 113: // TODO PERSISTENCE WORKAROUND kept anonymous function in case referenced in persisted state core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/BasicLocationRebindSupport.java (3 lines): - line 70: // FIXME Treat config like we do for entities; this code will disappear when locations become entities. - line 91: // FIXME How to do findFieldForFlag without throwing exception if it's not there? - line 126: location.init(); // TODO deprecated calling init; will be deleted api/src/main/java/org/apache/brooklyn/api/typereg/RegisteredType.java (3 lines): - line 47: // TODO would prefer this to be VersionedName if/when everything comes from OSGi bundles - line 89: * (TODO Currently I don't think it ever includes {@link RegisteredType} supertypes.) - line 122: Object getPlanData(); // TODO unclear if this is allowed to return null; most (?) usages do a null check utils/common/src/main/java/org/apache/brooklyn/config/ConfigMap.java (3 lines): - line 71: // TODO should be findKeysDeclaredOrPresent - if you want just the declared ones, look up the type - line 72: // TODO should ignore sub element config keys, but for now the caller can do that - line 79: // TODO should include structured config keys if they have a sub element config present core/src/main/java/org/apache/brooklyn/location/byon/FixedListMachineProvisioningLocation.java (3 lines): - line 80: // TODO Synchronization looks very wrong for accessing machines/inUse - line 247: // TODO shouldn't have to copy config bag as it should be inherited (but currently it is not used inherited everywhere; just most places) - line 250: .configure(config().getAllLocalRaw()) // FIXME Should this just be inherited? policy/src/main/java/org/apache/brooklyn/policy/ha/ServiceReplacer.java (3 lines): - line 62: // TODO if there are multiple failures perhaps we should abort quickly - line 124: // TODO Could use BasicExecutionManager.setTaskSchedulerForTag to prevent race of two - line 140: // TODO semaphores would be better to allow at-most-one-blocking behaviour rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/ServerApi.java (3 lines): - line 55: // TODO support TGZ, and check mime type - line 166: // TODO: This should probably return a 404 if the key is not present, and should return a predictable - line 308: // TODO /ha/persist/backup set of endpoints, to list and retrieve specific backups core/src/main/java/org/apache/brooklyn/util/core/xstream/ClassRenamingMapper.java (3 lines): - line 42: * TODO There is a strange relationship between this and OsgiClassnameMapper. - line 45: * TODO For class-loading on deserialization, should we push the class-rename logic into - line 51: * TODO This code feels overly complicated, and deserves a cleanup. core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/transformer/CompoundTransformerLoader.java (3 lines): - line 46: // TODO Improve error handing so get nicer errors. - line 47: // TODO Improve names (e.g. always camel case?) - line 48: // TODO Pass in classloader for reflectively loading rawDataTransformer? core/src/main/java/org/apache/brooklyn/core/internal/BrooklynPropertiesImpl.java (3 lines): - line 61: * TODO methods in this class are not thread safe. - line 168: // TODO Could also read from http://brooklyn.io, for up-to-date values? - line 477: // TODO does not support MapConfigKey etc where entries use subkey notation; for now, access using submap rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/ConfigTransformer.java (3 lines): - line 132: // TODO wasteful including these - line 140: // TODO is this json or a display value? - line 152: // TODO if ui metadata not set try to infer or get more info from caller ? software/base/src/main/java/org/apache/brooklyn/entity/java/UsesJmx.java (3 lines): - line 62: // TODO when using JmxAgentModes.NONE we should *not* convert, but leave it null - line 155: /* TODO brooklyn ROOT key - line 175: /* TODO specify a keystore from which to get the access key policy/src/main/java/org/apache/brooklyn/policy/enricher/HttpLatencyDetector.java (3 lines): - line 134: // TODO use init()? - line 205: // TODO would be good if subscription gave us the current value, rather than risking a race with code like this. - line 228: // TODO would be good if subscription gave us the current value, rather than risking a race with code like this. api/src/main/java/org/apache/brooklyn/api/entity/EntityLocal.java (3 lines): - line 25: * FIXME Moved from core project to api project because of bug in groovy's covariant return types. - line 28: * FIXME Add {@link setAttribute(AttributeSensorAndConfigKey)} back in if/when move it back, - line 36: // FIXME Rename to something other than EntityLocal. policy/src/main/java/org/apache/brooklyn/policy/followthesun/DefaultFollowTheSunModel.java (3 lines): - line 91: // TODO: delete? - line 110: // FIXME Too expensive to compute; store in a different data structure? - line 315: // TODO Move to utils; or stop AbstractLocation from removing things from the map! core/src/main/java/org/apache/brooklyn/core/sensor/http/HttpRequestSensor.java (3 lines): - line 95: // TODO Keeping anonymous inner class for backwards compatibility with persisted state - line 123: // (TODO perhaps the default type shouldn't be string for this initializer?!) - line 163: // TODO this will cause `allConfig` to be persisted inside the UriSupplier, which is not ideal. core/src/main/java/org/apache/brooklyn/core/entity/BrooklynConfigKeys.java (3 lines): - line 57: // TODO Rename to VERSION, instead of SUGGESTED_VERSION? And declare as BasicAttributeSensorAndConfigKey? - line 67: // TODO above should also be NOT_REINHERITED - line 145: // TODO these dirs should also not be reinherited at runtime camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/resolve/PdpProcessor.java (3 lines): - line 151: // TODO unpack entry, create a space on disk holding the archive ? - line 166: // TODO a list is a crude way to do matching ... but good enough to start - line 178: // TODO first accepting is a crude way to do matching ... but good enough to start core/src/main/java/org/apache/brooklyn/util/core/task/ValueResolver.java (3 lines): - line 74: // TODO most of these usages should be removed when we have - line 129: // TODO i don't think we ever rely this -Alex - line 472: // TODO svet suggested at https://github.com/apache/brooklyn-server/pull/565#pullrequestreview-27124074 utils/common/src/main/java/org/apache/brooklyn/util/internal/BrooklynSystemProperties.java (3 lines): - line 26: // FIXME not used - line 28: // FIXME not used - line 31: // FIXME not used policy/src/main/java/org/apache/brooklyn/policy/followthesun/FollowTheSunPoolImpl.java (3 lines): - line 40: // FIXME Remove duplication from BalanceableWorkerPool? - line 42: // FIXME Asymmetry between loadbalancing and followTheSun: ITEM_ADDED and ITEM_REMOVED in loadbalancing - line 78: // TODO What if start has failed? Is there a sensor to indicate that? api/src/main/java/org/apache/brooklyn/api/internal/AbstractBrooklynObjectSpec.java (3 lines): - line 239: // TODO which semantics are correct? replace has been the behaviour; - line 327: // TODO Duplicates method in BasicEntityTypeRegistry and InternalEntityFactory.isNewStyleEntity - line 343: // TODO Duplicates method in BasicEntityTypeRegistry core/src/main/java/org/apache/brooklyn/core/mgmt/internal/EffectorUtils.java (3 lines): - line 126: // TODO do we ignore arguments in the same order that groovy does? - line 338: // FIXME seems brittle to have the listeners in the Utils method; better to move into the context.invokeEff - line 344: // FIXME this is really Effector submitted core/src/main/java/org/apache/brooklyn/util/core/task/ssh/internal/RemoteExecTaskConfigHelper.java (3 lines): - line 126: // TODO SSH client class should be injected in the 'config' map here too, get it from ManagementContext.getTypeRegistry() , allow users to register their own types 'ssh' and 'winrm' - line 134: // TODO add support for 'winrm' - line 184: String sshToolClass = SshjTool.class.getName(); // TODO hardcoded for now, @see SshMachineLocation#connectSsh(..) software/base/src/main/java/org/apache/brooklyn/entity/brooklynnode/BrooklynNodeSshDriver.java (3 lines): - line 146: // TODO use machine.installTo ... but that only works w a single location currently - line 175: // FIXME remove when all downstream usages don't use this - line 335: // TODO sensors will probably not work in this mode core/src/main/java/org/apache/brooklyn/core/network/OnPublicNetworkEnricher.java (3 lines): - line 74: // TODO Need more logging, particularly for when the value has *not* been transformed. - line 76: // TODO What if the sensor has an unrelated hostname - we will currently still transform this! - line 80: // TODO If there is no port-mapping, should we advertise the original sensor value? core/src/main/java/org/apache/brooklyn/core/objs/BrooklynObjectInternal.java (3 lines): - line 92: // TODO deprecate. used fairly extensively, mostly in tests. a bit more care will be needed to refactor. - line 100: // TODO deprecate. used extensively in tests but should be easy (if tedious) to refactor. - line 205: @Beta // TODO provide more accessors and deprecate this policy/src/main/java/org/apache/brooklyn/policy/followthesun/FollowTheSunStrategy.java (3 lines): - line 37: // TODO: extract interface - line 42: // TODO location constraints - line 154: * TODO should choose the least loaded mediator. Currently chooses first available, and relies core/src/main/java/org/apache/brooklyn/core/location/access/BrooklynAccessUtils.java (3 lines): - line 59: null); // TODO should be a list - line 76: // TODO finer-grained synchronization - line 93: // TODO discuss, is this the best way to do it policy/src/main/java/org/apache/brooklyn/policy/failover/ElectPrimaryPolicy.java (3 lines): - line 94: // TODO support configurable parallelisation of promote/demote (in the code) - line 95: // TODO more propagation, effectors, and "all-but" semantics (comments in PPE, though we might want a separate effector propagator) - line 253: // TODO as with during create, would be good to filter what is getting passed, or have another config key to allow it to be restricted/changed locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BrooklynImageChooser.java (3 lines): - line 195: // TODO prefer known providerIds - line 305: // TODO use AlphaNum string comparator - line 344: // TODO suggest to use NaturalOrderComparator (so 10>9) then order by: camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/methods/DslComponent.java (3 lines): - line 385: // TODO inefficient when looking at descendants or ancestors, as it also traverses in the other direction, - line 1051: // TODO Try repeatedly if no location(s)? - line 1086: // TODO Arguably this should not look at ancestors. For example, in a `SoftwareProcess` core/src/main/java/org/apache/brooklyn/entity/group/QuarantineGroupImpl.java (2 lines): - line 80: // TODO Quite like DynamicClusterImpl.waitForTasksOnEntityStart - line 82: // TODO Could have CompoundException, rather than propagating first core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/PeriodicDeltaChangeListener.java (2 lines): - line 79: * TODO A better implementation would look at a per-entity basis. When the entity was modified, then - line 408: // FIXME How to let the policy/location tell us about changes? Don't do this every time! locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsWinRmMachineLocation.java (2 lines): - line 83: * TODO We will rename these to get rid of the ugly underscore when the old node/template - line 108: // TODO Need to fix the rebind-detection, and not call init() on rebind. utils/common/src/main/java/org/apache/brooklyn/util/http/HttpAsserts.java (2 lines): - line 326: * TODO Look at difference between this and WebAppMonitor, to decide if this should be kept. - line 331: // TODO Need to drop logging; remove sleep when that's done. rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/AbstractBrooklynRestResource.java (2 lines): - line 343: boolean areSecretsAllowed = true; // TODO check in mgmt context if secrets are allowed (change this from static to get mgmt context!) - line 349: boolean isDefaultsSecretSAllowed = true; // TODO check in mgmt context if secrets should default to being shown in API software/base/src/main/java/org/apache/brooklyn/entity/brooklynnode/BrooklynClusterImpl.java (2 lines): - line 50: // TODO should we set a default MEMBER_SPEC ? difficult though because we'd need to set a password - line 102: //TODO Do set such indicator if this continues for an extended period of time core/src/main/java/org/apache/brooklyn/core/objs/AbstractEntityAdjunct.java (2 lines): - line 157: // TODO only set on first time through - line 188: //TODO inconsistent with entity and location, where name is legacy and displayName is encouraged! core/src/main/java/org/apache/brooklyn/core/sensor/AttributeMap.java (2 lines): - line 145: // TODO path must be ordered(and legal to contain duplicates like "a.b.a"; list would be better - line 249: // TODO path must be ordered(and legal to contain duplicates like "a.b.a"; list would be better utils/groovy/src/main/java/org/apache/brooklyn/util/groovy/GroovyJavaMethods.java (2 lines): - line 47: //TODO use named subclasses, would that be more efficient? - line 49: // TODO xFromY methods not in correct class: they are not "handy method available in groovy"? core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/dto/BasicEntityMemento.java (2 lines): - line 117: // TODO can we move some of these to entity type, or remove/re-insert those which are final statics? - line 286: * TODO Really don't like this pattern. Should we clean it up? But deferring until core/src/main/java/org/apache/brooklyn/util/core/logbook/file/FileLogStore.java (2 lines): - line 130: // TODO: the read of the file needs to be improved, specially to implement reading the file backwards and - line 152: // TODO: fix the RegEx to process multiline log messages like stack-traces, and remove this condition. core/src/main/java/org/apache/brooklyn/util/core/task/ssh/SshPutTaskWrapper.java (2 lines): - line 66: // TODO: - line 141: // TODO verify camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/pdp/Service.java (2 lines): - line 50: // FIXME _type needed in lots of places - line 64: // TODO "map" short form core/src/main/java/org/apache/brooklyn/core/typereg/RegisteredTypes.java (2 lines): - line 264: // TODO should this be on the AbstractTypePlanTransformer ? - line 612: // TODO remove if we don't see any warnings (or when we sort out semantics for template v app v allowed-unresolved better) locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/pool/ReusableMachineTemplate.java (2 lines): - line 41: // TODO tags/metadata semantics are not quite right, as they could apply to the server _image_ or _instance_ - line 43: // TODO we could use a hashcode over the values of template-builder and template-options fields, as a tag/usermetadata, core/src/main/java/org/apache/brooklyn/entity/stock/EffectorStartableImpl.java (2 lines): - line 40: * TODO we should have a better way to autostart, basically checking whether there is - line 48: // TODO polymorphic parametrisation of effetor, take LOCATION, take strings, etc core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogInitialization.java (2 lines): - line 265: // TODO ideally this would remain false until it has *persisted* the changed catalog; - line 270: // TODO also, if a node comes up in standby, the addition might not take effector for a while camp/camp-server/src/main/java/org/apache/brooklyn/camp/server/dto/PlatformComponentTemplateDto.java (2 lines): - line 29: // TODO set addl PCT fields - line 32: // TODO add addl PCT fields core/src/main/java/org/apache/brooklyn/entity/group/zoneaware/BalancingNodePlacementStrategy.java (2 lines): - line 58: // TODO Inefficient to loop this many times! But not called with big numbers. - line 88: // TODO Inefficient to loop this many times! But not called with big numbers. policy/src/main/java/org/apache/brooklyn/policy/loadbalancing/DefaultBalanceablePoolModel.java (2 lines): - line 106: @Override public String getName(ContainerType container) { return container.toString(); } // TODO: delete? - line 192: // TODO: assert no orphaned items utils/common/src/main/java/org/apache/brooklyn/util/net/Networking.java (2 lines): - line 255: // TODO it does not add adjacent intervals: {[22, 22], [23, 23]} is not merged to {[22, 23]} - line 651: // TODO go through nic's, looking for public, private, etc, on localhost core/src/main/java/org/apache/brooklyn/enricher/stock/Joiner.java (2 lines): - line 111: // TODO would be useful to have a convenience to "subscribeAndThenIfItIsAlreadySetRunItOnce" - line 146: // TODO we might want to handle QUOTE=true specially for this case, to quote keys and values if needed policy/src/main/java/org/apache/brooklyn/policy/action/AbstractScheduledEffectorPolicy.java (2 lines): - line 152: // TODO instead of a custom executor it would be nicer to use scheduled tasks - line 248: boolean formatted = time.contains(":"); // FIXME deprecated TimeDuration coercion core/src/main/java/org/apache/brooklyn/core/location/geo/MaxMind2HostGeoLookup.java (2 lines): - line 43: // TODO this should be configurable from system property or brooklyn.properties - line 44: // TODO and should use properties BrooklynServerConfig.MGMT_BASE_DIR (but hard to get mgmt properties here!) core/src/main/java/org/apache/brooklyn/core/entity/drivers/downloads/DownloadSubstituters.java (2 lines): - line 52: // TODO in Freemarker 2.4 SLF4J may be auto-selected and we can remove this; - line 147: // FIXME Also need default subs (entity, driver, simpletype, etc) api/src/main/java/org/apache/brooklyn/api/mgmt/ManagementContext.java (2 lines): - line 57: // TODO Consider separating out into a ConfigManager for methods like: - line 228: // TODO should we replace this with isNotYetTerminated() ?? rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/PolicyConfigResource.java (2 lines): - line 60: // TODO support parameters ?show=value,summary&name=xxx &format={string,json,xml} - line 64: // TODO: add test software/base/src/main/java/org/apache/brooklyn/entity/machine/SetHostnameCustomizer.java (2 lines): - line 55: // TODO basic hostname setting is done by JcloudsLocation, combine that code with this - line 104: // TODO Any checks that they've given us sufficient configuration? core/src/main/java/org/apache/brooklyn/core/network/AbstractOnNetworkEnricher.java (2 lines): - line 178: // TODO Avoid repeated logging - line 189: // TODO Avoid repeated logging core/src/main/java/org/apache/brooklyn/enricher/stock/AbstractAggregator.java (2 lines): - line 66: // FIXME this is not just for "members" i think -Alex - line 255: // TODO If producer removed but then get (queued) event from it after this method returns, locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/ConnectivityResolverOptions.java (2 lines): - line 137: // TODO: Merge this with pollForReachable when waitForSshable and waitForWinRmable deleted. - line 150: // TODO: Can usePortForwarding and portForwardSshOverride be merged? camp/camp-server/src/main/java/org/apache/brooklyn/camp/server/dto/PlatformDto.java (2 lines): - line 73: // TODO set custom fields - line 80: // TODO add custom fields utils/common/src/main/java/org/apache/brooklyn/util/collections/Jsonya.java (2 lines): - line 385: // TODO a nicer architecture would create a new object with focus for each traversal - line 494: // TODO a nicer architecture might replace the current target with a list (also above where single non-map argument is supplied) software/winrm/src/main/java/org/apache/brooklyn/location/winrm/WinRmPutTaskWrapper.java (2 lines): - line 61: // TODO: - line 136: // TODO verify core/src/main/java/org/apache/brooklyn/util/core/file/ArchiveUtils.java (2 lines): - line 63: // TODO Make this a ConfigKey on the machine location - line 333: // TODO would be nice to have this in a task (and the things within it!) policy/src/main/java/org/apache/brooklyn/policy/autoscaling/SizeHistory.java (2 lines): - line 102: // TODO Could do more sophisticated "stable" check; this is the easiest code - correct but not most efficient - line 113: // TODO bad casting from Integer default result to T core/src/main/java/org/apache/brooklyn/util/core/logbook/opensearch/OpenSearchLogStore.java (2 lines): - line 178: this.password = mgmt.getConfig().getConfig(LOGBOOK_LOG_STORE_PASS); // TODO: this is not completely secure - line 272: // TODO ideally recurse against remote endpoint software/base/src/main/java/org/apache/brooklyn/entity/java/VanillaJavaAppSshDriver.java (2 lines): - line 55: // FIXME this should be a config, either on the entity or -- probably better -- - line 118: // FIXME Cannot handle spaces in paths properly camp/camp-server/src/main/java/org/apache/brooklyn/camp/server/rest/CampServer.java (2 lines): - line 93: // TODO if there is a GUI or other war... - line 128: // FIXME port hardcoded software/winrm/src/main/java/org/apache/brooklyn/feed/windows/WindowsPerformanceCounterFeed.java (2 lines): - line 198: .add("2") // TODO: extract SampleInterval as a config key - line 284: // TODO not just using statusCode; also looking at absence of stderr. camp/camp-server/src/main/java/org/apache/brooklyn/camp/server/dto/ApplicationComponentTemplateDto.java (2 lines): - line 29: // TODO set addl ACT fields - line 32: // TODO add addl ACT fields core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogClasspathDo.java (2 lines): - line 120: // TODO AH thinks we should delete ALL this old catalog stuff and scanning and annotations; it's redundant now that we use bundles, - line 134: // TODO put convenience in ResourceUtils for extracting to a normal url policy/src/main/java/org/apache/brooklyn/policy/loadbalancing/BalanceableWorkerPoolImpl.java (2 lines): - line 42: // FIXME Asymmetry between loadbalancing and followTheSun: ITEM_ADDED and ITEM_REMOVED in loadbalancing - line 79: // TODO What if start has failed? Is there a sensor to indicate that? software/winrm/src/main/java/org/apache/brooklyn/util/core/internal/winrm/winrm4j/Winrm4jTool.java (2 lines): - line 63: // TODO Should we move this up to the interface? - line 234: // FIXME USE_HTTPS_WINRM shouldn't disable certificates checks core/src/main/java/org/apache/brooklyn/core/mgmt/internal/ManagementContextInternal.java (2 lines): - line 102: // TODO would benefit from better naming! The name has percolated up from LocalEntityManager. - line 112: * TODO In future this will change to a custom interface with a unique identifier for each error. */ core/src/main/java/org/apache/brooklyn/core/sensor/DependentConfiguration.java (2 lines): - line 232: // TODO would be nice to have an easy semantics for whenServiceUp (cf DynamicWebAppClusterImpl.whenServiceUp) - line 257: // TODO onError Continue / Throw / Return(V) camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/BrooklynDslInterpreter.java (2 lines): - line 120: // TODO in future we should support functions of the form 'Maps.clear', 'Maps.reset', 'Maps.remove', etc; - line 188: // TODO Could move argument resolve in DslDeferredFunctionCall freeing each Deffered implementation core/src/main/java/org/apache/brooklyn/core/workflow/WorkflowExpressionResolution.java (2 lines): - line 304: // TODO variable reference for link - line 367: // TODO link and error, as above software/base/src/main/java/org/apache/brooklyn/entity/java/JavaAppUtils.java (2 lines): - line 144: // TODO Could we reuse the result of compositeDataToMemoryUsage? - line 217: //FIXME: need a new type of adapter that maps multiple objectNames to a mapping core/src/main/java/org/apache/brooklyn/util/core/crypto/FluentKeySigner.java (2 lines): - line 92: // TODO see deprecation note at top of file - line 158: // TODO see note re deprecation at start of file core/src/main/java/org/apache/brooklyn/feed/ssh/SshPollConfig.java (2 lines): - line 50: // TODO Kept in case it's persisted; new code will not use this. - line 58: // TODO Kept in case it's persisted; new code will not use this. core/src/main/java/org/apache/brooklyn/util/core/logbook/DelegatingLogStore.java (2 lines): - line 64: // TODO implement logic to allow to inject the implementation from other bundle. - line 75: // TODO what must be removed here and on the DelegatingSecurityProvider core/src/main/java/org/apache/brooklyn/core/mgmt/internal/BrooklynGarbageCollector.java (2 lines): - line 168: @SuppressWarnings("unused") // TODO remove BrooklynStorage altogether? - line 611: // TODO Skip tasks that will be evicted anyway (transient, expired) core/src/main/java/org/apache/brooklyn/core/workflow/steps/appmodel/UpdateChildrenWorkflowStep.java (2 lines): - line 134: // TODO obtain lock on parent -> "update-children" - line 273: // TODO other vars? software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcessWinRmDriver.java (2 lines): - line 50: // TODO: At some point in the future, this should probably be refactored to get the name of the machine in WinRmMachineLocation and set it as the hostname sensor - line 61: // TODO: Follow install path of VanillaSoftwareProcessSshDriver core/src/main/java/org/apache/brooklyn/enricher/stock/AbstractTypeTransformingEnricher.java (2 lines): - line 36: // TODO this has active subclasses so i don't think it should be deprecated; possibly protected was the intention? - line 66: // TODO Aled didn't you write a convenience to "subscribeAndRunIfSet" ? (-Alex) core/src/main/java/org/apache/brooklyn/core/network/OnSubnetNetworkEnricher.java (2 lines): - line 35: * TODO This is a temporary measure while we discuss and implement the proposal - line 58: // TODO This is a temporary measure while we discuss and implement core/src/main/java/org/apache/brooklyn/util/core/task/BasicTask.java (2 lines): - line 86: // TODO would be nice to make this linked to preserve order, as well as concurrent; - line 766: //TODO could say who holds it core/src/main/java/org/apache/brooklyn/core/workflow/steps/variables/TransformReplace.java (2 lines): - line 44: // TODO: Ability to parse Brooklyn DSL - line 99: * TODO: Want to use library utility, but cant' find a suitable one other than the now-retired Apache Jakarta ORO core/src/main/java/org/apache/brooklyn/enricher/stock/Propagator.java (2 lines): - line 139: // TODO kept for deserialization of inner classes, but shouldn't be necessary, as with other inner classes (qv); - line 212: // TODO we should keep a timestamp for the source sensor and echo it software/base/src/main/java/org/apache/brooklyn/entity/software/base/AbstractSoftwareProcessWinRmDriver.java (2 lines): - line 374: // TODO in winrm4j should check, the response is only valid if it is given a ByteArrayOutputStream - line 451: // TODO: Reduce / remove duplication between this and JcloudsLocation.waitForWinRmAvailable software/base/src/main/java/org/apache/brooklyn/feed/jmx/JmxFeed.java (2 lines): - line 278: // TODO Could config.getObjectName have wildcards? Is this code safe? - line 365: // TODO Not good calling this holding the synchronization lock core/src/main/java/org/apache/brooklyn/core/resolve/jackson/CommonTypesSerialization.java (2 lines): - line 148: // TODO - would be better to use createBeanDeserializer ? - line 441: // TODO we should prefer a spec, and coerce to a spec (separate coercer), core/src/main/java/org/apache/brooklyn/core/objs/proxy/InternalEntityFactory.java (2 lines): - line 145: // TODO OSGi strangeness! The classloader obtained from the type should be enough. - line 516: // TODO would it be cleaner to have rebind create a spec and deprecate this? launcher-common/src/main/java/org/apache/brooklyn/launcher/common/BasicLauncher.java (2 lines): - line 473: // TODO create apps only after becoming master, analogously to catalog initialization - line 536: // TODO start CAMP rest _server_ in the below (at /camp) ? rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/PolicyResource.java (2 lines): - line 76: // TODO support parameters ?show=value,summary&name=xxx - line 88: // TODO would like to make 'config' arg optional but jersey complains if we do software/winrm/src/main/java/org/apache/brooklyn/util/core/internal/winrm/WinRmTool.java (2 lines): - line 61: * TODO Winrm supports several authentication mechanisms so it would be better to replace it with a prioritised list of authentication mechanisms to try. - line 73: // TODO See SshTool#PROP_SSH_TRIES, where it was called "sshTries"; remove duplication? Merge into one well-named thing? rest/rest-resources/src/main/java/org/apache/brooklyn/rest/filter/LoggingResourceFilter.java (2 lines): - line 59: * TODO: - line 207: // TODO `getLength` is based on the presence of `Content-Length` header, rather than the measured length. core/src/main/java/org/apache/brooklyn/core/location/cloud/CloudLocationConfig.java (2 lines): - line 105: // FIXME we would like to deprecate this but POLL_FOR_FIRST_REACHABLE_ADDRESS does not have the same behaviour; - line 116: // FIXME as WAIT_FOR_SSHABLE above core/src/main/java/org/apache/brooklyn/core/mgmt/internal/AppGroupTraverser.java (2 lines): - line 38: // TODO would be nice to have tests which look at parent, children, grandchildren, older and younger nephews - line 40: // TODO ideally would be enhanced to look at the "depth in ancestor" tag, to work based on entity definition boundaries rather than app boundaries rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/LocationTransformer.java (2 lines): - line 134: // TODO not sure this is the best strategy, or if it's needed, as the spec config is inherited anyway... - line 156: // TODO remove this section unless we get this warning software/base/src/main/java/org/apache/brooklyn/entity/java/JavaSoftwareProcessSshDriver.java (2 lines): - line 360: // TODO Also handle IBM jvm - line 437: // TODO check java version locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BlobStoreContextFactoryImpl.java (2 lines): - line 49: // TODO Comparing this with {@link JcloudsLocation#getComputeService()}, that calls - line 60: // TODO We could try to remove some duplication compared to {@link ComputeServiceRegistryImpl}, rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/ApplicationResource.java (2 lines): - line 567: //TODO infer encoding from request - line 576: // TODO if not yaml/json - try ZIP, etc camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynYamlTypeInstantiator.java (2 lines): - line 135: * TODO in future also picking up recognized flags and config keys (those declared on the type). - line 182: * but TODO in future should support recognized flags and config keys (those declared on the type), core/src/main/java/org/apache/brooklyn/util/core/task/ScheduledTask.java (2 lines): - line 53: // TODO ScheduledTask is a very pragmatic implementation; would be nice to tighten, - line 255: // TODO Assumes that maxIterations is not negative! core/src/main/java/org/apache/brooklyn/util/core/config/ResolvingConfigBag.java (2 lines): - line 46: // TODO Check if this is still needed after the changes in https://github.com/apache/brooklyn-server/pull/340. - line 85: // TODO Transformer is cached so on next getConfig call the context could be different - something to watch out for. core/src/main/java/org/apache/brooklyn/core/entity/EntityDynamicType.java (2 lines): - line 66: // TODO support overloading; requires not using a map keyed off method name. - line 329: // TODO not perfect, but approx right; we should clarify whether we prefer statics or methods core/src/main/java/org/apache/brooklyn/core/objs/BrooklynTypes.java (2 lines): - line 92: return new PolicyDynamicType((Class)brooklynClass); // TODO immutable? - line 94: return new EnricherDynamicType((Class)brooklynClass); // TODO immutable? camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/PlatformRootSummary.java (2 lines): - line 36: //TODO: - line 66: // TODO a better way not to have an ID here (new subclass BasicIdentifiableResource for other BasicResource instances) locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SecurityGroupEditor.java (2 lines): - line 67: * this class by instantiating a type appropriate to the underlying cloud. TODO investigate and implement. - line 228: @Deprecated // TODO improve this - shouldn't have AWS specifics in here policy/src/main/java/org/apache/brooklyn/policy/enricher/RollingTimeWindowMeanEnricher.java (2 lines): - line 64: * TODO this may end up being deprecated in favour of near-duplicate code in YAML-friendly {@link YamlRollingTimeWindowMeanEnricher}, - line 135: // TODO would be nice to include timestamp, etc core/src/main/java/org/apache/brooklyn/util/core/xstream/OsgiClassnameMapper.java (2 lines): - line 40: // TODO above, and also see discussion at https://github.com/apache/brooklyn-server/pull/718 - line 55: // TODO What if previous stages have already renamed it? policy/src/main/java/org/apache/brooklyn/policy/followthesun/FollowTheSunPool.java (2 lines): - line 34: // FIXME Remove duplication from BalanceableWorkerPool? - line 36: // FIXME Asymmetry between loadbalancing and followTheSun: ITEM_ADDED and ITEM_REMOVED in loadbalancing core/src/main/java/org/apache/brooklyn/core/location/BasicOsDetails.java (2 lines): - line 49: // TODO: Should be replaced with an enum like Jclouds' OsFamily and isX methods should - line 71: //TODO confirm core/src/main/java/org/apache/brooklyn/location/multi/MultiLocation.java (2 lines): - line 152: // TODO shouldn't have to copy config bag as it should be inherited (but currently it is not used inherited everywhere; just most places) - line 155: .configure(config().getLocalBag().getAllConfig()) // FIXME Should this just be inherited? core/src/main/java/org/apache/brooklyn/enricher/stock/Combiner.java (2 lines): - line 118: // TODO Aled didn't you write a convenience to "subscribeAndRunIfSet" ? (-Alex) - line 151: // TODO Could avoid copying when filter not needed core/src/main/java/org/apache/brooklyn/util/core/internal/ssh/cli/SshCliTool.java (2 lines): - line 49: // TODO No retry support, with backoffLimitedRetryHandler - line 119: // TODO Always pretends to be connected utils/common/src/main/java/org/apache/brooklyn/util/http/HttpTool.java (1 line): - line 256: // TODO deprecate this and use the new Apache Commons HttpClientBuilder instead software/base/src/main/java/org/apache/brooklyn/entity/software/base/InboundPortsUtils.java (1 line): - line 77: /* TODO: This won't work if there's a port collision, which will cause the corresponding port attribute rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/EntityConfigApi.java (1 line): - line 65: // TODO support parameters ?show=value,summary&name=xxx &format={string,json,xml} core/src/main/java/org/apache/brooklyn/core/entity/Attributes.java (1 line): - line 53: // TODO these should switch to being TemplatedStringAttributeSensorAndConfigKey utils/common/src/main/java/org/apache/brooklyn/util/stream/StreamGobbler.java (1 line): - line 119: //TODO parametrise log level, for this error, and for normal messages core/src/main/java/org/apache/brooklyn/util/core/json/ErrorAndToStringUnknownTypeSerializer.java (1 line): - line 41: * TODO maybe we want to attempt to serialize fields instead? (but being careful not to be self-referential!) software/base/src/main/java/org/apache/brooklyn/entity/machine/MachineEntityImpl.java (1 line): - line 124: // TODO Logic duplicated from MachineLifecycleEffectorTasks.getLocation(Collection); core/src/main/java/org/apache/brooklyn/core/workflow/steps/appmodel/ClearSensorWorkflowStep.java (1 line): - line 69: // TODO use WorkflowSettingItemsUtils rest/rest-resources/src/main/java/org/apache/brooklyn/rest/filter/BrooklynSecurityProviderFilterHelper.java (1 line): - line 108: // TODO this should be parametrisable core/src/main/java/org/apache/brooklyn/core/mgmt/internal/ManagementTransitionInfo.java (1 line): - line 24: // TODO does this class really pull its weight? core/src/main/java/org/apache/brooklyn/util/core/task/system/internal/ExecWithLoggingHelpers.java (1 line): - line 71: // TODO scriptHeader are the extra commands we expect the SshTool/ShellTool to add. software/base/src/main/java/org/apache/brooklyn/entity/resolve/HardcodedCatalogEntitySpecResolver.java (1 line): - line 94: // TODO is this hardcoded list deprecated? If so log a warning. camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/pdp/ServiceCharacteristic.java (1 line): - line 45: // TODO fulfillment core/src/main/java/org/apache/brooklyn/core/mgmt/internal/NonDeploymentManagementContext.java (1 line): - line 310: // TODO the methods below should delegate to the application? rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/UsageApi.java (1 line): - line 45: // TODO should `/applications?start=...` only return those applications matching the constraint? core/src/main/java/org/apache/brooklyn/core/entity/drivers/downloads/DownloadProducerFromLocalRepo.java (1 line): - line 50: // TODO explain why this is this in lower_case! it's surprising software/base/src/main/java/org/apache/brooklyn/entity/java/JmxSupport.java (1 line): - line 342: * TODO callers of this method have RMI dependencies in the actual app; core/src/main/java/org/apache/brooklyn/entity/group/DynamicMultiGroupImpl.java (1 line): - line 169: // TODO Want to determine if finished rebinding (either success or fail is fine). core/src/main/java/org/apache/brooklyn/util/core/xstream/SafeThrowableConverter.java (1 line): - line 49: public static int TODO = 0; core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/BasicFeedRebindSupport.java (1 line): - line 38: // TODO entity does config-lookup differently; the memento contains the config keys. core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/dto/MementoValidators.java (1 line): - line 33: // TODO Could also validate integrity of entityReferenceAttributes and entityReferenceConfig rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/EntityApi.java (1 line): - line 78: // TODO rename as "/children" ? software/winrm/src/main/java/org/apache/brooklyn/location/winrm/AdvertiseWinrmLoginPolicy.java (1 line): - line 46: // TODO Would like support user-creation over WinRM core/src/main/java/org/apache/brooklyn/core/server/BrooklynServiceAttributes.java (1 line): - line 42: // TODO use ConfigKey (or possibly BrooklynSystemProperties ?) software/base/src/main/java/org/apache/brooklyn/entity/java/JavaEntityMethods.java (1 line): - line 28: // TODO javaMaxHeap javaInitialHeap javaMaxPermGen should all be supplied as ListConfigs on JAVA_OPTIONS software/base/src/main/java/org/apache/brooklyn/entity/machine/pool/ServerPoolImpl.java (1 line): - line 218: // FIXME: What do true/false mean to callers? core/src/main/java/org/apache/brooklyn/core/typereg/TypePlanTransformers.java (1 line): - line 62: // TODO cache these in the TypeRegistry, looking for new ones periodically or supplying a way to register them core/src/main/java/org/apache/brooklyn/core/config/internal/AbstractConfigMapImpl.java (1 line): - line 587: // TODO due to recursive nature we call this N times for the Nth level ancestor core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/BasicPolicyRebindSupport.java (1 line): - line 43: // TODO entity does config-lookup differently; the memento contains the config keys. core/src/main/java/org/apache/brooklyn/core/sensor/BasicSensorEvent.java (1 line): - line 107: // TODO occasional CME observed on shutdown, wrt map, e.g. in UrlMappingTest rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/LocationResource.java (1 line): - line 194: // TODO make all locations be part of the catalog, then flip the JS GUI to use catalog api locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsLocationResolver.java (1 line): - line 155: // TODO Should revisit the locationFlags: where are these actually used? Reason accepting properties without locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/SecurityGroupDefinition.java (1 line): - line 91: // TODO use cloud machine namer locations/jclouds/src/main/java/org/apache/brooklyn/core/mgmt/persist/jclouds/JcloudsBlobStoreBasedObjectStore.java (1 line): - line 98: // TODO do we need to get location from region? can't see the jclouds API. rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/TypeTransformer.java (1 line): - line 147: // TODO include config on location specs? (wasn't done previously so not needed, but good for completeness) camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/lookup/AssemblyBrooklynLookup.java (1 line): - line 55: // FIXME this walks the whole damn tree! core/src/main/java/org/apache/brooklyn/core/resolve/jackson/BeanWithTypeUtils.java (1 line): - line 62: * TODO ideally that and this would be combined */ utils/common/src/main/java/org/apache/brooklyn/util/text/StringShortener.java (1 line): - line 110: // TODO expose a replace or update utils/common/src/main/java/org/apache/brooklyn/util/net/URLParamEncoder.java (1 line): - line 26: * TODO Want to use a library utility, but couldn't find this in guava and don't want to introduce locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/BlobStoreContextFactory.java (1 line): - line 32: // TODO Longer term, we could make this more testable by having the BlobStoreContextFactory configurable. core/src/main/java/org/apache/brooklyn/enricher/stock/Aggregator.java (1 line): - line 249: // TODO Could avoid copying when filter not needed core/src/main/java/org/apache/brooklyn/core/effector/Effectors.java (1 line): - line 278: // TODO sameSignatureAndBody core/src/main/java/org/apache/brooklyn/core/config/SetConfigKey.java (1 line): - line 49: //TODO Create interface software/base/src/main/java/org/apache/brooklyn/entity/software/base/lifecycle/ScriptHelper.java (1 line): - line 422: * TODO would be nice to have a way to add just a few, core/src/main/java/org/apache/brooklyn/util/core/task/ssh/SshTasks.java (1 line): - line 227: // TODO if in a queueing context can we mark this task inessential and throw? utils/common/src/main/java/org/apache/brooklyn/util/repeat/Repeater.java (1 line): - line 239: // TODO support waitingOn to allow notify to interrupt the waits; core/src/main/java/org/apache/brooklyn/util/core/json/BrooklynObjectsJsonMapper.java (1 line): - line 40: /** TODO {@link org.apache.brooklyn.core.resolve.jackson.BeanWithTypeUtils#newMapper(ManagementContext, boolean, BrooklynClassLoadingContext, boolean)} core/src/main/java/org/apache/brooklyn/core/mgmt/persist/FileBasedObjectStore.java (1 line): - line 194: // TODO is this check needed? shouldn't come here now without persistence on. software/base/src/main/java/org/apache/brooklyn/entity/java/VanillaJavaApp.java (1 line): - line 39: // TODO Make jmxPollPeriod @SetFromFlag easier to use: currently a confusion over long and TimeDuration, and core/src/main/java/org/apache/brooklyn/core/catalog/internal/CatalogDo.java (1 line): - line 262: // TODO: Can the entry be in more than one catalogue? The management context has no notion of utils/common/src/main/java/org/apache/brooklyn/util/javalang/AggregateClassLoader.java (1 line): - line 164: // TODO lesser used items, such as getPackage, findLibrary core/src/main/java/org/apache/brooklyn/core/resolve/jackson/BrooklynRegisteredTypeJacksonSerialization.java (1 line): - line 138: // TODO - this would be nice to support complex types policy/src/main/java/org/apache/brooklyn/policy/failover/ElectPrimaryEffector.java (1 line): - line 181: // TODO cancel other promote/demote calls core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalManagementContext.java (1 line): - line 88: // TODO We could delete our other calls to BrooklynInitialization.initAll(), to rely on core/src/main/java/org/apache/brooklyn/core/location/internal/LocationConfigMap.java (1 line): - line 99: // TODO phase it out -- just image chooser? since 1.0 core/src/main/java/org/apache/brooklyn/core/entity/internal/EntityTransientCopyInternal.java (1 line): - line 63: // TODO For feeds() and config(), need to ensure mutator methods on returned object are not invoked. policy/src/main/java/org/apache/brooklyn/policy/ha/HASensors.java (1 line): - line 39: // TODO How to make this serializable with the entity reference rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/UsageStatistics.java (1 line): - line 35: // TODO populate links with /apps endpoint to link to /usage/applications/{id}, to make it more core/src/main/java/org/apache/brooklyn/core/resolve/jackson/JacksonBetterDelegatingDeserializer.java (1 line): - line 136: // throw new IllegalStateException("TODO catch abstract array attempts and treat as typed"); utils/common/src/main/java/org/apache/brooklyn/util/javalang/Reflections.java (1 line): - line 759: // TODO I've seen strange behaviour where class.getMethods() does not include methods from interfaces. core/src/main/java/org/apache/brooklyn/core/effector/http/HttpCommandEffector.java (1 line): - line 173: // TODO responseBody or else ??? core/src/main/java/org/apache/brooklyn/entity/group/DynamicFabricImpl.java (1 line): - line 191: // TODO Could do best-effort for waiting for remaining tasks, rather than failing on first? api/src/main/java/org/apache/brooklyn/api/mgmt/Task.java (1 line): - line 162: * TODO Fine-grained control over underlying jobs, e.g. to ensure anything represented by this task is actually completed, api/src/main/java/org/apache/brooklyn/api/mgmt/AccessController.java (1 line): - line 29: // TODO Expect this class' methods to change, e.g. including the user doing the launcher-common/src/main/java/org/apache/brooklyn/launcher/command/support/CloudExplorerSupport.java (1 line): - line 130: // TODO consider using org.apache.karaf.shell.support.table.ShellTable to replace/supplement this formatting, core/src/main/java/org/apache/brooklyn/location/localhost/LocalhostPropertiesFromBrooklynProperties.java (1 line): - line 35: // TODO Once delete support for deprecated "location.localhost.*" then can get rid of this class, and use core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/BasicEnricherRebindSupport.java (1 line): - line 38: // TODO entity does config-lookup differently; the memento contains the config keys. launcher/src/main/java/org/apache/brooklyn/launcher/config/BrooklynGlobalConfig.java (1 line): - line 67: // TODO other constants from elsewhere software/base/src/main/java/org/apache/brooklyn/entity/java/JmxAttributeSensor.java (1 line): - line 123: // TODO add entity shutdown hook to stop JmxFeed camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/pdp/ArtifactRequirement.java (1 line): - line 45: // TODO fulfillment locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsUtil.java (1 line): - line 63: // TODO Review what utility methods are needed, and what is now supported in jclouds 1.1 core/src/main/java/org/apache/brooklyn/util/core/LoaderDispatcher.java (1 line): - line 87: // TODO loadClass() should not throw IllegalStateException; should throw ClassNotFoundException without wrapping. core/src/main/java/org/apache/brooklyn/core/mgmt/persist/PersistenceObjectStore.java (1 line): - line 124: // TODO requiring clients to wrap and cache accessors is not very nice API, core/src/main/java/org/apache/brooklyn/core/location/LocationConfigUtils.java (1 line): - line 446: // yuck!: TODO should clean up how these things get passed around locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/DefaultConnectivityResolver.java (1 line): - line 452: // TODO See waitForSshable, which now handles if the node.getLoginCredentials has both a password+key launcher/src/main/java/org/apache/brooklyn/launcher/config/CustomResourceLocator.java (1 line): - line 72: // TODO we could allow the source to be overridden from config, rest/rest-server/src/main/java/org/apache/brooklyn/rest/filter/RequestTaggingFilter.java (1 line): - line 36: // TODO Deprecate after porting LoggingFilter camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/CampTypePlanTransformer.java (1 line): - line 45: // TODO any use in having these formats? if not, remove. Nov 2015. core/src/main/java/org/apache/brooklyn/core/mgmt/internal/NonDeploymentUsageManager.java (1 line): - line 36: // TODO All the `isInitialManagementContextReal()` code-checks is a code-smell. core/src/main/java/org/apache/brooklyn/core/mgmt/internal/LocalSubscriptionManager.java (1 line): - line 248: // FIXME ALEX - this seems wrong utils/common/src/main/java/org/apache/brooklyn/util/time/Time.java (1 line): - line 603: // TODO does 'never' work? core/src/main/java/org/apache/brooklyn/entity/group/SshCommandMembershipTrackingPolicy.java (1 line): - line 91: // TODO these methods maybe not needed due to EnumTypeCoercions core/src/main/java/org/apache/brooklyn/core/objs/proxy/AbstractBrooklynObjectProxyImpl.java (1 line): - line 45: // TODO Currently the proxy references the real entity and invokes methods on it directly. core/src/main/java/org/apache/brooklyn/core/typereg/BundleUpgradeParser.java (1 line): - line 539: // TODO Add support for the other options described in the proposal: policy/src/main/java/org/apache/brooklyn/policy/failover/PropagatePrimaryEnricher.java (1 line): - line 93: // TODO - allow strings above also software/base/src/main/java/org/apache/brooklyn/entity/software/base/WorkflowSoftwareProcessSshDriver.java (1 line): - line 84: // TODO see note in VanillaSoftwareProcess about PID_FILE as a config key software/base/src/main/java/org/apache/brooklyn/entity/brooklynnode/LocalBrooklynNodeImpl.java (1 line): - line 33: // TODO Why use BrooklynProperties, rather than StringConfigMap returned by mgmt.getConfig()? utils/common/src/main/java/org/apache/brooklyn/util/CommandLineUtil.java (1 line): - line 23: // FIXME move to brooklyn.util.cli.CommandLineArgs, and change get to "remove" core/src/main/java/org/apache/brooklyn/enricher/stock/YamlRollingTimeWindowMeanEnricher.java (1 line): - line 118: // TODO would be nice to include timestamp, etc core/src/main/java/org/apache/brooklyn/core/mgmt/internal/EntityChangeListener.java (1 line): - line 30: // TODO for testing only! rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/CatalogResource.java (1 line): - line 499: // TODO Move to an appropriate utility class? policy/src/main/java/org/apache/brooklyn/policy/loadbalancing/ItemsInContainersGroupImpl.java (1 line): - line 46: // TODO Inefficient: will not scale to many 1000s of items rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/EntityResource.java (1 line): - line 255: // TODO deprecate in favour of ActivityApi.get ? core/src/main/java/org/apache/brooklyn/util/core/internal/ssh/process/ProcessTool.java (1 line): - line 70: // TODO should remember other flags here? (e.g. NO_EXTRA_OUTPUT, RUN_AS_ROOT, etc) camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/BrooklynEntityMatcher.java (1 line): - line 91: // TODO should we build up a new type, BrooklynEntityComponentTemplate here camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/resolve/interpret/PlanInterpretationNode.java (1 line): - line 126: // TODO matchesRegex ? core/src/main/java/org/apache/brooklyn/core/internal/storage/Reference.java (1 line): - line 30: // TODO We can add compareAndSet(T,T) as and when required core/src/main/java/org/apache/brooklyn/util/core/ClassLoaderUtils.java (1 line): - line 402: // TODO not sure warning is appropriate, but won't hide that in all cases yet core/src/main/java/org/apache/brooklyn/core/feed/AbstractFeed.java (1 line): - line 193: // TODO Default impl will result in multiple logs for same error if becomes unreachable core/src/main/java/org/apache/brooklyn/core/annotation/EffectorParam.java (1 line): - line 26: //FIXME Move to brooklyn.entity.effector? core/src/main/java/org/apache/brooklyn/core/location/LocationPropertiesFromBrooklynProperties.java (1 line): - line 90: // TODO better would be to use BrooklynServerConfig, requiring management passed in core/src/main/java/org/apache/brooklyn/core/mgmt/internal/EntityManagementSupport.java (1 line): - line 507: // TODO framework stopped activities, e.g. serialize state ? api/src/main/java/org/apache/brooklyn/api/mgmt/ha/HighAvailabilityMode.java (1 line): - line 64: // TODO when multi-master supported we will of course not fail fast on startup when there is already a master; core/src/main/java/org/apache/brooklyn/core/entity/lifecycle/ServiceStateLogic.java (1 line): - line 590: // TODO items below should probably also have inheritance NONE ? core/src/main/java/org/apache/brooklyn/enricher/stock/aggregator/AggregationJob.java (1 line): - line 45: "A list of high availability primaries "); //TODO: find out what this is and add a better description core/src/main/java/org/apache/brooklyn/core/resolve/jackson/BrooklynJacksonType.java (1 line): - line 141: // TODO could be improved to take most specific, not first; and there are probably places that duplicate this which should call here core/src/main/java/org/apache/brooklyn/core/workflow/WorkflowCommonConfig.java (1 line): - line 34: // TODO is this needed? probably just for effectors and possibly custom steps. api/src/main/java/org/apache/brooklyn/api/mgmt/ha/ManagementNodeSyncRecord.java (1 line): - line 37: // TODO Not setting URI currently; ManagementContext doesn't know its URI; only have one if web-console was enabled. core/src/main/java/org/apache/brooklyn/core/config/ListConfigKey.java (1 line): - line 59: //TODO Create interface camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/pdp/Artifact.java (1 line): - line 65: // TODO "map" short form core/src/main/java/org/apache/brooklyn/core/policy/AbstractPolicy.java (1 line): - line 57: // TODO Don't let `this` reference escape during construction utils/common/src/main/java/org/apache/brooklyn/util/osgi/OsgiUtils.java (1 line): - line 92: // TODO deprecate? software/base/src/main/java/org/apache/brooklyn/entity/software/base/EmptyWindowsProcessWinRmDriver.java (1 line): - line 92: /* TODO not necessarily, but there is not yet an easy way to persist state without core/src/main/java/org/apache/brooklyn/core/effector/AddEffectorInitializerAbstract.java (1 line): - line 66: // TODO support TypeToken here ... and anyone who looks this up dynamically should use BrooklynTypeNameResolver software/base/src/main/java/org/apache/brooklyn/entity/software/base/EmptySoftwareProcessSshDriver.java (1 line): - line 85: /* TODO not necessarily, but there is not yet an easy way to persist state without rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/EffectorApi.java (1 line): - line 97: @ApiParam(/* FIXME: giving a `name` in swagger @ApiParam seems wrong as this object is the body, not a named argument */ name = "parameters", core/src/main/java/org/apache/brooklyn/entity/group/zoneaware/ProportionalZoneFailureDetector.java (1 line): - line 29: // TODO Would be nice to weight it disproportionately for more recent attempts; but this will do for now. rest/rest-server/src/main/java/org/apache/brooklyn/rest/filter/LoggingFilter.java (1 line): - line 48: // TODO Re-implement as JAX-RS filter api/src/main/java/org/apache/brooklyn/api/mgmt/EntityManager.java (1 line): - line 142: // TODO manage and unmanage without arguments should be changed to take an explicit ManagementTransitionMode core/src/main/java/org/apache/brooklyn/core/entity/drivers/RegistryEntityDriverFactory.java (1 line): - line 83: //TODO: locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/pool/MachinePoolPredicates.java (1 line): - line 121: // TODO other TemplateBuilder fields and TemplateOptions core/src/main/java/org/apache/brooklyn/core/location/access/PortMapping.java (1 line): - line 40: // TODO CIDR's ? core/src/main/java/org/apache/brooklyn/util/core/file/ArchiveBuilder.java (1 line): - line 89: // TODO would be nice to support TAR and TGZ policy/src/main/java/org/apache/brooklyn/policy/followthesun/FollowTheSunParameters.java (1 line): - line 83: //TODO more params about nextHighest vs current core/src/main/java/org/apache/brooklyn/core/internal/storage/impl/BrooklynStorageImpl.java (1 line): - line 59: // TODO Don't like using finalize due to performance overhead, but not launcher/src/main/java/org/apache/brooklyn/launcher/WebAppContextProvider.java (1 line): - line 79: // TODO would be nice if the various karaf startups rename the session cookie property (from JSESSIONID) core/src/main/java/org/apache/brooklyn/core/internal/storage/impl/InmemoryDatagrid.java (1 line): - line 54: // TODO Not doing Maps.newConcurrentMap() because needs to store null values. camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/lookup/PlatformComponentBrooklynLookup.java (1 line): - line 49: // FIXME this walks the whole damn tree! api/src/main/java/org/apache/brooklyn/api/entity/EntitySpec.java (1 line): - line 381: // TODO we could perhaps introduce an ExistingLocation class which can generate a spec based on an ID to formalize this? camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/ApplicationComponentTemplate.java (1 line): - line 38: // TODO platform component templates, maybe other act's too ? rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/CatalogPolicySummary.java (1 line): - line 57: // TODO expose config from policies camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/CampToSpecTransformer.java (1 line): - line 83: // TODO how do we figure out that the plan is not supported vs. invalid to wrap in a PlanNotRecognizedException? core/src/main/java/org/apache/brooklyn/core/internal/BrooklynProperties.java (1 line): - line 164: // TODO Could also read from http://brooklyn.io, for up-to-date values? camp/camp-server/src/main/java/org/apache/brooklyn/camp/server/dto/AssemblyTemplateDto.java (1 line): - line 50: // TODO addl AssemblyTemplate fields server-cli/src/main/java/org/apache/brooklyn/cli/lister/ItemDescriptors.java (1 line): - line 179: // TODO Get javadoc of LocationResolver? Could use docklet? But that would give dependency here core/src/main/java/org/apache/brooklyn/core/location/MachineLifecycleUtils.java (1 line): - line 136: // TODO kill this? policy/src/main/java/org/apache/brooklyn/policy/enricher/TimeWeightedDeltaEnricher.java (1 line): - line 50: * TODO this may end up being deprecated in favour of near-duplicate code in YAML-friendly {@link YamlTimeWeightedDeltaEnricher}, core/src/main/java/org/apache/brooklyn/core/objs/AdjunctType.java (1 line): - line 115: // TODO Remove duplication from EntityDynamicType core/src/main/java/org/apache/brooklyn/core/entity/EntityAsserts.java (1 line): - line 269: // TODO when checking that all keys are strings core/src/main/java/org/apache/brooklyn/core/mgmt/persist/UnwantedStateLoggingMapper.java (1 line): - line 62: // TODO could add more checks to guide developers, for example api/src/main/java/org/apache/brooklyn/api/typereg/BrooklynTypeRegistry.java (1 line): - line 81: // TODO do these belong here, or in a separate master TypePlanTransformer ? see also BrooklynTypePlanTransformer core/src/main/java/org/apache/brooklyn/core/objs/proxy/EntityAdjunctProxyImpl.java (1 line): - line 37: // TODO Currently the proxy references the real entity and invokes methods on it directly. software/base/src/main/java/org/apache/brooklyn/entity/machine/MachineInitTasks.java (1 line): - line 53: // TODO Move somewhere so code can also be called by JcloudsLocation! utils/common/src/main/java/org/apache/brooklyn/util/internal/StringSystemProperty.java (1 line): - line 23: // TODO replace usages of this and related items with ConfigKeys api/src/main/java/org/apache/brooklyn/api/entity/drivers/downloads/DownloadResolver.java (1 line): - line 51: * TODO The driver needs to know what will happen when an install archive is unpacked (e.g. an core/src/main/java/org/apache/brooklyn/core/config/BasicConfigKey.java (1 line): - line 233: // FIXME In groovy, fields were `public final` with a default constructor; do we need the gson? core/src/main/java/org/apache/brooklyn/util/core/mutex/SemaphoreForTasks.java (1 line): - line 40: * TODO As tasks are distributed this should support distribution across the management context. */ locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/networking/JcloudsLocationSecurityGroupCustomizer.java (1 line): - line 229: * TODO investigate whether this can be improved. Can the synchronization be moved to launcher/src/main/java/org/apache/brooklyn/launcher/BrooklynLauncher.java (1 line): - line 388: // TODO Do we want to do this as part of managementContext.terminate, so after other threads are terminated etc? rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/BundleResource.java (1 line): - line 171: // TODO best to default to "not found" - unless maybe they have permission to "see null" core/src/main/java/org/apache/brooklyn/core/typereg/BrooklynCatalogBundleResolvers.java (1 line): - line 66: // TODO cache these in the TypeRegistry, looking for new ones periodically or supplying a way to register them software/winrm/src/main/java/org/apache/brooklyn/core/sensor/windows/WinRmCommandSensor.java (1 line): - line 86: // TODO create a supplier for the command string to support attribute embedding utils/common/src/main/java/org/apache/brooklyn/util/net/Urls.java (1 line): - line 188: * TODO URLEncoder.encode is a HTML encoder, to make strings safe to use in core/src/main/java/org/apache/brooklyn/core/entity/drivers/ReflectiveEntityDriverFactory.java (1 line): - line 196: // TODO: use a proper registry later on api/src/main/java/org/apache/brooklyn/api/objs/BrooklynType.java (1 line): - line 33: // TODO rename as BrooklynObjectSignature or BrooklynObjectMetadata; core/src/main/java/org/apache/brooklyn/util/core/task/system/internal/SystemProcessTaskFactory.java (1 line): - line 41: // FIXME Plum this through?! utils/jmx/jmxrmi-agent/src/main/java/org/apache/brooklyn/util/jmx/jmxrmi/JmxRmiAgent.java (1 line): - line 136: // TODO Security core/src/main/java/org/apache/brooklyn/core/resolve/jackson/JsonShorthandDeserializer.java (1 line): - line 106: // TODO do these methods need the BJSU routines? rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/TaskSummary.java (1 line): - line 142: // TODO if we had access to a mapper we could use it to give better json utils/common/src/main/java/org/apache/brooklyn/util/pool/BasicPool.java (1 line): - line 43: // TODO Implement expiry of pooled resources utils/common/src/main/java/org/apache/brooklyn/util/javalang/LoadedClassLoader.java (1 line): - line 51: // TODO could also add resources camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/DslDeferredFunctionCall.java (1 line): - line 217: // TODO white-list using brooklyn.properties (at runtime) core/src/main/java/org/apache/brooklyn/core/location/cloud/AbstractAvailabilityZoneExtension.java (1 line): - line 78: // TODO bad pattern, as this will likely call alien code (such as asking cloud provider?!) core/src/main/java/org/apache/brooklyn/core/mgmt/entitlement/EntitlementPredicates.java (1 line): - line 35: // TODO PERSISTENCE WORKAROUND core/src/main/java/org/apache/brooklyn/core/location/Locations.java (1 line): - line 108: // FIXME this occurs MOST OF THE TIME e.g. including BrooklynLauncher.location(locationString) camp/camp-base/src/main/java/org/apache/brooklyn/camp/spi/instantiate/BasicAssemblyTemplateInstantiator.java (1 line): - line 30: // TODO this should build it based on the components rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/CatalogLocationSummary.java (1 line): - line 55: // TODO expose config from policies utils/common/src/main/java/org/apache/brooklyn/util/http/executor/HttpRequest.java (1 line): - line 37: // TODO Should we use InputStream for body (rather than byte[]). That would mean we don't have core/src/main/java/org/apache/brooklyn/core/location/access/PortForwardManager.java (1 line): - line 109: // TODO Note: using name "scope" rather than "brooklyn.portForwardManager.scope" so that location spec locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/templates/customize/ExtraPublicKeyDataToAuthOption.java (1 line): - line 49: // TODO remove in 1.1 or later, if we confirm there is no need for this core/src/main/java/org/apache/brooklyn/enricher/stock/UpdatingMap.java (1 line): - line 118: // TODO clean up so that we have synchronization guarantees and can inspect the item to see whether it has changed rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/LocationSpec.java (1 line): - line 33: // FIXME change name, due to confusion with LocationSpec <- no need, as we can kill the class instead soon! core/src/main/java/org/apache/brooklyn/core/objs/proxy/ClassLoaderCache.java (1 line): - line 48: // TODO Should TypesKey use WeakReferences for the classes (e.g. so that if bundle is unloaded, core/src/main/java/org/apache/brooklyn/core/internal/storage/BrooklynStorage.java (1 line): - line 62: * TODO Aled says: Is getNonConcurrentList necessary? rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/AccessApi.java (1 line): - line 42: // TODO First access use-case is to disable location-provisioning (for Citrix's Cloud Portal Business Manager (CPBM)). rest/rest-resources/src/main/java/org/apache/brooklyn/rest/resources/EffectorResource.java (1 line): - line 85: // TODO check effectors? core/src/main/java/org/apache/brooklyn/core/workflow/steps/variables/LoadWorkflowStep.java (1 line): - line 42: // TODO could support "template" here to change the interpolation mode rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/CatalogEnricherSummary.java (1 line): - line 57: // TODO expose config from enrichers core/src/main/java/org/apache/brooklyn/core/mgmt/persist/FileBasedStoreObjectAccessor.java (1 line): - line 130: // TODO Should this write to the temporary file? Otherwise we'll risk getting a partial view of the write. rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/HighAvailabilityTransformer.java (1 line): - line 40: // TODO What links? core/src/main/java/org/apache/brooklyn/core/relations/ByObjectBasicRelationSupport.java (1 line): - line 57: // TODO for now, relationships are stored here (and persisted); ideally we'd look them up in catalog core/src/main/java/org/apache/brooklyn/core/location/AbstractLocationResolver.java (1 line): - line 195: // TODO Hacky; hosts("1.1.1.1") returns argsPart=("1.1.1.1") locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JcloudsMachineNamer.java (1 line): - line 41: // TODO other cloud max length rules core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/PersistenceExceptionHandlerImpl.java (1 line): - line 98: // TODO the default behaviour is simply to warn; we should have a "fail_at_end" behaviour, core/src/main/java/org/apache/brooklyn/core/typereg/AbstractTypePlanTransformer.java (1 line): - line 138: // TODO remove if we don't see any warnings (or when we sort out semantics for template v app v allowed-unresolved better) core/src/main/java/org/apache/brooklyn/core/sensor/StaticSensor.java (1 line): - line 70: // TODO resolve deep? core/src/main/java/org/apache/brooklyn/enricher/stock/Enrichers.java (1 line): - line 555: // TODO What to use as the entity id if using fromEntitySupplier? core/src/main/java/org/apache/brooklyn/core/feed/FeedConfig.java (1 line): - line 69: // TODO these should both be configurable core/src/main/java/org/apache/brooklyn/core/workflow/WorkflowStepDefinition.java (1 line): - line 132: // TODO: might be nice to support a shorthand for on-error; but not yet camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/DslDeferredPropertyAccess.java (1 line): - line 46: * TODO parser return objects that we CAN recognise as being interpreted to form the thing below. core/src/main/java/org/apache/brooklyn/core/mgmt/internal/DeferredBrooklynProperties.java (1 line): - line 75: // TODO Should we fail or return the untransformed value? software/base/src/main/java/org/apache/brooklyn/entity/machine/pool/ServerPoolLocationResolver.java (1 line): - line 98: // TODO Could validate that the namePart matches the existing poolLoc api/src/main/java/org/apache/brooklyn/api/effector/ParameterType.java (1 line): - line 32: // TODO rename this to ParameterInfo rather than type. A ParameterType object is used for each parameter not for each type of parameter. api/src/main/java/org/apache/brooklyn/api/mgmt/rebind/RebindManager.java (1 line): - line 44: // FIXME Should we be calling managementContext.getRebindManager().rebind, using a utils/common/src/main/java/org/apache/brooklyn/util/io/FilePermissions.java (1 line): - line 78: // TODO: what happens to group permissions ? policy/src/main/java/org/apache/brooklyn/policy/ha/AbstractFailureDetector.java (1 line): - line 49: // TODO Remove duplication from ServiceFailureDetector, particularly for the stabilisation delays. camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/BrooklynCampPlatform.java (1 line): - line 79: // TODO artifacts utils/common/src/main/java/org/apache/brooklyn/util/net/Cidr.java (1 line): - line 235: // FIXME remove from here, promote NetworkUtils core/src/main/java/org/apache/brooklyn/core/objs/proxy/EntityProxyImpl.java (1 line): - line 65: // TODO Currently the proxy references the real entity and invokes methods on it directly. core/src/main/java/org/apache/brooklyn/feed/http/HttpPollConfig.java (1 line): - line 148: // TODO Not using Immutable builder, because that fails if duplicates in map1 and map2 core/src/main/java/org/apache/brooklyn/location/byon/ByonLocationResolver.java (1 line): - line 244: // TODO set to null and rely on the MachineLocation. If not then make a dependency to WinRmMachineLocation and use its config key name. core/src/main/java/org/apache/brooklyn/core/mgmt/classloading/ClassLoaderFromStackOfBrooklynClassLoadingContext.java (1 line): - line 84: // TODO xml serializers using this should take a BCLC instead of a CL core/src/main/java/org/apache/brooklyn/core/objs/BrooklynDynamicType.java (1 line): - line 164: // TODO remove or document overlap with ConfigUtilsInternal.findConfigKeys api/src/main/java/org/apache/brooklyn/api/mgmt/rebind/mementos/BrooklynMementoRawData.java (1 line): - line 38: // TODO Should this be on an interface? core/src/main/java/org/apache/brooklyn/core/typereg/BasicRegisteredType.java (1 line): - line 146: @Beta // TODO depending how useful this is, it might be better to replace by a static WeakHashMap in RegisteredTypes core/src/main/java/org/apache/brooklyn/core/entity/AbstractApplication.java (1 line): - line 278: //TODO review mgmt destroy lifecycle core/src/main/java/org/apache/brooklyn/core/plan/PlanToSpecFactory.java (1 line): - line 117: // TODO primitive loading mechanism, just tries all in order; we'll want something better as we get more plan transformers core/src/main/java/org/apache/brooklyn/util/core/task/DynamicSequentialTask.java (1 line): - line 294: // TODO overkill having a thread/task for this, but it works rest/rest-resources/src/main/java/org/apache/brooklyn/rest/BrooklynWebConfig.java (1 line): - line 56: // TODO document core/src/main/java/org/apache/brooklyn/core/mgmt/ha/OsgiManager.java (1 line): - line 680: // TODO for snapshot versions we should indicate which one is best to use utils/common/src/main/java/org/apache/brooklyn/util/collections/QuorumCheck.java (1 line): - line 136: // TODO also accept "50%", and "50%,1" utils/common/src/main/java/org/apache/brooklyn/util/http/executor/HttpResponseImpl.java (1 line): - line 70: // TODO In the streaming case could have Content-Length set in the headers. core/src/main/java/org/apache/brooklyn/util/core/crypto/SecureKeys.java (1 line): - line 89: // TODO cache is only for fallback "reader" strategy (2015-01); delete when Parser confirmed working core/src/main/java/org/apache/brooklyn/core/mgmt/internal/AbstractSubscriptionManager.java (1 line): - line 43: // TODO Perhaps could use guava's SynchronizedSetMultimap? But need to check its synchronization guarantees. rest/rest-api/src/main/java/org/apache/brooklyn/rest/domain/LinkWithMetadata.java (1 line): - line 34: // TODO remove 'metadata' and promote its contents to be top-level fields; then unmark as Beta camp/camp-server/src/main/java/org/apache/brooklyn/camp/server/dto/AssemblyDto.java (1 line): - line 53: // TODO addl AssemblyTemplate fields rest/rest-api/src/main/java/org/apache/brooklyn/rest/api/PolicyConfigApi.java (1 line): - line 64: // TODO support parameters ?show=value,summary&name=xxx &format={string,json,xml} core/src/main/java/org/apache/brooklyn/core/entity/EntityInternal.java (1 line): - line 166: // TODO extend AdjunctSupport, after 1.0.0 software/base/src/main/java/org/apache/brooklyn/entity/java/VanillaJavaAppImpl.java (1 line): - line 98: // FIXME Make this an attribute; don't assume it hsa to be ssh? What uses this? software/base/src/main/java/org/apache/brooklyn/feed/jmx/JmxOperationPollConfig.java (1 line): - line 105: // FIXME Have a build() method for ensuring signature is set, and making class subsequently immutable? core/src/main/java/org/apache/brooklyn/feed/shell/ShellFeed.java (1 line): - line 260: // FIXME Add generic timeout() support to task ExecutionManager core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/transformer/impl/DeleteOrphanedStateTransformer.java (1 line): - line 47: // TODO this isn't really a "CompoundTransformer" - it doesn't register any transformers core/src/main/java/org/apache/brooklyn/core/mgmt/EntityManagementUtils.java (1 line): - line 154: // TODO make it so that this arg does not have to be supplied to START ! camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/dsl/DslUtils.java (1 line): - line 89: // TODO if it fails log a warning -- eg entitySpec with root.war that doesn't exist core/src/main/java/org/apache/brooklyn/core/server/entity/BrooklynMetricsImpl.java (1 line): - line 43: // TODO Don't use own thread pool; use new "feeds" (see FunctionFeed, or variants there of) core/src/main/java/org/apache/brooklyn/core/mgmt/entitlement/Entitlements.java (1 line): - line 65: // TODO applies to bundles and registered types; should pass object or probably better add more entitlements? core/src/main/java/org/apache/brooklyn/core/plan/PlanToSpecTransformer.java (1 line): - line 46: // TODO determine semantics of plan type; for now, we try all using PlanToSpecFactory methods, camp/camp-server/src/main/java/org/apache/brooklyn/camp/server/rest/resource/AssemblyTemplateRestResource.java (1 line): - line 64: // TODO AssemblyDto, or location thereto? utils/common/src/main/java/org/apache/brooklyn/util/net/NetworkMultiAddressUtils.java (1 line): - line 29: // TODO should convert to byte arrays then binary, and look at binary digit match length ! core/src/main/java/org/apache/brooklyn/core/mgmt/rebind/ActivePartialRebindIteration.java (1 line): - line 95: * TODO: Currently this does not do any pausing or unmanagement or guarding write access, core/src/main/java/org/apache/brooklyn/feed/CommandPollConfig.java (1 line): - line 46: // TODO Kept in case it's persisted; new code will not use this. core/src/main/java/org/apache/brooklyn/core/typereg/UnsupportedCatalogBundleException.java (1 line): - line 22: // TODO add another hierarchy RecognizedTypePlanException or a score to indicate priority of errors for reporting? core/src/main/java/org/apache/brooklyn/core/workflow/steps/flow/LogWorkflowStep.java (1 line): - line 71: // TODO workflow log messages should include step id as logging MDC, or message to start/end each workflow/task policy/src/main/java/org/apache/brooklyn/policy/loadbalancing/BalanceableWorkerPool.java (1 line): - line 42: // FIXME Asymmetry between loadbalancing and followTheSun: ITEM_ADDED and ITEM_REMOVED in loadbalancing locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/JCloudsPropertiesBuilder.java (1 line): - line 113: // TODO convert AWS-only flags to config keys software/base/src/main/java/org/apache/brooklyn/entity/software/base/VanillaWindowsProcess.java (1 line): - line 175: // TODO If automatic updates are enabled and there are updates waiting to be installed, thirty minutes may not be sufficient... api/src/main/java/org/apache/brooklyn/api/entity/drivers/EntityDriver.java (1 line): - line 42: * FIXME The signature of this will change to return Entity instead of EntityLocal. core/src/main/java/org/apache/brooklyn/util/core/xstream/HashMultimapConverter.java (1 line): - line 43: // TODO how do we convert this from ObjectOutputStream to XStream mapper ? core/src/main/java/org/apache/brooklyn/core/entity/Dumper.java (1 line): - line 287: // TODO create a FeedType cf EnricherType ? rest/rest-resources/src/main/java/org/apache/brooklyn/rest/util/MultiSessionAttributeAdapter.java (1 line): - line 213: //TODO just check this the first time preferred session is accessed on a given request (when it is looked up) locations/container/src/main/java/org/apache/brooklyn/container/location/kubernetes/KubernetesClientRegistryImpl.java (1 line): - line 86: // TODO Should we also set configBuilder.withTrustCerts(true) here? utils/common/src/main/java/org/apache/brooklyn/util/javalang/Boxing.java (1 line): - line 100: // TODO maybe better to switch to using Primitives, eg: core/src/main/java/org/apache/brooklyn/entity/group/AbstractGroup.java (1 line): - line 92: // FIXME Do we really want this method? "setMembers" is a misleading name core/src/main/java/org/apache/brooklyn/util/core/xstream/XmlSerializer.java (1 line): - line 256: // TODO as noted in ClassRenamingMapper that class can be simplified if api/src/main/java/org/apache/brooklyn/api/mgmt/ExecutionContext.java (1 line): - line 92: // TODO reference ImmediateSupplier when that class is moved to utils project camp/camp-brooklyn/src/main/java/org/apache/brooklyn/camp/brooklyn/spi/creation/service/UrlServiceSpecResolver.java (1 line): - line 67: // TODO somehow specify to allow full syntax for services api/src/main/java/org/apache/brooklyn/api/location/LocationSpec.java (1 line): - line 43: // TODO Would like to add `configure(ConfigBag)`, but `ConfigBag` is in core rather than api rest/rest-resources/src/main/java/org/apache/brooklyn/rest/transform/EntityTransformer.java (1 line): - line 82: // TODO: change all these as well :S locations/jclouds/src/main/java/org/apache/brooklyn/location/jclouds/softlayer/SoftLayerSameVlanLocationCustomizer.java (1 line): - line 247: // TODO if there were a failure and race this machine might have different details to what we've recorded software/base/src/main/java/org/apache/brooklyn/entity/software/base/SoftwareProcess.java (1 line): - line 54: // TODO Want this to have typeInheritance.merge as well, but currently only supported for maps core/src/main/java/org/apache/brooklyn/core/mgmt/persist/XmlMementoSerializer.java (1 line): - line 464: // TODO: readClassType() and readClassAttribute()