src/brpc/policy/rtmp_protocol.cpp (8 lines): - line 2145: // TODO: execq? - line 2173: // TODO: execq? - line 2228: // TODO: execq? - line 2247: // TODO: execq? - line 2390: // TODO: Set this field. - line 2510: // TODO: Should Run return bool? - line 2978: // TODO: frequent, commented now - line 3007: // TODO: frequent, commented now src/brpc/policy/http_rpc_protocol.cpp (7 lines): - line 91: //TODO add protocols other than IPv4 supports. - line 376: // TODO: changing when imsg_guard->read_body_progressively() is true - line 413: // TODO: More strict parsing - line 640: // TODO: Checking required fields of http header. - line 694: // TODO: do we need this? - line 1052: // TODO: this is not sent - line 1369: // TODO: Fix backdoor that sends BuiltinService at first src/brpc/controller.cpp (6 lines): - line 897: // TODO: Replace this with stream_creator. - line 918: // TODO: Replace this with stream_creator. - line 976: // FIXME: We're assuming the calling thread is about to quit. - line 1201: // TODO: PackRequest may accept SocketMessagePtr<>? - line 1453: // TODO: Need more security advices from professionals. - line 1454: // TODO: Is percent encoding better? src/brpc/details/hpack.cpp (5 lines): - line 384: // TODO: push_back is probably costly since it acquires tls everytime it - line 407: // FIXME: resizing of out is costly - line 708: // TODO: Add Options that indexes name independently - line 833: // TODO: Expose NeverIndex to the caller. - line 838: // TODO: Expose NeverIndex to the caller. src/brpc/rdma/rdma_endpoint.cpp (4 lines): - line 496: // TODO: Read Hello Message customized data - line 604: // TODO: Read Hello Message customized header - line 1160: attr.pkey_index = 0; // TODO: support more pkey use in future - line 1178: attr.path_mtu = IBV_MTU_1024; // TODO: support more mtu in future src/brpc/server.cpp (4 lines): - line 1232: //TODO add TrackMe support - line 1308: // TODO: calculate timeout? - line 1338: // TODO: Can't delete _keytable_pool which may be accessed by - line 1623: // TODO: This is weird src/brpc/builtin/pprof_perl.cpp (4 lines): - line 706: " # TODO: Maybe we should not pass the --noantialias flag\n" - line 1929: " # TODO: Compute range of lines to print together to deal with\n" - line 2122: " # TODO: omit low %age edges\n" - line 2931: " # TODO: Remove TCMalloc once everything has been\n" src/bthread/task_control.cpp (4 lines): - line 242: // TODO: Handle the case that worker quits before add_group - line 245: usleep(100); // TODO: Elaborate - line 371: // TODO: Not needed anymore since non-worker pthread cannot have TaskGroup - line 486: // TODO: Reduce this lock src/brpc/socket.cpp (4 lines): - line 589: // FIXME : close-on-exec should be set by new syscalls or worse: set right - line 943: // FIXME: Design a better interface for AppConnect - line 1963: // TODO: Separate SSL stuff from SocketConnection - line 2011: // TODO: Reuse ssl session id for client src/brpc/ts.cpp (3 lines): - line 196: // TODO: always false right now. - line 1428: // TODO: maybe only need to write at begin and end of ts. - line 1436: // TODO: FIXME: figure out why use discontinuity of msg src/bvar/collector.cpp (3 lines): - line 29: // TODO: Do we need to expose this flag? Dumping thread may dump different - line 234: // FIXME: equal probabilities to drop. - line 296: // FIXME: May become too large at startup. src/bthread/task_group.cpp (3 lines): - line 361: // TODO: Save thread_return - line 366: // FIXME: the time from quiting fn to here is not counted into cputime - line 999: // TODO: bthreads created by BTHREAD_ATTR_PTHREAD blocking on bthread_usleep() src/brpc/policy/thrift_protocol.cpp (3 lines): - line 363: // TODO: this is not sent - line 610: // TODO: Convert exception type to brpc errors. - line 757: // TODO: Nowhere to set tracing ids. src/bthread/key.cpp (2 lines): - line 486: // TODO: return_keytable may race with this function, we don't destroy - line 526: // TODO: this is not strict `reserve' because we only check #free. src/bvar/detail/agent_group.h (2 lines): - line 54: // TODO: We should remove the template parameter and unify AgentGroup - line 102: // TODO: How to avoid double free? src/bvar/detail/combiner.h (2 lines): - line 283: // TODO: For non-atomic types, we can pass the reference to op directly. - line 316: // TODO: Is uniqueness-checking necessary here? src/brpc/policy/nshead_protocol.cpp (2 lines): - line 140: // TODO: this is not sent - line 445: // TODO: Nowhere to set tracing ids. src/brpc/details/naming_service_thread.cpp (2 lines): - line 124: // TODO: For each unique SocketMapKey (i.e. SSL settings), insert a new - line 187: // TODO: Remove all Sockets that have the same address in SocketMapKey.peer src/brpc/builtin/rpcz_service.cpp (2 lines): - line 191: // TODO: Going through all extractors is not strictly correct because - line 341: // TODO: We can't hyperlink parent_span now because there's no generic src/brpc/ssl_options.h (2 lines): - line 91: // TODO: Support CRL - line 161: // TODO: Support OSCP stapling src/butil/containers/flat_map_inl.h (2 lines): - line 389: // TODO: Do we need auto collapsing here? - line 455: // TODO: Do we need auto collapsing here? src/brpc/stream.cpp (2 lines): - line 527: // TODO:: See the comments in Consume - line 646: // TODO add *this to host socke src/bthread/mutex.cpp (2 lines): - line 445: // TODO: may need dlvsym when GLIBC has multiple versions of a same symbol. - line 474: // TODO: look workaround for dlsym on mac src/brpc/socket.h (2 lines): - line 83: // TODO: Remove this class which is replace-able with SocketMessage - line 245: // TODO: Comment fields src/brpc/socket_map.cpp (2 lines): - line 109: // TODO: We don't have expected_id to pass right now since the callsite - line 203: // TODO: Elaborate. src/mcpack2pb/generator.cpp (2 lines): - line 551: // TODO: Encoding checking/conversion for pb strings(utf8). - line 580: // FIXME: describe type. example/thrift_extension_c++/server2.cpp (1 line): - line 55: // TODO: Following Cast<> drops data field from ProxyRequest which src/brpc/amf.cpp (1 line): - line 144: // TODO: Try to reuse the space. src/brpc/ts.h (1 line): - line 326: // TODO: Is it worthwhile to new? src/bthread/butex.cpp (1 line): - line 589: // FIXME: jump back to original thread is buggy. src/brpc/rtmp.cpp (1 line): - line 2565: // TODO: put into some bvars? src/bvar/recorder.h (1 line): - line 181: // TODO: The following numeric functions should be independent utils src/brpc/parallel_channel.h (1 line): - line 105: // TODO: Remove this backward compatibility method. src/butil/resource_pool_inl.h (1 line): - line 176: TODO: Popping from _free needs to copy a FreeChunk which is \ src/bthread/context.cpp (1 line): - line 797: " ; TODO: Numeric offset since llvm still does not support labels in ADR. Fix:\n" src/brpc/policy/public_pbrpc_protocol.cpp (1 line): - line 274: // TODO: Nowhere to set tracing ids. src/butil/time.h (1 line): - line 292: // TODO: should be OK until CPU's frequency exceeds 16GHz. src/butil/containers/stack_container.h (1 line): - line 92: // TODO: If we were fancy pants, perhaps we could share storage src/brpc/policy/baidu_rpc_protocol.cpp (1 line): - line 446: // TODO: this is not sent src/brpc/acceptor.cpp (1 line): - line 113: // TODO: this is not efficient for a lot of connections(>100K) src/brpc/policy/hulu_pbrpc_protocol.cpp (1 line): - line 327: // TODO: this is not sent src/butil/iobuf.cpp (1 line): - line 2179: // TODO: butil::IOBuf supports dynamic sized blocks. src/brpc/adaptive_max_concurrency.h (1 line): - line 78: _timeout_conf; // TODO std::varient for different type src/butil/object_pool_inl.h (1 line): - line 188: TODO: Popping from _free needs to copy a FreeChunk which is \ src/brpc/span.cpp (1 line): - line 47: // TODO: collected per second is customizable. src/butil/threading/platform_thread_mac.mm (1 line): - line 46: // TODO: add tracked_objects related headers src/bvar/variable.cpp (1 line): - line 890: // FIXME: -bvar_dump_interval is actually unreloadable but we need to src/brpc/global.cpp (1 line): - line 282: // TODO: Calling MallocExtension::instance()->ReleaseFreeMemory may src/butil/synchronization/lock.h (1 line): - line 122: // TODO: Remove this type. src/brpc/policy/ubrpc2pb_protocol.cpp (1 line): - line 223: // TODO: This is optional since serializing already checks. src/butil/files/temp_file.cpp (1 line): - line 113: // TODO: is this right? tools/wireshark_baidu_std.lua (1 line): - line 158: -- TODO: pop items src/brpc/details/http_parser.cpp (1 line): - line 2023: /* just ignore this shit. TODO check for overflow */ src/json2pb/zero_copy_stream_writer.h (1 line): - line 83: // TODO: Add BIADU_CHECK src/brpc/policy/sofa_pbrpc_protocol.cpp (1 line): - line 304: // TODO: this is not sent src/bthread/types.h (1 line): - line 163: // TODO: bthread_contention_site_t should be put into butex. src/brpc/policy/domain_naming_service.cpp (1 line): - line 153: //TODO add protocols other than IPv4 supports src/brpc/nshead_pb_service_adaptor.h (1 line): - line 53: // FIXME: server is not needed anymore, controller->server() is same src/brpc/policy/consistent_hashing_load_balancer.cpp (1 line): - line 33: // TODO: or 160? src/brpc/socket_map.h (1 line): - line 187: // TODO: When RpcChannels connecting to one EndPoint are frequently created src/bthread/interrupt_pthread.cpp (1 line): - line 27: // TODO: Make sure SIGURG is not used by user. src/butil/status.cpp (1 line): - line 117: // TODO: If we failed to allocate, the status will be OK. src/brpc/controller.h (1 line): - line 886: // TODO: Replace following fields with StreamCreator src/brpc/details/ssl_helper.cpp (1 line): - line 413: // TODO: Verify the CNAME in certificate matches the requesting host src/butil/endpoint.cpp (1 line): - line 408: //TODO: add more values?