catalogs/catalog-jdbc-mysql/src/main/java/org/apache/gravitino/catalog/mysql/operation/MysqlTableOperations.java [224:387]: - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - if (change instanceof TableChange.UpdateComment) { updateComment = (TableChange.UpdateComment) change; } else if (change instanceof TableChange.SetProperty) { // The set attribute needs to be added at the end. setProperties.add(((TableChange.SetProperty) change)); } else if (change instanceof TableChange.RemoveProperty) { // mysql does not support deleting table attributes, it can be replaced by Set Property throw new IllegalArgumentException("Remove property is not supported yet"); } else if (change instanceof TableChange.AddColumn) { TableChange.AddColumn addColumn = (TableChange.AddColumn) change; lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); alterSql.add(addColumnFieldDefinition(addColumn)); } else if (change instanceof TableChange.RenameColumn) { lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); TableChange.RenameColumn renameColumn = (TableChange.RenameColumn) change; alterSql.add(renameColumnFieldDefinition(renameColumn, lazyLoadTable)); } else if (change instanceof TableChange.UpdateColumnDefaultValue) { lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); TableChange.UpdateColumnDefaultValue updateColumnDefaultValue = (TableChange.UpdateColumnDefaultValue) change; alterSql.add( updateColumnDefaultValueFieldDefinition(updateColumnDefaultValue, lazyLoadTable)); } else if (change instanceof TableChange.UpdateColumnType) { lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); TableChange.UpdateColumnType updateColumnType = (TableChange.UpdateColumnType) change; alterSql.add(updateColumnTypeFieldDefinition(updateColumnType, lazyLoadTable)); } else if (change instanceof TableChange.UpdateColumnComment) { lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); TableChange.UpdateColumnComment updateColumnComment = (TableChange.UpdateColumnComment) change; alterSql.add(updateColumnCommentFieldDefinition(updateColumnComment, lazyLoadTable)); } else if (change instanceof TableChange.UpdateColumnPosition) { lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); TableChange.UpdateColumnPosition updateColumnPosition = (TableChange.UpdateColumnPosition) change; alterSql.add(updateColumnPositionFieldDefinition(updateColumnPosition, lazyLoadTable)); } else if (change instanceof TableChange.DeleteColumn) { TableChange.DeleteColumn deleteColumn = (TableChange.DeleteColumn) change; lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); String deleteColSql = deleteColumnFieldDefinition(deleteColumn, lazyLoadTable); if (StringUtils.isNotEmpty(deleteColSql)) { alterSql.add(deleteColSql); } } else if (change instanceof TableChange.UpdateColumnNullability) { lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); alterSql.add( updateColumnNullabilityDefinition( (TableChange.UpdateColumnNullability) change, lazyLoadTable)); } else if (change instanceof TableChange.AddIndex) { alterSql.add(addIndexDefinition((TableChange.AddIndex) change)); } else if (change instanceof TableChange.DeleteIndex) { lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); alterSql.add(deleteIndexDefinition(lazyLoadTable, (TableChange.DeleteIndex) change)); } else if (change instanceof TableChange.UpdateColumnAutoIncrement) { lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); alterSql.add( updateColumnAutoIncrementDefinition( lazyLoadTable, (TableChange.UpdateColumnAutoIncrement) change)); } else { throw new IllegalArgumentException( "Unsupported table change type: " + change.getClass().getName()); } } if (!setProperties.isEmpty()) { alterSql.add(generateTableProperties(setProperties)); } // Last modified comment if (null != updateComment) { String newComment = updateComment.getNewComment(); if (null == StringIdentifier.fromComment(newComment)) { // Detect and add Gravitino id. JdbcTable jdbcTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); StringIdentifier identifier = StringIdentifier.fromComment(jdbcTable.comment()); if (null != identifier) { newComment = StringIdentifier.addToComment(identifier, newComment); } } alterSql.add("COMMENT '" + newComment + "'"); } if (!setProperties.isEmpty()) { alterSql.add(generateTableProperties(setProperties)); } if (CollectionUtils.isEmpty(alterSql)) { return ""; } // Return the generated SQL statement String result = "ALTER TABLE `" + tableName + "`\n" + String.join(",\n", alterSql) + ";"; LOG.info("Generated alter table:{} sql: {}", databaseName + "." + tableName, result); return result; } private String updateColumnAutoIncrementDefinition( JdbcTable table, TableChange.UpdateColumnAutoIncrement change) { if (change.fieldName().length > 1) { throw new UnsupportedOperationException("Nested column names are not supported"); } String col = change.fieldName()[0]; JdbcColumn column = getJdbcColumnFromTable(table, col); if (change.isAutoIncrement()) { Preconditions.checkArgument( Types.allowAutoIncrement(column.dataType()), "Auto increment is not allowed, type: " + column.dataType()); } JdbcColumn updateColumn = JdbcColumn.builder() .withName(col) .withDefaultValue(column.defaultValue()) .withNullable(column.nullable()) .withType(column.dataType()) .withComment(column.comment()) .withAutoIncrement(change.isAutoIncrement()) .build(); return MODIFY_COLUMN + BACK_QUOTE + col + BACK_QUOTE + appendColumnDefinition(updateColumn, new StringBuilder()); } @VisibleForTesting static String deleteIndexDefinition( JdbcTable lazyLoadTable, TableChange.DeleteIndex deleteIndex) { if (deleteIndex.isIfExists()) { if (Arrays.stream(lazyLoadTable.index()) .anyMatch(index -> index.name().equals(deleteIndex.getName()))) { throw new IllegalArgumentException("Index does not exist"); } } return "DROP INDEX " + BACK_QUOTE + deleteIndex.getName() + BACK_QUOTE; } private String updateColumnNullabilityDefinition( TableChange.UpdateColumnNullability change, JdbcTable table) { validateUpdateColumnNullable(change, table); String col = change.fieldName()[0]; JdbcColumn column = getJdbcColumnFromTable(table, col); JdbcColumn updateColumn = JdbcColumn.builder() .withName(col) .withDefaultValue(column.defaultValue()) .withNullable(change.nullable()) .withType(column.dataType()) .withComment(column.comment()) .withAutoIncrement(column.autoIncrement()) .build(); return MODIFY_COLUMN + BACK_QUOTE + col + BACK_QUOTE + appendColumnDefinition(updateColumn, new StringBuilder()); } @VisibleForTesting static String addIndexDefinition(TableChange.AddIndex addIndex) { StringBuilder sqlBuilder = new StringBuilder(); sqlBuilder.append("ADD "); switch (addIndex.getType()) { case PRIMARY_KEY: if (null != addIndex.getName() && !StringUtils.equalsIgnoreCase( addIndex.getName(), Indexes.DEFAULT_MYSQL_PRIMARY_KEY_NAME)) { - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - catalogs/catalog-jdbc-oceanbase/src/main/java/org/apache/gravitino/catalog/oceanbase/operation/OceanBaseTableOperations.java [239:402]: - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - if (change instanceof TableChange.UpdateComment) { updateComment = (TableChange.UpdateComment) change; } else if (change instanceof TableChange.SetProperty) { // The set attribute needs to be added at the end. setProperties.add(((TableChange.SetProperty) change)); } else if (change instanceof TableChange.RemoveProperty) { // OceanBase does not support deleting table attributes, it can be replaced by Set Property throw new IllegalArgumentException("Remove property is not supported yet"); } else if (change instanceof TableChange.AddColumn) { TableChange.AddColumn addColumn = (TableChange.AddColumn) change; lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); alterSql.add(addColumnFieldDefinition(addColumn)); } else if (change instanceof TableChange.RenameColumn) { lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); TableChange.RenameColumn renameColumn = (TableChange.RenameColumn) change; alterSql.add(renameColumnFieldDefinition(renameColumn, lazyLoadTable)); } else if (change instanceof TableChange.UpdateColumnDefaultValue) { lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); TableChange.UpdateColumnDefaultValue updateColumnDefaultValue = (TableChange.UpdateColumnDefaultValue) change; alterSql.add( updateColumnDefaultValueFieldDefinition(updateColumnDefaultValue, lazyLoadTable)); } else if (change instanceof TableChange.UpdateColumnType) { lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); TableChange.UpdateColumnType updateColumnType = (TableChange.UpdateColumnType) change; alterSql.add(updateColumnTypeFieldDefinition(updateColumnType, lazyLoadTable)); } else if (change instanceof TableChange.UpdateColumnComment) { lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); TableChange.UpdateColumnComment updateColumnComment = (TableChange.UpdateColumnComment) change; alterSql.add(updateColumnCommentFieldDefinition(updateColumnComment, lazyLoadTable)); } else if (change instanceof TableChange.UpdateColumnPosition) { lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); TableChange.UpdateColumnPosition updateColumnPosition = (TableChange.UpdateColumnPosition) change; alterSql.add(updateColumnPositionFieldDefinition(updateColumnPosition, lazyLoadTable)); } else if (change instanceof TableChange.DeleteColumn) { TableChange.DeleteColumn deleteColumn = (TableChange.DeleteColumn) change; lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); String deleteColSql = deleteColumnFieldDefinition(deleteColumn, lazyLoadTable); if (StringUtils.isNotEmpty(deleteColSql)) { alterSql.add(deleteColSql); } } else if (change instanceof TableChange.UpdateColumnNullability) { lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); alterSql.add( updateColumnNullabilityDefinition( (TableChange.UpdateColumnNullability) change, lazyLoadTable)); } else if (change instanceof TableChange.AddIndex) { alterSql.add(addIndexDefinition((TableChange.AddIndex) change)); } else if (change instanceof TableChange.DeleteIndex) { lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); alterSql.add(deleteIndexDefinition(lazyLoadTable, (TableChange.DeleteIndex) change)); } else if (change instanceof TableChange.UpdateColumnAutoIncrement) { lazyLoadTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); alterSql.add( updateColumnAutoIncrementDefinition( lazyLoadTable, (TableChange.UpdateColumnAutoIncrement) change)); } else { throw new IllegalArgumentException( "Unsupported table change type: " + change.getClass().getName()); } } if (!setProperties.isEmpty()) { alterSql.add(generateTableProperties(setProperties)); } // Last modified comment if (null != updateComment) { String newComment = updateComment.getNewComment(); if (null == StringIdentifier.fromComment(newComment)) { // Detect and add Gravitino id. JdbcTable jdbcTable = getOrCreateTable(databaseName, tableName, lazyLoadTable); StringIdentifier identifier = StringIdentifier.fromComment(jdbcTable.comment()); if (null != identifier) { newComment = StringIdentifier.addToComment(identifier, newComment); } } alterSql.add("COMMENT '" + newComment + "'"); } if (!setProperties.isEmpty()) { alterSql.add(generateTableProperties(setProperties)); } if (CollectionUtils.isEmpty(alterSql)) { return ""; } // Return the generated SQL statement String result = "ALTER TABLE `" + tableName + "`\n" + String.join(",\n", alterSql) + ";"; LOG.info("Generated alter table:{} sql: {}", databaseName + "." + tableName, result); return result; } private String updateColumnAutoIncrementDefinition( JdbcTable table, TableChange.UpdateColumnAutoIncrement change) { if (change.fieldName().length > 1) { throw new UnsupportedOperationException("Nested column names are not supported"); } String col = change.fieldName()[0]; JdbcColumn column = getJdbcColumnFromTable(table, col); if (change.isAutoIncrement()) { Preconditions.checkArgument( Types.allowAutoIncrement(column.dataType()), "Auto increment is not allowed, type: " + column.dataType()); } JdbcColumn updateColumn = JdbcColumn.builder() .withName(col) .withDefaultValue(column.defaultValue()) .withNullable(column.nullable()) .withType(column.dataType()) .withComment(column.comment()) .withAutoIncrement(change.isAutoIncrement()) .build(); return MODIFY_COLUMN + BACK_QUOTE + col + BACK_QUOTE + appendColumnDefinition(updateColumn, new StringBuilder()); } @VisibleForTesting static String deleteIndexDefinition( JdbcTable lazyLoadTable, TableChange.DeleteIndex deleteIndex) { if (deleteIndex.isIfExists()) { if (Arrays.stream(lazyLoadTable.index()) .anyMatch(index -> index.name().equals(deleteIndex.getName()))) { throw new IllegalArgumentException("Index does not exist"); } } return "DROP INDEX " + BACK_QUOTE + deleteIndex.getName() + BACK_QUOTE; } private String updateColumnNullabilityDefinition( TableChange.UpdateColumnNullability change, JdbcTable table) { validateUpdateColumnNullable(change, table); String col = change.fieldName()[0]; JdbcColumn column = getJdbcColumnFromTable(table, col); JdbcColumn updateColumn = JdbcColumn.builder() .withName(col) .withDefaultValue(column.defaultValue()) .withNullable(change.nullable()) .withType(column.dataType()) .withComment(column.comment()) .withAutoIncrement(column.autoIncrement()) .build(); return MODIFY_COLUMN + BACK_QUOTE + col + BACK_QUOTE + appendColumnDefinition(updateColumn, new StringBuilder()); } @VisibleForTesting static String addIndexDefinition(TableChange.AddIndex addIndex) { StringBuilder sqlBuilder = new StringBuilder(); sqlBuilder.append("ADD "); switch (addIndex.getType()) { case PRIMARY_KEY: if (null != addIndex.getName() && !StringUtils.equalsIgnoreCase( addIndex.getName(), Indexes.DEFAULT_MYSQL_PRIMARY_KEY_NAME)) { - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - - -