src/redis_protocol/proxy_lib/redis_parser.cpp (8 lines): - line 491: // TODO: set the timeout - line 530: 2000, // TODO: set the timeout - line 590: // TODO: set the timeout - line 636: // TODO: set the timeout - line 693: // TODO: set the timeout - line 729: 2000); // TODO: set the timeout - line 780: // TODO: set the timeout - line 1197: // TODO: set the timeout src/meta/meta_backup_service.cpp (4 lines): - line 119: // TODO: backup_service and policy_context should need two locks, its own _lock and server_state's - line 866: // TODO: just ignore this backup and wait next backup - line 1154: // TODO: make sync_policies_from_remote_storage function to async - line 1627: // TODO: if app is dropped, how to process src/replica/replica_stub.cpp (3 lines): - line 1166: // TODO: use the following to alleviate data lost - line 1543: // TODO: send stored replicas may cost network, we shouldn't config the frequency - line 1732: // TODO: set PS_INACTIVE instead for further state reuse src/rpc/rpc_engine.cpp (3 lines): - line 255: // TODO: time overflow - line 258: // TODO: memory pool for this task - line 648: // TODO: performance optimization src/replica/replica_backup.cpp (3 lines): - line 97: /// TODO: policy may change provider - line 169: // TODO: if secondary's status have changed, how to process the _cold_backup_state, - line 491: // TODO: in primary, this will make the request send to secondary again src/server/hotkey_collector.cpp (3 lines): - line 101: // TODO: (Tangyanzhao) increase a judgment of table_captured_key_sum - line 130: // TODO: (Tangyanzhao) replace it to xxhash - line 238: // TODO: (Tangyanzhao) add a unit test to ensure data integrity src/meta/meta_data.cpp (2 lines): - line 203: // TODO: adjust other proposals according to replica info collected - line 225: // TODO: need to add a metric here. src/meta/server_state_restore.cpp (2 lines): - line 154: // TODO: using one single env to replace - line 219: // TODO: for simply we don't allow progress to rollback; src/meta/meta_data.h (2 lines): - line 190: // TODO: report the storage size of replica - line 220: // TODO: a more clear implementation src/server/hotkey_collector.h (2 lines): - line 99: // TODO: (Tangyanzhao) capture_*_key should be consistent with hotspot detection - line 155: // TODO: (Tangyanzhao) add a unit test of hotkey_coarse_data_collector src/replica/replica_restore.cpp (2 lines): - line 263: // TODO: check the md5sum - line 451: // TODO: we should retry to make the result more precisely src/common/json_helper.h (2 lines): - line 651: // TODO: encoded to null? - line 667: // TODO: encoded to null? src/replica/backup/cold_backup_context.cpp (2 lines): - line 565: // TODO: if call upload_checkpint_to_remote multi times, maybe write_current_chkpt_file - line 691: // TODO: status change from ColdBackupUploading to src/rpc/network.cpp (2 lines): - line 561: _max_buffer_block_count_per_send = 64; // TODO: windows, how about the other platforms? - line 649: // TODO: thread-local client ptr cache src/replica/replica_config.cpp (2 lines): - line 171: // TODO: tell meta server so new primary is built more quickly - line 227: state.timeout_task = nullptr; // TODO: add timer for learner task src/replica/replica_learn.cpp (2 lines): - line 399: // TODO: learner machine has been down for a long time, and DDD MUST happened before - line 1509: // TODO: assign the returned error_code to err and check it src/runtime/tracer.cpp (2 lines): - line 267: // TODO: implement this - line 274: // TODO: implement this python-client/pypegasus/pgclient.py (2 lines): - line 96: seqid = self._seqid = self._seqid + 1 # TODO should keep atomic - line 687: self.name, ec.name, ec.value) # TODO when it happen? src/replica/replica_init.cpp (1 line): - line 79: // TODO: check if _dir contain other file or directory except for src/task/task.h (1 line): - line 201: // TODO: modify delay from chrono to int, keep in consistency with other API src/rpc/asio_net_provider.cpp (1 line): - line 413: // FIXME: we actually do not need to set a random port for client if the rpc_engine is src/utils/binary_writer.h (1 line): - line 131: // TODO: optimization by not memcpy src/utils/shared_io_service.h (1 line): - line 38: // TODO: seperate this into per-node service, so we can use src/replica/replica_stub.h (1 line): - line 270: // TODO: (Tangyanzhao) add some comments src/zookeeper/zookeeper_session.cpp (1 line): - line 314: // TODO: the read ops from zookeeper might get the staled data, need to fix src/task/task.cpp (1 line): - line 284: // TODO: using event pool instead src/task/task_spec.h (1 line): - line 196: join_point on_task_begin; // TODO: parent task src/server/pegasus_server_impl.cpp (1 line): - line 1834: nullptr, // TODO: the tracker is nullptr, we will fix it later src/task/task_tracker.cpp (1 line): - line 51: // TODO: src/runtime/scheduler.h (1 line): - line 102: // TODO: time delay for true, true src/replica/backup/cold_backup_context.h (1 line): - line 349: // TODO: if chechpoint directory has many files, cold_backup_metadata may src/utils/coredump.posix.cpp (1 line): - line 50: // TODO: not implemented src/meta/partition_guardian.cpp (1 line): - line 685: // TODO: treat remove as cure proposals too src/shell/commands/detect_hotkey.cpp (1 line): - line 70: // TODO: (Tangyanzhao) merge hotspot_partition_calculator::send_detect_hotkey_request src/meta/server_state.cpp (1 line): - line 1074: // TODO: add parameter of the retry time interval in config file src/meta/distributed_lock_service_simple.cpp (1 line): - line 50: // TODO: let's test without failure first src/zookeeper/distributed_lock_service_zookeeper.cpp (1 line): - line 268: // TODO: better policy of zookeeper session response scala-client/src/main/scala/org/apache/pegasus/scalaclient/Serializer.scala (1 line): - line 61: Ints.toByteArray(obj) // TODO: remove guava. src/server/capacity_unit_calculator.cpp (1 line): - line 249: // TODO: (Tangyanzhao) hotkey detect in scan python-client/pypegasus/base/ttypes.py (1 line): - line 271: self.address = (self.address << 32) + (int(port) << 16) + 1 # TODO why + 1? src/runtime/service_api_c.cpp (1 line): - line 500: // TODO: register sys_exit execution src/perf_counter/perf_counters.h (1 line): - line 108: /// TODO: totally eliminate this stupid snapshot feature with a better metrics library src/runtime/fault_injector.cpp (1 line): - line 352: // TODO: src/utils/hpc_locks/sema.h (1 line): - line 80: // TODO: timeout src/replica/storage/simple_kv/simple_kv.server.impl.cpp (1 line): - line 280: // TODO: gc checkpoints src/utils/thread_access_checker.h (1 line): - line 44: // TODO: the implementation is not thread safe. use atomic variable to reimplement this src/replica/mutation_log.cpp (1 line): - line 307: // FIXME : the file could have been closed src/meta/meta_state_service_zookeeper.cpp (1 line): - line 379: // TODO: support the switch of zookeeper session src/server/pegasus_server_impl_init.cpp (1 line): - line 852: // TODO: move the qps/latency counters and it's statistics to replication_app_base layer src/gutil/map_util.h (1 line): - line 223: // TODO: Stop using this. src/replica/log_file.cpp (1 line): - line 194: // TODO: We need better abstraction to avoid those manual stuffs..