phoenix-core-client/src/main/java/org/apache/phoenix/schema/MetaDataClient.java (27 lines): - line 606: boolean alwaysHitServer, Long resolvedTimestamp) throws SQLException { // TODO: pass byte[] herez - line 635: // TODO if system tables become transactional remove the check - line 730: // TODO: No table exists at the clientTimestamp, but a newer one exists. - line 868: boolean alwaysHitServer) throws SQLException { // TODO: pass byte[] herez - line 928: // TODO removeFunctions all together from cache when - line 1303: // TODO: If our table is a VIEW with multiple indexes or a TABLE with local indexes, - line 1527: // TODO: this sleep time is really arbitrary. If any query is in progress - line 1553: // TODO: Use scn or LATEST_TIMESTAMP here? It's possible that a DML statement - line 1780: // TODO column names cannot have double quotes, remove this once this PHOENIX-1621 is fixed - line 2051: // for now, only track stream partition metadata for tables, TODO: updatable views - line 2593: // TODO: Can we support a multi-tenant index directly on a multi-tenant - line 2674: // TODO remove TableProperty.IMMUTABLE_ROWS at the next major release - line 2896: // TODO: formalize the known set of these properties - line 2913: // TODO PHOENIX-4766 Add an options to stop sending parent metadata when creating views - line 2935: // TODO From 4.16 write the child links to SYSTEM.CHILD_LINK directly - line 3259: // TODO: remove this constraint? - line 3350: // TODO: what about stats for system catalog? - line 4202: // TODO: Let the standard mutable secondary index maintenance handle this? - line 4234: // TODO: better to return error code - line 4257: // TODO: update cache? - line 4761: // TODO: support setting properties on other families? - line 4986: // TODO: remove this, as the DROP INDEX commands run when the DROP VIEW - line 5127: // TODO: add support to specify tenant owned indexes in the DDL statement with CASCADE executed with Global connection - line 5396: // TODO: pass through schema name and table name instead to these methods as it's cleaner - line 5519: // TODO For immutable tables, if the storage scheme is not ONE_CELL_PER_COLUMN we will remove the column values at compaction time - line 5526: // TODO: move this into PostDDLCompiler - line 5527: // TODO: consider filtering mutable indexes here, but then the issue is that phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionQueryServicesImpl.java (18 lines): - line 509: // TODO: should we track connection wide memory usage or just org-wide usage? - line 593: if (localConnection.isClosed()) { // TODO: why the heck doesn't this throw above? - line 804: //TODO allow passing cause to TableNotFoundException - line 1048: // TODO: assert that timeStamp is bigger that table timeStamp? - line 1358: // TODO: better encapsulation for this - line 2001: admin.modifyTable(newDesc); // TODO: Update to TableDescriptor - line 2004: admin.modifyTable(newDesc); // TODO: Update to TableDescriptor - line 2400: // TODO: if viewIndexId is Short.MIN_VALUE, then we don't need to attempt to create it - line 2739: // TODO: encapsulate better - line 2806: // TODO: change to if (tableMetaData.isEmpty()) once we pass through schemaBytes and tableBytes - line 3149: // FIXME: This isn't getting triggered as currently a property gets evaluated - line 4041: return Lists.newArrayList(admin.listTableNames(Pattern.compile(QueryConstants.SYSTEM_SCHEMA_NAME + "\\..*"))); // TODO: replace to pattern - line 4157: // TODO: Once https://issues.apache.org/jira/browse/PHOENIX-1614 is fixed, - line 4480: * TODO: Provide a path to copy existing data from PHOENIX_TTL to TTL column and then - line 5857: .setRootCause(e).build().buildException(); // FIXME ? - line 6033: .setRootCause(e).build().buildException(); // FIXME ? - line 6085: .setRootCause(e).build().buildException(); // FIXME ? - line 6278: // TODO the mutations should be added to System functions table. phoenix-core-client/src/main/java/org/apache/phoenix/compile/WhereOptimizer.java (16 lines): - line 158: // TODO:: When we only have one where clause, the keySlots returns as a single slot object, - line 164: // FIXME this overwrites salting info in the scanRange - line 255: // TODO: - line 364: // TODO: when stats are available, we may want to use a skip scan if the - line 754: * TODO: We could potentially rewrite simple expressions to move constants to the RHS - line 1645: // TODO: Have separate list for single span versus multi span - line 1650: // TODO: can this ever happen and can we safely filter the expression tree? - line 1657: // TODO: Do the same optimization that we do for IN if the childSlots specify a fully qualified row key - line 1669: * TODO: We could potentially handle these cases through - line 1788: // TODO: consider supporting expression substitution in the PK for pre-joined tables - line 1810: // TODO: can we optimize something that starts with '_' like this: foo LIKE '_a%' ? - line 1811: if (node.getLikeType() == LikeType.CASE_INSENSITIVE || // TODO: remove this when we optimize ILIKE - line 1821: // TODO: optimize ILIKE by creating two ranges for the literal prefix: one with lower case, one with upper case - line 1829: // TODO: is there a case where we'd need to go through the childPart to calculate the key range? - line 2272: // TODO: DelegateExpression - line 2343: FIXME: phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/MetaDataEndpointImpl.java (15 lines): - line 705: // TODO: check that key is within region.getStartKey() and region.getEndKey() - line 1400: //TODO: change this once we start having other values for storage schemes - line 1490: // TODO: Need to Update Cache for Alter Commands, can use PHOENIX-6883. - line 2458: /* TODO: During inital create we may not need the family map */ - line 2702: // TODO: Avoid doing server-server RPC when we have held row locks - line 2728: // Not sure whether this TODO is relevant anymore. PHOENIX-7107 introduces indexes - line 2730: // TODO: Switch this to HRegion#batchMutate when we want to support indexes on the - line 2746: // TODO: consider loading the table that was just created here, patching up the parent table, and updating the cache - line 2814: // TODO why creating generic connection and not getConnectionOnServer? - line 3260: // we want to delete. FIXME: we shouldn't need a scan here, but should be able to - line 3325: // FIXME: Remove when unintentionally deprecated method is fixed (HBASE-7870). - line 3326: // FIXME: the version of the Delete constructor without the lock args was introduced - line 3889: // TODO: check that key is within region.getStartKey() and region.getEndKey() - line 3904: // TODO: If we indicate to the client that we're returning an older version, but there's a - line 4773: // TODO: consider loading the function that was just created here, patching up the parent function, and updating the cache phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixStatement.java (8 lines): - line 383: // TODO: for joins, we need to iterate through all tables, but we need the original table, - line 473: //TODO we can log retry count and error for debugging in LOG table - line 500: // FIXME: Expression.evaluate does not throw SQLException - line 709: // FIXME: Expression.evaluate does not throw SQLException - line 2595: return 0; // TODO: 4000? - line 2631: // TODO: not sure this matters - line 2677: // TODO: any escaping we need to do? - line 2689: // TODO: map to Scan.setBatch() ? phoenix-core-client/src/main/java/org/apache/phoenix/compile/ExpressionCompiler.java (8 lines): - line 303: // TODO: Oracle supports nested aggregate function while other DBs don't. Should we? - line 534: // TODO: for pattern of '%' optimize to strlength(lhs) > 0 - line 601: if (childNode instanceof BindParseNode) { // TODO: valid/possibe? - line 612: // TODO: don't repeat this ugly cast logic (maybe use isCastable in the last else block. - line 737: // TODO: same for TIMESTAMP for DATE/TIME? - line 754: if (childNode instanceof BindParseNode) { // TODO: valid/possibe? - line 908: // TODO: simplify this special case for DATE conversion - line 938: * FIXME: Could be either a Date or BigDecimal, but we phoenix-core-client/src/main/java/org/apache/phoenix/index/IndexMaintainer.java (7 lines): - line 406: // TODO remove this in the next major release - line 490: // TODO: persist nDataSaltBuckets separately, but maintain b/w compat. - line 560: // TODO: check whether index is immutable or not. Currently it's always false so checking - line 1774: //TODO remove this in the next major release - line 1979: //TODO remove indexedColumnTypes in the next major release - line 1990: // TODO: remove when rowKeyOrderOptimizable hack no longer needed - line 1994: // TODO in order to maintain b/w compatibility encode emptyKeyValueCFPtr.getLength() as a negative value (so we can distinguish between new and old clients) phoenix-core-client/src/main/java/org/apache/phoenix/execute/MutationState.java (6 lines): - line 335: // TODO: seems like an autonomous tx capability would be useful here. - line 799: // TODO: use our ServerCache - line 1399: // TODO maybe we can be smarter about the table name to string here? - line 1789: // TODO: For V1, we don't expect mixed upserts and deletes so this is fine, - line 2118: // TODO: in theory we should do a deep equals check here, as it's possible - line 2175: // FIXME: strip table alias to prevent equality check from failing due to alias mismatch on null alias. phoenix-core-client/src/main/java/org/apache/phoenix/util/SchemaUtil.java (5 lines): - line 171: * TODO: keep row count in stats table and use total size / row count instead - line 615: // FIXME: shouldn't this return if splits.length == 0? - line 848: // TODO: for tenant-specific table on tenant-specific connection, - line 855: // TODO: when PColumn has getPKPosition, use that instead - line 1019: // TODO: escape wildcard characters here because we don't want that phoenix-core-client/src/main/java/org/apache/phoenix/util/IndexUtil.java (5 lines): - line 233: // TODO set the columnQualifierBytes correctly - line 442: ByteArrayInputStream stream = new ByteArrayInputStream(columnsBytes); // TODO: size? - line 484: ByteArrayInputStream stream = new ByteArrayInputStream(bytes); // TODO: size? - line 507: ByteArrayInputStream stream = new ByteArrayInputStream(schemaBytes); // TODO: size? - line 587: PhoenixKeyValueUtil.newKeyValue(firstCell.getRowArray(), // FIXME: This does DEEP_COPY of cell, do we need that? phoenix-core-client/src/main/java/org/apache/phoenix/compile/UpsertCompiler.java (5 lines): - line 491: Arrays.fill(columnIndexesToBe, -1); // TODO: necessary? So we'll get an AIOB exception if it's not replaced - line 492: Arrays.fill(pkSlotIndexesToBe, -1); // TODO: necessary? So we'll get an AIOB exception if it's not replaced - line 582: * selection. TODO: change this and only force client side if there's a ORDER BY on the sequence value - line 607: // TODO: it'd be nice if we could figure out in advance if the PK is potentially changing, - line 687: // TODO: break this up into multiple functions phoenix-core-client/src/main/java/org/apache/phoenix/compile/ProjectionCompiler.java (5 lines): - line 232: // TODO: Should we do this more efficiently than catching the exception ? - line 410: // TODO: visitor? - line 444: // TODO: consider having a ScanUtil.addColumn and ScanUtil.addFamily to work - line 612: // TODO make estimatedByteSize more accurate by counting the joined columns. - line 693: // TODO Auto-generated method stub phoenix-core-client/src/main/antlr3/PhoenixSQL.g (4 lines): - line 997: | n=bind_name ((AS)? alias=identifier)? { $ret = factory.bindTable(alias, factory.table(null,n)); } // TODO: review - line 1211: // TODO: figure out how not repeat this two times - line 1217: // TODO: figure out how not repeat this two times - line 1294: | QUESTION { $ret = nextBind(); } // TODO: only support this? phoenix-core-client/src/main/java/org/apache/phoenix/util/PhoenixKeyValueUtil.java (4 lines): - line 227: // TODO Do we really want to return only KeyValues, or would it be enough to - line 262: // TODO Do we really want to return only KeyValues, or would it be enough to - line 282: //FIXME this does not catch all off-heap cells - line 308: // TODO Do we really need to copy everything to the HEAP here ? phoenix-core-client/src/main/java/org/apache/phoenix/expression/ComparisonExpression.java (4 lines): - line 161: // TODO: use lhsExpr.isStateless instead - line 169: // TODO: use lhsExpr.isStateless instead - line 190: // TODO: if lengths are unequal and fixed width? - line 198: } else { // TODO: generalize this with PDataType.getMinValue(), PDataTypeType.getMaxValue() methods phoenix-core-client/src/main/java/org/apache/phoenix/compile/PostDDLCompiler.java (4 lines): - line 65: * TODO: get rid of this ugly code and just go through the standard APIs. - line 193: // FIXME: DDL operations aren't transactional, so we're basing the timestamp on a server timestamp. - line 210: /* TODO: we currently manually run a scan to delete the index data here - line 297: // FIXME: Remove if this is fixed in 0.96 phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixConnection.java (4 lines): - line 837: // TODO This could be optimized out by decoupling closing the stmt and removing it - line 1140: // TODO: run query here or ping - line 1262: // TODO: - line 1372: // TODO Auto-generated method stub phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/covered/NonTxIndexBuilder.java (4 lines): - line 142: // FIXME: PHOENIX-4057 do not attempt to issue index updates - line 205: // FIXME: PHOENIX-4057 do not attempt to issue index updates - line 238: // FIXME: PHOENIX-4057 do not attempt to issue index updates - line 256: // TODO Implement IndexBuilder.getIndexUpdateForFilteredRows phoenix-core-client/src/main/java/org/apache/phoenix/schema/PTableImpl.java (4 lines): - line 200: private final boolean rowKeyOrderOptimizable; // TODO: remove when required that tables have been upgrade for PHOENIX-2067 - line 201: private final boolean hasColumnsRequiringUpgrade; // TODO: remove when required that tables have been upgrade for PHOENIX-2067 - line 784: //TODO should we just pass the global indexref columns separately instead ? - line 2216: // TODO remove this field in 5.0 release phoenix-core-client/src/main/java/org/apache/phoenix/schema/types/PDataType.java (4 lines): - line 334: // TODO: this doesn't jive with HBase's DataType - line 888: //FIXME this is misnamed - line 897: //FIXME this is misnamed - line 1194: //TODO this could be improved by some lookup tables instead of iterating over all types phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/XMLConfigParser.java (4 lines): - line 118: // TODO Remove static calls - line 132: // TODO Remove static calls - line 141: // TODO Remove static calls - line 152: // TODO Remove static calls phoenix-core-server/src/main/java/org/apache/phoenix/mapreduce/index/IndexTool.java (4 lines): - line 551: // TODO probably we can initiate the job by ourself or can skip them while making the list for partial build with a warning - line 556: //serialize index maintaienr in job conf with Base64 TODO: Need to find better way to serialize them in conf. - line 586: //TODO: update disable indexes - line 685: //FIXME Drop this snapshot after we're done ? phoenix-core-client/src/main/java/org/apache/phoenix/compile/DeleteCompiler.java (4 lines): - line 500: // TODO: SchemaUtil.isReadOnly(PTable, connection)? - line 581: // TODO: the select clause should know that there's a sub query, but doesn't seem to currently - line 620: // TODO: better abstraction - line 828: // TODO: share this block of code with UPSERT SELECT phoenix-core-client/src/main/java/org/apache/phoenix/schema/types/PBoolean.java (4 lines): - line 40: // TODO: review - return null? - line 49: // TODO: review - return null? - line 59: // TODO: review - return null? - line 93: // FIXME according to the JDBC spec, we should support all these types: phoenix-core/src/it/java/org/apache/phoenix/end2end/DynamicFamilyIT.java (4 lines): - line 179: // FIXME @Test - line 207: // FIXME @Test - line 257: // FIXME @Test - line 284: // FIXME @Test phoenix-core-client/src/main/java/org/apache/phoenix/iterate/BaseResultIterators.java (4 lines): - line 160: // TODO: too much nesting here - breakup into new classes. - line 246: // FIXME: we only enter this if the number of column families is 1 because otherwise - line 394: // TODO: samarth confirm with James why do we need this hack here :( - line 1014: // TODO: when implementing PHOENIX-4585, we should change this to an assert phoenix-core-client/src/main/java/org/apache/phoenix/compile/ScanRanges.java (4 lines): - line 92: // TODO: consider keeping original to use for serialization as it would be smaller? - line 266: // FIXME Both the salted status and the pre-computed bucket list should be available in - line 327: //TODO split this for normal, salted and local index variants - line 447: // TODO: it seems that our SkipScanFilter or HBase runs into problems if we don't phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionScanner.java (4 lines): - line 501: // TODO: We need to set SOURCE_OPERATION_ATTRIB here also. The control will come here if - line 502: // TODO: we drop a column. We also delete metadata from SYSCAT table for the dropped column - line 503: // TODO: and delete the column. In short, we need to set this attribute for the DM for SYSCAT metadata - line 504: // TODO: and for data table rows. phoenix-core-client/src/main/java/org/apache/phoenix/util/MetaDataUtil.java (3 lines): - line 224: // TODO: generalize this to use two bytes to return a SQL error code instead - line 441: for (Cell kv : kvs) { // list is not ordered, so search. TODO: we could potentially assume the position - line 637: // TODO: confirm that Delete timestamp is reset like Put phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ParallelPhoenixPreparedStatement.java (3 lines): - line 109: //TODO handle disabling connetions in a client to have all or nothing commits - line 691: // TODO: implement using the ParallelPhoenixResultSetFactory - line 752: //TODO Inject ParallelPhoenixConnection phoenix-core-client/src/main/java/org/apache/phoenix/schema/transform/TransformClient.java (3 lines): - line 178: // TODO: Support schema versioning as well. - line 198: // TODO: add more ways of finding out what transform type this is - line 200: // TODO: calculate old and new metadata phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/UngroupedAggregateRegionObserver.java (3 lines): - line 139: // TODO: move all constants into a single class - line 276: // TODO: should we use the one that is all or none? - line 667: // FIXME need to handle views and indexes on views as well phoenix-core/src/it/java/org/apache/phoenix/end2end/UpsertSelectIT.java (3 lines): - line 308: // TODO: more tests - nullable fixed length last PK column - line 1420: //TODO: uncomment the code after PHOENIX-2277 is fixed - line 1530: //TODO: uncomment the code after PHOENIX-2277 is fixed phoenix-core-client/src/main/java/org/apache/phoenix/expression/InListExpression.java (3 lines): - line 256: input.readBoolean(); // Unused, but left for b/w compat. TODO: remove in next major release - line 261: // TODO: consider using a regular HashSet as we never serialize from the server-side - line 284: output.writeBoolean(false); // Unused, but left for b/w compat. TODO: remove in next major release phoenix-core/src/it/java/org/apache/phoenix/end2end/UpsertSelectWithRegionMovesIT.java (3 lines): - line 317: // TODO: more tests - nullable fixed length last PK column - line 1514: //TODO: uncomment the code after PHOENIX-2277 is fixed - line 1643: //TODO: uncomment the code after PHOENIX-2277 is fixed phoenix-core-client/src/main/java/org/apache/phoenix/util/PhoenixRuntime.java (3 lines): - line 112: //TODO use strings, char needs a lot of error-prone conversions - line 269: * TODO: use enum instead - line 1357: // TODO: consider setting MULTI_TENANT = true for SYSTEM.CATALOG and SYSTEM.SEQUENCE phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/MetaDataRegionObserver.java (3 lines): - line 298: // FIXME: we should replay the data table Put, as doing a partial index build would only add - line 541: // TODO Need to set high timeout - line 555: // TODO : use array of index names as Scan attribute for only phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HighAvailabilityGroup.java (3 lines): - line 743: // TODO: Parameterize and set in future work item for pluggable - line 807: // TODO: save timeout in the HA group info (aka cluster role record) instead in properties - line 1033: // TODO: do better than fixed time sleep phoenix-core-client/src/main/java/org/apache/phoenix/schema/Sequence.java (3 lines): - line 341: // TODO: We could have the server return the timestamps of the - line 549: // TODO: We could have the server return the timestamps of the - line 622: // TODO: We could have the server return the timestamps of the phoenix-core-client/src/main/java/org/apache/phoenix/filter/MultiKeyValueComparisonFilter.java (3 lines): - line 120: // TODO: test with older versions to confirm this doesn't get tripped - line 218: // This is a key value we're not interested in (TODO: why INCLUDE here instead of NEXT_COL?) - line 225: // TODO: if we have row key columns in our expression, should phoenix-core-client/src/main/java/org/apache/phoenix/expression/LiteralExpression.java (3 lines): - line 126: // TODO: cache? - line 177: // TODO: cache? - line 258: // TODO: move into PDataType? phoenix-core-client/src/main/java/org/apache/phoenix/filter/SkipScanFilter.java (2 lines): - line 60: * TODO: figure out when to reset/not reset position array - line 307: // TODO: We're including everything between the lowerPosition and end position, which is phoenix-core-client/src/main/java/org/apache/phoenix/filter/MultiEncodedCQKeyValueComparisonFilter.java (2 lines): - line 56: * TODO: derived this from MultiKeyValueComparisonFilter to reduce the copy/paste from that class. - line 254: // TODO: I don't think we would ever hit this case of encountering a greater than what we expect. phoenix-core/src/it/java/org/apache/phoenix/end2end/BaseViewTTLIT.java (2 lines): - line 1864: // TODO handle case when both global and tenant are Local Index cases - line 1872: * TODO: phoenix-core-client/src/main/java/org/apache/phoenix/schema/tool/SchemaExtractionProcessor.java (2 lines): - line 146: //TODO: Indexed on an expression - line 147: //TODO: test with different CF phoenix-core-client/src/main/java/org/apache/phoenix/coprocessorclient/MetaDataProtocol.java (2 lines): - line 59: * TODO: dynamically prune number of schema version kept based on whether or - line 161: // TODO: pare this down to minimum, as we don't need duplicates for both table and column errors, nor should we need phoenix-core/src/it/java/org/apache/phoenix/end2end/index/MutableIndexExtendedIT.java (2 lines): - line 109: // TODO: Move to a different test class? - line 193: rs.getInt(1)); //TODO this returns 5 sometimes instead of 4, duplicate results? phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixResultSet.java (2 lines): - line 668: // TODO: support? - line 911: // FIXME: Expression.evaluate does not throw SQLException phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/FailoverPhoenixConnection.java (2 lines): - line 189: Thread.sleep(100); // TODO: be smart than this - line 211: // TODO: what happens to in-flight edits/mutations? phoenix-core-client/src/main/java/org/apache/phoenix/compile/ExpressionProjector.java (2 lines): - line 83: // FIXME: Expression.evaluate does not throw SQLException - line 106: // FIXME: Expression.evaluate does not throw SQLException phoenix-core-client/src/main/java/org/apache/phoenix/expression/function/AvgAggregateFunction.java (2 lines): - line 42: // TODO: remove when not required at built-in func register time - line 86: // TODO: base the precision on column metadata instead of constant phoenix-core-server/src/main/java/org/apache/phoenix/mapreduce/transform/TransformTool.java (2 lines): - line 712: // TODO : if the rowkey changes via transform, we need to create new split points - line 801: // TODO: disable transform on the old table phoenix-core-server/src/main/java/org/apache/phoenix/schema/transform/Transform.java (2 lines): - line 141: // TODO In the future, we need to handle rowkey changes and column type changes as well - line 253: // TODO: Cleanup syscat so that we don't have an extra index phoenix-core/src/it/java/org/apache/phoenix/schema/tool/SchemaToolExtractionIT.java (2 lines): - line 101: //FIXME never verified - line 103: //FIXME never verified phoenix-core-client/src/main/java/org/apache/phoenix/schema/types/PDate.java (2 lines): - line 111: // FIXME java.time.Local conversions use ISO chronology, unlike the rest of Phoenix. - line 113: // FIXME this does a lot of unnecessary computation. phoenix-core-client/src/main/java/org/apache/phoenix/expression/RowKeyColumnExpression.java (2 lines): - line 119: // FIXME: fixedByteSize <= maxByteSize ? fixedByteSize : 0 required because HBase passes bogus keys to filter to position scan (HBASE-6562) - line 147: // FIXME: fixedByteSize <= maxByteSize ? fixedByteSize : 0 required because HBase passes bogus keys to filter to position scan (HBASE-6562) phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixDatabaseMetaData.java (2 lines): - line 1368: // TODO does this need to change to use the PARENT_TABLE link - line 1821: // TODO: review phoenix-core/src/it/java/org/apache/phoenix/tx/TransactionIT.java (2 lines): - line 356: // TODO: we should support having a transactional table defined for a connectionless connection - line 389: // FIXME: should verify Omid table properties too, but the checks below won't be valid for Omid phoenix-core-server/src/main/java/org/apache/phoenix/mapreduce/OrphanViewTool.java (2 lines): - line 436: // TODO can this be rewritten with try-with-resources ? - line 954: // TODO use try-with-resources at least for the Connection ? phoenix-core-server/src/main/java/org/apache/phoenix/mapreduce/index/IndexScrutinyTool.java (2 lines): - line 93: private static final Option SNAPSHOT_OPTION = //TODO check if this works - line 314: } else { // TODO check if using a snapshot works phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/Indexer.java (2 lines): - line 123: // coprocessor calls. TODO: remove after HBASE-18127 when available - line 692: // TODO check the regions in transition. If the server on which the region lives is this one, phoenix-core/src/it/java/org/apache/phoenix/end2end/ExtendedQueryExecIT.java (2 lines): - line 111: // TODO: Bug #1 - Result should be the same as the the case above - line 116: // TODO: Bug #2 - Exception should be generated for invalid date/time phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableWithViewsIT.java (2 lines): - line 156: // TODO PHOENIX-4766 add/drop column to a base table are no longer propagated to child views - line 962: // TODO since the view is diverged we can't filter out the parent table column metadata phoenix-core-server/src/main/java/org/apache/phoenix/iterate/NonAggregateRegionScannerFactory.java (2 lines): - line 218: // TODO:the above wrapped scanner should be used here also - line 284: ByteArrayInputStream stream = new ByteArrayInputStream(topN); // TODO: size? phoenix-core/src/it/java/org/apache/phoenix/schema/stats/BaseStatsCollectorIT.java (2 lines): - line 474: @Ignore //TODO remove this once https://issues.apache.org/jira/browse/TEPHRA-208 is fixed - line 480: @Ignore //TODO remove this once https://issues.apache.org/jira/browse/TEPHRA-208 is fixed phoenix-core/src/it/java/org/apache/phoenix/end2end/AlterTableIT.java (2 lines): - line 236: assertEquals(5,rs.getInt(2)); // TODO: figure out why this flaps - line 331: //needed in an external schema registry. TODO: fix the base column count anyway phoenix-core/src/it/java/org/apache/phoenix/end2end/index/PartialSystemCatalogIndexIT.java (2 lines): - line 900: // TODO: needs to make this test more robust after fixing the deadlock - line 941: // TODO : fix the deadlock issue when partial index are present phoenix-core-client/src/main/java/org/apache/phoenix/schema/types/PDataTypeFactory.java (2 lines): - line 53: }); // TODO: replace with ServiceLoader or some other plugin system - line 59: }); // TODO: replace with ServiceLoader or some other plugin system phoenix-core/src/it/java/org/apache/phoenix/end2end/DynamicColumnWildcardIT.java (2 lines): - line 54: //FIXME this class has no @Category and is never run by maven - line 63: // TODO: Once PHOENIX-5107 is fixed, add a case for SINGLE_CELL_ARRAY_WITH_OFFSETS phoenix-core/src/it/java/org/apache/phoenix/end2end/index/DropIndexDuringUpsertIT.java (2 lines): - line 64: //FIXME this test is marked abstract, but has no children, so it never run. - line 110: @Ignore // FIXME: this fails 100% of the time on the Mac phoenix-core-client/src/main/java/org/apache/phoenix/parse/SelectStatementRewriter.java (2 lines): - line 34: * TODO: generize this - line 111: // TODO: keep or collapse? Maybe be helpful as context of where a problem occurs if a node could not be consumed phoenix-core-client/src/main/java/org/apache/phoenix/execute/BaseQueryPlan.java (2 lines): - line 278: // TODO fix this in PHOENIX-2415 Support ROW_TIMESTAMP with transactional tables - line 327: // TODO: can have an hint to skip joining back to data table, in that case if any column to phoenix-core-client/src/main/java/org/apache/phoenix/expression/function/ArrayConcatFunction.java (2 lines): - line 73: // FIXME: calling version of coerceBytes that takes into account the separator used by LHS - line 91: // FIXME: concatArrays will be fine if it's copying the separator bytes, including the terminating bytes. phoenix-core-server/src/main/java/org/apache/phoenix/util/ServerIndexUtil.java (2 lines): - line 56: // TODO: Create DelegateCell class instead - line 94: // TODO: PrivateCellUtil's IA is Private. phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/covered/LocalTableState.java (2 lines): - line 182: // FIXME: this is crappy code - we need to simplify the global mutable secondary index implementation - line 183: // TODO: use mutable transactional secondary index implementation instead (PhoenixTransactionalIndexer) phoenix-core-client/src/main/java/org/apache/phoenix/schema/types/PVarchar.java (2 lines): - line 42: // TODO: consider using avro UTF8 object instead of String - line 55: byte[] b = toBytes(object); // TODO: no byte[] allocation: use CharsetEncoder phoenix-core/src/it/java/org/apache/phoenix/jdbc/HighAvailabilityTestingUtility.java (2 lines): - line 82: * TODO: @Bharath check if we can use utility from upstream HBase for a pair of mini clusters. - line 341: //TODO: Replace with a real check for replication complete phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/mt/operations/QueryOperationSupplier.java (2 lines): - line 62: // TODO: - line 80: // TODO handle dynamic statements phoenix-core-client/src/main/java/org/apache/phoenix/compile/FromCompiler.java (2 lines): - line 1138: // TODO Auto-generated method stub - line 1144: // TODO Auto-generated method stub phoenix-core-client/src/main/java/org/apache/phoenix/schema/types/PTime.java (2 lines): - line 100: // FIXME this does a lot of unnecessary computation. - line 111: // FIXME this does a lot of unnecessary computation. phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/WriteWorkload.java (2 lines): - line 89: * TODO extract notion of the scenario list and have 1 write workload per scenario - line 133: // TODO Move pool management up to WorkloadExecutor phoenix-core-client/src/main/java/org/apache/phoenix/execute/AggregatePlan.java (1 line): - line 251: if (groupByExpressions.isEmpty()) { // FIXME ? phoenix-core/src/it/java/org/apache/phoenix/end2end/LoadSystemTableSnapshotBase.java (1 line): - line 71: //TODO:- Snapshot here is storing integers as TTL Value and Phoenix Level TTL is Long, need to work on this. phoenix-core-client/src/main/java/org/apache/phoenix/expression/aggregator/DistinctValueWithCountServerAggregator.java (1 line): - line 122: // TODO Do we need to consider 5 as the number of bytes for each of the int field? Else there is phoenix-core-client/src/main/java/org/apache/phoenix/util/CostUtil.java (1 line): - line 88: // TODO currently return constants for simplicity, should derive from cluster config. phoenix-core-client/src/main/java/org/apache/phoenix/compile/QueryPlan.java (1 line): - line 62: // TODO: change once joins are supported phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/WorkloadExecutor.java (1 line): - line 110: * TODO This should be removed, Access to the pool should be restriced and callers should Workflows phoenix-core/src/it/java/org/apache/phoenix/end2end/TenantSpecificTablesDDLIT.java (1 line): - line 354: //TODO Create some tenant specific table indexes phoenix-core/src/it/java/org/apache/phoenix/tx/ParameterizedTransactionIT.java (1 line): - line 150: // @Test - disabled, doesn't test anything new. TODO: Fix or remove. phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ConnectionInfo.java (1 line): - line 290: // TODO is cloning the configuration a performance problem ? phoenix-core-client/src/main/java/org/apache/phoenix/compile/ColumnProjector.java (1 line): - line 56: // TODO: An expression may contain references to multiple tables. phoenix-core/src/it/java/org/apache/phoenix/end2end/ConnectionQueryServicesTestImpl.java (1 line): - line 91: // Make copy to prevent ConcurrentModificationException (TODO: figure out why this is necessary) phoenix-core-client/src/main/java/org/apache/phoenix/query/QueryServicesOptions.java (1 line): - line 302: // TODO Change this to true as part of PHOENIX-1543 phoenix-core-client/src/main/java/org/apache/phoenix/expression/function/InvertFunction.java (1 line): - line 52: // FIXME: losing rowKeyOrderOptimizable here phoenix-core-client/src/main/java/org/apache/phoenix/util/DateUtil.java (1 line): - line 89: // FIXME why don't we just set these codecs in the Types ? phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/PhoenixAccessController.java (1 line): - line 246: // TODO: confirm whether granting permission from coprocessor is a security leak.(currently it is done if phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryIT.java (1 line): - line 63: public void testToDateOnString() throws Exception { // TODO: test more conversion combinations phoenix-core/src/it/java/org/apache/phoenix/end2end/TTLAsPhoenixTTLIT.java (1 line): - line 647: * TODO :- We are externally calling clearCache for Alter Table scenario, remove this after phoenix-core/src/it/java/org/apache/phoenix/end2end/BinaryStringLiteralIT.java (1 line): - line 136: //FIXME we're using a different string representation here than for the scalar values phoenix-core-client/src/main/java/org/apache/phoenix/parse/ColumnDef.java (1 line): - line 87: // TODO : Add correctness check for arrSize. Should this be ignored as in postgres phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexScrutinyToolBaseIT.java (1 line): - line 92: // TODO test snapshot reads phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalIndexOptimizationIT.java (1 line): - line 435: assertEquals("a", rs.getString(5)); //TODO use name v1 instead of position 5, see PHOENIX-6644 phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixDriver.java (1 line): - line 147: // TODO that's not true, we can have multiple connections with different configs / principals phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/CDCGlobalIndexRegionScanner.java (1 line): - line 86: //TODO: Get Timerange from the start row and end row of the index scan object phoenix-core-client/src/main/java/org/apache/phoenix/schema/types/PTimestamp.java (1 line): - line 181: // FIXME java.time.Local conversions use ISO chronology, unlike the rest of Phoenix. phoenix-core-server/src/main/java/org/apache/phoenix/index/PhoenixIndexFailurePolicy.java (1 line): - line 230: // FIXME: all cell timestamps should be the same phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/CompactionScanner.java (1 line): - line 484: /// TODO : Needs to convert debug to trace logging. phoenix-core/src/it/java/org/apache/phoenix/tx/FlappingTransactionIT.java (1 line): - line 251: // FIXME: must begin txn before getting transactional table phoenix-core-client/src/main/java/org/apache/phoenix/schema/PMetaDataImpl.java (1 line): - line 112: // TODO The tables with zero update cache frequency should not be inserted to the cache. However, Phoenix phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/mt/operations/UserDefinedOperationSupplier.java (1 line): - line 44: // TODO : implement user defined operation invocation. phoenix-core-client/src/main/java/org/apache/phoenix/index/PhoenixIndexBuilderHelper.java (1 line): - line 126: // TODO: optimization size of RPC more. phoenix-core-client/src/main/java/org/apache/phoenix/expression/ColumnExpression.java (1 line): - line 46: // TODO: review, as the hashCode() and equals() here seem unnecessary phoenix-core/src/it/java/org/apache/phoenix/query/MetaDataCachingIT.java (1 line): - line 143: TODO: The tables with zero update cache frequency should not be inserted to the cache. However, Phoenix phoenix-core-client/src/main/java/org/apache/phoenix/memory/GlobalMemoryManager.java (1 line): - line 62: // TODO: Work on fairness: One big memory request can cause all others to fail here. phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexTestUtil.java (1 line): - line 107: // TODO: push to RowKeySchema? phoenix-core-client/src/main/java/org/apache/phoenix/util/json/JsonUpsertExecutor.java (1 line): - line 159: // TODO: move to DateUtil phoenix-core-client/src/main/java/org/apache/phoenix/schema/types/PDecimal.java (1 line): - line 100: // TODO: should we strip zeros and round here too? phoenix-core-client/src/main/java/org/apache/phoenix/execute/ScanPlan.java (1 line): - line 137: ByteArrayOutputStream stream = new ByteArrayOutputStream(); // TODO: size? phoenix-core/src/it/java/org/apache/phoenix/end2end/DeleteIT.java (1 line): - line 203: // TODO: surface QueryPlan from MutationPlan phoenix-pherf/src/main/java/org/apache/phoenix/pherf/configuration/LoadProfile.java (1 line): - line 47: * TODO : phoenix-core-client/src/main/java/org/apache/phoenix/expression/function/CollationKeyFunction.java (1 line): - line 193: // TODO: Look into calling freeze() on them to be able return true here. phoenix-core-server/src/main/java/org/apache/phoenix/iterate/RegionScannerFactory.java (1 line): - line 400: * TODO try to fix this case in LocalIndexStoreFileScanner when there is a merge. phoenix-core/src/it/java/org/apache/phoenix/monitoring/PhoenixMetricsIT.java (1 line): - line 961: // TODO use a spy ? phoenix-core/src/it/java/org/apache/phoenix/end2end/SyncUpdateCacheFreqIT.java (1 line): - line 48: //FIXME this class no @Category, and will not be run by maven phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixPreparedStatement.java (1 line): - line 88: this.query = null; // TODO: add toString on SQLStatement phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/mt/operations/PreScenarioOperationSupplier.java (1 line): - line 63: // TODO: phoenix-core-client/src/main/java/org/apache/phoenix/schema/PColumnFamilyImpl.java (1 line): - line 101: //TODO: samarth think about backward compatibility here phoenix-core-client/src/main/java/org/apache/phoenix/execute/PhoenixTxIndexMutationGenerator.java (1 line): - line 464: // TODO: creating these objects over and over again is wasteful phoenix-core-client/src/main/java/org/apache/phoenix/schema/stats/StatisticsUtil.java (1 line): - line 65: // TODO: make this declarative through new DISABLE_STATS column on SYSTEM.CATALOG table. phoenix-pherf/src/main/java/org/apache/phoenix/pherf/jmx/MonitorManager.java (1 line): - line 52: // TODO Move this out to config. Possible use Guice and use IOC to inject it in. phoenix-core/src/it/java/org/apache/phoenix/end2end/CDCBaseIT.java (1 line): - line 496: // FIXME: Add the following with consecutive upserts on the sake PK (no delete in between): phoenix-core/src/it/java/org/apache/phoenix/end2end/SystemTablesUpgradeIT.java (1 line): - line 52: //FIXME this class has no @Category, and will not be run by Maven phoenix-core/src/it/java/org/apache/phoenix/end2end/CaseStatementIT.java (1 line): - line 163: // TODO: we need some tests that have multiple versions of key values phoenix-core-client/src/main/java/org/apache/phoenix/optimize/Cost.java (1 line): - line 92: // TODO right now for simplicity, we choose to ignore CPU and memory costs. We may phoenix-core/src/it/java/org/apache/phoenix/end2end/PhoenixTTLToolIT.java (1 line): - line 76: * TODO:- To enable this test after re-enabling TTL for view for more info check :- PHOENIX-6978 phoenix-core-client/src/main/java/org/apache/phoenix/expression/LikeExpression.java (1 line): - line 276: if (pattern == null) { // TODO: don't allow? this is going to be slooowwww phoenix-core-client/src/main/java/org/apache/phoenix/expression/RowValueConstructorExpression.java (1 line): - line 182: // TODO: handle overflow and underflow phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/TaskRegionObserver.java (1 line): - line 165: // TODO: Not sufficient info available when namespaces are enabled and index rebuild task are run phoenix-core-client/src/main/protobuf/PTable.proto (1 line): - line 81: // TODO remove this field in 5.0 release phoenix-pherf/src/main/java/org/apache/phoenix/pherf/PherfConstants.java (1 line): - line 67: // TODO MOve to properties phoenix-core-client/src/main/java/org/apache/phoenix/iterate/ScanningResultIterator.java (1 line): - line 229: // TODO: use ResultTuple.setResult(result)? phoenix-core/src/it/java/org/apache/phoenix/end2end/index/GlobalMutableNonTxIndexWithLazyPostBatchWriteIT.java (1 line): - line 29: //FIXME shouldn't this be @NeedsOwnMiniClusterTest ? phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ParallelPhoenixStatement.java (1 line): - line 459: return null; //TODO: Push parallel context to this layer phoenix-core-client/src/main/java/org/apache/phoenix/expression/function/SumAggregateFunction.java (1 line): - line 60: // TODO: remove when not required at built-in func register time phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixHAAdminTool.java (1 line): - line 144: // TODO: use jackson or standard JSON library according to PHOENIX-5789 phoenix-core/src/it/java/org/apache/phoenix/end2end/SpooledTmpFileDeleteIT.java (1 line): - line 50: // TODO: review with Samarth - should a Noop iterator be used if pacing is not possible? phoenix-core/src/it/java/org/apache/phoenix/end2end/transform/TransformMonitorIT.java (1 line): - line 388: // TODO: Fix this as part of implementing TransformTool so that the tenant view rows could be read from the tool phoenix-core/src/it/java/org/apache/phoenix/end2end/QueryDatabaseMetaDataIT.java (1 line): - line 733: assertEquals(SchemaUtil.normalizeIdentifier("pk"), rs.getString("PK_NAME")); // TODO: phoenix-core-client/src/main/java/org/apache/phoenix/execute/UnionPlan.java (1 line): - line 310: // TODO is this correct? phoenix-core-client/src/main/java/org/apache/phoenix/compile/IndexStatementRewriter.java (1 line): - line 123: // TODO: test case for this phoenix-core/src/it/java/org/apache/phoenix/end2end/index/IndexUsageIT.java (1 line): - line 467: //TODO figure out why this " " is needed phoenix-core/src/it/java/org/apache/phoenix/end2end/StatsEnabledSplitSystemCatalogIT.java (1 line): - line 100: * TODO: we should throw in that case phoenix-core-client/src/main/java/org/apache/phoenix/schema/PColumnImpl.java (1 line): - line 111: // TODO: we may be able to allow this for columns at the end of the PK phoenix-core-client/src/main/java/org/apache/phoenix/schema/metrics/MetricsMetadataSource.java (1 line): - line 109: // TODO: metrics for addIndexToTable and dropIndexes phoenix-core-client/src/main/java/org/apache/phoenix/execute/SortMergeJoinPlan.java (1 line): - line 986: // TODO: We should make a explicit distinction between OrderByExpression for phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/mt/handlers/RendezvousingWorkHandler.java (1 line): - line 78: // TODO need to handle asynchronous result publishing phoenix-core/src/it/java/org/apache/phoenix/end2end/NativeHBaseTypesIT.java (1 line): - line 104: // FIXME: the version of the Delete constructor without the lock args was introduced phoenix-core-client/src/main/java/org/apache/phoenix/parse/ParseNodeFactory.java (1 line): - line 76: // TODO: Use Google's Reflection library instead to find aggregate functions phoenix-core-client/src/main/java/org/apache/phoenix/expression/function/DistinctCountAggregateFunction.java (1 line): - line 109: // TODO: optimize query plan of this to run scan serially for a limit of one row phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexExtendedIT.java (1 line): - line 220: if (localIndex) { // TODO: remove this return once PHOENIX-3292 is fixed phoenix-core-client/src/main/java/org/apache/phoenix/coprocessorclient/BaseScannerRegionObserverConstants.java (1 line): - line 102: * Needed for backward compatibility purposes. TODO: get rid of this in next major release. phoenix-core-client/src/main/java/org/apache/phoenix/optimize/QueryOptimizer.java (1 line): - line 166: // TODO: It seems inefficient to be recompiling the statement again inside of this optimize call phoenix-core-client/src/main/java/org/apache/phoenix/expression/RowKeyExpression.java (1 line): - line 46: // TODO Auto-generated method stub phoenix-core-client/src/main/java/org/apache/phoenix/util/i18n/LinguisticSort.java (1 line): - line 887: // TODO: Make this an environment variable. phoenix-core-client/src/main/java/org/apache/phoenix/log/ConnectionActivityLogger.java (1 line): - line 55: // TODO: CQS_NAME (Connection Profile Name) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/util/ResourceList.java (1 line): - line 85: // TODO Make getResourcesPaths() return the URLs directly instead of converting them phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/HighAvailabilityPolicy.java (1 line): - line 185: // TODO: Once we have operation/primary wait timeout use the same phoenix-core-client/src/main/java/org/apache/phoenix/expression/function/CoalesceFunction.java (1 line): - line 43: * TODO: better bind parameter type matching, since arg2 must be coercible phoenix-core-client/src/main/java/org/apache/phoenix/expression/function/BsonValueFunction.java (1 line): - line 156: // TODO : uncomment after PHOENIX-7357 phoenix-core-client/src/main/java/org/apache/phoenix/schema/types/PChar.java (1 line): - line 119: // TODO: UTF-8 decoder that will invert as it decodes phoenix-core-client/src/main/java/org/apache/phoenix/expression/visitor/CloneExpressionVisitor.java (1 line): - line 62: // have accept methods. TODO: get rid of those phoenix-core-client/src/main/java/org/apache/phoenix/schema/KeyValueSchema.java (1 line): - line 135: // TODO: if there aren't any non null values, don't serialize anything phoenix-core/src/it/java/org/apache/phoenix/end2end/NonParameterizedIndexScrutinyToolIT.java (1 line): - line 43: //FIXME this test is never run by maven, as it has no @Category phoenix-core-client/src/main/java/org/apache/phoenix/util/JDBCUtil.java (1 line): - line 228: //TODO: check if anything else is needed for RPCRegistry connections and do we need to store them in CRR phoenix-core-client/src/main/java/org/apache/phoenix/monitoring/ReadMetricQueue.java (1 line): - line 38: private static final int MAX_QUEUE_SIZE = 20000; // TODO: should this be configurable? phoenix-core-client/src/main/java/org/apache/phoenix/schema/RowKeyValueAccessor.java (1 line): - line 442: // FIXME: keyOffset < keyBuffer.length required because HBase passes bogus keys to filter to position scan (HBASE-6562) phoenix-core-client/src/main/java/org/apache/phoenix/expression/SingleCellColumnExpression.java (1 line): - line 195: //FIXME: this is ugly but can't think of a good solution. phoenix-core-client/src/main/java/org/apache/phoenix/expression/CaseExpression.java (1 line): - line 200: * expression will use it too. TODO: We could alternatively have a non interface phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/mt/operations/UpsertOperationSupplier.java (1 line): - line 70: // TODO: phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ParallelPhoenixContext.java (1 line): - line 123: //FIXME should return immutable phoenix-core-client/src/main/java/org/apache/phoenix/compile/GroupByCompiler.java (1 line): - line 413: // TODO: PHOENIX-2989 suggests some ways to optimize the latter case phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/mt/handlers/TenantOperationWorkHandler.java (1 line): - line 66: // TODO need to handle asynchronous result publishing phoenix-core-client/src/main/java/org/apache/phoenix/util/i18n/LocaleUtils.java (1 line): - line 42: // TODO: The number of locales in the system is rather small, phoenix-core-client/src/main/java/org/apache/phoenix/schema/types/PUnsignedDate.java (1 line): - line 133: // TODO: derive PUnsignedDate from PDate to avoid copy/paste phoenix-core-client/src/main/java/org/apache/phoenix/util/QueryUtil.java (1 line): - line 580: // TODO: we should union this with SYSTEM.SEQUENCE too, but we only have support for phoenix-core-client/src/main/java/org/apache/phoenix/util/NumberUtil.java (1 line): - line 52: decimal = decimal.setScale(scale, BigDecimal.ROUND_DOWN); // FIXME: should this be ROUND_UP? phoenix-core-client/src/main/java/org/apache/phoenix/schema/types/PBinaryBase.java (1 line): - line 125: // TODO we could duplicate getString() for String type phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/PhoenixHAAdmin.java (1 line): - line 210: * // TODO: add retry logics phoenix-core-server/src/main/java/org/apache/phoenix/iterate/RegionScannerResultIterator.java (1 line): - line 71: // TODO: size phoenix-core-client/src/main/java/org/apache/phoenix/jdbc/ParallelPhoenixNullComparingResultSet.java (1 line): - line 153: // TODO: track which rs came back first and is potentially faster. Bind accordingly phoenix-core-server/src/main/java/org/apache/phoenix/mapreduce/index/automation/PhoenixMRJobSubmitter.java (1 line): - line 112: // TODO - Move this to a property? phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/HashJoinRegionScanner.java (1 line): - line 165: // TODO: fix below Scanner.next() and Scanner.nextRaw() methods as well. phoenix-core-client/src/main/java/org/apache/phoenix/parse/BindTableNode.java (1 line): - line 29: * TODO: modify grammar to support this phoenix-core/src/it/java/org/apache/phoenix/end2end/PartialScannerResultsDisabledIT.java (1 line): - line 102: // TODO: it's likely that less data could be written if whatever phoenix-core/src/it/java/org/apache/phoenix/end2end/DefaultPhoenixMultiViewListProviderIT.java (1 line): - line 40: * TODO:- To enable this test after re-enabling TTL for view for more info check :- PHOENIX-6978 phoenix-core/src/it/java/org/apache/phoenix/end2end/Array1IT.java (1 line): - line 1034: // FIXME we should be throwing an SQLException phoenix-core-client/src/main/java/org/apache/phoenix/util/csv/CsvUpsertExecutor.java (1 line): - line 141: // TODO: move to DateUtil phoenix-core/src/it/java/org/apache/phoenix/end2end/index/ImmutableIndexIT.java (1 line): - line 441: if (localIndex) { // TODO: remove after PHOENIX-3314 is fixed phoenix-core-server/src/main/java/org/apache/hadoop/hbase/regionserver/wal/IndexedHLogReader.java (1 line): - line 35: * TODO: Support splitting index updates into their own WAL entries on recovery (basically, just phoenix-core-client/src/main/java/org/apache/phoenix/expression/function/SingleAggregateFunction.java (1 line): - line 70: // Ensures COUNT(1) sorts first TODO: unit test for this phoenix-tracing-webapp/src/main/java/org/apache/phoenix/tracingwebapp/http/ConnectionFactory.java (1 line): - line 32: //TODO : need to get port and host from configuration phoenix-core-client/src/main/java/org/apache/phoenix/compile/LimitCompiler.java (1 line): - line 92: if (limit.intValue() >= 0) { // TODO: handle LIMIT 0 phoenix-core-server/src/main/java/org/apache/phoenix/coprocessor/AddColumnMutator.java (1 line): - line 394: // TODO: this likely means we don't need the above logic that phoenix-core-client/src/main/java/org/apache/phoenix/log/TableLogWriter.java (1 line): - line 151: // TODO Ignore? phoenix-core-client/src/main/java/org/apache/phoenix/schema/types/PDouble.java (1 line): - line 254: // TODO: would it be possible to use the toLongUnsafe? phoenix-core-server/src/main/java/org/apache/phoenix/util/PhoenixMRJobUtil.java (1 line): - line 70: // TODO - Move these as properties? phoenix-core-client/src/main/java/org/apache/phoenix/expression/ExpressionType.java (1 line): - line 232: if (type == null) { // FIXME: this exception gets swallowed and retries happen phoenix-pherf/src/main/java/org/apache/phoenix/pherf/result/impl/DefaultResultHandler.java (1 line): - line 41: * TODO Change this so NPE is not possible. Needs a bit of refactoring here phoenix-core-client/src/main/java/org/apache/phoenix/hbase/index/covered/update/IndexUpdateManager.java (1 line): - line 92: // TODO: make this a real comparison phoenix-core-client/src/main/java/org/apache/phoenix/compile/JoinCompiler.java (1 line): - line 679: // TODO PHOENIX-4618: phoenix-core-server/src/main/java/org/apache/phoenix/iterate/SnapshotScanner.java (1 line): - line 87: // TODO : Use hbase provided snapshot scanner (make it IA.LimitedPrivate) phoenix-pherf/src/main/java/org/apache/phoenix/pherf/workload/mt/generators/BaseLoadEventGenerator.java (1 line): - line 190: // TODO need to handle asynchronous result publishing phoenix-core-client/src/main/java/org/apache/phoenix/util/CursorUtil.java (1 line): - line 75: //TODO: Determine if the cursor should be removed from the HashMap at this point. phoenix-tracing-webapp/src/main/webapp/js/controllers/timeline-controllers.js (1 line): - line 99: //TODO draw chart in start of the page. phoenix-core-client/src/main/java/org/apache/phoenix/query/ConnectionlessQueryServicesImpl.java (1 line): - line 408: // TODO: share this with ConnectionQueryServicesImpl phoenix-core-client/src/main/java/org/apache/phoenix/expression/KeyValueColumnExpression.java (1 line): - line 94: // TODO: assumes single table phoenix-core-client/src/main/java/org/apache/phoenix/hbase/index/util/IndexManagementUtil.java (1 line): - line 246: // TODO do we really need this to be on-heap ? phoenix-core-client/src/main/java/org/apache/phoenix/expression/aggregator/UnsignedLongSumAggregator.java (1 line): - line 27: * TODO: create these classes dynamically based on the type passed through phoenix-core/src/it/java/org/apache/phoenix/end2end/IndexBuildTimestampIT.java (1 line): - line 121: //FIXME PHOENIX-5375 TS is set to index creation time phoenix-core-client/src/main/java/org/apache/phoenix/parse/DeclareCursorStatement.java (1 line): - line 41: //TODO: Test if this works phoenix-core-client/src/main/java/org/apache/phoenix/compile/CreateTableCompiler.java (1 line): - line 112: // TODO: support any statement for a VIEW instead of just a WHERE clause phoenix-core-server/src/main/java/org/apache/phoenix/index/PhoenixTransactionalIndexer.java (1 line): - line 67: // coprocessor calls. TODO: remove after HBASE-18127 when available phoenix-core-server/src/main/java/org/apache/phoenix/mapreduce/CsvToKeyValueMapper.java (1 line): - line 105: // TODO Creating a new parser for each line seems terribly inefficient but phoenix-pherf/src/main/java/org/apache/phoenix/pherf/rules/RulesApplier.java (1 line): - line 153: // TODO Make a Set of Rules that have already been applied so that so we don't generate for every value phoenix-core-client/src/main/java/org/apache/phoenix/util/ViewUtil.java (1 line): - line 801: // TODO figure out a way to actually drop this view index phoenix-core-client/src/main/java/org/apache/phoenix/iterate/CursorResultIterator.java (1 line): - line 31: //TODO Configure fetch size from FETCH call phoenix-core-server/src/main/java/org/apache/phoenix/mapreduce/PhoenixOutputFormat.java (1 line): - line 46: // FIXME Never used, and the ignore feature didn't work anyway phoenix-core-client/src/main/java/org/apache/phoenix/job/JobManager.java (1 line): - line 143: // FIXME: this fails when executor used by hbase phoenix-core-client/src/main/java/org/apache/phoenix/execute/HashJoinPlan.java (1 line): - line 303: // TODO : Support ExplainPlanAttributes for HashJoinPlan phoenix-core-client/src/main/java/org/apache/phoenix/parse/LiteralParseNode.java (1 line): - line 115: // TODO: move into PDataType? phoenix-core/src/it/java/org/apache/hadoop/hbase/regionserver/wal/WALReplayWithIndexWritesAndCompressedWALIT.java (1 line): - line 205: HRegion region0 = HRegion.createHRegion(hri, hbaseRootDir, this.conf, htd, wal); // FIXME: Uses private type phoenix-core-client/src/main/java/org/apache/phoenix/parse/CreateTableStatement.java (1 line): - line 43: // TODO change this to boolean at the next major release and remove TableProperty.IMMUTABLE_ROWS and QueryServiceOptions.IMMUTABLE_ROWS_ATTRIB phoenix-core/src/it/java/org/apache/phoenix/end2end/GlobalConnectionTenantTableIT.java (1 line): - line 44: //FIXME this class has no @Category, and is never run by maven phoenix-core-server/src/main/java/org/apache/phoenix/hbase/index/IndexRegionObserver.java (1 line): - line 237: // coprocessor calls. TODO: remove after HBASE-18127 when available phoenix-core/src/it/java/org/apache/phoenix/jdbc/HighAvailabilityGroupTestIT.java (1 line): - line 76: // TODO: This is not an IT but can't run in parallel with other UTs, refactor phoenix-core-client/src/main/java/org/apache/phoenix/expression/function/ScalarFunction.java (1 line): - line 42: // FIXME: we could potentially implement this on each subclass and not use reflection