solr/core/src/java/org/apache/solr/handler/component/RealTimeGetComponent.java (17 lines):
- line 144: // TODO remove this at Solr 10
- line 247: // if _route_ is passed, id is a child doc. TODO remove in SOLR-15064
- line 446: *
TODO Sometimes there's copy-field target removal; it ought to be consistent.
- line 480: // TODO could make this smarter but it's complicated with nested docs
- line 512: toSolrDoc(partialDoc, schema, forInPlaceUpdate); // filters copy-field targets TODO don't
- line 632: // TODO ideally we wouldn't have fetched these in the first place!
- line 868: // TODO optimization: add feature to SolrReturnFields to exclude copyFieldTargets from wildcard
- line 952: // TODO Lucene Field has no copy constructor; maybe it should?
- line 989: // TODO: do something more performant than this double conversion
- line 1049: // TODO: handle collection=...?
- line 1082: // sreq.shards = new String[]{shard}; // TODO: would be nice if this would work...
- line 1109: // TODO: how to avoid hardcoding this and hit the same handler?
- line 1298: // TODO: more complex response?
- line 1344: // TODO: get this from cache instead of rebuilding?
- line 1357: // TODO: do any kind of validation here?
- line 1382: // TODO merge ranges.
- line 1408: // TODO do we need to sort versions using PeerSync.absComparator?
solr/core/src/java/org/apache/solr/handler/component/QueryComponent.java (16 lines):
- line 274: // TODO: move weighting of sort
- line 278: // TODO: move weighting of sort
- line 466: // TODO: See SOLR-5595
- line 522: // :TODO: would be simpler to always serialize every position of SortField[]
- line 813: // TODO: base on current params or original params?
- line 826: // TODO: should we even use the SortSpec? That's obtained from the QParser, and
- line 882: // TODO: should this really sendGlobalDfs if just includeScore?
- line 1133: // TODO: remove previous from priority queue
- line 1189: // TODO: use ResponseBuilder (w/ comments) or the request context?
- line 1302: // :TODO: would be simpler to always serialize every position of SortField[]
- line 1330: // TODO: in a system with nTiers > 2, we could be passed "ids" here
- line 1371: // TODO: depending on the type, we may need more tha a simple toString()?
- line 1382: // TODO: if a multi-tiered system, it seems like some requests
- line 1384: // TODO: merge fsv to if requested
- line 1544: // TODO: create a cache for this!
- line 1836: *
TODO: when SOLR-5595 is fixed, this wont be needed, as we dont need to recompute sort values
solr/core/src/java/org/apache/solr/search/facet/FacetFieldProcessor.java (13 lines):
- line 64: // TODO: push any of this down to base class?
- line 205: // TODO: BEGIN: why can't we just call createAccs here ?
- line 215: // TODO: END: why can't we just call createAccs here ?
- line 234: collectAcc.key = sort.sortVariable; // TODO: improve this
- line 240: boolean needOtherAccs = freq.allBuckets; // TODO: use for missing too...
- line 531: // TODO: it would be more efficient to build up a missing DocSet if we need it here anyway.
- line 547: // TODO - Should we enforce minPrefixLength here in the case of 'string' fields, or omit
- line 573: // TODO: we could potentially store the bucket's (DocSet)subDomain as well,
- line 600: // TODO: save something generic like "slotNum" in the context and use that to implement things
- line 613: acc.reset(); // TODO: only needed if we previously used for allBuckets or missing
- line 693: // TODO: what if resortAcc is still null, ie: bad input? ... throw an error? (see SOLR-13022)
- line 1021: // TODO: but in case something does need to be done here, should we require this method to be
- line 1071: // TODO: an alternate implementations can fill all accs at once
solr/core/src/java/org/apache/solr/update/processor/DistributedUpdateProcessor.java (13 lines):
- line 70: // TODO: we really should not wait for distrib after local? unless a certain replication factor is
- line 186: // TODO: better way to get the response, or pass back info to it?
- line 235: // TODO: if minRf > 1 and we know the leader is the only active replica, we could fail
- line 245: // TODO: do we need to add anything to the response?
- line 251: // TODO: what to do when no idField?
- line 262: // TODO: keep track of errors? needs to be done at a higher level though since
- line 312: // TODO: don't reuse update commands any more!
- line 357: // TODO: if versions aren't stored, do we need to set on the cmd anyway for some
- line 520: // TODO: possibly set checkDeleteByQueries as a flag on the command?
- line 725: // TODO: may want to switch to using optimistic locking in the future for better concurrency
- line 819: // TODO: do we need to add anything to the response?
- line 826: // TODO: what to do when no idField?
- line 977: // TODO update versions in all buckets
solr/core/src/java/org/apache/solr/search/SolrIndexSearcher.java (11 lines):
- line 209: // TODO: wrap elsewhere and return a "map" from the schema that overrides get() ?
- line 403: // TODO: This may not be safe w/softCommit, see SOLR-13908
- line 737: // TODO: make more configurable later...
- line 958: // TODO: this should be implemented in DocSet, most likely with a getBits method that takes a
- line 983: // TODO duplicated code with getDocSet?
- line 1128: // TODO rename to getLiveDocs in 8.0
- line 1592: // TODO don't take QueryResult as arg; create one here
- line 1814: // TODO: would be nice to rename & generalize this method for non-cursor cases...
- line 2098: // TODO: Think about using ScoreMode from searchResult down below
- line 2109: // TODO: if we collect results before the filter, we just need to intersect with
- line 2113: // TODO: currently we don't generate the DocSet for the base query,
solr/core/src/java/org/apache/solr/request/SimpleFacets.java (11 lines):
- line 195: if (!Objects.equals(type, FacetParams.FACET_QUERY)) { // TODO Cut over to an Enum here
- line 310: // TODO: slight optimization would prevent double-parsing of any localParams
- line 311: // TODO: SOLR-7753
- line 627: // TODO do we handle debug? Should probably already be handled by the legacy code
- line 737: // TODO: default to per-segment or not?
- line 821: // :TODO:can we filter earlier than this to make it more efficient?
- line 1069: /* :TODO: potential optimization...
- line 1116: // TODO: OPT: if seek(ord) is supported for this termsEnum, then we could use it for
- line 1169: // TODO: specialize when base docset is a bitset or hash set (skipDocs)? or does it
- line 1171: // TODO: do this per-segment for better efficiency (MultiDocsEnum just uses base class
- line 1173: // TODO: would passing deleted docs lead to better efficiency over checking the
solr/core/src/java/org/apache/solr/search/SolrCache.java (10 lines):
- line 75: *
:TODO: verify this.
- line 82: /** :TODO: copy from Map */
- line 85: /** :TODO: copy from Map */
- line 88: /** :TODO: copy from Map */
- line 107: /** :TODO: copy from Map */
- line 111: * Enumeration of possible States for cache instances. :TODO: only state that seems to ever be set
- line 115: /** :TODO */
- line 117: /** :TODO */
- line 119: /** :TODO */
- line 121: /** :TODO */
solr/core/src/java/org/apache/solr/cloud/ZkController.java (10 lines):
- line 140: *
TODO: exceptions during close on attempts to update cloud state
- line 288: * @param cloudConfig configuration for this controller. TODO: possibly redundant with
- line 476: // TODO: we need to think carefully about what happens when it was a leader
- line 1357: // TODO: should this be moved to another thread? To recoveryStrat?
- line 1358: // TODO: should this actually be done earlier, before (or as part of)
- line 1386: // TODO: public as recovering in the mean time?
- line 1387: // TODO: in the future we could do peersync in parallel with recoverFromLog
- line 2324: // TODO: we should consider using version
- line 2340: // TODO: we should consider using version
- line 2878: // TODO: can we remove `synchronized`, now that SOLR-11535 is fixed?
solr/core/src/java/org/apache/solr/search/facet/FacetParser.java (9 lines):
- line 63: // TODO: put the FacetRequest on the parser object?
- line 83: // TODO: have parseFacetOrStat directly add instead of return?
- line 142: // TODO: a place to register all these facet types?
- line 164: // TODO - simple string representation of facets
- line 287: Object fieldName = args.get("field"); // TODO: pull out into defined constant
- line 355: // TODO: should we be more flexible and accept things like "true" (strings)?
- line 460: // TODO Make this private (or at least not static) and introduce
- line 523: // TODO: substats that are from defaults!!!
- line 566: // TODO: pull up to higher level?
solr/core/src/java/org/apache/solr/search/facet/FacetHeatmap.java (9 lines):
- line 101: // TODO for more format ideas, see formatCountsVal()
- line 233: // TODO perhaps all FacetRequest objs should have this?
- line 290: // TODO this is a general utility that should go elsewhere? DocSetUtil? Then should
- line 327: // TODO case UTFGRID https://github.com/mapbox/utfgrid-spec
- line 328: // TODO case skipList: //A sequence of values; negative values are actually how many 0's to
- line 330: // TODO auto choose png or skipList; use skipList when < ~25% full or <= ~512 cells remember
- line 371: null)); // TODO where debugInfo?
- line 486: // TODO re-use this instance; superclass has 8KB buffer.
- line 529: // TODO can/should we re-use an imageReader instance on FacetInfo?
solr/core/src/java/org/apache/solr/search/facet/UnInvertedField.java (9 lines):
- line 155: // TODO: check for MultiTermsEnum in SolrIndexSearcher could now fail?
- line 202: // TODO: it's wasteful to create one of these each time
- line 346: // TODO: when iterator across negative elements is available, use that
- line 356: // TODO: counts could be deferred if sorting by index order
- line 370: // TODO: we could short-circuit counting altogether for sorted faceting
- line 424: /* TODO - future optimization to handle allBuckets
- line 447: // TODO: do a callback version that can be specialized!
- line 493: // TODO: handle facet.prefix here!!!
- line 648: // TODO: SolrCache is not used safely in other places, but this might be simpligfied to:
solr/ui/src/commonMain/kotlin/org/apache/solr/ui/components/main/integration/DefaultMainComponent.kt (9 lines):
- line 101: // TODO Uncomment once Dashboard available
- line 105: // TODO Uncomment once Metrics available
- line 109: // TODO Uncomment once Cluster available
- line 113: // TODO Uncomment once Security available
- line 117: // TODO Uncomment once Configsets available
- line 121: // TODO Uncomment once Collections available
- line 125: // TODO Uncomment once QueriesAndOperations available
- line 133: // TODO Uncomment once ThreadDump available
- line 137: // TODO Remove else case once all destinations are available
solr/core/src/java/org/apache/solr/handler/IndexFetcher.java (9 lines):
- line 459: // TODO: Do we need to set forceReplication = true?
- line 491: // TODO: make sure that getLatestCommit only returns commit points for the main index (i.e. no
- line 550: // TODO: Should we be comparing timestamps (across machines) here?
- line 1173: // efficient as compared to a file copy. TODO: Maybe we could do a move safely here?
- line 1467: /** Make file list TODO: return the stream directly */
- line 1621: // TODO: currently does not reflect conf files
- line 1760: // TODO consider recoding the remaining logic to not use/need buf[]; instead use the
- line 1903: // TODO use shardhandler
- line 2052: // TODO use shardhandler
solr/core/src/java/org/apache/solr/index/SlowCompositeReaderWrapper.java (8 lines):
- line 79: // TODO: this could really be a weak map somewhere else on the coreCacheKey,
- line 135: // TODO: this is trappy as the expectation is that core keys live for a long
- line 150: return MultiDocValues.getNumericValues(in, field); // TODO cache?
- line 156: return MultiDocValues.getBinaryValues(in, field); // TODO cache?
- line 162: return MultiDocValues.getSortedNumericValues(in, field); // TODO cache?
- line 312: return MultiDocValues.getNormValues(in, field); // TODO cache?
- line 355: return MultiBits.getLiveDocs(in); // TODO cache?
- line 395: // TODO: as this is a wrapper, should we really close the delegate?
solr/core/src/java/org/apache/solr/search/facet/FacetRangeProcessor.java (8 lines):
- line 51: // TODO: the code paths for initial faceting, vs refinement, are very different...
- line 52: // TODO: ...it might make sense to have seperate classes w/a common base?
- line 53: // TODO: let FacetRange.createFacetProcessor decide which one to instantiate?
- line 330: // TODO: should we be more flexible and accept things like "true" (strings)?
- line 593: // TODO: specialize count only
- line 598: // TODO: only save if number of slots is small enough?
- line 608: countAcc.incrementCount(slot, num); // TODO: roll this into collect()
- line 1023: // TODO: an alternate implementations can fill all accs at once
solr/ui/src/commonMain/kotlin/org/apache/solr/ui/components/main/MainComponent.kt (8 lines):
- line 52: // TODO Uncomment once DashboardComponent available
- line 55: // TODO Uncomment once MetricsComponent available
- line 58: // TODO Uncomment once ClusterComponent available
- line 61: // TODO Uncomment once SecurityComponent available
- line 64: // TODO Uncomment once ConfigsetsComponent available
- line 67: // TODO Uncomment once MetricsComponent available
- line 70: // TODO Uncomment once QueriesAndOperationsComponent available
- line 87: // TODO Uncomment once ThreadDump available
solr/core/src/java/org/apache/solr/uninverting/FieldCacheImpl.java (8 lines):
- line 536: // TODO: it is dumb that uninverting code is duplicated here in this method!!
- line 563: // TODO: use bulk API
- line 655: Bits docsWithField) { // TODO: accept null docsWithField?
- line 968: // TODO: use Uninvert?
- line 997: // TODO: use Uninvert?
- line 1128: // TODO: this if DocTermsIndex was already created, we
- line 1171: // TODO: would be nice to first check if DocTermsIndex
- line 1258: // TODO: this if DocTermsIndex was already created, we
solr/core/src/java/org/apache/solr/update/processor/DistributedZkUpdateProcessor.java (8 lines):
- line 205: // TODO: revisit the need for tracking `issuedDistribCommit` -- see below, and SOLR-15045
- line 246: // TODO: according to discussion on SOLR-15045, this call (and all tracking of
- line 492: // TODO: What if leaders changed in the meantime?
- line 620: // TODO: what if we are no longer the leader?
- line 718: // TODO: what if this core is not in the targeted collection?
- line 1174: // TODO: optionally fail if n replicas are not reached...
- line 1188: // TODO: if not a forward and replication req is not specified, we could
- line 1193: // TODO - we may need to tell about more than one error...
solr/core/src/java/org/apache/solr/update/UpdateLog.java (7 lines):
- line 480: // TODO: these startingVersions assume that we successfully recover from all non-complete tlogs.
- line 760: // TODO: we currently need to log to maintain correct versioning, rtg, etc
- line 780: // TODO: in the future we could support a real position for a REPLAY update.
- line 1043: // TODO: check that this works to cap a tlog we were using to buffer so we don't replay on
- line 1787: // TODO: refactor this out so we get common error handling
- line 1888: // TODO: what if I hand out a list of updates, then do an update, then hand out another list
- line 2317: // TODO handle the case when there are no progress after a long time
solr/test-framework/src/java/org/apache/solr/cloud/ChaosMonkey.java (7 lines):
- line 59: *
TODO: expire multiple sessions / connectionloss at once
- line 61: *
TODO: kill multiple jetties at once
- line 63: *
TODO: ? add random headhunter mode that always kills the leader
- line 65: *
TODO: chaosmonkey should be able to do cluster stop/start tests
- line 147: // TODO: expire all clients at once?
- line 318: // TODO: stale state makes this a tough call
- line 531: // TODO: when kill leaders is on, lets kill a higher percentage of leaders
solr/core/src/java/org/apache/solr/update/PeerSync.java (7 lines):
- line 129: // TODO: close
- line 168: // TODO: core name turns up blank in many tests - find URL if cloud enabled?
- line 354: // TODO: look at this more thoroughly - we don't want
- line 406: // TODO: we should return the above information so that when we can request a recovery through
- line 409: // TODO: at least log???
- line 446: // TODO: how to handle short lists?
- line 724: // TODO: should this be handled separately as a problem with us?
solr/core/src/java/org/apache/solr/core/SolrConfig.java (6 lines):
- line 291: // TODO: Old code - in case somebody wants to re-enable. Also see SolrIndexSearcher#search()
- line 460: // TODO: WTF is up with queryConverter???
- line 548: // TODO: we should be explicitly looking for file not found exceptions
- line 924: // TODO Want to remove SolrResourceLoader.getInstancePath; it can be on a Standalone subclass.
- line 984: // TODO remove after fixing https://issues.apache.org/jira/browse/SOLR-13706
- line 1019: // TODO there is more to add
solr/core/src/java/org/apache/solr/schema/LatLonPointSpatialField.java (6 lines):
- line 60: // TODO once LLP & LLDVF are out of Lucene Sandbox, we should be able to javadoc reference them.
- line 66: // TODO handle polygons
- line 85: schema.getField(fieldName); // TODO change AbstractSpatialFieldType so we get schemaField?
- line 123: // TODO move to Lucene-spatial-extras once LatLonPoint & LatLonDocValuesField moves out of sandbox
- line 195: // // TODO support multi-polygon
- line 218: // // TODO support multi-polygon
solr/core/src/java/org/apache/solr/search/facet/FacetProcessor.java (6 lines):
- line 50: // TODO : I'm not sure this needs to be generic but come back to this later
- line 53: // TODO: do these need to be on the context to support recomputing during multi-select?
- line 83: // TODO: prevent parsing filters each time!
- line 207: // TODO: somehow remove responsebuilder dependency
- line 225: // TODO: we lose parent exclusions...
- line 257: // TODO: avoid query parsing per-bucket somehow...
solr/core/src/java/org/apache/solr/handler/component/TermsComponent.java (6 lines):
- line 153: // FIXME: terms.ttf=true is not supported for pointFields
- line 190: // TODO: we can't use the streaming solution until XML writer supports PushWriter!
- line 240: // TODO: how to handle binary? perhaps we don't for "raw"... or if the field exists
- line 281: // TODO: support "raw" mode?
- line 299: // TODO: handle raw somehow
- line 467: // TODO: not sure 128 is the best starting size
solr/core/src/java/org/apache/solr/util/NumberUtils.java (6 lines):
- line 56: // TODO: operate directly on BytesRef
- line 76: // TODO: operate directly on BytesRef
- line 109: // TODO: operate directly on BytesRef
- line 134: // TODO: operate directly on BytesRef
- line 162: // TODO: operate directly on BytesRef
- line 191: // TODO: operate directly on BytesRef
solr/core/src/java/org/apache/solr/search/facet/RelatednessAgg.java (6 lines):
- line 81: // TODO: defaults not supported yet -- see comments in createSlotAcc
- line 106: // TODO: need better output processing when we start supporting null fgQ/bgQ in constructor
- line 143: // TODO: Ideally this is where we should check fgQ/bgQ for 'null' and apply defaults...
- line 343: // TODO: avoid initializing array until we know we're not doing sweep collection?
- line 630: // TODO: add support for a "sort_val" option...
- line 661: // TODO: it would be nice to put them directly in the parent facet, instead of every bucket,
solr/solrj/src/java/org/apache/solr/common/util/NamedList.java (6 lines):
- line 130: *
TODO: this method was formerly public, now that it's not we can change the impl details of
- line 498: // TODO implement more efficiently
- line 505: // TODO implement more efficiently
- line 511: // TODO implement more efficiently
- line 566: // TODO: we NPE if val is null; yet we support val members above. A bug?
- line 594: // TODO this seems scary because it does not type checking
solr/test-framework/src/java/org/apache/solr/cloud/AbstractBasicDistributedZkTestBase.java (6 lines):
- line 160: // TODO: tlog replicas makes commits take way to long due to what is likely a bug and it's
- line 619: /* TODO: the failure may come back in "exception"
- line 737: // TODO: This test currently fails because debug info is obtained only
- line 1129: // TODO: Use CollectionAdminRequest for this test
- line 1238: // TODO: test deletes. SolrJ needs a good way to pass version for delete...
- line 1335: // TODO: enable when we don't falsely get slice1...
solr/test-framework/src/java/org/apache/solr/cloud/AbstractFullDistribZkTestBase.java (6 lines):
- line 114: * TODO: we should still test this works as a custom update chain as well as what we test now - the
- line 308: // TODO: for now, turn off stress because it uses regular clients, and we
- line 968: // TODO: no trailing slash on end desired, so replica.getCoreUrl is not applicable here
- line 1779: // TODO: as we create the clients, we should build a map from shard to
- line 1956: closeRestTestHarnesses(); // TODO: close here or later?
- line 2017: // TODO: Use CollectionAdminRequest#createCollection() instead of a raw request
solr/core/src/java/org/apache/solr/update/processor/DocExpirationUpdateProcessorFactory.java (6 lines):
- line 222: // TODO: check for managed schema and auto-add as a date field?
- line 273: // TODO: should we make initialDelay configurable
- line 274: // TODO: should we make initialDelay some fraction of the period?
- line 323: // TODO: should we try to accept things like "1DAY" as well as "+1DAY" ?
- line 406: // TODO: should this be more configurable?
- line 407: // TODO: in particular: should hard commit be optional?
solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java (6 lines):
- line 193: // TODO: Consider doing this for all collections, not just the PRS collections.
- line 194: // TODO comment above achieved by switching the cluster to distributed state updates
- line 200: // TODO: Consider doing this for all collections, not just the PRS collections.
- line 331: // TODO: Consider doing this for all collections, not just the PRS collections.
- line 333: // TODO: consider doing this once after the loop for all replicas rather than writing
- line 731: // TODO shouldn't the stateManager ensure this does not happen; should throw
solr/ui/src/commonMain/kotlin/org/apache/solr/ui/views/navigation/NavigationSideBar.kt (5 lines):
- line 103: // TODO Add condition for displaying logout button if user identity / auth present
- line 108: onClick = {}, // TODO Call logout on auth component
- line 172: MainMenu.Configsets -> Icons.Rounded.Folder // TODO Update to FolderData
- line 174: MainMenu.QueriesAndOperations -> Icons.Rounded.DocumentScanner // TODO Update to OtherAdmission
- line 185: * TODO Remove once all sections are added
solr/core/src/java/org/apache/solr/uninverting/DocTermOrds.java (5 lines):
- line 146: // TODO: This seems like an obvious candidate for using BytesRefArray extended with binarySearch
- line 169: // TODO: Why is indexedTermsArray not part of this?
- line 193: // TODO: instead of all these ctors and options, take termsenum!
- line 356: // TODO: really should 1) strip off useless suffix,
- line 397: // TODO: figure out what array lengths we can round up to w/o actually using more
solr/core/src/java/org/apache/solr/core/SolrCore.java (5 lines):
- line 2505: // TODO waitSearcher should be an AtomicReference or something that is a more clear API
- line 2876: * Keeping this usage of isDebugEnabled because the extraction of the log data as a string might be slow. TODO:
- line 2886: // TODO: this doesn't seem to be working correctly and causes problems with the example server
- line 2969: // TODO should check that responseHeader has not been replaced by handler
- line 3236: // TODO this is actually unsafe, the RMPI.initArgs can have objects too.
solr/core/src/java/org/apache/solr/search/facet/FacetFieldMerger.java (5 lines):
- line 27: // TODO: refactor more out to base class
- line 32: int[] numReturnedPerShard; // TODO: this is currently unused?
- line 112: // TODO: change effective offsets + limits at shards...
- line 151: // TODO: check refine of subs?
- line 152: // TODO: call subs each time with a shard/shardnum that is missing a bucket at this level?
solr/core/src/java/org/apache/solr/search/facet/FacetField.java (5 lines):
- line 69: return STREAM; // TODO replace with enum?
- line 110: // TODO if indexed=true then we could add support
- line 114: // TODO auto-pick ENUM/STREAM SOLR-9351 when index asc and DocSet cardinality is *not* much
- line 138: // TODO if method=UIF and not single-valued numerics then simply choose that now? TODO add
- line 143: // TODO can we auto-pick for strings when term cardinality is much greater than DocSet
solr/core/src/java/org/apache/solr/handler/component/PhrasesIdentificationComponent.java (5 lines):
- line 121: // TODO: ideally these should live in a commons.params class?
- line 253: // TODO: might want to add numDocs() & getSumTotalTermFreq(f)/getDocCount(f) stats from each
- line 291: // TODO: ideally this cut off of "0.0" should be a request option...
- line 347: // TODO: add an option to bias field weights based on sumTTF of the fields
- line 529: // TODO: rather then requiring the query analyzer to produce the Phrases for us (assuming
solr/core/src/java/org/apache/solr/schema/PointType.java (5 lines):
- line 71: // TODO: this doesn't currently support polyFields as sub-field types
- line 156: // TODO: should we assert that p1.length == dimension?
- line 197: // TODO: Handle distance measures
- line 206: // TODO: Handle distance measures, as this assumes Euclidean
- line 266: // TODO: Should we support sparse vectors?
solr/core/src/java/org/apache/solr/update/TransactionLog.java (5 lines):
- line 56: *
TODO: keep two files, one for [operation, version, id] and the other for the actual document
- line 466: // TODO: reset our file pointer back to "pos", the start of this record.
- line 562: // TODO: optimize this by keeping track of what we have flushed up to
- line 647: // TODO: should this class care if a file couldnt be deleted?
- line 928: // TODO: optionally skip document data
solr/core/src/java/org/apache/solr/search/facet/FacetModule.java (5 lines):
- line 61: // TODO: put a map on ResponseBuilder?
- line 317: facetState.mcontext.setShard(shardRsp.getShard()); // TODO: roll newShard into setShard?
- line 337: // TODO: merge any refinements
- line 352: // TODO: perhaps factor out some sort of root/parent facet object that doesn't depend
- line 517: // FIXME we need to propagate!!!
solr/core/src/java/org/apache/solr/schema/FieldType.java (5 lines):
- line 243: /** :TODO: document this method */
- line 290: * tokenized=true to get Lucene to convert to the internal(indexed) form. :TODO: clean up and
- line 1005: // TODO: change these all to use readableToIndexed/bytes instead (e.g. for unicode collation)
- line 1038: && !isPointField()) { // TODO: Remove !isPointField() for SOLR-14199
- line 1099: // TODO: if the field isn't indexed, this feels like the wrong query type to use?
solr/core/src/java/org/apache/solr/search/facet/FacetRequest.java (5 lines):
- line 221: // TODO: maybe allow simple string (instead of map) to mean "self join on this field name"
- line 362: // TODO it would be nice if there was no distinction. If the top level request had "type" as
- line 410: // TODO: should the default impl check processEmpty ?
- line 447: // TODO check for FacetDebugInfo? and if so set on fcontext
- line 449: // TODO should the SolrQueryRequest be held on the FacetRequest? It was created from
solr/core/src/java/org/apache/solr/core/CoreDescriptor.java (4 lines):
- line 216: // TODO maybe make this a CloudCoreDescriptor subclass?
- line 322: /** TODO remove mutability */
- line 379: // TODO consider falling back on "collection.configName" ( CollectionAdminParams.COLL_CONF )
- line 383: /** TODO remove mutability or at least make this non-public? */
solr/core/src/java/org/apache/solr/cloud/RecoveryStrategy.java (4 lines):
- line 373: // TODO: We can probably delete most of this code if we say this strategy can only be used
- line 466: // TODO: we don't want to retry for some problems?
- line 516: // TODO: perhaps make this grab a new core each time through the loop to handle core reloads?
- line 662: // TODO since SOLR-11216, we probably won't need this
solr/test-framework/src/java/org/apache/solr/BaseDistributedSearchTestCase.java (4 lines):
- line 109: // TODO: this shouldn't be static. get the random when you need it to avoid sharing.
- line 503: int batchSize = 100; // TODO make configurable?
- line 628: // TODO: look into why passing true causes fails
- line 986: // TODO: this should prob be done by adding an ignore on _version_ rather than mutating the
solr/core/src/java/org/apache/solr/highlight/DefaultSolrHighlighter.java (4 lines):
- line 535: // TODO: highlighting numeric fields is broken (Lucene) - so we disable them until fixed (see
- line 827: // TODO FieldType needs an API for this, e.g. toExternalFromDv()
- line 847: // TODO: we can include score and position information in output as snippet attributes
- line 962: new LinkedList<>(); // TODO replace with Deque, Array impl
solr/solrj-zookeeper/src/java/org/apache/solr/common/cloud/ZkStateReader.java (4 lines):
- line 106: // TODO: Deprecate and remove support for roles.json in an upcoming release.
- line 481: // TODO shouldn't we call ZooKeeper.sync() at the right places to prevent reading a stale value?
- line 1005: // TODO: It's odd that the default is to return replicas of type TLOG and NRT only
- line 1406: // TODO in Solr 10 remove that factory method
solr/core/src/java/org/apache/solr/search/facet/SlotAcc.java (4 lines):
- line 274: // TODO: we should really have a decoupled value provider...
- line 295: // TODO: make more sense to have func as the base class rather than double?
- line 300: protected double[] result; // TODO: use DoubleArray
- line 858: // TODO: count arrays can use fewer bytes based on the number of docs in
solr/api/src/java/org/apache/solr/client/api/model/CollectionStatusResponse.java (4 lines):
- line 39: // TODO - consider 'Instant' once SOLR-17608 is finished
- line 75: @JsonProperty public String state; // TODO Make this an enum?
- line 104: @JsonProperty public String state; // TODO Make this an enum?
- line 105: @JsonProperty public String type; // TODO Make this an enum?
solr/solrj/src/java/org/apache/solr/common/params/CollectionParams.java (4 lines):
- line 132: // TODO when we have a node level lock use it here
- line 134: // TODO when we have a node level lock use it here
- line 136: // TODO when we have a node level lock use it here
- line 141: // TODO: not implemented yet
solr/core/src/java/org/apache/solr/search/facet/FacetRequestSortedMerger.java (4 lines):
- line 200: // TODO: should returnsPartial() check processEmpty internally?
- line 234: // TODO: should we scale our 'overrefine' (heuristic) value based on 'mincount' ?
- line 309: // TODO: what if we don't need to refine any variable buckets, but we do need to contribute to
- line 312: // TODO: test with a sub-facet with a limit of 0 and something like a missing bucket
solr/core/src/java/org/apache/solr/handler/component/SpellCheckComponent.java (4 lines):
- line 588: // TODO: support custom attributes
- line 720: // TODO addSpellChecker response should set hasDefault!
- line 756: // TODO: There's got to be a better way! Where's Spring when you need it?
- line 765: // TODO: this is a little bit sneaky: warn if class isn't supplied
solr/test-framework/src/java/org/apache/solr/util/QueryMatchers.java (4 lines):
- line 36: // TODO: This can be contributed to Lucene
- line 83: // TODO Use a better matcher for more descriptive results?
- line 122: // TODO Use a better matcher for more descriptive results?
- line 164: // TODO Figure out Varargs
solr/core/src/java/org/apache/solr/handler/component/HighlightComponent.java (4 lines):
- line 86: // TODO lets restructure the abstractions/relationships
- line 139: // TODO: get from builder by default?
- line 165: // TODO ???? add this directly to the response?
- line 220: // TODO: make a generic routine to do automatic merging of id keyed data
solr/ui/src/commonMain/kotlin/org/apache/solr/ui/components/environment/store/EnvironmentStoreProvider.kt (4 lines):
- line 105: scope.launch { // TODO Add coroutine exception handler
- line 111: // TODO Add error handling
- line 121: scope.launch { // TODO Add coroutine exception handler
- line 127: // TODO Add error handling
solr/core/src/java/org/apache/solr/search/PointMerger.java (4 lines):
- line 226: // TODO: handle filter or deleted documents?
- line 289: // TODO: handle filter or deleted documents?
- line 352: // TODO: handle filter or deleted documents?
- line 415: // TODO: handle filter or deleted documents?
solr/core/src/java/org/apache/solr/handler/component/StatsField.java (4 lines):
- line 266: // reparse everything. ( TODO: refactor a common method in QParser ?)
- line 461: // TODO: should this also be used for single-valued string fields? (should work fine)
- line 699: // TODO: we could attempt additional reductions in the default regwidth based on index
- line 806: // TODO: add more tunning options for this.
solr/core/src/java/org/apache/solr/util/SolrPluginUtils.java (4 lines):
- line 204: // TODO consider moving / adapting this into a new StrUtils.splitSmart variant?
- line 205: // TODO deprecate; it's only used by two callers?
- line 576: *
:TODO: should optimize the case where number is same as clauses to just make them all
- line 813: // TODO: lookup won't work for non-string ids... String vs Float
solr/core/src/java/org/apache/solr/request/IntervalFacets.java (4 lines):
- line 227: // TODO: this bit flipping should probably be moved to tie-break in the PQ comparator
- line 237: // TODO: this bit flipping should probably be moved to tie-break in the PQ comparator
- line 588: // TODO: what about escaping star (*)?
- line 589: // TODO: escaping spaces on ends?
solr/core/src/java/org/apache/solr/search/QParser.java (4 lines):
- line 188: // TODO never return null; standardize the semantics
- line 229: // TODO: replace with a SolrParams that defaults to checking localParams first?
- line 253: // TODO: this would be better passed in to the constructor... change to a ParserContext object?
- line 385: // TODO if remainder of query string after '}' is non-empty, then what? Throw error? Fall
solr/core/src/java/org/apache/solr/core/CoreContainer.java (4 lines):
- line 754: // TODO put in the objectCache instead
- line 906: // TODO: manage to completely build CoreContainer in the constructor and not in the load()
- line 1592: // TODO: Shouldn't this be a BAD_REQUEST?
- line 2008: // TODO: remove core.properties from the conf directory in test files, it's in a bad place there
solr/modules/cross-dc/src/java/org/apache/solr/crossdc/update/processor/MirroringUpdateProcessor.java (4 lines):
- line 213: // TODO: implement "expand without deep paging"
- line 285: // TODO: Can we actually support this considering DBQs aren't versioned.
- line 331: // TODO: what if this core is not in the targeted collection?
- line 358: // TODO: We can't/shouldn't support this ?
solr/core/src/java/org/apache/solr/search/facet/FacetBucket.java (4 lines):
- line 46: // TODO: we don't need bucket numbers for all buckets...
- line 146: // TODO - partial results should turn off refining!!!
- line 150: // TODO: this is a redundant check for many types of facets... only do on field faceting
- line 180: // TODO: listing things like sub-facets that have no field facets are redundant
solr/core/src/java/org/apache/solr/cloud/SyncStrategy.java (4 lines):
- line 200: // TODO: as an assurance, we should still try and tell the sync nodes that we couldn't reach
- line 232: // TODO: we should do this in parallel at least
- line 303: // TODO: why does this return null sometimes?
- line 318: // TODO should we use peerSyncWithLeader instead?
solr/core/src/java/org/apache/solr/request/NumericFacets.java (4 lines):
- line 173: // TODO: evaluate using getCountsMultiValued for singleValued numerics with
- line 226: // TODO: this bit flipping should probably be moved to tie-break in the PQ comparator
- line 238: // TODO: this bit flipping should probably be moved to tie-break in the PQ comparator
- line 560: result.add(bitsToStringValue(ft, entry.bits), entry.count); // TODO: convert to correct value
solr/core/src/java/org/apache/solr/spelling/IndexBasedSpellChecker.java (3 lines):
- line 81: // TODO: maybe whether or not to clear the index should be configurable?
- line 85: // TODO: you should be able to specify the IWC params?
- line 86: // TODO: if we enable this, codec gets angry since field won't exist in the schema
dev-tools/scripts/releaseWizard.yaml (3 lines):
- line 50: In the first TODO step in the checklist you will be asked to read up on the
- line 158: # You can reference state saved from earlier TODO items using syntax
- line 167: # persist_vars: ['var_name', 'var_name'] # List of variables to persist in TODO state
solr/core/src/java/org/apache/solr/servlet/HttpSolrCall.java (3 lines):
- line 282: // TODO try the other collections if can't find a local replica of the first? (and do to
- line 737: // TODO using Http2Client
- line 979: // TODO add a SolrRequest.getModifiableParams ?
solr/core/src/java/org/apache/solr/request/PerSegmentSingleValuedFaceting.java (3 lines):
- line 124: // TODO: Is there a completion service, or a delegating executor that can
- line 139: // TODO: if limiting threads, submit by largest segment first?
- line 314: // TODO: we could constrain the lower endpoint if we had a binarySearch method that allowed
solr/solrj-streaming/src/java/org/apache/solr/client/solrj/io/stream/UpdateStream.java (3 lines):
- line 358: // TODO: it would be nice if there was an option to "skipFailedBatches"
- line 359: // TODO: and just record the batch failure info in the summary tuple for that batch and
- line 362: // TODO: The summary batches (and/or stream error) should also pay attention to the error
solr/test-framework/src/java/org/apache/solr/cloud/AbstractChaosMonkeyNothingIsSafeTestBase.java (3 lines):
- line 118: // TODO: we only do this sometimes so that we can sometimes compare against control,
- line 125: return false; // TODO: tlog replicas makes commits take way to long due to what is likely a bug
- line 249: // TODO: assert we didnt kill everyone
solr/core/src/java/org/apache/solr/search/facet/UniqueAgg.java (3 lines):
- line 97: // TODO: somehow get & use the count in the bucket?
- line 187: // TODO: make configurable
- line 188: // TODO: share values across buckets
solr/core/src/java/org/apache/solr/cloud/Overseer.java (3 lines):
- line 191: // TODO remove in 9.0, we do not push message into this queue anymore
- line 276: // TODO consider removing 'refreshClusterState' and simply check if clusterState is null
- line 455: // TODO: if ordering for the message is not important, we could
solr/core/src/java/org/apache/solr/handler/component/FacetComponent.java (3 lines):
- line 818: // TODO: on a tie, we could check the term values
- line 1123: } else { // TODO: log error or throw exception?
- line 1547: // TODO: could store the last term in the shard to tell if this term
solr/core/src/java/org/apache/solr/cloud/DistributedClusterStateUpdater.java (3 lines):
- line 457: // TODO Eventually rethink the way each node manages and caches its copy of the cluster
- line 630: // TODO in Solr 10 remove that factory method
- line 887: // TODO update stats here for the various commands executed successfully or not?
solr/core/src/java/org/apache/solr/search/facet/FacetFieldProcessorByHashDV.java (3 lines):
- line 149: // TODO consider making FacetRangeProcessor.Calc facet top level; then less of a hack?
- line 232: // TODO: Use the number of indexed terms, if present, as an estimate!
- line 346: // TODO support SortedSetDocValues
solr/core/src/java/org/apache/solr/core/SolrResourceLoader.java (3 lines):
- line 241: // TODO improve to use a static Set to check when we need to
- line 379: // TODO can we nuke this?
- line 668: // TODO: Assert here?
solr/core/src/java/org/apache/solr/handler/tagger/TaggerRequestHandler.java (3 lines):
- line 125: "The tagger requires a" + "uniqueKey in the schema."); // TODO this could be relaxed
- line 143: + " does not support multiple ContentStreams"); // TODO support bulk tagging?
- line 239: tagger.enableDocIdsCache(2000); // TODO configurable
solr/core/src/java/org/apache/solr/search/facet/UniqueSlotAcc.java (3 lines):
- line 113: // TODO: make configurable
- line 114: // TODO: share values across buckets
- line 150: if (counts == null) { // TODO: a more efficient way to do this? prepareSort?
solr/test-framework/src/java/org/apache/solr/cloud/AbstractBasicDistributedZk2TestBase.java (3 lines):
- line 68: return false; // TODO: tlog replicas makes commits take way to long due to what is likely a bug
- line 137: // TODO: bring this to its own method?
- line 379: // TODO: This test currently fails because debug info is obtained only
solr/solrj/src/java/org/apache/solr/common/util/Utils.java (3 lines):
- line 229: result.add(makeDeepCopy(o, maxDepth, mutable, sorted)); // TODO should this be maxDepth - 1?
- line 917: // TODO Should we be lenient here and accept both the Jackson and our homegrown
- line 976: // TODO fix that later
solr/core/src/java/org/apache/solr/util/DateMathParser.java (3 lines):
- line 209: // TODO this API is a bit clumsy. "now" is rarely used.
- line 268: // TODO write the equivalent of a Date::from; avoids Instant -> Date
- line 286: // TODO Deprecate?
solr/core/src/java/org/apache/solr/update/processor/RoutedAliasUpdateProcessor.java (3 lines):
- line 120: // TODO this may eventually not be true but at the moment it is
- line 217: cmdDistrib.blockAndDoRetries(); // TODO shouldn't distribCommit do this implicitly? It doesn't.
- line 280: // TODO when should we do StdNode vs RetryNode?
solr/core/src/java/org/apache/solr/core/PluginBag.java (3 lines):
- line 108: // TODO: since reads will dominate writes, we could also think about creating a new instance of
- line 255: // TODO Should we use to override the path that each
- line 433: // TODO: there may be a race here. One thread can be creating a plugin
solr/core/src/java/org/apache/solr/search/facet/FacetMerger.java (3 lines):
- line 40: public abstract Object getMergedResult(); // TODO: we should pass mcontext through here as well
- line 59: int shardNum = -1; // TODO: keep same mapping across multiple phases...
- line 136: // TODO: should returnsPartial() check processEmpty internally?
solr/solrj/src/java/org/apache/solr/client/solrj/request/CollectionAdminRequest.java (3 lines):
- line 486: Integer numPullReplicas) { // TODO: maybe add other constructors
- line 2031: // TODO: This and other commands in this file seem to need to share some sort of constants class
- line 2663: // TODO - deal with this inconsistency
solr/core/src/java/org/apache/solr/cloud/api/collections/Assign.java (3 lines):
- line 149: // TODO: now that we create shards ahead of time, is this code needed? Esp since hash ranges
- line 162: // TODO: don't need to sort to find shard with fewest replicas!
- line 184: // TODO: Adding the suffix is great for debugging, but may be an issue if at some point we want
solr/core/src/java/org/apache/solr/handler/component/SearchHandler.java (3 lines):
- line 564: // TODO: map from shard to address[]
- line 896: // TODO: generalize how a comm component can fit into search component framework
- line 897: // TODO: statics should be per-core singletons
solr/core/src/java/org/apache/solr/query/SolrRangeQuery.java (3 lines):
- line 108: hash = hash * 29 + ((lower == null) ? 0 : lower.hashCode()); // TODO: simpler hash code here?
- line 135: // TODO: use our schema?
- line 155: // TODO: other escaping
solr/test-framework/src/java/org/apache/solr/util/BaseTestHarness.java (3 lines):
- line 231: *
:TODO: currently only deals with one add/doc at a time, this will need changed if/when
- line 244: *
:TODO: currently only deals with one add/doc at a time, this will need changed if/when
- line 262: *
:TODO: currently only deals with one add/doc at a time, this will need changed if/when
solr/webapp/web/partials/documents.html (3 lines):
- line 32:
- line 72:
- line 75: