lib/BuildSystem/BuildSystem.cpp (43 lines): - line 86: /// FIXME: It would be nice to have a StringSet. - line 135: // FIXME: This is an inefficent map, the string is duplicated. - line 138: // FIXME: This is an inefficent map, the string is duplicated. - line 253: // FIXME: We should eliminate this, it isn't well formed when loading - line 278: // FIXME: Find a cleaner strategy for merging the internal schema version - line 314: // FIXME: How do we pass the client schema version here, if we haven't - line 384: // FIXME: We should probably factor this out somewhere else, so we can enforce - line 433: // FIXME: Design the logging and status output APIs. - line 475: // FIXME: We should do this work in the background. - line 479: // FIXME: This needs to delegate, since we want to have a notion of - line 502: // FIXME: This is inefficient, we will end up doing the stat twice, once - line 543: // FIXME: We should do this work in the background. - line 691: // FIXME: We should probably factor this out somewhere else, so we can enforce - line 781: // FIXME: - line 821: // FIXME: We should do this work in the background. - line 857: // FIXME: This is not going through the filesystem object. Indeed the fs - line 934: // FIXME: - line 1008: // FIXME: This is not going through the filesystem object. Indeed the fs - line 1055: // FIXME: This algorithm currently does a redundant stat for each directory, - line 1059: // FIXME: We need to fix the directory list to not get contents for symbolic - line 1200: // FIXME: This algorithm currently does a redundant stat for each directory, - line 1204: // FIXME: We need to fix the directory list to not get contents for symbolic - line 1554: // FIXME: We should most likely have some kind of registration process so we - line 1789: // FIXME: Invalid target name, produce an error. - line 1790: assert(0 && "FIXME: invalid target"); - line 2156: // FIXME: Really want this job to go into a high priority fifo queue - line 2217: // FIXME: Should create a CustomCommand class, to avoid all the boilerplate - line 2282: // FIXME: Need a decent subprocess interface. - line 2288: // FIXME: cmd.exe uses different syntax for I/O redirection to null. - line 2302: // FIXME: Error handling. - line 2313: // FIXME: We should support BuildValues with arbitrary payloads. - line 2444: // FIXME: This isn't correct, we need utilities for doing shell quoting. - line 2680: // FIXME: We need to fix the input ID situation, this is not extensible. We - line 2719: // FIXME: Need to add support for required parameters. - line 2757: // FIXME: This should really be done using an additional implicit input, so - line 2853: // FIXME: This isn't correct, we need utilities for doing shell quoting. - line 2877: // FIXME: We should strictly enforce the integrity of this validity routine - line 2996: // FIXME: This isn't correct, we need utilities for doing shell quoting. - line 3006: // FIXME: This isn't correct, we need utilities for doing shell quoting. - line 3107: // FIXME: We should make this explicit once we have actual support for must - line 3140: // FIXME: Shared behavior with ExternalCommand. - line 3233: // TODO instead insert, update and remove files from the archive - line 3785: // FIXME: We should give the client the opportunity to support a previous lib/Core/BuildEngine.cpp (23 lines): - line 240: // FIXME: This is a bit dubious, and wouldn't work anymore if we moved the - line 293: // FIXME: Keeping this in a side table is very inefficient, we always have to - line 303: // FIXME: Note that this structure is redundant here, as - line 310: // FIXME: As above, this structure has redundancy in it. - line 383: // FIXME: This should be abstracted into a helper class. - line 467: // FIXME: We should probably try and move this so that it can be done by - line 563: // FIXME: This should perhaps just be lumped in with the start call? Or - line 629: // FIXME: We need to continue scanning the rest of the inputs to ensure we - line 730: // FIXME: We don't want to process all of these requests, this amounts to - line 797: // FIXME: This is very performance critical and should be highly - line 859: // FIXME: Should we provide the input key here? We have it available - line 897: // FIXME: We need to track this state, and generate an error if this - line 948: // FIXME: We could audit these dependencies at this point to verify that - line 956: // FIXME: The need to do this makes it questionable that we use this - line 1346: // FIXME: This is currently an O(n) operation that could be relatively - line 1454: // FIXME: Investigate retrieving this result lazily. If the DB is - line 1462: // FIXME: Investigate changing the database error handling model to - line 1561: // FIXME: Introduce a per-build context object to hold this. - line 1574: // FIXME: Is it correct to do this here, or earlier? - line 1689: // FIXME: Error handling. - line 1739: // FIXME: We should flag the task to ensure this is only called once, and - line 1825: // FIXME: handle environment - line 1841: // FIXME: handle environment lib/Commands/NinjaBuildCommand.cpp (14 lines): - line 327: // FIXME: This could be packed one entry tighter. - line 470: // FIXME: In our model, we still wait for everything to terminate, which - line 931: // TODO: util::emitError doesn't use the console queue? - line 980: // FIXME: We should support update-if-newer for commands with deps. - line 1033: // FIXME: Find a way to harden this more, or see if we can just get CMake - line 1142: // FIXME: Is it right to bring this up-to-date when one of the inputs - line 1401: // FIXME: Error handling. - line 1571: // FIXME: We don't try and set this in response to the restat flag on - line 1608: // FIXME: This is inefficient, we will end up doing the stat twice, once when - line 1699: // FIXME: This is frequently a redundant lookup, given that the caller might - line 2184: // FIXME: We should probably also move this to be dynamic. - line 2196: // FIXME: Make efficient. - line 2228: // FIXME: This is somewhat inefficient, as we will end up repeating any - line 2294: // FIXME: We should sort out eventually whether the engine itself should lib/llvm/Support/YAMLParser.cpp (13 lines): - line 727: // FIXME: Error reporting. - line 1253: // FIXME: Remove once llvm optimizes this to the faster version without hints. - line 1654: // FIXME: Actually parse the c-ns-shorthand-tag rule. - line 1843: // TODO: Tag resolution. - line 1879: // TODO: Handle newlines properly. We need to remove leading whitespace. - line 1939: // TODO: Report error. - line 2012: // TODO: Report error. - line 2016: // TODO: Report error. - line 2024: // TODO: Report error. - line 2028: // TODO: Report error. - line 2036: // TODO: Report error. - line 2040: // TODO: Report error. - line 2395: // TODO: Properly handle tags. "[!!str ]" should resolve to !!str "", not products/libllbuild/BuildSystem-C-API.cpp (10 lines): - line 84: // FIXME: This is an unfortunate amount of copying. - line 90: // FIXME: This is gross, come up with a general purpose solution. - line 552: // FIXME: We don't currently expose the caret diagnostic information, or - line 588: // FIXME: Need to get the client name and schema version from - line 631: // FIXME: Support custom attributes in client tools. - line 638: // FIXME: Support custom attributes in client tools. - line 645: // FIXME: Support custom attributes in client tools. - line 667: // FIXME: This is incredibly wasteful to copy everywhere. Rephrase things so - line 1013: // FIXME: Provide client control. - line 1022: // FIXME: Provide client control. lib/BuildSystem/ExternalCommand.cpp (10 lines): - line 132: // FIXME: Eliminate this, and make the build value array contain an array of - line 141: // FIXME: This is O(N). We don't expect N to be large in practice, but it - line 181: // FIXME: CONSISTENCY: One consistency issue in this model currently is that - line 266: // FIXME: Eventually, it might be nice to harden the format so that we know - line 295: // FIXME: This should also account for dependencies that were added dynamically. - line 329: // FIXME: We need to delegate to the node here. - line 333: // FIXME: We currently have to shoehorn the timestamp into a fake file - line 347: // FIXME: If the outputs are empty, it might mean that this instance is for a custom task, which does not - line 392: // FIXME: Implement a shared cache for this, to reduce the number of - line 399: // FIXME: Need to use the filesystem interfaces. products/llbuildSwift/BuildSystemBindings.swift (9 lines): - line 170: // FIXME: This is unfortunate, we should be able to destroy these naturally. - line 359: // FIXME: The terminology is really confusing here, we have ExternalCommand which is divorced from the actual internal command implementation of the same name. - line 571: // FIXME: We shouldn't need to expose this to use for mapping purposes, we should be able to use something more efficient. - line 635: // FIXME: We would like to call this Process, but then it conflicts with Swift's builtin Process. Maybe there is another name? - line 712: // FIXME: We want to remove this protocol eventually and use the FileSystem - line 974: // FIXME: This should be a separate callback, not shared with getFileInfo (or get FileInfo should take a parameter). - line 977: // FIXME: should support fs_create_symlink, but for now explicitly defers to built-in symlink - line 1143: // FIXME: We do not support this natively, yet. - line 1149: // FIXME: This is unfortunate, we should be able to destroy these naturally. lib/llvm/Support/TargetParser.cpp (8 lines): - line 29: // FIXME: TableGen this. - line 50: // FIXME: SubArch values were simplified to fit into the expectations - line 53: // FIXME: TableGen this. - line 90: // FIXME: TableGen this. - line 111: // FIXME: TableGen this. - line 127: // FIXME: TableGen this. - line 580: // FIXME: Clang uses it, but it's bogus, since neon defaults to vfpv3. - line 856: // FIXME: this is invalid for WindowsCE. lib/Ninja/include/llbuild/Ninja/Manifest.h (7 lines): - line 48: // FIXME: This is an inefficent map, given that the string is contained - line 97: // FIXME: Figure out what the deal is with normalization. - line 171: // FIXME: It might be substantially better to evaluate all of these in the - line 188: // FIXME: Use an rvalue reference for the outputs and inputs here to avoid - line 344: // FIXME: It would be nice to optimize this more, and the common case is that - line 376: // FIXME: This is an inefficent map, given that the string is contained - line 386: // FIXME: This is an inefficent map, given that the string is contained lib/llvm/Support/SourceMgr.cpp (7 lines): - line 217: // FIXME: Handle multibyte characters. - line 299: // FIXME: Handle multibyte characters in the source line. - line 317: // FIXME: This assertion is intended to catch unintended use of multibyte - line 334: // FIXME: Handle multibyte characters in the source line. - line 430: // FIXME: If there are multibyte or multi-column characters in the source, all - line 453: // FIXME: Find the beginning of the line properly for multibyte characters. - line 508: // FIXME: This is trying not to break up replacements, but then to re-sync products/libllbuild/include/llbuild/buildsystem.h (7 lines): - line 231: // FIXME: This doesn't belong here, move once the status is fully delegated. - line 276: // FIXME: Design clean data types for clients to return unowned/unowned - line 341: // FIXME: Clean this up, we should be able to come up with a better definition - line 589: // FIXME: Need to support configuration behaviors. - line 604: // FIXME: Support dynamic tool commands. - line 764: // FIXME: This API most likely doesn't belong. - line 773: // FIXME: This API most likely doesn't belong. include/llbuild/Ninja/Manifest.h (7 lines): - line 48: // FIXME: This is an inefficent map, given that the string is contained - line 97: // FIXME: Figure out what the deal is with normalization. - line 171: // FIXME: It might be substantially better to evaluate all of these in the - line 188: // FIXME: Use an rvalue reference for the outputs and inputs here to avoid - line 344: // FIXME: It would be nice to optimize this more, and the common case is that - line 376: // FIXME: This is an inefficent map, given that the string is contained - line 386: // FIXME: This is an inefficent map, given that the string is contained lib/BuildSystem/include/llbuild/BuildSystem/BuildDescription.h (6 lines): - line 47: // FIXME: This is currently commingled with the build file loading, even though - line 82: // FIXME: Optimize for single entry list. - line 110: // FIXME: This is an inefficent map, the string is duplicated. - line 113: // FIXME: This is an inefficent map, the string is duplicated. - line 116: // FIXME: This is an inefficent map, the string is duplicated. - line 119: // FIXME: This is an inefficent map, the string is duplicated. include/llbuild/BuildSystem/BuildDescription.h (6 lines): - line 47: // FIXME: This is currently commingled with the build file loading, even though - line 82: // FIXME: Optimize for single entry list. - line 110: // FIXME: This is an inefficent map, the string is duplicated. - line 113: // FIXME: This is an inefficent map, the string is duplicated. - line 116: // FIXME: This is an inefficent map, the string is duplicated. - line 119: // FIXME: This is an inefficent map, the string is duplicated. include/llvm/Support/TargetParser.h (6 lines): - line 18: // FIXME: vector is used because that's what clang uses for subtarget feature - line 29: // FIXME: To TableGen this we need to make some table generated files available - line 103: // FIXME: BE8 vs. BE32? - line 117: // FIXME: These should be moved to TargetTuple once it exists - line 152: // FIXME:This should be made into class design,to avoid dupplication. - line 191: // FIXME: These should be moved to TargetTuple once it exists lib/llvm/Support/include/llvm/Support/TargetParser.h (6 lines): - line 18: // FIXME: vector is used because that's what clang uses for subtarget feature - line 29: // FIXME: To TableGen this we need to make some table generated files available - line 103: // FIXME: BE8 vs. BE32? - line 117: // FIXME: These should be moved to TargetTuple once it exists - line 152: // FIXME:This should be made into class design,to avoid dupplication. - line 191: // FIXME: These should be moved to TargetTuple once it exists lib/llvm/Support/APFloat.cpp (6 lines): - line 45: /// TODO: If clang source code is ever allowed to use constexpr in its own - line 112: TODO: Implement all operations in semPPCDoubleDouble, and delete these - line 2252: /* FIXME: should this just take a const APInt reference? */ - line 3361: // FIXME: this probably shouldn't use 'round half up'. - line 3445: // FIXME: Using a formula based purely on the precision is conservative; - line 3520: // TODO: don't do more precise calculations above than are required. lib/Basic/Subprocess.cpp (5 lines): - line 309: // FIXME: This really should move out of subprocess and up a layer or two. The - line 483: // FIXME: We should report a statistic for how much output we read from the - line 511: // FIXME: We should report a statistic for how much output we read from the - line 746: // FIXME: Note that this is an Apple-specific extension, and we will have to - line 801: // FIXME: This should be cached. bindings/python/llbuild.py (5 lines): - line 46: # FIXME: Need a way to find this. - line 84: # FIXME: Should we pass the context pointer separately from the delegate - line 118: # FIXME: What is to prevent the rule from being deallocated after this - line 142: # FIXME: This creates a cycle. - line 145: # FIXME: This leaks everything, but we are currently dropping a lib/Ninja/ManifestLoader.cpp (5 lines): - line 367: // FIXME: It probably should be an error to assign to the same parameter - line 393: // FIXME: Mange recursive lookup? Ninja crashes on it. - line 451: // FIXME: Eventually, we should evaluate whether it would be more efficient - line 460: // FIXME: There is no need to store the parameters in the build decl anymore - line 611: // FIXME: It probably should be an error to assign to the same parameter products/llbuildSwift/CoreBindings.swift (5 lines): - line 219: // FIXME: Why do we need this, why can't we get a pointer to the protocol - line 384: // FIXME: Include cycleDetected callback. - line 420: // FIXME: Why do I have to name the closure signature here? - line 462: // FIXME: We need a deallocation callback in order to ensure this is released. - line 492: // FIXME: Separate the delegate from the context pointer. lib/BuildSystem/BuildFile.cpp (5 lines): - line 122: // FIXME: Factor out into a parser helper class. - line 155: // FIXME: Factor out into a parser helper class. - line 527: // FIXME: One downside of doing the lookup here is that the client cannot - line 840: // FIXME: Lift the file access into the delegate, like we do for Ninja. - line 878: // FIXME: This is historical, We should tidy up this class to reflect that include/llbuild/BuildSystem/BuildSystemFrontend.h (4 lines): - line 241: // FIXME: We may eventually want to allow the individual job to provide some - line 244: // FIXME: Design a way to communicate the "lane" here, for use in "super - line 268: // FIXME: Need to move to more structured error handling. - line 286: // FIXME: Need to include additional information on the status here, e.g., the lib/BuildSystem/BuildSystemFrontend.cpp (4 lines): - line 557: // FIXME: We shouldn't need to do this, but should switch llbuild to using - line 562: // FIXME: We ignore errors here, for now, this will be resolved when we move - line 650: // FIXME: Design the logging and status output APIs. - line 757: // FIXME: Design the logging and status output APIs. include/llbuild/Core/BuildEngine.h (4 lines): - line 84: // FIXME: Think about this representation more. The problem with storing this - line 279: // FIXME: The intent of having a callback like Rule structure and a decoupled - line 287: // FIXME: We also need to figure out if a richer concurrency model is needed for - line 463: // FIXME: This method is hard to use correctly, we should modify build to lib/llvm/Support/MemoryBuffer.cpp (4 lines): - line 278: // TODO: Is 16-byte alignment enough? We copy small object files with large - line 331: // FIXME: this chunk of code is duplicated, but it avoids a fstat when - line 355: // FIXME: We should reorganize again getPageSize() on Win32. - line 511: // FIXME: That isn't necessarily true, we should try to mmap stdin and lib/llvm/Demangle/ItaniumDemangle.cpp (4 lines): - line 10: // FIXME: (possibly) incomplete list of features that clang mangles that this - line 3157: // FIXME parse the optional here! - line 3672: // FIXME: ::= L _ E # complex floating point literal (C 2000) - line 3829: // FIXME: This map is duplicated in parseOperatorName and parseExpr. lib/llvm/Support/include/llvm/ADT/SmallVector.h (4 lines): - line 109: Size = Capacity = 0; // FIXME: Setting Capacity to 0 is suspect. - line 420: // FIXME: Consider assigning over existing elements, rather than clearing & - line 743: // FIXME: don't do this if they're efficiently moveable. - line 802: // FIXME: this may not actually make any sense if we can efficiently move lib/BuildSystem/include/llbuild/BuildSystem/BuildSystemFrontend.h (4 lines): - line 241: // FIXME: We may eventually want to allow the individual job to provide some - line 244: // FIXME: Design a way to communicate the "lane" here, for use in "super - line 268: // FIXME: Need to move to more structured error handling. - line 286: // FIXME: Need to include additional information on the status here, e.g., the lib/llvm/Support/Host.cpp (4 lines): - line 395: // FIXME: should we save this for Clang? - line 435: // FIXME: should we save this for Clang? - line 776: // FIXME: this poorly matches the generated SubtargetFeatureKV table. There - line 977: //FIXME: include cpuid.h from clang or copy __get_cpuid_max here lib/Core/include/llbuild/Core/BuildEngine.h (4 lines): - line 84: // FIXME: Think about this representation more. The problem with storing this - line 279: // FIXME: The intent of having a callback like Rule structure and a decoupled - line 287: // FIXME: We also need to figure out if a richer concurrency model is needed for - line 463: // FIXME: This method is hard to use correctly, we should modify build to lib/BuildSystem/ShellCommand.cpp (4 lines): - line 78: // FIXME: Diagnose this sooner. - line 349: // FIXME: Really want this job to go into a high priority fifo queue - line 371: // FIXME: We should consider making this interface capable of feeding - line 374: // FIXME: This needs to honor certain properties of the execution queue lib/Basic/include/llbuild/Basic/ExecutionQueue.h (4 lines): - line 143: // FIXME: This interface will need to get more complicated, and provide the - line 168: // FIXME: This interface will need to get more complicated, and provide the - line 199: // FIXME: We may eventually want to allow the individual job to provide - line 202: // FIXME: Design a way to communicate the "lane" here, for use in "super include/llvm/ADT/SmallVector.h (4 lines): - line 109: Size = Capacity = 0; // FIXME: Setting Capacity to 0 is suspect. - line 420: // FIXME: Consider assigning over existing elements, rather than clearing & - line 743: // FIXME: don't do this if they're efficiently moveable. - line 802: // FIXME: this may not actually make any sense if we can efficiently move include/llbuild/Basic/ExecutionQueue.h (4 lines): - line 143: // FIXME: This interface will need to get more complicated, and provide the - line 168: // FIXME: This interface will need to get more complicated, and provide the - line 199: // FIXME: We may eventually want to allow the individual job to provide - line 202: // FIXME: Design a way to communicate the "lane" here, for use in "super unittests/Core/BuildEngineTest.cpp (3 lines): - line 473: // FIXME: This test is rather cumbersome for all it is trying to check, maybe - line 548: // FIXME: It would be nice to run this on a thread with a small stack to - line 572: // FIXME: Once we have custom ValueType objects, we would like to lib/llvm/Support/include/llvm/ADT/APFloat.h (3 lines): - line 814: // FIXME: This is due to clang 3.3 (or older version) always checks for the - line 839: // TODO: Remove this constructor. This isn't faster than the first one. - line 1012: // TODO: bool parameters are not readable and a source of bugs. Package.swift (3 lines): - line 198: // FIXME: Conditionalize these flags since SwiftPM 5.3 and earlier will crash for platforms they don't know about. - line 210: // FIXME: we need to define `libllbuild_EXPORTS` to ensure that the - line 218: // FIXME: when the SupportedPlatforms availability directive is updated and include/llbuild/Basic/Hashing.h (3 lines): - line 45: // FIXME: Use a more appropriate hashing infrastructure. - line 51: // FIXME: Use a more appropriate hashing infrastructure. - line 57: // FIXME: Use a more appropriate hashing infrastructure. lib/llvm/Support/include/llvm/ADT/STLExtras.h (3 lines): - line 405: /// FIXME: Currently if RangeT && is a rvalue reference to a temporary, the - line 444: // ^ TODO: Implement random access methods. - line 448: // ^ FIXME: This follows boost::make_zip_iterator's assumption that all lib/Basic/include/llbuild/Basic/Subprocess.h (3 lines): - line 199: // FIXME: Need to move to more structured error handling. - line 218: // FIXME: Need to include additional information on the status here, e.g., the - line 279: // FIXME: This interface will need to get more complicated, and provide the include/llbuild/BuildSystem/Command.h (3 lines): - line 37: // FIXME: This is currently commingled with the build file loading, even though - line 60: // FIXME: These probably don't belong here, clients generally can just manage - line 117: // FIXME: This feels awkward, maybe this isn't the right way to manage include/llvm/ADT/APFloat.h (3 lines): - line 814: // FIXME: This is due to clang 3.3 (or older version) always checks for the - line 839: // TODO: Remove this constructor. This isn't faster than the first one. - line 1012: // TODO: bool parameters are not readable and a source of bugs. lib/Basic/include/llbuild/Basic/Hashing.h (3 lines): - line 45: // FIXME: Use a more appropriate hashing infrastructure. - line 51: // FIXME: Use a more appropriate hashing infrastructure. - line 57: // FIXME: Use a more appropriate hashing infrastructure. lib/Core/SQLiteBuildDB.cpp (3 lines): - line 614: // FIXME: We could save some reallocation by having a templated SmallVector - line 620: // FIXME: This is naively mapping all keys with no caching at this point, - line 680: // FIXME: We should revist this, as we probably wouldn't want a crash in the include/llbuild/Basic/Subprocess.h (3 lines): - line 199: // FIXME: Need to move to more structured error handling. - line 218: // FIXME: Need to include additional information on the status here, e.g., the - line 279: // FIXME: This interface will need to get more complicated, and provide the include/llvm/ADT/STLExtras.h (3 lines): - line 405: /// FIXME: Currently if RangeT && is a rvalue reference to a temporary, the - line 444: // ^ TODO: Implement random access methods. - line 448: // ^ FIXME: This follows boost::make_zip_iterator's assumption that all unittests/BuildSystem/BuildSystemFrontendTest.cpp (3 lines): - line 47: // TODO Move this into some kind of libtestSupport? - line 413: // FIXME: This build graph triggers degenerate build behavior. Due to the - line 521: // FIXME: This is a good candidate for a 'long running' testing mode. Increase lib/BuildSystem/include/llbuild/BuildSystem/Command.h (3 lines): - line 37: // FIXME: This is currently commingled with the build file loading, even though - line 60: // FIXME: These probably don't belong here, clients generally can just manage - line 117: // FIXME: This feels awkward, maybe this isn't the right way to manage lib/llvm/Support/Signals.cpp (2 lines): - line 117: // FIXME: Subtract necessary number from StackTrace entries to turn return addresses - line 166: // FIXME: Make this the default for llvm-symbolizer. include/llvm/ADT/ilist.h (2 lines): - line 82: /// TODO: Remove this layer of indirection. It's not necessary. - line 186: // TODO: Drop this assertion and the transitive type traits anytime after lib/Core/include/llbuild/Core/BuildDB.h (2 lines): - line 83: // FIXME: This might be more efficient if it returns Result. - line 85: // FIXME: Figure out if we want a more lazy approach where we make the include/llvm/Support/YAMLParser.h (2 lines): - line 276: /// TODO: Consider making this not a child of Node. - line 390: // TODO: support skipping from the middle of a parsed collection ;/ lib/llvm/Support/Triple.cpp (2 lines): - line 383: // FIXME: Do we need to support these? - line 1562: // FIXME: this is invalid for WindowsCE lib/llvm/Support/Windows/Process.inc (2 lines): - line 53: // FIXME: FileOffset in MapViewOfFile() should be aligned to not dwPageSize, - line 185: // FIXME: This assumes the wildcard is only in the file name and not in the include/llvm/ADT/Hashing.h (2 lines): - line 326: // FIXME: This needs to be a per-execution seed. This is just a placeholder - line 344: // FIXME: We want to replace is_integral_or_enum and is_pointer here with lib/llvm/Demangle/MicrosoftDemangle.cpp (2 lines): - line 734: // FIXME: We should output this, but it requires updating lots of tests. - line 757: // FIXME: We should output this, but it requires updating lots of tests. include/llvm/Support/Compiler.h (2 lines): - line 150: // FIXME: Provide this for PE/COFF targets. - line 450: // FIXME: Move this to a private config.h as it's not usable in public headers. lib/llvm/Support/include/llvm/ADT/Twine.h (2 lines): - line 60: /// We maintain a number of invariants on Twine objects (FIXME: Why): - line 349: // FIXME: Unfortunately, to make sure this is as efficient as possible we lib/llvm/Support/include/llvm/ADT/iterator_range.h (2 lines): - line 36: //TODO: Add SFINAE to test that the Container's iterators match the range's - line 40: //TODO: Consider ADL/non-member begin/end calls. include/llbuild/Core/BuildDB.h (2 lines): - line 83: // FIXME: This might be more efficient if it returns Result. - line 85: // FIXME: Figure out if we want a more lazy approach where we make the lib/Basic/LaneBasedExecutionQueue.cpp (2 lines): - line 125: // FIXME: Consider trying to share this with the Ninja implementation. - line 420: // FIXME: This involves a lot of redundant allocation, currently. We could lib/llvm/Support/NativeFormatting.cpp (2 lines): - line 192: // FIXME: Implement our formatter to here or Support/Format.h! - line 194: // FIXME: It should be generic to C++11. lib/llvm/Support/APInt.cpp (2 lines): - line 393: // TODO - there is scope for optimization here, but at the moment this code - line 466: // FIXME: base 36 lib/llvm/Support/include/llvm/ADT/Hashing.h (2 lines): - line 326: // FIXME: This needs to be a per-execution seed. This is just a placeholder - line 344: // FIXME: We want to replace is_integral_or_enum and is_pointer here with lib/llvm/Support/include/llvm/Support/YAMLParser.h (2 lines): - line 276: /// TODO: Consider making this not a child of Node. - line 390: // TODO: support skipping from the middle of a parsed collection ;/ lib/llvm/Support/Unix/Signals.inc (2 lines): - line 69: // FIXME: We should be able to use for any target that has an - line 542: // FIXME: When we move to C++11, use %t length modifier. It's not in include/llbuild/BuildSystem/BuildSystem.h (2 lines): - line 108: // FIXME: This is a total hack, and should be cleaned up. - line 142: // FIXME: This API is now gross, there shouldn't be one generic status changed include/llvm/ADT/iterator_range.h (2 lines): - line 36: //TODO: Add SFINAE to test that the Container's iterators match the range's - line 40: //TODO: Consider ADL/non-member begin/end calls. include/llvm/ADT/Twine.h (2 lines): - line 60: /// We maintain a number of invariants on Twine objects (FIXME: Why): - line 349: // FIXME: Unfortunately, to make sure this is as efficient as possible we lib/BuildSystem/include/llbuild/BuildSystem/BuildSystem.h (2 lines): - line 108: // FIXME: This is a total hack, and should be cleaned up. - line 142: // FIXME: This API is now gross, there shouldn't be one generic status changed lib/llvm/Support/include/llvm/Support/SourceMgr.h (2 lines): - line 234: // FIXME: Twine.str() is not very efficient. - line 240: // FIXME: Twine.str() is not very efficient. lib/Basic/SerialQueue.cpp (2 lines): - line 42: // FIXME: Optimize. - line 289: // FIXME: This involves a lot of redundant allocation, currently. We could products/libllbuild/Core-C-API.cpp (2 lines): - line 74: // FIXME: Check that the client created the rule appropriately. We should - line 181: // FIXME: Delegate is lost. utils/ptreetime/ptreetime.py (2 lines): - line 366: # FIXME: Get utime and stime available here, and copy. - line 669: # FIXME: Quote arguments better. lib/BuildSystem/BuildSystemExtensionManager.cpp (2 lines): - line 76: // FIXME: Add a utility for capturing a subprocess infocation. - line 111: // FIXME: This needs to be reworked to go through a C API. lib/llvm/Support/ConvertUTFWrapper.cpp (2 lines): - line 36: // FIXME: Make the type of the result buffer correct instead of - line 49: // FIXME: Make the type of the result buffer correct instead of lib/llvm/Support/include/llvm/Support/Compiler.h (2 lines): - line 150: // FIXME: Provide this for PE/COFF targets. - line 450: // FIXME: Move this to a private config.h as it's not usable in public headers. lib/llvm/Support/include/llvm/ADT/ilist.h (2 lines): - line 82: /// TODO: Remove this layer of indirection. It's not necessary. - line 186: // TODO: Drop this assertion and the transitive type traits anytime after include/llvm/Support/SourceMgr.h (2 lines): - line 234: // FIXME: Twine.str() is not very efficient. - line 240: // FIXME: Twine.str() is not very efficient. include/llvm/ADT/ilist_iterator.h (1 line): - line 185: /// FIXME: remove this, since there is no implicit conversion to NodeTy. unittests/TestSupport/XCTestCase+Extensions.swift (1 line): - line 14: // FIXME: Move to a shared location. experimental/cevobuild/Sources/NinjaBuild/NinjaBuild.swift (1 line): - line 147: // FIXME: For now, we just merge all the inputs. This isn't lib/Commands/NinjaCommand.cpp (1 line): - line 425: // FIXME: Need llvm::sys::fs. products/ui/llbuildui/views.py (1 line): - line 114: # FIXME: We need to get back the dependents view, it was super useful. lib/llvm/Support/Hashing.cpp (1 line): - line 26: // FIXME: Use atomic operations here so that there is no data race. include/llvm/Support/Program.h (1 line): - line 168: /// FIXME: We use EM_CurrentCodePage to write response files for GNU tools in lib/Commands/CommandUtil.h (1 line): - line 37: // FIXME: Move all of these things to a real home. include/llvm/Support/CommandLine.h (1 line): - line 1408: // FIXME: Reduce this API to a more narrow subset of std::vector products/libllbuild/include/llbuild/ninja.h (1 line): - line 68: // TODO: Add the other special variables, ie. depsFile, rspFile, rspFileContent, unittests/CAPI/BuildSystem-C-API.cpp (1 line): - line 383: // FIXME: might be better to just fake the timestamp on the file include/llvm/ADT/SmallSet.h (1 line): - line 179: // FIXME: Add iterators that abstract over the small and large form, and then include/llvm/Config/abi-breaking.h (1 line): - line 35: // FIXME: Implement checks without weak. lib/llvm/Support/Debug.cpp (1 line): - line 145: // TODO: Add a handler for SIGUSER1-type signals so the user can include/llvm/ADT/Optional.h (1 line): - line 70: // FIXME: these assignments (& the equivalent const T&/const Optional& ctors) lib/Evo/EvoEngine.cpp (1 line): - line 207: inputs[inputID].second = value; // FIXME: avoid copying value ? include/llbuild/Core/AttributedKeyIDs.h (1 line): - line 27: // FIXME: At some point, figure out the optimal representation for this lib/Basic/include/llbuild/Basic/BinaryCoding.h (1 line): - line 50: // FIXME: Parameterize this size? include/llbuild/BuildSystem/BuildValue.h (1 line): - line 127: // FIXME: We are currently paying the cost for carrying this around on every lib/BuildSystem/include/llbuild/BuildSystem/BuildValue.h (1 line): - line 127: // FIXME: We are currently paying the cost for carrying this around on every include/llvm/Support/SmallVectorMemoryBuffer.h (1 line): - line 35: /// FIXME: It'd be nice for this to be a non-templated constructor taking a lib/llvm/Support/include/llvm/ADT/SmallSet.h (1 line): - line 179: // FIXME: Add iterators that abstract over the small and large form, and then include/llbuild/Basic/FileInfo.h (1 line): - line 16: // FIXME: I am ambivalent about this living in Basic, I want all non-functional include/llbuild/Basic/BinaryCoding.h (1 line): - line 50: // FIXME: Parameterize this size? products/llbuildSwift/Internals.swift (1 line): - line 43: // FIXME: We should eventually eliminate the need for this. lib/Commands/CommandLineStatusOutput.cpp (1 line): - line 169: // TODO: the long colored prefix output might mess with this logic: lib/llvm/Support/include/llvm/ADT/SmallString.h (1 line): - line 269: // TODO: Make this const, if it's safe... lib/llvm/Support/Error.cpp (1 line): - line 25: // FIXME: This class is only here to support the transition to llvm::Error. It lib/Commands/BuildSystemCommand.cpp (1 line): - line 714: // TODO - print build value lib/llvm/Support/Windows/Program.inc (1 line): - line 66: PathExts.push_back(".exe"); // FIXME: This must be in %PATHEXT%. products/libllbuild/BuildDB-C-API.cpp (1 line): - line 313: // TODO: Check if results were fetched lib/BuildSystem/BuildKey.cpp (1 line): - line 61: // FIXME: should probably dump filters here too lib/llvm/Support/include/llvm/Support/SmallVectorMemoryBuffer.h (1 line): - line 35: /// FIXME: It'd be nice for this to be a non-templated constructor taking a unittests/Basic/TempDir.h (1 line): - line 21: // TODO Move this into some kind of libtestSupport? lib/llvm/Support/include/llvm/Support/CommandLine.h (1 line): - line 1408: // FIXME: Reduce this API to a more narrow subset of std::vector perftests/Xcode/PerfTests/BuildSystemPerfTests.mm (1 line): - line 39: // FIXME: Raise proper error. include/llbuild/BuildSystem/ExternalCommand.h (1 line): - line 56: // FIXME: This is currently useful as a mechanism for defining builds in which include/llbuild/Basic/POSIXEnvironment.h (1 line): - line 50: // FIXME: This is not efficient, we could store into a single allocation. unittests/BuildSystem/TempDir.h (1 line): - line 21: // TODO Move this into some kind of libtestSupport? utils/import-llvm/include/llvm/Config/abi-breaking.h (1 line): - line 35: // FIXME: Implement checks without weak. include/llvm/Support/UnicodeCharRanges.h (1 line): - line 55: // FIXME: This could use constexpr + static_assert. This way we lib/llvm/Support/include/llvm/Support/MathExtras.h (1 line): - line 706: /// \todo FIXME: remove when \c constexpr becomes really \c constexpr products/ui/llbuildui/templates/db_rule_result.html (1 line): - line 13: