Summary: 107 instances, 96 unique Text Count // FIXME: This should write atomically. 1 // FIXME: deprecate 2/2021 (used below), remove once clients transitioned 1 // FIXME: Do we need to detect and remove watch for directories 1 // FIXME: It would be nice to avoid a per-instance lock, but this type isn't 1 // FIXME: This is very inefficient, we need a way to pass a buffer. It 1 // FIXME: This override shouldn't be necesary but removing it causes a 30% performance regression. This problem is 1 // FIXME: Kill this 1 // FIXME: Swift should provide shims for FD_ macros 1 // FIXME: This is inefficient; eventually, we want a way to do the 1 // FIXME: Because `ArgumentKindTy`` can't conform to `ArgumentKind`, this 1 // FIXME: deprecated 12/2020, remove once clients migrated over 1 // FIXME: This doesn't seem a particularly efficient way to do this. 2 // FIXME: We need extract information from the event mask and 1 // FIXME: This class does not yet support concurrent mutation safely. 1 /// FIXME: Using a single lock for this is a performance problem, but in 1 // FIXME: This is wasteful, we should be caching the PkgConfig result. 1 // FIXME: Maybe we should allow setting this when creating the fs. 1 // FIXME: Write precondition to ensure its called only once. 1 // FIXME: Write precondition to ensure this is called only once. 1 // FIXME: This looks inefficient. 1 // FIXME: Perhaps we should change the protocol to allow lazy behavior. 1 // FIXME: We should start again with remaining chunk but this doesn't work. Write everything for now. 1 // FIXME: We need to recurse here. 1 // FIXME: Convert to stack. 1 // FIXME: Check for int signal. 2 // FIXME: Always return false until in-memory implementation 1 // FIXME: Diagnose integers which cannot be represented in JSON. 1 // FIXME: What happens for NaN, etc.? 1 // FIXME: We should measure if it's really more efficient to compare the strings first. 1 // FIXME: This should check for invalid paths. 1 // FIXME: We need to remove the watches. 1 // FIXME: This should be constrained to ArgumentKind but Array can't conform 1 // FIXME: This method seems too complicated; it should be simplified, 3 // FIXME: We use this private environment variable hack to be able to 1 // FIXME: Write precondition to ensure its called after start() and once only. 1 // FIXME: This belongs somewhere else, but we don't have a layer specifically 1 // TODO: this is more of an error 1 // FIXME: This is obviously not a very efficient or flexible API. 3 // FIXME: There doesn't seem to be a way to create a string from an 1 // FIXME: We probably don't need this protocol anymore and should convert this to a class. 1 // FIXME: Report errors 1 // TODO: Rename this function to `init(string:usesLenientParsing:) throws`, after `init?(string: String)` is removed. 1 // FIXME: Once the minimum deployment target bumps to macOS 11, use 1 // FIXME: deprecate 2/2021, remove once clients transitioned 1 // FIXME: We should consider building a registry for all items in the 1 // FIXME: check expected length 2 // FIXME: This is probably not thread safe? 1 // FIXME: Determine the most efficient way to reassemble a string. 2 // FIXME: We should investigate if it would be more efficient to instead 1 // FIXME: This is all rather unfortunate and expensive. 1 // FIXME: This isn't particularly efficient; needs optimization, and 1 // FIXME: This should be factored out into a open error enum. 1 // FIXME: We should consider whether to merge the two `normalize()` functions. 1 // TODO: Find a better error-checking order. 1 // FIXME: This isn't right place to declare this, probably POSIX or merge with FileSystemError? 1 // FIXME: We need to free the buffer. 1 // FIXME: Eliminate or find a proper place for this. 1 // FIXME: deprecate 2/2021, remove once clients transitioned 2 // FIXME: This is only internal so it can be unit tested. 1 // FIXME: This is highly questionable. Aside from the performance of 1 // FIXME: We don't see pipe2 for some reason. 1 // FIXME: is it safe to dlclose() indexstore? If so, do that here. For now, let the handle leak. 1 // FIXME: Is Double.debugDescription the best representation? 1 // FIXME: This is unfortunate, see note w.r.t. the lock. 1 // FIXME: We should only construct a new string if anything changed. 1 // FIXME: Instead of string prefix comparison we should add a proper API 1 // FIXME: Find a better default behavior here. 1 // FIXME: The is needs to be optimized to avoid unncessary copying. 1 // FIXME: This should use a stack not recursion. 1 // FIXME: We should report this path separately. 1 // FIXME: We don't have these semantics in InMemoryFileSystem. 1 // FIXME: We should really be escaping backslashes and quotes here. 2 // FIXME: This wrapper could benefit from local static variables, in which case 1 public private(set) static var pkgConfigPaths: [AbsolutePath]? // FIXME: @testable(internal) 1 // FIXME: Actual file system interfaces will allow more efficient access to 1 // FIXME: Here we should also keep track of whether anything actually has 1 // FIXME: This will be copying bytes but we don't have option currently. 1 // FIXME: Should we error out instead if content is not UTF8 representable? 1 // FIXME: We might be able to make this more generic through the use of a "JSONEncodable" protocol. 2 // FIXME: Remove the macOS special-casing once the latest version of Xcode comes with 1 /// FIXME: This shouldn't use a static variable, since the first lookup 1 // FIXME: The directory paths are hard coded right now and should be replaced by --get-package-path 1 // FIXME: We can actually optimize that case, since we know that the 1 // TODO: this is more of an error 1 // FIXME: What should we do about NaN, etc.? 1 // FIXME: conditionalise these flags since SwiftPM 5.3 and earlier will crash 1 //FIXME: Migrate to DiagnosticFragmentBuilder 1 // FIXME: We can't use FileManager's destinationOfSymbolicLink because 1 // FIXME: We should use the new `CollectionDifference` API once the 1 // FIXME: We should probably do this async but then we need 1 // FIXME: Kill this 1 // FIXME: getDirectoryContents should have an iterator version. 1 // FIXME: Design an asynchronous story? 1 // FIXME: we need a runtime check as well since the library may have been built 1 // FIXME: We could easily include information on the cycle we found here. 1 // FIXME: Optimize? 1