src/main/java/org/apache/commons/net/ftp/parser/EnterpriseUnixFTPEntryParser.java (2 lines): - line 55: + "\\s*" // TODO should the space be optional? - line 56: // TODO \\d* should be \\d? surely ? Otherwise 01111 is allowed src/main/java/org/apache/commons/net/ftp/parser/UnixFTPEntryParser.java (2 lines): - line 73: + "\\s*" // separator TODO why allow it to be omitted?? - line 213: type = FTPFile.FILE_TYPE; // TODO change this if DEVICE_TYPE implemented src/main/java/org/apache/commons/net/ftp/parser/MLSxEntryParser.java (2 lines): - line 146: // TODO these are mostly just guesses at present - line 254: // TODO should this cause failure, or can it be reported somehow? src/main/java/org/apache/commons/net/ftp/FTPListParseEngine.java (2 lines): - line 122: public FTPFile[] getFiles() throws IOException // TODO remove; not actually thrown - line 140: public FTPFile[] getFiles(final FTPFileFilter filter) throws IOException // TODO remove; not actually thrown src/main/java/org/apache/commons/net/telnet/TelnetInputStream.java (2 lines): - line 32: // TODO should these be private enums? - line 557: // TODO remove this src/main/java/org/apache/commons/net/imap/IMAPReply.java (2 lines): - line 65: private static final String TAGGED_RESPONSE = "^\\w+ (\\S+).*"; // TODO perhaps be less strict on tag match? - line 92: if (m.matches()) { // TODO would lookingAt() be more efficient? If so, then drop trailing .* from patterns src/main/java/org/apache/commons/net/ftp/FTPFile.java (2 lines): - line 80: // TODO Consider changing internal representation to java.time. - line 342: // TODO: only allow permission setting if file is valid src/main/java/org/apache/commons/net/nntp/NntpThreadContainer.java (1 line): - line 48: // TODO convert this to an iterative function - this can blow the stack src/main/java/org/apache/commons/net/ftp/parser/VMSFTPEntryParser.java (1 line): - line 55: // TODO - perhaps restrict permissions to [RWED]* ? src/main/java/org/apache/commons/net/ftp/FTPReply.java (1 line): - line 24: * TODO replace with an enum src/main/java/org/apache/commons/net/util/ListenerList.java (1 line): - line 51: * @since 2.0 TODO Check that this is a good defensive strategy src/main/java/org/apache/commons/net/imap/IMAPSClient.java (1 line): - line 298: // TODO the following setup appears to duplicate that in the super class methods src/main/java/org/apache/commons/net/ftp/parser/MVSFTPEntryParser.java (1 line): - line 419: // TODO check this is ok src/main/java/org/apache/commons/net/ftp/parser/FTPTimestampParserImpl.java (1 line): - line 282: // TODO this won't always work for systems that use short dates +0/-12months src/main/java/org/apache/commons/net/telnet/TelnetOutputStream.java (1 line): - line 35: // TODO there does not appear to be any way to change this value - should it be a ctor parameter? src/main/java/org/apache/commons/net/nntp/Threader.java (1 line): - line 167: // TODO verify this will avoid rehashing src/main/java/org/apache/commons/net/io/FromNetASCIIInputStream.java (1 line): - line 66: // TODO - can we delete this override now? src/main/java/org/apache/commons/net/pop3/POP3SClient.java (1 line): - line 293: // TODO the following setup appears to duplicate that in the super class methods src/main/java/org/apache/commons/net/smtp/SMTPSClient.java (1 line): - line 302: // TODO the following setup appears to duplicate that in the super class methods src/main/java/org/apache/commons/net/ftp/parser/MacOsPeterFTPEntryParser.java (1 line): - line 140: type = FTPFile.FILE_TYPE; // TODO change this if DEVICE_TYPE implemented src/main/java/org/apache/commons/net/ftp/FTPSClient.java (1 line): - line 1023: // TODO the following setup appears to duplicate that in the super class methods src/main/java/org/apache/commons/net/ntp/TimeInfo.java (1 line): - line 168: // TODO: is offset still valid if rcvNtpTime=0 || xmitNtpTime=0 ???