npm/pkg/dataplane/dataplane.go (25 lines): - line 37: // TODO put NodeName in Config? - line 260: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 283: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 333: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 337: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 346: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 352: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 374: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 384: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 392: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 411: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 419: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 434: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 438: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 449: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 455: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 469: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 488: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 546: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 549: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 556: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 597: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 674: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 678: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 683: // TODO it would be ideal to calculate a diff of policies npm/pkg/controlplane/controllers/v2/podController.go (19 lines): - line 173: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 195: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 199: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 202: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 241: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 355: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 378: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 397: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 407: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 442: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 459: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 463: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 469: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 484: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 507: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 517: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 561: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 582: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 616: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level npm/pkg/dataplane/ipsets/ipsetmanager_linux.go (19 lines): - line 111: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 149: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 162: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 214: // TODO mark as a failure - line 229: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 279: // TODO mark the set as a failure and reconcile what iptables rule or ipset is referring to it - line 295: // TODO mark the set as a failure and reconcile what iptables rule or ipset is referring to it - line 459: creator := ioutil.NewFileCreator(iMgr.ioShim, maxTryCount, ipsetRestoreLineFailurePattern) // TODO make the line failure pattern into a definition constant eventually - line 508: creator := ioutil.NewFileCreator(iMgr.ioShim, maxTryCount, ipsetRestoreLineFailurePattern) // TODO make the line failure pattern into a definition constant eventually - line 571: // TODO send error snapshot - line 599: // TODO send error snapshot - line 627: // TODO send error snapshot - line 636: // TODO send error snapshot - line 676: // TODO check type based on maxelem for hash sets? CIDR blocks have a different maxelem - line 726: // TODO mark as a failure - line 743: // TODO mark the set as a failure and reconcile what iptables rule or ipset is referring to it - line 779: // TODO mark the set as a failure and handle this - line 787: // TODO same as above error handler - line 828: // TODO reconcile zapai/encoder.go (19 lines): - line 78: // TODO to be implemented - line 83: // TODO to be implemented - line 87: // TODO to be implemented - line 91: // TODO to be implemented - line 95: // TODO to be implemented - line 99: // TODO to be implemented - line 103: // TODO to be implemented - line 107: // TODO to be implemented - line 111: // TODO to be implemented - line 115: // TODO to be implemented - line 119: // TODO to be implemented - line 123: // TODO to be implemented - line 127: // TODO to be implemented - line 131: // TODO to be implemented - line 135: // TODO to be implemented - line 139: // TODO to be implemented - line 143: // TODO to be implemented - line 147: // TODO to be implemented - line 152: // TODO to be implemented npm/pkg/controlplane/controllers/v2/namespaceController.go (12 lines): - line 167: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 173: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 176: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 215: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 328: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 352: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 382: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 399: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 433: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 439: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 448: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 457: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level npm/pkg/controlplane/controllers/v1/translatePolicy.go (9 lines): - line 80: // TODO check this func references and change the label and op logic - line 114: // TODO need to change this logic, create a list of lsts here and have a single match against it - line 153: // TODO doubt check if this 2nd level needs to be added to the labels when labels are added to lists - line 184: // TODO check if we are missing any crucial comment - line 379: // TODO move IP cidrs rule to allow based only - line 613: // TODO check old code if we need any ns- prefix for pod selectors - line 621: // TODO check this if ns- is needed here. - line 1029: // TODO move IP cidrs rule to allow based only - line 1276: // TODO check if the ns- is needed here ? npm/pkg/dataplane/ipsets/ipsetmanager.go (7 lines): - line 96: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 312: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 458: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 463: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 480: // TODO could also set the number of ipsets in NPM (not necessarily in kernel) here using len(iMgr.setMap) - line 526: TODO kernel-based prometheus metrics - line 549: TODO kernel-based prometheus metrics cni/network/network.go (6 lines): - line 453: addSnatInterface(nwCfg, cniResult) //nolint TODO: check whether Linux supports adding secondary snatinterface - line 588: // TODO: This proably needs to be changed as we return all interfaces... - line 647: // TODO: should this statement be based on the current iteration instead of the constant ifIndex? - line 648: // TODO figure out where to put telemetry: sendEvent(plugin, fmt.Sprintf("CNI ADD succeeded: IP:%+v, VlanID: %v, podname %v, namespace %v numendpoints:%d", - line 850: endpointInfo.IPV6Mode = string(util.IpamMode(opt.nwCfg.IPAM.Mode)) // TODO: check IPV6Mode field can be deprecated and can we add IsIPv6Enabled flag for generic working - line 967: // TODO: Ideally we should return from here only. npm/pkg/dataplane/policies/policymanager_linux.go (5 lines): - line 140: creator := ioutil.NewFileCreator(pMgr.ioShim, maxTryCount, knownLineErrorPattern, unknownLineErrorPattern) // TODO pass an array instead of this ... thing - line 148: // TODO remove sections if we never use section-based error handling (e.g. remove the whole section) - line 234: creator.AddLine("", nil, ingressJumpSpecs...) // TODO error handler - line 239: creator.AddLine("", nil, egressJumpSpecs...) // TODO error handler - line 270: creator.AddLine("", nil, line...) // TODO add error handler npm/pkg/dataplane/policies/policymanager_windows.go (4 lines): - line 354: // FIXME rulesToRemove is a list of pointers - line 419: // FIXME epBuilder.aclPolicies is a list of pointers - line 472: // FIXME a lot of prints - line 495: // TODO need some retry mechanism to check why the translations failed npm/pkg/dataplane/types.go (4 lines): - line 147: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 161: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 182: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 214: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level network/manager.go (4 lines): - line 43: // TODO: Remove dummy GUID and come up with more permanent solution - line 109: EndpointCreate(client apipaClient, epInfos []*EndpointInfo) error // TODO: change name - line 456: // TODO unit tests need to be added, WorkItem: 26606939 - line 540: IfName: epInfo.IfName, // TODO: For stateless cni linux populate IfName here to use in deletion in secondary endpoint client npm/pkg/controlplane/controllers/v2/networkPolicyController.go (4 lines): - line 151: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 155: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 158: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level - line 196: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level npm/util/ioutil/restore.go (4 lines): - line 36: // TODO ideas: - line 163: // TODO conditionally specify as retriable? - line 180: // TODO return another bool that specifies if there was a file-level retriable error? - line 188: // TODO: Refactor non-error/warning klogs with Zap and set the following logs to "debug" level cni/network/invoker_cns.go (3 lines): - line 190: // TODO: check whether setting default route on IB interface - line 396: // TODO: Remove v4overlay and dualstackoverlay options, after 'overlay' rolls out in AKS-RP - line 465: // TODO: Remove v4overlay and dualstackoverlay options, after 'overlay' rolls out in AKS-RP npm/pkg/dataplane/policies/policy.go (3 lines): - line 20: // TODO get rid of PodSelectorIPSets in favor of PodSelectorList (exact same except need to add members field to SetInfo) - line 25: // TODO change to slice of pointers - line 346: // TODO: Need to remove this dependency on case-sensitivity. cns/service/main.go (3 lines): - line 1017: // TODO: we will deprecated -c option in next phase and start local server in any case - line 1284: // TODO: do we need this to be running? - line 1575: // TODO: add pod listeners based on Swift V1 vs MT/V2 configuration npm/pkg/controlplane/goalstateprocessor/goalstateprocessor.go (3 lines): - line 73: // TODO benchmark how many events can stay in pipeline as we work - line 76: // TODO remove this large print later - line 83: // TODO remove this large print later cns/NetworkContainerContract.go (2 lines): - line 70: // TODO: Add OrchastratorType as CRD: https://msazure.visualstudio.com/One/_workitems/edit/7711872 - line 91: // TODO: These two const are currently unused due to version compatibility with DNC. DelegatedVMNIC and NodeNetworkInterfaceBackendNIC should be renamed to align with the naming convention with DNC npm/pkg/dataplane/policies/policy_linux.go (2 lines): - line 108: // TODO remove the if check and initialize the list like in egress once we replace SrcList and DstList with PeerList - line 125: // TODO remove the if check once we replace SrcList and DstList with PeerList cns/middlewares/k8sSwiftV2_windows.go (2 lines): - line 32: // TODO: Remove this once HNS fix is ready - line 234: // TODO: add ipv6 when supported cns/restserver/ipam.go (2 lines): - line 138: // TODO: we need another way to verify and sync NMAgent's NIC programming status. pending new NMAgent API or NIC programming status to be passed in the SwiftV2 create NC request. - line 624: // TODO: Add a change so that we should only update the current state if it is different than the new state npm/ipsm/ipsm.go (2 lines): - line 393: // TODO make sure these are info and not errors, use NPmErr - line 560: // TODO optimize to not run this command in case cache has already been updated. npm/pkg/dataplane/dataplane_windows.go (2 lines): - line 122: // TODO once we make endpoint refreshing smarter, it would be most efficient to use allEndpoints to refreshPodEndpoints here. - line 251: 3. FIXME: If a policy is/was just removed, but the ipset's selector hasn't been updated yet, cns/restserver/util.go (2 lines): - line 442: // TODO: Add telemetry as this has potential to have containers in the running state w/o datapath working - line 763: // TODO - Add for SecondaryIPs (Task: https://msazure.visualstudio.com/One/_workitems/edit/7711831) npm/metrics/ipsets.go (2 lines): - line 48: // TODO might be more efficient to keep track of the count - line 120: // TODO could use the map if this function needs to be faster. cns/deviceplugin/plugin.go (1 line): - line 113: conn, err := grpc.Dial(p.kubeletSocket, grpc.WithTransportCredentials(insecure.NewCredentials()), //nolint:staticcheck // TODO: Move to grpc.NewClient method npm/cacheencoder.go (1 line): - line 32: // TODO test v2 NPM debug API when it's implemented platform/os_windows.go (1 line): - line 69: // TODO: can we replace this (and things in endpoint_windows) with other utils from "golang.org/x/sys/windows"? netlink/netlink_linux.go (1 line): - line 19: // TODO do we need this function? npm/pkg/dataplane/policies/policy_windows.go (1 line): - line 85: // TODO need to have better priority handling npm/pkg/dataplane/policies/testutils.go (1 line): - line 5: // TODO: deprecate this file. Updating this file impacts multiple tests. npm/pkg/dataplane/parse/parser.go (1 line): - line 69: // TODO: need to get iptable's lock ovsctl/ovsctl.go (1 line): - line 38: // TODO: remove this interface after platform calls are mocked npm/pkg/dataplane/policies/chain-management_linux.go (1 line): - line 185: TODO: could use one grep call instead of separate calls for getting jump line nums and for getting deprecated chains and old v2 policy chains npm/pkg/dataplane/ipsets/testutils.go (1 line): - line 5: // TODO deprecate the TestSet type and replace TestNSSet etc. with just their metadata npm/config/config_linux.go (1 line): - line 6: // GetConfigPath TODO: solidify config paths npm/iptm/ioshim_fake.go (1 line): - line 31: // TODO: we can use this method down the road for testing iptables restore cns/deviceplugin/server.go (1 line): - line 67: c, err := grpc.DialContext(ctx, s.address, grpc.WithTransportCredentials(insecure.NewCredentials()), grpc.WithBlock(), //nolint:staticcheck // TODO: Move to grpc.NewClient method npm/cmd/start_daemon.go (1 line): - line 76: // TODO Daemon should implement cache encoder npm/iptm/iptm.go (1 line): - line 229: // TODO Adding this chain is printing error messages try to clean it up cni/network/invoker_azure.go (1 line): - line 116: // TODO: changed how host subnet prefix populated (check) npm/cmd/convertiptable.go (1 line): - line 15: iptableName, _ := cmd.Flags().GetString("table") // TODO this isn't an argument right now cns/common/service.go (1 line): - line 50: EnableLocalServer bool // TODO: Remove this flag once -c option gets deprecated npm/pkg/models/consts.go (1 line): - line 7: // TODO: consider increasing thread number later when logics are correct cns/hnsclient/hnsclient_windows.go (1 line): - line 20: // TODO redesign hnsclient on windows npm/pkg/dataplane/ipsets/ipsetmanager_windows.go (1 line): - line 284: // TODO we should add members first and then the Lists common/config.go (1 line): - line 141: // OptCNIConflistFilepathAlias TODO: a "shorthand" is required for the acn args package but this isn't helpful npm/metrics/prometheus-metrics.go (1 line): - line 157: // TODO consider refactoring the functionality of the metrics package into a "Metrics" struct with methods (this would require code changes throughout npm). network/hnswrapper/hnsv2wrapperfake.go (1 line): - line 574: // FIXME should include RuleType too, but that will require updating every instance of this struct in UTs npm/pkg/controlplane/translation/parseSelector.go (1 line): - line 206: // TODO: good to remove this dependency later if possible. network/transparent_vlan_endpointclient_linux.go (1 line): - line 659: // TODO: revist if this require in future. network/endpoint_windows.go (1 line): - line 358: // TODO: this code is duplicated in cns/hnsclient, but that code has logging messages that require a CNSLogger, cni/network/network_windows.go (1 line): - line 386: // TODO: Remove v4overlay and dualstackoverlay options, after 'overlay' rolls out in AKS-RP cns/restserver/api.go (1 line): - line 44: // TODO: break it even further per module (network, nc, etc) like it is done for ipam npm/pkg/controlplane/translation/translatePolicy.go (1 line): - line 66: // TODO (jungukcho): check whether this can be possible or not. cns/fakes/cnsfake.go (1 line): - line 268: // TODO: Populate on scale down network/secondary_endpoint_client_linux.go (1 line): - line 190: // TODO: For stateless cni linux, check if delegated vmnic type, and if so, delete using this *endpoint* struct's ifname npm/config/config_windows.go (1 line): - line 6: // GetConfigPath TODO: solidify config paths netlink/link_linux.go (1 line): - line 360: // TODO do we need this function, not used anywhere currently cns/restserver/restserver.go (1 line): - line 134: // TODO: add json tags for this struct as per linter suggestion, ignored for now as part of revert-PR network/endpoint_linux.go (1 line): - line 546: // TODO: It needs to be tested to see if HostVethName is required for SingleTenancy, WorkItem: 26606939 npm/pkg/dataplane/ipsets/ipset.go (1 line): - line 45: // TODO join with colon instead of dash for easier readability?