eng/spotbugs/spotbugs-excludes.xml

<?xml version="1.0" encoding="UTF-8"?>
<FindBugsFilter xmlns="https://github.com/spotbugs/filter/4.8.4"
                xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
  xsi:schemaLocation="https://github.com/spotbugs/filter/4.8.4 https://raw.githubusercontent.com/spotbugs/spotbugs/4.8.4/spotbugs/etc/findbugsfilter.xsd">

  <!-- This was written a while ago and the byte shifts work for outputting the data. -->
  <Match>
    <Class name="com.microsoft.azure.proton.transport.ws.impl.WebSocketHandlerImpl"/>
    <Method name="wrapBuffer"/>
    <Bug pattern="ICAST_BAD_SHIFT_AMOUNT"/>
  </Match>

  <!-- We want to be explicit about the WebSocket payload length because the RFC specifies these ranges. -->
  <Match>
    <Class name="com.microsoft.azure.proton.transport.ws.impl.WebSocketHandlerImpl"/>
    <Method name="unwrapBuffer"/>
    <Bug pattern="UC_USELESS_CONDITION"/>
  </Match>

  <!-- It is not needed to make this inner class into a static one. Requires more refactoring than needed. -->
  <Match>
    <Class name="com.microsoft.azure.proton.transport.ws.impl.WebSocketImpl$WebSocketSnifferTransportWrapper"/>
    <Bug pattern="SIC_INNER_SHOULD_BE_STATIC_NEEDS_THIS"/>
  </Match>

  <!-- TODO (conniey): https://github.com/Azure/qpid-proton-j-extensions/issues/42 -->
  <Match>
    <Class name="com.microsoft.azure.proton.transport.proxy.impl.ProxyImpl"/>
    <Method name="writeProxyRequest" />
    <Bug pattern="DM_DEFAULT_ENCODING"/>
  </Match>

  <!-- TODO (conniey): https://github.com/Azure/qpid-proton-j-extensions/issues/43 -->
  <Match>
    <Class name="com.microsoft.azure.proton.transport.ws.impl.WebSocketImpl"/>
    <Method name="writeUpgradeRequest"/>
    <Bug pattern="DM_DEFAULT_ENCODING"/>
  </Match>

  <!-- Proxy is an immutable class. -->
  <Match>
    <Class name="com.microsoft.azure.proton.transport.proxy.ProxyConfiguration"/>
    <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2"/>
  </Match>

  <Match>
    <Class name="com.microsoft.azure.proton.transport.proxy.impl.BasicProxyChallengeProcessorImpl"/>
    <Method name="getHeader" />
    <Bug pattern="EI_EXPOSE_REP" />
  </Match>

  <Match>
    <Class name="com.microsoft.azure.proton.transport.proxy.impl.DigestProxyChallengeProcessorImpl"/>
    <Method name="getHeader" />
    <Bug pattern="EI_EXPOSE_REP" />
  </Match>

  <Match>
    <Class name="com.microsoft.azure.proton.transport.proxy.impl.ProxyImpl"/>
    <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2"/>
  </Match>

  <Match>
    <Class name="com.microsoft.azure.proton.transport.proxy.impl.ProxyResponseImpl"/>
    <Or>
      <Method name="getHeaders" />
      <Method name="getContents" />
    </Or>
    <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_BUF"/>
  </Match>

  <Match>
    <Class name="com.microsoft.azure.proton.transport.ws.impl.WebSocketImpl"/>
    <Bug pattern="EI_EXPOSE_REP,EI_EXPOSE_REP2" />
  </Match>

  <Match>
    <Class name="com.microsoft.azure.proton.transport.ws.impl.WebSocketUpgrade"/>
    <Bug pattern="EI_EXPOSE_REP2" />
  </Match>
</FindBugsFilter>