prod/native/libcommon/code/ConfigurationManager.h (6 lines): - line 42: //TODO default unit? - line 43: //TODO sign - line 61: //TODO class might be used in different threads, right now it is pretty safe as log is attached on globals init (for zts it should be in minit) - line 66: //TODO lock - line 69: //TODO lock - line 84: //TODO test prod/native/extension/code/InternalFunctionInstrumentation.cpp (3 lines): - line 139: //TODO consider refs - line 301: //TODO if called from other place that MINIT - make it thread safe in ZTS - line 302: //TODO use hash struct instead of combined to prevent collisions prod/native/libcommon/code/os/OsUtils.cpp (2 lines): - line 52: // TODO implement GetCommandLineW - line 60: // TODO implement GetCommandLineW prod/native/extension/code/ModuleEntry.cpp (2 lines): - line 87: //TODO for ZTS logger must be initialized in MINIT! (share fd between threads) - different lifecycle - line 89: //TODO store in globals and allow watch for config change (change of level) prod/native/building/cmake/elastic_set_default_build_options.cmake (2 lines): - line 70: "-Wno-ignored-qualifiers" #TODO php headers issues, should be removed and patched in conan package - line 73: "-Wno-enum-compare" #TODO refactor code and remove prod/native/extension/code/ModuleFunctions.cpp (2 lines): - line 124: //TODO elasticApmGetLastThrown(/* out */ return_value); - line 135: //TODO elasticApmGetLastPhpError(/* out */ return_value); prod/native/libcommon/code/RequestScope.h (1 line): - line 85: // TODO log supportability info prod/native/extension/code/ForkHandler.cpp (1 line): - line 34: // TODO implement forkable registry prod/native/libcommon/code/Logger.cpp (1 line): - line 219: //TODO note, in case of fork each worker can have different fd (and different log name) opened. Consided shm sync. prod/native/libcommon/code/InternalFunctionInstrumentationStorage.h (1 line): - line 30: //TODO sync for ZTS, need to be pure global for ZTS, doesnt need to be global for NTS prod/native/libphpbridge/code/AutoZval.h (1 line): - line 179: AutoZval callMethod(std::string_view methodName, std::array params = {}) const { // TODO const? can modify object prod/native/libcommon/code/ConfigurationManager.cpp (1 line): - line 139: //TODO lock prod/native/libphpbridge/code/OtlpExporter/MetricConverter.h (1 line): - line 92: out->set_schema_url(schemaUrl.getStringView()); // TODO ??? no value at all or empty string? (in php null is casted to empty string) prod/native/libcommon/code/CommonUtils.cpp (1 line): - line 100: //TODO handle other string types