The distribution of size of units (measured in lines of code).
Intro
Unit size measurements show the distribution of size of units of code (methods, functions...).
Units are classified in four categories based on their size (lines of code): 1-20 (small units), 20-50 (medium size units), 51-100 (long units), 101+ (very long units).
You should aim at keeping units small (< 20 lines). Long units may become "bloaters", code that have increased to such gargantuan proportions that they are hard to work with.
"If you have to spend effort into looking at a fragment of code to figure out what it's doing, then you should extract it into a function and name the function after that 'what'."
"Use common sense, stick to small function sizes in most instances but don't be dogmatic about it if you have a genuinely good reason to make an unusually big function."
"All other things being equal, a shorter method is easier to read, easier to understand, and easier to troubleshoot. Refactor long methods into smaller methods if you can."
"The first rule of functions is that they should be small. The second rule of functions is that they should be smaller than that. Functions should not be 100 lines long. Functions should hardly ever be 20 lines long."
Unit Size Overall
There are 465 units with 3,399 lines of code in units (42.2% of code).
override suspend fun load() in PagingWithNetworkSample/app/src/main/java/com/android/example/paging/pagingwithnetwork/reddit/repository/inDb/PageKeyedRemoteMediator.kt
43
5
2
override fun run() in GithubBrowserSample/app/src/main/java/com/android/example/github/repository/FetchNextSearchPageTask.kt
40
4
0
public void setProductList() in BasicSample/app/src/main/java/com/example/android/persistence/ui/ProductAdapter.java
33
5
1
override fun onChanged() in GithubBrowserSample/app/src/main/java/com/android/example/github/ui/search/SearchViewModel.kt
30
2
1
fun updateFromCombinedLoadStates() in PagingWithNetworkSample/lib/src/main/java/com/android/example/paging/pagingwithnetwork/reddit/paging/LoadStatesMerger.kt
29
1
1
override fun doWork() in WorkManagerSample/lib/src/main/java/com/example/background/workers/UploadWorker.kt
29
4
0
override fun onCreate() in WorkManagerSample/app/src/main/java/com/example/background/SelectImageActivity.kt
28
2
1
override fun onCreate() in WorkManagerMultiprocessSample/app/src/main/java/com/example/background/multiprocess/MainActivity.kt
27
1
1
void getUser() in PersistenceMigrationsSample/app/src/sqlite/java/com/example/android/persistence/migrations/UserRepository.java
24
3
1
void getUser() in PersistenceMigrationsSample/app/src/room3/java/com/example/android/persistence/migrations/UserRepository.java
24
3
1
void updateUserName() in PersistenceMigrationsSample/app/src/room3/java/com/example/android/persistence/migrations/UserRepository.java
23
3
2
override fun onViewCreated() in GithubBrowserSample/app/src/main/java/com/android/example/github/ui/repo/RepoFragment.kt
22
1
2
public User getUser() in PersistenceMigrationsSample/app/src/sqlite/java/com/example/android/persistence/migrations/LocalUserDataSource.java
22
5
0
void updateUserName() in PersistenceMigrationsSample/app/src/sqlite/java/com/example/android/persistence/migrations/UserRepository.java
22
3
2
fun create() in GithubBrowserSample/app/src/main/java/com/android/example/github/api/ApiResponse.kt
override fun applyFilter() in WorkManagerSample/lib/src/main/java/com/example/background/workers/filters/GrayScaleFilterWorker.kt
21
1
1
override fun applyFilter() in WorkManagerSample/lib/src/main/java/com/example/background/workers/filters/WaterColorFilterWorker.kt
21
1
1
public Cursor query() in PersistenceContentProviderSample/app/src/main/java/com/example/android/contentprovidersample/provider/SampleContentProvider.java
21
5
5
override fun onCreateView() in GithubBrowserSample/app/src/main/java/com/android/example/github/ui/user/UserFragment.kt