pkg/experimental/workload/controller.go (7 lines): - line 95: // TODO: Implement ping for controller - line 251: // TODO: Need to skip processing if only Heartbeat/Ping timestamp changes, but the status does not. - line 257: // TODO: fix this - line 288: // TODO: Use selector instaed of name to select endpointslices - line 295: // TODO: fix this - line 301: // TODO: Consider Ready conditions of the workloads before putting them into the EndpointSlice. - line 371: // TODO: Find a better way to compare these pkg/controller/controller.go (4 lines): - line 66: // TODO: Watch secrets - line 358: // TODO: Only lock per resource - line 437: // TODO: Remove this after deprecation - line 728: // TODO: this path should be removed when external certificate managers migrate to a better solution. pkg/loadbalancers/features/features.go (4 lines): - line 17: // TODO: (shance) this file should ideally be combined with backends/features - line 60: // TODO: (shance) refactor scope to be per-resource - line 137: // TODO: (shance) refactor scope to be per-resource - line 150: // TODO: (shance) refactor scope to be per-resource pkg/backends/backends.go (3 lines): - line 186: // TODO: Include port, ip in the status, since it's in the health info. - line 187: // TODO (shance) convert to composite types - line 221: // TODO: for consistency with the rest of this sub-package this method pkg/translator/healthchecks.go (3 lines): - line 68: // TODO: revendor the GCE API go client so that this error will not be hit. - line 296: // TODO: what if the port changes? - line 297: // TODO: does not handle protocol? pkg/neg/manager.go (3 lines): - line 75: // TODO: lock per service instead of global lock - line 465: // TODO: avoid race condition here - line 509: // TODO: avoid race condition here pkg/composite/meta/meta.go (3 lines): - line 57: // TODO: (shance) Replace this with data gathered from meta.AllServices - line 83: // TODO: This should be a list, not a map so the generated code ordering is stable - line 92: // TODO (shance) Replace this with data gathered from meta.AllServices or discovery doc pkg/backends/features/features.go (3 lines): - line 49: // TODO: (shance) refactor all scope to be above the serviceport level - line 92: // TODO: (shance) refactor all scope to be above the serviceport level - line 118: // TODO: (shance) refactor all scope to be above the serviceport level pkg/backends/ig_linker.go (2 lines): - line 61: // TODO: Should this be math.MaxInt64? - line 162: // TODO: Set utilization and connection limits when we accept them pkg/l4lb/l4controller.go (2 lines): - line 133: // TODO enhance this by looking at some metric from service controller to ensure it is up. - line 148: // TODO return error here pkg/instances/interfaces.go (2 lines): - line 37: // TODO: Refactor for modularity - line 52: // TODO: Refactor for modulatiry. pkg/composite/metrics/metrics.go (2 lines): - line 87: Name: "gce_api_request_duration_seconds", // TODO: (shance) reconcile with cloudprovider - line 94: Name: "gce_api_request_errors", // TODO: (shance) reconcile with cloudprovider pkg/neg/types/mock.go (2 lines): - line 63: // TODO: move this logic into code gen - line 64: // TODO: make AggregateList return map[meta.Key]Object pkg/loadbalancers/forwarding_rules.go (2 lines): - line 135: // TODO: If the port range and protocol don't match, recreate the rule - line 171: // TODO: Handle the last case better. pkg/utils/namer/namer.go (2 lines): - line 40: // TODO: this should really be "fr" and "frs". - line 345: // TODO: Pipe the clusterName through, for now it saves code churn cmd/e2e-test/upgrade/basic_http.go (1 line): - line 105: // TODO: does the path need to be different for each upgrade pkg/experimental/apis/workload/register.go (1 line): - line 20: // TODO: Change group name to discovery.k8s.io after KEP is approved pkg/experimental/workload/daemon/daemon.go (1 line): - line 108: // TODO: The following options are considered: cmd/glbc/app/handlers.go (1 line): - line 57: // TODO: Better retries than relying on restartPolicy. pkg/experimental/metadata/metadata.go (1 line): - line 21: // TODO: this is copied from "cloud.google.com/go/compute/metadata" pkg/neg/types/cloudprovideradapter.go (1 line): - line 70: // TODO: filter for the region the cluster is in. pkg/loadbalancers/l7.go (1 line): - line 486: // TODO: We really want to know *when* a backend flipped states. pkg/storage/configmaps.go (1 line): - line 153: // TODO: Implement all the other store methods and make this a write pkg/instances/fakes.go (1 line): - line 55: // TODO: evolve as required, it's currently needed just to satisfy the pkg/neg/syncers/utils.go (1 line): - line 275: // TODO: This check and EndpointsData.Ready field may be deleted once Endpoints support is removed. cmd/404-server/server.go (1 line): - line 73: // TODO: this handler exists only to avoid breaking existing deployments pkg/experimental/apis/workload/v1alpha1/doc.go (1 line): - line 16: // TODO: Change group name to discovery.k8s.io after approved pkg/backends/syncer.go (1 line): - line 251: // TODO: (shance) add unit tests pkg/apis/svcneg/v1beta1/types.go (1 line): - line 83: // TODO: Replace Condition with standard Condition pkg/healthchecks/healthchecks.go (1 line): - line 66: // TODO: rename backend-service and health-check to not use port as key pkg/experimental/workload/client/informers/externalversions/generic.go (1 line): - line 52: // TODO extend this to unknown resources with a client pool pkg/healthchecks/interfaces.go (1 line): - line 31: // TODO: (shance) convert this to use composite types pkg/loadbalancers/url_maps.go (1 line): - line 41: // TODO: (shance) refactor this so we don't need an empty arg pkg/ingparams/client/informers/externalversions/generic.go (1 line): - line 52: // TODO extend this to unknown resources with a client pool pkg/svcneg/client/informers/externalversions/generic.go (1 line): - line 52: // TODO extend this to unknown resources with a client pool pkg/controller/translator/translator.go (1 line): - line 405: // TODO: Make this more resilient to label changes by listing pkg/firewalls/firewalls.go (1 line): - line 127: // TODO: Currently only used in testing. Modify so we don't leak compute pkg/experimental/apis/workload/v1alpha1/types.go (1 line): - line 74: // TODO: Use standardized conditions (KEP-1623) cmd/glbc/main.go (1 line): - line 309: // TODO: Refactor NEG to use cloud mocks so ctx.Cloud can be referenced within NewController. pkg/frontendconfig/client/informers/externalversions/generic.go (1 line): - line 52: // TODO extend this to unknown resources with a client pool pkg/loadbalancers/certificates.go (1 line): - line 150: // TODO: (shance) refactor this so we don't need an empty arg pkg/neg/controller.go (1 line): - line 142: // TODO: move event recorder initializer to main. Reuse it among controllers. pkg/composite/utils.go (1 line): - line 33: // TODO: (shance) implement zonal cmd/workload-controller/main.go (1 line): - line 88: // TODO: Leader Elect and Health Check? pkg/annotations/service.go (1 line): - line 304: // TODO: add link to Expose NEG documentation when complete pkg/backendconfig/client/informers/externalversions/generic.go (1 line): - line 53: // TODO extend this to unknown resources with a client pool pkg/neg/utils.go (1 line): - line 42: // TODO: also validate ServicePorts in the exposed NEG annotation via webhook pkg/l4lb/ports.go (1 line): - line 51: // TODO: Should we check name? (In theory, an LB could expose it) pkg/serviceattachment/client/informers/externalversions/generic.go (1 line): - line 53: // TODO extend this to unknown resources with a client pool pkg/loadbalancers/features/l7ilb.go (1 line): - line 34: // TODO: (shance) refactor to use filter cmd/glbc/app/clients.go (1 line): - line 113: // TODO: why do we bail with success out if there is a permission error??? pkg/utils/common/finalizer.go (1 line): - line 35: // TODO remove the 2 definitions once they are added in legacy-cloud-providers/gce