Places in code with 6 or more lines that are exactly the same.
Intro
- For duplication, we look at places in code where there are 6 or more lines of code that are exactly the same.
- Before duplication is calculated, the code is cleaned to remove empty lines, comments, and frequently duplicated constructs such as imports.
- You should aim at having as little as possible (<5%) of duplicated code as high-level of duplication can lead to maintenance difficulties, poor factoring, and logical contradictions.
- To learn more about duplications and techniques for eliminating duplication, Sokrates recommends the following resources:
- Avoid Repetition, MartinFlower.com (IEEE Software article)
- Refactoring duplicated code, sourcemaking.com
- Beck Design Rules, MartinFowler.com
- DRY (Don't Repeat Yourself) Principle, Wikipedia
- The Cut-and-Paste Programming Software Development Anti-Pattern, sourcemaking.com
- Code Smells / Duplicated Code, Jeff Atwood, codinghorror.com:
- "Duplicated code is the bane of software development. Stamp out duplication whenever possible. You should always be on the lookout for more subtle cases of near-duplication, too. Don't Repeat Yourself!"
- Reducing Coupling, MartinFlower.com (IEEE Software article):
- "There are several ways to describe coupling, but it boils down to this: If changing one module in a program requires changing another module, then coupling exists. ... Duplication always implies coupling, because changing one piece of duplicate code implies changing the other."
Duplication Overall
- 17% duplication:
- 28,190 cleaned lines of cleaned code (without empty lines, comments, and frequently duplicated constructs such as imports)
- 4,893 duplicated lines
- 927 duplicates
Duplication per Extension
Duplication per Component (primary)
Duplication Between Components (50+ lines)
Open 3D force graph...
Show more details on duplication between components...
From Component
--> To Component
Duplicated
Lines
File Pairs
Details
pkg/apis (10%)
--> pkg/experimental (19%)
666
17 file pairs
details...
pkg/frontendconfig (44%)
--> pkg/svcneg (44%)
448
10 file pairs
details...
pkg/ingparams (47%)
--> pkg/svcneg (43%)
440
10 file pairs
details...
pkg/frontendconfig (43%)
--> pkg/ingparams (47%)
436
10 file pairs
details...
pkg/backendconfig (20%)
--> pkg/serviceattachment (25%)
426
17 file pairs
details...
pkg/serviceattachment (25%)
--> pkg/svcneg (41%)
417
11 file pairs
details...
pkg/frontendconfig (41%)
--> pkg/serviceattachment (25%)
417
11 file pairs
details...
pkg/ingparams (43%)
--> pkg/serviceattachment (24%)
399
11 file pairs
details...
pkg/backendconfig (18%)
--> pkg/frontendconfig (38%)
381
11 file pairs
details...
pkg/backendconfig (18%)
--> pkg/svcneg (37%)
381
11 file pairs
details...
pkg/experimental (11%)
--> pkg/serviceattachment (22%)
373
11 file pairs
details...
pkg/backendconfig (18%)
--> pkg/experimental (11%)
373
11 file pairs
details...
pkg/backendconfig (17%)
--> pkg/ingparams (39%)
363
11 file pairs
details...
pkg/experimental (10%)
--> pkg/svcneg (33%)
342
8 file pairs
details...
pkg/experimental (10%)
--> pkg/frontendconfig (34%)
342
8 file pairs
details...
pkg/experimental (9%)
--> pkg/ingparams (35%)
330
8 file pairs
details...
cmd/glbc (6%)
--> cmd/workload-controller (56%)
62
2 file pairs
details...
| From Component --> To Component |
Duplicated Lines |
File Pairs | Details |
|---|---|---|---|
| pkg/apis (10%) --> pkg/experimental (19%) |
666 | 17 file pairs | details... |
| pkg/frontendconfig (44%) --> pkg/svcneg (44%) |
448 | 10 file pairs | details... |
| pkg/ingparams (47%) --> pkg/svcneg (43%) |
440 | 10 file pairs | details... |
| pkg/frontendconfig (43%) --> pkg/ingparams (47%) |
436 | 10 file pairs | details... |
| pkg/backendconfig (20%) --> pkg/serviceattachment (25%) |
426 | 17 file pairs | details... |
| pkg/serviceattachment (25%) --> pkg/svcneg (41%) |
417 | 11 file pairs | details... |
| pkg/frontendconfig (41%) --> pkg/serviceattachment (25%) |
417 | 11 file pairs | details... |
| pkg/ingparams (43%) --> pkg/serviceattachment (24%) |
399 | 11 file pairs | details... |
| pkg/backendconfig (18%) --> pkg/frontendconfig (38%) |
381 | 11 file pairs | details... |
| pkg/backendconfig (18%) --> pkg/svcneg (37%) |
381 | 11 file pairs | details... |
| pkg/experimental (11%) --> pkg/serviceattachment (22%) |
373 | 11 file pairs | details... |
| pkg/backendconfig (18%) --> pkg/experimental (11%) |
373 | 11 file pairs | details... |
| pkg/backendconfig (17%) --> pkg/ingparams (39%) |
363 | 11 file pairs | details... |
| pkg/experimental (10%) --> pkg/svcneg (33%) |
342 | 8 file pairs | details... |
| pkg/experimental (10%) --> pkg/frontendconfig (34%) |
342 | 8 file pairs | details... |
| pkg/experimental (9%) --> pkg/ingparams (35%) |
330 | 8 file pairs | details... |
| cmd/glbc (6%) --> cmd/workload-controller (56%) |
62 | 2 file pairs | details... |
Longest Duplicates
The list of 20 longest duplicates.
| Size | # | Folders | Files | Lines | Code |
|---|---|---|---|---|---|
| 100 | x 2 | pkg/apis/serviceattachment/v1pkg/apis/serviceattachment/v1beta1 |  zz_generated.deepcopy.gozz_generated.deepcopy.go |
28:183 (100%)28:183 (100%) | view |
| 96 | x 2 | pkg/apis/backendconfig/v1pkg/apis/backendconfig/v1beta1 | zz_generated.deepcopy.gozz_generated.deepcopy.go |
262:407 (30%)168:313 (43%) | view |
| 76 | x 2 | pkg/serviceattachment/cl...ormers/externalversionspkg/svcneg/client/informers/externalversions | factory.gofactory.go |
36:173 (96%)36:173 (96%) | view |
| 76 | x 2 | pkg/backendconfig/client...ormers/externalversionspkg/frontendconfig/clien...ormers/externalversions | factory.gofactory.go |
36:173 (96%)36:173 (96%) | view |
| 76 | x 2 | pkg/experimental/workloa...ormers/externalversionspkg/serviceattachment/cl...ormers/externalversions | factory.gofactory.go |
36:173 (96%)36:173 (96%) | view |
| 76 | x 2 | pkg/experimental/workloa...ormers/externalversionspkg/ingparams/client/informers/externalversions | factory.gofactory.go |
36:173 (96%)36:173 (96%) | view |
| 76 | x 2 | pkg/ingparams/client/informers/externalversionspkg/svcneg/client/informers/externalversions | factory.gofactory.go |
36:173 (96%)36:173 (96%) | view |
| 76 | x 2 | pkg/frontendconfig/clien...ormers/externalversionspkg/serviceattachment/cl...ormers/externalversions | factory.gofactory.go |
36:173 (96%)36:173 (96%) | view |
| 76 | x 2 | pkg/experimental/workloa...ormers/externalversionspkg/svcneg/client/informers/externalversions | factory.gofactory.go |
36:173 (96%)36:173 (96%) | view |
| 76 | x 2 | pkg/backendconfig/client...ormers/externalversionspkg/svcneg/client/informers/externalversions | factory.gofactory.go |
36:173 (96%)36:173 (96%) | view |
| 76 | x 2 | pkg/ingparams/client/informers/externalversionspkg/serviceattachment/cl...ormers/externalversions | factory.gofactory.go |
36:173 (96%)36:173 (96%) | view |
| 76 | x 2 | pkg/backendconfig/client...ormers/externalversionspkg/serviceattachment/cl...ormers/externalversions | factory.gofactory.go |
36:173 (96%)36:173 (96%) | view |
| 76 | x 2 | pkg/frontendconfig/clien...ormers/externalversionspkg/ingparams/client/informers/externalversions | factory.gofactory.go |
36:173 (96%)36:173 (96%) | view |
| 76 | x 2 | pkg/experimental/workloa...ormers/externalversionspkg/frontendconfig/clien...ormers/externalversions | factory.gofactory.go |
36:173 (96%)36:173 (96%) | view |
| 76 | x 2 | pkg/backendconfig/client...ormers/externalversionspkg/experimental/workloa...ormers/externalversions | factory.gofactory.go |
36:173 (96%)36:173 (96%) | view |
| 76 | x 2 | pkg/frontendconfig/clien...ormers/externalversionspkg/svcneg/client/informers/externalversions | factory.gofactory.go |
36:173 (96%)36:173 (96%) | view |
| 76 | x 2 | pkg/backendconfig/client...ormers/externalversionspkg/ingparams/client/informers/externalversions | factory.gofactory.go |
36:173 (96%)36:173 (96%) | view |
| 71 | x 2 | pkg/apis/backendconfig/v1pkg/apis/backendconfig/v1beta1 | zz_generated.deepcopy.gozz_generated.deepcopy.go |
28:129 (22%)28:129 (32%) | view |
| 56 | x 2 | pkg/apis/backendconfig/v1pkg/apis/backendconfig/v1beta1 | zz_generated.openapi.gozz_generated.openapi.go |
287:342 (9%)173:228 (14%) | view |
| 43 | x 2 | pkg/apis/backendconfig/v1pkg/apis/backendconfig/v1beta1 | zz_generated.openapi.gozz_generated.openapi.go |
395:437 (7%)281:323 (11%) | view |
Duplicated Units
The list of top 20 duplicated units.
| Size | # | Folders | Files | Lines | Code |
|---|---|---|---|---|---|
| 60 | x 2 | pkg/apis/backendconfig/v1beta1pkg/apis/backendconfig/v1 | zz_generated.openapi.gozz_generated.openapi.go |
172:232 286:346 | view |
| 42 | x 2 | pkg/apis/ingparams/v1beta1pkg/apis/serviceattachment/v1beta1 | zz_generated.openapi.gozz_generated.openapi.go |
37:79 132:174 | view |
| 41 | x 5 | pkg/experimental/apis/workload/v1alpha1pkg/apis/backendconfig/v1beta1pkg/apis/backendconfig/v1pkg/apis/svcneg/v1beta1pkg/apis/frontendconfig/v1beta1 | zz_generated.openapi.gozz_generated.openapi.gozz_generated.openapi.gozz_generated.openapi.gozz_generated.openapi.go |
124:165 46:87 50:91 131:172 38:79 | view |
| 38 | x 2 | pkg/apis/backendconfig/v1beta1pkg/apis/backendconfig/v1 | zz_generated.deepcopy.gozz_generated.deepcopy.go |
245:283 339:377 | view |
| 33 | x 3 | pkg/apis/backendconfig/v1beta1pkg/apis/backendconfig/v1pkg/apis/svcneg/v1beta1 | zz_generated.openapi.gozz_generated.openapi.gozz_generated.openapi.go |
368:401 537:570 96:129 | view |
| 25 | x 2 | pkg/apis/backendconfig/v1beta1pkg/apis/backendconfig/v1 | zz_generated.openapi.gozz_generated.openapi.go |
341:366 456:481 | view |
| 25 | x 4 | pkg/apis/backendconfig/v1pkg/apis/backendconfig/v1pkg/apis/serviceattachment/v1beta1pkg/apis/serviceattachment/v1 | zz_generated.openapi.gozz_generated.openapi.gozz_generated.openapi.gozz_generated.openapi.go |
483:508 510:535 40:65 40:65 | view |
| 24 | x 2 | pkg/apis/backendconfig/v1beta1pkg/apis/backendconfig/v1 | zz_generated.openapi.gozz_generated.openapi.go |
254:278 368:392 | view |
| 23 | x 2 | pkg/apis/backendconfig/v1beta1pkg/apis/backendconfig/v1 | zz_generated.openapi.gozz_generated.openapi.go |
424:447 593:616 | view |
| 21 | x 2 | pkg/apis/serviceattachment/v1beta1pkg/apis/serviceattachment/v1 | zz_generated.deepcopy.gozz_generated.deepcopy.go |
131:152 131:152 | view |
| 20 | x 6 | pkg/backendconfig/client/clientset/versioned/fakepkg/svcneg/client/clientset/versioned/fakepkg/ingparams/client/clientset/versioned/fakepkg/experimental/workloa...lientset/versioned/fakepkg/frontendconfig/client/clientset/versioned/fakepkg/serviceattachment/cl...lientset/versioned/fake | clientset_generated.goclientset_generated.goclientset_generated.goclientset_generated.goclientset_generated.goclientset_generated.go |
38:60 36:58 36:58 36:58 36:58 38:60 | view |
| 19 | x 3 | pkg/svcneg/client/clientset/versionedpkg/ingparams/client/clientset/versionedpkg/frontendconfig/client/clientset/versioned | clientset.goclientset.goclientset.go |
58:78 58:78 58:78 | view |
| 19 | x 3 | pkg/apis/backendconfig/v1beta1pkg/apis/backendconfig/v1pkg/apis/ingparams/v1beta1 | zz_generated.openapi.gozz_generated.openapi.gozz_generated.openapi.go |
403:422 572:591 81:100 | view |
| 18 | x 2 | pkg/apis/backendconfig/v1beta1pkg/apis/backendconfig/v1 | zz_generated.openapi.gozz_generated.openapi.go |
234:252 155:173 | view |
| 17 | x 6 | pkg/backendconfig/client...ormers/externalversionspkg/svcneg/client/informers/externalversionspkg/ingparams/client/informers/externalversionspkg/experimental/workloa...ormers/externalversionspkg/frontendconfig/clien...ormers/externalversionspkg/serviceattachment/cl...ormers/externalversions | factory.gofactory.gofactory.gofactory.gofactory.gofactory.go |
124:143 124:143 124:143 124:143 124:143 124:143 | view |
| 15 | x 6 | pkg/backendconfig/client...ormers/externalversionspkg/svcneg/client/informers/externalversionspkg/ingparams/client/informers/externalversionspkg/experimental/workloa...ormers/externalversionspkg/frontendconfig/clien...ormers/externalversionspkg/serviceattachment/cl...ormers/externalversions | factory.gofactory.gofactory.gofactory.gofactory.gofactory.go |
147:166 147:166 147:166 147:166 147:166 147:166 | view |
| 13 | x 6 | pkg/backendconfig/client...ormers/externalversionspkg/svcneg/client/informers/externalversionspkg/ingparams/client/informers/externalversionspkg/experimental/workloa...ormers/externalversionspkg/frontendconfig/clien...ormers/externalversionspkg/serviceattachment/cl...ormers/externalversions | factory.gofactory.gofactory.gofactory.gofactory.gofactory.go |
92:108 92:108 92:108 92:108 92:108 92:108 | view |
| 13 | x 7 | pkg/backendconfig/client...d/backendconfig/v1beta1pkg/backendconfig/client.../typed/backendconfig/v1pkg/svcneg/client/client...ed/typed/svcneg/v1beta1pkg/experimental/workloa...typed/workload/v1alpha1pkg/frontendconfig/clien.../frontendconfig/v1beta1pkg/serviceattachment/cl...rviceattachment/v1beta1pkg/serviceattachment/cl...ed/serviceattachment/v1 | backendconfig.gobackendconfig.goservicenetworkendpointgroup.goworkload.gofrontendconfig.goserviceattachment.goserviceattachment.go |
150:163 150:163 167:180 167:180 150:163 167:180 167:180 | view |
| 13 | x 2 | pkg/apis/backendconfig/v1beta1pkg/apis/backendconfig/v1 | zz_generated.deepcopy.gozz_generated.deepcopy.go |
182:195 276:289 | view |
| 13 | x 2 | pkg/apis/serviceattachment/v1beta1pkg/apis/serviceattachment/v1 | zz_generated.deepcopy.gozz_generated.deepcopy.go |
44:57 44:57 | view |