membership-attribute-service/app/services/zuora/rest/SimpleClientZuoraRestService.scala (3 lines): - line 18: simpleRest.get[AccountSummary](s"accounts/${accountId.get}/summary") // TODO error handling - line 56: ], // FIXME: Optionality should probably be removed and semantics changed to cancellationEffectiveDate (see comments bellow) - line 59: // FIXME: Not always safe assumption. There are multiple scenarios to consider membership-common/src/main/scala/com/gu/memsub/subsv2/services/SubscriptionService.scala (2 lines): - line 71: * FIXME: We should change to true as default as we are usually interested in only what the user has right now. We could simplify much filtering - line 87: s"subscriptions/${subscriptionNumber.getNumber}" // FIXME: equivalent to ?charge-detail=last-segment which returns even removed historical charges. We should not have this as default. membership-attribute-service/app/controllers/ExistingPaymentOptionsController.scala (2 lines): - line 62: val theChosenOne = consolidated.head // TODO in future perhaps use custom fields on PaymentMethod to see which is safe to clone - line 74: // TODO should probably fetch upToDate details from Stripe to determine this (rather than relying on Zuora) - see getUpToDatePaymentDetailsFromStripe in AccountController membership-attribute-service/app/actions/CommonActions.scala (2 lines): - line 26: // TODO: Might need a better name as authoriseForRecentLogin checks for recency and scopes - line 36: // TODO: Is this redundant, given that authoriseForRecentLogin checks for recency and scopes? membership-attribute-service/app/controllers/PaymentUpdateController.scala (2 lines): - line 46: // TODO - refactor to use the Zuora-only based lookup, like in AttributeController.pickAttributes - https://trello.com/c/RlESb8jG - line 135: // TODO - refactor to use the Zuora-only based lookup, like in AttributeController.pickAttributes - https://trello.com/c/RlESb8jG membership-common/src/main/scala/com/gu/zuora/soap/actions/Actions.scala (2 lines): - line 15: * TODO: Split up these actions into simple models (In models/Commands) and XmlWriters - line 92: case _ => None // TODO perhaps log invalid card type membership-attribute-service/app/models/AccountDetails.scala (1 line): - line 173: "plan" -> Json.obj( // TODO remove once nothing is using this key (same time as removing old deprecated endpoints) membership-attribute-service/app/models/Attributes.scala (1 line): - line 79: // TODO in future this could become more sophisticated (e.g. two weeks before their products expire) membership-attribute-service/app/services/zuora/rest/ZuoraRestService.scala (1 line): - line 417: ], // FIXME: Optionality should probably be removed and semantics changed to cancellationEffectiveDate (see comments bellow)