eden/mononoke/mercurial/bundles/src/part_header.rs (15 lines): - line 68: // CheckBookmarks, // TODO Do we want to support this? - line 69: // CheckHeads, // TODO Do we want to support this? - line 70: // CheckUpdatedHeads, // TODO Do we want to support this? - line 71: // CheckPhases, // TODO Do we want to support this? - line 72: // Output, // TODO Do we want to support this? - line 73: // ErrorAbort, // TODO Do we want to support this? - line 74: // ErrorPushkey, // TODO Do we want to support this? - line 75: // ErrorUnsupportedContent, // TODO Do we want to support this? - line 76: // ErrorPushRaced, // TODO Do we want to support this? - line 77: // Pushkey, // TODO Do we want to support this? - line 78: // Bookmarks, // TODO Do we want to support this? - line 79: // ReplyPushkey, // TODO Do we want to support this? - line 81: // ReplyObsmarkers, // TODO Do we want to support this? - line 82: // HgtagsFnodes, // TODO Do we want to support this? - line 276: // TODO: ensure none of the params is empty eden/fs/inodes/TreeInode.cpp (11 lines): - line 878: // TODO: O(N^2) - line 2424: // TODO: Once we build a new backing store and can replace our - line 2433: // TODO: Hopefully at some point we will track file sizes in the - line 2672: // TODO: If we are doing a force update we should probably short circuit in - line 2807: // TODO: Should we perhaps fall through anyway to report conflicts for - line 2951: // TODO: remove entry.getInodeNumber() from both the overlay and the - line 2980: // TODO: contents have changed: we probably should propagate - line 3075: // TODO: Also apply permissions changes to the entry. - line 3318: // TODO: This check should be removed and instead a - line 3357: // TODO: Currently we end up writing out overlay data for TreeInodes - line 3542: // TODO: Better yet, this shouldn't use atime at all and instead keep an eden/scm/edenscm/hgext/convert/repo/repo_source.py (11 lines): - line 255: date = datetime.datetime.utcnow() # TODO: date should never be empty - line 262: None, # TODO: Use time zone info from commit - line 270: None, # TODO: Use time zone info from commit - line 382: # TODO: This won't be reliable for filenames with newlines. We need to parse a - line 540: # TODO: Allow project-specific remote - line 766: self.srcencoding = "utf-8" # TODO: Read from git source projects - line 785: # TODO: Validate input repo, e.g. all branches present - line 786: # TODO: Look at the manifest for the repo - line 792: # TODO: Validate output somehow - line 901: # TODO: Fix for multiple parents - line 1063: # TODO: Log to some persistent place eden/scm/edenscm/mercurial/merge.py (8 lines): - line 561: # TODO: move this to filectxorabsent - line 1513: # TODO: Consider other simple actions such as mode changes - line 1519: # Pick random action. TODO: Instead, prompt user when resolving - line 1684: # TODO: move to absentfilectx - line 2286: # TODO: We potentially should support handling this scenario ourself in - line 2291: # TODO: We potentially should support handling this scenario ourself in - line 2301: # TODO: Figure out what's the other cases here. - line 2345: # TODO: remove the default once all callers that pass branchmerge=False eden/scm/lib/manifest/src/lib.rs (8 lines): - line 37: // TODO: Add method for batch modification, takes iterator of added, removed, changed, or - line 39: // TODO: A batch API allows us to move to having all nodes have a computed hash without losing - line 47: // TODO: add default implementation - line 56: // TODO: add default implementation - line 89: // TODO: add default implementation - line 97: // TODO: add default implementation - line 125: // TODO: add FileMetadata to File and "DirectoryMetadata" to Directory - line 148: // TODO: Move hgid to a new DirectoryMetadata struct. eden/scm/lib/manifest-tree/src/lib.rs (8 lines): - line 64: // TODO: root can't be a Leaf - line 146: path.clone(), // TODO: get rid of clone (it is borrowed) - line 172: path.clone(), // TODO: get rid of clone (it is borrowed later) - line 222: // TODO: only convert to ephemeral if a removal took place - line 299: // TODO: remove clone - line 526: // TODO: This code is also used on durable nodes for the purpose of generating - line 545: // TODO: remove clone - line 625: // TODO: optimize "other_nodes" construction eden/fs/service/EdenServiceHandler.cpp (8 lines): - line 1113: // TODO: remove these dynamic casts in favor of a QueryInterface method - line 1205: // TODO: trace requesting pid - line 1352: // TODO: applyToInodes currently forces allocation of inodes for all specified - line 1405: // TODO: applyToInodes currently forces allocation of inodes for all specified - line 1756: // TODO: This function should operate with ObjectId instead of RootId. - line 1827: // TODO: since we call INSTRUMENT_THRIFT_CALL in _globFiles, the time - line 2470: // TODO: remove these dynamic casts in favor of a QueryInterface method - line 2560: // TODO: remove when no old clients exists eden/scm/lib/workingcopy/src/filesystem.rs (7 lines): - line 74: // TODO: Make this an Arc> so we can persist the vfs pathauditor cache - line 178: let in_parent = flags.intersects(StateFlags::EXIST_P1); // TODO: Also check against P2? - line 299: // TODO: audit the path for symlinks and weirdness - line 385: // TODO: if the underlying stores gain the ability to do hash-based comparisons, - line 417: // TODO: after finishing these comparisons, update the cached mtimes of files so we - line 425: // TODO: Try to make this into a chain instead of a manual state machine - line 447: // TODO: Support path normalization on case insensitive file systems eden/scm/edenscm/mercurial/templates/static/excanvas.js (6 lines): - line 152: // TODO: use runtimeStyle and coordsize - line 159: // TODO: use runtimeStyle and coordsize - line 325: // TODO: Branch current matrix so that save/restore has no effect - line 641: // TODO: Following is broken for curves due to - line 884: // TODO: Implement - line 888: // TODO: Implement eden/fs/inodes/EdenMount.cpp (6 lines): - line 124: // TODO: figure out what we should do to notify the user, if anything. - line 302: // TODO: It would be nice if the .eden inode was created before - line 349: // TODO: it would be nicer to actually check the exception to - line 1278: // TODO: Report the pid of the client that requested the first checkout - line 1610: // TODO: Should we perhaps hold the parentInfo read-lock for the duration - line 1657: // TODO: Maybe we should walk the inodes and see if we can dematerialize eden/fs/service/EdenServer.cpp (6 lines): - line 104: "run fuse in debug mode"); // TODO: remove; no longer needed - line 742: // TODO: would be nice to deduplicate these function calls. We need the - line 916: // TODO: The "state config" only has one configuration knob now. When - line 1810: // TODO: remove these dynamic casts in favor of a QueryInterface method - line 2098: // TODO: Set a flag in handler_ to reject future subscription requests. - line 2121: // TODO: Stop using the legacy addStatValue() call that checks to see eden/scm/edenscm/hgext/convert/repo/repomanifest.py (6 lines): - line 39: # TODO: arg checking including path - line 70: # TODO: arg checking - line 149: # TODO: Index this? - line 248: # TODO: Index this? - line 263: # TODO: Index this? - line 280: # TODO: Path normalization eden/mononoke/walker/src/new_walker/args/walk_params.rs (6 lines): - line 20: // TODO: NODE_TYPE_POSSIBLE_VALUES - line 25: // TODO: NODE_TYPE_POSSIBLE_VALUES, default = DEFAULT_VALUE_ARG, also hide - line 31: // TODO: EDGE_TYPE_POSSIBLE_VALUES - line 35: // TODO: EDGE_TYPE_POSSIBLE_VALUES, default = DEEP_VALUE_ARG, also hide - line 95: // TODO: NODE_HASH_VALIDATION_POSSIBLE_VALUES - line 99: // TODO: NODE_HASH_VALIDATION_POSSIBLE_VALUES, also hide eden/mononoke/walker/src/new_walker/args/tail_args.rs (5 lines): - line 56: // TODO: CHUNK_BY_PUBLIC_POSSIBLE_VALUES - line 74: // TODO: INTERNED_TYPE_POSSIBLE_VALUES - line 78: // TODO: INTERNED_TYPE_POSSIBLE_VALUES - line 83: // TODO: NODE_TYPE_POSSIBLE_VALUES - line 87: // TODO: NODE_TYPE_POSSIBLE_VALUES eden/fs/store/ObjectStore.cpp (5 lines): - line 163: // TODO: We should consider checking if we have in flight BackingStore - line 190: // TODO: Perhaps we should do some short-term negative - line 232: // TODO: Perhaps we should do some short-term negative caching? - line 309: // TODO: It would be nice to add a smarter API to the BackingStore so - line 313: // TODO: This should probably check the LocalStore for the blob first, eden/fs/cli/main.py (5 lines): - line 1243: # TODO: unload - line 1247: # TODO: clear kernel caches - line 1715: # TODO: intelligently stop nuclide-server associated with eden - line 2213: # TODO: We should probably rename this argument to --state-dir. - line 2348: # TODO: Remove when we can rely on Python 3.7 everywhere. eden/fs/inodes/overlay/OverlayChecker.cpp (5 lines): - line 114: // TODO: It would be somewhat nicer to look in the ObjectStore and see what - line 261: // TODO: Move the file into the repair directory, with some unique name - line 284: // TODO: Move the file into the repair directory, with some unique name - line 621: // TODO: split the inode into 2 separate copies - line 1045: // TODO: It would be nice to also check for mismatch between eden/mononoke/repo_client/src/client/mod.rs (5 lines): - line 397: // TODO: T45411456 Fix this by teaching the client to expect extra commits to correspond to the bookmarks. - line 589: // TODO: generalize this to other listkey types - line 643: // TODO: possibly enable compression support once this is fixed. - line 1129: // TODO: directly return stream of streams - line 1215: // TODO: directly return stream of heads eden/scm/edenscm/mercurial/utils/cborutil.py (4 lines): - line 554: # TODO add support for limiting size of bytestrings - line 555: # TODO add support for limiting number of keys / values in collections - line 556: # TODO add support for limiting size of buffered partial values - line 923: TODO consider adding limits as to the maximum amount of data that can eden/fs/inodes/InodeMap.cpp (4 lines): - line 108: // TODO: We need to clean up the EdenMount / InodeMap destruction process a - line 686: // TODO add a checkout decRef counter - line 687: // TODO: this will unload by atime, atime is not updated by stat -- fix it - line 869: // TODO: This check could occur after the loadedInodes_ assertion below to eden/fs/inodes/Overlay.cpp (4 lines): - line 310: // TODO: Eventually, we should only serialize the child entry's dtype into - line 332: // TODO: T20282158 clean up access of child inode information. - line 361: // TODO: batch request during GC - line 536: // TODO: For better throughput on large tree collections, it might make eden/fs/store/git/GitBackingStore.cpp (4 lines): - line 95: // TODO: Use a separate thread pool to do the git I/O - line 122: // TODO: Use a separate thread pool to do the git I/O - line 155: // TODO: We currently don't handle GIT_FILEMODE_COMMIT - line 173: // TODO: Use a separate thread pool to do the git I/O eden/mononoke/commit_rewriting/cross_repo_sync/src/lib.rs (4 lines): - line 364: // TODO: Finish refactor and remove pub - line 921: None => remap_parents(ctx, &source_cs, self, CandidateSelectionHint::Only).await?, // TODO: check if only is ok - line 1049: // FIXME: Had to turn it to a vector to avoid "One type is more general than the other" - line 1405: // FIXME: Had to turn it to a vector to avoid "One type is more general than the other" eden/fs/store/RocksDbLocalStore.cpp (4 lines): - line 391: // TODO: RocksDB can return a "TryAgain" error. - line 472: // TODO: RocksDB can return a "TryAgain" error. - line 517: // TODO: RocksDB can return a "TryAgain" error. - line 709: // TODO: log the column names in the structured event eden/integration/lib/skip.py (4 lines): - line 128: # TODO: Opening a file with O_TRUNC inside an EdenFS mount fails on Windows - line 130: # TODO: These tests do not report the file as modified after truncation - line 138: # TODO: A \r\n is used - line 140: # TODO: crash EdenFS with TreeInode.cpp:3035] Check failed: !newScmEntry->isTree() eden/mononoke/lfs_server/src/upload.rs (4 lines): - line 212: // TODO: We are discarding expiry and headers here. We probably shouldn't. - line 213: // TODO: We are discarding verify actions. - line 217: // TODO: Fix this after updating Hyper: https://github.com/hyperium/hyper/pull/2187 - line 417: // TODO: More appropriate status codes here eden/scm/edenscm/mercurial/localrepo.py (4 lines): - line 1861: # TODO: Consider changing 'self' to 'reporef()'. - line 2077: # TODO: if we know which new heads may result from this rollback, pass - line 2158: # TODO: Solve the problem instead of working around it. - line 2181: # TODO: Changing contents of store outside transaction eden/fs/inodes/DirEntry.h (4 lines): - line 71: // TODO: In the future we should probably only allow callers to invoke - line 78: // TODO: In the future we should probably only allow callers to invoke - line 176: * TODO: This field is not updated when an inode's mode bits are changed. - line 202: * TODO: If inode is set, this field generally should not be used, and the eden/fs/cli/fsck.py (4 lines): - line 146: # TODO: It would be nice to try and get the contents of the - line 202: # TODO: It would be nice to try and get the contents of the - line 435: # TODO: Handle the error if os.listdir() fails - line 444: # TODO: check if inode_number is actually in the correct subdirectory. eden/fs/fuse/FuseChannel.cpp (4 lines): - line 197: // TODO: could print some specific inode values here - line 1212: // TODO: This code is slightly racy, since threads could receive the signal - line 1450: // TODO: follow up and look at the new flags; particularly - line 1561: // TODO: FUSE_SPLICE_READ allows using splice(2) here if we enable it. eden/mononoke/newfilenodes/src/reader.rs (3 lines): - line 305: // TODO: We should compress if this is too big. - line 556: // TODO: It'd be nice to have some eviction here. - line 557: // TODO: It'd be nice to chain those. eden/fs/inodes/OverlayFileAccess.cpp (3 lines): - line 187: // TODO: implement readFile with pread instead of lseek. - line 261: // TODO: If the inode is not currently in cache, we could avoid calling fsync. - line 300: // TODO: A possible future optimization here is, if a SHA-1 is known when eden/scm/edenscm/hgext/treemanifestserver.py (3 lines): - line 1680: # TODO: only put in cache if pulling from main server - line 2685: # TODO: treeonly bundlerepo's won't work here since the manifest - line 2931: # TODO: We should probably cache getmeta as well eden/scm/edenscm/mercurial/match.py (3 lines): - line 102: # TODO: update me? - line 1076: TODO: If we want to keep the behavior described above for exact matches, we - line 1131: # TODO: Consider encapsulating these things in a class so there's only eden/scm/edenscm/mercurial/commands/debug.py (3 lines): - line 715: # TODO we may want to turn this into an abort when this functionality - line 1391: # TODO: get desired bundlecaps from command line. - line 1647: # TODO print CA cert info eden/fs/cli/redirect.py (3 lines): - line 626: # TODO: replace this with Path.readlink once Python 3.9+ - line 688: # TODO: on Windows we replace backslash \ with / since - line 1177: # FIXME: I'd rather just show the help here automatically eden/mononoke/common/rust/caching_ext/src/lib.rs (3 lines): - line 163: // TODO: We should relax the bounds on cachelib's set_cached. We don't need all of this: - line 189: // TODO: We should relax the bounds on cachelib's set_cached. We don't need all of this: - line 286: // TODO: We should relax the bounds on cachelib's set_cached. We don't need all of this: eden/fs/inodes/InodeTable.h (3 lines): - line 40: // TODO: should we maintain a 64-bit SpookyHashV2 checksum to ignore - line 188: // TODO: maybe trigger a background msync - line 193: // TODO: replace with freeInodes - it's much more efficient to free a bunch eden/scm/edenscm/mercurial/util.py (3 lines): - line 504: # TODO: We should enforce that services set HG_CALLER_ID to their oncall. We - line 3172: # TODO: similar to the query string, we should not unescape the - line 4198: # TODO: Move these to async analysis reading from blackbox. eden/scm/edenscm/mercurial/setdiscovery.py (3 lines): - line 174: # TODO: Improve clone protocol so streamclone transfers remote names. - line 188: # TODO: Revisit this after segmented changelog, which makes it - line 333: # TODO: Check how 'remoteheads' is used at upper layers, and if we eden/fs/utils/ProcessNameCache.cpp (3 lines): - line 307: // TODO: When we can rely on C++17, it might be cheaper to move the node - line 356: // TODO: It might be worth skipping this during ProcessNameCache shutdown, - line 388: // TODO: There are a few possible optimizations here, but get() is so eden/fs/store/ObjectCache-inl.h (3 lines): - line 115: // TODO: One possible optimization here is to set a bit (reference count - line 154: // TODO: Should we avoid promoting if interest is UnlikelyNeededAgain? - line 351: // TODO: Releasing this ObjectPtr here can run arbitrary deleters which eden/scm/edenscm/mercurial/httpclient/__init__.py (3 lines): - line 318: # TODO HTTP < 1.0 support - line 890: # TODO: find a way to block on ssl flushing its buffer - line 928: # TODO restructure sending of requests to avoid eden/fs/utils/PathFuncs.h (3 lines): - line 645: * TODO: operator->() is not implemented - line 837: * TODO: operator->() is not implemented - line 1536: * TODO: operator->() is not implemented build/fbcode_builder/CMake/FBPythonBinary.cmake (3 lines): - line 50: # TODO: On Windows we require the Python libraries as well. - line 187: # TODO: generate a main executable that will invoke Python3 - line 420: # TODO: In the future it would be nice to support pre-compiling the source eden/scm/edenscm/mercurial/eden_dirstate.py (3 lines): - line 58: # FIXME: This appears to be called by `hg reset`, so we provide a dummy - line 98: # TODO: We do not currently invoke match.traversedir - line 232: # TODO: Just invoke self.normal() here for now. eden/mononoke/newfilenodes/src/remote_cache.rs (3 lines): - line 63: // TODO: Can we optimize to reuse the existing PathWithHash we got? - line 82: // TODO: Need to use the same CacheKey here. - line 112: // TODO: Take ownership of key eden/scm/edenscm/mercurial/uiconfig.py (3 lines): - line 222: # TODO remove those users and make this a ProgrammingError. - line 553: # FIXME: Do something here? - line 564: # TODO Call this from somewhere eden/mononoke/repo_client/remotefilelog/src/lib.rs (3 lines): - line 119: // TODO (T30456231): Avoid this copy - line 180: // TODO (T30456231): Avoid this copy - line 214: // TODO (T30456231): Avoid this copy eden/mononoke/mercurial/bundles/src/part_inner.rs (3 lines): - line 171: // TODO: add support for file wirepacks once that's a thing - line 190: // TODO: add support for file wirepacks once that's a thing - line 215: _ => panic!("TODO: make this an error"), eden/scm/edenscm/mercurial/changelog2.py (2 lines): - line 64: # TODO: Consider moving visibleheads out? - line 566: # TODO: Add hints about possible matches. eden/mononoke/mercurial/revlog/revlogrepo.rs (2 lines): - line 253: // TODO: (jsgf) T17932873 distinguish between not existing vs some other error - line 264: // TODO: (jsgf) T17932873 distinguish between not existing vs some other error eden/scm/edenscm/hgext/remotefilelog/remotefilelog.py (2 lines): - line 354: # TODO: this algorithm has the potential to traverse parts of - line 392: # TODO: ancestors should probably be (name, node) -> (value) eden/mononoke/mononoke_types/src/path.rs (2 lines): - line 917: // TODO: do we really want a uniform distribution over component chars - line 1203: // TODO: Do we need this? Why? eden/mononoke/mononoke_hg_sync_job/src/main.rs (2 lines): - line 174: // TODO: (torozco) T43766262 We should embed attempts in retry()'s Error type and use it - line 747: // FIXME: this cloned! will go away once HgRepo is asyncified eden/fs/cli/config.py (2 lines): - line 229: # TODO: We should eventually read the default config_dir path from the config - line 1186: # TODO: replace is needed to workaround a bug in toml eden/mononoke/commit_rewriting/mononoke_x_repo_sync_job/src/sync.rs (2 lines): - line 469: // TODO: do not require clone here - line 504: // FIXME: this code has an assumption that parent with a smaller generation number is a eden/mononoke/repo_client/unbundle/src/processing.rs (2 lines): - line 70: // FIXME: it's used not only in pushrebase, so it worth moving - line 349: // FIXME: stop cloning when this fn is async eden/mononoke/mercurial/bundles/src/part_outer.rs (2 lines): - line 130: // TODO: the only state valid when the stream terminates is - line 229: // TODO: -1 means this part has been interrupted. Handle that eden/fs/nfs/rpc/Server.cpp (2 lines): - line 490: // TODO: something reasonable here - line 606: // TODO this needs to check if the unique_ptr is valid eden/fs/utils/MappedDiskVector.h (2 lines): - line 349: // TODO: It might be worth eliminating the end_ pointer and always adding - line 568: // TODO: newVector.reserve eden/scm/edenscm/mercurial/exchange.py (2 lines): - line 1146: # TODO: get bundlecaps from remote - line 1734: # TODO: get bundlecaps from remote eden/scm/edenscm/mercurial/extensions.py (2 lines): - line 161: # TODO: check whether path is "trusted" or not - line 292: # TODO: write a test after Python 3 migration eden/scm/lib/tracing-collector/src/model.rs (2 lines): - line 351: // TODO: Implement this. - line 655: // TODO: Implement this. eden/scm/edenscmnative/bindings/modules/pymanifest/src/lib.rs (2 lines): - line 224: // TODO: Optimize this so that the string does not get copied. - line 229: // TODO: can the node and flag that are passed in be None? eden/fs/cli/trace/trace_stream.cpp (2 lines): - line 171: // TODO: Might be interesting to add an option to see queuing events. - line 231: // TODO (liuz): Rather than issuing one call per filesystem interface, it eden/mononoke/unbundle_replay/src/main.rs (2 lines): - line 311: // TODO: Run hooks here (this is where repo_client would run them). - line 382: // TODO: Would want Scuba and such here. eden/mononoke/mercurial/bundles/src/changegroup/unpacker.rs (2 lines): - line 243: // TODO: chunk_len < 0 = error - line 315: // TODO: filename_len < 0 == error eden/fs/cli/stats.py (2 lines): - line 38: # TODO: https://github.com/python/typeshed/issues/1240 - line 416: # TODO: Retrieve this data via Thrift. eden/scm/lib/tracing-analyzer/src/tables.rs (2 lines): - line 25: // TODO: Make things more configurable. - line 84: // TODO: Use shell_escape once in tp2. build/fbcode_builder/CMake/FBCMakeParseArgs.cmake (2 lines): - line 49: # TODO: We aren't extremely strict about error checking for one-value - line 125: # TODO: Our caller still won't be able to distinguish between an empty eden/scm/lib/workingcopy/src/walker.rs (2 lines): - line 372: // TODO make sure that _t is different for each thread - line 419: // TODO in future, let caller handle receiving on the channel. eden/scm/lib/edenapi/types/src/wire/history.rs (2 lines): - line 24: // TODO: attributes in this file aren't renamed to 0, 1, ... - line 57: // TODO: Rename, move more functionality to wire types? eden/fs/nfs/Nfsd3.cpp (2 lines): - line 1226: /* TODO @cuev: This is prob where we'd use args.maxcount: - line 1883: // TODO: Add requestMetrics for NFS. eden/scm/lib/backingstore/src/backingstore/scmstores.rs (2 lines): - line 182: // TODO: How should we handle normal non-keyed errors? - line 335: // TODO: How should we handle normal non-keyed errors? eden/mononoke/blobrepo/common/src/file_history.rs (2 lines): - line 263: /// FIXME: max_legth parameter is not necessary. We can use .take() method on the stream - line 296: // TODO: There is probably another thundering herd problem here. If we change a file twice, eden/mononoke/bookmarks/bookmarks_movement/src/restrictions.rs (2 lines): - line 51: // TODO: clean up `is_allowed_user` to avoid this clone. - line 62: // TODO: Check using ctx.identities, and deny if neither are provided. configerator/structs/scm/mononoke/blobimport/state.thrift (2 lines): - line 15: # TODO: Remove after updating blobimport - line 20: # TODO: Remove after updating blobimport eden/scm/edenscm/mercurial/hgweb/webcommands.py (2 lines): - line 927: # TODO there are still redundant operations within basefilectx.parents() - line 1467: # TODO implement support for rendering sections, like eden/fs/cli/doctor/__init__.py (2 lines): - line 491: # TODO: We could potentially try automatically unmounting and remounting. - line 550: # TODO: Maybe we could use some better suggestions here, depending on eden/scm/lib/edenapi/types/src/token.rs (2 lines): - line 60: // TODO: add other data (like expiration time). - line 123: // TODO: implement secure signed tokens eden/fs/takeover/TakeoverData.h (2 lines): - line 49: // TODO (T104724681): use a nicer representation for a bit set to combine these - line 125: // TODO: deprecate versions 3-5 after capability matching is stable eden/scm/lib/manifest-tree/src/link.rs (2 lines): - line 81: // TODO: Use Vec instead of BTreeMap - line 209: // TODO: be smarter around how failures are handled when reading from the store eden/scm/lib/backingstore/c_api/HgNativeBackingStore.cpp (2 lines): - line 197: // TODO: It would be nice if we can differentiate not found error with - line 258: // TODO: It would be nice if we can differentiate not found error with eden/scm/edenscm/mercurial/revset.py (2 lines): - line 326: # TODO: perhaps this should be a table of relation functions - line 328: # TODO: support range, rewrite tests, and drop startdepth argument eden/fs/model/TreeEntry.cpp (2 lines): - line 37: // TODO: would be nice to log some useful context here! - line 112: // TODO: we should consider using a standard memory framework across eden/mononoke/edenapi_service/src/utils/convert.rs (2 lines): - line 95: // TODO: Verify signature on upload token - line 131: // TODO: Verify signature on upload token eden/fs/inodes/treeoverlay/TreeOverlayWindowsFsck.cpp (2 lines): - line 224: // TODO: EdenFS for Windows does not support symlinks yet, the only - line 246: // TODO: remove cast once we don't use Thrift to represent overlay entry eden/scm/edenscm/mercurial/dispatch.py (2 lines): - line 519: # TODO: Move this into a background task that renders from - line 852: # FIXME: Find a way to avoid calling expandargs twice. eden/fs/cli_rs/edenfs-commands/src/gc.rs (2 lines): - line 29: // TODO: unload inodes - line 36: // TODO: clear kernel caches here eden/fs/inodes/sqliteoverlay/SqliteOverlay.cpp (2 lines): - line 34: // TODO: We should customize it by reading the value from the config. This is - line 42: // TODO: we need `or ignore` otherwise we hit primary key violations eden/mononoke/git/git_types/src/tree.rs (2 lines): - line 184: // TODO: Can we verify members here (git_path_isvalid) - line 267: // TODO: Expose git_path_cmp from libgit2 and use it here eden/scm/lib/edenfs-client/src/status.rs (2 lines): - line 50: /// TODO: This does not match the Python implementation. Namely: - line 147: // TODO: in the future we can have this look at some configuration that eden/scm/edenscm/mercurial/ui.py (2 lines): - line 490: # TODO: add support for HGPLAIN=+feature,-feature syntax - line 820: # TODO: expose debugger-enabled on the UI object eden/scm/edenscm/hgext/lfs/__init__.py (2 lines): - line 126: # TODO: is there a way to just walk the files in the commit? - line 358: # TODO: Consider GC hidden commits as well and only keep objects used by eden/fs/inodes/EdenMount.h (2 lines): - line 559: * TODO: add maxSize parameter to cause the command to fail if the file is - line 911: * TODO: we should make this a bit more channel type agnostic. eden/mononoke/mercurial/bundles/src/wirepack/mod.rs (2 lines): - line 99: // TODO: move to mercurial_types - line 103: // TODO: replace with HgParents? eden/mononoke/hgproto/src/commands.rs (2 lines): - line 601: // TODO: placeholder types are generally `()` - line 629: // TODO: make this streaming eden/mononoke/mercurial/bundles/src/part_encode.rs (2 lines): - line 176: // TODO: don't send too large or too small chunks to clients - line 181: // TODO: produce an error part for (some kinds of?) errors eden/scm/edenscm/mercurial/discovery.py (2 lines): - line 95: # TODO remove call to nodesbetween. - line 96: # TODO populate attributes on outgoing instance instead of setting build/fbcode_builder/getdeps/platform.py (2 lines): - line 56: # TODO: Ideally, this function would inspect the current cgroup for any - line 88: # TODO: There may be some way to approximate an availability eden/fs/cli/doctor/check_os.py (2 lines): - line 82: # TODO: Reword these messages prior to public release - line 96: # TODO: Reword these messages prior to public release eden/scm/edenscm/hgext/amend/metaedit.py (2 lines): - line 314: # TODO: set poroper phase boundaries (affects secret - line 323: # TODO: if the author and message are the same, don't create a eden/mononoke/mercurial/revlog/manifest/revlog.rs (2 lines): - line 45: File(file::File), // TODO stream - line 46: Executable(file::File), // TODO stream eden/mononoke/repo_client/unbundle/src/push_redirector.rs (2 lines): - line 87: // TODO: This function needs to be extended - line 618: // TODO: this can only be implemented once we have a way eden/scm/edenscm/mercurial/dirstate.py (2 lines): - line 957: # TODO: get rid of this when EdenFS migrates to TreeState. - line 1182: # TODO: fire this inside filesystem. fixup is a list of files that eden/fs/store/BackingStore.h (2 lines): - line 57: * TODO: Replace rootID with objectId once objectId is widened. - line 154: * TODO: When EdenFS no longer uses hg import helper subprocesses and when eden/mononoke/mercurial/bundles/src/delta.rs (2 lines): - line 38: // TODO: handle negative values for all the above - line 51: // TODO: avoid copies here by switching this to Bytes eden/mononoke/mercurial/types/src/blobs/upload.rs (2 lines): - line 70: pub p1: Option, // TODO: How hard is it to udpate those? - line 370: // TODO: Introduce Metadata bytes? eden/fs/store/Diff.cpp (2 lines): - line 192: // TODO: load file contents directly from context->store if gitIgnoreEntry is - line 199: // TODO: add an API to DiffCallback to report user errors like this eden/scm/edenscm/mercurial/commands/__init__.py (2 lines): - line 1416: # TODO compression options should be derived from bundlespec parsing. - line 4669: # TODO: Consider migrate to repo.pull to avoid the race eden/scm/edenscm/hgext/convert/subversion.py (2 lines): - line 983: # TODO: ra.get_file transmits the whole file instead of diffs. - line 1378: # TODO: implement something better if necessary and feasible eden/mononoke/pushrebase/src/lib.rs (2 lines): - line 384: // TODO: Avoid this clone - line 502: // FIXME: it would also be great to do a manifest diff for old_id eden/mononoke/lfs_server/src/batch.rs (2 lines): - line 146: // TODO: Unit tests for this. We could use a client that lets us do stub things. - line 595: // TODO: Do we want to validate the client's Accept & Content-Type headers here? eden/mononoke/git/import_tools/src/lib.rs (2 lines): - line 111: // TODO: Try to produce copy-info? - line 429: // TODO: Should we have further extras? eden/scm/lib/hg-http/src/lib.rs (2 lines): - line 127: // TODO: How to tell whether it is downloading or uploading? - line 187: // TODO: gauges: rx_bytes and tx_bytes; histograms: request_time_ms, response_delay_ms eden/scm/lib/types/src/path.rs (2 lines): - line 64: /// TODO: There is more validation that could be done here. Windows has a broad list of illegal - line 695: // TODO: directly operate on the RepoPath components. build/fbcode_builder/getdeps.py (2 lines): - line 834: # TODO: we could just go ahead and build it here, but I - line 904: # TODO: Break up complex function eden/scm/edenscm/mercurial/filemerge.py (2 lines): - line 840: # TODO: Add a workingfilectx.write(otherfilectx) path so we can use - line 858: # TODO: Break this import cycle somehow. (filectx -> ctx -> fileset -> eden/mononoke/server/monitoring/src/lib.rs (1 line): - line 22: // TODO: Stop using this one-off for Mononoke server, and instead use the one from cmdlib. eden/fs/inodes/overlay/FsOverlay.cpp (1 line): - line 651: // TODO: It might be worth maintaining a memory-mapped set to rapidly eden/mononoke/repo_client/mononoke_repo/src/lib.rs (1 line): - line 93: // TODO: Update Metaconfig so we just have this in config: eden/mononoke/mercurial/bundles/src/utils.rs (1 line): - line 158: // TODO: just enforce ASCII-only and make this simpler. eden/scm/edenscm/hgext/extlib/pywatchman/bser.c (1 line): - line 724: // TODO: On Python 3 the Unicode APIs are smarter: we might be able to use eden/mononoke/walker/src/new_walker/main.rs (1 line): - line 35: // FIXME: Investigate why some SQL queries kicked off by the walker take 30s or more. eden/fs/inodes/CheckoutAction.cpp (1 line): - line 330: // TODO: check for permissions changes configerator/structs/scm/hg/hgclientconf/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when eden/scm/edenscm/mercurial/templater.py (1 line): - line 1013: # TODO: perhaps this should be evalfuncarg(), but it can't because hgweb eden/mononoke/filestore/src/multiplexer.rs (1 line): - line 87: // TODO: Pass through an executor? eden/mononoke/unbundle_replay/src/hooks.rs (1 line): - line 44: timestamps: Arc>, // TODO: it'd be nice the hooks could be a lifetime. eden/fs/inodes/Overlay.h (1 line): - line 163: * TODO: It would be easy to extend this function to allocate a range of eden/scm/lib/cliparser/src/alias.rs (1 line): - line 160: // TODO: This might be an error case. eden/fs/telemetry/SubprocessScribeLogger.cpp (1 line): - line 152: // TODO: We could attempt to restart the process here. eden/mononoke/mercurial/bundles/src/bundle2_encode.rs (1 line): - line 301: // TODO: bail on (some forms of) errors? eden/scm/edenscm/mercurial/formatter.py (1 line): - line 448: # TODO: add support for filectx. probably each template keyword or eden/fs/utils/ImmediateFuture.h (1 line): - line 218: // TODO: At the cost of reimplementing parts of Try, we could save a byte or eden/mononoke/derived_data/mercurial_derived_data/derive_hg_manifest.rs (1 line): - line 297: // TODO: move `Blobrepo::store_file_changes` logic in here eden/mononoke/megarepo_api/if/thrift_build.rs (1 line): - line 33: // TODO: replace canonicalize() with std::path::absolute() when eden/mononoke/repo_client/unbundle/src/response.rs (1 line): - line 71: // TODO: possibly enable compression support once this is fixed. eden/scm/edenscm/hgext/win32mbcs.py (1 line): - line 190: # TODO: decide use of config section for this extension eden/fs/telemetry/StructuredLogger.h (1 line): - line 34: // TODO: consider moving the event to another thread and populating the eden/scm/edenscm/mercurial/bookmarks.py (1 line): - line 1284: TODO: Remove this once remotenames is default on everywhere. eden/scm/edenscm/mercurial/stdiopeer.py (1 line): - line 83: # TODO this response parsing is probably suboptimal for large configerator/structs/scm/mononoke/repos/commitsync/thrift_build.rs (1 line): - line 32: // TODO: replace canonicalize() with std::path::absolute() when eden/mononoke/cmdlib/src/args/matches.rs (1 line): - line 104: // TODO: FacebookKV for this one? eden/scm/edenscmnative/bindings/modules/pyworkingcopy/src/lib.rs (1 line): - line 92: // TODO: Add error handling eden/mononoke/microwave/if/thrift_build.rs (1 line): - line 33: // TODO: replace canonicalize() with std::path::absolute() when eden/mononoke/mononoke_types/src/repo.rs (1 line): - line 51: // TODO: (rain1) T30368905 Instead of using this struct directly, have a wrapper around it that eden/fs/model/git/GlobMatcher.h (1 line): - line 113: * TODO: It's perhaps worth doing some small-string optimization here. eden/scm/edenscm/hgext/journal.py (1 line): - line 185: # TODO: Once we fully convert to Python 3 we can change this to the much nicer Python 3 eden/fs/inodes/InodeBase.h (1 line): - line 625: * TODO: The mount point rename lock does not exist yet. We need to add it eden/mononoke/blobrepo/blobrepo_hg/src/lib.rs (1 line): - line 16: // TODO: This is exported for testing - is this the right place for it? eden/fs/model/git/GitBlob.cpp (1 line): - line 42: // TODO: We probably should add a Cursor::managedClone() function that does eden/mononoke/filestore/src/fetch.rs (1 line): - line 26: // TODO: Make this configurable? Perhaps as a global, since it's something that only makes sense at eden/mononoke/blobstore/packblob/if/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when eden/scm/lib/revisionstore/src/repack.rs (1 line): - line 369: // TODO: This is a bit fragile as a bug in commit_pending not returning a path could lead eden/fs/config/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when eden/mononoke/tools/admin/src/commands/fetch.rs (1 line): - line 70: // TODO: Add unode manifest, fsnode and skmf support eden/mononoke/changesets/if/thrift_build.rs (1 line): - line 32: // TODO: replace canonicalize() with std::path::absolute() when eden/scm/lib/revisionstore/src/historyindex.rs (1 line): - line 523: // TODO: test write() when duplicate files and duplicate nodes passed eden/scm/edenscm/mercurial/scmutil.py (1 line): - line 357: # TODO: Move this into a background task that renders from eden/fs/utils/FsChannelTypes.h (1 line): - line 37: // TODO fill this in with data to support takeover on windows eden/scm/lib/hgcommands/src/run.rs (1 line): - line 653: // TODO: Replace this with the 'exitcode' crate once it's available. eden/fs/nfs/Mountd.cpp (1 line): - line 140: // TODO: This needs to be implemented to support umount without the eden/mononoke/rate_limiting/src/lib.rs (1 line): - line 119: // TODO (harveyhunt): Pass identities rather than Some(identities) once LFS server has eden/mononoke/newfilenodes/src/history.rs (1 line): - line 15: // TODO: We could store this more efficiently by deduplicating filenode IDs. eden/mononoke/mercurial/types/src/lib.rs (1 line): - line 31: //! resulting in `HgNodeHash` (TODO: rename HgNodeHash -> NodeId?). This means manifests and files eden/scm/edenscm/hgext/chistedit.py (1 line): - line 183: # TODO: swap should not know about histeditrule's internals eden/fs/telemetry/IHiveLogger.h (1 line): - line 39: // TODO: Deprecate ScribeLogger and rename this class ScribeLogger. CMake/EdenConfigChecks.cmake (1 line): - line 110: # TODO: It shouldn't be too hard to turn RocksDB and sqlite3 into optional eden/mononoke/filestore/src/prepare.rs (1 line): - line 92: // TODO: Convert this along with other store calls to impl Storable for eden/fs/testharness/TestServer.cpp (1 line): - line 54: // TODO: in the future we should build a better mechanism for controlling this eden/mononoke/derived_data/remote/if/thrift_build.rs (1 line): - line 37: // TODO: replace canonicalize() with std::path::absolute() when eden/scm/edenscm/hgext/commitcloud/sync.py (1 line): - line 64: # TODO (liubovd): remove the filer once the issue is fixed. build/fbcode_builder/docker_builder.py (1 line): - line 37: # system packages are installed. TODO: For users not defined in the eden/mononoke/bonsai_hg_mapping/if/thrift_build.rs (1 line): - line 33: // TODO: replace canonicalize() with std::path::absolute() when eden/fs/inodes/treeoverlay/TreeOverlayStore.cpp (1 line): - line 161: // TODO: check `user_version` and migrate schema if necessary eden/fs/fuse/FuseChannel.h (1 line): - line 125: * TODO: 32 bytes for an optional, immutable argument string is excessive. configerator/structs/scm/mononoke/megarepo/version_cconf_index/thrift_build.rs (1 line): - line 32: // TODO: replace canonicalize() with std::path::absolute() when eden/scm/edenscm/hgext/commitcloud/httpsservice.py (1 line): - line 250: # TODO: Make this a dedicated request build/fbcode_builder/getdeps/dyndeps.py (1 line): - line 117: # TODO: audit that both source paths have the same inode number eden/fs/py/eden/thrift/legacy.py (1 line): - line 46: # TODO: https://github.com/python/mypy/issues/2427 eden/scm/lib/exchange/src/lib.rs (1 line): - line 31: // TODO: move to a bookmarks crate eden/fs/cli/top.py (1 line): - line 605: # TODO: daemon memory/inode stats on line 2 eden/fs/cli/proc_utils_win.py (1 line): - line 140: # TODO: Finding all EdenFS processes is not yet implemented on Windows configerator/structs/scm/mononoke/tunables/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when eden/mononoke/git/git_types/if/thrift_build.rs (1 line): - line 32: // TODO: replace canonicalize() with std::path::absolute() when eden/fs/telemetry/SessionInfo.cpp (1 line): - line 61: // TODO: Implement build version lookup, e.g. 1903 eden/mononoke/cmdlib/extensions/lib.rs (1 line): - line 11: // TODO: We may want to add the Args type defaults are set for and eden/scm/edenscm/hgext/pushrebase/__init__.py (1 line): - line 710: # TODO: clean up eden/fs/journal/JournalDelta.h (1 line): - line 49: // TODO: It may make sense to maintain an existenceChanged bit to distinguish eden/fs/service/eden.thrift (1 line): - line 936: // TODO: Count the number of thrift requests eden/fs/monitor/EdenInstance.cpp (1 line): - line 177: // TODO: rotate/truncate the startup log eden/mononoke/derived_data/mercurial_derived_data/derive_hg_changeset.rs (1 line): - line 238: // TODO: eden/fs/store/SqliteLocalStore.cpp (1 line): - line 174: // TODO: we need `or ignore` otherwise we hit primary key violations configerator/structs/scm/mononoke/pushredirect/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when configerator/structs/scm/mononoke/repos/repos.thrift (1 line): - line 464: // TODO: Once the whole config is hot reloadable, move redaction configerator/structs/scm/mononoke/hgserverconf/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when eden/mononoke/phases/sqlphases/src/sql_store.rs (1 line): - line 233: // TODO (liubovd): improve sqlite query to make it semantically the same eden/fs/model/Tree.cpp (1 line): - line 25: // TODO: we should consider using a standard memory framework across eden/mononoke/tools/admin/src/commands/blobstore_unlink.rs (1 line): - line 81: // TODO: Do this for all blobstores that can support unlink, not just SQLBlob eden/scm/edenscm/mercurial/httpclient/_readers.py (1 line): - line 229: # TODO: avoid this string concatenation if possible eden/fs/cli/doctor/check_hg.py (1 line): - line 277: # TODO: make sure the sharedpath file points to a valid .hg directory that eden/fs/telemetry/TraceBus-inl.h (1 line): - line 176: // TODO: If it were safe to access Subscription::unsubscribe when the lock eden/mononoke/reachabilityindex/if/thrift_build.rs (1 line): - line 32: // TODO: replace canonicalize() with std::path::absolute() when eden/scm/lib/indexedlog/src/index.rs (1 line): - line 2572: // TODO: Review this decision. eden/mononoke/mercurial/types/if/thrift_build.rs (1 line): - line 32: // TODO: replace canonicalize() with std::path::absolute() when build/fbcode_builder/getdeps/builder.py (1 line): - line 122: # TODO: Introduce some sort of defaults config that can select by configerator/structs/scm/mononoke/redaction/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when configerator/structs/scm/mononoke/fastreplay/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when eden/mononoke/cmds/admin/blobstore_fetch.rs (1 line): - line 254: // TODO: (rain1) T30974137 add a better way to print out file contents eden/scm/edenscm/hgext/fbscmquery.py (1 line): - line 192: # TODO: 's/svnrev/globalrev' after turning off Subversion servers. We will eden/scm/i18n/polib.py (1 line): - line 969: # flags (TODO: wrapping ?) eden/scm/edenscm/hgext/amend/split.py (1 line): - line 151: # TODO: Does no seem like the best way to do this build/fbcode_builder/getdeps/py_wheel_builder.py (1 line): - line 158: # TODO: process the subdirectories of data_dir_name eden/scm/lib/util/src/path.rs (1 line): - line 256: // TODO: We should at least generate a warning here. We cannot because we eden/mononoke/derived_data/utils/lib.rs (1 line): - line 72: // TODO: come up with a better way to maintain these dependencies T77090285 eden/fs/inodes/InodeBase.cpp (1 line): - line 346: // TODO: Is it worth implementing relatime-like logic? eden/scm/edenscm/hgext/infinitepush/common.py (1 line): - line 48: # TODO: make a single query to the bundlestore.index eden/mononoke/cmdlib/logging/logging_args.rs (1 line): - line 107: // TODO: separate the panic handler out from logging eden/fs/takeover/takeover.thrift (1 line): - line 46: // TODO: remove this field, it is no longer used eden/fs/cli_rs/edenfs-commands/src/minitop.rs (1 line): - line 38: // TODO: For minitop, we may want to allow querying for < 1s, but this eden/scm/edenscm/mercurial/commands/eden.py (1 line): - line 978: # TODO: It would be nice to automatically look up the current eden/mononoke/mercurial/types/src/envelope/manifest_envelope.rs (1 line): - line 44: // TODO: (rain1) T30973227 parse contents and print out in a better fashion eden/mononoke/cmds/admin/blobstore_unlink.rs (1 line): - line 83: // TODO: Do this for all blobstores that can support unlink, not just SQLBlob eden/scm/lib/cliparser/src/parser.rs (1 line): - line 1071: // TODO for now this is expected to be the default flag val, but later a Value eden/scm/edenscm/mercurial/streamclone.py (1 line): - line 364: # TODO: get rid of (potential) inconsistency eden/mononoke/mercurial/types/src/envelope/changeset_envelope.rs (1 line): - line 42: // TODO: (rain1) T30970792 parse contents and print out in a better fashion common/logging/logging.h (1 line): - line 12: // TODO: actually implement this eden/mononoke/scs/if/thrift_build.rs (1 line): - line 33: // TODO: replace canonicalize() with std::path::absolute() when eden/mononoke/mercurial/types/src/delta.rs (1 line): - line 226: // TODO: make this more rigorous, e.g. by using params such that p95 = size. eden/mononoke/blobrepo_utils/src/bonsai/manifest.rs (1 line): - line 222: // TODO: Update this to support stepparents eden/integration/snapshot/types/basic.py (1 line): - line 97: # TODO: These symlink permissions should ideally be 0o777 eden/scm/lib/edenapi/types/proc_macros/lib.rs (1 line): - line 20: // TODO: Future improvements eden/mononoke/mutable_renames/if/thrift_build.rs (1 line): - line 32: // TODO: replace canonicalize() with std::path::absolute() when eden/fs/prjfs/PrjfsChannel.cpp (1 line): - line 1200: // TODO: We need to add an extra layer to absorb all the exceptions generated in eden/mononoke/bonsai_svnrev_mapping/if/thrift_build.rs (1 line): - line 32: // TODO: replace canonicalize() with std::path::absolute() when eden/fs/inodes/DeferredDiffEntry.cpp (1 line): - line 127: // TODO: Load the inode in parallel with loading the source control data eden/scm/lib/indexedlog/src/log/mod.rs (1 line): - line 604: // TODO: Review this decision. eden/mononoke/tunables/src/lib.rs (1 line): - line 318: // TODO: Instead of refreshing tunables every loop iteration, eden/scm/edenscm/mercurial/treestate.py (1 line): - line 206: # TODO: figure out whether "copied" needs to be preserved here. eden/fs/utils/SpawnedProcess.cpp (1 line): - line 375: // FIXME: multibyte? eden/mononoke/cmds/admin/async_requests.rs (1 line): - line 215: // TODO: pretty printing of the request details eden/mononoke/benchmarks/simulated_repo/lib/repository.rs (1 line): - line 163: // TODO: eden/fs/store/BlobAccess.h (1 line): - line 26: * TODO: To support large files, they should be split into a series of blobs, eden/scm/lib/backingstore/src/raw/tree.rs (1 line): - line 70: // TODO: we currently do not have these information stored in Mercurial. eden/mononoke/mononoke_types/src/rawbundle2.rs (1 line): - line 69: // TODO (T26959816) -- allow Thrift to represent binary as Bytes eden/fs/utils/IDGen.h (1 line): - line 21: * TODO: It might be beneficial to add a parameter to request more than one eden/mononoke/mercurial/bundles/src/quickcheck_types.rs (1 line): - line 253: // TODO: should these be more structured? e.g. base = p1 some of the time eden/scm/lib/pathmatcher/src/utils.rs (1 line): - line 14: /// TODO: Fix error handling so it returns an error when the input is eden/scm/edenscm/hgext/commitcloud/backuplock.py (1 line): - line 82: # TODO: support windows eden/fs/inodes/CheckoutContext.h (1 line): - line 59: // TODO: make this configurable on checkout start eden/mononoke/segmented_changelog/src/tests.rs (1 line): - line 883: tokio::time::pause(); // TODO: pause only works with the `current_thread` Runtime. eden/scm/edenscm/hgext/commitcloud/commands.py (1 line): - line 318: # TODO: suggest user to archive the old workspace if they want to eden/scm/edenscm/mercurial/mdiff.py (1 line): - line 547: # TODO: deltas eden/mononoke/cmdlib/mononoke_app/src/fb303.rs (1 line): - line 25: // TODO: switch mononoke server to use the same flags as everybody. eden/mononoke/filenodes/if/thrift_build.rs (1 line): - line 33: // TODO: replace canonicalize() with std::path::absolute() when configerator/structs/scm/mononoke/observability/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when configerator/structs/scm/mononoke/lfs_server/thrift_build.rs (1 line): - line 32: // TODO: replace canonicalize() with std::path::absolute() when build/fbcode_builder/getdeps/buildopts.py (1 line): - line 521: # TODO: `mkscratch` doesn't currently know how best to place things on eden/fs/store/ObjectCache.h (1 line): - line 230: * TODO: This data structure could be implemented more efficiently. But since eden/fs/service/thrift_streaming/thrift_build.rs (1 line): - line 32: // TODO: replace canonicalize() with std::path::absolute() when eden/scm/edenscm/mercurial/manifest.py (1 line): - line 713: # TODO: We eventually want p1, p2, and linkrev exposed on this class, eden/scm/edenscm/mercurial/templatekw.py (1 line): - line 621: # TODO: perhaps 'ctx' should be dropped from mapping because manifest configerator/structs/scm/mononoke/xdb_gc/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when eden/scm/lib/tracing-runtime-callsite/src/runtime_callsite.rs (1 line): - line 221: // TODO: Uncomment when tracing >= 0.1.18. eden/mononoke/mercurial/bundles/src/wirepack/packer.rs (1 line): - line 12: #![allow(deprecated)] // TODO: T29077977 convert from put_X:: -> put_X_be configerator/structs/scm/mononoke/ratelimiting/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when configerator/structs/scm/mononoke/qps/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when eden/scm/exec/hgmain/src/chg.rs (1 line): - line 74: /// TODO: implement command-based filtering logic eden/scm/lib/checkout/src/lib.rs (1 line): - line 649: // TODO: This should be done in parallel. Maybe with the new vfs async batch APIs? eden/fs/model/git/GlobMatcher.cpp (1 line): - line 57: // TODO: Do not let a negated character class pattern match a "." at the start eden/scm/lib/hgcommits/src/strip.rs (1 line): - line 12: // TODO: Consider migrating to async, or get rid of strip in tests. eden/mononoke/mononoke_types/if/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when eden/scm/edenscm/mercurial/repository.py (1 line): - line 44: TODO audit/clean consumers and more clearly define the contents of this eden/scm/edenscm/mercurial/context.py (1 line): - line 1197: # TODO: Consider following renames. eden/mononoke/repo_client/unbundle/src/resolver.rs (1 line): - line 705: // TODO: we probably run hooks even if no changesets are pushed? eden/scm/lib/xdiff/src/lib.rs (1 line): - line 311: // TODO: Expose a constructor for this so that it cannot be constructed wiht seed: None. eden/scm/edenscm/mercurial/commands/blackbox.py (1 line): - line 93: # TODO: Consider properly templatize the output. So users can choose fields configerator/structs/scm/mononoke/repos/repos/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when eden/fs/config/ReloadableConfig.cpp (1 line): - line 37: // TODO: Update this monitoring code to use FileChangeMonitor. eden/mononoke/lfs_protocol/src/protocol.rs (1 line): - line 318: // TODO: It'd be nice to generate those too. eden/scm/edenscm/hgext/phrevset.py (1 line): - line 277: # TODO: 's/svnrev/globalrev' after turning off Subversion eden/scm/edenscm/hgext/interactiveui.py (1 line): - line 85: # TODO: figure out tests eden/fs/service/thrift_build.rs (1 line): - line 33: // TODO: replace canonicalize() with std::path::absolute() when eden/fs/inodes/InodeNumber.h (1 line): - line 125: // TODO: It may be worth using a different hash function. The default eden/mononoke/tunables/tunables-derive/lib.rs (1 line): - line 261: // TODO: Handle full paths to the types, such as eden/scm/edenscm/mercurial/filesystem.py (1 line): - line 381: # TODO: All ignore logic should be encapsulated in the matcher and eden/mononoke/repo_client/unbundle/src/hook_running.rs (1 line): - line 74: // TODO: Need to run hooks on Push, not just Pushrebase eden/fs/config/TomlConfig.h (1 line): - line 58: // TODO: Much of this function could be moved into the .cpp file. eden/mononoke/blobstore/if/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when eden/scm/lib/clidispatch/src/dispatch.rs (1 line): - line 320: // FIXME: Try to "infer repo" here. eden/scm/lib/manifest-tree/src/store.rs (1 line): - line 425: // TODO: benchmark taking a buffer as a parameter eden/scm/lib/dag/src/idmap/mem_idmap.rs (1 line): - line 169: // TODO: Reconsider re-assign master cases. Currently they are ignored. eden/mononoke/scs_server/src/scuba_response.rs (1 line): - line 87: // TODO: report cs_ids and actual error where possible eden/fs/config/eden_config.thrift (1 line): - line 40: // TODO: In the future it may be nice to add a sourceValue field that eden/mononoke/derived_data/changeset_info/if/thrift_build.rs (1 line): - line 32: // TODO: replace canonicalize() with std::path::absolute() when eden/fs/cli/win_ui.py (1 line): - line 10: # TODO: Implement a custom WindowsOutput class that provides color support in eden/scm/lib/hgcommands/src/commands/debug/scmstorereplay.rs (1 line): - line 27: // TODO: Take into account log timings to yield a more faithful eden/integration/lib/buck.py (1 line): - line 34: # TODO we probably need to do env scrubbing? eden/mononoke/mercurial/bundles/src/changegroup/packer.rs (1 line): - line 94: // TODO: will need to encode tree manifests here as well eden/scm/edenscm/mercurial/treedirstate.py (1 line): - line 437: # TODO: register map store offset with 'tr' eden/fs/store/ObjectStore.h (1 line): - line 268: * TODO: It never makes sense to rlock an LRU cache, since cache hits mutate eden/mononoke/bonsai_globalrev_mapping/if/thrift_build.rs (1 line): - line 32: // TODO: replace canonicalize() with std::path::absolute() when eden/scm/edenscm/mercurial/cmdutil.py (1 line): - line 3612: # avoid cycle (TODO: should be removed in default branch) eden/mononoke/megarepo_api/async_requests/src/types.rs (1 line): - line 367: // TODO: maybe use structured error? eden/mononoke/common/rendezvous/src/rendez_vous.rs (1 line): - line 242: rdv_stats.inflight.increment_value(fb, -1); // TODO: This should use a scopeguard... eden/scm/lib/radixbuf/src/base16.rs (1 line): - line 81: // TODO: Use (self.1 + n).min(self.2) once ord_max_min is available (Rust 1.22) eden/fs/inodes/overlay/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when eden/scm/edenscm/mercurial/annotate.py (1 line): - line 109: # TODO: change this? eden/scm/lib/backingstore/src/remotestore.rs (1 line): - line 22: // TODO: Once we have EdenAPI production ready, remove this. eden/mononoke/tools/admin/src/commands/blobstore/fetch.rs (1 line): - line 59: // TODO: Missing types, e.g. RedactionKeyList, DeletedManifest, eden/mononoke/walker/src/main.rs (1 line): - line 21: // FIXME: Investigate why some SQL queries kicked off by the walker take 30s or more. eden/mononoke/walker/src/commands/detail/blobstore.rs (1 line): - line 122: // TODO parse out NodeType from string key prefix if we can. Or better, make blobstore keys typed? eden/scm/edenscm/mercurial/git.py (1 line): - line 272: # TODO: Figure out how to remove refs. build/fbcode_builder/getdeps/copytree.py (1 line): - line 75: TODO: I'd like to either extend this or add a variant that eden/scm/edenscm/hgext/amend/common.py (1 line): - line 199: # TODO: In case not date is given, we should take the old commit date eden/scm/edenscmnative/bindings/modules/pysptui/src/lib.rs (1 line): - line 43: // TODO: export this from streampager configerator/structs/scm/mononoke/megarepo/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when eden/scm/lib/backingstore/src/backingstore/contentstores.rs (1 line): - line 92: // TODO: LFS support eden/fs/telemetry/LogEvent.h (1 line): - line 55: // TODO: add vector support if needed. eden/scm/lib/tracing-runtime-callsite/src/intern_str.rs (1 line): - line 22: // TODO: Use get_or_insert_owned once stabilized (https://github.com/rust-lang/rust/issues/60896) eden/scm/edenscm/mercurial/hook.py (1 line): - line 187: # TODO: check whether the hook item is trusted or not eden/fs/utils/ImmediateFuture-inl.h (1 line): - line 126: // TODO: This could return semi_.isReady() if we also changed thenTry to