bowler/tool.py (296 lines of code) (raw):

#!/usr/bin/env python3 # # Copyright (c) Facebook, Inc. and its affiliates. # # This source code is licensed under the MIT license found in the # LICENSE file in the root directory of this source tree. import difflib import logging import multiprocessing import os import sys import time from queue import Empty from typing import Any, Iterator, List, Optional, Sequence, Tuple import click from fissix import pygram from fissix.pgen2.parse import ParseError from fissix.refactor import RefactoringTool, _detect_future_features from moreorless.patch import PatchException, apply_single_file from .helpers import filename_endswith from .types import ( BadTransform, BowlerException, BowlerQuit, Filename, FilenameMatcher, Fixers, Hunk, Processor, RetryFile, ) PROMPT_HELP = { "y": "apply this hunk", "n": "skip this hunk", "a": "apply this hunk and all remaining hunks for this file", "d": "skip this hunk and all remaining hunks for this file", "q": "quit; do not apply this hunk or any remaining hunks", "?": "show help", } log = logging.getLogger(__name__) def diff_texts(a: str, b: str, filename: str) -> Iterator[str]: lines_a = a.splitlines() lines_b = b.splitlines() return difflib.unified_diff(lines_a, lines_b, filename, filename, lineterm="") def prompt_user(question: str, options: str, default: str = "") -> str: options = options.lower() default = default.lower() assert len(default) < 2 and default in options if "?" not in options: options += "?" prompt_options = ",".join(o.upper() if o == default else o for o in options) prompt = f"{question} [{prompt_options}]? " result = "" while True: result = input(prompt).strip().lower() if result == "?": for option in PROMPT_HELP: click.secho(f"{option} - {PROMPT_HELP[option]}", fg="red", bold=True) elif len(result) == 1 and result in options: return result elif result: click.echo(f'invalid response "{result}"') elif default: return default class BowlerTool(RefactoringTool): NUM_PROCESSES = os.cpu_count() or 1 IN_PROCESS = False # set when run DEBUG mode from command line def __init__( self, fixers: Fixers, *args, interactive: bool = True, write: bool = False, silent: bool = False, in_process: Optional[bool] = None, hunk_processor: Processor = None, filename_matcher: Optional[FilenameMatcher] = None, **kwargs, ) -> None: options = kwargs.pop("options", {}) super().__init__(fixers, *args, options=options, **kwargs) self.queue_count = 0 self.queue = multiprocessing.JoinableQueue() # type: ignore self.results = multiprocessing.Queue() # type: ignore self.semaphore = multiprocessing.Semaphore(self.NUM_PROCESSES) self.interactive = interactive self.write = write self.silent = silent if in_process is None: in_process = self.IN_PROCESS # pick the most restrictive of flags; we can pickle fixers when # using spawn. if sys.platform == "win32" or sys.version_info > (3, 7): in_process = True self.in_process = in_process self.exceptions: List[BowlerException] = [] if hunk_processor is not None: self.hunk_processor = hunk_processor else: self.hunk_processor = lambda f, h: True self.filename_matcher = filename_matcher or filename_endswith(".py") def log_error(self, msg: str, *args: Any, **kwds: Any) -> None: self.logger.error(msg, *args, **kwds) def get_fixers(self) -> Tuple[Fixers, Fixers]: fixers = [f(self.options, self.fixer_log) for f in self.fixers] pre: Fixers = [f for f in fixers if f.order == "pre"] post: Fixers = [f for f in fixers if f.order == "post"] return pre, post def processed_file( self, new_text: str, filename: str, old_text: str = "", *args, **kwargs ) -> List[Hunk]: self.files.append(filename) hunks: List[Hunk] = [] if old_text != new_text: a, b, *lines = list(diff_texts(old_text, new_text, filename)) hunk: Hunk = [] for line in lines: if line.startswith("@@"): if hunk: hunks.append([a, b, *hunk]) hunk = [] hunk.append(line) if hunk: hunks.append([a, b, *hunk]) original_grammar = self.driver.grammar if "print_function" in _detect_future_features(new_text): self.driver.grammar = pygram.python_grammar_no_print_statement try: new_tree = self.driver.parse_string(new_text) if new_tree is None: raise AssertionError("Re-parsed CST is None") except Exception as e: raise BadTransform( f"Transforms generated invalid CST for {filename}", filename=filename, hunks=hunks, ) from e finally: self.driver.grammar = original_grammar return hunks def refactor_file(self, filename: str, *a, **k) -> List[Hunk]: try: hunks: List[Hunk] = [] input, encoding = self._read_python_source(filename) if input is None: # Reading the file failed. return hunks except (OSError, UnicodeDecodeError) as e: log.error(f"Skipping {filename}: failed to read because {e}") return hunks try: if not input.endswith("\n"): input += "\n" tree = self.refactor_string(input, filename) if tree: hunks = self.processed_file(str(tree), filename, input) except ParseError as e: log.exception("Skipping {filename}: failed to parse ({e})") return hunks def refactor_dir(self, dir_name: str, *a, **k) -> None: """Descends down a directory and refactor every Python file found. Python files are those for which `self.filename_matcher(filename)` returns true, to allow for custom extensions. Files and subdirectories starting with '.' are skipped. """ for dirpath, dirnames, filenames in os.walk(dir_name): self.log_debug("Descending into %s", dirpath) dirnames.sort() filenames.sort() for name in filenames: fullname = os.path.join(dirpath, name) if not name.startswith(".") and self.filename_matcher( Filename(fullname) ): self.queue_work(Filename(fullname)) # Modify dirnames in-place to remove subdirs with leading dots dirnames[:] = [dn for dn in dirnames if not dn.startswith(".")] def refactor_queue(self) -> None: self.semaphore.acquire() while True: filename = self.queue.get() if filename is None: break try: hunks = self.refactor_file(filename) self.results.put((filename, hunks, None)) except RetryFile: self.log_debug(f"Retrying {filename} later...") self.queue.put(filename) except BowlerException as e: log.exception(f"Bowler exception during transform of {filename}: {e}") self.results.put((filename, e.hunks, e)) except Exception as e: log.exception(f"Skipping {filename}: failed to transform because {e}") self.results.put((filename, [], e)) finally: self.queue.task_done() self.semaphore.release() def queue_work(self, filename: Filename) -> None: self.queue.put(filename) self.queue_count += 1 def refactor(self, items: Sequence[str], *a, **k) -> None: """Refactor a list of files and directories.""" for dir_or_file in sorted(items): if os.path.isdir(dir_or_file): self.refactor_dir(dir_or_file) else: self.queue_work(Filename(dir_or_file)) children: List[multiprocessing.Process] = [] if self.in_process: self.queue.put(None) self.refactor_queue() else: child_count = max(1, min(self.NUM_PROCESSES, self.queue_count)) self.log_debug(f"starting {child_count} processes") for i in range(child_count): child = multiprocessing.Process(target=self.refactor_queue) child.start() children.append(child) self.queue.put(None) results_count = 0 while True: try: filename, hunks, exc = self.results.get_nowait() results_count += 1 if exc: self.log_error(f"{type(exc).__name__}: {exc}") if exc.__cause__: self.log_error( f" {type(exc.__cause__).__name__}: {exc.__cause__}" ) if isinstance(exc, BowlerException) and exc.hunks: diff = "\n".join("\n".join(hunk) for hunk in exc.hunks) self.log_error(f"Generated transform:\n{diff}") self.exceptions.append(exc) else: self.log_debug(f"results: got {len(hunks)} hunks for {filename}") self.process_hunks(filename, hunks) except Empty: if self.queue.empty() and results_count == self.queue_count: break elif not self.in_process and not any( child.is_alive() for child in children ): self.log_debug(f"child processes stopped without consuming work") break else: time.sleep(0.05) except BowlerQuit: for child in children: child.terminate() break self.log_debug(f"all children stopped and all diff hunks processed") def process_hunks(self, filename: Filename, hunks: List[Hunk]) -> None: auto_yes = False result = "" accepted_hunks = "" for hunk in hunks: if self.hunk_processor(filename, hunk) is False: continue if not self.silent: for line in hunk: if line.startswith("---"): click.secho(line, fg="red", bold=True) elif line.startswith("+++"): click.secho(line, fg="green", bold=True) elif line.startswith("-"): click.secho(line, fg="red") elif line.startswith("+"): click.secho(line, fg="green") else: click.echo(line) if self.interactive: if auto_yes: click.echo(f"Applying remaining hunks to {filename}") result = "y" else: result = prompt_user("Apply this hunk", "ynqad", "n") self.log_debug(f"result = {result}") if result == "q": self.apply_hunks(accepted_hunks, filename) raise BowlerQuit() elif result == "d": self.apply_hunks(accepted_hunks, filename) return # skip all remaining hunks elif result == "n": continue elif result == "a": auto_yes = True result = "y" elif result != "y": raise ValueError("unknown response") if result == "y" or self.write: accepted_hunks += "\n".join(hunk[2:]) + "\n" self.apply_hunks(accepted_hunks, filename) def apply_hunks(self, accepted_hunks, filename): if accepted_hunks: with open(filename) as f: data = f.read() try: accepted_hunks = f"--- {filename}\n+++ {filename}\n{accepted_hunks}" new_data = apply_single_file(data, accepted_hunks) except PatchException as err: log.exception(f"failed to apply patch hunk: {err}") return with open(filename, "w") as f: f.write(new_data) def run(self, paths: Sequence[str]) -> int: if not self.errors: self.refactor(paths) self.summarize() return int(bool(self.errors or self.exceptions))