Summary: 189 instances, 175 unique Text Count * TODO: Or even better: why don't I just send over the encoded short header 1 // TODO figure out a better interface here. 10 * TODO: Consider adding the type field here so that backend doesn't have to 1 // TODO: pace d6d probing when there's congestion 1 // TODO: add protection from calling "consume" in the middle of the peek - 1 // TODO: maxBatchSize is only a good start value when each transport does 1 // TODO: Same as passing cipherOverhead into the CloningScheduler, this really 1 // TODO: Another experiment here is that to maintain a min rtt sample since 1 // TODO: if PMTU changes between the transmission of the original packet and 1 // TODO this is still extra work, as we end up duplicating these 1 // TODO: Make sure the alpn is the same, if not then do a full undo of the 1 // TODO actually drop the 0-rtt keys in addition to dropping packets. 1 // TODO: There is a tradeoff between getting an accurate Cwnd by frequently 1 // TODO: This is silly. We need a better solution. 1 // TODO: Remove UNLIKELY here when DSR is ready for test. 1 // TODO junqiw probing is not supported, so pathValidation==connMigration 1 // TODO: track bytesWritten, when buffer was split it may not be 0 1 // TODO implement the handler 1 // TODO: This too needs to be switchable between regular and inplace builder. 1 // TODO: both kDefaultCubicReductionFactor and kTimeScalingFactor are <1. 1 // TODO: we should experiment with subtract ackdelay from 1 // TODO: check for the stream is in Open or HalfClosedLocal state, the 1 // TODO this is incomplete 1 // TODO: track read bytes to have it available after QUIC stream closure 1 // TODO: Get rid of these two wrapBuffer when Fizz::AEAD has a new interface 1 // TODO when we can rely on C++17, this is a good candidate for try_emplace. 1 // TODO: follow up on getSendTimeout() use, 0 indicates that no timeout is 1 // TODO: If i'm smart enough, maybe we don't have to loop through the acked 1 // TODO: this can happen because we clone RST_STREAM frames. Should we 1 // TODO: chromium has a limit on targetCwnd to be no larger than half of acked 1 // TODO: Sad. I wanted moved all the string into the dynamic but this function 1 // TODO workers_ (vector) is not protected against concurrent modifications 1 # TODO: process the subdirectories of data_dir_name 1 # TODO: Introduce some sort of defaults config that can select by 1 // TODO: setReadCallback to nullptr closes the stream, so the app 1 // TODO This sucks, but manually update the max packet size until we fix 1 // TODO do we need to reset? 2 // TODO Supply v4 delay amount from somewhere when we want to tune this 1 // TODO: allow other connid lengths from the state. 1 // TODO: the error code is CWND_OVERFLOW but this function can totally be 1 // TODO: We can avoid the copy & rebuild of the header by creating an 1 // TODO: track written bytes to have it available after QUIC stream closure 1 // TODO change the error code 1 // TODO: Support empty write loop detection 1 // TODO: We are not going to maintain any QUIC related states. So if the cache 1 // TODO: remove this when we implement EOED for 1 // TODO Save TicketTransportParams here instead of in QuicClientTransport 1 // TODO (amsharma): add a "RetryPacket" QLog event, and log it here. 1 // TODO: handle timeout for assigning stream id 1 // TODO: reduce udpSendPacketLen below base once we can trust 1 // TODO: wrong error code 1 // TODO all the 40s here in the appenders are very likely not the optimal 1 // TODO this is another bandaid. Explicitly set the stateless reset token 1 // TODO: Get rid of appDataReadBuf_ once we do not need EndOfEarlyData 1 // TODO: isn't this a bug? But we don't do drainToTarget today. 1 # TODO: Our caller still won't be able to distinguish between an empty 1 // TODO: I think this may be a bug in the specs. We should use 1 // TODO: 1s may not be the best choice. It can overflow units. 1 // TODO add support for: RETIRE_CONNECTION_ID and NEW_TOKEN frames 1 // TODO Which min RTT should we use? 1 // TODO vchynaro Ensure we ignore smaller subsequent retirePriorTos 1 // TODO: don't carry server connection id over to the new connection. 1 // TODO: ack aggregation expiration controlled by a config flag 1 // TODO Validate active_connection_id_limit 2 // TODO: I think we should add an API that doesn't need a buffer. 1 * TODO: Please make sure QuicConnectionStateBase::D6DState::outstandingProbes 1 // TODO: I don't think i need client address here. 1 // TODO if read buffer is re-used, shouldn't move it here 1 // TODO also update counters 1 // TODO: move to client only conn state. 2 // TODO: t64691045 change the closeImpl API to include both the sanitized and 1 // TODO: InplaceQuicPacketBuilder in the future 1 // TODO: implement undo transport state on retry. 1 // TODO it's not clear that we should be using the smallest and largest 1 // TODO: add path challenge and response 1 // TODO: We can avoid the copy & rebuild of the header by creating an 1 // TODO max ack delay, is this really necessary? 1 * TODO: move to dsr directory. 1 // TODO: current code in detectLossPackets only gives back a loss event when 1 // TODO should this be a small_vector? 1 // TODO: it needs to be able to get the cache data. 1 // TODO: We used to check if there is available bandwidth and rtt samples in 1 // TODO: We should let chain based GSO to use bufAccessor in the future as 1 * TODO: The cloning builder only clones stream data that has not already been 1 # TODO: There may be some way to approximate an availability 1 // TODO: these should probably come in as part of a builder. but I'm not sure 1 // TODO: check version before looking at type 1 // TODO use new conn id, make sure the other endpoint has new conn id 1 // TODO: rate based startup mode 1 // TODO: also consider connection being quiescent 1 // TODO should we throw or return Expected here? 1 // TODO: Do not wait for both IPv4 and IPv6 addresses to return before 1 // TODO: OK, "insert" is a lie. Inside, we copy. But I'd like the BufWriter 1 // TODO should this be initialized once in the constructor and re-used here? 1 // TODO: send extra bandwidth probers when pipe isn't sufficiently full 1 // TODO: send error if we get an ack for a packet we've not sent t18721184 1 * TODO add error handling for this case 1 // TODO: rename "canIgnorePathMTU" to "forciblySetPathMTU" 1 // TODO T32658838 better API to disable early data for current connection 1 // TODO: Support multiple addresses 1 // TODO: should we also add a rttMin to timeElapsed? 1 TODO: I'd like to either extend this or add a variant that 1 // TODO: we need to deal with HRR based rejection as well, however we don't 1 * TODO: We can also send over the encoded QuicInteger of some of these values. 1 // TODO: (yangchi) Figure out how to calculate the 1 // TODO: is there a faster way to do cbrt? We should benchmark a few 1 // TODO junqiw 1 // TODO: client impl 1 // TODO: Also listens to write event from libevent. Only schedule write when 1 // TODO: we can get better receive time accuracy than this, with 1 // TODO: I'm not completely convinced d6d.outstandingProbes has been updated 1 * TODO: in a future version, libccp should pass a pointer to the datapath 1 // TODO See if we should go to slowStart here 1 // TODO update source token, 1 # TODO: Break up complex function 1 // TODO: so our rtt is within 8us (kDelayIncreaseUpperBound) of the 1 // TODO: this will become simpler when we change the underlying data 1 // TODO Checking kMinInitialDestinationConnIdLength isn't necessary 1 // TODO: For Recovery in Startup, Chromium has another config option to set if 1 // TODO vchynaro Implement retire_prior_to logic 1 // TODO: closeNow inside this callback may actually trigger gracefull close 2 # TODO: audit that both source paths have the same inode number 1 // TODO this totally doesn't work, we can't apply socket options before 1 // TODO: It's possible we write out a packet that's larger than the packet 1 // TODO refactor transport settings to avoid having to update params twice. 1 // TODO better way of handling this (tests break without this) 2 // TODO (amsharma): verify the "original_connection_id" parameter 1 // TODO remove this when we make instructions match the request. 1 // TODO: RST here? 1 // TODO: Pacing isn't supported with NewReno 1 // TODO: Currently we will to get some stats first. Then we may filter 1 // TODO accumulate recent source tokens 1 # TODO: In the future it would be nice to support pre-compiling the source 1 // TODO: make this constant time, the token might be secret, but we're 1 // TODO: this approach will make the app unable to setReadCallback to 1 // TODO also remove any stream data from the loss buffer. 1 // TODO: Maybe I should virtualize DSR related APIs and only implement in 1 // TODO: there is a tradeoff between precalculate and cache the result of 1 # TODO: On Windows we require the Python libraries as well. 1 // TODO: this also needs to be 3 numbers now... 1 # TODO: we could just go ahead and build it here, but I 1 // TODO is this needed? 1 # TODO: We aren't extremely strict about error checking for one-value 1 // TODO we simply ignore ECN blocks in ACK-ECN frames for now. 1 // TODO T33014230 subnet matching 1 // TODO: This is temporary. Soon, we will add a transport parameter for knob 1 // TODO replace users with trimStartAtMost 1 // TODO: if the stream has an error and it is also paused we should 1 // TODO implement handler for it 1 // TODO: some of these do not have to be in public API. 1 # TODO: `mkscratch` doesn't currently know how best to place things on 1 // TODO: add path challenge and response 1 // TODO: This list should be trimmed down. 1 * TODO: Current PacketNum is an alias to uint64_t. We should just make 1 // TODO: deal with clear text alert messages. It's possible that a MITM who 1 // TODO: instead of multiplying by 1000 three times, Chromium shifts by 30 1 # system packages are installed. TODO: For users not defined in the 1 // TODO: enable Pacing and BBR together. 1 // TODO: truncate the error code string to be 1MSS only. 1 // TODO: Temporarly let this interface be reusable across different concrete 1 // TODO T33454954 Simplify ticket transport params. see comments in D9324131 1 // TODO: There's some dynamic string construction happening in this (related to 1 // TODO: support key phase one. 1 // TODO: support app retry of zero rtt data. 1 * TODO: onPersistentCongestion entirely depends on how long a loss period is, 1 // TODO: Should we not increase cwnd if inflight is less than half of cwnd? 1 // TODO: change this back to generating random packet type after we rollout 1 # TODO: generate a main executable that will invoke Python3 1 // TODO: This is caller responsibility for now so the BufWriter conform with 1 // TODO: If we want to be able to write FIN out of order for DSR-ed streams, 1 # TODO: Ideally, this function would inspect the current cgroup for any 1 // TODO: It's worth experimenting to use the larger one between cwndBytes_ and 1 // TODO: Why don't I just limit the batch size to reqGroup.size()? What can go 1 // TODO plumb version 1 // TODO: experiment with exit slow start on loss 1