Summary: 279 instances, 253 unique Text Count // TODO Find a way to not have this Presto-specific logic in here. 1 // TODO 3: Add ascii propagation optimization 1 // TODO (cao) - SelectedTypeBuilder is uncessary to exist, can be killed 1 // TODO: add support for general regex pattern using R2 1 // FIXME: Unless query optimizer took care of this already, othersie this 1 // TODO: if these allocations show up on a profile, add a 'canGet' 1 // TODO: Missing implementation; 1 // TODO: Work with DuckDB to directly support a InputStream API. 1 /// FIXME: the below optimization is only correct if child expr has no side 1 // TODO: why is data type instead of requested type passed in? 1 // TODO: write now we are sharing everything, this not ideal. We should do 1 * TODO (cao) - eventually these two mappings can be replaced by expression 1 // TODO: Investigate if std::sysem_error would be a better choice here 1 // TODO Re-use output_ columns when possible. 1 // TODO: Extend the interface to parity with folly::StringPiece as needed. 1 /// TODO: This might need to be improved in case func return ref types. 1 /// TODO: Update this to reflected latest changes in D26383419 1 // TODO: specialize for default nulls 1 // TODO (cao) - should we have project order on node level 1 * TODO (cao) Ideally this should merge with TypeWithId, but due to 1 // TODO: compare is not defined for view types yet 1 // TODO: Row type serializer is not tested 1 // TODO: move to factory pattern with type trait. 1 // TODO (bharathb) : We notify everyone irrespective of whether their 1 // TODO T70734527 dealing with zero length vector 3 // TODO Add support for accuracy parameter 1 // TODO Delay this call until all input data has been processed. 1 // TODO Optimize to avoid copy 2 /// TODO Check if this filter is needed. This should not be passed down. 2 // TODO 1: Investigate copying 1 // TODO: This is temporary until the new map writer interface is completed. 1 // TODO: Support for Struct is not fully added. 1 // TODO when read only vector does not have nulls we dont need to allocate 2 // FIXME: generated code should avoid calling on this on the writer and 1 // TODO: Consider putting these in base class also. 1 // TODO we can allocate on the pool 1 // Note: TODO investigate, re-run and optimize when input is not null. 1 // TODO: Wire up serde properties to writer configs. 1 // TODO: as we implement memory tracking, this should be per 1 // TODO: We should exclude here direct access columns. 1 // TODO Replace with struct_pack 1 // TODO: relax this constraint to allow more pointer type 1 // TODO: support null on failure 1 : preload_(true), // TODO: is preload required ? 1 // TODO: This basically here to track the benefit of constructing constant 1 // TODO: this assume that nodePtr is never null, we need to add a constraints 3 // TODO: perhaps the root pool should be a specialized pool that 1 // TODO: does FILE really not use any more memory? From the stdio.h 1 // TODO: reuse strings once support landed. 1 // TODO Fix the signatures to match Presto. 1 // TODO: Only direct reference is considered here. 1 // TODO: probably can introduce a macro here. 1 // TODO: T45220726 Reduce memory usage in this method by 2 // TODO: the only way useDictionaryEncoding_ right now is 2 // TODO: implement short name time zone, need a map from full name to 1 // TODO: remove once writer code is consolidated 1 /// TODO: use a range_view instead of a containers as arg 1 // TODO: enable generating strings that represent numbers 1 // TODO: Define batch size as bytes based on RowContainer row sizes. 1 // TODO make the following metadata const, e.g. call computeMetadata in the 1 # TODO: There may be some way to approximate an availability 1 // TODO Add support for "week". 1 // TODO: Implement 1 // TODO: Missing tests 1 // TODO: remember to add in the size of the hash map and its contents 1 // TODO: expose config for initial guess? 1 // TODO: might be able to move implementation to abstract class 1 // TODO: The propagation is a safe approximation here, it might be better 1 // TODO Fix signature to match Presto. 1 // @TODO Add support for needed complex types in T74045702 1 // TODO: If we are writing shared dictionaries, the shared dictionary data 1 // TODO Once C++20 supported we may want to replace this with 1 // TODO: consider using folly/ScopeGuard here. 1 // TODO Reuse memory 2 // TODO (T61713241): Remove this later. 1 // TODO: implement proper stats 1 TODO: I'd like to either extend this or add a variant that 1 // TODO: Get the input type and support different types here. 1 // TODO Move is available only for flat vectors. Check if tempResult is 1 // TODO: Only and relation is supported here. 1 /// TODO: Missing implementation 1 // TODO: avoid this copy when oldBuffer and newBuffer are sequential in 1 // TODO: should allow expressions 1 // TODO: analyze other options for enabling inplace i.e.: 1 // TODO: velox implementation is in cpp 1 # TODO: Break up complex function 1 * TODO: Implement a lazy version 1 // TODO: T46365785 It would be nice if the suppression 1 // TODO: refactor to merge the decoding of a vector of fixed length, 1 // TODO: We probably need here to have a better ordering of the columns 1 // TODO: Investigate why std::shared_ptr here is seen as incomplete type 1 // TODO: unroll to improve performance 1 // TODO : Find out what to do with these types 1 // TODO: wonder if this should be final dictionary size instead. In that 1 // TODO: Currently Filter is skipped because Filter is Pushdowned to 1 // TODO Remove this check when Presto is fixed to not specify a filter 1 // TODO Figure out how to re-use 'result' safely. 1 # TODO: On Windows we require the Python libraries as well. 1 // TODO: Rename this to something more descriptive 1 // TODO: velox throws here for non fixed width types. 1 # TODO: We aren't extremely strict about error checking for one-value 1 // TODO: implement timezone offset id formatting, need a map from full 1 // TODO: double check if we need to check on eagerness here. 1 // Aggregates in payload. TODO: Separate out aggregate metadata 1 // TODO: T45260340 Unfortunately standard usage of the index 2 // TODO: allocate from a memory pool 1 // TODO: Deprecate in favor of folly::symbolizer. 1 // TODO Implement 3 // TODO: We can fuzz nulls here as well. 1 /// TODO: It's important that this function and helper be inline 1 // TODO: maybe do something smarter than just matching any shared_ptr, e.g. we 1 // TODO: lineNumbers has been disabled since 2009. 1 return StringView("TODO: Implement"); 1 // TODO: override getCurrentBytes() to be lock-free for leaf level pools. 1 // TODO Figure out how to allow memory reuse for a newly loaded vector. 1 // TODO: hopefully not required in the future, but need to solve the problem 2 // TODO Optimization: check and remove string buffers not referenced by 1 // TODO: Potentially re-use the string vector, not just the buffer. 1 // TODO (bharathb) : Either disallow or flatten config stacks here. 1 # system packages are installed. TODO: For users not defined in the 1 // TODO: passing factory method into the dict encoder also works 2 // TODO: remove once old writers deprecated. 1 // TODO Reuse 1 // TODO: avoid copying constant string by allocating them on Velox buffer 1 // TODO Finish the pipeline early and avoid unnecessary computing. 1 # TODO: generate a main executable that will invoke Python3 1 // TODO: These checks are costing ~13% performance penalty, it would be nice 1 /// // TODO: ComplexVector.h should contain asserts for these assumptions 1 // TODO (bharathb) : replace dynamic_pointer_cast with 1 // TODO: read footer from spectrum 1 // TODO: Only double is considered here. 1 // TODO Add support for strings. 1 // TODO: move readers to different directory 1 // TODO Add connector details. 1 // TODO investigate why we are slower. @ 75% 1 // TODO: We should bias towards edge cases (min, max, Nan, etc). 1 // TODO Finish early if ran out of data on either side of the join. 1 // TODO: configure this accurately if it actually has impact. 1 // TODO Reuse memory 2 // TODO Allow DataSource to indicate that it is blocked (say waiting for IO) 1 // TODO we should do better for such deep expression 1 // TODO: investigate why vectorFunc is much faster than compiled 1 // TODO: writeVuLong should ideally be using uint64_t as input. 1 // TODO 2: Investigate using a global bump allocator instead of std::string 1 // TODO: Load only for active rows, except if right/full outer join. 1 BufferPtr(nullptr), // TODO nulls 2 // TODO: partially specialize for integers only. 1 // TODO: we want to register UDFs via config files rather than in code 1 // TODO: Re-work the logic of deciding when to load which field. 1 // TODO: Add different types' support here. 1 // TODO: Once C++20 supported we may want to replace this with 1 /// TODO extract this onto a separate process 1 # TODO: process the subdirectories of data_dir_name 1 // to rows. TODO: Consider isFinal as template parameter. 1 // TODO: Investigate if std::system_error might 1 # TODO: Introduce some sort of defaults config that can select by 1 // TODO Generalize to specify TableHandle/Layout and ColumnHandles. 1 // TODO: Move this into a file 1 * Constraints (TODO : define formaly those constraints in term of c++ concepts) 1 // TODO In Presto, intermediate results are represented as a struct with 1 * TODO: Make sure that this class respects the range concept 1 # TODO: Our caller still won't be able to distinguish between an empty 1 /// TODO: Why is this in an anon namespace 1 // TODO: nodes, cpu threads/%, memory, iops, etc. 1 // TODO separate defintions of composite types from declarations. 1 /// TODO: create a generic base visitor class for PlanNode 1 // TODO: deprecate this once all proxies introduced. 1 // TODO Decode keys first, then decode the rest only for passing positions 1 // TODO: consider returning bool instead. 1 // TODO: what does this try to capture? 1 // TODO: If we get this to be recursive somehow, we can save on cast function 1 // TODO: let's templatise the invoke function; 1 // TODO when read only vector does not have nulls we dont need to 1 // TODO: This is temporary until the new map writer interface is completed. 1 /// TODO: We should really be story full library information here instead 1 * TODO: Introduce more refined of the tree concept : mutable tree 1 // TODO: support fields other than top level ones 1 /// TODO 1: add reference to the working directory, and the search path. 1 // TODO: Casting fails here because str1 is not a valid double string. 1 // and is used also if only one Expr is to be evaluated. TODO: Rename to 1 // TODO: It would be nice if the suppression could be pushed down to 1 // TODO: make a config 1 // TODO Figure out how to perform a zero-copy conversion. 1 // TODO: Arguably all of this could be done with just Types. 1 // TODO: might be able to collapse this with templated class 1 // TODO: `resize` is probably a better name for this method 1 /// TODO: Track files and cleanup after process closes 1 // TODO: Normally, we would want to handle this in the on_error callback. 1 // unique_ptr. TODO: Make all streams owned via shared_ptr. 1 // TODO: change this to be controlled in a header i.e ret CodegenType