Summary: 82 instances, 75 unique Text Count # TODO consider refactor to handle overlap with match 1 # TODO t.Generic[TFetchDelta, TFetchedSignalData, TCollabConfig] 1 # TODO this test for "already exists" should be moved to a common place 1 TODO: At this point, is dumb. Does not actually batch the requests, instead 1 # TODO find way to reuse similar code in raw_text.py without sacrificing performance. 1 # TODO add method for when matches are added to a sqs 1 # TODO research max # sqs records / lambda_handler invocation 3 # TODO Something better than 'hit limit=skip' 1 # TODO - Figure out how to properly capture hash vs search 1 # TODO Remove same methods in python-threatexchange api.py 1 raise NotImplementedError("TODO not yet implemented") 1 # TODO - defend against missing extensions imports 1 settings._state.delete_collab(collab) # TODO clean private member access 1 {/* TODO: Undecided nomenclature */} 1 # TODO t.Generic[TFetchDeltaBase, TFetchedSignalDataBase, FetchCheckpointBase] 1 # TODO force this as a required library? 1 "# TODO: also filter for attack_type == PHISHING, when Pytx supports it\n", 1 # TODO - we should probably sanity check here to make sure all the fields 1 # TODO name confusing. Should probably be SignalID... 1 # TODO #751 Until we resolve type agnostic storage of signal data, 1 # TODO - consider storing by tuple instead of defending against accidental 1 TODO: Make this into batch calls to dynamodb so it is performant. Right 1 TODO: Something like an override flag should be added to the submit API 1 # TODO: Currently writing back INGESTED fails becuase of API limits. Need to 1 TODO: Consider moving to its own helper class. 1 "# TODO Add this translation to Pytx\n", 1 # TODO: Once ThreatExchange data flows into Banks, we can Use BankMember 1 # TODO - this is supported by the API 3 # TODO These should maybe have a strong connection to the objects instead of class constants 1 // TODO: pull out body to method here and re-use for getIncremental 1 # TODO: Combine 2 update functions into single function 1 # TODO this method is expensive some cache or memoization method might be a good idea. 1 # TODO - merge SimpleDescriptorRollup here 1 # TODO - Support things other than just one item per line 1 # TODO actually implement fancy threading logic 1 # TODO: ActionEvaluation does not yet leave a trail. Either record 1 // Ensure placeholders don't get displayed. TODO: Move this to the API. 1 # TODO: make this computed from var.fetch_frequency. 1 TODO: Move this out of matchers. 1 TODO: assumption that a signal value can only be string is inaccurate. Even 1 TODO Research caching rules for a short bit of time (1 min? 5 min?) use @lru_cache to implement 1 TODO: Additionally, if writebacks are enabled for this privacy group write back 1 " #td.ATTACK_TYPE: a.MALWARE, # TODO uncomment when PR #120 gets added to Pytx in pip\n", 1 # TODO - do something smarter than this - static 1 TODO: This currently implies that you are going to load the entire dataset 1 # This may need to be updated (TODO make more configurable) 2 # TODO - probably move add() methods to a mixin instead 1 TODO implement 1 # TODO - this doesn't handle bytes queries / BytesHashers 1 # FIXME: Presently, hash API can only support one hash per content_id 1 TODO: Slim down to only what we need 1 TODO refactor #2 to its own lambda that handles more general sqs events 1 opinion?: string; // TODO enum 1 // TODO: create-time/update-time filters go here ... 1 ) # TODO - does this throw all the right exceptions? 1 # TODO Currently default to True for testing purpose, 1 # TODO - Consider stripping out collab labels 1 // TODO extra additional fields spec should be established in documentation 1 # TODO catch errors here 1 # TODO - correctly check types 1 // TODO: Use a better in-house error message. Perhaps not blur it? 1 TODO: Just refactor this file to separate the lambda and functional 2 # TODO elevate this to some central place when working on Issue 599 1 * TODO: typescript supports enums. However, all files that use enums from here 1 # TODO: Are there known values for these keys? 1 # TODO: This would do good with caching. 1 self.added_on = added_on # TODO - convert to int? 1 pendingOpinionChange?: string; // TODO enum 1 {/* TODO these Dropdown.Item's logic is likely possible to generalize into a signal component */} 1 signal_type: string; // TODO: Convert to enum. 1 signal_type: signal.signal_type, // TODO: Convert to enum. 1 # TODO: Support pagination after implementing in UI. 1 # TODO: Find where these are sourced from. 2 ).get_persistent_config() # TODO fix the circular dependency 1 # TODO -This is supported by the API 1