bistro/cron/StandardCrontabItem.cpp (6 lines): - line 29: // TODO: Make the error messages more helpful by identifying the failing - line 202: // TODO: It might be cool to add 32 with an "end_of_month" string - line 442: // TODO: An optimization that I'm too lazy to test now would be: - line 574: // TODO: Morally, it's more correct to make this adjustment in the - line 621: // TODO: With some additional selectors, it would be possible to make a - line 637: // TODO: an optimization I'm too lazy to implement for the "early" & bistro/nodes/AddTimeFetcher.h (5 lines): - line 137: * TODO: Refresh timezone data periodically, since TZ rules can change. The - line 139: * tzset() -- TODO: confirm that this tracks system timezone rule updates: - line 142: * TODO: Add support for specifying a Boost "posix_time_zone" string as part - line 150: * TODO: (overengineering) Build stateful Cron (see the Cron README). Also - line 247: // TODO: this code could be more performant if node fetchers were stateful. web_ui/src/applications/bistro/fetchers/BistroDataFetcher.php (3 lines): - line 44: // For duplicate shard detection. TODO: rename to loadLevelToNodes - line 86: // TODO: We should ask Bistro for the total # of jobs as part of the - line 96: // TODO: A more salient optimization for the paged case is just to do web_ui/src/applications/bistro/fetchers/BistroBaseMonitor2Fetcher.php (3 lines): - line 50: // TODO: backoff interval? cutoff_time? resources! config? filters? - line 130: // TODO: Delete once all Bistro deployments have running_tasks, - line 139: // TODO: Delete once all Bistro deployments have running_tasks bistro/cmake/targets_to_cmake_lists.py (3 lines): - line 109: pass # TODO: actually build the benchmark - line 140: pass # Thrift is currently built by run-cmake.sh. TODO: Improve? - line 211: # run-cmake.sh has its own hacky way of building Thrift. TODO: Fix. build/fbcode_builder/CMake/FBPythonBinary.cmake (3 lines): - line 50: # TODO: On Windows we require the Python libraries as well. - line 187: # TODO: generate a main executable that will invoke Python3 - line 420: # TODO: In the future it would be nice to support pre-compiling the source web_ui/src/applications/bistro/model/BistroInstanceHealthChecker.php (3 lines): - line 50: // TODO: Move duplicate-node checking in here? - line 124: // TODO: Maybe emptying all state here would improve performance. Or - line 247: // TODO: As soon as possible, check all level counts -- right now the bistro/server/HTTPMonitor.cpp (2 lines): - line 122: // TODO: deprecate this in favor of running_tasks - line 312: * Response doesn't include workers at this point (TODO t7757044). bistro/statuses/TaskStatusSnapshot.h (2 lines): - line 37: * TODO: It's dubious that getPtr() simply returns nullptr for out-of-range - line 137: // TODO: For most uses of RunningTasks, e.g. HTTPMonitor, updateForConfig, build/fbcode_builder/getdeps.py (2 lines): - line 834: # TODO: we could just go ahead and build it here, but I - line 904: # TODO: Break up complex function build/fbcode_builder/getdeps/platform.py (2 lines): - line 56: # TODO: Ideally, this function would inspect the current cgroup for any - line 88: # TODO: There may be some way to approximate an availability build/fbcode_builder/CMake/FBCMakeParseArgs.cmake (2 lines): - line 49: # TODO: We aren't extremely strict about error checking for one-value - line 125: # TODO: Our caller still won't be able to distinguish between an empty bistro/utils/LogLines.h (1 line): - line 15: // TODO: Get rid of this in favor of the Thrift struct as soon as we figure bistro/statuses/TaskStatus.h (1 line): - line 356: // TODO: Since different fields are used for different statuses, a union build/fbcode_builder/getdeps/buildopts.py (1 line): - line 521: # TODO: `mkscratch` doesn't currently know how best to place things on web_ui/rsrc/js/application/bistro/render-node-group-details.js (1 line): - line 8: // TODO: I don't know jack about JS or Phabricator Javelin usage, but bistro/utils/TemporaryFile.h (1 line): - line 15: // TODO: Maybe rename this TaskStatusFile, because this is not currently a bistro/statuses/SQLiteTaskStore.cpp (1 line): - line 56: // TODO: Use "IN" query with up to 999 job IDs (SQLite limitation) bistro/cmake/setup.cmake (1 line): - line 105: # TODO: Some of the above dependencies, like SQLite and libthrift, are only web_ui/src/applications/bistro/prefs/BistroJobListPrefs.php (1 line): - line 146: // TODO: Make paging work better. build/fbcode_builder/docker_builder.py (1 line): - line 37: # system packages are installed. TODO: For users not defined in the bistro/statuses/TaskStatusSnapshot.cpp (1 line): - line 89: // from the TaskStore. TODO: Overall plan for handling TaskStore failures. bistro/statuses/TaskStatuses.cpp (1 line): - line 88: // TODO: Add exponential backoff retry? Crashing doesn't actually bistro/worker/BistroWorkerHandler.cpp (1 line): - line 250: // TODO: An alternative is for every heartbeat to generate a fresh bistro/config/JobFilters.cpp (1 line): - line 127: // TODO: T26311162 fix float-cast-overflow undefined behavior bistro/runners/RemoteWorkerRunner.h (1 line): - line 109: // TODO: Make this private once we don't have an FB-specific class web_ui/src/applications/bistro/request_utils.php (1 line): - line 32: // TODO: Delete once all Bistro deployments have running_tasks build/fbcode_builder/getdeps/dyndeps.py (1 line): - line 117: # TODO: audit that both source paths have the same inode number web_ui/src/applications/bistro/view/monitor2_job/BistroMonitor2JobLevel.php (1 line): - line 70: // TODO: Bistro should return sorted levels, but this heuristic is okay. bistro/config/Job.h (1 line): - line 42: // TODO: Figure out why 'noexcept' does not compile here web_ui/src/applications/bistro/view/components/StackedBarChart.php (1 line): - line 88: // TODO: faster algorithm build/fbcode_builder/getdeps/builder.py (1 line): - line 122: # TODO: Introduce some sort of defaults config that can select by web_ui/src/applications/bistro/BistroLoadableByName.php (1 line): - line 44: $name_to_class = self::getNameToClass($base_class); // TODO: memoize build/fbcode_builder/getdeps/copytree.py (1 line): - line 75: TODO: I'd like to either extend this or add a variant that web_ui/src/applications/bistro/controllers/BistroCommonQueryController.php (1 line): - line 41: // TODO: Surface the overrides in the form (e.g. next to the defaults). bistro/worker/main.cpp (1 line): - line 21: // TODO: It would be useful to periodically re-read this host:port from a bistro/worker/BistroWorkerHandler.h (1 line): - line 137: // TODO: Replace this with a common Thrift struct throughout Bistro & web_ui/src/applications/bistro/multicurl/controllers/BistroBaseMultiCurlController.php (1 line): - line 22: * TODO: It would be ideal to return a 400 on fatals, so that the attacker build/fbcode_builder/getdeps/py_wheel_builder.py (1 line): - line 158: # TODO: process the subdirectories of data_dir_name web_ui/src/applications/bistro/view/monitor2_job/BistroMonitor2JobErrors.php (1 line): - line 7: // TODO: Try ConsensusFinder-style rendering here?