thrift/lib/cpp2/transport/rocket/framing/Parser.h (8 lines): - line 77: // TODO: This should be removed once the new buffer logic controlled by - line 81: // TODO: This should be removed once the new buffer logic controlled by - line 85: // TODO: This should be removed once the new buffer logic controlled by - line 93: // TODO: This should be removed once the new buffer logic controlled by - line 120: // TODO: remove once hybrid logic is stable - line 125: // TODO: remove once hybrid logic is stable - line 139: // TODO: This should be removed once the new buffer logic controlled by - line 146: // TODO: readBuffer_, lastResizeTime_, resizeBufferTimeout_ and thrift/compiler/generate/t_cocoa_generator.cc (6 lines): - line 1458: // TODO:: can item be a list / std::map / set, in which case need to do - line 1477: // TODO:: can item be a list / std::map / set, in which case need to do - line 1906: // FIXME - could optimize here to reduce creation of temporary objects. - line 2285: // FIXME - the code above does not verify that the element types of - line 2325: // FIXME - optimize here to avoid autorelease pool? - line 2954: // FIXME The generated code does not match with initWithXXX thrift/lib/cpp/async/TStreamAsyncChannel-inl.h (4 lines): - line 172: // TODO: it would be better to perform this bind once, rather than - line 345: // TODO: It would be nice not to have to always log an error message here; - line 391: // TODO: This matches the old TAsyncChannel behavior, but it seems like - line 472: // TODO: It would be nicer to have a mechanism to indicate to the caller thrift/lib/go/thrift/header.go (4 lines): - line 535: // FIXME: We should only write supported xforms - line 641: // TODO: Changes with bigframes - line 650: // FIXME: support bigframes - line 687: // FIXME: Bad assumption (no err check), but we should be writing to an in-memory buffer here thrift/lib/cpp2/async/AsyncProcessorHelper.cpp (3 lines): - line 61: // TODO: T112295873 - line 68: // TODO: T112295873 - line 80: // TODO: T113039894 thrift/compiler/ast/t_type.h (3 lines): - line 138: // TODO: add description - line 140: // TODO: add description - line 146: // TODO: Rename function. build/fbcode_builder/CMake/FBPythonBinary.cmake (3 lines): - line 50: # TODO: On Windows we require the Python libraries as well. - line 187: # TODO: generate a main executable that will invoke Python3 - line 420: # TODO: In the future it would be nice to support pre-compiling the source thrift/lib/cpp2/transport/rocket/framing/Parser-inl.h (3 lines): - line 491: // TODO: This should be removed once the new buffer logic controlled by - line 543: // TODO: This should be removed once the new buffer logic controlled by - line 564: // TODO: This should be removed once the new buffer logic controlled by thrift/perf/cpp2/util/Runner.h (2 lines): - line 51: // TODO: Implement sync calls. - line 82: // TODO: Properly handle errors and exceptions thrift/lib/cpp2/transport/core/ThriftRequest.cpp (2 lines): - line 184: // TODO: refactor to move response compression to CPU thread. - line 215: // TODO: refactor to move response compression to CPU thread. thrift/lib/cpp2/async/AsyncProcessor.h (2 lines): - line 464: // TODO: T108089128 We should change this to return a ResponseChannelRequest - line 992: // TODO: replace with getRequestExecutionScope. thrift/lib/py3lite/sink.pyx (2 lines): - line 25: # TODO: (pyamane) This is here just to validate the types are correct for now - line 37: # TODO: (pyamane) This is here just to validate the types are correct for now thrift/compiler/lib/cpp2/util.cc (2 lines): - line 51: // TODO: check @cpp.Adapter - line 129: // TODO: Consider why typedef is not resolved in this method thrift/compiler/generate/t_go_generator.cc (2 lines): - line 789: // TODO: Do better error checking here. - line 2711: // TODO should handle extends? thrift/lib/cpp2/transport/http2/common/SingleRpcChannel.cpp (2 lines): - line 236: // TODO: We could also try to understand the kind of error be looking - line 349: // TODO: contents_ should never be empty. For some reason, once the number thrift/lib/cpp2/frozen/Frozen.h (2 lines): - line 267: // TODO: declare bits as int16_t instead of casting it - line 403: // TODO: declare offset as int16_t instead of using folly::to_narrow thrift/lib/cpp2/transport/http2/client/H2ClientConnection.cpp (2 lines): - line 77: // TODO: Improve the way max outging streams is set - line 194: // TODO: need to change timeout in httpSession_. This functionality build/fbcode_builder/getdeps/platform.py (2 lines): - line 56: # TODO: Ideally, this function would inspect the current cgroup for any - line 88: # TODO: There may be some way to approximate an availability build/fbcode_builder/CMake/FBCMakeParseArgs.cmake (2 lines): - line 49: # TODO: We aren't extremely strict about error checking for one-value - line 125: # TODO: Our caller still won't be able to distinguish between an empty thrift/lib/cpp2/transport/http2/common/HTTP2RoutingHandler.cpp (2 lines): - line 143: // TODO: this is not valid HTTP/2, accepting a connection like this - line 197: // TODO: Improve the way max incoming streams is set thrift/lib/cpp2/transport/core/testutil/TransportCompatibilityTest.cpp (2 lines): - line 937: // TODO: Even though we observe that the timeout functionality works fine for - line 945: // TODO: fixme T22871783: Oneway tasks don't get cancelled thrift/perf/cpp/ClientLoadConfig.cpp (2 lines): - line 172: // TODO: verify that at least one weight is non-zero - line 173: // TODO: it would be nice to be able to load from a config file thrift/lib/cpp2/transport/core/testutil/FakeServerObserver.h (2 lines): - line 78: // TODO: T24439845 - Implement Failure Injection - line 85: // TODO: T24439936 - Implement LOADSHEDDING thrift/compiler/generate/t_json_generator.cc (2 lines): - line 340: * TODO - support serialization of complex keys... - line 532: // TODO (partisan): Find a good way to expose enumerator annotations. thrift/lib/cpp2/protocol/nimble/BufferingNimbleEncoder.h (2 lines): - line 45: // TODO: We will eventually want a way to "reserve" chunks in the output - line 57: // TODO: We currently just "pad-out" with zeros to make the result a full thrift/lib/javadeprecated/src/main/java/com/facebook/thrift/TMultiplexedProcessor.java (2 lines): - line 104: // TODO Apache Guys - Can the server ever get an EXCEPTION or REPLY? - line 105: // TODO Should we check for this here? thrift/conformance/cpp2/internal/Object.h (2 lines): - line 230: // TODO: set in stringValue if UTF8 - line 317: // TODO: handle jsonprotocol thrift/lib/thrift/RpcMetadata.thrift (2 lines): - line 138: // TODO: this should be extended to support unset protocol field (e.g. unset - line 144: // TODO: this should be extended to support unset kind field (e.g. RPC kind build/fbcode_builder/getdeps.py (2 lines): - line 834: # TODO: we could just go ahead and build it here, but I - line 904: # TODO: Break up complex function thrift/lib/java/runtime/src/main/java/com/facebook/thrift/util/RpcClientUtils.java (1 line): - line 324: // TODO: (vishwagayasen) Revert this to directly using ex when RSocket is released thrift/lib/cpp2/reflection/internal/reflection-inl-pre.h (1 line): - line 91: // FIXME: There is a bug that is_set(...) always return `true` for cpp.ref field thrift/compiler/generate/templates/java2/Union.mustache (1 line): - line 59: TODO: remove unionFieldTypeUnique related check and use builder pattern thrift/lib/cpp2/async/HTTPClientChannel.h (1 line): - line 218: // TODO (geniusye) destroy the channel here thrift/lib/cpp2/protocol/nimble/EncodeNimbleBlock.h (1 line): - line 184: // TODO: this leads to longer dependency chains. We should probably be thrift/lib/java/runtime/src/main/java/com/facebook/thrift/client/RpcClient.java (1 line): - line 46: // TODO: since D29640861, the corresponding RpcKind is Sink thrift/lib/cpp2/protocol/NimbleProtocol.h (1 line): - line 367: // TODO: implement canReadNElements for NimbleProtocol thrift/lib/cpp2/security/FizzPeeker.h (1 line): - line 31: * TODO: This can be generalized into wangle. thrift/compiler/generate/t_js_generator.cc (1 line): - line 281: // TODO should the namespace just be in the directory structure for node? thrift/lib/cpp2/server/ThriftServer.cpp (1 line): - line 672: // TODO: T111371879 [thrift][resourcepools] Figure out priorities for default thrift/lib/cpp2/server/ParallelConcurrencyController.cpp (1 line): - line 125: /*FIXME:roddym tile*/); thrift/lib/py3lite/util.h (1 line): - line 81: or consider passing the Thrift compiler the mstch_py3lite:no_sink (TODO: (pyamane) implement this) \ thrift/lib/cpp2/transport/http2/client/ThriftTransactionHandler.h (1 line): - line 62: // TODO (geniusye) destroy the channel here thrift/compiler/parse/parsing_driver.h (1 line): - line 68: // TODO (partisan): Rename to t_stmt_attrs. thrift/compiler/generate/t_py_generator.cc (1 line): - line 759: // TODO: Do better error checking here. thrift/compiler/gen/cpp/reference_type.cc (1 line): - line 93: // TODO: Consider having default reference type thrift/lib/cpp2/op/Patch.h (1 line): - line 89: // TODO (afuller): Add more binary patch operations. thrift/lib/go/thrift/serial_channel.go (1 line): - line 61: // TODO: Implement per-call cancellation for a SerialChannel thrift/lib/cpp2/transport/rocket/server/ThriftRocketServerHandler.cpp (1 line): - line 114: // TODO: determine isClientSamplingEnabled by "client_logging_enabled" header thrift/lib/cpp2/protocol/detail/protocol_methods.h (1 line): - line 106: // TODO: Remove once libstdc++ < 7 is not supported any longer. thrift/compiler/sema/standard_validator.cc (1 line): - line 398: // TODO: use string_view as map key thrift/lib/cpp2/reflection/populator.h (1 line): - line 256: // TODO: fair amount of shared code bewteen this and specialization for thrift/lib/javadeprecated/src/main/java/com/facebook/thrift/transport/TNonblockingServerSocket.java (1 line): - line 123: // TODO: decide what to do with this. thrift/compiler/generate/templates/python/metadata/thrift_type.mustache (1 line): - line 21: }}{{#type:typedef?}}_fbthrift_metadata.ThriftType(t_typedef={{! TODO this branch never gets hit thrift/lib/cpp/transport/THttpClient.cpp (1 line): - line 103: // TODO: we should probably check that the version is 1.0 or 1.1 thrift/compiler/parse/parsing_driver.cc (1 line): - line 210: // TODO: This doesn't really need to be a member function. Move it somewhere thrift/compiler/lib/py3/util.h (1 line): - line 44: // TODO: get rid of this list and force users to rename explicitly thrift/lib/rust/src/framing.rs (1 line): - line 39: /// FIXME: need &self? thrift/lib/py/util/Decorators.py (1 line): - line 270: TODO haijunz: handler_ctx is not supported in FutureProcessor's handler thrift/lib/py/server/TCppServer.py (1 line): - line 87: # TODO mhorowitz: add read headers here, so they can be added to thrift/lib/cpp/concurrency/ThreadManager.cpp (1 line): - line 1018: // TODO: enforce this. thrift/lib/cpp2/GeneratedCodeHelper.h (1 line): - line 495: // TODO: re-enable checksumming after we properly adjust checksum on the thrift/lib/cpp2/transport/core/ThriftRequest.h (1 line): - line 59: * TODO: RSocket currently has a dependency to this class. We may want thrift/compiler/ast/t_program.h (1 line): - line 143: * @param name_space - //TODO add definition of name_space thrift/lib/cpp2/transport/http2/common/H2Channel.cpp (1 line): - line 90: // TODO: urlDecode with StringPiece? thrift/lib/cpp/transport/THeader.cpp (1 line): - line 971: // TODO: IOBufize httpTransport. thrift/lib/cpp2/async/Cpp2Channel.cpp (1 line): - line 53: // TODO getHandler() with no index should return first valid handler? build/fbcode_builder/getdeps/buildopts.py (1 line): - line 521: # TODO: `mkscratch` doesn't currently know how best to place things on thrift/lib/py/transport/TSocket.py (1 line): - line 56: # TODO should we set any other masks? build/fbcode_builder/docker_builder.py (1 line): - line 37: # system packages are installed. TODO: For users not defined in the thrift/lib/java/runtime/src/main/java/com/facebook/thrift/server/RpcServerHandler.java (1 line): - line 40: // TODO: since D29640861, the corresponding RpcKind is Sink thrift/lib/cpp2/FieldRef.h (1 line): - line 197: // TODO: Remove special attribute for MOBILE thrift/perf/cpp/AsyncLoadHandler2.cpp (1 line): - line 130: // FIXME: it isn't possible to implement this behavior with the async code thrift/compiler/generate/templates/rust/lib/server.mustache (1 line): - line 225: buffer: ::std::marker::PhantomData, // FIXME P::into_buffer(p).reset(), thrift/lib/py/Thrift.py (1 line): - line 82: # TODO: implement asyncComplete for Twisted thrift/lib/py/client/sync_client.pyx (1 line): - line 89: # TODO: return correct exception type thrift/lib/cpp/util/THttpParser.cpp (1 line): - line 346: // TODO: we should probably check that the version is 1.0 or 1.1 thrift/compiler/generate/templates/java/Union.mustache (1 line): - line 59: TODO: remove unionFieldTypeUnique related check and use builder pattern build/fbcode_builder/getdeps/dyndeps.py (1 line): - line 117: # TODO: audit that both source paths have the same inode number thrift/conformance/cpp2/ObjectTest.cpp (1 line): - line 399: // FIXME: skip validation for structs with empty list, set, map. thrift/perf/cpp2/util/QPSStats.h (1 line): - line 42: // TODO: Each thread in the Runner creates an instance of an Operation. thrift/lib/rust/src/simplejson_protocol.rs (1 line): - line 142: // TODO what to do here thrift/lib/cpp/protocol/TProtocol.h (1 line): - line 493: // TODO: remove these two calls, they are for backwards thrift/lib/cpp2/async/HeaderClientChannel.cpp (1 line): - line 391: // TODO: On some errors, some servers will return 0 for seqid. thrift/lib/py3lite/server/server.h (1 line): - line 293: // TODO: (ffrancet) error kind overrides currently usupported, thrift/lib/cpp2/server/AdaptiveConcurrency.cpp (1 line): - line 164: // TODO: follow up on this range and see if it can be tuned further (or make thrift/lib/py3lite/types.pyx (1 line): - line 539: # TODO in python 3.10 update this to use name and obj fields thrift/lib/cpp2/transport/core/EnvelopeUtil.h (1 line): - line 84: // TODO: Add Frozen2 case. thrift/compiler/generate/templates/py3/types.pyx.mustache (1 line): - line 320: {{! TODO: python 3.10 adds some more fields to AttributeError, those should be added here at some point }} thrift/lib/cpp/RelativePtr.h (1 line): - line 28: // TODO: expose 'OffsetType' as a type parameter in freeze() thrift/lib/go/thrift/header_protocol.go (1 line): - line 109: // TODO: This is a bug. if we are speaking header protocol, we should be using thrift/lib/rust/src/dep_tests/cargo_thrift/thrift_build.rs (1 line): - line 31: // TODO: replace canonicalize() with std::path::absolute() when thrift/compiler/generate/templates/cpp2/module_visit_union.h.mustache (1 line): - line 41: <%! TODO: use field ref API once it supports cpp.ref %> thrift/compiler/generate/t_mstch_cpp2_generator.cc (1 line): - line 1586: // TODO: extra copy thrift/compiler/generate/templates/python/lite_metadata.py.mustache (1 line): - line 31: # TODO (ffrancet): This general pattern can be optimized by using tuples and dicts thrift/lib/cpp2/transport/core/ThriftClient.h (1 line): - line 120: // TODO: Refactor this to be cleaner. thrift/lib/cpp2/transport/rocket/server/RocketServerHandler.h (1 line): - line 58: // TODO current only Sink are supported by using channel build/fbcode_builder/getdeps/builder.py (1 line): - line 122: # TODO: Introduce some sort of defaults config that can select by build/fbcode_builder/getdeps/copytree.py (1 line): - line 75: TODO: I'd like to either extend this or add a variant that build/fbcode_builder/getdeps/py_wheel_builder.py (1 line): - line 158: # TODO: process the subdirectories of data_dir_name