fbpcs/emp_games/lift/calculator/OutputMetrics.hpp (13 lines): - line 165: // TODO: We shouldn't be using MPC for this, it should just be shared over - line 183: // TODO: We shouldn't be using MPC for this, it should just be shared over - line 228: // TODO: Figure out why this isn't working when using values other than - line 325: // TODO: We're using 32 bits for timestamps along with an offset setting the - line 437: // TODO: Computational shortcut possible by recognizing that bin 0 - line 453: // TODO: These could be abstracted into a common function - line 572: // TODO: These could be abstracted into a common function - line 619: // TODO: These could be abstracted into a common function - line 671: // TODO: These could be abstracted into a common function - line 750: // TODO: These could be abstracted into a common function - line 820: // TODO: These could be abstracted into a common function - line 859: // TODO: this can be optimizing by specializing this use case so we don't have - line 872: // TODO: this can be optimizing by specializing this use case so we don't have fbpcs/private_computation/service/private_computation.py (5 lines): - line 105: # TODO T88759390: make an async version of this function - line 176: # TODO T88759390: make an async version of this function - line 180: # TODO T88759390: make an async version of this function - line 277: # TODO T88759390: Make this function truly async. It is not because it calls blocking functions. - line 323: # TODO T88759390: make an async version of this function fbpcs/data_processing/lift_id_combiner/LiftIdSpineFileCombiner.cpp (4 lines): - line 26: // TODO: Rewrite for OSS? - line 62: // TODO T86923630: Uncomment this once data validation supports hashed ids - line 85: // TODO: Switch from stringstreams to a real random filename - line 187: // TODO: This should never happen if we actually use a tmp filename fbpcs/private_computation/entity/private_computation_instance.py (4 lines): - line 85: TODO T104391012: pass padding size to lift id spine combiner. - line 108: False # TODO T98578624: once the product is stabilized, we can enable this - line 113: # TODO T98476320: make the following optional attributes non-optional. They are optional - line 118: concurrency: int = 1 # used only by MPC compute metrics stage. TODO T102588568: rename to compute_metrics_concurrency fbpcs/private_computation/service/compute_metrics_stage_service.py (3 lines): - line 72: # TODO T88759390: Make this function truly async. It is not because it calls blocking functions. - line 146: # TODO: Make an entity representation for game args that can dump a dict to pass - line 191: # TODO: we eventually will want to get rid of the if-else here, which will be fbpcs/data_processing/pid_preparer/union_pid_preparer_cpp.py (3 lines): - line 121: # TODO: Support custom log path - line 131: # TODO: Probably put exe in an env variable? - line 157: # TODO: The ContainerService API for async instance creation only fbpcs/private_computation/service/prepare_data_stage_service.py (3 lines): - line 66: # TODO T88759390: Make this function truly async. It is not because it calls blocking functions. - line 88: # TODO: we will write log_cost_to_s3 to the instance, so this function interface - line 138: # TODO: T106159008 Add on attribution specific args fbpcs/data_processing/service/id_spine_combiner.py (3 lines): - line 30: # TODO T106159008: padding_size and run_name are only temporarily optional - line 36: # TODO: Combiner could be made async so we don't have to spawn our - line 40: # TODO: There's a weird dependency between these two services fbpcs/private_computation/service/aggregate_shards_stage_service.py (2 lines): - line 62: # TODO T88759390: Make this function truly async. It is not because it calls blocking functions. - line 83: # TODO T101225989: map aggregation_type from the compute stage to metrics_format_type fbpcs/emp_games/common/EmpOperationUtil.hpp (2 lines): - line 27: // TODO: Braced initialization - line 54: // TODO: If `in` is empty for some reason, immediately return 0. fbpcs/data_processing/id_combiner/DataPreparationHelpers.cpp (2 lines): - line 133: // TODO: Check that first and last are [] characters - line 134: // TODO: Using something like a stringview could make this more efficient fbpcs/emp_games/lift/common/LiftMetrics.cpp (2 lines): - line 40: // TODO: Could be replaced with zip_longest and map - line 83: // TODO: Could be replaced with zip_longest and map fbpcs/data_processing/pid_preparer/preparer.py (2 lines): - line 34: # TODO: Support custom log path - line 47: # TODO: Support custom log path fbpcs/pid/service/pid_service/pid_prepare_stage.py (1 line): - line 77: # TODO: Preparer could be made async so we don't have to spawn our fbpcs/emp_games/attribution/decoupled_attribution/AttributionMetrics.cpp (1 line): - line 73: // TODO: right now we use 0,1,2,.... as impression id. In future, fbpcs/data_processing/service/sharding_service.py (1 line): - line 61: # TODO: Probably put exe in an env variable? fbpcs/emp_games/attribution/decoupled_aggregation/Aggregator.h (1 line): - line 38: // TODO: Add fields for additional aggregatiors to PrivateAggregation. fbpcs/utils/config_yaml/reflect.py (1 line): - line 75: "Fill in remaining TODO entries in config.yml", fbpcs/infra/cloud_bridge/cli.py (1 line): - line 32: TODO: add GCP to this cli when it's ready fbpcs/data_processing/lift_id_combiner/LiftIdSpineCombiner.cpp (1 line): - line 14: // TODO: Rewrite for OSS? fbpcs/private_computation/service/decoupled_aggregation_stage_service.py (1 line): - line 70: # TODO T88759390: Make this function truly async. It is not because it calls blocking functions. fbpcs/data_processing/pid_preparer/UnionPIDDataPreparer.cpp (1 line): - line 27: // TODO: Rewrite for OSS? fbpcs/emp_games/lift/calculator/CalculatorGame.h (1 line): - line 41: * TODO: cohortOut should also be returned or sent to a file. fbpcs/private_computation/service/pid_stage_service.py (1 line): - line 67: # TODO T88759390: Make this function truly async. It is not because it calls blocking functions. fbpcs/private_computation/service/utils.py (1 line): - line 221: # TODO - hope we're using AWS! fbpcs/private_computation_cli/config.yml (1 line): - line 39: # TODO: Change this value with pl-task task definition in the following format (see Container Definitions section inside selected task definition revision): fbpcs/utils/config_yaml/config_yaml_dict.py (1 line): - line 30: "Fill in remaining TODO entries in config.yml", fbpcs/data_processing/pid_preparer/union_pid_data_preparer.cpp (1 line): - line 14: // TODO: Rewrite for OSS? fbpcs/emp_games/attribution/Aggregator.cpp (1 line): - line 241: // TODO: Try to split aem into a separate file fbpcs/data_processing/common/S3CopyFromLocalUtil.cpp (1 line): - line 19: // TODO: Auto-rewrite for open source? fbpcs/emp_games/common/Functional.h (1 line): - line 58: // TODO: Would be better to check *all* iterators instead of just first fbpcs/infra/cloud_bridge/deployment_helper/aws/aws_deployment_helper.py (1 line): - line 130: # TODO: pass the policy to be added from cli.py when we need more granular control fbpcs/emp_games/attribution/Aggregator.h (1 line): - line 39: // TODO: Try to split aems into a separate header file fbpcs/emp_games/attribution/main.cpp (1 line): - line 144: // TODO: remove the following and use cost.getNetworkBytes() or fbpcs/emp_games/attribution/Attribution.hpp (1 line): - line 235: // TODO: verify that the ids are the same on both ends fbpcs/private_computation/service/id_match_stage_service.py (1 line): - line 53: # TODO T88759390: Make this function truly async. It is not because it calls blocking functions. fbpcs/private_computation/service/post_processing_stage_service.py (1 line): - line 54: # TODO T88759390: Make this function truly async. It is not because it calls blocking functions. fbpcs/private_computation/service/decoupled_attribution_stage_service.py (1 line): - line 69: # TODO T88759390: Make this function truly async. It is not because it calls blocking functions. fbpcs/emp_games/attribution/AttributionMetrics.cpp (1 line): - line 83: // TODO: right now we use 0,1,2,.... as impression id. In future, fbpcs/pl_coordinator/pl_graphapi_utils.py (1 line): - line 71: # TODO rename to create_pl_instance since we now have a create_pa_instance function fbpcs/emp_games/common/EmpOperationUtil.h (1 line): - line 23: // TODO: Could probably be smarter about INT_SIZE here given the size of the