Places in code with 6 or more lines that are exactly the same.
Intro
- For duplication, we look at places in code where there are 6 or more lines of code that are exactly the same.
- Before duplication is calculated, the code is cleaned to remove empty lines, comments, and frequently duplicated constructs such as imports.
- You should aim at having as little as possible (<5%) of duplicated code as high-level of duplication can lead to maintenance difficulties, poor factoring, and logical contradictions.
- To learn more about duplications and techniques for eliminating duplication, Sokrates recommends the following resources:
- Avoid Repetition, MartinFlower.com (IEEE Software article)
- Refactoring duplicated code, sourcemaking.com
- Beck Design Rules, MartinFowler.com
- DRY (Don't Repeat Yourself) Principle, Wikipedia
- The Cut-and-Paste Programming Software Development Anti-Pattern, sourcemaking.com
- Code Smells / Duplicated Code, Jeff Atwood, codinghorror.com:
- "Duplicated code is the bane of software development. Stamp out duplication whenever possible. You should always be on the lookout for more subtle cases of near-duplication, too. Don't Repeat Yourself!"
- Reducing Coupling, MartinFlower.com (IEEE Software article):
- "There are several ways to describe coupling, but it boils down to this: If changing one module in a program requires changing another module, then coupling exists. ... Duplication always implies coupling, because changing one piece of duplicate code implies changing the other."
Duplication Overall
- 8% duplication:
- 32,636 cleaned lines of cleaned code (without empty lines, comments, and frequently duplicated constructs such as imports)
- 2,771 duplicated lines
- 312 duplicates
Duplication per Extension
Duplication per Component (primary)
Longest Duplicates
The list of 20 longest duplicates.
| Size | # | Folders | Files | Lines | Code |
|---|---|---|---|---|---|
| 87 | x 2 | src/Microsoft.Health.Fhi...dures/AcquireExportJobssrc/Microsoft.Health.Fhi...ures/AcquireReindexJobs |  acquireExportJobs.jsacquireReindexJobs.js |
10:137 (97%)10:137 (97%) | view |
| 34 | x 2 | src/Microsoft.Health.Fhi...Server/Features/Storagesrc/Microsoft.Health.Fhi...Server/Features/Storage |  SqlServerTaskConsumer.csSqlServerTaskConsumer.cs |
52:96 (20%)165:209 (20%) | view |
| 34 | x 2 | buildbuild |  ci-pipeline.ymlpr-pipeline.yml |
23:58 (18%)30:66 (9%) | view |
| 32 | x 2 | build/jobsbuild/jobs | run-export-tests.ymlrun-export-tests.yml |
9:46 (18%)107:144 (18%) | view |
| 30 | x 2 | src/Microsoft.Health.Fhi...Server/Features/Storagesrc/Microsoft.Health.Fhi...Server/Features/Storage | SqlServerTaskManager.csSqlServerTaskManager.cs |
96:132 (26%)144:180 (26%) | view |
| 29 | x 2 | build/jobsbuild/jobs | e2e-tests.ymlrun-export-tests.yml |
10:43 (25%)16:49 (16%) | view |
| 26 | x 2 | build/jobsbuild/jobs | e2e-tests.ymlrun-export-tests.yml |
10:40 (22%)114:144 (15%) | view |
| 23 | x 2 | build/jobsbuild/jobs | run-export-tests.ymlrun-export-tests.yml |
82:104 (13%)180:202 (13%) | view |
| 22 | x 2 | src/Microsoft.Health.Fhi...torage/TvpRowGenerationsrc/Microsoft.Health.Fhi...torage/TvpRowGeneration | BulkCompositeSearchParameterRowGenera...CompositeSearchParameterRowGenerator.cs |
29:79 (75%)29:79 (75%) | view |
| 20 | x 2 | src/Microsoft.Health.Fhi...isitors/QueryGeneratorssrc/Microsoft.Health.Fhi...isitors/QueryGenerators | SqlQueryGenerator.csSqlQueryGenerator.cs |
871:907 (3%)912:948 (3%) | view |
| 17 | x 2 | build/jobsbuild/jobs | e2e-tests.ymlrun-export-tests.yml |
113:129 (14%)84:100 (9%) | view |
| 17 | x 2 | build/jobsbuild/jobs | e2e-tests.ymlrun-export-tests.yml |
113:129 (14%)182:198 (9%) | view |
| 17 | x 2 | build/jobsbuild/jobs | run-export-tests.ymlrun-export-tests.yml |
48:72 (9%)146:170 (9%) | view |
| 16 | x 2 | buildbuild | ci-deploy.ymlci-pipeline.yml |
6:23 (10%)4:21 (8%) | view |
| 16 | x 2 | src/Microsoft.Health.Fhi...Server/Features/Storagesrc/Microsoft.Health.Fhi...Server/Features/Storage | SqlServerTaskConsumer.csSqlServerTaskConsumer.cs |
52:71 (9%)222:241 (9%) | view |
| 16 | x 2 | src/Microsoft.Health.Fhi...Server/Features/Storagesrc/Microsoft.Health.Fhi...Server/Features/Storage | SqlServerTaskConsumer.csSqlServerTaskManager.cs |
76:96 (9%)169:189 (14%) | view |
| 16 | x 2 | src/Microsoft.Health.Fhir.Core/Extensionssrc/Microsoft.Health.Fhi...tures/Search/Converters | TypedElementExtensions.csTypedElementExtensions.cs |
1:42 (84%)1:42 (100%) | view |
| 16 | x 2 | src/Microsoft.Health.Fhi...Server/Features/Storagesrc/Microsoft.Health.Fhi...Server/Features/Storage | SqlServerTaskConsumer.csSqlServerTaskConsumer.cs |
165:184 (9%)222:241 (9%) | view |
| 16 | x 2 | src/Microsoft.Health.Fhi...Server/Features/Storagesrc/Microsoft.Health.Fhi...Server/Features/Storage | SqlServerTaskConsumer.csSqlServerTaskManager.cs |
189:209 (9%)169:189 (14%) | view |
| 15 | x 2 | build/jobsbuild/jobs | cleanup-resourcegroup-aad.ymlcleanup.yml |
1:16 (100%)1:16 (48%) | view |
Duplicated Units
The list of top 20 duplicated units.
| Size | # | Folders | Files | Lines | Code |
|---|---|---|---|---|---|
| 34 | x 2 | src/Microsoft.Health.Fhi...dures/AcquireExportJobssrc/Microsoft.Health.Fhi...ures/AcquireReindexJobs | acquireExportJobs.jsacquireReindexJobs.js |
67:107 67:107 | view |
| 14 | x 2 | src/Microsoft.Health.Fhi...dures/AcquireExportJobssrc/Microsoft.Health.Fhi...ures/AcquireReindexJobs | acquireExportJobs.jsacquireReindexJobs.js |
86:101 86:101 | view |
| 13 | x 2 | src/Microsoft.Health.Fhir.Core/Extensionssrc/Microsoft.Health.Fhi...tures/Search/Converters | TypedElementExtensions.csTypedElementExtensions.cs |
17:33 17:33 | view |
| 21 | x 2 | src/Microsoft.Health.Fhi...dures/AcquireExportJobssrc/Microsoft.Health.Fhi...ures/AcquireReindexJobs | acquireExportJobs.jsacquireReindexJobs.js |
40:65 40:65 | view |
| 12 | x 2 | src/Microsoft.Health.Fhi...atures/Resources/Createsrc/Microsoft.Health.Fhi...atures/Resources/Upsert | ConditionalCreateResourceHandler.csConditionalUpsertResourceHandler.cs |
26:39 30:43 | view |
| 12 | x 2 | src/Microsoft.Health.Fhi...torage/TvpRowGenerationsrc/Microsoft.Health.Fhi...torage/TvpRowGeneration | BulkCompartmentAssignmentV1RowGenerat...CompartmentAssignmentV1RowGenerator.cs |
98:112 82:96 | view |
| 11 | x 2 | src/Microsoft.Health.Fhi...atures/Resources/Bundlesrc/Microsoft.Health.Fhi...atures/Resources/Bundle | BundleHandler.csBundleHandler.cs |
13:24 13:24 | view |
| 10 | x 2 | src/Microsoft.Health.Fhi...torage/TvpRowGenerationsrc/Microsoft.Health.Fhi...torage/TvpRowGeneration | BulkCompositeSearchParameterRowGenera...CompositeSearchParameterRowGenerator.cs |
29:40 29:40 | view |
| 9 | x 6 | src/Microsoft.Health.Fhi...ions/ConvertData/Modelssrc/Microsoft.Health.Fhi...ions/ConvertData/Modelssrc/Microsoft.Health.Fhi...ions/ConvertData/Modelssrc/Microsoft.Health.Fhi...ions/ConvertData/Modelssrc/Microsoft.Health.Fhi...ions/ConvertData/Modelssrc/Microsoft.Health.Fhi...ions/ConvertData/Models | ContainerRegistryNotAuthorizedExcepti...ConvertDataFailedException.csConvertDataTimeoutException.csConvertDataUnhandledException.csFetchTemplateCollectionFailedExceptio...TemplateCollectionErrorException.cs |
25:35 25:35 14:24 14:24 14:24 14:24 | view |
| 8 | x 2 | src/Microsoft.Health.Fhir.Api/Features/Exceptionssrc/Microsoft.Health.Fhir.Api/Features/Exceptions | BundleEntryLimitExceededException.csProvenanceHeaderException.cs |
14:23 14:23 | view |
| 8 | x 3 | src/Microsoft.Health.Fhi...re/Features/Compartmentsrc/Microsoft.Health.Fhi...ed.Core/Features/Searchsrc/Microsoft.Health.Fhi...ed.Core/Features/Search | SearchCompartmentHandler.csSearchResourceHandler.csSearchResourceHistoryHandler.cs |
33:42 33:42 24:33 | view |
| 8 | x 2 | src/Microsoft.Health.Fhi...re/Features/Conformancesrc/Microsoft.Health.Fhi...re/Features/Conformance | ConformanceProviderExtensions.csConformanceProviderExtensions.cs |
25:33 35:43 | view |
| 8 | x 4 | src/Microsoft.Health.Fhi...ions/ConvertData/Modelssrc/Microsoft.Health.Fhi...ions/ConvertData/Modelssrc/Microsoft.Health.Fhi...ions/ConvertData/Modelssrc/Microsoft.Health.Fhi...ions/ConvertData/Models | ContainerRegistryNotAuthorizedExcepti...ContainerRegistryNotConfiguredExcepti...ContainerRegistryNotFoundException.csConvertDataFailedException.cs |
14:23 14:23 14:23 14:23 | view |
| 8 | x 2 | src/Microsoft.Health.Fhi...atures/Resources/Deletesrc/Microsoft.Health.Fhi.../Features/Resources/Get | DeleteResourceHandler.csGetResourceHandler.cs |
23:31 23:31 | view |
| 8 | x 2 | src/Microsoft.Health.Fhi...torage/TvpRowGenerationsrc/Microsoft.Health.Fhi...torage/TvpRowGeneration | BulkSearchParameterRowGenerator.csSearchParameterRowGenerator.cs |
75:85 59:69 | view |
| 7 | x 2 | src/Microsoft.Health.Fhir.Core/Extensionssrc/Microsoft.Health.Fhi...tures/Search/Converters | TypedElementExtensions.csTypedElementExtensions.cs |
35:43 35:43 | view |
| 7 | x 3 | src/Microsoft.Health.Fhi...tures/Operations/Exportsrc/Microsoft.Health.Fhi...tures/Operations/Exportsrc/Microsoft.Health.Fhi...tures/Operations/Export | AnonymizationConfigurationFetchExcept...FailedToAnonymizeResourceException.csFailedToParseAnonymizationConfigurati... |
18:25 18:25 18:25 | view |
| 7 | x 3 | src/Microsoft.Health.Fhi...tures/Operations/Exportsrc/Microsoft.Health.Fhi...tures/Operations/Exportsrc/Microsoft.Health.Fhi...tures/Operations/Export | AnonymizationConfigurationFetchExcept...FailedToAnonymizeResourceException.csFailedToParseAnonymizationConfigurati... |
27:34 27:34 27:34 | view |
| 7 | x 2 | src/Microsoft.Health.Fhi...tures/Operations/Importsrc/Microsoft.Health.Fhi...tures/Operations/Import | ImportOrchestratorTask.csImportProcessingTask.cs |
543:550 259:266 | view |
| 7 | x 2 | src/Microsoft.Health.Fhi...tures/Search/Converterssrc/Microsoft.Health.Fhi...tures/Search/Converters | OidToUriSearchValueConverter.csUriToUriSearchValueConverter.cs |
22:30 22:30 | view |