Places in code with 6 or more lines that are exactly the same.
Intro
- For duplication, we look at places in code where there are 6 or more lines of code that are exactly the same.
- Before duplication is calculated, the code is cleaned to remove empty lines, comments, and frequently duplicated constructs such as imports.
- You should aim at having as little as possible (<5%) of duplicated code as high-level of duplication can lead to maintenance difficulties, poor factoring, and logical contradictions.
- To learn more about duplications and techniques for eliminating duplication, Sokrates recommends the following resources:
- Avoid Repetition, MartinFlower.com (IEEE Software article)
- Refactoring duplicated code, sourcemaking.com
- Beck Design Rules, MartinFowler.com
- DRY (Don't Repeat Yourself) Principle, Wikipedia
- The Cut-and-Paste Programming Software Development Anti-Pattern, sourcemaking.com
- Code Smells / Duplicated Code, Jeff Atwood, codinghorror.com:
- "Duplicated code is the bane of software development. Stamp out duplication whenever possible. You should always be on the lookout for more subtle cases of near-duplication, too. Don't Repeat Yourself!"
- Reducing Coupling, MartinFlower.com (IEEE Software article):
- "There are several ways to describe coupling, but it boils down to this: If changing one module in a program requires changing another module, then coupling exists. ... Duplication always implies coupling, because changing one piece of duplicate code implies changing the other."
Duplication Overall
- 31% duplication:
- 51,211 cleaned lines of cleaned code (without empty lines, comments, and frequently duplicated constructs such as imports)
- 15,920 duplicated lines
- 17,851 duplicates
Duplication per Extension
Duplication per Component (primary)
Duplication Between Components (50+ lines)
Open 3D force graph...
Show more details on duplication between components...
From Component
--> To Component
Duplicated
Lines
File Pairs
Details
src/Microsoft.ServiceFabric.Client.Http/Extensions (56%)
--> src/Microsoft.ServiceFabric.Client.Http/Generated (1%)
903
38 file pairs
details...
src/Microsoft.ServiceFabric.Client.Http/Generated (<1%)
--> src/Microsoft.ServiceFabric.Client/Generated (16%)
424
11 file pairs
details...
src/Microsoft.ServiceFabric.Powershell.Http/Generated (<1%)
--> src/Microsoft.ServiceFabric.Powershell.Http (6%)
115
10 file pairs
details...
| From Component --> To Component |
Duplicated Lines |
File Pairs | Details |
|---|---|---|---|
| src/Microsoft.ServiceFabric.Client.Http/Extensions (56%) --> src/Microsoft.ServiceFabric.Client.Http/Generated (1%) |
903 | 38 file pairs | details... |
| src/Microsoft.ServiceFabric.Client.Http/Generated (<1%) --> src/Microsoft.ServiceFabric.Client/Generated (16%) |
424 | 11 file pairs | details... |
| src/Microsoft.ServiceFabric.Powershell.Http/Generated (<1%) --> src/Microsoft.ServiceFabric.Powershell.Http (6%) |
115 | 10 file pairs | details... |
Longest Duplicates
The list of 20 longest duplicates.
| Size | # | Folders | Files | Lines | Code |
|---|---|---|---|---|---|
| 98 | x 2 | src/Microsoft.ServiceFab...wershell.Http/Generatedsrc/Microsoft.ServiceFab...wershell.Http/Generated |  NewRepairTaskCmdlet.csUpdateRepairExecutionStateCmdlet.cs |
22:273 (91%)22:273 (91%) | view |
| 83 | x 2 | src/Microsoft.ServiceFab...wershell.Http/Generatedsrc/Microsoft.ServiceFab...wershell.Http/Generated | NewBackupPolicyCmdlet.csUpdateBackupPolicyCmdlet.cs |
22:193 (48%)22:193 (47%) | view |
| 81 | x 2 | src/Microsoft.ServiceFab...wershell.Http/Generatedsrc/Microsoft.ServiceFab...wershell.Http/Generated | StartClusterUpgradeCmdlet.csValidateClusterUpgradeCmdlet.cs |
22:304 (92%)22:304 (89%) | view |
| 50 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | StatefulReplicaHealthReportExpiredEve...StatefulReplicaNewHealthReportEventCo... |
36:120 (54%)36:120 (54%) | view |
| 50 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | DeployedApplicationHealthReportExpire...DeployedApplicationNewHealthReportEve... |
36:120 (54%)36:120 (54%) | view |
| 48 | x 2 | src/Microsoft.ServiceFab...wershell.Http/Generatedsrc/Microsoft.ServiceFab...wershell.Http/Generated | NewBackupPolicyCmdlet.csUpdateBackupPolicyCmdlet.cs |
267:334 (28%)273:340 (27%) | view |
| 47 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | NodeHealthReportExpiredEventConverter.csNodeNewHealthReportEventConverter.cs |
36:115 (54%)36:115 (54%) | view |
| 47 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | StatelessReplicaHealthReportExpiredEv...StatelessReplicaNewHealthReportEventC... |
36:115 (54%)36:115 (54%) | view |
| 47 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | ApplicationHealthReportExpiredEventCo...ApplicationNewHealthReportEventConver... |
36:115 (54%)36:115 (54%) | view |
| 47 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | ServiceHealthReportExpiredEventConver...ServiceNewHealthReportEventConverter.cs |
36:115 (54%)36:115 (54%) | view |
| 44 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | NodeAbortedEventConverter.csNodeOpenSucceededEventConverter.cs |
36:110 (54%)36:110 (54%) | view |
| 44 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | PartitionHealthReportExpiredEventConv...PartitionNewHealthReportEventConverte... |
36:110 (54%)36:110 (54%) | view |
| 41 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | ClusterHealthReportExpiredEventConver...ClusterNewHealthReportEventConverter.cs |
36:105 (53%)36:105 (53%) | view |
| 38 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | NodeAddedToClusterEventConverter.csNodeRemovedFromClusterEventConverter.cs |
36:100 (53%)36:100 (53%) | view |
| 34 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | StatefulServiceDescriptionConverter.csStatelessServiceDescriptionConverter.cs |
64:129 (20%)60:125 (23%) | view |
| 33 | x 2 | src/Microsoft.ServiceFabric.Common/Generatedsrc/Microsoft.ServiceFabric.Common/Generated | DeployedApplicationHealthReportExpire...DeployedApplicationNewHealthReportEve... |
59:133 (61%)59:133 (61%) | view |
| 32 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | ChaosReplicaRemovalScheduledEventConv...ChaosReplicaRestartScheduledEventConv... |
36:90 (52%)36:90 (52%) | view |
| 31 | x 2 | src/Microsoft.ServiceFabric.Common/Generatedsrc/Microsoft.ServiceFabric.Common/Generated | StatefulReplicaHealthReportExpiredEve...StatefulReplicaNewHealthReportEvent.cs |
61:129 (59%)61:129 (59%) | view |
| 30 | x 2 | src/Microsoft.ServiceFabric.Common/Generatedsrc/Microsoft.ServiceFabric.Common/Generated | NodeHealthReportExpiredEvent.csNodeNewHealthReportEvent.cs |
52:119 (60%)52:119 (60%) | view |
| 30 | x 2 | src/Microsoft.ServiceFabric.Common/Generatedsrc/Microsoft.ServiceFabric.Common/Generated | ApplicationHealthReportExpiredEvent.csApplicationNewHealthReportEvent.cs |
57:124 (60%)57:124 (60%) | view |
Duplicated Units
The list of top 20 duplicated units.
| Size | # | Folders | Files | Lines | Code |
|---|---|---|---|---|---|
| 32 | x 2 | src/Microsoft.ServiceFabric.Client.Http/Generatedsrc/Microsoft.ServiceFabric.Client.Http/Generated | PartitionClient.csPartitionClient.cs |
582:618 621:657 | view |
| 30 | x 2 | src/Microsoft.ServiceFabric.Client.Http/Generatedsrc/Microsoft.ServiceFabric.Client.Http/Generated | NodeClient.csNodeClient.cs |
497:532 535:570 | view |
| 29 | x 3 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | SecondaryActiveReplicatorStatusConver...SecondaryIdleReplicatorStatusConverte...SecondaryReplicatorStatusConverter.cs |
91:127 91:127 97:133 | view |
| 27 | x 2 | src/Microsoft.ServiceFabric.Client.Http/Generatedsrc/Microsoft.ServiceFabric.Client.Http/Generated | RepairManagementClient.csRepairManagementClient.cs |
37:69 242:274 | view |
| 26 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | DeployedApplicationHealthReportExpire...DeployedApplicationNewHealthReportEve... |
145:174 145:174 | view |
| 26 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | StatefulReplicaHealthReportExpiredEve...StatefulReplicaNewHealthReportEventCo... |
145:174 145:174 | view |
| 25 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | ApplicationHealthReportExpiredEventCo...ApplicationNewHealthReportEventConver... |
139:167 139:167 | view |
| 25 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | NodeHealthReportExpiredEventConverter.csNodeNewHealthReportEventConverter.cs |
139:167 139:167 | view |
| 25 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | ServiceHealthReportExpiredEventConver...ServiceNewHealthReportEventConverter.cs |
139:167 139:167 | view |
| 25 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | StatelessReplicaHealthReportExpiredEv...StatelessReplicaNewHealthReportEventC... |
139:167 139:167 | view |
| 24 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | NodeAbortedEventConverter.csNodeOpenSucceededEventConverter.cs |
133:160 133:160 | view |
| 24 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | PartitionHealthReportExpiredEventConv...PartitionNewHealthReportEventConverte... |
133:160 133:160 | view |
| 23 | x 2 | src/Microsoft.ServiceFabric.Client.Http/Generatedsrc/Microsoft.ServiceFabric.Client.Http/Generated | ApplicationClient.csBackupRestoreClient.cs |
534:561 408:435 | view |
| 23 | x 3 | src/Microsoft.ServiceFabric.Client.Http/Generatedsrc/Microsoft.ServiceFabric.Client.Http/Generatedsrc/Microsoft.ServiceFabric.Client.Http/Generated | BackupRestoreClient.csBackupRestoreClient.csPartitionClient.cs |
629:656 659:686 384:411 | view |
| 23 | x 3 | src/Microsoft.ServiceFabric.Client.Http/Generatedsrc/Microsoft.ServiceFabric.Client.Http/Generatedsrc/Microsoft.ServiceFabric.Client.Http/Generated | BackupRestoreClient.csBackupRestoreClient.csPartitionClient.cs |
840:867 870:897 324:351 | view |
| 23 | x 2 | src/Microsoft.ServiceFabric.Client.Http/Generatedsrc/Microsoft.ServiceFabric.Client.Http/Generated | ComposeDeploymentClient.csComposeDeploymentClient.cs |
167:194 238:265 | view |
| 23 | x 2 | src/Microsoft.ServiceFabric.Client.Http/Generatedsrc/Microsoft.ServiceFabric.Client.Http/Generated | NodeClient.csNodeClient.cs |
293:320 323:350 | view |
| 23 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | ClusterHealthReportExpiredEventConver...ClusterNewHealthReportEventConverter.cs |
127:153 127:153 | view |
| 22 | x 2 | src/Microsoft.ServiceFab...Generated/Serializationsrc/Microsoft.ServiceFab...Generated/Serialization | NodeAddedToClusterEventConverter.csNodeRemovedFromClusterEventConverter.cs |
121:146 121:146 | view |
| 20 | x 3 | src/Microsoft.ServiceFabric.Client.Http/Generatedsrc/Microsoft.ServiceFabric.Client.Http/Generatedsrc/Microsoft.ServiceFabric.Client.Http/Generated | ChaosClient.csClusterClient.csPartitionClient.cs |
102:126 543:567 414:438 | view |