Places in code with 6 or more lines that are exactly the same.
Intro
- For duplication, we look at places in code where there are 6 or more lines of code that are exactly the same.
- Before duplication is calculated, the code is cleaned to remove empty lines, comments, and frequently duplicated constructs such as imports.
- You should aim at having as little as possible (<5%) of duplicated code as high-level of duplication can lead to maintenance difficulties, poor factoring, and logical contradictions.
- To learn more about duplications and techniques for eliminating duplication, Sokrates recommends the following resources:
- Avoid Repetition, MartinFlower.com (IEEE Software article)
- Refactoring duplicated code, sourcemaking.com
- Beck Design Rules, MartinFowler.com
- DRY (Don't Repeat Yourself) Principle, Wikipedia
- The Cut-and-Paste Programming Software Development Anti-Pattern, sourcemaking.com
- Code Smells / Duplicated Code, Jeff Atwood, codinghorror.com:
- "Duplicated code is the bane of software development. Stamp out duplication whenever possible. You should always be on the lookout for more subtle cases of near-duplication, too. Don't Repeat Yourself!"
- Reducing Coupling, MartinFlower.com (IEEE Software article):
- "There are several ways to describe coupling, but it boils down to this: If changing one module in a program requires changing another module, then coupling exists. ... Duplication always implies coupling, because changing one piece of duplicate code implies changing the other."
Duplication Overall
- 18% duplication:
- 24,989 cleaned lines of cleaned code (without empty lines, comments, and frequently duplicated constructs such as imports)
- 4,594 duplicated lines
- 581 duplicates
Duplication per Extension
Duplication per Component (primary)
Duplication Between Components (50+ lines)
Open 3D force graph...
Show more details on duplication between components...
From Component
--> To Component
Duplicated
Lines
File Pairs
Details
src/Microsoft.ServiceFabric.Actors (1%)
--> src/Microsoft.ServiceFabric.Services.Remoting (2%)
332
17 file pairs
details...
src/Microsoft.ServiceFabric.Actors (1%)
--> src/Microsoft.ServiceFabric.Services (3%)
272
3 file pairs
details...
src/Microsoft.ServiceFabric.Services.Remoting (<1%)
--> src/Microsoft.ServiceFabric.Services.Wcf (4%)
117
5 file pairs
details...
| From Component --> To Component |
Duplicated Lines |
File Pairs | Details |
|---|---|---|---|
| src/Microsoft.ServiceFabric.Actors (1%) --> src/Microsoft.ServiceFabric.Services.Remoting (2%) |
332 | 17 file pairs | details... |
| src/Microsoft.ServiceFabric.Actors (1%) --> src/Microsoft.ServiceFabric.Services (3%) |
272 | 3 file pairs | details... |
| src/Microsoft.ServiceFabric.Services.Remoting (<1%) --> src/Microsoft.ServiceFabric.Services.Wcf (4%) |
117 | 5 file pairs | details... |
Longest Duplicates
The list of 20 longest duplicates.
| Size | # | Folders | Files | Lines | Code |
|---|---|---|---|---|---|
| 51 | x 2 | src/Microsoft.ServiceFab...ces.Remoting/Diagnosticsrc/Microsoft.ServiceFab....Remoting/V2/Diagnostic |  ServiceRemotingPerformanceCounters.csServiceRemotingPerformanceCounters.cs |
138:190 (33%)79:131 (49%) | view |
| 45 | x 2 | src/Microsoft.ServiceFabric.Services/Runtimesrc/Microsoft.ServiceFabric.Services/Runtime | StatefulServiceReplicaAdapter.csStatelessServiceInstanceAdapter.cs |
531:604 (13%)345:417 (18%) | view |
| 34 | x 2 | src/Microsoft.ServiceFabric.Actorssrc/Microsoft.ServiceFabric.Services | ActorEventSource.csServiceEventSource.cs |
55:125 (16%)49:119 (15%) | view |
| 34 | x 2 | src/Microsoft.ServiceFab...ces.Remoting/Diagnosticsrc/Microsoft.ServiceFab....Remoting/V2/Diagnostic | ServicePerformanceCounterProvider.csServiceRemotingPerformanceCounterProv... |
306:342 (12%)156:192 (22%) | view |
| 27 | x 2 | src/Microsoft.ServiceFab...ces.Remoting/Diagnosticsrc/Microsoft.ServiceFab....Remoting/V2/Diagnostic | ServiceRemotingPerformanceCounters.csServiceRemotingPerformanceCounters.cs |
60:95 (17%)38:73 (25%) | view |
| 26 | x 2 | src/Microsoft.ServiceFab...ces.Remoting/Diagnosticsrc/Microsoft.ServiceFab....Remoting/V2/Diagnostic | ServicePerformanceCounterProvider.csServiceRemotingPerformanceCounterProv... |
172:212 (9%)107:147 (17%) | view |
| 24 | x 2 | src/Microsoft.ServiceFab...ces.Remoting/V1/Buildersrc/Microsoft.ServiceFab...ces.Remoting/V2/Builder | MethodDispatcherBuilder.csMethodDispatcherBuilder.cs |
87:125 (11%)365:403 (8%) | view |
| 23 | x 2 | src/Microsoft.ServiceFabric.Services/Runtimesrc/Microsoft.ServiceFabric.Services/Runtime | StatefulServiceReplicaAdapter.csStatelessServiceInstanceAdapter.cs |
608:652 (6%)431:475 (9%) | view |
| 17 | x 2 | src/Microsoft.ServiceFab...tors/Remoting/V1/Clientsrc/Microsoft.ServiceFab...tors/Remoting/V2/Client | ActorEventSubscriberManager.csActorEventSubscriberManager.cs |
78:113 (33%)69:104 (36%) | view |
| 17 | x 2 | src/Microsoft.ServiceFab...ces.Remoting/V1/Buildersrc/Microsoft.ServiceFab...ces.Remoting/V2/Builder | MethodDispatcherBuilder.csMethodDispatcherBuilder.cs |
42:67 (8%)50:75 (6%) | view |
| 17 | x 2 | src/Microsoft.ServiceFab...ces.Remoting/V1/Buildersrc/Microsoft.ServiceFab...ces.Remoting/V2/Builder | MethodDispatcherBuilder.csMethodDispatcherBuilder.cs |
128:151 (8%)406:429 (6%) | view |
| 17 | x 2 | src/Microsoft.ServiceFab...rvices.Remoting/Buildersrc/Microsoft.ServiceFab...rvices.Remoting/Builder | ProxyGeneratorBuilder.csProxyGeneratorBuilder.cs |
127:151 (6%)268:292 (6%) | view |
| 16 | x 2 | src/Microsoft.ServiceFabric.Actors/Remotingsrc/Microsoft.ServiceFabric.Actors/Remoting | ActorDataContractSurrogate.csActorDataContractSurrogate.cs |
21:55 (32%)66:100 (32%) | view |
| 16 | x 2 | src/Microsoft.ServiceFab...rvices.Remoting/Buildersrc/Microsoft.ServiceFab...ces.Remoting/V2/Builder | ProxyGeneratorBuilder.csProxyGeneratorBuilder.cs |
384:404 (6%)370:390 (6%) | view |
| 16 | x 2 | src/Microsoft.ServiceFab...FabricTransport/Runtimesrc/Microsoft.ServiceFab...FabricTransport/Runtime | FabricTransportServiceRemotingConnect...FabricTransportRemotingConnectionHand... |
20:51 (84%)19:50 (84%) | view |
| 16 | x 2 | src/Microsoft.ServiceFab...ices.Remoting/V1/Clientsrc/Microsoft.ServiceFab...ices.Remoting/V2/Client | ServiceRemotingPartitionClient.csServiceRemotingPartitionClient.cs |
17:34 (27%)17:34 (22%) | view |
| 15 | x 2 | src/Microsoft.ServiceFab...ces.Remoting/V1/Buildersrc/Microsoft.ServiceFab...ces.Remoting/V2/Builder | MethodDispatcherBuilder.csMethodDispatcherBuilder.cs |
167:189 (7%)246:268 (5%) | view |
| 15 | x 2 | src/Microsoft.ServiceFab...ices.Remoting/V1/Clientsrc/Microsoft.ServiceFab...ices.Remoting/V2/Client | ServiceRemotingPartitionClient.csServiceRemotingPartitionClient.cs |
95:128 (25%)102:138 (21%) | view |
| 15 | x 2 | src/Microsoft.ServiceFabric.Actors/Runtimesrc/Microsoft.ServiceFabric.Actors/Runtime | ReliableCollectionsActorStateProvider.csVolatileActorStateProvider.cs |
160:200 (2%)100:140 (2%) | view |
| 15 | x 2 | src/Microsoft.ServiceFabric.Actors/Runtimesrc/Microsoft.ServiceFabric.Actors/Runtime | KvsActorStateProviderBase.csVolatileActorStateProvider.cs |
109:149 (2%)100:140 (2%) | view |
Duplicated Units
The list of top 20 duplicated units.
| Size | # | Folders | Files | Lines | Code |
|---|---|---|---|---|---|
| 36 | x 2 | src/Microsoft.ServiceFabric.Services/Runtimesrc/Microsoft.ServiceFabric.Services/Runtime | StatefulServiceReplicaAdapter.csStatelessServiceInstanceAdapter.cs |
564:606 377:419 | view |
| 35 | x 2 | src/Microsoft.ServiceFabric.Services/Runtimesrc/Microsoft.ServiceFabric.Services/Runtime | StatefulServiceReplicaAdapter.csStatelessServiceInstanceAdapter.cs |
608:650 431:473 | view |
| 29 | x 2 | src/Microsoft.ServiceFab...ces.Remoting/V1/Buildersrc/Microsoft.ServiceFab...ces.Remoting/V2/Builder | MethodDispatcherBuilder.csMethodDispatcherBuilder.cs |
79:115 357:393 | view |
| 19 | x 2 | src/Microsoft.ServiceFabric.Actors/Diagnosticssrc/Microsoft.ServiceFab...ces.Remoting/Diagnostic | PerformanceCounterProvider.csServicePerformanceCounterProvider.cs |
395:415 346:366 | view |
| 17 | x 2 | src/Microsoft.ServiceFab...ces.Remoting/Diagnosticsrc/Microsoft.ServiceFab....Remoting/V2/Diagnostic | ServicePerformanceCounterProvider.csServiceRemotingPerformanceCounterProv... |
368:386 196:214 | view |
| 15 | x 2 | src/Microsoft.ServiceFab...ces.Remoting/Diagnosticsrc/Microsoft.ServiceFab....Remoting/V2/Diagnostic | ServicePerformanceCounterProvider.csServiceRemotingPerformanceCounterProv... |
196:213 131:148 | view |
| 15 | x 2 | src/Microsoft.ServiceFab...ices.Remoting/V1/Clientsrc/Microsoft.ServiceFab...ices.Remoting/V2/Client | ServiceRemotingPartitionClient.csServiceRemotingPartitionClient.cs |
21:36 21:36 | view |
| 14 | x 2 | src/Microsoft.ServiceFab...tors/Remoting/V1/Clientsrc/Microsoft.ServiceFab...tors/Remoting/V2/Client | ActorProxyFactory.csActorProxyFactory.cs |
103:118 71:86 | view |
| 14 | x 2 | src/Microsoft.ServiceFab...tors/Remoting/V1/Clientsrc/Microsoft.ServiceFab...tors/Remoting/V2/Client | ActorProxyFactory.csActorProxyFactory.cs |
229:245 212:228 | view |
| 14 | x 2 | src/Microsoft.ServiceFab...ices.Remoting/V1/Clientsrc/Microsoft.ServiceFab...ices.Remoting/V2/Client | ServiceProxyFactory.csServiceProxyFactory.cs |
90:104 103:117 | view |
| 14 | x 2 | src/Microsoft.ServiceFab...ices.Remoting/V1/Clientsrc/Microsoft.ServiceFab...ices.Remoting/V2/Client | ServiceProxyFactory.csServiceProxyFactory.cs |
135:151 170:186 | view |
| 14 | x 2 | src/Microsoft.ServiceFab.../FabricTransport/Clientsrc/Microsoft.ServiceFab.../FabricTransport/Client | FabricTransportServiceRemotingClientF...FabricTransportServiceRemotingClientF... |
199:213 260:274 | view |
| 14 | x 2 | src/Microsoft.ServiceFab.../FabricTransport/Clientsrc/Microsoft.ServiceFab.../FabricTransport/Client | FabricTransportServiceRemotingClientF...FabricTransportServiceRemotingClientF... |
215:229 276:290 | view |
| 14 | x 2 | src/Microsoft.ServiceFabric.Services.Remoting/V2src/Microsoft.ServiceFabric.Services.Remoting/V2 | ServiceRemotingDataContractSerializat...ServiceRemotingDataContractSerializat... |
104:119 121:136 | view |
| 13 | x 2 | src/Microsoft.ServiceFabric.Actors/Runtimesrc/Microsoft.ServiceFabric.Actors/Runtime | ActorEventManager.csMockActorEventManager.cs |
51:65 36:50 | view |
| 13 | x 2 | src/Microsoft.ServiceFabric.Services.Remoting/V2src/Microsoft.ServiceFabric.Services.Remoting/V2 | BasicDataContractHeaderSerializer.csServiceRemotingMessageHeaderSerialize... |
62:76 65:79 | view |
| 13 | x 2 | src/Microsoft.ServiceFabric.Services.Remoting/V2src/Microsoft.ServiceFabric.Services.Remoting/V2 | BasicDataContractHeaderSerializer.csServiceRemotingMessageHeaderSerialize... |
97:111 99:113 | view |
| 12 | x 2 | src/Microsoft.ServiceFabric.Actors/Clientsrc/Microsoft.ServiceFab...ervices.Remoting/Client | ActorProxyFactory.csServiceProxyFactory.cs |
198:210 218:230 | view |
| 12 | x 2 | src/Microsoft.ServiceFabric.Actors/Remotingsrc/Microsoft.ServiceFabric.Actors/Remoting | ActorDataContractSurrogate.csActorDataContractSurrogate.cs |
43:56 88:101 | view |
| 11 | x 2 | src/Microsoft.ServiceFabric.Actors/Remotingsrc/Microsoft.ServiceFabric.Actors/Remoting | ActorDataContractSurrogate.csActorDataContractSurrogate.cs |
29:41 74:86 | view |