Summary: 1528 instances, 1246 unique Text Count (LONGLONG)0 // TODO seperate template for this trace 2 HttpConstants::MaxEntityBodySize) // TODO: This should be changed to settings.xml 1 __in int timeoutInMilliSeconds); //TODO: Make this private 1 // TODO: This is a temporary fix for the copy before checkpoint case. 1 //TODO: Can be changed to BeginWaitForTransition to STarted stated. In this case, we won't need the due time in VersionedSP. 1 // TODO: Trace 1 // TODO: KWString should be replaced by KString once ktl apis are fixed 3 // TODO: implement the version with only the acquire semantics 1 // TODO: Remove this when stabilized 1 // TODO: Remove this exception for broadcast during M1 refactoring 1 // @TODO - Change this to a iterator based batch interface 1 // TODO: add buffer to a karray 1 MessageUPtr response = make_unique(notification); // TODO: We should return empty message. 1 // TODO: jit64 should be switched to the same plan as the i386 jits - use 1 // TODO: Post GA, move this logic into the lock class. 1 // TODO: ToString needs to be changed since JSON doesnt serialize the clusterconnectionport 1 // TODO: Reconsider infinite retry. 1 // TODO: Dump redo and undo bytes 1 RETAIL_CONFIG_STRING_INFO_DIRECT_ACCESS(EXTERNAL_developerInstallation, W("developerInstallation"), "Flag to enable DEVPATH binding feature") // TODO: check special handling 1 // TODO: Define a new failure report routine 1 // TODO Kernel mode 1 // TODO: change from ComPointer to IOperationDataStreamPtr 2 // TODO: flags? 1 // TODO: Log 1 /// TODO: RDBug 11875738: FabricClientRetryErrors.All: Fill the info using reflection over the all defined retryable error rules per operation. 1 // TODO: Handle cases when instance name cannot be mapped 1 // TODO - return the description with status. 1 { "ApplicationConfig.Freeze", ImpactCategory.NoImpact }, // TODO: Review new impact 1 // TODO: there is a store GetAsync at the bottom of this enumeration so think about the exceptions 1 // TODO: validation against schema 1 // TODO should this be RoleInstancesToBeImpacted or JobStep.CurrentlyImpactedRoleInstances? 1 // TODO: Fix this by using operationdata in this class 2 //TODO move other common code from ComStatelessServicePartition and ComStatefulServicePartition into this base class 1 // TODO Reduce duplicate logic in GetService/GetApp functions. 1 // TODO: document the exact role and reliability of the CloseMessageSequenceNumber in the driver 1 // TODO: Consider not completing here, but propagating the timeout error code to the completion of the request so OnRequestCallback will call complete. 1 // TODO: Start: DebugOnly 1 //TODO shuxu check 2 // TODO: what do we do if responseResult is failure? 1 // Re-Launch CI. TODO Have some policy to restart only X Times and then crash the process. 1 // TODO: deal with exceptions 1 // TODO: The rest of lpSystemInfo 1 // TODO: find out how to track original activity id. 1 // TODO: Need to dump out why the record isn't valid 1 // TODO: review lifecycle management of openOp_ 1 // TODO: emulate event files 2 /// TODO : Improve this. 1 /// TODO: Consider moving it out of this generic interface into implementation. Kids can cast and check. 1 { "ApplicationConfig.Initialize", ImpactCategory.NoImpact }, // TODO: Review new impact 1 // TODO: consider making this max window size and making window size dynamic 1 // TODO: This should ideally be removed 1 // TODO: Refine this Logic. 1 // TODO: fix callback - Where does the invoke verb live in the XML 1 // TODO: Asynchronous T[] ToArray(). 1 //TODO: Optimize lookup to not to use 2 maps. 1 // TODO: the environment should really be baked into all these pooled resources at the environment level 1 // TODO consider deriving this class into AckImpactStartJob and AckImpactEndJob to override the ActionType. 1 // TODO we can get this with bit-shifts. but okay for now. 1 // TODO: Hosting to provide us with a backup folder. 1 ///TODO: remove 1 // TODO: Handle this situation by reading the next record and 1 /// TODO: incorporate retry on quota exceeded, return true if we don't encounter session aborted exceptions, false otherwise 1 // to WebSocketManager. TODO: make this cleaner 1 // TODO: Discriminated union over various buffer pointers? Might save us 4 bytes... 1 //LINUXTODO move exitProcessCalled to libFabricCommon.so to truly avoid racing calls to exit() 1 // TODO: Why are we ignoring the session abort callbacks. 1 // TODO: Examples 1 // Add the connection to Runtime. TODO Get rid of this and pass this explicitly. 1 // TODO: Holding the lock during network call - improve. 1 // TODO: Consider Assert. 2 // TODO: Remove this when stabilized 1 // TODO: This error should be sent as errorcode value's message 1 TODO: implement this as a template structure -- runs into some compiler issues 1 // TODO: Wait for some time so that the unreliable transport behavior can be read from the files. 1 // TODO: no need to get initial violation list if we are sure CorrectSolution won't make a solution worse 1 // TODO: use memory stream pool here. 2 // TODO: Implement if needed - Writing as necessary and then calling GetBuffer should cover a lot of cases 1 #if defined(_DEBUG_IMPL) && !defined(JIT_BUILD) && !defined(JIT64_BUILD) && !defined(CROSS_COMPILE) && !defined(_TARGET_ARM_) // @ARMTODO: no contracts for speed 1 // TODO: Unit tests for this 1 _CRTIMP_TODO extern FILE _iob[]; 1 // TODO: add dropped item callback to handle dropped enqueued messages? To send back Nacks perhaps? Not essential but courteous .. 1 // TODO: refactor to SendFederationFaultMethod 1 // TODO: 2 // TODO: Wait for some time so that the unreliable transport behavior can be read from the files. 3 // TODO: Overflow handling. Reboot scenario handling 1 // TODO: Send successor and predecessor nodes seperately for now to simplify the code, use the same header collection later 1 KNodeList _GateList; // TODO: move these 1 // TODO: rethink need and safety of no lock in send situation 1 //TODO: serviceTypeId is required as a part of End as caller is not aware about the type of operation 1 std::wstring logDirectory = L"/mnt/logs"; // TODO read this value from the cluster manifest 1 // TODO: cleanup 1 // TODO: Consider adding SF_STATUS_BACKUP_OR_RESTORE_IN_PROGRESS 1 // TODO: Should add some retry logic on unmap failure 1 # define CHK_HR( expr ) for ( int __hr = expr; FAILED(__hr); ) THROW_SYSTEM_ERROR( microsoft::MakeWindowsErrorCode( __hr ), #expr ) //TODO: Create its own error category? 1 //// TODO: Add test for this class. RDBUG # 3290604 1 // TODO: build up the path properly instead of hardcoding it 1 // TODO: When we make Replicable name to be IComparable, we can remove the ToString call from here. 1 // TODO: this is going through transport stack delete callback, and all the way to the service completing the Begin/End async 1 /// TODO: Likley not needed. Will simply expose a task that can be awaited till done. 1 // TODO: Can return error 1 // TODO: Remove COPY 2 ULONG32 CopyProtocolVersion = 2; // TODO: make constant 1 // TODO IDisposable? 1 // TODO: Should we throw an exception here if the registration fails? 1 //TODO: fix size. 1 // TODO: might need to get additional info to lookup incase of auth failures/challenges 2 // TODO: Remove STL later 1 // TODO: check if Transport tolerates empty buffers--do we even want to allow those? 1 // TODO: array based method to get list of values 1 protected: // TODO: Are all these below need to be protected?? 1 // TODO: if the key is an unknown type should be invalif arg 1 //TODO: Reading the description extensions from the xml is pending 2 /// TODO: Why not make this a overloaded constructor, or precreate one that they can use right away. 1 // TODO: Determine whether this is actually needed 1 //TODO: we can continue and see if file is mapped by any other dev file. 1 // TODO: we may need to periodically flush messages that come in as retries and have sequence numbers below NextSequenceNumberToDelete 1 // TODO: The creation of propertyNameIdex can be cached in the creator since it will done only 1 Time for each Type during a Run. 1 // TODO Think through this Reset and passing of stop options. 1 RemoteLeasingApplicationIdentifier; //TODO value is unused 1 // TODO: Add Support for prefix matching. 1 // TODO: Consider isPrimaryTransaction only when the first AddOperation is called. 1 return(BaseSize / 4); // TODO: we need to make this more intelligent 1 m_previousTokenType == JsonTokenType_BeginArray || // TODO: This case is actually caught by the InObject check. Remove? 1 // TODO: verify startingEpoch & startingLsn is not invalid 1 // TODO: Come up with a better reuse approach; unseal/reuse if sizeOfUserDataSealed == 0 1 // TODO: This can be removed but being kept for compatibility 1 SERIALIZABLE_PROPERTY(Constants::TimeToLiveInMs, timeToLive_)// TODO Update publicapi 1 // TODO consider retrying the fetch/reconcile/execute block, to avoid 1 // TODO: if files are large, read line by line 1 // TODO: In the future this can be an assert 1 // TODO: improve password generation by using a secret 1 // TODO: Once FabricTest has been modified to generate InfrastructureManifest.xml file, we should not 1 // TODO: Do I want this ?? Or retry ??? 1 // TODO: deal with exceptions 2 // TODO: these can be const & but this must start in comm object 1 // TODO: Work out Reuse() for read approach 1 error = ErrorCodeValue::InvalidCredentials; // TODO: bharatn: create new error code InvalidClaims 1 // TODO what kind of exception should this be? Should we wrap it in something? 1 // TODO - The value returned is not accurate 1 // TODO: Create by using System.Guid.NewGuid().ToString() and save to globle reliable map to handle the failover case from Node1 to Node2 1 // TODO: implementation of iterator pattern? 1 // TODO - Following code will be removed once fully transitioned to structured traces in Linux 2 // @TODO - NYI. Need to decide if store is implementing ClearAll. 1 ret = std::remove(_PathToFile.c_str()); // TODO: Remove STL usage 1 // TODO clean/scrub this map periodically 1 // TODO: Check against key filter 1 // TODO: Implement reverse logic of truncatehead 1 std::set routedMessageProcessingSet_; // TODO: refactor into a common threadsafe set 1 // TODO: consider using the following to avoid copying when replicated store supports it 1 TODO: Replace Deactivate message with the force flag with ClientReportFault 1 // TODO: Currently we give send and receive timeouts as remaining time. This 1 3 // TODO: This should be moved to servicemodel\ 1 // TODO asnegi: RDBug #10278280 Adding 0xc0190021 as it is expected HResult for exception. However, it seems that it is not being 1 //TODO: Use these when transport is ready 1 // TODO: do we need a DeleteOutboundSession API? Will that close automatically? Perhaps at the managed level .. 1 // TODO IsRetryable? 1 // TODO: look at sequence number management end-to-end including what happens to Open and Close messages 1 TODO: consider separating the state checks from the state transitions and doing the former in a safe method. 1 // TODO: drop all in the same batch 1 { "OS.Wipe", ImpactCategory.DataDestructive }, // TODO: Review new impact 1 // @ARMTODO: Disable for ARM for now, contracts slow down the debug build far too much 1 // TODO: Check if we need to throw instead, as this replica 1 // TODO: make sure the message is always deleted when consumed and will not reappear 1 auto read = BIO_read(outBio_, output.pvBuffer, output.cbBuffer);//LINUXTODO avoid memory copy 1 // TODO: Call FreeHGlobal when done with this native string 1 // @TODO: put this in the CORINFO_EE_INFO data structure 1 // * TODO: Optimization: Old code established FileOptions.SequentialScan 1 // TODO: look at whether this would ever happen 1 // TODO: Do not lock the FailoverUnit 1 // TODO: Make volumesMetadata single file instead of multi files 1 /// TODO: refactor to combine the two methods 2 //TODO shuxu check this to see if it is needed 1 // TODO - create a separate method for this to indicate signal 1 // TODO: add fields over here. For now keeping empty 1 // TODO: make sure hash table structure has a const Find key parameter (unlike KAvlTree) so we can drop this extra assignment 2 // TODO: Bug#9728016 - Disable the bind until windows supports mounting file onto container 1 // TODO: Make it generic for ipv6 in the future? 1 //LINUXTODO consider moving the following two APIs to pal_missing.cpp 1 throw new Exception("TODO ::: Analysis is already Running. Please Call Stop and then start"); 1 w.Write("TODO {"); 1 // TODO replace with a structured event 5 // TODO: Refactor this so that it is a little cleaner 1 // TODO: figure out why passing in quotes in the arg is causing failure in Linux. We need to support spaces in paths 1 //TODO: Remove above conditional code block as this logic should work for both FullFx and CoreCLR. 1 // TODO: this only applies when DynamicTopologyUpdateMode == None or OnNodeConfigurationOnly. 1 //TODO shuxu check 1 ASSERT_IFNOT(recordSPtr.RawPtr() == keyFoundInPendingTxPair.RawPtr(), "Invalid log record"); // TODO: Verify validity of this assert 1 //TODO: Struct is same as EnvironmentVariablesDescription. Create a base and inherit from it. 1 // TODO: ResolveServicePartitionAsync seems to throw TimeoutException in unexpected ways: investigate and fix this, leaving out the timeout param for now 1 // @TODO: Fix this by adding an abstract function Hash() which must be implemented 1 // TODO: handle exceptions 1 // TODO: This should return the merged file once we support it. 2 // TODO: Make the ut context the root of the RA 1 // TODO: are we doing proper/sufficient cleanup on failed Create in general? 1 // TODO: verify deploymentName 1 // TODO: currently we just abort all outbound sessions, need a more nuanced shutdown semantic if sessions are used standalone, i.e., not via streams 1 // TODO: Check with failover team to see how to confirm that the replica actually restarted. We do not expose instance id for persisted replicas 1 // TODO preethas : Remove transaction id or add transaction id to acquire API it is not in sync with the acquire API 1 // TODO: Need to deal with stream states other than Open on restart 1 // TODO check why it is nullptr. 1 return; // LINUXTODO implement CRL recheck and remove PurgeExpired_LockHeld 1 // TODO: 1 // TODO: inline? 1 // TODO: Not supported by V2 stack 1 /// TODO: Switch with NodeEntity 1 // TODO: if paging status not null, should ask for next page 1 // TODO: make a simple KQueue of these session-specific DequeueOperations for reuse 1 // TODO: 4240470: pass in correct baseline and upgrade domain list 1 // TODO: Figure out exactly how the read backward should work 1 //TODO - waa 1 // TODO replace with a structured event 2 // TODO: No messaging resources active, should we shut down and delete the transport? For now, no, it doesn't save much 1 hr = JSON_E_UNEXPECTED_TOKEN; // TODO: More specific error code? 2 //***BUG: richhas, xxxxxx, TODO: Add: get all names AND values 1 // TODO what kind of exception should this be? 1 refCount = referenceCount_; // TODO: volatile read? 1 * TODO: currently AP safe config deployment is not supported to update configurations. 2 // TODO: reconsider this assert: this can happen in a race between session manager abort and a regular session close process 1 // TODO - Consider that folders are not ordered by events timestamps 1 /// TODO: implement copy flags: 1 /// TODO: Verify supported versions 1 // TODO: directly return ViolationList from CorrectSolution? 1 TODO: Talk about initializing strutures before use 1 TODO: Add configuration to give all or at most one notification during undo per key. 1 /// TODO - move common constants to a common class. 1 /// Windows traces for now.. TODO Handle Linux 1 // TODO: This assumes that sweep only applies to SPtr 1 // TODO: Should we enumerate based on codePackageResult? The mismatch could happen if service is upgrading and node view vs. CM view is different. 1 // TODO: Report Health. 2 // TODO: LastReceiveSequenceNumber fix needed 1 // TODO: need simple exception handling structure/pattern 1 // TODO: Not implementing timeout - waiting for timer solution. 1 // TODO: To be made private 1 //TODO: Implement Smarter Logic Here Eventually -- Such as if the cluster is under FabricUpgrade 1 // TODO: Remove after race condition is addressed 1 //TODO: what if sendMessage is null? 1 backupPartitionStatus.OperationId.Equals(operationResult.OperationId)) // TODO : Also check for Guid for the request 1 // TODO: Temporary name, Reconcile with ConcurrentDictionary post Ignite 1 // TODO: do we support null messages, e.g., for pinging purposes? 1 // TODO: this is where we would take back an outbound stream if the transaction aborted 1 //TODO: what is the purpose of these? 1 if (rwtxSPtr->ReadIsolationLevel == StoreTransactionReadIsolationLevel::Enum::Snapshot) // TODO: Also check for ReadCommittedSnapshot 1 // TODO: Consider having the LongByteConverter as static. 1 //TODO: possible to always transfer one token only? 1 // TODO: Improve. 1 // TODO: This is temporary, as PutCustomProperty will be available in PutProperty in the future (there was a mistake in defining the API) Defect: 1168753 1 // TODO fix https://bugzilla.redhat.com/show_bug.cgi?id=1476120 1 // TODO #10279752: Separate redo out of ReplicationMetadata. Making 1 // TODO: if failed return some error 1 // TODO: Add a unit test case where a huge records array is returned 1 // TODO: consider assert instead of an error message 1 // TODO: don't be so recursive 2 // TODO Refactor prepare/restore async ops to be polymorphic based on impact type 2 // TODO: This logic should be changed to use asyncoperation multiroot 5 ///TODO: temporary code.remove 1 // TODO: what happens if there is a session Abort? Or a failure of the partner? 1 // TODO: Windows behavior should change to match this once hosting changes are made to make this consistent 1 // TODO: Better Manage Scrub Task 1 // UTF-8 to UTF-16 Conversion. TODO: wchar_t seems still 4-bytes in to_bytes() 2 //TODO shuxu 6 // LINUXTODO: consider removing registry usage 1 // TODO: Come up with a better reuse approach; unseal/reuse if sizeOfUserDataSealed == 0 1 // TODO: Do Atomically. 1 [SuppressMessage(FxCop.Category.StyleCopMaintainability, FxCop.Rule.FileMayOnlyContainASingleClass, Justification = "TODO:huich - Need to fix.")] 1 // TODO [dragosav]: look into aligning the type of the variable/setting type - env vars 1 // TODO: consistency. in passing Uri or name from client - it should be either name or uri. 1 // TODO: check application attributes 1 /// TODO: We could use GCHandle and StructureToPtr to do copy free serialization and de-serialization. 2 // TODO Enable the assert below once item 5861402 is fixed. 1 // TODO: Is this correct to use std::remove ? Why not remove() 1 // TODO: KTL doesnt support sending a null buffer with just the flag. Check and fix it. 1 // TODO: track and clear cancellation token registration? 1 // TODO: consider cleaning the thread if we are going to use it more -which we are now; 1 // TODO: take description class after compose structure is updated 1 // TODO: Payload buffer allocation here is being done again even though the 1 // TODO: Should there be a status code and description to identify any errors 2 // TODO: Copy shld be removed 1 ServiceModelEventSource::Trace->ReplicatorSettingsError(errorMessage); // TODO: Add TRSettingsError Trace 1 // TODO: Trace. 1 // TODO: system app policy should be read from config instead 1 //TODO Find a better place for this ... 1 //TODO: add assert for starttime + phasestarttime 1 // TODO: Merge these fields into one 1 // TODO: We could avoid the copy in the future 1 // TODO: This check is safe since Failover gurantee's that a primary will never cancel the build and restart it without either the idle restarting or primary itself restarting 1 // this start again. TODO: Think of better of supporting this scenario. 1 // TODO: Create a specialized trace 1 // TODO : Improve this Logic. 1 // TODO: On Autopilot, endpoint set is not part of service model so would not be modeled as part of topology. 1 // TODO: Make sure the continuation token fits 1 //LINUXTODO handle LT_FRAMETYPE_CONNECT within transport 1 // TODO: make this private 1 // TODO: reconsider this assert: this can happen in a race between session manager abort and an incoming session open request 1 return ResultStatus.InProgress; // TODO: Should we create an Unknown/Invalid status? 2 // TODO: Figure out the right place to send all of this output. Is 1 // TODO: This needs to be put on the Dac side. 1 // TODO: Set the query iD 1 StringConstants.WorkingDir, // TODO: Revisit to see if this is needed. 1 // TODO: 134637: consider whether NULL operations 1 // TODO consider cancelling restoring health check, if necessary 1 TimeSpan::FromMinutes(2), // TODO: Should be a configurable time, so we can retry incase IB is stuck. 1 // TODO: Remove the hardcoding from here and make this piece generic for services to register a entity and forward all URLs under the same to them. 1 // TODO: Revisit this to make it dynamic. 1 // TODO: What else can we do if we can't post ?? 1 // TODO: Create directories based on partition and replica ID 2 //TODO: add nameformat 1 // TODO: account for key metadata correctly. 1 // TODO: Dump the rest of the data. 1 // TODO: reference any additional headers you need in STDAFX.H 4 0, // TODO: Will this overwrite existing allocation 1 // TODO: fix callback - many of the fields are broken out of the 1 #include ///TODO: move to Common/Types.h 1 // TODO - check if this URI is correct 1 // TODO: Use encoding to convert from byte to char 1 nullptr, // TODO: healthClient 1 // TODO: make _MaxBytesPaddingWhenUnderPressure a config 1 // TODO: Use TTL; left as an example 1 // TODO: Refactor - updating remote replica state should be intelligent enough to not require the function below 1 // TODO: should we keep track of source service partition Address() from ISendTarget provided by transport 1 // TODO: How to handle errors ? 1 // TODO : Do dispatching in Batches over a separate Task 1 // TODO: Wait for some time so that the removal of this unreliable transport behavior can be read from the files. 1 /// TODO: Verify support type ex. 1 // TODO: Arbitration Support Methods not implemented. 1 // TODO: no other recourse here? Report fault? 1 // TODO: Will have to check on Linux if this needs an ifdef. 1 // TODO: Merge with the RA state and send an updated DoReconfig message 1 _CRTIMP_TODO size_t __cdecl fwrite(const void *, size_t, size_t, FILE *); 1 // TODO: there seems to be no clear way to report the actual failure here as an NTSTATUS 1 // TODO: Fix RA to use QueryMessageHandler, rather than directly parsing the query, 1 TODO: The medata should also come from the code that invokes the API 1 Status = _File->Transfer(KBlockFile::IoPriority::eForeground, // TODO: Allow bg writes too 2 public: // TODO const 1 // TODO: add compare to Common::Guid to avoid Guid copying here 1 // TODO: implement Http transport message 1 /// TODO: Add more details like Time Taken, Traces Lost etc. 1 // TODO: evaluate whether we should have an explicit callback to Dispose, or if we should copy to HGLOBAL? 1 // TODO: use FormatMessage to convert NTSTATUS to string 1 // TODO: Add StartTelemetryTaskAsync here. 1 //BUG: richhas, xxxxxx, TODO: Add support for: Get all attr names AND values 1 // TODO: See if this can be removed by allowing health policy updates via UpdateRepairExecutionStateAsync 1 // TODO: Remove sequence number logic above and use the new out param 1 // TODO: 132314: Infrastructure: need to add ref_ptr 1 //TODO: add validation for all configurations 1 // TODO: Dump results to XML ?? 1 { "OS.Initialize", ImpactCategory.NoImpact }, // TODO: Review new impact 1 // TODO: handle other Federation faults 1 // TODO: remove this, don't think it is needed 1 // TODO: If disconnect_ is specified in this case, return error. 1 // TODO: Apply Silo Context to the workitem that will run under System process context. 1 // TODO: account for key metadata correctly. 1 // TODO: Consistency: Make the name to uri translation happen only on the server side. Client side should be passing the name without fabric: 1 // TODO copying to a storage first involves a double copy 1 //TODO: Remove this check after Bug :1225032 gets resolved 4 // TODO: Potential optimization: 1 // TODO cancellation token (if there are many folders and a lot of data) 1 key.resize(256/8); // LINUXTODO determize key size based on encryption algorithm 1 //TODO: This will be changed to the async write after the COM::File is updated to support append mode at item #7564216 1 // TODO: Check for ReadCommittedSnapshot level and no locking hints 1 // TODO: Persist 1 // MCoskun TODO: This can be turned into Test Assert. 1 // TODO: Log this 1 // TODO: We should have a retry count and fail if that is crossed. 1 // TODO: Revisit after we enable multiple Ktl systems 1 /// TODO:: Fix Suspended??? 1 // TODO: Verify HTTP/1.0 or 1.1. 1 // TODO [dragosav]: look into renaming the EnvVarTypeType to something more generic, 1 // @TODO: it's not clear that we actually *want* any operator overloading here. It's in here primarily 1 // JBTODO: remove. This is temporary. 1 // TODO: this should return something other than InvalidArg, so the calling query can give users a more useful error (ie. increase max message size) 1 // LINUXTODO consider replacing SSLv23_method with TLS_method after upgrading to openssl 1.1 or newer, to avoid confusion. 1 // TODO: list of objects/URI that are handled 1 // TODO: abort all other requests 2 // TODO: update after finalize the upgrade domain issues. 1 // TODO: Add Move constructor 1 // TODO: do we support empty messages? 1 // TODO move nodeid to common. 2 // TODO: we are truly out of resources, notify Fabric -- asserting for now 1 //TODO generic key types 1 Transport::MessageUPtr reply_; // TODO: This should be private 1 // TODO: Configure test to actually run 200 tasks concurrently. Currently ~12 run together 1 // TODO: In 'develop' branch, FM used to have its own wrapper implementing 1 // TODO:Verify.AreEqual(expect.Override, actual.override); 1 /* TODO: prior code to be deleted 1 // TODO: If SiteNode must do any other processing on these events consider making a general method to move ProcessRoutedMessageHoldingList to 1 // TODO: Rethink 1 { //TODO: print all the LUID, not only lower part. 1 // TODO: ReliableSessionManagerAlreadyListening must not happen; Assert? 1 // TODO: Remove these 2 fields before release after running enough coverage tests to assert this 1 // TODO: there is something wrong with USE_INDIRECT_CODEHEADER with CODE_ALIGN=16 1 // TODO: REMOVE AFTER DEBUGGING 2 // TODO prefer tasks with jobKeyMatch? 1 // TODO get the description with the status. 1 cabPath = Path.Combine(FabricEnvironment.GetDataRoot(), System.Fabric.FabricDeployer.Constants.FileNames.BaselineCab); // TODO: Needs to come from image store 1 // TODO: use constraint to implement swap-only? 1 // TODO: handle exceptions 1 //TODO: SetSecurity for entreeservice proxy and httpgateway 1 // TODO: not handling incorrect format yet 1 // TODO: Check this later. 1 // TODO: Consider if these really need to be returned 1 // TODO: Provide a way to clear all behaviors just in case. 1 // TODO: Ensure that the requests dont come in before we do the necessary initializations which are being done below 1 // @TODO - This should inherit from StoreTestBase 1 // TODO: re-implement to avoid resize here and end which need to modify function 1 // TODO: Log this. 1 // TODO: remove when making DCA validator change 4 // TODO: Add api to enable this dynamically 1 // TODO: For now fire any truncation needed events, in the future we 1 // TODO - Should be removed after complete migration to structured events 1 // TODO: When CreateLocalReplica is properly refactored this can be made private 1 // TODO: Optimize query to fetch FM data only 1 // TODO: remove this when we remove m_cursor from the HENUMInternal structure 1 //TODO: add code to slowdown requests to FM 1 PREFIX_ASSUME (section!=NULL); //TODO: actually it is possible that it si null we need to rethink how we handle this cases and do better there 1 /// TODO: Check if ToString() can suffice for this need. 1 LPCSTR algorithmOid, // algorithmOid is ignored. //LINUXTODO implement other algorithms. 1 // TODO: Once we support custom state providers, add retry for failed state providers. 1 // TODO: The raw buffer may not always be multiplexed. 1 /// TODO: the exceptions here need to be Asserts? 1 #if !defined(PLATFORM_UNIX) // TODO: Port this code 1 // TODO: logging. 1 // TODO: Demote to noise after testing 1 // TODO: Actual TTL; left here as an example 1 // TODO different values for destructive and non-destructive 1 // TODO: Following 4 APIs should be move to CorHost for V1. 1 return ErrorCodeValue::NotImplemented; // LINUXTODO implement create cert from key. 1 //*** TODO: 1 // TODO: If we need round-trip conversion, we may have to provide our own HRESULT_FROM_NT 1 //TODO: When implementing certificates, also implement these methods correctly 1 // TODO: Evaluate what other CDB commands need to be supported and go over the following implementations. 1 // TODO: Coarse lock - improve. 2 // TODO success but null address 1 // TODO: Windows behavior and behavior for process isolation should change to match this once hosting changes are made to make this consistent 1 // TODO: Consider remove validation for speed. Commiting all the contexts in one transaction would fail in the end anyway. 1 // TODO: Structured Tracing. Trace TransactionalReplicator.ApiError@, t.Exception.InnerException. 1 //TODO change the timeout from magic number to FederationConfig constant. 1 // TODO: REMOVE WHEN DEBUGGED 3 // TODO: Do not use a dedicated thread but instead use async 2 // TODO #10279752: Separate redo out of ReplicationMetadata. Making 1 // TODO: check and filter error 1 // TODO: Validate range 1 // TODO: Used by HM 1 // TODO: wrap in a child async 1 #if !defined(PLATFORM_UNIX) // TODO: Determine size of memory 1 return ErrorCodeValue::NotImplemented; // LINUXTODO implement create cert from key. 2 TimeSpan::FromMinutes(2), // TODO: This should be a configurable timeout within max val. 1 // TODO: Clean way to add query header 1 // TODO: Remove STL usage 4 // TODO: Read and merge the compose file and overrides file. 1 // TODO: the behavior of ResolveServicePartitionAsync is unclear as far as timeout goes, this code needs fixing 1 // TODO: do we need to AddRef/ReleaseRef on metadataTable for background consolidation? 1 // TODO: Remove this when I feel good about the math 2 // TODO: Temporarily internal for testing purposes. Should be made private. 1 // TODO: optimize by not sending if they are already in the exponential list 1 //TODO shuxu 1 //LINUXTODO consider avoid copying 1 // TODO: What else can we do ? 1 // TODO: Improve code sharing in the code below after sweep algorithm is done. 1 // TODO: who is responsible for keeping this alive? Always release? 1 //@TODO: Would be good to add runtime validation that the return value is used. 1 // TODO: we are keeping receiveOp in the DequeueOperation to keep it alive--need to revisit lifetime management interaction via COM refcounting 1 // TODO: no other recourse here? Report fault? 1 static const ULONG _MinimumFirstReadCompleteSize = ((128 * 1024) - 0x110); // TODO: Pick a number 1 // TODO: Conisdier optimization: 1 // LINUXTODO investigate how/when to delete the file 1 // TODO: Add tracing here. 2 // TODO: Figure out the right sizes 1 // TODO: hotCodeSize should be encoded in GC info 1 // TODO: Change to syscall instead of process create for better diagnostics. 1 // TODO: this is an opportunity to release the closeOp if we want to recycle it 1 // TODO: Refactor - this should be moved out of this file 1 // TODO: 3 // TODO: This logic needs to be moved out of here 1 // TODO: reply with a suitable fault message 1 // TODO validate task params 4 // TODO allow config overrides 1 /// TODO: resolve this with BlockAlignedWriter.DefaultBlockAlignmentSize; 1 // TODO: this case happens when the proxy is not known or has just been disconnected, 1 // TODO: list of objects/URI that are handled 1 // TODO: Temporarily reverse ordering in feature_data2 branch for density testing 1 // TODO: Lock-free enumeration 1 // TODO error code 1 // TODO: Not sure what to do here 1 /// TODO: Persist time the Object was first created. That will be insight start time. 1 // TODO: Make this sync when service Abort support is added 1 /// TODO Update SFE code. 1 // TODO: cleanup reinterpret_cast mess 1 // TODO: correcting constraints based on static constraints 1 // TODO: call GetTargetNodeForUnplacedReplica directly for each constraint 2 KSharedPtr CreateMockReplicator(FABRIC_REPLICA_ROLE role) //TODO: IStatefulServicePartition& partition 1 // TODO additional info in executordata 1 // TODO: would codepackage versions be different than manifest version? 1 // TODO: Move inside the loop to get checkpoint file for specific i 1 queryParameters[RestPathBuilder.StartDateTimeFilter] = startDateTimeFilter.ToString(); // TODO: Verify if this format is correct 1 // TODO: Use a common action queue in the entity executor async operation 1 // TODO cancel task if its action/target is bad 1 // TODO: this is an opportunity to release the openOp if we want to recycle it 1 // TODO: revisit inbound session cleanup, some tricky race conditions including multiple colliding protocol responses when session not found during CloseRequest retry 1 // TODO: this can be optimized by ra remembering the delete intent 1 ApplicationHostIsolationContext const & isolationContext, // TODO: This should not be needed. 1 // TODO - remove after transition to structured traces is complete 1 // TODO: When we make Replicable name to be IComparable, we can remove the ToString call from here. 1 { "ApplicationConfig.Wipe", ImpactCategory.DataDestructive }, // TODO: Review new impact 1 // TODO: Can deletions end up in a failed state? 1 V2Application = 2 // TODO: Finalize names 1 // TODO: Checks for bad retry timeouts such as MaxValue 1 // TODO: Use FabricReplicaRole enum 1 // TODO: Reenable when Raymond is ready 1 // TODO: need to come up with a better implementation(base class) to do this transparently 1 //LINUXTODO use SSL_get_verify_result to avoid duplicate chain validation 1 // TODO: Change from Common::ComPointer IStatelessServicePartitionHolder 1 // TODO: handle allocation failure 1 //include child partitions that are not in node1 or node2, TODO: consider replica on node1 or node2 for loadChange calculation 1 // TODO: Consider creating a buffer pool for performance 2 // TODO: Merge the next 3 fields into one. 1 // TODO: define a size validation for encrypted passwords 1 // TODO: Get own structured trace. 2 // TODO: NLS Arrowhead -This isn't really right, custom locales could start with en- and have different sort behavior 1 // TODO: Investigate why UTF16 is causing crashes and then switch to it 3 // TODO: Dump headers within metadata 1 //TODO: clean all operations in same batch 1 totalLoadOverCapacity += load - capacity; // TODO: check overflow 1 // TODO: Temporary assert should be removed later 1 // 3. TODO: need to handle Connection header, TE: with trailers. 1 // TODO: Const correctness. 1 // TODO: Consider: Should operationContext be const? 1 // TODO: make private when When UC handling is refactored 1 // TODO: Remove this validation when we support 'dynamic' services under application. 1 // @TODO - There is no way to tell client that we can't send the notification - need to log 2 // TODO: This can be made common code. 2 // TODO: Today TStore only supports exclusive lock for operations that are ReadOrWrite. 2 //LINUXTODO check if offset is needed 1 // TODO: Add the error message to status description. 1 // TODO linux only logic, the real ttl is returned and out put to a 1 // TODO: Used by Naming service 1 { "Compute.Wipe", ImpactCategory.DataDestructive }, // TODO: Review new impact 1 // @TODO - Merge these two calls into one call 1 // TODO: Windows behavior should change to match this once hosting changes are made to make this consistent 2 /// TODO:Check if there is enough room in the stream 1 KSharedPtr CreateMockReplicator(__in FABRIC_REPLICA_ROLE role, __in bool hasPersistedState) //TODO: IStatefulServicePartition& partition 1 // TODO: we seem to be completely out of resources -- need to signal fault -- assert for now 1 //LINUXTODO consider use UnreliabableTransport 1 // TODO: use streams instead of reading bytes, 1 0, /*TODO: remove, not used*/ 1 // TODO: Trace. 1 // TODO validate params 1 // TODO: Move this as a property of the name? 1 // TODO: make this a property?? 1 // TODO: revisit Uri equality -- may not be compatible with the unmanaged definition 1 //TODO: Wait for pending requests to complete 1 //TODO: Delete the registed application. Might never be done. 1 // TODO: This functionality should be added to the KTL layer 1 // TODO Chrissie: When the seed node removal causing the intermediate seed node shift bug is fixed, remove this parameter from add node scenario. 1 { "Network.Initialize", ImpactCategory.NoImpact }, // TODO: Review new impact 1 // TODO: Consider Asserting if these fail. 1 // TODO: do we need to look more closely into these exceptions? 1 // TODO: Clean up these multiple Ifs. 1 // TODO: look closely at lifecycle management os sessions and session managers 2 // TODO: make these actions which store state locally as well. 3 if (currentRestoreStatus.RestoreStatusState == RestoreState.Accepted) //TODO Check for Guid 1 // TODO: check application attributes 1 // TODO: Anurag: do we plumb c.token up? 1 // TODO: Remove when update network is implemented 1 // TODO: include all parameters for the run 3 KArray<_CallbackInfo> completionCallbacks_; // TODO: use a delegate 1 // TODO: Certain Optimization can be done at this level maybe? For example, can we not query and just use a cached value for a certain amount of time? 1 // TODO: Check if these strings are ok and consistent with the other places we ask for partitionkind 1 // TODO: This is an workaround for bug 8874388: SimpleClusterUpgradeState shouldn't reselect seednode. It should use the exisiting ones. 2 //TODO: Either make this an instance method or ensure that the working directory is passed in to use 1 // TODO: should this be configurable? Make sure receive operation quota is larger than this 1 // TODO - Following code will be removed once fully transitioned to structured traces in Linux 4 // ReplicatorTransaction->ThrowIfTransactionManagerIsNull(); 1 /*TODO - 935703 - WaitForReplicationQueueToDrain(thisSPtr);*/ 1 // TODO: Currently we give send and receive timeouts as remaining time. This 1 // TODO: RA does not process this yet 1 return ErrorCodeValue::Success; //LINUXTODO ??? 1 // TODO: is _FileSize correct ??? Does it matter ?? 1 // TODO: should also include Error 1 /// TODO: 2. The current implementation supports source and target partners to be located in the same ring. We need to support Xrings. 1 // TODO: this is going through transport stack delete callback, and all the way to the service completing the Begin/End async 1 // TODO: Ctrl+C handler is not supported on CoreCLR Linux. Need to work to find alternate. 1 // TODO: Make sure this is safe. 1 // TODO: more fields 2 // TODO: currently we just abort all inbound sessions, need a more nuanced shutdown semantic if sessions are used standalone, i.e., not via streams 1 // TODO: Wait for some time so that the removal of this unreliable transport behavior can be read from the files. 2 // TODO: Handle BRS not reachable 1 // TODO: SetResult can hijack the thread to execute the continuation, so make sure that happens on a different thread 2 return STATUS_INTERNAL_ERROR; // TODO: Map to NTStatus 1 // TODO: We should make the SF_STATUS_ONDATALOSS_NOT_INFLIGHT. 1 // TODO: handle accounting for open network as well 1 // TODO: pass time to extract method. 1 DateTime::Zero, // TODO: last modified 2 // TODO: do we need to handle the case that we just created the singletonEnvironment_ and should shut it down? 1 { "Compute.Initialize", ImpactCategory.NoImpact }, // TODO: Review new impact 1 // TODO: add node failure reason 1 //LINUXTODO avoid data copying during encryption 2 // TODO: update the isSingleton_ here when we have the dynamic partitioning 1 // TODO - Following code will be removed once fully transitioned to structured traces in Linux 24 // TODO: verify other load metrics should not have the same name with it 1 bool IsCurrentStateValidForRestart(uint64 & currState) // TODO: Should we include Analyzing state as valid state. 1 FolderPath = String.Empty, // TODO: This should be constructed 2 // TODO add trace 1 // TODO: handle remaining client settings parameters 1 // TODO: look at this nolock option again later right now it seems dangerous 1 // TODO: dump rest of record 1 // TODO: when kernel supports coroutines, actually implement this 1 // TODO: Create these lazily rather than creating upfront 1 // TODO avoid extra copy here 1 // TODO - Following code will be removed once fully transitioned to structured traces in Linux 1 // GopalK, TODO: Preetha, should not we be disposing statemanager here? 1 // TODO: make httpgateway a rooted component. 1 // // TODO: We only require two variables. 1 // TODO: Add mopre validation to make sure our rollout version compute logic 1 // TODO: Refer to #1282639, this will be updated once we have a way to query Fabric Host about whether hosted application/services are actually ready. 1 Common::RwLock lock_; // TODO rename 1 // TODO: MultipleCloseSessionAcksReceived needs to be changed to CloseSessionAckDropped 1 // TODO: Allow logical log IoBuffer for metadata to be used 1 /// An ETW file Reader. TODO Stop using ETL reader, we don't need it. 1 // @TODO - Implement "Read your own write" by inspecting WriteSet 1 // TODO: Enable this later 2 // TODO: track when this is disposed for asserts 1 // TODO: Bug#9728016 - Disable the bind until windows supports mounting file onto container 3 // TODO: move to a more general location, as this is not http-specific 1 Common::TimeSpan::FromMilliseconds(256 * 1000), // TODO: make constant 1 // TODO: Review these (and any additional SRBs that need to be supported) 1 // TODO: when adding dynamic topology support, change state machine transition here. 1 // TODO: is this always accessed under waiterSync? If so make it a simple dictionary; also consolidate access code in a class 1 // @TODO - Better error checking by returning error back to managed in CExportTests 1 //TODO::Reversible Tracing/Writeto:#1955390 1 // TODO: Make Noise trace 1 // TODO: Fix CRCs 1 _CRTIMP_TODO int __cdecl fclose(FILE *); 1 TODO: When the move to async is complete this will not be a problem 1 //TODO shuxu 1 #if 0 // TODO: Remove 1 // TODO: Break report fault analysis into two separate analyses because ReplicaStateChange already shows which one of the two happened 1 // TODO: Remove Copy 1 X509_VERIFY_PARAM_set_flags(param, X509_V_FLAG_CRL_CHECK); //LINUXTODO consider support X509_V_FLAG_CRL_CHECK_ALL? 1 // TODO: Unify with pCurrentContext / pCallerContext used on 64-bit 1 //DENY_COPY_ASSIGNMENT(MessageIdHeader); TODO: deny later 1 ///TODO:remove 1 // TODO: This should always use the names 1 // TODO: make these actions which store state locally as well. 1 /// TODO: this may throw FabricObjectClosedException 1 // TODO Add validation to http appgateway endpoint 1 m_previousTokenType == JsonTokenType_BeginObject || // TODO: This case is actually caught by the InArray check. Remove? 1 // TODO: Wait for some time so that the removal of this unreliable transport behavior can be read from the files. 2 // TODO: dispose managed state (managed objects). 2 // TODO: Think of something better to enforce this. 1 // TODO: revisit the timeout behavior of GetPropertyAsync to clarify and adjust accordingly 1 // TritonTODO: should this be inside ifdef? 1 { "ApplicationConfig.Reset", ImpactCategory.NoImpact }, // TODO: Review new impact - this is an actual config update 1 // TODO: Routine would be more easily written using memory 1 // TODO: Change this to a continuation 1 HRESULT GetCallingConv(ULONG* data) // @REVISIT_TODO: Calling convention is one byte, not four. 1 // TODO: Add following files in concurrent bag and run loop with scheduled number of threads to upload these in parallel. 1 // TODO: Optimize in TStore by distinguishing version mismatch and not found in ConditionalRemoveAsync() 1 // TODO: implement this 1 //codePackage->Abort(); // TODO: This should not be called. 1 // TODO: This should be traced as ServicePackgeAborted to differentiate from normal deactivation. 1 // * Look at the available config files (system, application, host and user). For details see TODO: 1 // TODO: Separate into .h and .c 2 // TODO: consider to put this into an action 1 // TODO: Once async, co_await CloseAsync 1 // TODO: Ask for the size to avoid expanding the memoryStream. 1 // TODO: Await records processor. 1 // TODO: Add a RestoreBatchSizeInKB into the configuration. 1 //TODO define custom value type 1 // TODO: Optimize with GetSequenceNumber API from v2 stack 1 // TODO validate as NamingUri also 1 // TODO: deal with overflow 2 // TODO: IEnumerator also needs a Reset() method 2 // TODO: Monitor onDataLossCallback duration 1 // TODO: We are currently hard-coding the mask values, but this is not ideal 1 // TODO: should we zero? 1 // TODO: Add support to enumerate timers too. 1 // TODO: Remove this when stabilized 1 // TODO - Investigate fix and return to Assert.Equal (RDBug 11404901) 1 // TODO: Grow locks array? 1 TODO: Optimize the above 1 writer.WriteAttributeString("Value", "ComputerName"); // TODO: COmputername 2 // TODO: #9165801 : Eliminate copy 2 by aligning the allocations. 1 // TODO: Wait for some time so that the unreliable transport behavior can be read from the files. 1 // TODO: Requires test. 1 // TODO: Is MemoryBarrier required? 2 /// TODO - the above comment may not be true. investigate. Service Fabric Explorer scenario shouldn't be broken. 1 // TODO leaking 1 // TODO: Workaround if coalescing is not enabled and old driver is checked in for the release 1 // TODO: Following tests fail because of negative size assert 1 // TODO: override a finalizer only if Dispose(bool disposing) above has code to free unmanaged resources. 2 // TODO: Asynchronous void CopyTo(T[] array, int index). 1 // TODO: Linux equivalent 1 // TODO: make constructors protected after unit test class can be made a friend (switched to TAEF) 1 // ARM64TODO: these were copied from AMD64, and need to be reviewed 1 /// TODO: 1. Move end point management to its own class 1 // TODO: Any way to prevent unintended instantiations? This is only designed to 2 /* TODO: do not write past buffer size */ 4 // TODO: Temporary double check. 1 TimeSpan::FromMinutes(2), // TODO: THis should be a configurable timeout within max val. 1 // TODO: make sure locking issues are avoided 1 // TODO: Implement 1 // TODO: when kernel supports coroutines, actually implement this 5 //TODO: #12372718: Add a new API to force download the package during predeployment on node 1 // TODO: Move this into a config or make it a percentage 1 // TODO: determine proper error codes to use in the assert statements 1 // TODO: Use a backup config for this flush size determination 1 TimeSpan::FromMinutes(2), // TODO: this should be a configurable timeout within max val. 1 // TODO: replace 32 with 1024. Workaround for Rich's bug 1 /// TODO: Remove duplication from application name function 1 // TODO: handle continuation token. if received, continue to get pages. 1 // TODO: tracing already in the PLBScheduler::RefreshAction, move the tracing to here 1 // TODO: Add support for operationContext verification 1 // TODO: Rather than use a timeout, use ppoll and have this get 2 // TODO: implement the version with only the release semantics 1 // TODO: trace 1 // TODO: This is a bug in DCA. It doesn't upload Critical information to the Tables today, so 1 // TODO: This method should be async once SM fixes the interface to call async dispose or close 1 // TODO: Since fabricclient constructed here no goes via tcp transport, this should be changed to use 1 //// TODO: We need to add domain information which will be published address 1 // TODO: Can we do this better? 1 // TODO: Make it configurable. 1 // TODO: Need to be more selective about use of LastServiceActivityReleased trace 1 /// TODO: 3. Security (certs management) 1 // TODO: If we reject a one way message we can potentially send some messages back about ring state 1 // TODO: Bug#9728016 - Disable the bind until windows supports mounting file onto container 2 // TODO: Should the load happen all the time? 1 // TODO: bump up the windows CODE_ALIGN to 16 and iron out any nibble map bugs that exist. 1 // TODO: dispose enumerator if it is empty 1 #if !defined(PLATFORM_UNIX) // TODO: Port this code 1 // TODO: rename to backup inflight 1 SetBAHeaders(*message, Transport::Actor::BA, action, activityId); // TODO: Using default BA here 2 // TODO: what is port is not specified?, private network should be treated same as open. 1 // TODO: Make this thread-safe 1 true, // TODO: should this be configurable? 1 alias, // TODO: Pass KString ?? 1 { "Network.Wipe", ImpactCategory.DataDestructive }, // TODO: Review new impact 1 // TODO return false here if strict matching is enabled 1 { "Disk.Initialize", ImpactCategory.NoImpact }, // TODO: Review new impact 1 // TODO: Preethas This is a workaround until state manager supports hierarchy. Once hierarchy is supported, 1 // TODO remove this 1 // TODO: 724168 - Native to Managed URI conversion needs context to determine URI kind 1 // TODO: Today we expect analysisConsumer to be very light weight. In future, we can potentially 1 // TODO: do we erase the singleton environment now if myEnvironment_ is the singleton? 1 // TODO: Review this. 5 // TODO: Demote to noise when Image Store Service stabilizes 1 //LINUXTODO consider using BIO_f_base64 2 // TODO: Temporary assert should be removed later 1 // TODO: Workaround until GetOrAdd Semantics is added from log api 1 // TODO: We are currently hard-coding the mask values, but this is not ideal 1 // TODO: Expose these fields later, once support for job sets is added, and AllowAction command is ready 1 // @TODO:: a-meicht 1 // TODO: More replica within 1 CGS/CG on the same node. 1 // TODO: What else can we do ? 1 // TODO: Convert this to Structured Tracing completely 1 // TODO: make configurable 1 // TODO: Implement this 1 // TODO: what do we do with invalid messages? For now, assert! 1 // TODO: (maburlik) Validate conforms to JSON config model 1 // TODO: pass timeout to CodePackageHost 1 // TODO: trace! 1 // TODO: convert to structured tracing and add the correct trace type 1 // TODO: this.StopCoordinatorAsync? 1 // TODO: REMOVE WHEN DEBUGGED 1 // TODO: Since there is not yet first class support for sockets in the 1 // TODO: Change this back to 8192 when the ktllogger daemon is 1 // TODO: locking weak ptr should be protected by a lock? 1 //TODO: Deal with scenario that UD failed in the middle 1 // TODO: guard state changes etc. 1 // TODO: what if this callback faults? catch it 1 // TODO: Remove this once the underlying infrastructure delivers the same capability 1 // TODO: Create an async operation for incoming requests 1 // TODO: Add validation for this config in FabricDeployer 1 // TODO: we should probably report fault here 1 // TODO: This should not be needed on every single UC message 1 [SuppressMessage(FxCop.Category.StyleCopMaintainability, FxCop.Rule.FileMayOnlyContainASingleClass, Justification = "TODO: move to seperate file")] 1 // TODO - Move the caching enabled Param to Config 1 // TODO: provide better error code 1 // TODO: Consider usefulness of these error codes 1 // TODO: Test against key filter 1 // TODO: We should have a statically allocated buffer that can be sent for failure cases. 1 // TODO: we could check to make sure the request is still in the context table before sending 1 // TODO: assert that built in metrics don't have a default load and validate this in API 1 char *Value; // @TODO - Use BufferHandle for batching 2 // TODO: ContinuationToken support 1 // TODO: this is also weird 1 // TODO: registry key not available yet 1 // TODO - Following code will be removed once fully transitioned to structured traces in Linux 20 // TODO : RDBug 11792270 1 // TODO: Currently this method is not called by anyone in the production code. 1 // TODO: we need a consistent policy for when to track and use responseTarget and when to ignore it 1 // TODO: #9000025: KHashTable needs to be const correct. 1 // TODO: Dispose enumerator if it is empty 1 // TODO: think through this situation -- just dropping the message right now -- consider sending a Nack 1 // @TODO - eventName isn't actually supported in linux. we need to find another way 1 // TODO: clear flegs on the existing replica 1 // TODO: This needs to be optimized for the copy notification case. 1 //TODO: 1 // TODO: We can be smart and cache the FD for the different disk 1 // TODO: I don't think we need all of these. 1 // TODO: this code needs to be factored and structured to amke it easy to bypass Transport for intra-process communication 1 // TODO: do we need these static methods? Should we just do the search here instead? 1 // TODO: Consider not return message since it is not used. 1 // TODO: When doing actual DMA, we do not need to fetch the kernel virtual address 1 my $description = "TODO: GET DETAILS AND ADD TO GenerateConfigurationsCSV.pl"; 2 // TODO: #11905876 Integrate querying SecretStoreService in Hosting 1 // TODO: stream not long enough, return error 1 // TODO: This can be optimized if KBuffer can be initialized with just the pointer 1 HttpConstants::MaxEntityBodySize) // TODO: This should be changed to settings.xml 1 // TODO: check on perf testing for this allocation 1 // TODO: 847196, support notifications for all partitions: 1 //TODO check this 1 // TODO: Replace with our implementation. 1 //TODO: Does kernel_sendmsg ever return 0? If yes, we may run into 1 // TODO: Replace with our implementation. 1 // TODO: Bug# 1136788 - Implement TransitionCallerHolds_Lock method in StateMachine.h 1 // TODO: This is to be refactored still 1 // TODO: once 5052175 is fixed and FabricNotReadable is split into transient/non-transient cases, don't retry on it 1 // TODO: constants for defaults 1 // TODO: Make Async 1 // TODO: Better to use KAsyncService? 1 // TODO: This can be enhanced to allow chaining of multiple 1 // TODO: RDBug 10631157:Add idempotent operation assert for CreateLSN/DeleteLSN check 1 // TODO: ForceInline and Inline cause build warning LNK4221. 5 // TODO ASSERT 2 [SuppressMessage(FxCop.Category.Design, FxCop.Rule.TypesThatOwnDisposableFieldsShouldBeDisposable, Justification = "// TODO: Implement an IDisposable, or ensure cleanup.")] 9 // TODO: #9166098: Take in cancellation token. 1 // TODO: FabricObjectClosedException may occur if this races with shutdown; catch and ..? 1 #if !defined(PLATFORM_UNIX) // FIXME: _mm_crc32_u64 replacement 1 // TODO: let service logic handle this -- don't ever erase sessionManager_ 1 // TODO: RDBug 13398799: Trace PerformCheckpoint in volatile case 1 // TODO: Is there a better way to convert TextA. Can we pass that 1 // @TODO - Fix KTL so that KUri LPCWSTR conversion has correct const-ness 1 // TODO: use string.join. 1 // TODO: What to do in this case, is throwing an exception the right way to respond to user API? 1 // TODO: Add some retry logic on unmap failures 2 /// TODO:With the retry added to the FinishOpen process we need to revisit how this is used there. 1 // TODO: We could add a more specific error code. 2 L"", // TODO: Fetch status description from KTL request and propagate it back to the client. 1 // TODO: remove retry timeout since we can get it from the header 1 // TODO [dragosav]: for the time being, we're using the same service API as for retrieving 2 // LINUXTODO output size depends on hash algorithm 1 sa.sa_flags = SA_NOCLDSTOP | SA_SIGINFO | SA_RESTART; //LINUXTODO should we also report stop events? 1 // TODO: replace 32 with 1024 when Rich fixes 1 // TODO: We need to use api monitor here. 1 // TODO: should trace and drop, but catch these errors and throw for now 1 // TODO: Replace with WhenAll 1 // TODO: free unmanaged resources (unmanaged objects) and override a finalizer below. 2 // TODO: establish correct default values - should be taken from native/configuration? 1 _CRTIMP_TODO int __cdecl ftell(FILE *); 1 // TODO: what is this Clear all about? Should we use this for anything? 1 // TODO: If idle restarts, we are fine. If primary restarts, its address changes so we are fine. 1 // TODO: We should look into fixing this. 1 // TODO: Actual implementation will need to support key_equal function / equalscomparer to be passed in. 1 // TODO: Wait for some time so that the unreliable transport behavior can be read from the files. 4 // TODO: Think the Policy passing through 1 //TODO: Remove this address update after Bug :1225032 gets resolved 2 return L""; // LINUXTODO implement create cert from key. 1 //LINUXTODO connectionAuthSecurityDescriptor_ 1 // TODO: this is not correct; if the application contains map with specific items for this service type, that policy should be used. 1 { /*@TODO: Static bind version, if necessary*/ \ 1 /// TODO: Will need to enhance the client connection to support Certs. 1 // TODO: if status failed, return converted error 2 // TODO - remove just for debugging 1 /// TODO: Refactor it out. 1 // TODO: Pass the UpgradeType flag when implementing Switch 1 //** TODO: To be merged with current PAL CreateThread imp 1 -1, 0, // TODO: Replace with constants in a way that won't break Linux build 1 // TODO: Fast path for UTF-16 2 // TODO all replica and partition selector overloads 1 Now build completes for one replica which then gets deactivation epoch updated (TODO: No need for deactivation epoch update in swap during phase 0) 1 if(!InObject()) // TODO: I suspect the else clause is sufficient here, the previous token will only be Json_FieldName if we are already InObject 1 // TODO: Do we need to wire up set-cookie header? and also set cookie expiry? 1 // TODO: Used by managed KVS 1 // TODO: uncomment the following line if the finalizer is overridden above. 2 // TODO: These didn't make it to windows 1 // TODO: move logic to test code after code is stable. 1 // TODO: _AllocationExtentSize may need to be configurable or 1 // @TODO - Read the key 1 // TODO: Change to 0 before merging 1 //LINUXTODO consider support sending callback in IDatagramTransport 1 // TODO: Start time is not accurate yet. Only in "Application Upgrade" scope. 1 true, // TODO: This should be propagated based on the requireSFRuntime flag. 1 // TODO: structured tracing for a map 1 // TODO: This should include duration of each stage. 1 //TODO shuxu check 1 // TODO: Fix this 1 // TODO: target to self? 1 //this is not currently used, but I'm keeping it in. TODO: perform cleanup if metric graph gets too big. 1 /*TODO - 935703 - WaitForCopyQueueToDrain(thisSPtr);*/ 1 // TODO: find a way to push handling of this transient fault down into the managed wrapper for sessions 1 // TODO: Should we be doing deep copies here? Think in details. 1 // TODO: receivedMessages and receiveWaiters probably don't need to be Concurrent 1 // TODO: Make Federation use the PToP actor map 1 /// TODO FW: make it abstract after script test side code is refactor and totally dependent on testability. 1 // TODO: Is MemoryBarrier required? 1 // TODO: FOR DEBUGGING PURPOSES, REMOVE WHEN FIXED 2 // TODO: Fix the variable name here 1 // TODO: Return error code when all features have been ported. 1 /// TODO: this layer must catch all exceptions and decide what to do with them -- lower layer functions like ResolveAndNormalizeTargetPartition 1 // TODO: Why is this not using move semantics - kept the same for back compat in just in case 1 // TODO: Remove 1 // TODO what's the right way to IPv6 enable this 1 SetBAHeaders(*message, Transport::Actor::BA, action); // TODO: Using default BA here 1 // TODO: handle message dropping 1 // TODO: Fix buffer1K to be correct size. Add 1 to work around bug in KFileStream::WriteAsync 1 // TODO validate node names, casing, duplicates, etc? 1 // TODO: De-Staging ? 7 // TODO: create correct provider based on the infrastructure 1 0, // TODO: estimatedDbSize 1 // @TODO: This is required because we pull in the COM+ 2.0 PE header 1 //LINUXTODO remove this conditional compile and always call ProcessClaimsMessage here 1 isAlwaysReadable_(true), // TODO: should be configured on creation 1 // TODO: Clean this up together with some other change to version the JIT-EE interface 1 //// TODO native code try findvalue as complete subject name first, if no match, then as common name. 1 throw ktl::Exception(SF_STATUS_INVALID_OPERATION); // TODO: Use actual exception 1 psid->SubAuthority[1] = uid; //TODO: Linux does not have anonymous... 1 // TODO: Trace that volatile store has recovered 1 // TODO: END: DebugOnly 1 // TODO: this currently doesn't catch all exceptions 1 // TODO: Once FabricTest has been modified to generate InfrastructureManifest.xml file, we should throw if the file 1 // TODO: this relies on the above assertion that a KUniquePtr is really just a pointer 2 // TODO: header can be && 1 // TODO: Implement Max delay 1 // TODO: use one-way & extend request for RevertToReject after arbitrators all move to new version 1 // TODO: this should really be const but for now we don't want to preclude the assignment operator 1 // TODO: should we also assert against current send sequence number? 1 // TODO: Read into readBuffer directly instead of using readData. 1 // TODO: set large fields to null. 2 // TODO: File bug to fix this 1 // TODO: Kernel mode 1 /* TODO: prior code to be deleted 1 // TODO: Need setitem support on ItemCollection 1 // TODO: Dampen cancellation by looking at this.IsLastKnownJobStateRecentlyUpdated() 1 foreach (var aa in allowActionMap.Get().Where(e => e.CreationTime < now - TimeSpan.FromHours(1))) // TODO expiry as config 1 // find the root service, TODO: find the first placed root service 1 // TODO: A tree implementation would 1 #define _CRTIMP_TODO __declspec(dllimport) 1 // TODO: Is this needed? 1 // TODO: RDBug 11876054:FabricUS: Handle retryable exceptions for health status publishing 1 // TODO: report health 1 //TODO: verify if this is an assertion I can make 1 /// TODO: keep the count in memory. 2 /// TODO: Look at moving all out the special casing complexity into Cluster query object itself. 1 // TODO: Consider adding trace output when secondary exceptions occur 1 auto alg = EVP_sha512(); // LINUXTODO make algorithm an input parameter 1 // TODO: Avoid returning a string because strings are immutable and hence we cannot clear out the 1 // TODO: TryPush the enumerator for de-duplication 1 //TODO: Remove default value to force all references to explicitly pass isolation context. 1 // TODO: REMOVE WHEN DEBUGGED 2 // TODO: add validation 1 //LINUXTODO: get full uri 1 // TODO: Get rid of the extra KDbgCheckpointWData 1 TODO: This could be changed to call CORINFO_HELP_VERIFICATION_RUNTIME_CHECK 1 // TODO: Use a more appropriate timeout 1 // TODO: Exception/HRESULT work needs to be finished: catch (FabricElementNotFoundException) 1 // TODO: use timeout 1 // @TODO - Move this into reliable_collections.h 1 /// TODO: This seems to cache all partition keys not just numbered. 1 // TODO: We need to add a mitigation here in case FabricBRS is not reachable. 1 BackupScheduleRuntimeList::BackupScheduleRuntimeList(vector runTimes) : runTimes_(runTimes) // TODO: Check if effective copy possible. 1 // Dism COM errors aren't well understood yet across different OSes. TODO Handle specific error codes and throw the rest 1 // TODO: remove and replace with better one 1 #if 0 // TODO: Delete me 1 FolderPath = UtilityHelper.GetBaseDirectoryPathForPartition(this.ServiceUri, this.PartitionId), // TODO: This should be constructed 1 throw ktl::Exception(K_STATUS_OBJECT_NOT_ATTACHED); //TODO: Pick the right status for NotImplementedException 6 _CRTIMP_TODO FILE * __cdecl _wfopen(const wchar_t *, const wchar_t *); 1 // TODO: add support for HeapAlloc options, such as ZERO_INIT 1 _CRTIMP_TODO int __cdecl fprintf(FILE *, const char *, ...); 1 // TODO: check on perf testing for this allocation. 1 // TODO: GopalK, currently all barrier operations are full barriers. 1 // TODO: Enable after updating ServiceFabricClientPackage in SF-AppStore Repo 1 // TODO - Uncomment code below when totally transitioned to structured traces 1 // TODO: processing load information. 1 LONGLONG _DedicatedWriteBytesOutstandingThreshold; // TODO: Make configurable 1 // TODO: To optimize explicitly cancel the pending operations. 1 else if (exception is FabricBackupRestoreLocalRetryException) //TODO Remove this and change to correct message 1 // TODO: Check with Rajeet. 1 //LINUXTODO should this be a list of buffers? or using buffered BIO? 1 // TODO: Change the caller: WinErrorCategory.cpp 1 // TODO: In the future make the config on by default and change this to nodesWithUpStatefulReplicas_ 1 // TODO: use constraint to implement overflow to underflow only? 2 // TODO: the tracing isn't from the component itself anymore. Does that matter? 1 // @TODO: Due to prefast template problems, implementations of the DoNothing macro have been changed 1 // TODO: Configure and enforce PinnedMemoryLimit 1 //// TODO: Implement smarter port selection to avoid conflicts with ports specified by the user 1 // TODO: Once we support custom state providers, add retry for failed state providers. 1 // TODO: Temporary assert. Should be removed later. 2 //TODO: create an internal CLSID and do a QueryInterface 3 // TODO: if we want to avoid tombstones for sessions we must tolerate this situation as a no-op (fail the Start) for ProtocolResponse messages 1 // rahku- TODO change to long 1 // TODO: use the Unsafe naming convention for all methods that assume appropriate locks are held 1 // ROTORTODO - g++ 3 doesn't like the use of the operator& in __GlobalVal 1 /// Best Effort Today. TODO: Need to improve this but require the incoming event to have more information 1 /* TODO: Disable temporarily for force delete 1 //TODO: Add check for each request by Guid 1 // TODO: most of this can be done with a Read lock -- Flush requires a Write lock 1 // TODO : Make this common code between all upgrade input parsing. 1 // TODO: This exception needs to be considered. 1 // TODO: Handler unregistration. 1 // TODO: Use fabric tracing ??? 1 // TODO - to be removed after transitioning for structured traces in Linux 1 // TODO: Another hash generator has been added based on Pearson algorithm; this one, at some point, 1 // TODO: if files are large, read line by line 1 // TODO: fault and cancel are actual possibilities we need to account for 2 // TODO: LeaseAgent and LeasePartner Source Code will be moving to ~src\Lease\Api directory later. 1 //LINUXTODO enable algorithm comparison 1 _ASSERTE(!"@TODO Port - getRegAddr (Regdisp.h)"); 1 return ErrorCode(ErrorCodeValue::InvalidState); // TODO: return correct error code 1 // TODO: Revisit with new KTL threadpool 2 { "Disk.Wipe", ImpactCategory.DataDestructive }, // TODO: Review new impact 1 //// TODO current SFRP only use thumbprint, so we may ingore this for now 1 // TODO: deal with exceptions 2 // TODO: Should the number of receive correspond to the sessionReceiveQuota. 1 // TODO: [General] disposal of ServiceController 1 // TODO: RDBug 7635808 : Test and see if DeployedPartition 1 // TODO: We do not support session expiry currently 1 // TODO: AreEqual(expect.CurrentUpgradeDomainProgress, actual.CurrentUpgradeDomainProgress); 2 // TODO consider adding JobStatus == JobStatusEnum.Executing check or deleting this comment once MR team 1 // TODO: shouldnt be using const cast 1 // TODO: Find a way to enable this check. 1 _CRTIMP_TODO int __cdecl fflush(FILE *); 1 // TODO: is the following code used? 1 // TODO: Can this occur when the heap is too fragmented ? 1 //LINUXTODO compare string based on locale 2 // TODO: trace 1 // TODO add for all if needed 1 // the rollout status for this need not be set to DeletePending here. TODO: Test/check 4 // TODO: Consider moving into logical log 1 // 4. TODO: Have a configuration to preserve the host header. If that is not set, then dont 1 // TODO: param of extension buffers 1 // TODO: differentiate between noise and info for stable tracing 1 // TODO: DYNAMIC_SIZE_ESTIMATION_MEMBER(currentConfigurationEpoch_) ? 1 // TODO: this is not processed, consider calling UpdateRepairTaskHealthPolicyAsync instead 1 // TODO: Remove template parameter from here 1 _CRTIMP_TODO FILE * __cdecl fopen(const char *, const char *); 1 // TODO: #9165663: KTL SetSystemIoPriorityHintAsync is requried. 2 // TODO: make empty array 1 // TODO continuation token 1 // TODO: Notifications for all partitions are not currently supported; 1 throw new ArgumentException(); // TODO: Change this with appropriate exception 1 // TODO: Consider adding trace output when secondary exceptions occur 1 //LINUXTODO consider removing HRESULT_FROM_WIN32 below (revert back to commit fab0ac79d978d646454ca13561154f031b5008c8), 1 // TODO #10279752: Separate redo out of ReplicationMetadata. Making 1 ServiceModelEventSource::Trace->ReplicatorSettingsError(errorMessage); // TODO: Create trace for TransactionalReplicatorSettings error 1 // TODO add validation for http app gateway endpoint 1 // TODO: Add support for undo verification. 1 throw new ArgumentException(); // TODO: Change with the OTher exception 1 throw ktl::Exception(K_STATUS_OBJECT_NOT_ATTACHED); //TODO: Out of capacity. KStatus doesn't have this we shall create one in KTL? 1 TODO: In order for retail wastorage to be usable, we will either need to wait for 1 /// TODO: Consider adding a Performance Counter Manager. 1 //LINUXTODO also retrieve issuer public key 1 // TODO: Replace the following sample code with your own logic 1 // TODO: Make into parameters 1 // TODO: At some point allow read only access to the stream 1 // TODO: think through this situation -- just dropping the message right now -- need throttling protocol 1 // TODO: should we use Now as timestamp? 1 // TODO: Compute ! 1 /// TODO: Change to id. 1 // TODO: implement iterator pattern? 1 //TODO: Add cert update handling in Hosting to refresh certs in container application host 1 // TODO: Require storageAccountFQDN and fail the request at some timepoint 1 // TODO: FLOW CONTROL 1 // TODO: Consider moving into logical log 1 // TODO remove after JSON serialization of sptr is checked in 2 // Lease Agent was found (TODO:linux specific logic) 1 //// TODO: (maburlik) Validate FabricClient connection 2 // TODO - make this a warning 1 // TODO: validation of the CIDR notation 1 // operator &. TODO: probe with a static_assert? 1 // TODO: Add a GetOrAdd() function to activation table itself as it is already thread safe. 1 // TODO -waa 1 // TODO: All HRESULT_FROM_WIN32(GetLastError()) should be replaced by calls to 1 // TODO: Trace here for failed start. 1 // TODO: create proxy for the stateless service 1 //TODO: validate content type: text/yaml or text/yml 2 FolderPath = UtilityHelper.GetBaseDirectoryPathForPartition(serviceName, partitionId), // TODO: This should be constructed 2 __out Transport::ISendTarget::SPtr &); // TODO: returns a sptr copy, can this be optimized to return a ref? 1 // TODO: scope should be a const reference, but that requires making entire JSON writer const 1 KAssert(_NextStreamLsn == recordHeader->Lsn); // TODO: Why assert and not a failure ? 1 // TODO: this looks more like something to Assert 1 // TODO: rename JsonBufferManager2 to JsonBufferManager when jpath.lib is removed 1 //LINUXTODO do we need to clean up inBio_ or SSL_read will clean up? 1 // TODO: handle property already exists error. 1 // BUG: TODO: richhas merge into common base class. 1 // TODO: This routine does not cleanly handle the case where log wraps 1 // TODO: Put this back in when the issue found in FabricRM.test is 1 //LINUXTODO consider removing EventBuffer 1 // TODO This eventually needs to be moved to its own Consumer so event is not decoded more than once. 1 // TODO: Use a backup config for this flush size determination 1 // TODO: factor and fix reentrancy/etc. issues 1 // TODO: 7953769: we should disallow system reports sent by public users. 1 // TODO: exception handling 22 // TODO: I may refactor this a bit in future. 1 // TODO: Make this sync when service Abort support is added 1 // TODO - work around recreated relationship for termination message 2 // TODO: what exceptions is this allowed to throw? 1 // TODO: Can throw FabricTransientException. 1 // TODO: add lock to ServiceDomain class, and this lock only controls global information update 1 // TODO: Work out Reuse() for read approach 1 // TODO: Add unit test 1 // TODO: Invalid path 1 // TODO: Wait for some time so that the removal of this unreliable transport behavior can be read from the files. 1 // TODO: Change to sys call instead of process create for better diagnostics 1 // TODO: look at whether this would ever happen 1 // TODO: Fix the workaround below until item 5861402 is fixed. 1 // TODO: This can be enhanced with per client caches, processor 1 // TODO: Get the Replica by ReplicaId. 1 // TODO: Bug check activationId value and ignore any stale notification 1 // TODO: [General] surface fatal errors outside the agent as AP health report. 1 // TODO: Make these error messages more detailed by adding an actual error message 1 //@TODO: Dangerous default value. Some Win32 functions return INVALID_HANDLE_VALUE, some return NULL (such as CreatEvent). 1 /// TODO - create an interface, a factory (and a factory interface) and pass the factory interface in the constructor to the 1 // TODO make this optional 1 // TODO: Reject each request with a cancel error code 1 // TODO: After current xcopyable issue is fixed, update the pattern here. 1 // TODO: replace this with trace into product 3 // TODO error -> ntstatus 1 auto md = EVP_sha256(); //LINUXTODO take algorithm as an input parameter 1 // TODO: THis just disconnects the request to service to prevent leaks, this should also clean 1 // TODO: Is MemoryBarrier required? 2 // TODO: Remove this KInvariant before release 1 // TODO: Remove when stabilized 2 // TODO: Rewrite this state machine for correctness. Each call to an asynchronous http.sys API should be wrapped 1 // TODO: when kernel supports coroutines, actually implement this 7 // TODO: Expiration could be maxvalue, sanitize it. 1 // TODO: Remove it or change it to TRACE_NOISE 1 string jsonConfigPath = Path.Combine(fabricDataRoot, System.Fabric.FabricDeployer.Constants.FileNames.BaselineJsonClusterConfig); // TODO: Needs to come from image store 1 // TODO: do we need to keep the capacityratio and capacity data If a node is down? 1 this->RemainingTime, // TODO: Need to fix retry timeout 1 // TODO: The RA should move to using the same activity id as the rest of the product 1 //TODO lifetime of txReplicator 1 // TODO: Logfile configured geometry 1 // TODO: overactive assert meant to discover failure modes 1 // TODO: Add cancellation support 1 // TODO: Exception/HRESULT work needs to be finished: catch (FabricElementNotFoundException) 1 // TODO special case passthrough transport 1 // TODO: Remove me when code is fully stabilized 1 // TODO: deal with exceptions 1 // TODO: Replace blocking thread with syncfile support when KXM is 1 class BuildSingleInstanceApplicationForUpgradeAsyncOperation; // TODO: Make this common code between CGS 1 //LINUXTODO consider avoid callback_ copy, which probably requires not resetting 1 /// TODO - fix this 1 // TODO: Remove this trace once #11183365 is resolved 7 // TODO: add certificates 1 // TODO: do we need to worry about OutOfMemory exception? 1 // TODO: Not implemented yet 2 @TODO: _ASSERTE not available here... 1