src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReliableMessaging/stream/Stream.cs (30 lines):
- line 41: // TODO: is this always accessed under waiterSync? If so make it a simple dictionary; also consolidate access code in a class
- line 186: // TODO: LastReceiveSequenceNumber fix needed
- line 228: // TODO: think about using the new InboundParameters property; more appropriate/consistent?
- line 229: // TODO: document the exact role and reliability of the CloseMessageSequenceNumber in the driver
- line 961: // TODO: deal with exceptions
- line 1153: // TODO: this could benefit from transaction enlistment
- line 1485: // TODO: rethink need and safety of no lock in send situation
- line 1630: // TODO: deal with exceptions
- line 1645: // TODO: should we also assert against current send sequence number?
- line 1646: // TODO: look at this nolock option again later right now it seems dangerous
- line 1741: // TODO: deal with exceptions
- line 1788: // TODO: handle exceptions
- line 1804: // TODO: SetResult can hijack the thread to execute the continuation, so make sure that happens on a different thread
- line 1805: // TODO: fault and cancel are actual possibilities we need to account for
- line 1951: // TODO: look at whether this would ever happen
- line 2103: // TODO: exception handling
- line 2241: // TODO: deal with exceptions
- line 2302: // TODO: SetResult can hijack the thread to execute the continuation, so make sure that happens on a different thread
- line 2303: // TODO: fault and cancel are actual possibilities we need to account for
- line 2330: // TODO: make sure locking issues are avoided
- line 2366: // TODO: cleanup
- line 2378: // TODO: look at whether this would ever happen
- line 2403: // TODO: exception handling
- line 2422: // TODO: deal with exceptions
- line 2533: // TODO: deal with exceptions
- line 2989: // TODO: Need to deal with stream states other than Open on restart
- line 3039: // TODO: we may need to periodically flush messages that come in as retries and have sequence numbers below NextSequenceNumberToDelete
- line 3056: // TODO: look into making this less chatty, perhaps with a timer
- line 3134: // TODO: make sure the message is always deleted when consumed and will not reappear
- line 3154: // TODO: receivedMessages and receiveWaiters probably don't need to be Concurrent
src/prod/src/managed/Api/src/System/Fabric/Common/Tracing/TraceEvent.cs (20 lines):
- line 54: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 84: // TODO: We are currently hard-coding the mask values, but this is not ideal
- line 157: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 299: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 320: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 339: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 358: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 377: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 396: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 415: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 434: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 453: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 472: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 491: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 510: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 529: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 548: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 567: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 586: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 713: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReliableMessaging/stream/StreamManager.cs (18 lines):
- line 246: // TODO: exception handling
- line 786: // TODO: ReliableSessionManagerAlreadyListening must not happen; Assert?
- line 795: // TODO: FabricObjectClosedException may occur if this races with shutdown; catch and ..?
- line 1274: /// TODO: Why not make this a overloaded constructor, or precreate one that they can use right away.
- line 1475: // TODO: Implement Max delay
- line 1611: // TODO: exception handling
- line 1649: // TODO: what exceptions is this allowed to throw?
- line 1954: // TODO: need simple exception handling structure/pattern
- line 2174: // TODO: exception handling
- line 2190: // TODO: exception handling: should we do ReportFaultTransient in this case?
- line 2213: // TODO: exception handling: should we do ReportFaultTransient in this case?
- line 2542: // TODO: handle exceptions
- line 2862: // TODO: there is a store GetAsync at the bottom of this enumeration so think about the exceptions
- line 3139: // TODO: look at sequence number management end-to-end including what happens to Open and Close messages
- line 3214: // TODO: what is this Clear all about? Should we use this for anything?
- line 3237: // TODO: this is where we would take back an outbound stream if the transaction aborted
- line 3296: // TODO what kind of exception should this be? Should we wrap it in something?
- line 3375: // TODO what kind of exception should this be?
src/prod/ktl/src/src/palio.cpp (15 lines):
- line 9: // TODO fix https://bugzilla.redhat.com/show_bug.cgi?id=1476120
- line 568: #if 0 // TODO: Delete me
- line 751: // TODO: Is this correct to use std::remove ? Why not remove()
- line 752: ret = std::remove(_PathToFile.c_str()); // TODO: Remove STL usage
- line 754: // TODO: Kernel mode
- line 757: return STATUS_INTERNAL_ERROR; // TODO: Map to NTStatus
- line 863: 0, // TODO: Will this overwrite existing allocation
- line 874: // TODO: Is there an equivalent for Linux ??
- line 1325: // TODO: Return error code when all features have been ported.
- line 1529: // TODO: Do I need to do this ??
- line 2117: // TODO: Remove STL usage
- line 2139: // TODO: Remove STL usage
- line 2296: // TODO: Remove STL usage
- line 2353: // TODO: Remove STL usage
- line 2603: // TODO: Linux equivalent
src/prod/src/data/tstore/Store.h (15 lines):
- line 172: // TODO: Implement
- line 2034: // TODO: Trace that volatile store has recovered
- line 4312: // TODO: Remove this trace once #11183365 is resolved
- line 4318: // TODO: Remove this trace once #11183365 is resolved
- line 4325: // TODO: Remove this trace once #11183365 is resolved
- line 4335: // TODO: Remove this trace once #11183365 is resolved
- line 4345: // TODO: Remove this trace once #11183365 is resolved
- line 4358: // TODO: Remove this trace once #11183365 is resolved
- line 4390: // TODO: Remove this trace once #11183365 is resolved
- line 4490: // TODO: Reconsider infinite retry.
- line 4615: // TODO: Replace with WhenAll
- line 4740: if (rwtxSPtr->ReadIsolationLevel == StoreTransactionReadIsolationLevel::Enum::Snapshot) // TODO: Also check for ReadCommittedSnapshot
- line 5213: // TODO: rwtx->ReplicatorTransaction->ThrowIfTransactionManagerIsNull();
- line 5298: // TODO: Check for ReadCommittedSnapshot level and no locking hints
- line 5432: isAlwaysReadable_(true), // TODO: should be configured on creation
src/prod/src/ktllogger/sys/ktlshim/shimkm.h (15 lines):
- line 800: // TODO: when kernel supports coroutines, actually implement this
- line 885: // TODO: when kernel supports coroutines, actually implement this
- line 1292: // TODO: when kernel supports coroutines, actually implement this
- line 1456: // TODO: when kernel supports coroutines, actually implement this
- line 1708: // TODO: when kernel supports coroutines, actually implement this
- line 1782: // TODO: when kernel supports coroutines, actually implement this
- line 1855: // TODO: when kernel supports coroutines, actually implement this
- line 1960: // TODO: when kernel supports coroutines, actually implement this
- line 2057: // TODO: when kernel supports coroutines, actually implement this
- line 2131: // TODO: when kernel supports coroutines, actually implement this
- line 2667: // TODO: when kernel supports coroutines, actually implement this
- line 2686: // TODO: when kernel supports coroutines, actually implement this
- line 2775: // TODO: when kernel supports coroutines, actually implement this
- line 2977: // TODO: FOR DEBUGGING PURPOSES, REMOVE WHEN FIXED
- line 2981: // TODO: FOR DEBUGGING PURPOSES, REMOVE WHEN FIXED
src/prod/src/reliablemessaging/ReliableSessionService.cpp (14 lines):
- line 333: // TODO: what if this callback faults? catch it
- line 399: // TODO: we are truly out of resources, notify Fabric -- asserting for now
- line 429: // TODO: we seem to be completely out of resources -- need to signal fault -- assert for now
- line 485: // TODO: trace!
- line 672: // TODO: review lifecycle management of openOp_
- line 811: // TODO: we should probably report fault here
- line 855: // TODO: MultipleCloseSessionAcksReceived needs to be changed to CloseSessionAckDropped
- line 986: // TODO: look closely at lifecycle management os sessions and session managers
- line 990: // TODO: revisit inbound session cleanup, some tricky race conditions including multiple colliding protocol responses when session not found during CloseRequest retry
- line 1090: // TODO: look closely at lifecycle management os sessions and session managers
- line 1263: // TODO: do we need to look more closely into these exceptions?
- line 1381: // TODO: no other recourse here? Report fault?
- line 1389: // TODO: no other recourse here? Report fault?
- line 1581: // TODO: add dropped item callback to handle dropped enqueued messages? To send back Nacks perhaps? Not essential but courteous ..
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReliableMessaging/session/ReliableSession.cs (14 lines):
- line 300: // TODO: if the key is an unknown type should be invalif arg
- line 301: // TODO: this whole boolean return API needs update
- line 431: // TODO: Call FreeHGlobal when done with this native string
- line 466: // TODO: exception handling
- line 476: // TODO: exception handling
- line 862: // TODO: exception handling
- line 887: // TODO: exception handling
- line 894: // TODO: exception handling
- line 916: // TODO: exception handling
- line 923: // TODO: exception handling
- line 933: // TODO: exception handling
- line 948: // TODO: do we support null messages, e.g., for pinging purposes?
- line 954: //TODO: what if sendMessage is null?
- line 969: // TODO: do we support empty messages?
src/prod/src/managed/fabricis/parallel/dll/ImpactTranslator.cs (12 lines):
- line 65: { "Compute.Initialize", ImpactCategory.NoImpact }, // TODO: Review new impact
- line 66: { "Compute.Wipe", ImpactCategory.DataDestructive }, // TODO: Review new impact
- line 71: { "Disk.Initialize", ImpactCategory.NoImpact }, // TODO: Review new impact
- line 72: { "Disk.Wipe", ImpactCategory.DataDestructive }, // TODO: Review new impact
- line 77: { "Network.Initialize", ImpactCategory.NoImpact }, // TODO: Review new impact
- line 78: { "Network.Wipe", ImpactCategory.DataDestructive }, // TODO: Review new impact
- line 83: { "OS.Initialize", ImpactCategory.NoImpact }, // TODO: Review new impact
- line 84: { "OS.Wipe", ImpactCategory.DataDestructive }, // TODO: Review new impact
- line 87: { "ApplicationConfig.Freeze", ImpactCategory.NoImpact }, // TODO: Review new impact
- line 88: { "ApplicationConfig.Reset", ImpactCategory.NoImpact }, // TODO: Review new impact - this is an actual config update
- line 89: { "ApplicationConfig.Initialize", ImpactCategory.NoImpact }, // TODO: Review new impact
- line 90: { "ApplicationConfig.Wipe", ImpactCategory.DataDestructive }, // TODO: Review new impact
src/prod/src/ktllogger/sys/tools/DumpContainer/dumpcontainer.cpp (12 lines):
- line 36: // TODO: Separate into .h and .c
- line 1040: // TODO: Fix CRCs
- line 1117: // TODO: Dump the rest of the data.
- line 1127: // TODO: Dump redo and undo bytes
- line 1172: // TODO: dump rest of record
- line 1375: // TODO: Handle this situation by reading the next record and
- line 1748: // TODO: Figure out exactly how the read backward should work
- line 1798: // TODO: Examples
- line 2235: // TODO: Logfile configured geometry
- line 2494: // TODO: Dump headers within metadata
- line 2616: // TODO: This routine does not cleanly handle the case where log wraps
- line 2836: // TODO: Routine would be more easily written using memory
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReliableMessaging/stream/InboundSessionDriver.cs (11 lines):
- line 58: // TODO: Should the number of receive correspond to the sessionReceiveQuota.
- line 83: /// TODO: incorporate retry on quota exceeded, return true if we don't encounter session aborted exceptions, false otherwise
- line 128: // TODO: exception handling
- line 149: // TODO: exception handling
- line 169: // TODO: exception handling
- line 189: // TODO: exception handling
- line 209: // TODO: exception handling
- line 229: // TODO: exception handling
- line 249: // TODO: exception handling
- line 270: // TODO: exception handling
- line 291: // TODO: exception handling
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReliableMessaging/stream/SessionConnectionManager.cs (11 lines):
- line 27: /// TODO: 1. Move end point management to its own class
- line 28: /// TODO: 2. The current implementation supports source and target partners to be located in the same ring. We need to support Xrings.
- line 29: /// TODO: 3. Security (certs management)
- line 49: /// TODO: This seems to cache all partition keys not just numbered.
- line 71: /// TODO: Will need to enhance the client connection to support Certs.
- line 276: /// TODO: this may throw FabricObjectClosedException
- line 305: // TODO: ResolveServicePartitionAsync seems to throw TimeoutException in unexpected ways: investigate and fix this, leaving out the timeout param for now
- line 378: // TODO: the behavior of ResolveServicePartitionAsync is unclear as far as timeout goes, this code needs fixing
- line 449: // TODO: revisit the timeout behavior of GetPropertyAsync to clarify and adjust accordingly
- line 868: // TODO: overactive assert meant to discover failure modes
- line 951: // TODO: Why are we ignoring the session abort callbacks.
src/prod/src/reliablemessaging/ReliableMessagingTransport.cpp (11 lines):
- line 172: // TODO: this code needs to be factored and structured to amke it easy to bypass Transport for intra-process communication
- line 183: // TODO: what do we do with invalid messages? For now, assert!
- line 239: // TODO: make sure hash table structure has a const Find key parameter (unlike KAvlTree) so we can drop this extra assignment
- line 253: // TODO: think through this situation -- just dropping the message right now -- consider sending a Nack
- line 322: // TODO: make sure hash table structure has a const Find key parameter (unlike KAvlTree) so we can drop this extra assignment
- line 353: // TODO: think through this situation -- just dropping the message right now -- need throttling protocol
- line 450: // TODO: this is actually not a coding error -- not clear what the recourse is if we run out of resources here: a Nack? Not sure that would work
- line 458: // TODO: this is actually not a coding error -- not clear what the recourse is if we run out of resources here: a Nack? Not sure that would work
- line 520: // TODO: do we need these static methods? Should we just do the search here instead?
- line 560: // TODO: what do we do if responseResult is failure?
- line 573: // TODO: do we need these static methods?
src/prod/src/Lease/linux/Leases.cpp (11 lines):
- line 987: //TODO check this
- line 1022: //TODO shuxu
- line 1216: //TODO shuxu
- line 1304: (LONGLONG)0 // TODO seperate template for this trace
- line 1355: //TODO shuxu
- line 1886: //TODO shuxu
- line 3067: //TODO shuxu check
- line 3077: //TODO shuxu check
- line 3344: //TODO shuxu check
- line 3356: //TODO shuxu check
- line 6532: //LINUXTODO check if offset is needed
src/prod/src/data/txnreplicator/loggingreplicator/BackupManager.cpp (10 lines):
- line 161: // TODO: Not implementing timeout - waiting for timer solution.
- line 1344: // TODO: We could add a more specific error code.
- line 1362: // TODO: We could add a more specific error code.
- line 1429: // TODO: We need to use api monitor here.
- line 1496: // TODO: Can return error
- line 1600: // TODO: Trace.
- line 1629: // TODO: Await records processor.
- line 1776: // TODO: Consider adding SF_STATUS_BACKUP_OR_RESTORE_IN_PROGRESS
- line 1844: // TODO: We should make the SF_STATUS_ONDATALOSS_NOT_INFLIGHT.
- line 1903: // TODO: Consider adding SF_STATUS_RESTORE_NOT_SAFE error code.
src/prod/src/managed/Container/VolumePlugin/AzureFiles/Service/VolumeMap.cs (10 lines):
- line 24: // TODO: Coarse lock - improve.
- line 87: // TODO: Require storageAccountFQDN and fail the request at some timepoint
- line 139: // TODO: Holding the lock during network call - improve.
- line 393: // TODO: Change to sys call instead of process create for better diagnostics
- line 452: // TODO: Change to syscall instead of process create for better diagnostics.
- line 606: // TODO: dispose managed state (managed objects).
- line 610: // TODO: free unmanaged resources (unmanaged objects) and override a finalizer below.
- line 611: // TODO: set large fields to null.
- line 617: // TODO: override a finalizer only if Dispose(bool disposing) above has code to free unmanaged resources.
- line 628: // TODO: uncomment the following line if the finalizer is overridden above.
src/prod/ktl/src/src/kxm/user/KXMApiUser.cpp (9 lines):
- line 292: // TODO: emulate event files
- line 342: // TODO: We can be smart and cache the FD for the different disk
- line 350: //TODO: we can continue and see if file is mapped by any other dev file.
- line 390: // TODO: emulate event files
- line 659: // TODO: What else can we do if we can't post ??
- line 697: // TODO: Use a more linux oriented approach such as epoll and IoSubmit.
- line 745: // TODO: Use a more linux oriented approach such as epoll and IoSubmit.
- line 796: // TODO: Use a more linux oriented approach such as epoll and IoSubmit.
- line 847: // TODO: Use a more linux oriented approach such as epoll and IoSubmit.
src/prod/src/Common/CryptoUtility.Linux.cpp (9 lines):
- line 995: //LINUXTODO: FW: handle altSubjectName
- line 1106: //LINUXTODO consider using BIO_f_base64
- line 1141: key.resize(256/8); // LINUXTODO determize key size based on encryption algorithm
- line 1184: auto alg = EVP_sha512(); // LINUXTODO make algorithm an input parameter
- line 1199: // LINUXTODO output size depends on hash algorithm
- line 1219: auto md = EVP_sha256(); //LINUXTODO take algorithm as an input parameter
- line 1479: //LINUXTODO consider using BIO_f_base64
- line 1771: //LINUXTODO also retrieve issuer public key
- line 2013: X509_VERIFY_PARAM_set_flags(param, X509_V_FLAG_CRL_CHECK); //LINUXTODO consider support X509_V_FLAG_CRL_CHECK_ALL?
src/prod/ktl/src/src/khttpserver.cpp (9 lines):
- line 807: // TODO: wrap in a child async
- line 952: // TODO: factor and fix reentrancy/etc. issues
- line 1083: // TODO: Rewrite this state machine for correctness. Each call to an asynchronous http.sys API should be wrapped
- line 1466: // TODO: wrap in a child async
- line 1548: // TODO: wrap in a child async
- line 1673: // TODO: wrap in a child async
- line 2053: // TODO: wrap in a child async
- line 2094: // TODO: guard state changes etc.
- line 2167: // TODO: wrap in a child async
src/prod/src/inc/clr/crtwrap.h (9 lines):
- line 63: #define _CRTIMP_TODO __declspec(dllimport)
- line 269: _CRTIMP_TODO extern FILE _iob[];
- line 276: _CRTIMP_TODO FILE * __cdecl fopen(const char *, const char *);
- line 277: _CRTIMP_TODO FILE * __cdecl _wfopen(const wchar_t *, const wchar_t *);
- line 278: _CRTIMP_TODO size_t __cdecl fwrite(const void *, size_t, size_t, FILE *);
- line 279: _CRTIMP_TODO int __cdecl ftell(FILE *);
- line 280: _CRTIMP_TODO int __cdecl fprintf(FILE *, const char *, ...);
- line 281: _CRTIMP_TODO int __cdecl fflush(FILE *);
- line 282: _CRTIMP_TODO int __cdecl fclose(FILE *);
src/prod/src/Common/JsonReader.h (9 lines):
- line 84: // TODO: Fast path for UTF-16
- line 628: hr = JSON_E_UNEXPECTED_TOKEN; // TODO: More specific error code?
- line 632: hr = JSON_E_UNEXPECTED_TOKEN; // TODO: More specific error code?
- line 764: m_previousTokenType == JsonTokenType_BeginObject || // TODO: This case is actually caught by the InArray check. Remove?
- line 787: m_previousTokenType == JsonTokenType_BeginArray || // TODO: This case is actually caught by the InObject check. Remove?
- line 853: if(!InObject()) // TODO: I suspect the else clause is sufficient here, the previous token will only be Json_FieldName if we are already InObject
- line 1234: // TODO: rename JsonBufferManager2 to JsonBufferManager when jpath.lib is removed
- line 1295: // TODO: Fast path for UTF-16
- line 1430: // TODO: Discriminated union over various buffer pointers? Might save us 4 bytes...
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/LoggingReplicator.cs (8 lines):
- line 119: // TODO: Temporarily internal for testing purposes. Should be made private.
- line 894: // TODO: Conisdier optimization:
- line 1276: // TODO: Consider Assert.
- line 1334: // TODO: Can throw FabricTransientException.
- line 1412: // TODO: rename to backup inflight
- line 2060: // GopalK, TODO: Preetha, should not we be disposing statemanager here?
- line 2078: /// TODO: Consider adding a Performance Counter Manager.
- line 2176: /// TODO:
src/prod/src/Federation/RoutingManager.cpp (8 lines):
- line 76: // TODO: remove retry timeout since we can get it from the header
- line 192: // TODO: Remove this exception for broadcast during M1 refactoring
- line 386: // TODO: reply with a suitable fault message
- line 407: // TODO: Checks for bad retry timeouts such as MaxValue
- line 414: // TODO: should trace and drop, but catch these errors and throw for now
- line 588: // TODO: Reject each request with a cancel error code
- line 589: // TODO: The id may still be in the processing set, we could remove it, but SiteNode should be shutting down anyway...
- line 653: // TODO: this is common in ProcessRoutedMessages, consider refactoring
src/prod/src/managed/Api/src/System/Fabric/Common/Tracing/TraceConfig.cs (8 lines):
- line 31: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 55: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 93: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 210: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 415: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 499: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 530: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 615: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
src/prod/shared/serialization/src/FabricStream.cpp (8 lines):
- line 157: // TODO: if status failed, return converted error
- line 164: // TODO: add buffer to a karray
- line 166: // TODO: shouldnt be using const cast
- line 177: // TODO: if status failed, return converted error
- line 182: // TODO: stream not long enough, return error
- line 279: // TODO: check and filter error
- line 287: // TODO: remove this, don't think it is needed
- line 310: // TODO: if failed return some error
src/prod/src/BlockStore/Service/VolumeDriver/Service/VolumeMap.cs (8 lines):
- line 26: // TODO: Make volumesMetadata single file instead of multi files
- line 33: // TODO: Coarse lock - improve.
- line 178: // TODO: Create by using System.Guid.NewGuid().ToString() and save to globle reliable map to handle the failover case from Node1 to Node2
- line 965: // TODO: dispose managed state (managed objects).
- line 970: // TODO: free unmanaged resources (unmanaged objects) and override a finalizer below.
- line 971: // TODO: set large fields to null.
- line 977: // TODO: override a finalizer only if Dispose(bool disposing) above has code to free unmanaged resources.
- line 988: // TODO: uncomment the following line if the finalizer is overridden above.
src/prod/src/Store/TSReplicatedStore.cpp (7 lines):
- line 463: // TODO: Is this needed?
- line 517: // TODO: Not supported by V2 stack
- line 644: // TODO: Optimize in TStore by distinguishing version mismatch and not found in ConditionalUpdateAsync()
- line 692: // TODO: Optimize in TStore by distinguishing version mismatch and not found in ConditionalRemoveAsync()
- line 719: // TODO: Used by HM
- line 811: 0, // TODO: estimatedDbSize
- line 1589: // TODO: This can be optimized if KBuffer can be initialized with just the pointer
src/prod/src/Common/Trace.cpp (7 lines):
- line 21: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 124: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 302: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 401: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 591: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 601: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 623: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
src/prod/ktl/src/src/MgmtService.cpp (7 lines):
- line 77: // TODO: list of objects/URI that are handled
- line 172: // TODO: Reenable when Raymond is ready
- line 468: // TODO:
- line 575: // TODO: use FormatMessage to convert NTSTATUS to string
- line 655: // TODO: array based method to get list of values
- line 990: // TODO: fix callback - many of the fields are broken out of the
- line 1009: // TODO: fix callback - Where does the invoke verb live in the XML
src/prod/src/managed/Api/src/System/Fabric/StatefulServiceReplicaT.cs (7 lines):
- line 154: //// TODO: We need to add domain information which will be published address
- line 225: // TODO: When we make Replicable name to be IComparable, we can remove the ToString call from here.
- line 239: // TODO: When we make Replicable name to be IComparable, we can remove the ToString call from here.
- line 423: // TODO: Need setitem support on ItemCollection
- line 517: // TODO: Do we need to wire up set-cookie header? and also set cookie expiry?
- line 581: // TODO: We do not support session expiry currently
- line 816: /// TODO: Make this async. The asynchrony needs to be plumbed all the way through. WCF interfaces don't support
src/prod/src/managed/Api/src/System/Fabric/Management/ImageBuilder/SingleInstance/ApplicationPackageGenerator.cs (7 lines):
- line 234: // TODO: Windows behavior and behavior for process isolation should change to match this once hosting changes are made to make this consistent
- line 581: // TODO: Windows behavior should change to match this once hosting changes are made to make this consistent
- line 622: // TODO: Windows behavior should change to match this once hosting changes are made to make this consistent
- line 687: // TODO: Windows behavior should change to match this once hosting changes are made to make this consistent
- line 794: // TODO: what is port is not specified?, private network should be treated same as open.
- line 1124: // TODO: #11905876 Integrate querying SecretStoreService in Hosting
- line 1125: // TODO [dragosav]: look into aligning the type of the variable/setting type - env vars
src/prod/src/Management/RepairManager/RepairManagerServiceReplica.cpp (7 lines):
- line 837: // TODO replace with a structured event
- line 925: // TODO replace with a structured event
- line 1011: // TODO replace with a structured event
- line 1094: // TODO replace with a structured event
- line 1192: // TODO replace with a structured event
- line 1676: // TODO continuation token
- line 1721: // TODO: if paging status not null, should ask for next page
src/prod/src/ktllogger/sys/ktlshim/OverlayRvdLog.cpp (7 lines):
- line 1491: // TODO: De-Staging ?
- line 1506: // TODO: De-Staging ?
- line 1520: // TODO: De-Staging ?
- line 1548: // TODO: De-Staging ?
- line 1557: // TODO: De-Staging ?
- line 1568: // TODO: De-Staging ?
- line 1575: // TODO: De-Staging ?
src/prod/src/managed/FabricBRS/src/System/Fabric/BackupRestore/Service/BackupRestoreServiceImpl.cs (7 lines):
- line 217: throw new ArgumentException(); // TODO: Change this with appropriate exception
- line 227: throw new ArgumentException(); // TODO: Change with the OTher exception
- line 253: FolderPath = String.Empty, // TODO: This should be constructed
- line 264: FolderPath = String.Empty, // TODO: This should be constructed
- line 280: if (currentRestoreStatus.RestoreStatusState == RestoreState.Accepted) //TODO Check for Guid
- line 334: //TODO: Add check for each request by Guid
- line 378: backupPartitionStatus.OperationId.Equals(operationResult.OperationId)) // TODO : Also check for Guid for the request
src/prod/src/BlockStore/Service/Native/src/CBlockStoreService.cpp (6 lines):
- line 7: // TODO: Review this.
- line 584: // TODO: Remove this once the underlying infrastructure delivers the same capability
- line 676: // TODO: Fix the variable name here
- line 851: // TODO: We should have a retry count and fail if that is crossed.
- line 1268: // TODO: Use FabricReplicaRole enum
- line 1277: // TODO: Should we throw an exception here if the registration fails?
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Log/LogManager.LogicalLog.cs (6 lines):
- line 594: // TODO: Remove this when stabilized
- line 599: // TODO: Remove this when stabilized
- line 626: // TODO: Remove this when stabilized
- line 1062: // TODO: Work out Reuse() for read approach
- line 1190: // TODO: Come up with a better reuse approach; unseal/reuse if sizeOfUserDataSealed == 0
- line 1450: // TODO: Once WF Replicator folks are engaged - nail down actual behavior
src/prod/src/managed/powershell/MockClusterConnection.cs (6 lines):
- line 1526: // TODO: verify deploymentName
- line 2746: // TODO validate task params
- line 2764: // TODO validate task params
- line 2782: // TODO validate task params
- line 2820: // TODO validate params
- line 2844: // TODO validate task params
src/prod/src/data/tstore/PartitionSearchKey.h (6 lines):
- line 23: throw ktl::Exception(K_STATUS_OBJECT_NOT_ATTACHED); //TODO: Pick the right status for NotImplementedException
- line 28: throw ktl::Exception(K_STATUS_OBJECT_NOT_ATTACHED); //TODO: Pick the right status for NotImplementedException
- line 33: throw ktl::Exception(K_STATUS_OBJECT_NOT_ATTACHED); //TODO: Pick the right status for NotImplementedException
- line 38: throw ktl::Exception(K_STATUS_OBJECT_NOT_ATTACHED); //TODO: Pick the right status for NotImplementedException
- line 43: throw ktl::Exception(K_STATUS_OBJECT_NOT_ATTACHED); //TODO: Pick the right status for NotImplementedException
- line 48: throw ktl::Exception(K_STATUS_OBJECT_NOT_ATTACHED); //TODO: Pick the right status for NotImplementedException
src/prod/src/managed/Api/src/System/Fabric/Management/ImageBuilder/ImageBuilder.cs (6 lines):
- line 484: // TODO: This should return the merged file once we support it.
- line 497: // TODO: This should return the merged file once we support it.
- line 587: // TODO: This should return the merged file once we support it.
- line 832: // TODO: pass time to extract method.
- line 1334: // TODO: Once FabricTest has been modified to generate InfrastructureManifest.xml file, we should throw if the file
- line 1522: // TODO: Read and merge the compose file and overrides file.
src/prod/src/Reliability/Failover/ra/FailoverUnit.cpp (6 lines):
- line 1448: // TODO: Refactor - updating remote replica state should be intelligent enough to not require the function below
- line 2462: // TODO: This can be removed but being kept for compatibility
- line 2942: Now build completes for one replica which then gets deactivation epoch updated (TODO: No need for deactivation epoch update in swap during phase 0)
- line 3513: // TODO: Merge with the RA state and send an updated DoReconfig message
- line 4217: TODO: Replace Deactivate message with the force flag with ClientReportFault
- line 5566: // TODO: Move this as a property of the name?
src/prod/src/Reliability/LoadBalancing/Checker.cpp (6 lines):
- line 1202: // TODO: call GetTargetNodeForUnplacedReplica directly for each constraint
- line 1297: // TODO: call GetTargetNodeForUnplacedReplica directly for each constraint
- line 1695: // TODO: correcting constraints based on static constraints
- line 1798: // TODO: use constraint to implement swap-only?
- line 1818: // TODO: use constraint to implement overflow to underflow only?
- line 1857: // TODO: use constraint to implement overflow to underflow only?
src/prod/src/data/tstore/ConsolidationManager.h (6 lines):
- line 110: Common::TimeSpan::FromMilliseconds(256 * 1000), // TODO: make constant
- line 734: // TODO: trace
- line 941: // TODO: check on perf testing for this allocation
- line 1057: // TODO: trace
- line 1141: // TODO: This assumes that sweep only applies to SPtr
- line 1143: // TODO: Check if file ID is present in metadatatable (debug only)
src/prod/ktl/src/tools/DiskPerfTool/DiskPerfTool.cpp (6 lines):
- line 512: Status = _File->Transfer(KBlockFile::IoPriority::eForeground, // TODO: Allow bg writes too
- line 1168: Status = _File->Transfer(KBlockFile::IoPriority::eForeground, // TODO: Allow bg writes too
- line 1639: #if !defined(PLATFORM_UNIX) // TODO: Port this code
- line 1762: // TODO: include all parameters for the run
- line 2040: #if !defined(PLATFORM_UNIX) // TODO: Port this code
- line 2062: // TODO: Dump results to XML ??
src/prod/src/Common/CryptoUtility.cpp (6 lines):
- line 382: return; // LINUXTODO implement CRL recheck and remove PurgeExpired_LockHeld
- line 1422: LPCSTR algorithmOid, // algorithmOid is ignored. //LINUXTODO implement other algorithms.
- line 3044: return ErrorCodeValue::NotImplemented; // LINUXTODO implement create cert from key.
- line 3098: return ErrorCodeValue::NotImplemented; // LINUXTODO implement create cert from key.
- line 3155: return ErrorCodeValue::NotImplemented; // LINUXTODO implement create cert from key.
- line 3256: return L""; // LINUXTODO implement create cert from key.
src/prod/src/reliablemessaging/ReliableSessionManager.cpp (6 lines):
- line 83: // TODO: do we need to handle the case that we just created the singletonEnvironment_ and should shut it down?
- line 166: // TODO: do we need a DeleteOutboundSession API? Will that close automatically? Perhaps at the managed level ..
- line 342: // TODO: currently we just abort all inbound sessions, need a more nuanced shutdown semantic if sessions are used standalone, i.e., not via streams
- line 373: // TODO: currently we just abort all outbound sessions, need a more nuanced shutdown semantic if sessions are used standalone, i.e., not via streams
- line 441: // TODO: No messaging resources active, should we shut down and delete the transport? For now, no, it doesn't save much
- line 442: // TODO: do we erase the singleton environment now if myEnvironment_ is the singleton?
src/prod/src/Management/HttpTransport/ClientRequest.cpp (6 lines):
- line 154: // TODO: need to come up with a better implementation(base class) to do this transparently
- line 577: // TODO: This logic should be changed to use asyncoperation multiroot
- line 598: // TODO: This logic should be changed to use asyncoperation multiroot
- line 623: // TODO: This logic should be changed to use asyncoperation multiroot
- line 737: // TODO: This logic should be changed to use asyncoperation multiroot
- line 766: // TODO: This logic should be changed to use asyncoperation multiroot
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReliableMessaging/stream/OutboundSessionDriver.cs (6 lines):
- line 24: // TODO: track when this is disposed for asserts
- line 147: /// TODO: this layer must catch all exceptions and decide what to do with them -- lower layer functions like ResolveAndNormalizeTargetPartition
- line 197: // TODO: should we refcount how many streams depend on this session?
- line 315: // TODO: find a way to push handling of this transient fault down into the managed wrapper for sessions
- line 316: // TODO: what happens if there is a session Abort? Or a failure of the partner?
- line 427: // TODO: do we need to worry about OutOfMemory exception?
src/prod/src/Reliability/Failover/ra/ReconfigurationAgent.cpp (5 lines):
- line 603: // TODO: Fix this
- line 1248: // TODO: The RA should move to using the same activity id as the rest of the product
- line 1533: // TODO: Refactor - this should be moved out of this file
- line 2232: // TODO: This is to be refactored still
- line 3361: // TODO: See if we can improve this - it effectively implies there is a ReopenSuccessWaitInterval timeout
src/prod/ktl/src/src/ktlpal.cpp (5 lines):
- line 38: // TODO: Add api to enable this dynamically
- line 543: // TODO: Figure out the right place to send all of this output. Is
- line 825: //** TODO: To be merged with current PAL CreateThread imp
- line 1491: // TODO: The rest of lpSystemInfo
- line 1916: // TODO Kernel mode
src/prod/src/data/tstore/VolatileStoreCopyStream.h (5 lines):
- line 43: // TODO: make configurable
- line 131: ULONG32 CopyProtocolVersion = 2; // TODO: make constant
- line 152: // TODO: Trace
- line 254: // TODO: Trace
- line 323: // TODO: Actual TTL; left here as an example
src/prod/src/reliablemessaging/ComReliableMessaging.cpp (5 lines):
- line 198: // TODO: let service logic handle this -- don't ever erase sessionManager_
- line 511: // TODO: this is an opportunity to release the openOp if we want to recycle it
- line 521: // TODO: this looks more like something to Assert
- line 564: // TODO: this is an opportunity to release the closeOp if we want to recycle it
- line 709: // TODO: Create a specialized trace
src/prod/src/data/logicallog/LogTestBase.cpp (5 lines):
- line 1646: // TODO: Fix buffer1K to be correct size. Add 1 to work around bug in KFileStream::WriteAsync
- line 1833: // TODO: replace 32 with 1024. Workaround for Rich's bug
- line 1851: // TODO: Remove this when I feel good about the math
- line 2076: // TODO: replace 32 with 1024 when Rich fixes
- line 2093: // TODO: Remove this when I feel good about the math
src/prod/src/data/utilities/StatusConverter.h (5 lines):
- line 19: // TODO: ForceInline and Inline cause build warning LNK4221.
- line 26: // TODO: ForceInline and Inline cause build warning LNK4221.
- line 40: // TODO: ForceInline and Inline cause build warning LNK4221.
- line 52: // TODO: ForceInline and Inline cause build warning LNK4221.
- line 59: // TODO: ForceInline and Inline cause build warning LNK4221.
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/BackupManager/BackupManager.cs (5 lines):
- line 335: // TODO: Hosting to provide us with a backup folder.
- line 433: // TODO: This could be a provisional trace.
- line 456: // TODO: This should include duration of each stage.
- line 1055: // TODO: Get own structured trace.
- line 1061: // TODO: Get own structured trace.
src/prod/src/Lease/linux/LeasLayr.cpp (5 lines):
- line 206: // TODO check why it is nullptr.
- line 2797: // Lease Agent was found (TODO:linux specific logic)
- line 3297: // TODO linux only logic, the real ttl is returned and out put to a
- line 4346: //TODO shuxu
- line 6362: //TODO shuxu
src/prod/src/reliablemessaging/ReliableSessionRingBuffer.cpp (5 lines):
- line 85: // TODO: most of this can be done with a Read lock -- Flush requires a Write lock
- line 429: /* TODO: prior code to be deleted
- line 435: // TODO: this is going through transport stack delete callback, and all the way to the service completing the Begin/End async
- line 641: /* TODO: prior code to be deleted
- line 647: // TODO: this is going through transport stack delete callback, and all the way to the service completing the Begin/End async
src/prod/src/data/tstore/SortedSequenceMergeEnumerator.h (5 lines):
- line 65: // TODO: dispose enumerator if it is empty
- line 78: // TODO: Check against key filter
- line 124: // TODO: Dispose enumerator if it is empty
- line 164: // TODO: Test against key filter
- line 173: // TODO: TryPush the enumerator for de-duplication
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/DynamicStateManager.cs (5 lines):
- line 698: // TODO: Once we support custom state providers, add retry for failed state providers.
- line 1176: // TODO: Post GA, move this logic into the lock class.
- line 1729: // TODO: Preethas This is a workaround until state manager supports hierarchy. Once hierarchy is supported,
- line 2286: // TODO: RDBug 10631157:Add idempotent operation assert for CreateLSN/DeleteLSN check
- line 3533: // TODO #10279752: Separate redo out of ReplicationMetadata. Making
src/prod/src/ktllogger/sys/ktlshim/GlobalObj.h (5 lines):
- line 2138: // TODO: Move this into a config or make it a percentage
- line 3298: static const ULONG _MinimumFirstReadCompleteSize = ((128 * 1024) - 0x110); // TODO: Pick a number
- line 3555: LONGLONG _DedicatedWriteBytesOutstandingThreshold; // TODO: Make configurable
- line 3806: return(BaseSize / 4); // TODO: we need to make this more intelligent
- line 5793: KNodeList _GateList; // TODO: move these
src/prod/shared/serialization/src/FabricSerializableStream.cpp (5 lines):
- line 96: // TODO: make empty array
- line 118: // TODO: param of extension buffers
- line 126: // TODO: new error code
- line 1398: // TODO: flags?
- line 1414: // TODO: increment index, do we need interlocked or is volatile good enough since this should be single threaded?
src/prod/src/Management/ClusterManager/ClusterManagerReplica.cpp (5 lines):
- line 840: // TODO:
- line 967: // TODO: Consider remove validation for speed. Commiting all the contexts in one transaction would fail in the end anyway.
- line 1821: //TODO: ban creating under compose application
- line 6271: // TODO: Consistency: Make the name to uri translation happen only on the server side. Client side should be passing the name without fabric:
- line 6390: // TODO: consistency. in passing Uri or name from client - it should be either name or uri.
src/prod/src/managed/Autopilot/ServiceFabricAutopilotAgent/ServiceFabricLocalNodeManager.cs (5 lines):
- line 111: // TODO: registry key not available yet
- line 118: // TODO: [General] surface fatal errors outside the agent as AP health report.
- line 241: // TODO: After current xcopyable issue is fixed, update the pattern here.
- line 243: // TODO: [General] disposal of ServiceController
- line 618: // TODO: validation against schema
src/prod/src/BlockStore/Service/Native/src/CBlockStoreRequest.cpp (5 lines):
- line 7: // TODO: Review this.
- line 476: // @TODO - Read the key
- line 495: // TODO: Read into readBuffer directly instead of using readData.
- line 783: // TODO: Remove it or change it to TRACE_NOISE
- line 899: // TODO: re-implement to avoid resize here and end which need to modify function
src/prod/src/ktllogger/sys/ktlshim/KtlLogMarshalKernel.cpp (5 lines):
- line 405: // TODO: REMOVE AFTER DEBUGGING
- line 408: // TODO: REMOVE AFTER DEBUGGING
- line 2730: // TODO: Add a unit test case where a huge records array is returned
- line 4644: // TODO: REMOVE WHEN DEBUGGED
- line 4646: // TODO: REMOVE WHEN DEBUGGED
src/prod/src/Store/TSChangeHandler.cpp (5 lines):
- line 291: DateTime::Zero, // TODO: last modified
- line 402: // TODO: TStore does not support Reset()
- line 438: // TODO: TStore does not support Reset()
- line 584: DateTime::Zero, // TODO: last modified
- line 913: // TODO: Make Noise trace
src/prod/src/BlockStore/Service/Native/src/BlockStorePayload.cpp (4 lines):
- line 8: // TODO: Review this.
- line 199: // TODO: Payload buffer allocation here is being done again even though the
- line 202: // TODO: We should have a statically allocated buffer that can be sent for failure cases.
- line 275: // TODO: We should look into fixing this.
src/prod/src/Reliability/Failover/ra/Test.StateMachine.cpp (4 lines):
- line 3198: // TODO: Enable this later
- line 3204: // TODO: Enable this later
- line 3611: /* TODO: Disable temporarily for force delete
- line 7670: // TODO: File bug to fix this
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/OperationProcessor.cs (4 lines):
- line 175: // TODO: Temporary double check.
- line 625: // TODO: Temporary assert. Should be removed later.
- line 680: // TODO: Temporary assert. Should be removed later.
- line 735: // TODO: Trace.
src/prod/src/Federation/SiteNode.cpp (4 lines):
- line 142: // TODO: If SiteNode must do any other processing on these events consider making a general method to move ProcessRoutedMessageHoldingList to
- line 635: // TODO: add node failure reason
- line 891: // TODO: handle other Federation faults
- line 990: //TODO: Wait for pending requests to complete
src/prod/src/managed/FabricFAS/src/system/fabric/faultanalysisservice/ClusterAnalysisService/ClusterAnalysisApiHandler.cs (4 lines):
- line 153: // this start again. TODO: Think of better of supporting this scenario.
- line 157: throw new Exception("TODO ::: Analysis is already Running. Please Call Stop and then start");
- line 204: // TODO: What to do in this case, is throwing an exception the right way to respond to user API?
- line 310: // Re-Launch CI. TODO Have some policy to restart only X Times and then crash the process.
src/prod/src/Federation/RoutingTable.cpp (4 lines):
- line 699: // TODO: move logic to test code after code is stable.
- line 702: // TODO: compact the ring when the ring exceed the capacity
- line 1264: //TODO: possible to always transfer one token only?
- line 3123: //TODO: verify if this is an assertion I can make
src/prod/ktl/src/src/kawipcpipe.cpp (4 lines):
- line 349: // TODO: Do not use a dedicated thread but instead use async
- line 476: // TODO: Rather than use a timeout, use ppoll and have this get
- line 679: // TODO: Do not use a dedicated thread but instead use async
- line 850: // TODO: Rather than use a timeout, use ppoll and have this get
src/prod/src/managed/DCA/product/plugins/lttproducer/LttTraceProcessor.cs (4 lines):
- line 207: // TODO This eventually needs to be moved to its own Consumer so event is not decoded more than once.
- line 234: // TODO - to be removed after transitioning for structured traces in Linux
- line 395: // TODO - make this a warning
- line 434: // TODO - Uncomment code below when totally transitioned to structured traces
src/prod/src/data/txnreplicator/loggingreplicator/KLogManager.cpp (4 lines):
- line 404: // TODO: Consider moving into logical log
- line 433: // TODO: Consider moving into logical log
- line 482: // TODO: Workaround until GetOrAdd Semantics is added from log api
- line 483: // TODO: Consider moving into logical log
src/prod/src/managed/Api/src/System/Fabric/Common/RestartPartitionAction.cs (4 lines):
- line 128: // TODO: Wait for some time so that the unreliable transport behavior can be read from the files.
- line 192: // TODO: Wait for some time so that the unreliable transport behavior can be read from the files.
- line 198: // TODO: Provide a way to clear all behaviors just in case.
- line 212: // TODO: Wait for some time so that the unreliable transport behavior can be read from the files.
src/prod/ktl/src/inc/kawipc.h (4 lines):
- line 660: // TODO: Since there is not yet first class support for sockets in the
- line 1598: // TODO: This can be enhanced with per client caches, processor
- line 1640: // TODO: This can be enhanced to allow chaining of multiple
- line 1652: // TODO: Figure out the right sizes
src/prod/src/managed/Api/src/System/Fabric/Management/fabricvalidator/ValueValidator.cs (4 lines):
- line 165: // TODO: remove when making DCA validator change
- line 188: // TODO: remove when making DCA validator change
- line 211: // TODO: remove when making DCA validator change
- line 235: // TODO: remove when making DCA validator change
src/prod/src/managed/fabricis/parallel/dll/CommandHandling/CoordinatorCommandProcessor.cs (4 lines):
- line 474: // TODO clean/scrub this map periodically
- line 478: foreach (var aa in allowActionMap.Get().Where(e => e.CreationTime < now - TimeSpan.FromHours(1))) // TODO expiry as config
- line 570: // TODO make this optional
- line 770: /// TODO - the above comment may not be true. investigate. Service Fabric Explorer scenario shouldn't be broken.
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Collections/DistributedDictionary.cs (4 lines):
- line 479: /// TODO: keep the count in memory.
- line 495: /// TODO: keep the count in memory.
- line 832: // TODO: Today TStore only supports exclusive lock for operations that are ReadOrWrite.
- line 901: // TODO: Today TStore only supports exclusive lock for operations that are ReadOrWrite.
src/prod/src/data/tstore/MetadataManager.cpp (4 lines):
- line 56: // TODO: KWString should be replaced by KString once ktl apis are fixed
- line 221: // TODO: KWString should be replaced by KString once ktl apis are fixed
- line 406: // TODO: KWString should be replaced by KString once ktl apis are fixed
- line 560: -1, 0, // TODO: Replace with constants in a way that won't break Linux build
src/prod/src/inc/clr/corinfo.h (4 lines):
- line 178: TODO: Talk about initializing strutures before use
- line 456: // TODO: Clean this up together with some other change to version the JIT-EE interface
- line 1967: // @TODO: put this in the CORINFO_EE_INFO data structure
- line 3097: // TODO: jit64 should be switched to the same plan as the i386 jits - use
src/prod/src/Federation/PointToPointManager.cpp (4 lines):
- line 55: // TODO: Make Federation use the PToP actor map
- line 174: // TODO: we could check to make sure the request is still in the context table before sending
- line 175: // TODO: all routing headers should already be added but we could do checks
- line 471: // TODO: refactor to SendFederationFaultMethod
src/prod/src/ktllogger/sys/ktlshim/driver/nonpnp.cpp (4 lines):
- line 1002: // TODO: REMOVE WHEN DEBUGGED
- line 1004: // TODO: REMOVE WHEN DEBUGGED
- line 1025: // TODO: REMOVE WHEN DEBUGGED
- line 1027: // TODO: REMOVE WHEN DEBUGGED
src/prod/src/Transport/SecurityContextSsl.cpp (4 lines):
- line 202: //LINUXTODO consider avoid copying
- line 236: auto read = BIO_read(outBio_, output.pvBuffer, output.cbBuffer);//LINUXTODO avoid memory copy
- line 473: //LINUXTODO do we need to clean up inBio_ or SSL_read will clean up?
- line 672: //LINUXTODO use SSL_get_verify_result to avoid duplicate chain validation
src/prod/src/BlockStore/SFBDMiniport/SFBDMiniport/SFBDVMiniport.c (4 lines):
- line 350: // TODO: Log this
- line 404: // TODO: Log this.
- line 870: // TODO: Review these (and any additional SRBs that need to be supported)
- line 1789: // TODO: When doing actual DMA, we do not need to fetch the kernel virtual address
src/prod/src/inc/clr/utilcode.h (4 lines):
- line 524: // TODO: This should always use the names
- line 947: // TODO: All HRESULT_FROM_WIN32(GetLastError()) should be replaced by calls to
- line 2642: // @TODO: Fix this by adding an abstract function Hash() which must be implemented
- line 5349: // operator &. TODO: probe with a static_assert?
src/prod/src/data/txnreplicator/loggingreplicator/BackupLogFile.cpp (4 lines):
- line 85: // TODO: #9165663: KTL SetSystemIoPriorityHintAsync is requried.
- line 203: // TODO: #9165663: KTL SetSystemIoPriorityHintAsync is requried.
- line 286: // TODO: #9165801 : Eliminate copy 2 by aligning the allocations.
- line 642: // TODO: #9166098: Take in cancellation token.
src/prod/src/managed/fabricis/serial/dll/Coordinator/WindowsAzureInfrastructureCoordinator.cs (4 lines):
- line 31: /// TODO - move common constants to a common class.
- line 454: // TODO: track and clear cancellation token registration?
- line 1557: // TODO: Dampen cancellation by looking at this.IsLastKnownJobStateRecentlyUpdated()
- line 2793: // TODO: Handle cases when instance name cannot be mapped
src/prod/src/inc/clr/holder.h (4 lines):
- line 149: // TODO: Find a way to enable this check.
- line 680: // @TODO: Due to prefast template problems, implementations of the DoNothing macro have been changed
- line 1185: //@TODO: Dangerous default value. Some Win32 functions return INVALID_HANDLE_VALUE, some return NULL (such as CreatEvent).
- line 1470: //@TODO: Would be good to add runtime validation that the return value is used.
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReliableMessaging/stream/StreamWireMessages.cs (4 lines):
- line 230: /// TODO: Verify supported versions
- line 231: /// TODO: Verify support type ex.
- line 232: /// TODO: the exceptions here need to be Asserts?
- line 268: // TODO: Check if we need to throw instead, as this replica
src/prod/src/Reliability/LoadBalancing/PlacementAndLoadBalancing.cpp (4 lines):
- line 355: // TODO: do we need to keep the capacityratio and capacity data If a node is down?
- line 3860: // TODO: should we use Now as timestamp?
- line 4144: // TODO: tracing already in the PLBScheduler::RefreshAction, move the tracing to here
- line 5848: //TODO: add code to slowdown requests to FM
src/prod/src/Hosting2/VersionedServicePackage.cpp (4 lines):
- line 162: // TODO: To optimize explicitly cancel the pending operations.
- line 1536: //codePackage->Abort(); // TODO: This should not be called.
- line 2910: // TODO: Add mopre validation to make sure our rollout version compute logic
- line 3520: bool IsCurrentStateValidForRestart(uint64 & currState) // TODO: Should we include Analyzing state as valid state.
src/prod/src/ktllogger/sys/ktlshim/OverlayStream.cpp (4 lines):
- line 1679: // TODO: Remove when stabilized
- line 1687: // TODO: Remove when stabilized
- line 6017: // TODO: Remove me when code is fully stabilized
- line 7414: // TODO: How to handle errors ?
src/prod/src/reliablemessaging/ReliableSessionRingBuffer.h (4 lines):
- line 16: Opened, // TODO: this state currently not used -- probably should be
- line 72: // TODO: inline?
- line 108: // TODO: use the Unsafe naming convention for all methods that assume appropriate locks are held
- line 210: // TODO: consider making this max window size and making window size dynamic
src/prod/ktl/src/src/ksocket.cpp (4 lines):
- line 382: // TODO error -> ntstatus
- line 2969: // TODO success but null address
- line 4676: // TODO copying to a storage first involves a double copy
- line 4677: // TODO what's the right way to IPv6 enable this
src/prod/src/managed/Api/src/System/Fabric/Testability/Client/PowershellFabricClient.cs (3 lines):
- line 64: // TODO: handle remaining client settings parameters
- line 393: // TODO all replica and partition selector overloads
- line 2687: // TODO: this is not correct; if the application contains map with specific items for this service type, that policy should be used.
src/prod/src/data/tstore/StoreCopyStream.cpp (3 lines):
- line 182: // TODO: This method should be async once SM fixes the interface to call async dispose or close
- line 183: // TODO: Once async, co_await CloseAsync
- line 387: // TODO: Trace
src/prod/src/query/GetReplicaResourceListQuerySpecification.cpp (3 lines):
- line 15: // TODO: find out how to track original activity id.
- line 117: // TODO: More replica within 1 CGS/CG on the same node.
- line 187: // TODO: Should we enumerate based on codePackageResult? The mismatch could happen if service is upgrading and node view vs. CM view is different.
src/prod/src/data/interop/ReliableCollectionService/StatefulServiceBase.cpp (3 lines):
- line 19: // TODO: Make this thread-safe
- line 200: // TODO leaking
- line 227: //TODO lifetime of txReplicator
src/prod/src/managed/fabricis/parallel/dll/Helpers/CoordinatorHelper.cs (3 lines):
- line 38: // TODO we can get this with bit-shifts. but okay for now.
- line 250: // TODO consider adding JobStatus == JobStatusEnum.Executing check or deleting this comment once MR team
- line 550: // TODO should this be RoleInstancesToBeImpacted or JobStep.CurrentlyImpactedRoleInstances?
src/prod/src/Hosting2/ProcessActivationManager.cpp (3 lines):
- line 1346: true, // TODO: This should be propagated based on the requireSFRuntime flag.
- line 1713: // [subiswal]TODO: Handle sharing violation errors and schedule copy at reboot
- line 6042: // TODO: Should add some retry logic on unmap failure
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/KtlLogManager.cs (3 lines):
- line 45: // TODO: Harvest this value from cluster manifest or somewhere
- line 440: // TODO asnegi: RDBug #10278280 Adding 0xC0000225 as it is expected HResult for exception. However, it seems that it is not being
- line 548: // TODO: Exception/HRESULT work needs to be finished: catch (FabricElementNotFoundException)
src/prod/src/FabricNode/FabricNode.cpp (3 lines):
- line 1693: // TODO: Since fabricclient constructed here no goes via tcp transport, this should be changed to use
- line 3019: //TODO: Either make this an instance method or ensure that the working directory is passed in to use
- line 3077: //TODO: Add cert update handling in Hosting to refresh certs in container application host
src/prod/src/Management/RepairManager/RepairRestorationAsyncOperation.cpp (3 lines):
- line 63: // TODO replace with a structured event
- line 120: // TODO Refactor prepare/restore async ops to be polymorphic based on impact type
- line 379: // TODO replace with a structured event
src/prod/src/Management/BackupRestore/BA/BackupRestoreAgentProxy.cpp (3 lines):
- line 198: // TODO: Handle failure.
- line 244: // TODO: Handle failure.
- line 419: // TODO: Create an async operation for incoming requests
src/prod/src/Management/HttpTransport/RequestMessageContext.cpp (3 lines):
- line 154: // TODO: If disconnect_ is specified in this case, return error.
- line 162: // TODO: KTL doesnt support sending a null buffer with just the flag. Check and fix it.
- line 476: // TODO: This functionality should be added to the KTL layer
src/prod/src/reliablemessaging/ReliableSessionAsyncOperations.cpp (3 lines):
- line 131: // TODO: if we want to avoid tombstones for sessions we must tolerate this situation as a no-op (fail the Start) for ProtocolResponse messages
- line 294: // TODO: check if Transport tolerates empty buffers--do we even want to allow those?
- line 611: // TODO: make a simple KQueue of these session-specific DequeueOperations for reuse
src/prod/src/managed/ClusterAnalysis/AnalysisCore/ClusterQuery/ClusterQuery.cs (3 lines):
- line 244: /// TODO: Remove duplication from application name function
- line 248: // TODO Reduce duplicate logic in GetService/GetApp functions.
- line 297: // TODO: Clean up these multiple Ifs.
src/prod/src/Lease/linux/LeaseAgent.cpp (3 lines):
- line 523: //TODO shuxu
- line 2518: // TODO - work around recreated relationship for termination message
- line 4047: //TODO shuxu
src/prod/src/managed/Api/Dlls/Microsoft.ServiceFabric.ClusterManagementCommon/ClusterManifestBuilder.cs (3 lines):
- line 350: //// TODO: Implement smarter port selection to avoid conflicts with ports specified by the user
- line 541: /// TODO: refactor to combine the two methods
- line 608: /// TODO: refactor to combine the two methods
src/prod/src/Reliability/Replication/SecondaryReplicator.cpp (3 lines):
- line 1158: // TODO: This check is safe since Failover gurantee's that a primary will never cancel the build and restart it without either the idle restarting or primary itself restarting
- line 1159: // TODO: If idle restarts, we are fine. If primary restarts, its address changes so we are fine.
- line 2293: // TODO: Remove these 2 fields before release after running enough coverage tests to assert this
src/prod/src/managed/Autopilot/ServiceFabricAutopilotAgent/ServiceFabricAutopilotAgent.cs (3 lines):
- line 233: // TODO: when adding dynamic topology support, change state machine transition here.
- line 294: // TODO: this only applies when DynamicTopologyUpdateMode == None or OnNodeConfigurationOnly.
- line 330: // TODO: consider assert instead of an error message
src/prod/src/ServiceModel/ListPager.cpp (3 lines):
- line 85: // TODO: this should return something other than InvalidArg, so the calling query can give users a more useful error (ie. increase max message size)
- line 94: // TODO: Make sure the continuation token fits
- line 135: // TODO: the tracing isn't from the component itself anymore. Does that matter?
src/prod/src/managed/Microsoft.ServiceFabric.FabricTransport.V2/Client/FabricTransportClient.cs (3 lines):
- line 57: //TODO: Remove this check after Bug :1225032 gets resolved
- line 82: //TODO: Remove this check after Bug :1225032 gets resolved
- line 110: //TODO: Remove this check after Bug :1225032 gets resolved
src/prod/src/Reliability/Failover/ra/FailoverUnit.h (3 lines):
- line 363: // TODO: When CreateLocalReplica is properly refactored this can be made private
- line 366: // TODO: make private when When UC handling is refactored
- line 453: // TODO: To be made private
src/prod/src/data/interop/ReliableCollectionRuntime/dll/ReliableCollectionRuntime.h (3 lines):
- line 611: char *Value; // @TODO - Use BufferHandle for batching
- line 620: char *Value; // @TODO - Use BufferHandle for batching
- line 633: // @TODO - NYI. Need to decide if store is implementing ClearAll.
src/prod/src/reliablemessaging/ReliableSessionManager.h (3 lines):
- line 126: // TODO: reconsider this assert: this can happen in a race between session manager abort and an incoming session open request
- line 157: // TODO: reconsider this assert: this can happen in a race between session manager abort and a regular session close process
- line 166: // TODO: should we keep track of source service partition Address() from ISendTarget provided by transport
src/prod/src/Management/ApplicationGateway/Http/ParsedGatewayUri.cpp (3 lines):
- line 172: // TODO: Trace
- line 194: // TODO: Do remaining time calculation and update this timeout when
- line 292: // TODO: Remove the hardcoding from here and make this piece generic for services to register a entity and forward all URLs under the same to them.
src/prod/ktl/src/logger/src/KtlLogRecovery.cpp (3 lines):
- line 709: // TODO: Define a new failure report routine
- line 1064: // TODO: Get rid of the extra KDbgCheckpointWData
- line 2540: // TODO: Need to dump out why the record isn't valid
src/prod/src/Management/BackupRestore/BA/BAMessage.h (3 lines):
- line 144: SetBAHeaders(*message, Transport::Actor::BA, action, activityId); // TODO: Using default BA here
- line 154: SetBAHeaders(*message, Transport::Actor::BA, action); // TODO: Using default BA here
- line 164: SetBAHeaders(*message, Transport::Actor::BA, action, activityId); // TODO: Using default BA here
src/prod/src/Management/ClusterManager/DeleteSingleInstanceDeploymentContextAsyncOperation.cpp (3 lines):
- line 125: TimeSpan::FromMinutes(2), // TODO: This should be a configurable timeout within max val.
- line 431: // the rollout status for this need not be set to DeletePending here. TODO: Test/check
- line 484: // the rollout status for this need not be set to DeletePending here. TODO: Test/check
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReliableMessaging/stream/PartitionKey.cs (3 lines):
- line 280: // TODO: revisit Uri equality -- may not be compatible with the unmanaged definition
- line 330: /// TODO:Check if there is enough room in the stream
- line 361: /// TODO: Check if ToString() can suffice for this need.
src/prod/src/managed/ClusterAnalysis/AnalysisCore/Insights/Agents/AnalysisScheduler.cs (3 lines):
- line 136: // TODO: Do Atomically.
- line 171: // TODO : Improve this Logic.
- line 437: // TODO: Today we expect analysisConsumer to be very light weight. In future, we can potentially
src/prod/src/managed/Api/src/System/Fabric/Common/InvokeQuorumLossAction.cs (3 lines):
- line 138: // TODO: Wait for some time so that the unreliable transport behavior can be read from the files.
- line 198: // TODO: Wait for some time so that the removal of this unreliable transport behavior can be read from the files.
- line 226: // TODO: Wait for some time so that the removal of this unreliable transport behavior can be read from the files.
src/prod/src/data/interop/ReliableCollectionRuntimeImpl/DictionaryChangeHandler.cpp (3 lines):
- line 69: // @TODO - Change this to a iterator based batch interface
- line 98: // @TODO - There is no way to tell client that we can't send the notification - need to log
- line 105: // @TODO - There is no way to tell client that we can't send the notification - need to log
src/prod/src/client/FabricClientImpl.cpp (3 lines):
- line 3552: // TODO get the description with the status.
- line 6498: // TODO: scope should be a const reference, but that requires making entire JSON writer const
- line 10282: error = ErrorCodeValue::InvalidOperation; // TODO: bharatn: Better errorcode
src/prod/src/Common/TraceEvent.h (3 lines):
- line 115: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 197: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 530: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Collections/DistributedQueue.cs (3 lines):
- line 547: // TODO: Add tracing here.
- line 729: // TODO: Add tracing here.
- line 1319: // TODO: Consider having the LongByteConverter as static.
src/prod/src/Management/ClusterManager/DeleteComposeDeploymentContextAsyncOperation.cpp (3 lines):
- line 180: TimeSpan::FromMinutes(2), // TODO: THis should be a configurable timeout within max val.
- line 462: // the rollout status for this need not be set to DeletePending here. TODO: Test/check
- line 515: // the rollout status for this need not be set to DeletePending here. TODO: Test/check
src/prod/src/ktllogger/sys/ktlshim/overlaylog.cpp (3 lines):
- line 1499: // TODO: Consider if these really need to be returned
- line 1546: // TODO: Remove when stabilized
- line 1556: // TODO: Remove when stabilized
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReplicatedStore/DifferentialStore/TStore.cs (3 lines):
- line 558: // TODO: Currently this method is not called by anyone in the production code.
- line 4199: // TODO: Improve code sharing in the code below after sweep algorithm is done.
- line 7431: TODO: Add configuration to give all or at most one notification during undo per key.
src/prod/src/managed/Microsoft.ServiceFabric.Instrumentation/Tracing/Core/Reader/TraceRecordSession.cs (3 lines):
- line 19: /// TODO: Add more details like Time Taken, Traces Lost etc.
- line 171: // TODO : Do dispatching in Batches over a separate Task
- line 203: /// TODO: Likley not needed. Will simply expose a task that can be awaited till done.
src/prod/src/managed/FabricCAS/ConfigHelper.cs (3 lines):
- line 395: // TODO: Bug#9728016 - Disable the bind until windows supports mounting file onto container
- line 457: // TODO: Bug#9728016 - Disable the bind until windows supports mounting file onto container
- line 503: // TODO: Bug#9728016 - Disable the bind until windows supports mounting file onto container
src/prod/src/managed/ClusterAnalysis/AnalysisCore/Insights/ClusterEntityExtractor.cs (3 lines):
- line 61: // TODO: Make Async
- line 84: /// Best Effort Today. TODO: Need to improve this but require the incoming event to have more information
- line 88: /// TODO: Look at moving all out the special casing complexity into Cluster query object itself.
src/prod/src/Common/TraceEvent.cpp (3 lines):
- line 70: // TODO: We are currently hard-coding the mask values, but this is not ideal
- line 214: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 261: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
src/prod/src/managed/powershell/TestUtility.cs (3 lines):
- line 617: // TODO: AreEqual(expect.CurrentUpgradeDomainProgress, actual.CurrentUpgradeDomainProgress);
- line 697: // TODO: AreEqual(expect.CurrentUpgradeDomainProgress, actual.CurrentUpgradeDomainProgress);
- line 716: // TODO:Verify.AreEqual(expect.Override, actual.override);
src/prod/src/Management/ApplicationGateway/Http/GatewayRequestHandler.cpp (3 lines):
- line 158: // TODO: Use a more appropriate timeout
- line 438: // 3. TODO: need to handle Connection header, TE: with trailers.
- line 439: // 4. TODO: Have a configuration to preserve the host header. If that is not set, then dont
src/prod/src/data/reliableconcurrentqueue/ReliableConcurrentQueue.TestBase.h (3 lines):
- line 18: // @TODO - This should inherit from StoreTestBase
- line 406: KSharedPtr CreateMockReplicator(FABRIC_REPLICA_ROLE role) //TODO: IStatefulServicePartition& partition
- line 459: // TODO: Create directories based on partition and replica ID
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/LogManager.cs (3 lines):
- line 345: // * TODO: Optimization: Old code established FileOptions.SequentialScan
- line 445: // TODO: Anurag: do we plumb c.token up?
- line 615: // TODO: Use a backup config for this flush size determination
src/prod/src/managed/Api/src/System/Fabric/Common/InvokeDataLossAction.cs (3 lines):
- line 153: // TODO: Wait for some time so that the unreliable transport behavior can be read from the files.
- line 218: // TODO: Wait for some time so that the removal of this unreliable transport behavior can be read from the files.
- line 287: // TODO: Wait for some time so that the removal of this unreliable transport behavior can be read from the files.
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReplicatedStore/Disk/ValueCheckpointFile.cs (3 lines):
- line 26: /// TODO: resolve this with BlockAlignedWriter.DefaultBlockAlignmentSize;
- line 177: // TODO: use memory stream pool here.
- line 249: // TODO: use memory stream pool here.
src/prod/src/BlockStore/SFBDMiniport/SFBDMiniport/scsi.c (3 lines):
- line 55: // TODO: Evaluate what other CDB commands need to be supported and go over the following implementations.
- line 453: // TODO: Apply Silo Context to the workitem that will run under System process context.
- line 464: /* TODO: Look into this. */
src/prod/src/Common/Trace.h (3 lines):
- line 100: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 113: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 151: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
src/prod/src/Hosting2/ContainerActivator.cpp (3 lines):
- line 2490: // TODO: The raw buffer may not always be multiplexed.
- line 3118: // TODO: Add some retry logic on unmap failures
- line 3347: // TODO: Add some retry logic on unmap failures
src/prod/src/data/reliableconcurrentqueue/ReliableConcurrentQueue.h (2 lines):
- line 483: // @TODO - Implement "Read your own write" by inspecting WriteSet
- line 491: // @TODO - Merge these two calls into one call
src/prod/src/Store/TSEnumeration.cpp (2 lines):
- line 98: // TODO: Used by Naming service
- line 108: // TODO: Used by managed KVS
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Log/LogManager.PhysicalLog.cs (2 lines):
- line 241: // TODO: Consider adding trace output when secondary exceptions occur
- line 344: // TODO: Consider adding trace output when secondary exceptions occur
src/prod/src/BlockStore/Linux/driver/src/sfblkdev.c (2 lines):
- line 194: //TODO: Does kernel_sendmsg ever return 0? If yes, we may run into
- line 241: // TODO: Overflow handling. Reboot scenario handling
src/prod/src/Management/HttpTransport/requestmessagecontext.linux.cpp (2 lines):
- line 39: //LINUXTODO: get full uri
- line 191: // TODO: Change this to a continuation
src/prod/src/data/interop/ReliableCollectionRuntimeImpl/TStoreCExports.cpp (2 lines):
- line 213: //TODO generic key types
- line 215: //TODO define custom value type
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Collections/IDistributedQueue.cs (2 lines):
- line 136: // TODO: Asynchronous T[] ToArray().
- line 137: // TODO: Asynchronous void CopyTo(T[] array, int index).
src/prod/src/Reliability/LoadBalancing/ServiceDomain.cpp (2 lines):
- line 1049: // find the root service, TODO: find the first placed root service
- line 1105: //include child partitions that are not in node1 or node2, TODO: consider replica on node1 or node2 for loadChange calculation
src/prod/src/inc/clr/pal/pal.h (2 lines):
- line 4970: // TODO: implement the version with only the acquire semantics
- line 4987: // TODO: implement the version with only the release semantics
src/prod/src/inc/clr/dacprivate.h (2 lines):
- line 603: // TODO: Add support to enumerate timers too.
- line 718: // TODO: This needs to be put on the Dac side.
src/prod/src/reliablemessaging/ReliableMessagingAsyncQueue.h (2 lines):
- line 60: // TODO: we need a consistent policy for when to track and use responseTarget and when to ignore it
- line 194: // TODO: we are keeping receiveOp in the DequeueOperation to keep it alive--need to revisit lifetime management interaction via COM refcounting
src/prod/src/managed/FabricUOS/exe/UpgradeOrchestrationMessageProcessor.cs (2 lines):
- line 242: string jsonConfigPath = Path.Combine(fabricDataRoot, System.Fabric.FabricDeployer.Constants.FileNames.BaselineJsonClusterConfig); // TODO: Needs to come from image store
- line 731: string jsonConfigPath = Path.Combine(fabricDataRoot, System.Fabric.FabricDeployer.Constants.FileNames.BaselineJsonClusterConfig); // TODO: Needs to come from image store
src/prod/src/data/txnreplicator/statemanager/TestOperation.cpp (2 lines):
- line 66: // TODO: Add support for undo verification.
- line 69: // TODO: Add support for operationContext verification
src/prod/src/ServiceModel/data/txnreplicator/TransactionalReplicatorSettings.cpp (2 lines):
- line 232: ServiceModelEventSource::Trace->ReplicatorSettingsError(errorMessage); // TODO: Add TRSettingsError Trace
- line 710: ServiceModelEventSource::Trace->ReplicatorSettingsError(errorMessage); // TODO: Create trace for TransactionalReplicatorSettings error
src/prod/src/managed/Api/Dlls/Microsoft.ServiceFabric.DeploymentManager/Common/StandAloneCluster.cs (2 lines):
- line 45: // TODO: This is an workaround for bug 8874388: SimpleClusterUpgradeState shouldn't reselect seednode. It should use the exisiting ones.
- line 62: // TODO: This is an workaround for bug 8874388: SimpleClusterUpgradeState shouldn't reselect seednode. It should use the exisiting ones.
src/prod/src/managed/Api/src/System/Fabric/Management/fabricdeployer/DcaSettings.cs (2 lines):
- line 358: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
- line 481: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
src/prod/src/Management/ApplicationGateway/Http/GatewayRequestHandler.ProcessRequestAsyncOperation.cpp (2 lines):
- line 47: // TODO: Currently we give send and receive timeouts as remaining time. This
- line 312: // TODO: Currently we give send and receive timeouts as remaining time. This
src/prod/src/inc/clr/pal/rt/palrt.h (2 lines):
- line 1161: /* TODO: do not write past buffer size */
- line 1189: /* TODO: do not write past buffer size */
src/prod/src/managed/Api/Dlls/Microsoft.ServiceFabric.DeploymentManager/BPA/BestPracticesAnalyzer.cs (2 lines):
- line 264: //// TODO: (maburlik) Validate FabricClient connection
- line 442: //// TODO: (maburlik) Validate FabricClient connection
src/prod/src/managed/Microsoft.ServiceFabric.Instrumentation/Tracing/Core/Definition/PropertyBagValueReader.cs (2 lines):
- line 41: // TODO: The creation of propertyNameIdex can be cached in the creator since it will done only 1 Time for each Type during a Run.
- line 206: // TODO: Should we be doing deep copies here? Think in details.
src/prod/src/Reliability/Failover/ra/Test.Functional.PerformanceTest.cpp (2 lines):
- line 149: // TODO: build up the path properly instead of hardcoding it
- line 377: // TODO: This should ideally be removed
src/properties/ktl/KtlUserDriver.props (2 lines):
- line 49:
- line 73:
src/prod/src/Common/Throw.h (2 lines):
- line 104: # define CHK_HR( expr ) for ( int __hr = expr; FAILED(__hr); ) THROW_SYSTEM_ERROR( microsoft::MakeWindowsErrorCode( __hr ), #expr ) //TODO: Create its own error category?
- line 108: // TODO: remove and replace with better one
src/prod/src/managed/FabricBRS/src/System/Fabric/BackupRestore/BackupRestoreCommon/WorkItem/SendToServiceNodeWorkItem.cs (2 lines):
- line 248: FolderPath = UtilityHelper.GetBaseDirectoryPathForPartition(serviceName, partitionId), // TODO: This should be constructed
- line 259: FolderPath = UtilityHelper.GetBaseDirectoryPathForPartition(serviceName, partitionId), // TODO: This should be constructed
src/prod/src/data/utilities/ConcurrentDictionary.h (2 lines):
- line 15: // TODO: Actual implementation will need to support key_equal function / equalscomparer to be passed in.
- line 16: // TODO: Const correctness.
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/ReplicationMetadata.cs (2 lines):
- line 38: // TODO #10279752: Separate redo out of ReplicationMetadata. Making
- line 76: // TODO #10279752: Separate redo out of ReplicationMetadata. Making
src/prod/tools/ConfigurationValidator/GenerateConfigurationsCSV.pl (2 lines):
- line 563: my $description = "TODO: GET DETAILS AND ADD TO GenerateConfigurationsCSV.pl";
- line 625: my $description = "TODO: GET DETAILS AND ADD TO GenerateConfigurationsCSV.pl";
src/prod/src/Reliability/LoadBalancing/Searcher.cpp (2 lines):
- line 1116: // TODO: no need to get initial violation list if we are sure CorrectSolution won't make a solution worse
- line 1131: // TODO: directly return ViolationList from CorrectSolution?
src/prod/src/Reliability/Replication/SecondaryReplicator.CloseAsyncOperation.cpp (2 lines):
- line 142: /*TODO - 935703 - WaitForCopyQueueToDrain(thisSPtr);*/
- line 157: /*TODO - 935703 - WaitForReplicationQueueToDrain(thisSPtr);*/
src/prod/src/managed/Api/src/System/Fabric/Management/fabricvalidator/FabricValidator.cs (2 lines):
- line 234: // TODO Add validation to http appgateway endpoint
- line 454: // TODO add validation for http app gateway endpoint
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Log/LogManager.LogicalLog.Buffer.cs (2 lines):
- line 519: // TODO: Start: DebugOnly
- line 545: // TODO: END: DebugOnly
src/prod/src/managed/fabricis/autopilot/dll/AskModeContext.cs (2 lines):
- line 84: // TODO different values for destructive and non-destructive
- line 362: // TODO allow config overrides
src/prod/src/Management/ApplicationGateway/Http/ServiceResolver.cpp (2 lines):
- line 143: // TODO: This error should be sent as errorcode value's message
- line 238: // TODO: This can be made common code.
src/prod/ktl/src/logger/src/KtlLogStream.AsyncWriteStream.cpp (2 lines):
- line 1228: // TODO: Allow logical log IoBuffer for metadata to be used
- line 1628: // TODO: Need to ensure there is LSNIndex space for all
src/prod/src/Reliability/LoadBalancing/LoadMetricStats.cpp (2 lines):
- line 130: // TODO: deal with overflow
- line 195: // TODO: deal with overflow
src/prod/src/inc/clr/regdisp.h (2 lines):
- line 22: // TODO: Unify with pCurrentContext / pCallerContext used on 64-bit
- line 550: _ASSERTE(!"@TODO Port - getRegAddr (Regdisp.h)");
src/prod/src/Lease/linux/LeasLayr.h (2 lines):
- line 175: //TODO ignore for now, no detection
- line 667: // TODO hit max parameters, workaround by combine the strings
src/prod/src/ktllogger/sys/tools/CoreLoggerPerf/CoreLoggerPerf.cpp (2 lines):
- line 645: // TODO: include all parameters for the run
- line 1112: // TODO: Compute !
src/prod/src/httpgateway/ComposeDeploymentsHandler.cpp (2 lines):
- line 274: //TODO: validate content type: text/yaml or text/yml
- line 329: //TODO: validate content type: text/yaml or text/yml
src/prod/src/pal/src/winbase.cpp (2 lines):
- line 248: // TODO: Change the caller: WinErrorCategory.cpp
- line 372: psid->SubAuthority[1] = uid; //TODO: Linux does not have anonymous...
src/prod/src/Hosting2/CodePackageInstance.cpp (2 lines):
- line 984: // TODO: Bug check activationId value and ignore any stale notification
- line 1121: //TODO: Can be changed to BeginWaitForTransition to STarted stated. In this case, we won't need the due time in VersionedSP.
src/prod/src/Reliability/Failover/ra/Hosting.HostingEventHandler.cpp (2 lines):
- line 105: TODO: This code has much in common with the other hosting event processors
- line 222: // TODO: When the entire infrastructure moves to activity id use it everywhere
src/prod/src/Reliability/Failover/fm/Store.cpp (2 lines):
- line 832: // TODO: Consider creating a buffer pool for performance
- line 863: // TODO: Consider creating a buffer pool for performance
src/prod/src/Transport/TransportSecurity.cpp (2 lines):
- line 92: return ErrorCodeValue::Success; //LINUXTODO ???
- line 597: //LINUXTODO connectionAuthSecurityDescriptor_
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/BackupManager/BackupLogFile.cs (2 lines):
- line 401: // TODO: Fix this by using operationdata in this class
- line 474: // TODO: Fix this by using operationdata in this class
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/TransactionalReplicator.cs (2 lines):
- line 528: // TODO: Monitor onDataLossCallback duration
- line 547: // TODO: Structured Tracing. Trace TransactionalReplicator.ApiError@, t.Exception.InnerException.
src/prod/src/data/logicallog/LogicalLog.cpp (2 lines):
- line 1550: // TODO: Work out Reuse() for read approach
- line 1725: // TODO: Come up with a better reuse approach; unseal/reuse if sizeOfUserDataSealed == 0
src/prod/ktl/src/dbgext/ktlext.cpp (2 lines):
- line 1184: // TODO: more fields
- line 1349: // TODO: more fields
src/prod/src/managed/ClusterAnalysis/AnalysisCore/CallbackStore/SimpleCallbackStore.cs (2 lines):
- line 53: // TODO: Think the Policy passing through
- line 72: // TODO Think through this Reset and passing of stop options.
src/prod/src/managed/FabricUOS/exe/UpgradeOrchestrationServiceImpl.cs (2 lines):
- line 99: // TODO: Not implemented yet
- line 107: // TODO: Not implemented yet
src/prod/src/reliablemessaging/ReliableMessagingTwoTierIndex.h (2 lines):
- line 25: TODO: implement this as a template structure -- runs into some compiler issues
- line 190: // TODO: implement this
src/prod/src/Hosting2/MultiCodePackageApplicationHost.cpp (2 lines):
- line 296: // TODO: pass timeout to CodePackageHost
- line 493: // TODO: use timeout
src/prod/src/LeaseAgent/LeaseAgent.cpp (2 lines):
- line 79: RemoteLeasingApplicationIdentifier; //TODO value is unused
- line 1124: // TODO: Arbitration Support Methods not implemented.
src/prod/src/data/tstore/FastSkipList.h (2 lines):
- line 809: // TODO: Is MemoryBarrier required?
- line 852: // TODO: Is MemoryBarrier required?
src/prod/src/managed/FabricFAS/src/system/fabric/faultanalysisservice/FaultAnalysisServiceRoot/Actions/Steps/InvokeDataLossSteps.cs (2 lines):
- line 239: // TODO: Wait for some time so that the unreliable transport behavior can be read from the files.
- line 270: // TODO: Wait for some time so that the unreliable transport behavior can be read from the files.
src/prod/src/data/interop/ReliableCollectionRuntimeImpl/CompatRDStateProvider.cpp (2 lines):
- line 268: // TODO ASSERT
- line 275: // TODO ASSERT
src/prod/src/ktllogger/sys/ktlshim/StreamShimKernel.cpp (2 lines):
- line 556: // TODO: For now fire any truncation needed events, in the future we
- line 2440: // TODO: abort all other requests
src/prod/src/inc/clr/PAL.h (2 lines):
- line 354: //TODO - waa
- line 368: // TODO -waa
src/prod/src/inc/clr/nibblemapmacros.h (2 lines):
- line 30: // TODO: bump up the windows CODE_ALIGN to 16 and iron out any nibble map bugs that exist.
- line 31: // TODO: there is something wrong with USE_INDIRECT_CODEHEADER with CODE_ALIGN=16
src/prod/src/inc/palrt/palrt.h (2 lines):
- line 1158: /* TODO: do not write past buffer size */
- line 1186: /* TODO: do not write past buffer size */
src/prod/src/api/wrappers/ComFabricClient.cpp (2 lines):
- line 13749: // TODO: define a size validation for encrypted passwords
- line 20960: // TODO: take description class after compose structure is updated
src/prod/src/FabricGateway/FabricGateway.cpp (2 lines):
- line 259: // TODO: make httpgateway a rooted component.
- line 729: //TODO: SetSecurity for entreeservice proxy and httpgateway
src/prod/src/reliablemessaging/ReliableMessagingEnvironment.cpp (2 lines):
- line 56: // TODO: there seems to be no clear way to report the actual failure here as an NTSTATUS
- line 97: // TODO: Revisit after we enable multiple Ktl systems
src/prod/src/Reliability/Failover/ra/ReconfigurationAgentProxy.ActionListExecutorAsyncOperation.h (2 lines):
- line 68: // TODO: Make this sync when service Abort support is added
- line 85: // TODO: Make this sync when service Abort support is added
src/prod/src/inc/clr/corcompile.h (2 lines):
- line 797: // TODO: hotCodeSize should be encoded in GC info
- line 1653: // TritonTODO: should this be inside ifdef?
src/prod/src/Hosting2/VolumeMapper.cpp (2 lines):
- line 39: // TODO: Add validation for this config in FabricDeployer
- line 64: // TODO: Create these lazily rather than creating upfront
src/prod/src/data/tstore/TStoreTestBase.h (2 lines):
- line 1083: KSharedPtr CreateMockReplicator(__in FABRIC_REPLICA_ROLE role, __in bool hasPersistedState) //TODO: IStatefulServicePartition& partition
- line 1136: // TODO: Create directories based on partition and replica ID
src/prod/src/retail/native/LttngReader/dll/lttngreader_util.cpp (2 lines):
- line 25: // TODO - remove just for debugging
- line 414: // TODO - Should be removed after complete migration to structured events
src/prod/src/data/txnreplicator/loggingreplicator/LoggingReplicatorImpl.cpp (2 lines):
- line 287: // TODO: Add a RestoreBatchSizeInKB into the configuration.
- line 1074: // TODO: Add StartTelemetryTaskAsync here.
src/prod/src/Management/FileStoreService/ReplicationManager.cpp (2 lines):
- line 252: // TODO: Demote to noise after testing
- line 376: // TODO: Demote to noise when Image Store Service stabilizes
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/LogRecordsMap.cs (2 lines):
- line 20: /// TODO: Structured tracing.
- line 27: /// TODO: Structured tracing.
src/prod/src/Lease/linux/leaseapp.cpp (2 lines):
- line 294: //TODO shuxu
- line 1095: //TODO shuxu delete callback if needed, see windows code
src/prod/src/api/definitions/IStateProvider.h (2 lines):
- line 35: // TODO: change from ComPointer to IOperationDataStreamPtr
- line 39: // TODO: change from ComPointer to IOperationDataStreamPtr
src/prod/src/Transport/UnreliableTransportConfig.cpp (2 lines):
- line 282: // TODO: if files are large, read line by line
- line 288: // TODO: use streams instead of reading bytes,
src/prod/src/data/txnreplicator/loggingreplicator/OperationProcessor.cpp (2 lines):
- line 830: // TODO: Temporary assert should be removed later
- line 886: // TODO: Temporary assert should be removed later
src/prod/src/managed/fabricis/parallel/dll/Reconciler.cs (2 lines):
- line 472: // TODO prefer tasks with jobKeyMatch?
- line 648: // TODO consider cancelling restoring health check, if necessary
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/SerializationManager/NamedType.cs (2 lines):
- line 36: // TODO: Requires test.
- line 57: // TODO: Consider Assert.
src/prod/src/Lease/linux/LeaseTransport.cpp (2 lines):
- line 163: //LINUXTODO consider use UnreliabableTransport
- line 246: //LINUXTODO consider support sending callback in IDatagramTransport
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReplicatedStore/DifferentialStore/ConsolidationManager.cs (2 lines):
- line 203: // TODO: do we need to AddRef/ReleaseRef on metadataTable for background consolidation?
- line 919: // TODO: check on perf testing for this allocation.
src/prod/src/ktllogger/KtlLoggerNode.cpp (2 lines):
- line 84: #if !defined(PLATFORM_UNIX) // TODO: Determine size of memory
- line 681: // TODO: Use fabric tracing ???
src/prod/shared/serialization/inc/KSerializationHelper.h (2 lines):
- line 187: // TODO: this relies on the above assertion that a KUniquePtr is really just a pointer
- line 203: // TODO: this relies on the above assertion that a KUniquePtr is really just a pointer
src/prod/src/Reliability/Replication/OperationQueue.cpp (2 lines):
- line 276: // TODO: drop all in the same batch
- line 315: //TODO: clean all operations in same batch
src/prod/src/Common/SecurityConfig.h (2 lines):
- line 20: //LINUXTODO compare string based on locale
- line 94: //LINUXTODO compare string based on locale
src/prod/src/Common/IpAddressPrefix.cpp (2 lines):
- line 205: ///TODO: remove
- line 220: ///TODO:remove
src/prod/ktl/src/inc/KDom.h (2 lines):
- line 107: //BUG: richhas, xxxxxx, TODO: Add support for: Get all attr names AND values
- line 143: //***BUG: richhas, xxxxxx, TODO: Add: get all names AND values
src/prod/src/httpgateway/ApplicationsHandler.cpp (2 lines):
- line 3333: // TODO remove after JSON serialization of sptr is checked in
- line 3353: // TODO remove after JSON serialization of sptr is checked in
src/prod/src/data/utilities/BinaryWriter.h (2 lines):
- line 260: // TODO: Remove COPY
- line 266: // TODO: Remove COPY
src/prod/src/Management/ClusterManager/ProcessSingleInstanceDeploymentUpgradeContextAsyncOperation.cpp (2 lines):
- line 131: //TODO: Return AsyncOp and complete itself with error
- line 174: TimeSpan::FromMinutes(2), // TODO: Should be a configurable time, so we can retry incase IB is stuck.
src/prod/src/managed/Autopilot/ServiceFabricAutopilotAgent/ConfigurationManager.cs (2 lines):
- line 33: * TODO: currently AP safe config deployment is not supported to update configurations.
- line 145: // TODO: constants for defaults
src/prod/src/httpgateway/SecretsResourceHandler.cpp (2 lines):
- line 732: // TODO [dragosav]: for the time being, we're using the same service API as for retrieving
- line 796: // TODO [dragosav]: for the time being, we're using the same service API as for retrieving
src/prod/src/Common/Timer.Linux.cpp (2 lines):
- line 573: //LINUXTODO consider avoid callback_ copy, which probably requires not resetting
- line 613: // uncomment per LINUXTODO above
src/prod/src/managed/Api/src/System/Fabric/BackupRestore/BackupRestoreManager.cs (2 lines):
- line 260: // TODO: We need to add a mitigation here in case FabricBRS is not reachable.
- line 432: // TODO: Handle BRS not reachable
src/prod/src/managed/ClusterAnalysis/AnalysisCore/ClusterQuery/HealthQueryHelper.cs (2 lines):
- line 102: // TODO: Certain Optimization can be done at this level maybe? For example, can we not query and just use a cached value for a certain amount of time?
- line 151: this.logger.LogMessage("TODO: AppHealthQuery: App Name: {0}, State: {1}", oneAppHealthState.ApplicationName, oneAppHealthState.AggregatedHealthState);
src/prod/src/Transport/TcpConnection.cpp (2 lines):
- line 2113: //LINUXTODO remove this conditional compile and always call ProcessClaimsMessage here
- line 2389: AcquireWriteLock grab(lock_); //LINUXTODO read lock enough?
src/prod/src/managed/fabricis/serial/dll/WindowsAzureRepairExecutor.cs (2 lines):
- line 462: // TODO return false here if strict matching is enabled
- line 478: // TODO compare impact reasons?
src/prod/src/managed/fabricis/parallel/dll/CommandHandling/CoordinatorStateData.cs (2 lines):
- line 13: /// TODO Update SFE code.
- line 40: // TODO: Expose these fields later, once support for job sets is added, and AllowAction command is ready
src/prod/src/data/tstore/StoreKeyValueEnumerator.h (2 lines):
- line 64: // TODO:
- line 98: // TODO: IEnumerator also needs a Reset() method
src/prod/src/ktllogger/sys/ktlshim/OverlayManager.cpp (2 lines):
- line 2967: // TODO: _AllocationExtentSize may need to be configurable or
- line 3640: // TODO: Configure and enforce PinnedMemoryLimit
src/prod/src/ServiceModel/ResourcesDescription.h (2 lines):
- line 32: // TODO: add certificates
- line 46: //TODO: When implementing certificates, also implement these methods correctly
src/prod/src/inc/clr/corhost.h (2 lines):
- line 481: // TODO: Following 4 APIs should be move to CorHost for V1.
- line 686: // @TODO:: a-meicht
src/prod/src/Hosting2/ContainerConfig.cpp (2 lines):
- line 176: // TODO: Bug#9728016 - Disable the bind until windows supports mounting file onto container
- line 271: // TODO: Bug#9728016 - Disable the bind until windows supports mounting file onto container
src/prod/src/Management/ApplicationGateway/Http/WebSocketManager.cpp (2 lines):
- line 61: // TODO: Add the error message to status description.
- line 312: L"", // TODO: Fetch status description from KTL request and propagate it back to the client.
src/prod/src/managed/fabricis/parallel/dll/Actions/MoveToRestoringAction.cs (2 lines):
- line 63: // TODO: this is not processed, consider calling UpdateRepairTaskHealthPolicyAsync instead
- line 102: // TODO: Consider checking PA doc role instance list (health info) to verify that node has been removed
src/prod/src/data/utilities/LockManager.Perf.cpp (2 lines):
- line 290: // TODO: Revisit with new KTL threadpool
- line 375: // TODO: Configure test to actually run 200 tasks concurrently. Currently ~12 run together
src/prod/src/data/utilities/ConcurrentSkipList.h (2 lines):
- line 810: // TODO: Is MemoryBarrier required?
- line 853: // TODO: Is MemoryBarrier required?
src/prod/src/managed/Api/src/System/Fabric/Testability/Client/RestFabricClient.cs (2 lines):
- line 604: // TODO: 5604082 : Testability REST client: GetClusterHealth should pass ApplicationHealthPolicyMap in the body
- line 2428: queryParameters[RestPathBuilder.StartDateTimeFilter] = startDateTimeFilter.ToString(); // TODO: Verify if this format is correct
src/prod/src/Hosting2/SingleCodePackageApplicationHostProxy.cpp (2 lines):
- line 223: // TODO: Check with Rajeet.
- line 1666: // TODO: Trace here for failed start.
src/prod/src/Common/Common.h (2 lines):
- line 363: // TODO move nodeid to common.
- line 431: // LINUXTODO: consider removing registry usage
src/prod/src/Common/FileConfigStore.cpp (2 lines):
- line 146: // TODO: if files are large, read line by line
- line 154: // TODO: use streams instead of reading bytes,
src/prod/src/inc/clr/clrconfigvalues.h (2 lines):
- line 430: // JBTODO: remove. This is temporary.
- line 939: RETAIL_CONFIG_STRING_INFO_DIRECT_ACCESS(EXTERNAL_developerInstallation, W("developerInstallation"), "Flag to enable DEVPATH binding feature") // TODO: check special handling
src/prod/src/Federation/BroadcastManager.cpp (2 lines):
- line 317: // TODO: Send successor and predecessor nodes seperately for now to simplify the code, use the same header collection later
- line 318: // TODO: optimize by not sending if they are already in the exponential list
src/prod/src/inc/clr/downlevel.h (2 lines):
- line 60: // TODO: These didn't make it to windows
- line 131: // TODO: I don't think we need all of these.
src/prod/src/managed/Api/Dlls/Microsoft.ServiceFabric.DeploymentManager/Common/StandaloneSettingsValidator.cs (2 lines):
- line 69: // TODO: (maburlik) Validate conforms to JSON config model
- line 851: // TODO: (maburlik) check for typos i.e. WindowsIdentities section validates against nodes.
src/prod/src/managed/Microsoft.ServiceFabric.ContainerServiceClient/ContainerServiceHttpConnection.cs (2 lines):
- line 194: // TODO: Verify HTTP/1.0 or 1.1.
- line 203: // TODO: Validate range
src/prod/src/managed/FabricUS/src/system/fabric/upgradeservice/WRP/ServiceClient.cs (2 lines):
- line 86: var errorDetails = new JObject(); //TODO: How to get the error details?
- line 214: return ResultStatus.InProgress; // TODO: Should we create an Unknown/Invalid status?
src/prod/src/Federation/PartnerNode.cpp (2 lines):
- line 16: // TODO: header can be &&
- line 117: // TODO: target to self?
src/prod/src/ktllogger/sys/tools/writecrashandrecover/wcar.cpp (2 lines):
- line 380: // TODO: add validation
- line 640: // TODO: Do I want this ?? Or retry ???
src/prod/src/reliablemessaging/ReliableMessagingMacros.h (2 lines):
- line 28: // TODO: Need to be more selective about use of LastServiceActivityReleased trace
- line 71: // TODO: are we doing proper/sufficient cleanup on failed Create in general?
src/prod/src/managed/DCA/product/plugins/lttproducer/LttProducerWorker.cs (2 lines):
- line 327: // TODO - Consider that folders are not ordered by events timestamps
- line 337: // TODO cancellation token (if there are many folders and a lot of data)
src/prod/src/managed/FabricUS/src/system/fabric/upgradeservice/WRP/ExceptionHandlingPolicy.cs (1 line):
- line 215: // TODO: RDBug 11876054:FabricUS: Handle retryable exceptions for health status publishing
src/prod/src/Management/RepairManager/NodeRepairImpactDescription.cpp (1 line):
- line 84: // TODO validate node names, casing, duplicates, etc?
src/prod/src/managed/Api/src/System/Fabric/Repair/NodeRepairTargetDescription.cs (1 line):
- line 75: // TODO avoid extra copy here
src/prod/src/systemservices/SystemServiceResolver.cpp (1 line):
- line 343: // TODO: Optimize query to fetch FM data only
src/prod/src/managed/fabricis/host/exe/ServiceReplica.cs (1 line):
- line 145: // TODO: this.StopCoordinatorAsync?
src/prod/src/data/txnreplicator/testcommon/TestStateProvider.cpp (1 line):
- line 1083: // TODO: This is a temporary fix for the copy before checkpoint case.
src/prod/src/managed/Api/src/System/Fabric/Common/RestartReplicaOrInstanceAction.cs (1 line):
- line 95: // TODO: Check with failover team to see how to confirm that the replica actually restarted. We do not expose instance id for persisted replicas
src/prod/src/managed/Microsoft.ServiceFabric.FabricTransport/FabricTransport/Client/FabricTransportClient.cs (1 line):
- line 59: //TODO: Remove this check after Bug :1225032 gets resolved
src/prod/src/BlockStore/Service/SFBlockStore/SFBlockStoreService/TcpCommunicationListener.cs (1 line):
- line 165: // TODO: Can we do this better?
src/prod/src/inc/clr/ostype.h (1 line):
- line 126: @TODO: _ASSERTE not available here...
src/prod/src/Common/Sid.Linux.cpp (1 line):
- line 184: // TODO: memory reclamation..
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReliableStateManagerReplicatorSettingsUtil.cs (1 line):
- line 922: // TODO: Workaround if coalescing is not enabled and old driver is checked in for the release
src/prod/src/Reliability/LoadBalancing/TestFM.cpp (1 line):
- line 342: // TODO: clear flegs on the existing replica
src/prod/src/ServiceModel/management/HealthManager/SequenceStreamId.cpp (1 line):
- line 73: // TODO: Temporarily reverse ordering in feature_data2 branch for density testing
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReliableStateManagerImpl.cs (1 line):
- line 451: // TODO: For now only exposing TryAdd. Get and Remove can be exposed later.
src/prod/ktl/src/inc/khttp.h (1 line):
- line 454: // TODO: move to a more general location, as this is not http-specific
src/prod/src/Management/healthmanager/ClusterCache.h (1 line):
- line 24: // TODO: locking weak ptr should be protected by a lock?
src/prod/src/Common/InterlockedBufferPool.cpp (1 line):
- line 18: // TODO: should we zero?
src/prod/src/BlockStore/SFBDMiniport/SFBDCtlLib/stdafx.cpp (1 line):
- line 8: // TODO: reference any additional headers you need in STDAFX.H
src/prod/src/data/tstore/RebuiltStateEnumerator.h (1 line):
- line 98: // TODO: IEnumerator also needs a Reset() method
src/prod/src/Transport/LTSendBuffer.h (1 line):
- line 47: //LINUXTODO should this be a list of buffers? or using buffered BIO?
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReplicatedStore/DifferentialStore/MergeHelper.cs (1 line):
- line 307: // TODO: Fix the workaround below until item 5861402 is fixed.
src/prod/src/Reliability/Failover/ra/RA.Internal.h (1 line):
- line 31: // TODO: Fix RA to use QueryMessageHandler, rather than directly parsing the query,
src/prod/src/Reliability/Replication/ReplicationPointers.h (1 line):
- line 26: // TODO: 132314: Infrastructure: need to add ref_ptr
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReplicatedStore/Disk/PropertyChunkMetadata.cs (1 line):
- line 22: /// TODO: We could use GCHandle and StructureToPtr to do copy free serialization and de-serialization.
src/prod/src/pal/src/internal/pal.cpp (1 line):
- line 23: //LINUXTODO move exitProcessCalled to libFabricCommon.so to truly avoid racing calls to exit()
src/prod/src/managed/FabricFAS/src/system/fabric/faultanalysisservice/FaultAnalysisServiceRoot/Engine/ReliableFaultsEngine.cs (1 line):
- line 131: // TODO: should also include Error
src/prod/src/ServiceModel/management/RepairManager/RepairTaskState.cpp (1 line):
- line 87: // TODO Replace with a macro, or generate a map
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReliableMessaging/stream/ChangeRoleHandler.cs (1 line):
- line 180: /// TODO:With the retry added to the FinishOpen process we need to revisit how this is used there.
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/Transaction.cs (1 line):
- line 167: // TODO: Consider isPrimaryTransaction only when the first AddOperation is called.
src/prod/src/managed/Microsoft.ServiceFabric.Instrumentation/Tracing/Readers/AzureTableReader/ServiceFabricAzureTableRecordSession.cs (1 line):
- line 96: // TODO: This is a bug in DCA. It doesn't upload Critical information to the Tables today, so
src/prod/src/query/GetDeployedCodePackageParallelQuerySpecification.cpp (1 line):
- line 73: // TODO: Consider not return message since it is not used.
src/prod/src/managed/Api/src/System/Fabric/FabricTokenServiceMetadataResult.cs (1 line):
- line 12: [SuppressMessage(FxCop.Category.Design, FxCop.Rule.TypesThatOwnDisposableFieldsShouldBeDisposable, Justification = "// TODO: Implement an IDisposable, or ensure cleanup.")]
src/prod/src/managed/Microsoft.ServiceFabric.Instrumentation/Tracing/Readers/AzureTableReader/TraceRecordAzureTableMetadata.cs (1 line):
- line 14: /// TODO : Improve this.
src/prod/src/Common/Config.h (1 line):
- line 97: // TODO: not handling incorrect format yet
src/prod/src/Management/RepairManager/RepairTask.cpp (1 line):
- line 128: // TODO validate as NamingUri also
src/prod/src/BlockStore/SFBDMiniport/SFBDMiniport/inc/BlockStore.h (1 line):
- line 122: // TODO: Merge the next 3 fields into one.
src/prod/src/Management/HttpTransport/Constants.h (1 line):
- line 16: static ULONG MaxEntityBodySize; // TODO: This should be allowd to be overridden by settings.xml
src/prod/src/managed/Autopilot/ServiceFabricAutopilotAgent/ClusterTopology.cs (1 line):
- line 145: // TODO: On Autopilot, endpoint set is not part of service model so would not be modeled as part of topology.
src/prod/src/Management/HttpTransport/RequestMessageContext.ReadBodyAsyncOperation.cpp (1 line):
- line 56: HttpConstants::MaxEntityBodySize) // TODO: This should be changed to settings.xml
src/prod/src/Reliability/LoadBalancing/MetricGraph.cpp (1 line):
- line 433: //this is not currently used, but I'm keeping it in. TODO: perform cleanup if metric graph gets too big.
src/prod/src/Lease/api/stdafx.cpp (1 line):
- line 12: // TODO: reference any additional headers you need in STDAFX.H
src/prod/src/Transport/SecurityCredentials.cpp (1 line):
- line 81: // LINUXTODO consider replacing SSLv23_method with TLS_method after upgrading to openssl 1.1 or newer, to avoid confusion.
src/prod/src/data/txnreplicator/loggingreplicator/BackupMetadataFile.cpp (1 line):
- line 69: // TODO: Create BackupMetadataFileProperties with all settings. Now
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/FileLogManager.cs (1 line):
- line 259: // TODO: Exception/HRESULT work needs to be finished: catch (FabricElementNotFoundException)
src/prod/src/Common/CommonConfig.h (1 line):
- line 69: // TODO - remove after transition to structured traces is complete
src/prod/src/data/tstore/CopyManager.cpp (1 line):
- line 140: throw ktl::Exception(SF_STATUS_INVALID_OPERATION); // TODO: Use actual exception
src/prod/src/Federation/SiteNode.h (1 line):
- line 212: // TODO: these can be const & but this must start in comm object
src/prod/src/inc/clr/sigparser.h (1 line):
- line 295: HRESULT GetCallingConv(ULONG* data) // @REVISIT_TODO: Calling convention is one byte, not four.
src/prod/src/managed/Microsoft.ServiceFabric.ContainerServiceClient/BufferedClientStream.cs (1 line):
- line 174: // TODO: Use encoding to convert from byte to char
src/prod/src/inc/clr/newapis.h (1 line):
- line 126: // TODO: NLS Arrowhead -This isn't really right, custom locales could start with en- and have different sort behavior
src/prod/ktl/src/logger/src/KtlLogStreamRecovery.cpp (1 line):
- line 187: KAssert(_NextStreamLsn == recordHeader->Lsn); // TODO: Why assert and not a failure ?
src/prod/src/ktllogger/sys/dbgext/KtlLogExt.cpp (1 line):
- line 77: // TODO: don't be so recursive
src/prod/src/managed/EventsStore/EventStore.Service/ConfigReader/AzureTableConsumer.cs (1 line):
- line 83: // TODO: We need to improve this Logic.
src/prod/src/Lease/linux/Api.cpp (1 line):
- line 670: //TODO shuxu check this to see if it is needed
src/prod/src/managed/FabricUS/exe/WRP/StreamChannel/WrpStreamChannel.cs (1 line):
- line 568: //// TODO current SFRP only use thumbprint, so we may ingore this for now
src/prod/src/Common/CryptoUtility.Linux.h (1 line):
- line 92: // LINUXTODO support hash algorithm parameter
src/prod/src/managed/fabricis/parallel/dll/Coordinator/AzureParallelInfrastructureCoordinatorFactory.cs (1 line):
- line 60: // TODO use tenant ID or config section name suffix as base trace ID?
src/prod/src/Hosting2/ApplicationHost.cpp (1 line):
- line 1005: // TODO: Bug#9728016 - Disable the bind until windows supports mounting file onto container
src/prod/shared/ktlwf/logger/managed/tools/perftest/Program.cs (1 line):
- line 104: writer.WriteAttributeString("Value", "ComputerName"); // TODO: COmputername
src/prod/src/Common/Guid.cpp (1 line):
- line 120: { //TODO: print all the LUID, not only lower part.
src/prod/src/Federation/RoutingToken.h (1 line):
- line 27: /// TODO: consider to add ownerId field.
src/prod/src/Reliability/Failover/ra/Test.Utility.ScenarioTest.h (1 line):
- line 637: // TODO: Clean way to add query header
src/prod/src/Reliability/Failover/ra/ReconfigurationState.cpp (1 line):
- line 276: //TODO: add assert for starttime + phasestarttime
src/prod/src/Management/HttpTransport/HttpServerWebSocket.h (1 line):
- line 39: // TODO: Should there be a status code and description to identify any errors
src/prod/src/Naming/EntreeServiceTransport.cpp (1 line):
- line 81: // TODO: this case happens when the proxy is not known or has just been disconnected,
src/prod/src/Communication/TcpServiceCommunication/ServiceCommunicationTransport.cpp (1 line):
- line 32: //TODO: Optimize lookup to not to use 2 maps.
src/prod/src/Reliability/Failover/ra/Infrastructure.EntityJobItemListExecutorAsyncOperation.h (1 line):
- line 129: TODO: When the move to async is complete this will not be a problem
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReplicatedStore/Disk/KeyChunkMetadata.cs (1 line):
- line 22: /// TODO: We could use GCHandle and StructureToPtr to do copy free serialization and de-serialization.
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/LoggingReplicatorCopyStream.cs (1 line):
- line 466: // TODO: Ask for the size to avoid expanding the memoryStream.
src/prod/src/Common/XmlLiteReader.Linux.cpp (1 line):
- line 14: // UTF-8 to UTF-16 Conversion. TODO: wchar_t seems still 4-bytes in to_bytes()
src/prod/src/data/tstore/CheckpointFile.Perf.cpp (1 line):
- line 234: // TODO: Move inside the loop to get checkpoint file for specific i
src/prod/src/Reliability/Replication/ComReplicator.h (1 line):
- line 40: // TODO: make this private
src/prod/src/data/txnreplicator/common/IStateProvider2.h (1 line):
- line 150: // TODO: Consider: Should operationContext be const?
src/prod/src/Common/ProcessWait.Linux.cpp (1 line):
- line 399: sa.sa_flags = SA_NOCLDSTOP | SA_SIGINFO | SA_RESTART; //LINUXTODO should we also report stop events?
src/prod/src/Management/NetworkInventoryManager/lib/NIMNetworkAllocationPool.h (1 line):
- line 22: // TODO: Make it generic for ipv6 in the future?
src/prod/src/Lease/sys/Leases.c (1 line):
- line 1679: (LONGLONG)0 // TODO seperate template for this trace
src/prod/src/data/tstore/VersionedItem.h (1 line):
- line 124: // TODO: Check if the loop below spins taking up CPU cycles on perf runs.
src/prod/src/managed/infrastructurewrapper/azurewrapper/azurewrapperservice/WindowsFabricAzureWrapper.cs (1 line):
- line 1368: // TODO: Refer to #1282639, this will be updated once we have a way to query Fabric Host about whether hosted application/services are actually ready.
src/prod/src/Common/TestPortHelper.cpp (1 line):
- line 369: //LINUXTODO consider moving the following two APIs to pal_missing.cpp
src/prod/src/managed/Api/src/System/Fabric/Testability/Client/Requests/PutCustomPropertyRequest.cs (1 line):
- line 21: // TODO: This is temporary, as PutCustomProperty will be available in PutProperty in the future (there was a mistake in defining the API) Defect: 1168753
src/prod/ktl/src/logger/tools/RawLoggerPerf/CloseSync.h (1 line):
- line 1: // TODO: Separate into .h and .c
src/prod/src/data/tstore/MemoryBuffer.cpp (1 line):
- line 115: // TODO: Implement if needed - Writing as necessary and then calling GetBuffer should cover a lot of cases
src/prod/src/Management/RepairManager/RepairManagerServiceFactory.cpp (1 line):
- line 133: //TODO: create an internal CLSID and do a QueryInterface
src/prod/src/Transport/LTReceiveBuffer.cpp (1 line):
- line 133: //LINUXTODO handle LT_FRAMETYPE_CONNECT within transport
src/prod/ktl/src/inc/KAsyncContext.h (1 line):
- line 1091: // IStatelessServicePartitionHolder
src/prod/src/Common/TraceEventContext.cpp (1 line):
- line 25: // TODO: handle allocation failure
src/prod/src/data/utilities/KHashSet.h (1 line):
- line 69: // TODO: #9000025: KHashTable needs to be const correct.
src/prod/src/reliablemessaging/ReliableSessionCallbacks.cpp (1 line):
- line 57: // TODO: who is responsible for keeping this alive? Always release?
src/prod/src/managed/fabricis/parallel/dll/Actions/AckJobAction.cs (1 line):
- line 11: // TODO consider deriving this class into AckImpactStartJob and AckImpactEndJob to override the ActionType.
src/prod/src/managed/Api/src/System/Fabric/Common/Tracing/FabricEventSource.cs (1 line):
- line 711: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
src/prod/src/Common/IpAddressPrefix.h (1 line):
- line 145: ///TODO: temporary code.remove
src/prod/src/Hosting2/DownloadManager.h (1 line):
- line 98: //TODO: #12372718: Add a new API to force download the package during predeployment on node
src/prod/src/managed/ClusterAnalysis/AnalysisCore/Helpers/FabricClientRetryErrors.cs (1 line):
- line 188: // TODO: Enable after updating ServiceFabricClientPackage in SF-AppStore Repo
src/prod/src/Management/RepairService/PolicyEngineService/RepairPolicyEngineService.cpp (1 line):
- line 168: // TODO: Should the load happen all the time?
src/prod/src/reliablemessaging/ReliableSessionService.h (1 line):
- line 109: TODO: consider separating the state checks from the state transitions and doing the former in a safe method.
src/prod/src/ServiceModel/modelV2/ContainerVolumeRef.h (1 line):
- line 46: //TODO: add nameformat
src/prod/src/managed/Api/src/System/Fabric/Common/GetSelectedReplicaStateAction.cs (1 line):
- line 43: // TODO: make these actions which store state locally as well.
src/prod/src/managed/Api/src/System/Fabric/Interop/NativeRuntime.cs (1 line):
- line 3008: [SuppressMessage(FxCop.Category.StyleCopMaintainability, FxCop.Rule.FileMayOnlyContainASingleClass, Justification = "TODO: move to seperate file")]
src/prod/src/data/tstore/ValueCheckpointFileProperties.cpp (1 line):
- line 48: //TODO: fix size.
src/prod/src/Common/WaitHandle.cpp (1 line):
- line 47: // @TODO - eventName isn't actually supported in linux. we need to find another way
src/prod/src/Management/HttpTransport/RequestMessageContext.SendResponseAsyncOperation.Linux.cpp (1 line):
- line 88: // TODO: Add cancellation support
src/prod/src/Management/RepairManager/RepairPreparationAsyncOperation.cpp (1 line):
- line 43: // TODO Refactor prepare/restore async ops to be polymorphic based on impact type
src/prod/src/inc/clr/gcinfotypes.h (1 line):
- line 259: // ARM64TODO: these were copied from AMD64, and need to be reviewed
src/prod/src/managed/fabricis/parallel/dll/Coordinator/AzureParallelDisabledCoordinatorFactory.cs (1 line):
- line 59: // TODO use tenant ID or config section name suffix as base trace ID?
src/prod/ktl/src/src/kawipceventwaiter.cpp (1 line):
- line 153: // TODO: Replace blocking thread with syncfile support when KXM is
src/prod/src/ServiceModel/hosting2/ServiceTypeStatusEventArgs.h (1 line):
- line 13: //TODO: Remove default value to force all references to explicitly pass isolation context.
src/prod/src/data/txnreplicator/statemanager/TestTransactionManager.h (1 line):
- line 179: // TODO: Rethink
src/prod/src/managed/fabricis/parallel/dll/Actions/RequestRepairAction.cs (1 line):
- line 48: // TODO cancel task if its action/target is bad
src/prod/src/managed/Api/src/System/Fabric/Chaos/RandomActionGenerator/StateTransitionAction.cs (1 line):
- line 16: /// TODO FW: make it abstract after script test side code is refactor and totally dependent on testability.
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/StateManagerLockContext.cs (1 line):
- line 205: // TODO preethas : Remove transaction id or add transaction id to acquire API it is not in sync with the acquire API
src/prod/src/Common/Threadpool.Linux.h (1 line):
- line 7: // TODO: Replace with our implementation.
src/prod/src/managed/Microsoft.ServiceFabric.Instrumentation/Tracing/Readers/AzureTableReader/WellKnownFields.cs (1 line):
- line 37: /// TODO: Change to id.
src/prod/src/Management/BackupRestore/BA/BackupScheduleRuntimeList.cpp (1 line):
- line 15: BackupScheduleRuntimeList::BackupScheduleRuntimeList(vector runTimes) : runTimes_(runTimes) // TODO: Check if effective copy possible.
src/prod/src/httpgateway/ServiceResolver.cpp (1 line):
- line 223: // TODO: This can be made common code.
src/prod/src/data/interop/ReliableCollectionRuntimeImpl/Helper.h (1 line):
- line 13: public: // TODO const
src/prod/src/managed/FabricFAS/src/system/fabric/faultanalysisservice/TestEventSource.cs (1 line):
- line 12: // TODO: replace this with trace into product
src/prod/src/Common/Uri.h (1 line):
- line 30: // TODO: make constructors protected after unit test class can be made a friend (switched to TAEF)
src/prod/src/client/ClientServerTransport/ClientServerReplyMessage.h (1 line):
- line 20: // TODO: REMOVE after HealthReportingTransport interface is removed
src/prod/src/Transport/MessageHeadersCollection.h (1 line):
- line 15: // TODO: implementation of iterator pattern?
src/prod/src/Common/Guid.h (1 line):
- line 217: // TODO: make this a property??
src/prod/src/managed/ClusterAnalysis/AnalysisCore/Insights/NodeInfo.cs (1 line):
- line 18: /// TODO: Switch with NodeEntity
src/prod/src/managed/ClusterAnalysis/Common/Util/HandyUtil.cs (1 line):
- line 125: // TODO: Investigate why UTF16 is causing crashes and then switch to it
src/prod/src/managed/Api/src/System/Fabric/Management/ImageStore/XStoreFileOperations.cs (1 line):
- line 310: [SuppressMessage(FxCop.Category.StyleCopMaintainability, FxCop.Rule.FileMayOnlyContainASingleClass, Justification = "TODO:huich - Need to fix.")]
src/prod/src/managed/Api/src/System/Fabric/Common/GetSelectedPartitionStateAction.cs (1 line):
- line 38: // TODO: make these actions which store state locally as well.
src/properties/_service_fabric_native_user_common_pre.props (1 line):
- line 71: TODO: In order for retail wastorage to be usable, we will either need to wait for
src/prod/src/managed/ClusterAnalysis/TraceAccessLayer/StoreConnection/LocalTraceStoreConnectionInformation.cs (1 line):
- line 20: // TODO : Is there a legit case where one of these values can be null/empty?
src/prod/src/Common/RegistryKeyLinux.cpp (1 line):
- line 130: // TODO Option for REG_EXPAND_SZ is to be added. Bug 9012047
src/prod/src/managed/ClusterAnalysis/AnalysisCore/Insights/Agents/AnalysisSchedulingInformation.cs (1 line):
- line 225: /// TODO:: Fix Suspended???
src/prod/src/Common/LargeInteger.h (1 line):
- line 18: // TODO: Add Move constructor
src/prod/src/Management/healthmanager/ReplicaEntity.cpp (1 line):
- line 93: // TODO: check service and application attributes as well
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReplicatedStore/DifferentialStore/TVersionedItem.cs (1 line):
- line 335: // TODO: Potential optimization:
src/prod/src/managed/Api/Dlls/Microsoft.ServiceFabric.DeploymentManager/Common/StandAloneClusterManifestBuilder.cs (1 line):
- line 203: // TODO Chrissie: When the seed node removal causing the intermediate seed node shift bug is fixed, remove this parameter from add node scenario.
src/prod/src/Hosting2/RuntimeRegistrationTable.cpp (1 line):
- line 69: // TODO: provide better error code
src/prod/ktl/src/src/kvolumenamespace.cpp (1 line):
- line 556: // TODO: Add unit test
src/prod/src/Reliability/LoadBalancing/PlacementCreator.cpp (1 line):
- line 424: // TODO: is the following code used?
src/prod/src/Reliability/Failover/fm/DeleteServiceAction.cpp (1 line):
- line 31: // TODO: Do not lock the FailoverUnit
src/prod/src/managed/Api/src/System/Fabric/FabricValidatorConstants.cs (1 line):
- line 179: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
src/prod/src/Management/ClusterManager/DeploymentType.h (1 line):
- line 17: V2Application = 2 // TODO: Finalize names
src/prod/src/ServiceModel/modelV2/ApplicationDescription.cpp (1 line):
- line 32: // TODO: Remove this validation when we support 'dynamic' services under application.
src/prod/src/managed/fabricis/parallel/dll/Actions/ExecuteJobAction.cs (1 line):
- line 34: // TODO: Validate that state is already Executing; this action can have ActionType.None because
src/prod/src/ServiceModel/modelV2/SettingDescription.cpp (1 line):
- line 33: // TODO: Invalid path
src/prod/src/Reliability/Failover/ra/Upgrade.UpgradeMessageProcessor.cpp (1 line):
- line 137: // TODO: Unit tests for this
src/prod/src/managed/Autopilot/ServiceFabricEnvironmentSync/CertificateManager.cs (1 line):
- line 208: // TODO: report health
src/prod/src/Common/IoBuffers.h (1 line):
- line 70: // TODO: cleanup reinterpret_cast mess
src/prod/ktl/src/src/kthreadpool.cpp (1 line):
- line 2141: // TODO: consider cleaning the thread if we are going to use it more -which we are now;
src/prod/src/Reliability/LoadBalancing/Constants.cpp (1 line):
- line 16: // TODO: verify other load metrics should not have the same name with it
src/prod/src/inc/clr/metadata.h (1 line):
- line 133: // TODO: remove this when we remove m_cursor from the HENUMInternal structure
src/prod/src/reliablemessaging/ReliableMessagingHeaders.h (1 line):
- line 166: // TODO: this should really be const but for now we don't want to preclude the assignment operator
src/prod/ktl/src/src/kawipcheap.cpp (1 line):
- line 688: // TODO: Can this occur when the heap is too fragmented ?
src/prod/src/managed/ClusterAnalysis/AnalysisCore/CallbackStore/BaseCallbackStore.cs (1 line):
- line 373: // TODO: This may not be most accurate when the scenario represent expiring of an event. For now
src/prod/src/Federation/RoutingManager.h (1 line):
- line 73: std::set routedMessageProcessingSet_; // TODO: refactor into a common threadsafe set
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReplicationHelper.cs (1 line):
- line 101: // TODO: once 5052175 is fixed and FabricNotReadable is split into transient/non-transient cases, don't retry on it
src/prod/src/managed/Api/src/System/Fabric/ImageStore/FolderCopy.cs (1 line):
- line 21: /// TODO: implement copy flags:
src/prod/src/managed/fabricis/autopilot/dll/IAutopilotDMClient.cs (1 line):
- line 11: // TODO IDisposable?
src/prod/src/Hosting2/InProcessApplicationHostProxy.h (1 line):
- line 84: ApplicationHostIsolationContext const & isolationContext, // TODO: This should not be needed.
src/prod/src/Lease/sys/LeaseAgent.c (1 line):
- line 3106: // TODO - work around recreated relationship for termination message
src/prod/src/Transport/LTSendBuffer.cpp (1 line):
- line 123: //LINUXTODO avoid data copying during encryption
src/prod/src/managed/ClusterAnalysis/AnalysisCore/Insights/BaseInsightGenerator.cs (1 line):
- line 36: /// TODO: Persist time the Object was first created. That will be insight start time.
src/prod/src/managed/ClusterAnalysis/Common/Config/RunMode.cs (1 line):
- line 10: // TODO: I may refactor this a bit in future.
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReplicatedStore/Disk/FileMetadata.cs (1 line):
- line 295: // TODO Enable the assert below once item 5861402 is fixed.
src/prod/src/managed/Microsoft.ServiceFabric.Instrumentation/Tracing/Readers/AzureTableReader/ServiceFabricAzureAccessDataDecorator.cs (1 line):
- line 108: // TODO: Refine this Logic.
src/prod/src/data/tstore/StoreKeysEnumerator.h (1 line):
- line 71: // TODO:
src/prod/ktl/src/inc/MgmtService.h (1 line):
- line 102: // TODO: list of objects/URI that are handled
src/prod/src/Reliability/LoadBalancing/Service.cpp (1 line):
- line 120: // TODO: update the isSingleton_ here when we have the dynamic partitioning
src/prod/src/BlockStore/Service/Native/inc/common.h (1 line):
- line 99: // TODO: Revisit this to make it dynamic.
src/prod/src/Management/HttpTransport/ClientRequest.GetResponseBodyAsyncOperation.cpp (1 line):
- line 85: HttpConstants::MaxEntityBodySize) // TODO: This should be changed to settings.xml
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/DataStructures/Concurrent/ConcurrentSkipList.cs (1 line):
- line 622: // TODO: Is MemoryBarrier required?
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/BackupManager/IncrementalBackupLogRecordAsyncEnumerator.cs (1 line):
- line 73: // TODO: verify startingEpoch & startingLsn is not invalid
src/prod/src/managed/DCA/unittests/TestUtility.cs (1 line):
- line 152: // TODO - Investigate fix and return to Assert.Equal (RDBug 11404901)
src/prod/src/ServiceModel/ServiceModelConfig.h (1 line):
- line 120: // TODO: Change this back to 8192 when the ktllogger daemon is
src/prod/src/data/tstore/KeyBlockAlignedWriter.h (1 line):
- line 184: // TODO: account for key metadata correctly.
src/prod/src/Common/Serialization.h (1 line):
- line 10: #include ///TODO: move to Common/Types.h
src/prod/src/managed/FabricBRS/src/System/Fabric/BackupRestore/Service/BackupRestoreServiceBroker.cs (1 line):
- line 15: [SuppressMessage(FxCop.Category.Design, FxCop.Rule.TypesThatOwnDisposableFieldsShouldBeDisposable, Justification = "// TODO: Implement an IDisposable, or ensure cleanup.")]
src/prod/src/ServiceModel/ServicePartitionQueryResult.h (1 line):
- line 77: // TODO: DYNAMIC_SIZE_ESTIMATION_MEMBER(currentConfigurationEpoch_) ?
src/prod/src/Reliability/Failover/ReliabilitySubsystem.cpp (1 line):
- line 325: // TODO: Refactor this so that it is a little cleaner
src/prod/src/Reliability/Failover/ra/LocalStorageInitializer.cpp (1 line):
- line 72: // TODO: Can we parallelize this to use all cores
src/prod/src/data/txnreplicator/loggingreplicator/BackupFolderInfo.cpp (1 line):
- line 181: // TODO: This exception needs to be considered.
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReplicatedStore/DifferentialStore/TConsolidatingStoreComponent.cs (1 line):
- line 267: // // TODO: We only require two variables.
src/prod/src/Hosting2/FabricActivatorClient.cpp (1 line):
- line 4449: MessageUPtr response = make_unique(notification); // TODO: We should return empty message.
src/prod/src/managed/EventsStore/EventsStore.EventsReader/ConfigReader/AzureTableConsumer.cs (1 line):
- line 83: // TODO: We need to improve this Logic.
src/prod/src/managed/SFComposeExe/SFCompose.cs (1 line):
- line 128: // TODO: Log
src/prod/src/ktllogger/sys/ktlshim/unify/DevIoCtlUser.cpp (1 line):
- line 572: // TODO: Remove this KInvariant before release
src/prod/src/data/utilities/TaskUtilities.h (1 line):
- line 11: // TODO: Remove template parameter from here
src/prod/src/managed/FabricUS/src/system/fabric/upgradeservice/WRP/ApplicationClient.cs (1 line):
- line 91: // TODO: Can deletions end up in a failed state?
src/prod/src/Management/ClusterManager/ProcessInfrastructureTaskContextAsyncOperation.cpp (1 line):
- line 548: // TODO: 4240470: pass in correct baseline and upgrade domain list
src/prod/src/managed/Api/src/System/Fabric/InfrastructureServiceBroker.cs (1 line):
- line 14: [SuppressMessage(FxCop.Category.Design, FxCop.Rule.TypesThatOwnDisposableFieldsShouldBeDisposable, Justification = "// TODO: Implement an IDisposable, or ensure cleanup.")]
src/prod/src/managed/fabricis/parallel/dll/Actions/CreateInPreparingAction.cs (1 line):
- line 36: // TODO additional info in executordata
src/prod/src/httpgateway/getfilefromuploadasyncoperation.cpp (1 line):
- line 72: //TODO: This will be changed to the async write after the COM::File is updated to support append mode at item #7564216
src/prod/src/Common/Threadpool.Linux.cpp (1 line):
- line 7: // TODO: Replace with our implementation.
src/prod/src/managed/Microsoft.ServiceFabric.FabricTransport/FabricTransport/Common/Helper.cs (1 line):
- line 28: // TODO: Copy shld be removed
src/prod/src/client/ServiceAddressTrackerCallbacks.h (1 line):
- line 143: // TODO: 847196, support notifications for all partitions:
src/prod/src/data/tstore/ConsolidationTask.h (1 line):
- line 10: // TODO: Make this more general??
src/prod/src/Reliability/Failover/ra/ComServicePartitionBase.h (1 line):
- line 12: //TODO move other common code from ComStatelessServicePartition and ComStatefulServicePartition into this base class
src/prod/src/managed/Api/src/System/Fabric/Interop/StringResult.cs (1 line):
- line 13: // TODO: evaluate whether we should have an explicit callback to Dispose, or if we should copy to HGLOBAL?
src/prod/ktl/src/src/kawipcserverclientconnection.cpp (1 line):
- line 125: // TODO: What else can we do ?
src/prod/src/Management/healthmanager/ReplicatedStoreWrapper.cpp (1 line):
- line 119: // TODO: consider using the following to avoid copying when replicated store supports it
src/prod/src/Store/ReplicatedStore.cpp (1 line):
- line 1368: // TODO: In 'develop' branch, FM used to have its own wrapper implementing
src/prod/src/data/interop/ReliableCollectionServiceStandalone/ReliableCollectionServiceStandalone.cpp (1 line):
- line 221: // @TODO - Better error checking by returning error back to managed in CExportTests
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/BackupManager/BackupFolderInfo.cs (1 line):
- line 124: // TODO: Improve.
src/prod/src/managed/ClusterAnalysis/Common/Runtime/IInsightRuntime.cs (1 line):
- line 58: /// TODO: Consider moving it out of this generic interface into implementation. Kids can cast and check.
src/prod/src/managed/Api/src/System/Fabric/Common/Tracing/IVariantEventWriter.cs (1 line):
- line 29: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
src/prod/src/inc/clr/contract.h (1 line):
- line 20: // @ARMTODO: Disable for ARM for now, contracts slow down the debug build far too much
src/prod/src/data/utilities/ConcurrentHashTableEnumerator.h (1 line):
- line 12: // TODO: Lock-free enumeration
src/prod/ktl/src/logger/tools/RawLoggerPerf/RawLoggerPerf.cpp (1 line):
- line 780: // TODO: include all parameters for the run
src/prod/src/managed/Api/src/System/Fabric/Management/fabricdeployer/DockerDnsHelper.cs (1 line):
- line 344: // Dism COM errors aren't well understood yet across different OSes. TODO Handle specific error codes and throw the rest
src/prod/src/Hosting2/ServiceFactoryRegistrationTable.h (1 line):
- line 30: //TODO: serviceTypeId is required as a part of End as caller is not aware about the type of operation
src/prod/src/Common/XmlLiteWriter.Linux.cpp (1 line):
- line 13: // UTF-8 to UTF-16 Conversion. TODO: wchar_t seems still 4-bytes in to_bytes()
src/prod/src/LeaseAgent/LeasePartner.cpp (1 line):
- line 281: //TODO change the timeout from magic number to FederationConfig constant.
src/prod/src/Naming/EntreeServiceToProxyIpcChannel.h (1 line):
- line 111: Common::RwLock lock_; // TODO rename
src/prod/src/LeaseAgent/LeaseAgent.h (1 line):
- line 17: // TODO: LeaseAgent and LeasePartner Source Code will be moving to ~src\Lease\Api directory later.
src/prod/src/managed/Microsoft.ServiceFabric.Instrumentation/Tracing/Core/Definition/ByteValueReader.cs (1 line):
- line 466: // TODO: Will have to check on Linux if this needs an ifdef.
src/prod/src/data/tstore/MergeHelper.cpp (1 line):
- line 157: // TODO: Fix the workaround below until item 5861402 is fixed.
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReplicatedStore/Disk/KeyBlockAlignedWriter.cs (1 line):
- line 188: // TODO: account for key metadata correctly.
src/prod/src/BlockStore/Service/Native/inc/BlockStorePayload.h (1 line):
- line 113: // TODO: Merge these fields into one
src/prod/src/Common/JsonReaderWriter.h (1 line):
- line 12: // TODO move nodeid to common.
src/prod/ktl/src/logger/dbgext/KtlLogExt.cpp (1 line):
- line 98: // TODO: don't be so recursive
src/prod/src/Reliability/Failover/fm/RebuildContext.cpp (1 line):
- line 436: // TODO: processing load information.
src/prod/src/managed/FabricUS/src/system/fabric/upgradeservice/Program.cs (1 line):
- line 40: // TODO: Ctrl+C handler is not supported on CoreCLR Linux. Need to work to find alternate.
src/prod/src/managed/System.Fabric.Wave/Wave/WaveController.cs (1 line):
- line 337: // TODO: Consider Asserting if these fail.
src/prod/src/Management/ClusterManager/ClearSingleInstanceDeploymentUpgradeContextAsyncOperation.cpp (1 line):
- line 108: //TODO: Deal with scenario that UD failed in the middle
src/prod/src/managed/Api/src/System/Fabric/Testability/Client/Requests/RemoveUnreliableTransportBehaviorRequest.cs (1 line):
- line 50: // TODO: Wait for some time so that the removal of this unreliable transport behavior can be read from the files.
src/prod/shared/ktlwf/logger/managed/tools/readperf/Program.cs (1 line):
- line 105: writer.WriteAttributeString("Value", "ComputerName"); // TODO: COmputername
src/prod/shared/serialization/inc/FabricStream.h (1 line):
- line 78: KArray<_CallbackInfo> completionCallbacks_; // TODO: use a delegate
src/prod/ktl/src/tools/installer/install.cpp (1 line):
- line 92: // TODO: Make into parameters
src/prod/src/managed/FabricUOS/exe/UpgradeOrchestrator.cs (1 line):
- line 471: cabPath = Path.Combine(FabricEnvironment.GetDataRoot(), System.Fabric.FabricDeployer.Constants.FileNames.BaselineCab); // TODO: Needs to come from image store
src/prod/src/Reliability/Failover/FederationWrapper.cpp (1 line):
- line 385: // TODO: when not in reliable master mode, no need to create the context.
src/prod/src/Hosting2/Constants.cpp (1 line):
- line 95: // TODO: figure out why passing in quotes in the arg is causing failure in Linux. We need to support spaces in paths
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/MemoryLogicalLog.cs (1 line):
- line 320: // TODO: Implement reverse logic of truncatehead
src/prod/src/inc/clr/corjit.h (1 line):
- line 228: TODO: This could be changed to call CORINFO_HELP_VERIFICATION_RUNTIME_CHECK
src/prod/src/Naming/EntreeServiceProxy.cpp (1 line):
- line 621: error = ErrorCodeValue::InvalidCredentials; // TODO: bharatn: create new error code InvalidClaims
src/properties/ktl/imports/KtlKernelImports.props (1 line):
- line 53:
src/prod/src/data/tstore/VolatileCopyManager.h (1 line):
- line 280: // TODO: Use TTL; left as an example
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/SerializationManager/DataContractStateSerializer.cs (1 line):
- line 33: // TODO: Make sure this is safe.
src/prod/src/Reliability/Failover/common/Constants.cpp (1 line):
- line 57: // TODO: update after finalize the upgrade domain issues.
src/prod/src/managed/Api/src/System/Fabric/GatewayResourceManagerBroker.cs (1 line):
- line 16: [SuppressMessage(FxCop.Category.Design, FxCop.Rule.TypesThatOwnDisposableFieldsShouldBeDisposable, Justification = "// TODO: Implement an IDisposable, or ensure cleanup.")]
src/prod/src/Management/CentralSecretService/CentralSecretServiceFactory.cpp (1 line):
- line 102: //TODO: create an internal CLSID and do a QueryInterface
src/prod/src/Management/FileStoreService/PendingWriteOperations.h (1 line):
- line 40: // TODO: A tree implementation would
src/prod/src/data/txnreplicator/logrecordlib/ProgressVector.h (1 line):
- line 71: // TODO: Remove STL later
src/prod/src/managed/Container/VolumePlugin/AzureFiles/Common/Utilities.cs (1 line):
- line 42: // TODO: Avoid returning a string because strings are immutable and hence we cannot clear out the
src/prod/src/data/txnreplicator/loggingreplicator/TestLogRecordUtility.cpp (1 line):
- line 344: // TODO: Move all usages in PhysicalLogRecord.Test to this static method
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/utils/ByteAlignedReadWriteHelper.cs (1 line):
- line 82: // MCoskun TODO: This can be turned into Test Assert.
src/prod/src/managed/Api/src/System/Fabric/BackupRestore/AzureBlobBackupStoreManagerBase.cs (1 line):
- line 82: // TODO: Add following files in concurrent bag and run loop with scheduled number of threads to upload these in parallel.
src/prod/src/Reliability/Failover/ra/FailoverUnitProxy.cpp (1 line):
- line 1282: // TODO: This should not be needed on every single UC message
src/prod/ktl/src/src/kawipcringproducer.cpp (1 line):
- line 251: // TODO: Not sure what to do here
src/prod/src/ktllogger/sys/ktlshim/ContainerShimUser.cpp (1 line):
- line 120: // TODO: Implement this
src/prod/src/managed/Api/src/System/Fabric/health/ClusterUpgradeHealthPolicy.cs (1 line):
- line 32: // TODO: establish correct default values - should be taken from native/configuration?
src/prod/src/BlockStore/Service/Native/inc/trace.h (1 line):
- line 85: // TODO: Change to 0 before merging
src/prod/src/Management/ClusterManager/ImageBuilderProxy.h (1 line):
- line 402: class BuildSingleInstanceApplicationForUpgradeAsyncOperation; // TODO: Make this common code between CGS
src/prod/src/Transport/MulticastSendTarget.h (1 line):
- line 18: // TODO: implement iterator pattern?
src/prod/src/managed/Autopilot/ServiceFabricEnvironmentSync/ConfigurationManager.cs (1 line):
- line 28: * TODO: currently AP safe config deployment is not supported to update configurations.
src/prod/src/Common/FileLock.Linux.cpp (1 line):
- line 87: // LINUXTODO investigate how/when to delete the file
src/prod/src/Common/Throw.cpp (1 line):
- line 27: // TODO: determine proper error codes to use in the assert statements
src/prod/src/Store/TSEnumerationBase.cpp (1 line):
- line 53: // TODO: This needs to be optimized for the copy notification case.
src/prod/src/Reliability/Failover/ra/Test.StateMachine.Close.cpp (1 line):
- line 430: // TODO: this can be optimized by ra remembering the delete intent
src/prod/src/ServiceModel/ComposeDeploymentUpgradeDescription.cpp (1 line):
- line 117: // TODO : Make this common code between all upgrade input parsing.
src/prod/src/inc/clr/corhdr.h (1 line):
- line 247: // @TODO: This is required because we pull in the COM+ 2.0 PE header
src/prod/src/Reliability/Failover/ra/FailoverUnitProxy.UserApiInvoker.cpp (1 line):
- line 55: TODO: The medata should also come from the code that invokes the API
src/prod/src/httpgateway/NetworksHandler.cpp (1 line):
- line 699: // TODO: Remove when update network is implemented
src/prod/src/Transport/MessageIdHeader.h (1 line):
- line 23: //DENY_COPY_ASSIGNMENT(MessageIdHeader); TODO: deny later
src/prod/src/data/interop/ReliableCollectionRuntimeImpl/StoreKeyValueEnumeratorCExports.cpp (1 line):
- line 11: // TODO remove this
src/prod/src/managed/ClusterAnalysis/Common/Config/Config.cs (1 line):
- line 45: /// TODO: Refactor it out.
src/prod/src/Reliability/Failover/ra/ProxyErrorCode.h (1 line):
- line 24: TODO: Optimize the above
src/prod/src/managed/Api/src/System/Fabric/FabricTokenClaimResult.cs (1 line):
- line 13: [SuppressMessage(FxCop.Category.Design, FxCop.Rule.TypesThatOwnDisposableFieldsShouldBeDisposable, Justification = "// TODO: Implement an IDisposable, or ensure cleanup.")]
src/prod/src/Transport/MessageHeaders.cpp (1 line):
- line 619: // TODO this is somewhat redundant with CheckPoint, and could be skipped if enumerating header chunks did not include
src/prod/src/Reliability/LoadBalancing/PLBDiagnostics.cpp (1 line):
- line 84: //TODO: Implement Smarter Logic Here Eventually -- Such as if the cluster is under FabricUpgrade
src/prod/src/data/tstore/LongLongStore.Perf.cpp (1 line):
- line 312: // TODO: Revisit with new KTL threadpool
src/prod/src/data/tstore/Checkpoint.Stress.cpp (1 line):
- line 828: // TODO: Following tests fail because of negative size assert
src/prod/src/managed/BackupCopier/BackupCopier.cs (1 line):
- line 69: StringConstants.WorkingDir, // TODO: Revisit to see if this is needed.
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Log/LogManager.cs (1 line):
- line 463: // TODO asnegi: RDBug #10278280 Adding 0xc0190021 as it is expected HResult for exception. However, it seems that it is not being
src/prod/src/data/utilities/BinaryReader.h (1 line):
- line 27: // TODO: Remove Copy
src/prod/src/api/wrappers/ComProxyStatelessServiceFactory.cpp (1 line):
- line 50: // TODO: create proxy for the stateless service
src/prod/src/managed/Api/src/System/Fabric/health/ApplicationHealthPolicyMap.cs (1 line):
- line 42: //// TODO: Add test for this class. RDBUG # 3290604
src/prod/src/Hosting2/ApplicationHostManager.cpp (1 line):
- line 446: // TODO: Add a GetOrAdd() function to activation table itself as it is already thread safe.
src/prod/src/managed/EtlReader/EventDefinitionDescription.cs (1 line):
- line 280: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
src/prod/src/ktllogger/sys/ktlshim/ContainerShimKernel.cpp (1 line):
- line 1046: // TODO: abort all other requests
src/prod/src/managed/FabricUOS/src/system/fabric/UpgradeOrchestrationService/TestEventSource.cs (1 line):
- line 12: // TODO: replace this with trace into product
src/prod/src/managed/Api/src/System/Fabric/Testability/Client/PowershellManager.cs (1 line):
- line 47: // TODO: this currently doesn't catch all exceptions
src/prod/src/managed/FabricUS/src/system/fabric/upgradeservice/WRP/ApplicationTypeClient.cs (1 line):
- line 227: return ResultStatus.InProgress; // TODO: Should we create an Unknown/Invalid status?
src/prod/src/Reliability/Failover/ra/Test.Unit.FMMessageState.cpp (1 line):
- line 416: // TODO: In the future this can be an assert
src/prod/src/managed/EtlReader/EventRecordEventArgs.cs (1 line):
- line 24: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
src/prod/src/Reliability/Failover/fm/ReplicaUpdateTask.cpp (1 line):
- line 112: // TODO: Get the Replica by ReplicaId.
src/prod/src/Lease/linux/leaselayerio.h (1 line):
- line 315: //LINUXTODO consider removing EventBuffer
src/prod/src/Naming/ServiceNotificationManager.cpp (1 line):
- line 1153: // TODO special case passthrough transport
src/prod/src/Transport/MemoryTransport.cpp (1 line):
- line 213: // TODO: handle message dropping
src/prod/src/data/utilities/StatusConverter.cpp (1 line):
- line 171: // TODO: If we need round-trip conversion, we may have to provide our own HRESULT_FROM_NT
src/prod/src/managed/ClusterAnalysis/AnalysisCore/Insights/Agents/TimeTriggeredAgent.cs (1 line):
- line 47: // TODO: Persist
src/prod/src/Common/AccountHelper.cpp (1 line):
- line 686: // TODO: improve password generation by using a secret
src/prod/src/query/GetServicePartitionListQuerySpecification.cpp (1 line):
- line 32: // TODO: Set the query iD
src/prod/src/inc/clr/daccess.h (1 line):
- line 1342: // ROTORTODO - g++ 3 doesn't like the use of the operator& in __GlobalVal
src/prod/src/Federation/OneWayReceiverContext.cpp (1 line):
- line 32: // TODO: If we reject a one way message we can potentially send some messages back about ring state
src/prod/src/Management/healthmanager/ProcessInnerQueryRequestAsyncOperation.cpp (1 line):
- line 673: // TODO: add application health policy map
src/prod/src/ServiceGroup/Service/ServiceGroup.StatefulService.cpp (1 line):
- line 4921: // TODO: Remove sequence number logic above and use the new out param
src/prod/src/managed/Api/src/System/Fabric/Management/ImageBuilder/ApplicationInstanceBuilder.cs (1 line):
- line 1503: // TODO [dragosav]: look into renaming the EnvVarTypeType to something more generic,
src/prod/ktl/src/linuxinc/palio.h (1 line):
- line 190: //TODO Find a better place for this ...
src/prod/src/BlockStore/Service/Native/inc/boost_async_awaitable.h (1 line):
- line 15: // @TODO - Move this into reliable_collections.h
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReliableMessaging/stream/Tracing.cs (1 line):
- line 14: // TODO: differentiate between noise and info for stable tracing
src/prod/src/httpgateway/HttpKerberosAuthHandler.cpp (1 line):
- line 120: true, // TODO: should this be configurable?
src/prod/src/Transport/Message.cpp (1 line):
- line 507: : buffers_(/*std::move*/(buffers)), callback_(callback), state_(state), totalSize_(0) // TODO: make buffers movable, bug in our stl implementation
src/prod/src/managed/FabricFAS/src/system/fabric/faultanalysisservice/FaultAnalysisServiceRoot/Actions/Steps/InvokeQuorumLossSteps.cs (1 line):
- line 59: // TODO: Wait for some time so that the unreliable transport behavior can be read from the files.
src/prod/src/Management/BackupRestore/BA/RequestResponseAsyncOperationBase.h (1 line):
- line 44: Transport::MessageUPtr reply_; // TODO: This should be private
src/prod/src/Common/ErrorCode.cpp (1 line):
- line 313: //LINUXTODO consider removing HRESULT_FROM_WIN32 below (revert back to commit fab0ac79d978d646454ca13561154f031b5008c8),
src/prod/src/managed/Api/src/System/Fabric/TokenValidationServiceBroker.cs (1 line):
- line 15: [SuppressMessage(FxCop.Category.Design, FxCop.Rule.TypesThatOwnDisposableFieldsShouldBeDisposable, Justification = "// TODO: Implement an IDisposable, or ensure cleanup.")]
src/prod/src/Management/healthmanager/DeployedServicePackageEntity.cpp (1 line):
- line 81: // TODO: check application attributes
src/prod/src/Hosting2/ComGuestServiceReplica.cpp (1 line):
- line 299: // TODO: Report Health.
src/prod/src/managed/fabricis/serial/dll/Helpers/VolatileLastCompletedJobStepInfo.cs (1 line):
- line 21: /// TODO - create an interface, a factory (and a factory interface) and pass the factory interface in the constructor to the
src/prod/src/Lease/linux/stdafx.cpp (1 line):
- line 12: // TODO: reference any additional headers you need in STDAFX.H
src/prod/ktl/src/linuxinc/paldef.h (1 line):
- line 1009: #if 0 // TODO: Remove
src/prod/src/Management/ApplicationGateway/Http/GatewayRequestHandler.SendRequestToServiceAsyncOperation.cpp (1 line):
- line 367: // TODO: This just disconnects the request to service to prevent leaks, this should also clean
src/prod/src/managed/EventsStore/EventStore.Service/EventStoreService.cs (1 line):
- line 59: // TODO - Move the caching enabled Param to Config
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/LogRecordsDispatcher.cs (1 line):
- line 166: // TODO: GopalK, currently all barrier operations are full barriers.
src/prod/src/managed/FabricFAS/src/system/fabric/faultanalysisservice/FaultAnalysisServiceRoot/Actions/Steps/RestartPartitionSteps.cs (1 line):
- line 220: // TODO: Wait for some time so that the unreliable transport behavior can be read from the files.
src/prod/src/managed/Api/src/System/Fabric/Common/CleanTestStateAction.cs (1 line):
- line 44: // TODO: Wait for some time so that the removal of this unreliable transport behavior can be read from the files.
src/prod/src/data/utilities/ComProxyOperationData.h (1 line):
- line 21: // TODO: We could avoid the copy in the future
src/prod/ktl/src/src/kawipcserverpipeendpoint.cpp (1 line):
- line 696: // TODO: Replace with KFinally when there is one that works with
src/prod/ktl/src/src/kchecksum.cpp (1 line):
- line 2426: #if !defined(PLATFORM_UNIX) // FIXME: _mm_crc32_u64 replacement
src/prod/shared/serialization/src/FabricSerializable.cpp (1 line):
- line 167: // TODO: this is also weird
src/prod/src/BlockStore/Service/Native/src/ServiceMain.cpp (1 line):
- line 7: // TODO: Review this.
src/prod/src/Management/healthmanager/PartitionEntity.cpp (1 line):
- line 96: // TODO: check application attributes
src/prod/src/managed/Api/src/System/Fabric/BackupRestore/BackupScheduler.cs (1 line):
- line 103: Interlocked.CompareExchange(ref this._syncPoint, -1, 0); // TODO: Do we need this syncPoint?
src/prod/src/managed/Api/src/System/Fabric/Testability/Client/Structures/ReplicaResource.cs (1 line):
- line 18: //TODO:
src/prod/src/Management/ApplicationGateway/Http/Constants.cpp (1 line):
- line 17: // TODO: Check if these strings are ok and consistent with the other places we ask for partitionkind
src/prod/ktl/src/src/kblockfile.cpp (1 line):
- line 7442: // TODO: is _FileSize correct ??? Does it matter ??
src/prod/src/ServiceModel/ServiceGroupTypeDescription.cpp (1 line):
- line 376: //TODO: Reading the description extensions from the xml is pending
src/prod/src/data/tstore/ConcurrentDictionary2.h (1 line):
- line 14: // TODO: Temporary name, Reconcile with ConcurrentDictionary post Ignite
src/prod/src/managed/fabricis/parallel/dll/Helpers/BondHelper.cs (1 line):
- line 15: /// TODO - fix this
src/prod/src/data/utilities/ReaderWriterAsyncLock.h (1 line):
- line 72: __in int timeoutInMilliSeconds); //TODO: Make this private
src/prod/src/managed/Api/src/System/Fabric/Common/ValidateServiceAction.cs (1 line):
- line 38: // TODO: make these actions which store state locally as well.
src/prod/src/managed/FabricBRS/src/System/Fabric/BackupRestore/Service/BackupRestoreService.cs (1 line):
- line 80: // TODO: Ensure that the requests dont come in before we do the necessary initializations which are being done below
src/prod/src/Management/ApplicationGateway/Http/GatewayRequestHandler.SendResponseToClientAsyncOperation.cpp (1 line):
- line 248: // TODO: THis just disconnects the request to service to prevent leaks, this should also clean
src/prod/src/Management/NetworkInventoryManager/lib/NIMNetworkInventoryAllocationManager.cpp (1 line):
- line 272: // TODO: handle accounting for open network as well
src/prod/src/data/tstore/KeyValueList.h (1 line):
- line 77: throw ktl::Exception(K_STATUS_OBJECT_NOT_ATTACHED); //TODO: Out of capacity. KStatus doesn't have this we shall create one in KTL?
src/prod/src/managed/Microsoft.ServiceFabric.FabricTransport.V2/Runtime/FabricTransportListener.cs (1 line):
- line 28: //TODO: Remove this address update after Bug :1225032 gets resolved
src/prod/src/Common/TextTraceWriter.cpp (1 line):
- line 528: // TODO: Is there a better way to convert TextA. Can we pass that
src/prod/src/managed/ClusterAnalysis/AnalysisCore/Helpers/InsightsUtil.cs (1 line):
- line 83: // TODO: Investigate why UTF16 is causing crashes and then switch to it
src/prod/src/ServiceModel/HealthInformation.h (1 line):
- line 99: SERIALIZABLE_PROPERTY(Constants::TimeToLiveInMs, timeToLive_)// TODO Update publicapi
src/prod/src/ktllogger/sys/ktlshim/alias.cpp (1 line):
- line 389: alias, // TODO: Pass KString ??
src/prod/src/Naming/NamingStore.cpp (1 line):
- line 147: // TODO: Optimize with GetSequenceNumber API from v2 stack
src/prod/src/managed/Api/src/System/Fabric/Management/ImageBuilder/ImageBuilderUtility.cs (1 line):
- line 742: // TODO: would codepackage versions be different than manifest version?
src/prod/src/Naming/ServiceNotificationManagerProxy.h (1 line):
- line 95: __out Transport::ISendTarget::SPtr &); // TODO: returns a sptr copy, can this be optimized to return a ref?
src/prod/src/reliablemessaging/ReliableMessageId.h (1 line):
- line 12: // TODO: add compare to Common::Guid to avoid Guid copying here
src/prod/src/data/tstore/MetadataTable.cpp (1 line):
- line 91: refCount = referenceCount_; // TODO: volatile read?
src/prod/src/ServiceModel/NodeQueryResult.cpp (1 line):
- line 256: // TODO: ToString needs to be changed since JSON doesnt serialize the clusterconnectionport
src/prod/src/managed/EtlReader/EventDefinition.cs (1 line):
- line 89: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
src/prod/src/data/tstore/MockTransactionalReplicator.h (1 line):
- line 65: // TODO: Remove
src/prod/src/managed/ClusterAnalysis/Common/Duration.cs (1 line):
- line 34: // TODO: Think of something better to enforce this.
src/prod/src/Transport/TcpSendBuffer.cpp (1 line):
- line 101: //LINUXTODO avoid data copying during encryption
src/prod/src/Common/ConfigSettingsOverride.cpp (1 line):
- line 71: w.Write("TODO {");
src/prod/src/managed/Api/src/System/Fabric/KeyValueStoreReplica.cs (1 line):
- line 2516: return backupCallback.Invoke(backupInfo, CancellationToken.None); // TODO: Fix the cancellation token
src/prod/src/managed/Api/src/System/Fabric/Management/fabricvalidator/FabricValidatorUtility.cs (1 line):
- line 153: //TODO: Remove above conditional code block as this logic should work for both FullFx and CoreCLR.
src/prod/src/pal/src/internal/rt/safemath.h (1 line):
- line 186: // TODO: Any way to prevent unintended instantiations? This is only designed to
src/prod/src/managed/Api/src/System/Fabric/FaultAnalysisServiceBroker.cs (1 line):
- line 20: [SuppressMessage(FxCop.Category.Design, FxCop.Rule.TypesThatOwnDisposableFieldsShouldBeDisposable, Justification = "// TODO: Implement an IDisposable, or ensure cleanup.")]
src/prod/src/ServiceModel/HealthInformation.cpp (1 line):
- line 158: // TODO: 7953769: we should disallow system reports sent by public users.
src/prod/src/ktllogger/sys/ktlshim/globalobj.cpp (1 line):
- line 63: // TODO: At some point allow read only access to the stream
src/prod/src/Management/healthmanager/SequenceStreamRequestContext.cpp (1 line):
- line 70: 0, /*TODO: remove, not used*/
src/prod/src/Reliability/LoadBalancing/PLBConfig.h (1 line):
- line 33: //TODO: add validation for all configurations
src/prod/src/BlockStore/SFBDMiniport/sfbdctl/stdafx.cpp (1 line):
- line 8: // TODO: reference any additional headers you need in STDAFX.H
src/prod/src/Management/ClusterManager/ReplaceSingleInstanceDeploymentContextAsyncOperation.cpp (1 line):
- line 38: TimeSpan::FromMinutes(2), // TODO: this should be a configurable timeout within max val.
src/prod/src/data/interop/ReliableCollectionRuntimeImpl/StateManagerChangeHandler.cpp (1 line):
- line 62: // @TODO - Fix KTL so that KUri LPCWSTR conversion has correct const-ness
src/prod/src/managed/FabricFAS/src/system/fabric/faultanalysisservice/ClusterAnalysisService/Services/PersistentStore.cs (1 line):
- line 388: // TODO: Better Manage Scrub Task
src/prod/src/httpgateway/ApplicationTypesHandler.cpp (1 line):
- line 56: // TODO - check if this URI is correct
src/prod/src/Management/HttpTransport/HttpServer.cpp (1 line):
- line 501: // TODO: Handler unregistration.
src/prod/src/managed/fabricis/autopilot/dll/AutopilotInfrastructureCoordinator.cs (1 line):
- line 310: // TODO consider retrying the fetch/reconcile/execute block, to avoid
src/prod/src/managed/Api/src/System/Fabric/StatelessServiceBroker.cs (1 line):
- line 14: [SuppressMessage(FxCop.Category.Design, FxCop.Rule.TypesThatOwnDisposableFieldsShouldBeDisposable, Justification = "// TODO: Implement an IDisposable, or ensure cleanup.")]
src/prod/src/Management/HttpTransport/IHttpClientRequest.h (1 line):
- line 56: // TODO: might need to get additional info to lookup incase of auth failures/challenges
src/prod/src/reliablemessaging/ReliableMessagingPartitionKey.cpp (1 line):
- line 65: // TODO: Notifications for all partitions are not currently supported;
src/prod/src/managed/Api/src/System/Fabric/Management/fabricdeployer/DeployerTrace.cs (1 line):
- line 23: // TODO - Following code will be removed once fully transitioned to structured traces in Linux
src/prod/ktl/src/src/kawipcring.cpp (1 line):
- line 167: // TODO: Consider usefulness of these error codes
src/prod/src/Management/FileStoreService/FileStoreServiceFactory.cpp (1 line):
- line 103: //TODO: create an internal CLSID and do a QueryInterface
src/prod/src/managed/Api/src/System/Fabric/Chaos/RandomActionGenerator/StateSnapshot.cs (1 line):
- line 89: // TODO: RDBug 7635808 : Test and see if DeployedPartition
src/prod/src/Reliability/Failover/ra/Hosting.ServiceTypeMap.cpp (1 line):
- line 62: // TODO: This logic needs to be moved out of here
src/prod/src/reliablemessaging/ReliableSessionAsyncOperations.h (1 line):
- line 127: // TODO: the environment should really be baked into all these pooled resources at the environment level
src/prod/src/Reliability/Failover/ra/Infrastructure.EntityJobItem.h (1 line):
- line 423: // TODO: Use a common action queue in the entity executor async operation
src/prod/src/BlockStore/Service/Native/src/CNetworkStream.cpp (1 line):
- line 7: // TODO: Review this.
src/prod/src/managed/fabricis/parallel/dll/Actions/MoveToPreparingAction.cs (1 line):
- line 64: // TODO: See if this can be removed by allowing health policy updates via UpdateRepairExecutionStateAsync
src/prod/src/client/ClientServerTransport/ClientServerPassThroughTransport.cpp (1 line):
- line 290: // TODO: Expiration could be maxvalue, sanitize it.
src/prod/src/inc/clr/safemath.h (1 line):
- line 175: // TODO: Any way to prevent unintended instantiations? This is only designed to
src/prod/src/httpgateway/ApplicationsResourceHandler.cpp (1 line):
- line 150: // TODO - return the description with status.
src/prod/src/inc/clr/clrconfig.h (1 line):
- line 25: // * Look at the available config files (system, application, host and user). For details see TODO:
src/prod/src/ktllogger/sys/ktlshim/coalescerecords.cpp (1 line):
- line 620: // TODO: make _MaxBytesPaddingWhenUnderPressure a config
src/prod/src/managed/ClusterAnalysis/AnalysisCore/Insights/PartitionInsight/PrimaryMoveAnalysis/PrimaryMoveAnalysisAgent.cs (1 line):
- line 227: // TODO: Break report fault analysis into two separate analyses because ReplicaStateChange already shows which one of the two happened
src/prod/src/Reliability/Failover/ra/ReconfigurationAgentProxy.ActionListExecutorAsyncOperation.cpp (1 line):
- line 55: // TODO: Remove after race condition is addressed
src/prod/src/managed/Api/src/System/Fabric/Common/FabricClientRetryErrors.cs (1 line):
- line 20: /// TODO: RDBug 11875738: FabricClientRetryErrors.All: Fill the info using reflection over the all defined retryable error rules per operation.
src/prod/ktl/src/src/kawipcserver.cpp (1 line):
- line 368: // TODO: What else can we do ?
src/prod/src/Management/FileStoreService/InternalFileStoreClient.cpp (1 line):
- line 477: // TODO: handle continuation token. if received, continue to get pages.
src/prod/src/data/utilities/ConcurrentHashTable.h (1 line):
- line 395: // TODO: Grow locks array?
src/prod/src/managed/Microsoft.ServiceFabric.Instrumentation/Tracing/Runner/Program.cs (1 line):
- line 92: // TODO: Investigate why UTF16 is causing crashes and then switch to it
src/prod/src/Management/ClusterManager/ProcessComposeDeploymentContextAsyncOperation.cpp (1 line):
- line 204: //TODO: If IB build fails, this path should fail applicationtype. Consider fail app as well in the following path.
src/prod/src/inc/clr/legacyactivationshim.h (1 line):
- line 1253: { /*@TODO: Static bind version, if necessary*/ \
src/prod/src/Management/RepairManager/ClientRequestAsyncOperation.cpp (1 line):
- line 108: // TODO IsRetryable?
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/SerializationManager/SerializationManager.cs (1 line):
- line 76: // TODO: Add Support for prefix matching.
src/prod/src/Management/DnsService/src/DnsService.cpp (1 line):
- line 169: // TODO: Better to use KAsyncService?
src/prod/src/data/txnreplicator/loggingreplicator/TransactionMap.cpp (1 line):
- line 289: ASSERT_IFNOT(recordSPtr.RawPtr() == keyFoundInPendingTxPair.RawPtr(), "Invalid log record"); // TODO: Verify validity of this assert
src/prod/src/Reliability/Failover/ra/Test.Infrastructure.TestEntity.h (1 line):
- line 85: // TODO: Make the ut context the root of the RA
src/prod/src/managed/FabricUS/src/system/fabric/upgradeservice/WRP/ApplicationCommandProcessor.cs (1 line):
- line 35: // TODO: ContinuationToken support
src/prod/src/Transport/SecurityContextWin.cpp (1 line):
- line 781: // TODO error code
src/prod/src/Hosting2/ComGuestServiceInstance.cpp (1 line):
- line 197: // TODO: Report Health.
src/prod/src/Hosting2/OperationStatusMap.h (1 line):
- line 37: // TODO: Convert this to Structured Tracing completely
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/ReplicatedStore/Disk/BlockAlignedWriter.cs (1 line):
- line 19: // TODO: Make it configurable.
src/prod/src/Reliability/LoadBalancing/MovePlan.h (1 line):
- line 67: // TODO: update the two count when we allow dynamic configuration on the two throttling
src/prod/src/data/tstore/SnapshotComponent.h (1 line):
- line 68: // TODO: Determine whether this is actually needed
src/prod/src/ServiceModel/federation/NodeIdGenerator.cpp (1 line):
- line 183: // TODO: Another hash generator has been added based on Pearson algorithm; this one, at some point,
src/prod/src/Management/HttpTransport/ClientRequest.h (1 line):
- line 87: // TODO: might need to get additional info to lookup incase of auth failures/challenges
src/prod/src/ServiceModel/ComposeDeploymentUpgradeProgress.h (1 line):
- line 172: // TODO: Start time is not accurate yet. Only in "Application Upgrade" scope.
src/prod/src/Reliability/Failover/ra/Test.Utility.StateReader.h (1 line):
- line 165: // TODO: add fields over here. For now keeping empty
src/prod/ktl/src/inc/karray.h (1 line):
- line 732: // TODO: Why is this not using move semantics - kept the same for back compat in just in case
src/prod/src/Hosting2/FabricUpgradeManager.cpp (1 line):
- line 134: // TODO: Bug# 1136788 - Implement TransitionCallerHolds_Lock method in StateMachine.h
src/prod/src/Reliability/Failover/common/ReplicaListMessageBody.cpp (1 line):
- line 14: // TODO: structured tracing for a map
src/prod/src/managed/Api/src/System/Fabric/Management/ImageBuilder/DockerCompose/ComposeServiceTypeDescription.cs (1 line):
- line 180: // TODO: logging.
src/prod/src/managed/Autopilot/ServiceFabricAutopilotAgent/ServiceFabricAutopilotAgentStatus.cs (1 line):
- line 52: // TODO: when adding dynamic topology support, the expected topology does not need to be discovered.
src/prod/src/managed/Api/src/System/Fabric/Management/ImageBuilder/FabricProvisionOperation.cs (1 line):
- line 71: // TODO: Once FabricTest has been modified to generate InfrastructureManifest.xml file, we should not
src/prod/src/Transport/TcpReceiveBuffer.cpp (1 line):
- line 153: // TODO verify the crc/checksum
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/Replicator/ReaderWriterAsyncLock.cs (1 line):
- line 477: // TODO: convert to structured tracing and add the correct trace type
src/prod/src/managed/ClusterAnalysis/AnalysisCore/ClusterAnalysisEngine.cs (1 line):
- line 53: // Add the connection to Runtime. TODO Get rid of this and pass this explicitly.
src/prod/src/Hosting2/LogCollectionProviderFactory.cpp (1 line):
- line 116: // TODO: create correct provider based on the infrastructure
src/prod/src/Common/HeapAllocAllocator.h (1 line):
- line 14: // TODO: add support for HeapAlloc options, such as ZERO_INIT
src/prod/src/Common/AccessToken.cpp (1 line):
- line 1048: //TODO: what is the purpose of these?
src/prod/src/ServiceModel/naming/PartitionedServiceDescWrapper.h (1 line):
- line 153: protected: // TODO: Are all these below need to be protected??
src/prod/src/Common/ComUtility.cpp (1 line):
- line 105: return ErrorCode(ErrorCodeValue::InvalidState); // TODO: return correct error code
src/prod/ktl/src/src/kxm/user/KXMApiKernel.cpp (1 line):
- line 115: KXMCloseIoCompletionPort(DevFD, (HANDLE)cmd.Handle); // TODO: Check for errors ?
src/prod/src/Hosting2/ClearContainerHelper.cpp (1 line):
- line 139: std::wstring logDirectory = L"/mnt/logs"; // TODO read this value from the cluster manifest
src/prod/ktl/src/inc/KAsyncService.h (1 line):
- line 464: // BUG: TODO: richhas merge into common base class.
src/prod/src/Reliability/LoadBalancing/BalanceCheckerCreator.cpp (1 line):
- line 107: // TODO:
src/prod/src/managed/Api/src/System/Fabric/Common/ValidateApplicationServicesAction.cs (1 line):
- line 36: // TODO: make these actions which store state locally as well.
src/prod/src/Common/X509PubKey.cpp (1 line):
- line 32: //LINUXTODO enable algorithm comparison
src/prod/src/data/txnreplicator/statemanager/CheckpointManager.cpp (1 line):
- line 185: // TODO: RDBug 13398799: Trace PerformCheckpoint in volatile case
src/prod/src/managed/Microsoft.ServiceFabric.Data.Impl/DataStructures/BloomFilter.cs (1 line):
- line 29: // rahku- TODO change to long
src/prod/src/client/ClientServerTransport/ClientServerRequestMessage.h (1 line):
- line 19: // TODO: implement Http transport message
src/prod/src/Store/TSLocalStore.cpp (1 line):
- line 215: nullptr, // TODO: healthClient
src/prod/src/Management/BackupRestore/BA/NodeToNodeAsyncOperation.cpp (1 line):
- line 212: this->RemainingTime, // TODO: Need to fix retry timeout
src/prod/src/Management/RepairManager/RepairTaskHistory.h (1 line):
- line 24: // TODO add for all if needed
src/prod/src/LeaseAgent/DummyLeaseDriver.cpp (1 line):
- line 313: //TODO: Delete the registed application. Might never be done.
src/prod/ktl/src/linuxinc/palhandle.h (1 line):
- line 33: // TODO: Put this back in when the issue found in FabricRM.test is
src/prod/src/data/interop/ReliableCollectionRuntimeImpl/StateProviderFactory.cpp (1 line):
- line 89: // TODO add trace