External/Xal/Source/Xal/Include/Xal/xal_generic.h (6 lines): - line 21: // TODO collapse the 2 structs? the only thing missing from this one is the - line 26: _Field_z_ char const* appId; // TODO do we want to just use the titleId here? or the msa app id? - line 28: _Field_z_ char const* osName; // TODO use the device type? - line 29: _Field_z_ char const* osVersion; // TODO dupe - line 31: _Field_z_ char const* deviceClass; // TODO use the device type? - line 32: _Field_z_ char const* deviceId; // TODO dupe Source/Services/TCUI/iOS/title_callable_ui.mm (4 lines): - line 38: /* TODO 1808 - line 67: /* TODO 1808 - line 99: /* TODO 1808 - line 129: /* TODO 1808 Source/Services/Multiplayer/multiplayer_internal.h (3 lines): - line 63: // TODO fix this. If external member objects move around things break - line 116: xsapi_internal_vector m_groups; // TODO these never get deserialized - line 117: xsapi_internal_vector m_encounters; // TODO these never get deserialized Source/Services/Multiplayer/Manager/multiplayer_manager_internal.h (3 lines): - line 215: // TODO is there a better way to do this? - line 1409: MultiplayerEventQueue DoWork(); // TODO see if we can switch these to ref - line 1577: // TODO remove in favor of assignment operator Source/Shared/xsapi_json_utils.cpp (2 lines): - line 123: //TODO: Verify UTF8 format is maintained - line 552: //TODO: Throw exception here Source/Services/Multiplayer/Manager/multiplayer_lobby_client.cpp (2 lines): - line 93: // TODO this should be changed such that nothing here needs to depend on the GlobalState. - line 1788: // TODO remove this and add locking to event queue class Source/Services/Multiplayer/Manager/multiplayer_client_manager.cpp (2 lines): - line 561: // TODO have a way to set async queue here - line 892: // Note: This function does not require a lock. Caller already has a m_clientRequestLock TODO is this actually true? Source/Services/Notification/notification_api.cpp (2 lines): - line 276: // TODO really should be returning HRESULT E_INVALIDARG here - line 320: // TODO really should be returning HRESULT E_INVALIDARG here Source/Services/Multiplayer/Manager/multiplayer_session_writer.cpp (2 lines): - line 198: // TODO this may need to be invoked on another thread - line 241: // TODO this may need to be invoked on another thread Source/Services/Multiplayer/Manager/multiplayer_game_client.cpp (2 lines): - line 55: // TODO this should be changed such that nothing here needs to depend on the GlobalState. - line 334: // TODO we should have a way to configure the queue here Source/Services/Multiplayer/Manager/multiplayer_client_pending_reader.cpp (2 lines): - line 224: // TODO: add logging for error message - line 402: // TODO should be able to control the async queue here Source/Services/Multiplayer/multiplayer_session.cpp (2 lines): - line 289: // TODO remove this after fixing member management - line 2954: // TODO: is this correct? Source/Services/Social/social_api.cpp (1 line): - line 207: // TODO really should be returning HRESULT E_INVALIDARG here Include/cpprestinclude/cpprest/streams.h (1 line): - line 307: // TODO in the future this could be improved to have Value2StringFormatter avoid another unnecessary copy Source/System/a/java_interop.h (1 line): - line 60: // TODO This is a temporary workaround for TCUI. XSAPI C++ TCUI API's accept a xal_user_handle, from which we extract Include/xsapi-cpp/impl/xbox_service_call_routed_event_args.hpp (1 line): - line 41: // TODO a lot of these fields are not exposed from the hc_call_handle. Need to expose in libHttpClient to expose them from xsapi. Source/Services/Multiplayer/Manager/multiplayer_local_user_manager.cpp (1 line): - line 321: // TODO allow setting queue Source/Shared/xsapi_utils.cpp (1 line): - line 501: // TODO: remove Include/xsapi-cpp/impl/xbox_live_context.hpp (1 line): - line 4: // TODO exclude this from build and include in xbox_live_context.h. Circular dependency currently prevents this, Include/cpprestinclude/cpprest/details/asyncrt_utils.hpp (1 line): - line 35: // TODO 1808 #include Include/xsapi-c/title_storage_c.h (1 line): - line 20: #define XBL_TITLE_STORAGE_BLOB_ETAG_MAX_LENGTH (18 * 3) // TODO confirm with Azure Blob Services team Source/Shared/xbox_live_app_config_internal.h (1 line): - line 18: // TODO Remove. Unsafe method - returns null if GlobalState doesn't exist and is unchecked by callers Source/Shared/HookedUri/details/asyncrt_utils.hpp (1 line): - line 35: // TODO 1808 #include Include/xsapi-c/multiplayer_c.h (1 line): - line 1141: #define XBL_MULTIPLAYER_DEVICE_TOKEN_MAX_LENGTH 40 // TODO confirm max size, not a GUID Source/Shared/http_call_wrapper_internal.cpp (1 line): - line 367: //TODO: consider keeping a JsonDocument member instead of parsing every time Source/Services/Events/events_service_xsapi.cpp (1 line): - line 161: //TODO: [natiskan] Write telemetry to keep track of failed 400s. Source/Services/Multiplayer/Manager/multiplayer_local_user.cpp (1 line): - line 26: // TODO parameterize RTAManager Source/Shared/http_utils.cpp (1 line): - line 39: // TODO 1808 #include Source/System/iOS/XBLiOSGlobalState.mm (1 line): - line 16: // TODO 1808 return gLaunchViewController ?: [XBLIDPScenario getTopViewController]; Source/Shared/global_state.h (1 line): - line 100: // TODO consider configuring this with XblInitArgs External/Xal/Source/Xal/Include/Xal/xal_user.h (1 line): - line 63: STDAPI XalUserGetId( // TODO any valid error scenarios? local users, consent Include/xsapi-c/xbox_live_context_settings_c.h (1 line): - line 175: // TODO these probably should be moved somewhere else, they aren't really related to context settings Source/Shared/global_state.cpp (1 line): - line 83: // TODO Should make the java interop singleton a member of GlobalState rather than a separate static Source/Shared/public_utils_legacy.cpp (1 line): - line 306: //TODO: Throw exception