genie-web/src/main/java/com/netflix/genie/web/data/services/impl/jpa/JpaPersistenceServiceImpl.java (10 lines): - line 159: // TODO: Double check the docs on this as default is runtime exception and error... may want to incorporate them - line 307: // TODO: Still more optimization that can be done here to not load these entities - line 544: // TODO: Still more optimization that can be done here to not load these entities - line 850: // TODO: Still more optimization that can be done here to not load these entities - line 1539: // TODO: Metrics - line 1695: // TODO: The AOP aspects are firing on a lot of these APIs for retries and we may not want them to given a lot of - line 1711: // TODO: Perhaps could use jobEntity.isResolved here also but wouldn't check the case that the job was in a - line 1728: // TODO: It might be nice to set the status message as well to something like "Job claimed by XYZ..." - line 1731: // TODO: Should these be required? We're reusing the DTO here but perhaps the expectation at this point - line 1778: // TODO: Should we prevent updating status for statuses already covered by "reserveJobId" and genie-web/src/main/java/com/netflix/genie/web/services/impl/JobResolverServiceImpl.java (7 lines): - line 161: // TODO: Switch to path - line 185: final CommandSelector commandSelector, // TODO: For now this is a single value but maybe support List - line 232: // TODO: Possible improvement to combine this query with a few others to save DB trips but for now... - line 245: * TODO: There is currently a gap in database schema where the resolved CPU value is not persisted. This - line 583: // TODO: What do we do about application status? Should probably check here - line 766: // TODO: Disable ability to disable archival for all jobs during internal V4 migration. - line 850: // TODO: This runs the risk of diverging from DB query mechanism. Perhaps way to unite somewhat? genie-web/src/main/java/com/netflix/genie/web/tasks/leader/DatabaseCleanupTask.java (5 lines): - line 52: // TODO: The intention of this class is clear, it is to have the leader trigger a database cleanup action periodically - line 74: // TODO: May want to make this a property - line 79: // TODO: May want to make this a property - line 81: // TODO: May want to make this a property. Currently this maintains consistent behavior with before but it would - line 227: // TODO: Maybe we shouldn't reset it to midnight no matter what... just go with runtime minus something genie-common-internal/src/main/java/com/netflix/genie/common/internal/dtos/converters/DtoConverters.java (5 lines): - line 504: .withArchivingDisabled(/*v3JobRequest.isDisableLogArchival()*/ false) //TODO: Stop ignoring flag [GENIE-657] - line 703: // TODO: Remove this eventually once we're satisfied v3 statuses have been flushed - line 768: // TODO: Remove this eventually once we're satisfied v3 statuses have been flushed - line 833: // TODO: Remove this eventually once we're satisfied v3 statuses have been flushed - line 948: // TODO: Remove this eventually once we're satisfied v3 statuses have been flushed genie-web/src/integTest/java/com/netflix/genie/web/apis/rest/v3/controllers/JobRestControllerIntegrationTest.java (5 lines): - line 454: // TODO: Flipped during V4 migration to always be on to replicate expected behavior of V3 until clients - line 803: // TODO these are not populated - line 836: // TODO: These are not populated - line 980: // TODO: This is flipped during V4 migration and should be changed back once clients are fixed - line 1590: // TODO '/output' behaves differently than the rest. genie-common-internal/src/main/java/com/netflix/genie/common/internal/aws/s3/S3ClientFactory.java (4 lines): - line 126: // TODO: Perhaps this should be just set to null if the bucket properties are empty as we'll never need it? - line 204: // TODO: Do something about allowing ClientConfiguration to be passed in - line 214: // TODO: Perhaps rename with more detailed info? - line 229: // TODO: Perhaps want to supply more options? genie-web/src/main/java/com/netflix/genie/web/events/GenieEventBusImpl.java (4 lines): - line 69: // TODO: Metric here? - line 79: // TODO: Metric here? - line 159: // TODO: Metric here? - line 169: // TODO: Metric here? genie-web/src/main/java/com/netflix/genie/web/services/impl/JobDirectoryServerServiceImpl.java (3 lines): - line 268: // TODO: Once we determine what we want for V4 use v3/v4 flags or some way to differentiate - line 269: // TODO: there's no unit test covering this section - line 373: // TODO: This throws InvalidMediaTypeException. Not sure if should bother handing it here or not seeing genie-web/src/main/java/com/netflix/genie/web/services/impl/JobLaunchServiceImpl.java (3 lines): - line 176: // TODO: Failed to update the status to accepted. Try to set it to failed or rely on other cleanup - line 182: // TODO: at the moment this is not populated, it's going to be a null node (not null) - line 193: // TODO: How will we get the ID back to the user? Should we add it to an exception? We don't get genie-common-internal/src/main/java/com/netflix/genie/common/internal/aws/s3/S3ProtocolResolver.java (2 lines): - line 76: * TODO: It would be nice to use Spring's HttpRange for this parsing, but this module does not - line 148: // TODO: This implementation from Spring Cloud AWS always wraps the passed in client with a proxy that follows genie-web/src/integTest/java/com/netflix/genie/web/data/services/impl/jpa/JpaPersistenceServiceImplJobsIntegrationTest.java (2 lines): - line 603: //TODO: add more cases - line 1223: // TODO: Switch to compare results of a get once implemented to avoid collection transaction problem genie-common-internal/src/main/java/com/netflix/genie/common/internal/dtos/DirectoryManifest.java (2 lines): - line 395: // TODO: Not sure if we should do this or skip subtree or just continue and ignore it? - line 465: // TODO: Move configuration of special handling cases to external configuration for flexibility genie-web/src/main/java/com/netflix/genie/web/data/services/impl/jpa/queries/projections/v4/JobRequestProjection.java (2 lines): - line 37: // TODO: Clean this up as things get more finalized to break out fields into reusable super interfaces - line 51: // TODO: As we move more to V4 as default move this to more shared location genie-web/src/main/java/com/netflix/genie/web/agent/resources/AgentFileResourceImpl.java (2 lines): - line 151: //TODO: Doable, could resolve to API URL. Unclear what value this would add. - line 203: //TODO: Doable if a reference to AgentFileStreamService is kept. Unclear what value this would add. genie-web/src/main/java/com/netflix/genie/web/agent/launchers/impl/LocalAgentLauncherImpl.java (2 lines): - line 150: // TODO: These metrics should either be renamed or tagged so that it's easier to slice and dice them - line 284: // TODO: What happens if the server crashes? Does the process live on? Make sure this is totally detached genie-web/src/integTest/java/com/netflix/genie/web/apis/rest/v3/controllers/ClusterRestControllerIntegrationTest.java (2 lines): - line 312: //TODO: Add tests for searching by min and max update time as those are available parameters - line 313: //TODO: Add tests for sort, orderBy etc genie-common-internal/src/main/java/com/netflix/genie/common/internal/services/impl/JobArchiveServiceImpl.java (2 lines): - line 69: // TODO: This relies highly on convention. Might be nicer to better abstract with database - line 109: // TODO: Perhaps we should pass the manifest down to the archive implementations if they want to use it? genie-agent/src/main/java/com/netflix/genie/agent/cli/GenieAgentRunner.java (1 line): - line 104: //TODO: workaround for https://jira.spring.io/browse/SPR-17416 genie-demo/src/main/docker/client/example/run_trino_job.py (1 line): - line 32: # TODO: The Trino executable ends up executing in a different working directory and can't find the script file genie-web/src/main/java/com/netflix/genie/web/spring/autoconfigure/agent/apis/rpc/servers/AgentRpcServersAutoConfiguration.java (1 line): - line 73: @Value("${grpc.server.port:0}") final int port, // TODO: finalize how to get configure this property genie-web/src/main/java/com/netflix/genie/web/data/services/impl/jpa/converters/EntityV4DtoConverters.java (1 line): - line 298: // TODO: For now this is a generic GenieRuntimeException. If we would like more advanced logic at the genie-web/src/main/java/com/netflix/genie/web/data/services/impl/jpa/repositories/JpaJobRepository.java (1 line): - line 55: // TODO: Make interfaces generic but be aware of https://jira.spring.io/browse/DATAJPA-1185 genie-web/src/integTest/java/com/netflix/genie/web/data/services/impl/jpa/JpaPersistenceServiceIntegrationTestBase.java (1 line): - line 66: PersistedJobStatusObserver.class //TODO: Needed for JobEntityListener but should be in DataAutoConfiguration genie-web/src/main/java/com/netflix/genie/web/agent/launchers/dtos/TitusBatchJobRequest.java (1 line): - line 38: // TODO: This class and the nested classes likely could benefit from a builder pattern but I'm just too busy to tackle genie-web/src/main/java/com/netflix/genie/web/services/impl/RequestForwardingServiceImpl.java (1 line): - line 75: // TODO: Enable retries? genie-web/src/main/java/com/netflix/genie/web/apis/rest/v3/hateoas/assemblers/JobExecutionModelAssembler.java (1 line): - line 79: // TODO: https://github.com/spring-projects/spring-hateoas/issues/186 should be fixed in .20 currently .19 genie-web/src/main/java/com/netflix/genie/web/apis/rest/v3/controllers/GenieExceptionMapper.java (1 line): - line 64: // TODO: Not changing this while changing controller package due to need to keep dashboards in sync but we should genie-web/src/main/java/com/netflix/genie/web/agent/services/impl/AgentJobServiceImpl.java (1 line): - line 169: // TODO: How to handle this? genie-web/src/main/java/com/netflix/genie/web/data/services/impl/jpa/queries/projections/v4/JobSpecificationProjection.java (1 line): - line 75: // TODO: Figure out how to use nested projections for linked entities. It'll work but the fact genie-agent/src/main/java/com/netflix/genie/agent/execution/process/impl/JobProcessManagerImpl.java (1 line): - line 302: /* TODO: HACK, Process does not expose PID in Java 8 API */ genie-agent-app/src/main/java/com/netflix/genie/GenieAgentApplication.java (1 line): - line 64: //TODO: workaround for https://jira.spring.io/browse/SPR-17416 genie-web/src/main/java/com/netflix/genie/web/resources/writers/DefaultDirectoryWriter.java (1 line): - line 122: // TODO: replace with something related to Genie genie-web/src/main/java/com/netflix/genie/web/apis/rest/v3/controllers/JobRestController.java (1 line): - line 363: // TODO: refactor this ad-hoc checks into a component allowing more flexible logic (and can be replaced/extended) genie-web/src/main/java/com/netflix/genie/web/data/services/impl/jpa/entities/JobEntity.java (1 line): - line 324: // TODO: Drop this column once search implemented via better mechanism genie-web/src/main/java/com/netflix/genie/web/apis/rest/v3/hateoas/assemblers/JobRequestModelAssembler.java (1 line): - line 79: // TODO: https://github.com/spring-projects/spring-hateoas/issues/186 should be fixed in .20 currently .19 genie-common-internal/src/main/java/com/netflix/genie/common/internal/services/JobArchiver.java (1 line): - line 34: // TODO: Move this to the agent codebase once v3 embedded execution is removed from the server genie-web/src/main/java/com/netflix/genie/web/scripts/ClusterSelectorManagedScript.java (1 line): - line 91: // TODO: Remove once internal scripts migrate to use context directly genie-app/src/smokeTest/java/com/netflix/genie/GenieAppSmokeTest.java (1 line): - line 62: // TODO: Could add more genie-web/src/main/java/com/netflix/genie/web/apis/rest/v3/controllers/ApplicationRestController.java (1 line): - line 191: // TODO: This doesn't take into account others as compounded find...not sure if good or bad genie-agent/src/main/java/com/netflix/genie/agent/execution/services/impl/FetchingCacheServiceImpl.java (1 line): - line 71: * TODO:Use shared file lock for reading and exclusive lock for writing to the cache genie-web/src/main/java/com/netflix/genie/web/services/impl/ArchivedJobServiceImpl.java (1 line): - line 139: // TODO: This is pretty hardcoded and we may want to store direct link genie-web/src/main/java/com/netflix/genie/web/data/services/impl/jpa/repositories/JpaClusterRepository.java (1 line): - line 57: // TODO: Could use different lock mode genie-web/src/main/java/com/netflix/genie/web/agent/services/AgentFileStreamService.java (1 line): - line 48: * @param uri the file uri //TODO redundant genie-web/src/main/java/com/netflix/genie/web/scripts/CommandSelectorManagedScript.java (1 line): - line 85: // TODO: Remove once internal scripts migrate to use context directly genie-web/src/main/java/com/netflix/genie/web/scripts/AgentLauncherSelectorManagedScript.java (1 line): - line 86: // TODO: Remove once internal scripts migrate to use context directly genie-common-internal/src/main/java/com/netflix/genie/common/internal/dtos/AgentConfigRequest.java (1 line): - line 50: // TODO: Switch to Path genie-app/src/main/java/com/netflix/genie/GenieApp.java (1 line): - line 31: // TODO: We probably should handle these in an environment post processor so that it's universal genie-web/src/main/java/com/netflix/genie/web/agent/launchers/impl/TitusAgentLauncherImpl.java (1 line): - line 450: // TODO: Address defaults? genie-client/src/integTest/java/com/netflix/genie/client/GenieClientIntegrationTestBase.java (1 line): - line 63: // TODO: Improve genie-app image packaging to leverage unpacked (application plugin) based agent so that startup genie-common-internal/src/main/java/com/netflix/genie/common/internal/services/JobDirectoryManifestCreatorService.java (1 line): - line 32: // TODO: Move this into the Agent codebase once v3 embedded execution no longer needed on server genie-web/src/main/java/com/netflix/genie/web/data/services/impl/jpa/repositories/JpaBaseRepository.java (1 line): - line 44: // TODO: Make interfaces generic but be aware of https://jira.spring.io/browse/DATAJPA-1185 genie-web/src/main/java/com/netflix/genie/web/apis/rest/v3/hateoas/assemblers/JobModelAssembler.java (1 line): - line 65: // TODO: https://github.com/spring-projects/spring-hateoas/issues/186 should be fixed in .20 currently .19 genie-web/src/main/java/com/netflix/genie/web/health/GenieAgentHealthIndicator.java (1 line): - line 52: // TODO: For now just set it to always be up till we have better metrics. Likely want to tie this to gRPC genie-common-internal/src/main/java/com/netflix/genie/common/internal/services/JobArchiveService.java (1 line): - line 33: // TODO: Move this to the agent codebase once v3 embedded execution removed from server genie-web/src/main/java/com/netflix/genie/web/apis/rest/v3/controllers/ClusterRestController.java (1 line): - line 196: // TODO: This doesn't take into account others as compounded find...not sure if good or bad genie-web/src/integTest/java/com/netflix/genie/web/apis/rest/v3/controllers/ApplicationRestControllerIntegrationTest.java (1 line): - line 414: //TODO: Add tests for sort, orderBy etc genie-common/src/main/java/com/netflix/genie/common/dto/JobStatusMessages.java (1 line): - line 27: //TODO this class could go away and we could fold this into JobStatus genie-web/src/main/java/com/netflix/genie/web/apis/rest/v3/controllers/CommandRestController.java (1 line): - line 200: // TODO: This doesn't take into account others as compounded find...not sure if good or bad genie-web/src/integTest/java/com/netflix/genie/web/apis/rest/v3/controllers/CommandRestControllerIntegrationTest.java (1 line): - line 489: //TODO: Add tests for sort, orderBy etc genie-web/src/main/java/com/netflix/genie/web/spring/autoconfigure/tasks/TasksAutoConfiguration.java (1 line): - line 56: // TODO: Remove once agent job runs complete genie-web/src/main/java/com/netflix/genie/web/tasks/node/DiskCleanupTask.java (1 line): - line 47: //TODO: this is now only relevant for {@link com.netflix.genie.web.agent.launchers.impl.LocalAgentLauncherImpl}. genie-common-internal/src/main/java/com/netflix/genie/common/internal/configs/CommonServicesAutoConfiguration.java (1 line): - line 118: // TODO hardcoded configuration values