finagle-redis/src/main/scala/com/twitter/finagle/redis/ServerCommands.scala (24 lines): - line 10: // TODO: CLIENT KILL - line 12: // TODO: CLIENT LIST - line 14: // TODO: CLIENT GETNAME - line 16: // TODO: CLIENT PAUSE - line 18: // TODO: CLIENT SETNAME - line 38: // TODO: ROLE - line 40: // TODO: SHUTDOWN - line 45: // TODO: BGREWRITEAOF - line 47: // TODO: BGSAVE - line 49: // TODO: COMMAND - line 51: // TODO: COMMAND COUNT - line 53: // TODO: COMMAND GETKEYS - line 55: // TODO: COMMAND INFO - line 57: // TODO: CONFIG GET - line 59: // TODO: CONFIG REWRITE - line 61: // TODO: CONFIG SET - line 63: // TODO: CONFIG RESETSTAT - line 70: // TODO: DEBUG OBJECT - line 72: // TODO: DEBUG SEGFAULT - line 90: // TODO: LAST SAVE - line 92: // TODO: MONITOR - line 99: // TODO: SAVE - line 106: // TODO: SLOWLOG - line 108: // TODO: TIME finagle-http/src/main/scala/com/twitter/finagle/http/exp/routing/Parameter.scala (5 lines): - line 19: // TODO: missing Parameter properties (https://swagger.io/specification/#parameter-object): - line 50: // TODO - minimum, maximum, exclusive minimum, exclusive maximum, multipleOf - line 95: // TODO - add support for exploding path styles at https://swagger.io/docs/specification/serialization/ - line 97: // TODO - array support - line 98: // TODO - object support (https://swagger.io/specification/#schema-object) finagle-mux/src/main/scala/com/twitter/finagle/mux/lease/exp/Lessor.scala (4 lines): - line 10: // TODO: should no longer be private[finagle] when the api is locked down - line 11: // TODO: should not just work with Duration, ie be generic - line 12: // TODO: Lessors should expose capabilities - line 13: // TODO: npending is specific to servers, and isn't meaningful for other types finagle-mux/src/main/scala/com/twitter/finagle/mux/lease/exp/Coordinator.scala (4 lines): - line 40: // TODO: given that discount should be consistent for a generation, it doesn't - line 49: // TODO: wake up more often to see if the target - line 61: // TODO: if grabbing memory info is slow, rewrite this to only check memory info occasionally - line 70: // TODO MN: reenable finagle-postgresql/src/main/scala/com/twitter/finagle/postgresql/machine/ExecuteMachine.scala (4 lines): - line 105: // TODO: we can avoid sending this one when the Prepare phase already returned NoData. - line 118: // TODO: we can avoid this one by reusing the one in the first execution. Not sure what the best API for this is yet. - line 170: // TODO: the ReadyForQuery here is fake - line 174: // TODO: handle discard() to client can cancel the stream finagle-http/src/main/scala/com/twitter/finagle/http/SpnegoAuthenticator.scala (3 lines): - line 300: * TODO: Remove after http and http are merged - line 319: * TODO: Remove after http and http are merged - line 362: * TODO: naive implementation: every request arriving at the filter begins from the finagle-benchmark/src/main/scala/com/twitter/finagle/balancersim/Simulation.scala (2 lines): - line 132: // TODO: These latency events are dependent on the running time of - line 223: // TODO: export standard deviation. finagle-mysql/src/main/scala/com/twitter/finagle/mysql/ClientDispatcher.scala (2 lines): - line 250: // TODO: When streaming is implemented the done signal should be - line 274: * TODO: This result should be streaming via some construct finagle-postgresql/src/main/scala/com/twitter/finagle/postgresql/transport/PgBuf.scala (2 lines): - line 89: // TODO: not clear what to do about strings that contain the null byte? - line 266: // TODO: this is actually a bit mask, but it's not clear if any other values are possible anyway finagle-postgresql/src/main/scala/com/twitter/finagle/postgresql/machine/SimpleQueryMachine.scala (2 lines): - line 104: // TODO: handle discard() to client can cancel the stream - line 122: case (state, _: NoticeResponse) => Transition(state, NoOp) // TODO: don't ignore finagle-redis/src/it/scala/com/twitter/finagle/redis/commands/transaction/TransactionClientIntegrationSuite.scala (2 lines): - line 59: // TODO: the exact error message varies in different versions of redis. fix this later - line 72: // TODO: the exact error message varies in different versions of redis. fix this later finagle-http/src/main/scala/com/twitter/finagle/http/exp/routing/PathMatcher.scala (2 lines): - line 203: else if (str.indexOf('/', idx) >= 0) None // TODO - spec compliant, but *will* break things - line 418: // TODO - TrieSpecMatcher finagle-redis/src/main/scala/com/twitter/finagle/redis/ConnectionCommands.scala (2 lines): - line 37: // TODO: ECHO - line 39: // TODO: PING with argument finagle-mux/src/main/scala/com/twitter/finagle/mux/lease/exp/ByteCounter.scala (2 lines): - line 102: // TODO: Wake up sleepers if the rate changes more than some - line 132: // TODO: W, P could be configurable--for some servers, 100ms may be too slow finagle-base-http/src/main/scala/com/twitter/finagle/http/QueryParamEncoder.scala (2 lines): - line 47: // TODO: URLEncoder is known to be slow, explore more efficient options. - line 53: // TODO: we can do better than a regex finagle-mux/src/main/scala/com/twitter/finagle/mux/transport/Message.scala (2 lines): - line 432: // TODO: Update this extractor in the event that we "fix" the control - line 470: // TODO: technically we should probably check for duplicate finagle-mux/src/main/scala/com/twitter/finagle/mux/lease/exp/ClockedDrainer.scala (2 lines): - line 255: // TODO: can this API be made easier to use? - line 258: // TODO: issue leases immediately. finagle-postgresql/src/it/scala/com/twitter/finagle/postgresql/RichClientSpec.scala (2 lines): - line 35: // TODO: COPY in CRDB cannot be done within a prepared statement - line 45: // TODO: COPY in CRDB cannot be done within a prepared statement finagle-thrift/src/main/scala/com/twitter/finagle/thrift/TTwitterServerFilter.scala (1 line): - line 87: // TODO: only try once? finagle-postgresql/src/main/scala/com/twitter/finagle/postgresql/types/ValueWrites.scala (1 line): - line 254: // TODO: Json is really only meant for reading... finagle-http2/src/main/scala/com/twitter/finagle/http2/transport/client/H2ClientFilter.scala (1 line): - line 124: // `FailureDetector` to kick in. TODO - look into using/validating unique content. finagle-exp/src/main/scala/com/twitter/finagle/exp/fiber_scheduler/fiber/ForkedFiber.scala (1 line): - line 93: * TODO check if it's possible to allocate the StopHandler on each execution instead of using a thread local finagle-mux/src/main/scala/com/twitter/finagle/mux/util/TagMap.scala (1 line): - line 150: // TODO: should we worry about releasing clear finagle-partitioning/src/main/scala/com/twitter/finagle/partitioning/PartitionNodeManager.scala (1 line): - line 154: // TODO we should return a DelayingServiceFactory until `observable` is no finagle-thriftmux/src/main/scala/com/twitter/finagle/ThriftMux.scala (1 line): - line 352: // TODO set the Path here. finagle-postgresql/src/it/scala/com/twitter/finagle/postgresql/PreparedStatementSpec.scala (1 line): - line 131: // TODO: investigate CRDB failure finagle-postgresql/src/main/scala/com/twitter/finagle/postgresql/machine/HandshakeMachine.scala (1 line): - line 111: case (state, _: BackendMessage.NoticeResponse) => Transition(state, NoOp) // TODO: don't ignore finagle-netty4/src/main/scala/com/twitter/finagle/netty4/channel/AbstractNetty4ClientChannelInitializer.scala (1 line): - line 105: // TODO: Figure out if it makes sense to bypass localhost connections when HTTP proxy is finagle-http2/src/main/scala/com/twitter/finagle/http2/param/Params.scala (1 line): - line 123: // TODO: revert to 8.kilobytes after we resolve https://github.com/netty/netty/issues/7511 finagle-base-http/src/main/scala/com/twitter/finagle/http/codec/ResponseConformanceFilter.scala (1 line): - line 15: * TODO: 1xx, 204, and 304 responses are not allowed to have bodies which is finagle-core/src/main/scala/com/twitter/finagle/Exceptions.scala (1 line): - line 623: * TODO: Probably remove this exception class once we migrate away from Netty finagle-postgresql/src/main/scala/com/twitter/finagle/postgresql/PgSqlTransporter.scala (1 line): - line 32: maxFrameLength = Int.MaxValue, // TODO: what's an appropriate value here? finagle-postgresql/src/main/scala/com/twitter/finagle/postgresql/BackendMessage.scala (1 line): - line 96: // TODO: parse out the fields to expose the category and sql state. finagle-thrift/src/main/scala/com/twitter/finagle/thrift/transport/ThriftClientPreparer.scala (1 line): - line 97: // TODO: also apply this for Protocols.binaryFactory finagle-mux/src/main/scala/com/twitter/finagle/mux/lease/exp/RequestSnooper.scala (1 line): - line 43: // TODO: do we want to buffer and then discard if there might have been a gc? finagle-benchmark/src/main/scala/com/twitter/finagle/http/ParamMapBenchmark.scala (1 line): - line 26: // TODO: this is a bit of a cheat since we fastpath values without a space in the new impl finagle-core/src/main/scala/com/twitter/finagle/util/DefaultTimer.scala (1 line): - line 80: // TODO: We might consider doing round-robin over the set of "default" timers in future. finagle-mux/src/main/scala/com/twitter/finagle/mux/lease/exp/LogsReceiver.scala (1 line): - line 40: // TODO: can we recycle logs so not so many of them end up in oldgen? finagle-core/src/main/scala/com/twitter/finagle/util/StackRegistry.scala (1 line): - line 33: // TODO: many case classes have a $outer field because they close over an outside scope. finagle-mux/src/main/scala/com/twitter/finagle/mux/pushsession/ClientTracker.scala (1 line): - line 29: // TODO: Our MessageWriter potentially contains unwritten dispatches which finagle-serversets/src/main/scala/com/twitter/finagle/zookeeper/ZkClientFactory.scala (1 line): - line 40: // TODO: Watchers are tied to the life of the client, finagle-core/src/main/scala/com/twitter/finagle/filter/MaskCancelFilter.scala (1 line): - line 9: // TODO: we should simply transform the stack for boolean finagle-core/src/main/scala/com/twitter/finagle/builder/ClientBuilder.scala (1 line): - line 154: * TODO: do we really need to specify HasCodec? -- it's implied in a finagle-postgresql/src/main/scala/com/twitter/finagle/postgresql/Errors.scala (1 line): - line 23: PgSqlNoSuchTransition(machine, state.toString, msg.toString) // TODO: Show or similar instead of toString finagle-netty4-http/src/main/scala/com/twitter/finagle/netty4/http/Netty4StreamTransport.scala (1 line): - line 145: // TODO (vk): PR against Netty; we need to construct out of given Headers so we avoid finagle-postgresql/src/it/scala/com/twitter/finagle/postgresql/types/ValueWritesSpec.scala (1 line): - line 38: // TODO: investigate CRDB failures finagle-redis/src/it/scala/com/twitter/finagle/redis/commands/key/KeyClientIntegrationSuite.scala (1 line): - line 89: // TODO: this isn't actually a TTL, which means that the second assertion finagle-core/src/main/scala/com/twitter/finagle/FactoryToService.scala (1 line): - line 25: // TODO: we should simply transform the stack for boolean finagle-mysql/src/main/scala/com/twitter/finagle/mysql/Parameter.scala (1 line): - line 208: //TODO: create an accessor to Parameter.wrap, so type errors are caught at compile time. finagle-netty4/src/main/java/com/twitter/finagle/netty4/codec/compression/zstd/ZstdStreamingEncoder.java (1 line): - line 27: // TODO: this breaks backpressure as the bytes are not really sent but since we only use finagle-thrift/src/main/scala/com/twitter/finagle/thrift/exp/partitioning/PartitioningStrategy.scala (1 line): - line 737: // TODO reconcile these types w/ req / rep finagle-http/src/main/scala/com/twitter/finagle/http/exp/routing/HttpRouter.scala (1 line): - line 267: // TODO - TrieHttpRouter